[GitHub] [cloudstack-primate] PaulAngus commented on issue #487: [BUG] Backup tab is shown when Backup Framework is not enabled

2020-07-04 Thread GitBox


PaulAngus commented on issue #487:
URL: 
https://github.com/apache/cloudstack-primate/issues/487#issuecomment-653849107


   A release blocker is an issue that must be fixed prior to a release.  
therefore blocker is the correct category.
   
   Requiring the operator to hide the feature is not acceptable.  the 
kubernetes plugin tab is only visible when the kubernetes plugin is enabled.  
The same should be true for the backup plugin.  The operator should not have to 
fix inadequacies in ACS code.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack-primate] rhtyd merged pull request #235: Compute > Instances - Missing extended search functionality

2020-07-04 Thread GitBox


rhtyd merged pull request #235:
URL: https://github.com/apache/cloudstack-primate/pull/235


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack-primate] rhtyd commented on pull request #235: Compute > Instances - Missing extended search functionality

2020-07-04 Thread GitBox


rhtyd commented on pull request #235:
URL: 
https://github.com/apache/cloudstack-primate/pull/235#issuecomment-653847681


   LGTM tested as root admin, normal user



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack-primate] rhtyd commented on issue #485: [BUG] Actions for projects visible to users

2020-07-04 Thread GitBox


rhtyd commented on issue #485:
URL: 
https://github.com/apache/cloudstack-primate/issues/485#issuecomment-653833774


   cc @Pearl1594 does your project-roles PR cover this - let's discuss thanks.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack-primate] rhtyd commented on issue #485: [BUG] Actions for projects visible to users

2020-07-04 Thread GitBox


rhtyd commented on issue #485:
URL: 
https://github.com/apache/cloudstack-primate/issues/485#issuecomment-653833552


   Critical added, while no functionality is broken users shouldn't see button 
they're not authorised to press/see.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack-primate] rhtyd edited a comment on issue #487: [BUG] Backup tab is shown when Backup Framework is not enabled

2020-07-04 Thread GitBox


rhtyd edited a comment on issue #487:
URL: 
https://github.com/apache/cloudstack-primate/issues/487#issuecomment-653832217


   With @davidjumani 
   - Remove the view backup and vmsnapshot button via config::related for 
compute.js
   - Instead add tabs to the VM instance/detail component to show/hide both 
backup and vm snapshots (similar to the volumes, nics etc tabs) depending on 
user-role access and availability of feature
   
   @PaulAngus Lowering severity to Critical, we'll fix the issue for 1.0/GA but 
let's use blocker limited to issues where a feature is broken (i.e. does not 
work, than a visibility/usabilty issue)



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack-primate] rhtyd commented on issue #464: Complete user and dev documentation for 1.0/GA

2020-07-04 Thread GitBox


rhtyd commented on issue #464:
URL: 
https://github.com/apache/cloudstack-primate/issues/464#issuecomment-653833479


   Added blocker as GA/1.0 release cannot go without docs



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack-primate] rhtyd edited a comment on issue #491: [BUG] The Create Instance wizard should have an 'Advanced section' to make requirements clear

2020-07-04 Thread GitBox


rhtyd edited a comment on issue #491:
URL: 
https://github.com/apache/cloudstack-primate/issues/491#issuecomment-653833269


   Needs further discussion: cc @davidjumani 
   
   - 'Affinity groups' is already in its own step, the sequence/step is same as 
old UI's wizard after compute and disk offering, we probably can move it at the 
end?
   ![Screenshot from 2020-07-05 
07-42-14](https://user-images.githubusercontent.com/95203/86524053-395baa00-be93-11ea-88b1-14e149890150.png)
   
   - 'root disk size': already tracked by another ticket, refer/discuss #490 
   
   - The following are exactly as in the legacy UI and shown/asked in the last 
step. The keyboard option is still used to set the default keymap for 
VMware/vnc config for VM 
(https://github.com/apache/cloudstack/blob/master/vmware-base/src/main/java/com/cloud/hypervisor/vmware/util/VmwareHelper.java#L576)
 if not in CloudStack console proxy/popup. Possibly we can add a 2nd last step 
to say 'Advanced Configuration' for the following? However, userdata has been 
there for years and may not be an advanced setting? Should the advanced step be 
visible to normal users?
   ```
   'Boot type'
   'boot into hardware setup'
   'boot mode'
   'keyboard language' (as redundant with novnc console)
   'userdata'
   ```
   
   - For each step we probably want to add an information (a (i) icon) that 
shows popover help doc (like other forms) to either explain the step or a 
specific form-item in the step using translation keys `$tr(...`
   
   Screenshots for reference:
   ![Screenshot from 2020-07-05 
07-49-24](https://user-images.githubusercontent.com/95203/86524121-21d0f100-be94-11ea-9c64-083ccdd465f0.png)
   ![Screenshot from 2020-07-05 
07-49-38](https://user-images.githubusercontent.com/95203/86524123-239ab480-be94-11ea-803a-72a5fe66a830.png)
   
   We'll fix this for 1.0, but given the VM deployment feature/functionality is 
not broken but is the steps/form items are same as old UI I've lowered severity 
to Major.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack-primate] rhtyd commented on issue #491: [BUG] The Create Instance wizard should have an 'Advanced section' to make requirements clear

2020-07-04 Thread GitBox


rhtyd commented on issue #491:
URL: 
https://github.com/apache/cloudstack-primate/issues/491#issuecomment-653833269


   Needs further discussion: cc @davidjumani 
   
   - 'Affinity groups' is already in its own step, the sequence/step is same as 
old UI's wizard after compute and disk offering, we probably can move it at the 
end?
   ![Screenshot from 2020-07-05 
07-42-14](https://user-images.githubusercontent.com/95203/86524053-395baa00-be93-11ea-88b1-14e149890150.png)
   
   - 'root disk size': already tracked by another ticket, best case we may h is 
still used in backend while setting the 
is still used in backend while setting the 
   ide it if not applicable and perform size related validation; hide it by 
default (i.e. ask user for explicit override option by providing a switch)
   
   - The following are same as in the legacy UI asked at the last step. The 
keyboard option is still used to set the default keymap for VMware/vnc config 
for VM 
(https://github.com/apache/cloudstack/blob/master/vmware-base/src/main/java/com/cloud/hypervisor/vmware/util/VmwareHelper.java#L576)
 if not in CloudStack console proxy/popup. Possibly we can add a 2nd last step 
to say 'Advanced Configuration' for the following? However, userdata has been 
there for years and may not be an advanced setting? Should the advanced step be 
visible to normal users?
   ```
   'Boot type'
   'boot into hardware setup'
   'boot mode'
   'keyboard language' (as redundant with novnc console)
   'userdata'
   ```
   
   - For each step we probably want to add an information (a (i) icon) that 
shows popover help doc (like other forms) to either explain the step or a 
specific form-item in the step using translation keys `$tr(...`
   
   Screenshots for reference:
   ![Screenshot from 2020-07-05 
07-49-24](https://user-images.githubusercontent.com/95203/86524121-21d0f100-be94-11ea-9c64-083ccdd465f0.png)
   ![Screenshot from 2020-07-05 
07-49-38](https://user-images.githubusercontent.com/95203/86524123-239ab480-be94-11ea-803a-72a5fe66a830.png)
   
   We'll fix this for 1.0, but given the VM deployment feature/functionality is 
not broken but is the steps/form items are same as old UI I've lowered severity 
to Major.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack-primate] rhtyd edited a comment on issue #490: [BUG] Create VM Form - root disk size dialog is misleading

2020-07-04 Thread GitBox


rhtyd edited a comment on issue #490:
URL: 
https://github.com/apache/cloudstack-primate/issues/490#issuecomment-653832405


   With @davidjumani 
   - listTemplates returns `size` check and use that to validate root disk size 
(must be equal to or greater than template size/physical size)
   - Remove slider, keep it simply a number input
   - Perhaps discuss and add a switch to say override root disk size and then 
show the label/input (i.e. don't show it by default, a toggle/switch shows the 
input)
   
   Except for the slider part, the UX and feature is exactly like the old UI; 
lowered priority to Major.
   Last time I tested the feature is supported all KVM, VMware (maybe only scsi 
root disks) and XenServer, @davidjumani please also explore if it's possible to 
evaluate if we should show the option for specific template/hypervisor 
combination?



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack-primate] rhtyd commented on issue #490: [BUG] Create VM Form - root disk size dialog is misleading

2020-07-04 Thread GitBox


rhtyd commented on issue #490:
URL: 
https://github.com/apache/cloudstack-primate/issues/490#issuecomment-653832405


   With @davidjumani 
   - listTemplates returns `size` check and use that to validate root disk size 
(must be equal to or greater than template size/physical size)
   - Remove slider, keep it simply a number input
   - Perhaps discuss and add a switch to say override root disk size and then 
show the label/input (i.e. don't show it by default, a toggle/switch shows the 
input)



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack-primate] rhtyd commented on issue #487: [BUG] Backup tab is shown when Backup Framework is not enabled

2020-07-04 Thread GitBox


rhtyd commented on issue #487:
URL: 
https://github.com/apache/cloudstack-primate/issues/487#issuecomment-653832217


   With @davidjumani 
   - Remove the view backup and vmsnapshot button via config::related for 
compute.js
   - Instead add tabs to the VM instance/detail component to show/hide both 
backup and vm snapshots (similar to the volumes, nics etc tabs) depending on 
user-role access and availability of feature
   
   @PaulAngus Lowering severity to Major, we'll fix the issue for 1.0/GA but 
let's use blocker limited to issues where a feature is broken (i.e. does not 
work, than a visibility/usabilty issue)



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack-primate] rhtyd commented on issue #488: [BUG] 'Expunging' VM Snapshots show in the UI

2020-07-04 Thread GitBox


rhtyd commented on issue #488:
URL: 
https://github.com/apache/cloudstack-primate/issues/488#issuecomment-653832012


   I tested this is not a UI issue but a potential cleanup/GC issue, I've 
logged an issue here instead https://github.com/apache/cloudstack/issues/4201
   Legacy UI shows the same:
   ![Screenshot from 2020-07-05 
07-26-37](https://user-images.githubusercontent.com/95203/86523916-2ea01580-be91-11ea-9935-3686b62023f1.png)
   
   Primate screenshots as admin and normal user:
   ![Screenshot from 2020-07-05 
07-25-39](https://user-images.githubusercontent.com/95203/86523914-2cd65200-be91-11ea-87be-4f4bec07f1c1.png)
   ![Screenshot from 2020-07-05 
07-26-18](https://user-images.githubusercontent.com/95203/86523915-2e077f00-be91-11ea-9909-b81c83e70ed0.png)
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack-primate] rhtyd closed issue #488: [BUG] 'Expunging' VM Snapshots show in the UI

2020-07-04 Thread GitBox


rhtyd closed issue #488:
URL: https://github.com/apache/cloudstack-primate/issues/488


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack-primate] rhtyd closed issue #489: [BUG] The default number of entries in the data/table view (10) is a waste of screen space and frustrating

2020-07-04 Thread GitBox


rhtyd closed issue #489:
URL: https://github.com/apache/cloudstack-primate/issues/489


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack-primate] rhtyd edited a comment on issue #489: [BUG] The default number of entries in the data/table view (10) is a waste of screen space and frustrating

2020-07-04 Thread GitBox


rhtyd edited a comment on issue #489:
URL: 
https://github.com/apache/cloudstack-primate/issues/489#issuecomment-653831515


   We had this initially set to 20 to match old UI, then 15 previously and we 
set this to 10 after getting complains from HD/laptop users which may not have 
FHD/4K displays. The best strategy I can come up with is to set the default 
pagesize based on screen types; for mobile/table users keep it to 10 by default 
and for desktop users keep it to 20 by default.
   
   Screenshots:
   FHD (1920x1020)
   ![Screenshot from 2020-07-05 
07-15-58](https://user-images.githubusercontent.com/95203/86523823-cdc40d80-be8f-11ea-8d5b-d17bdfbe97ed.png)
   Laptop/tablet user:
   ![Screenshot from 2020-07-05 
07-16-54](https://user-images.githubusercontent.com/95203/86523824-cf8dd100-be8f-11ea-8d39-8f45676b0b5b.png)
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack-primate] rhtyd commented on issue #489: [BUG] The default number of entries in the data/table view (10) is a waste of screen space and frustrating

2020-07-04 Thread GitBox


rhtyd commented on issue #489:
URL: 
https://github.com/apache/cloudstack-primate/issues/489#issuecomment-653831515


   We had this initially set to 20 to match old UI, then 15 previously and we 
set this to 10 after getting complains from laptop users which may not have 
FHD/4K displays. The best strategy I can come up with is to set the default 
pagesize based on screen types; for mobile/table users keep it to 10 by default 
and for desktop users keep it to 20 by default.
   
   Screenshots:
   FHD (1920x1020)
   ![Screenshot from 2020-07-05 
07-15-58](https://user-images.githubusercontent.com/95203/86523823-cdc40d80-be8f-11ea-8d5b-d17bdfbe97ed.png)
   Laptop/tablet user:
   ![Screenshot from 2020-07-05 
07-16-54](https://user-images.githubusercontent.com/95203/86523824-cf8dd100-be8f-11ea-8d39-8f45676b0b5b.png)
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack-primate] rhtyd closed issue #486: Group actions don't work with custom components

2020-07-04 Thread GitBox


rhtyd closed issue #486:
URL: https://github.com/apache/cloudstack-primate/issues/486


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack-primate] blueorangutan commented on pull request #235: Compute > Instances - Missing extended search functionality

2020-07-04 Thread GitBox


blueorangutan commented on pull request #235:
URL: 
https://github.com/apache/cloudstack-primate/pull/235#issuecomment-653791161


   Packaging result: :heavy_check_mark:centos :heavy_check_mark:debian 
:heavy_check_mark:archive.
   QA: http://primate-qa.cloudstack.cloud:8080/client/pr/235 (JID-2209)



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack-primate] blueorangutan commented on pull request #472: Fixing permission issues

2020-07-04 Thread GitBox


blueorangutan commented on pull request #472:
URL: 
https://github.com/apache/cloudstack-primate/pull/472#issuecomment-653791159


   Packaging result: :heavy_check_mark:centos :heavy_check_mark:debian 
:heavy_check_mark:archive.
   QA: http://primate-qa.cloudstack.cloud:8080/client/pr/472 (JID-2210)



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack-primate] blueorangutan commented on pull request #472: Fixing permission issues

2020-07-04 Thread GitBox


blueorangutan commented on pull request #472:
URL: 
https://github.com/apache/cloudstack-primate/pull/472#issuecomment-653790323


   @rhtyd a Jenkins job has been kicked to build primate packages. I'll keep 
you posted as I make progress.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack-primate] blueorangutan commented on pull request #235: Compute > Instances - Missing extended search functionality

2020-07-04 Thread GitBox


blueorangutan commented on pull request #235:
URL: 
https://github.com/apache/cloudstack-primate/pull/235#issuecomment-653790289


   @rhtyd a Jenkins job has been kicked to build primate packages. I'll keep 
you posted as I make progress.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack-primate] rhtyd commented on pull request #235: Compute > Instances - Missing extended search functionality

2020-07-04 Thread GitBox


rhtyd commented on pull request #235:
URL: 
https://github.com/apache/cloudstack-primate/pull/235#issuecomment-653790202


   @blueorangutan package



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack-primate] rhtyd commented on pull request #472: Fixing permission issues

2020-07-04 Thread GitBox


rhtyd commented on pull request #472:
URL: 
https://github.com/apache/cloudstack-primate/pull/472#issuecomment-653790167


   @blueorangutan package



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack-primate] rhtyd commented on issue #492: Error when renaming a template

2020-07-04 Thread GitBox


rhtyd commented on issue #492:
URL: 
https://github.com/apache/cloudstack-primate/issues/492#issuecomment-653789838


   Thanks for reporting @gaaray2k I could reproduce and fix the issue



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack-primate] rhtyd closed issue #492: Error when renaming a template

2020-07-04 Thread GitBox


rhtyd closed issue #492:
URL: https://github.com/apache/cloudstack-primate/issues/492


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack-primate] gaaray2k opened a new issue #492: Error when renaming a template

2020-07-04 Thread GitBox


gaaray2k opened a new issue #492:
URL: https://github.com/apache/cloudstack-primate/issues/492


   I get the error message below when I try to rename a template from a non 
admin account. I guess the UI is trying to set the routing parameter although I 
am not selecting it. just wanted to let you guys know in case you didnt know 
already.
   
   
   
   request failed(531)
   Parameter isrouting can only be specified by a Root Admin, permission denied



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack-primate] PaulAngus opened a new issue #491: [BUG] The Create Instance wizard should have an 'Advanced section' to make requirements clear

2020-07-04 Thread GitBox


PaulAngus opened a new issue #491:
URL: https://github.com/apache/cloudstack-primate/issues/491


   **Describe the bug**
   
   The Create Instance wizard should have a number of options moved to an 
optional 'Advanced' section, their existence in the 'main flow' is confusing 
even to experienced users, deployment would be near impossible for new users.
   
   **To Reproduce**
   
Example:  What should a user enter for 'root disk size'  (link to #490 )
   
   **Expected behavior**
   
   The following should be in a clearly optional advanced section.
   'root disk size'
   'Affinity groups'
   'Boot type'
   'boot into hardware setup'
   'boot mode'
   'keyboard language' (as redundant with novnc console)
   'userdata'
   
   
   **Screenshots**
   If applicable, add screenshots to help explain your problem.
   
   **Desktop (please complete the following information):**
- OS: [e.g. Windows, Mac, iOS, Android with device/screen details if 
applicable]
- Browser [e.g. chrome, safari]
- Version [e.g. 22]
   
   **Additional context**
   Add any other context about the problem here.
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack-primate] PaulAngus opened a new issue #490: [BUG] Create VM Form - root disk size dialog is misleading

2020-07-04 Thread GitBox


PaulAngus opened a new issue #490:
URL: https://github.com/apache/cloudstack-primate/issues/490


   **Describe the bug**
   
   The implementation of the root disk slider suggests that the user MUST set a 
root disk size. This has two problems:
   
   1. This is not the case and setting a root disk size is conpletely optional 
and not always possible.
   2. User will not know the original root disk size, and setting a root disk 
size smaller than the original disk will fail the deployment.
   
   **To Reproduce**
   Steps to reproduce the behavior:
   
   1. Log in as: User
   2. Go to 'Create Instance'
   3. Select any zone
   4. See Root disk slider
   
   **Expected behavior**
   
   A clear indication that this is optional is required.
   
   **Screenshots**
   
   
![image](https://user-images.githubusercontent.com/4810220/86509967-deb74500-bde3-11ea-81b7-69ea9f5f1aa5.png)
   
   **Desktop (please complete the following information):**
- OS: [e.g. Windows, Mac, iOS, Android with device/screen details if 
applicable]
- Browser [e.g. chrome, safari]
- Version [e.g. 22]
   
   **Additional context**
   Add any other context about the problem here.
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack-primate] PaulAngus opened a new issue #489: [BUG] The default number of entries in the data/table view (10) is a waste of screen space and frustrating

2020-07-04 Thread GitBox


PaulAngus opened a new issue #489:
URL: https://github.com/apache/cloudstack-primate/issues/489


   **Describe the bug**
   
   [Ack: as much usability as a bug]
   
   EVERYTIME i use primate I have to change the number of items displayed to 
make reasonable use of screen space.
   It quickly becomes frustating.
   
   Some experiementation shows that a default around 17 suits most display 
screens.   15 is 'safe' but still often leaves quite a bit of empty screen 
space.
   
   **To Reproduce**
   Log in and goto any screen where you have more than 10 entities.
   
   **Expected behavior**
   
   'Better' use of available screen area.
   
   dynamically setting the initial number of items to match the screen size 
would be most awesome, but failing that, a better default is desirable.
   
   **Screenshots**
   
   
![image](https://user-images.githubusercontent.com/4810220/86509626-41f3a800-bde1-11ea-86f7-44d38e3b4bbe.png)
   
   **Desktop (please complete the following information):**
- OS: [e.g. Windows, Mac, iOS, Android with device/screen details if 
applicable]
- Browser [e.g. chrome, safari]
- Version [e.g. 22]
   
   **Additional context**
   Add any other context about the problem here.
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack-primate] PaulAngus opened a new issue #488: [BUG] 'Expunging' VM Snapshots show in the UI

2020-07-04 Thread GitBox


PaulAngus opened a new issue #488:
URL: https://github.com/apache/cloudstack-primate/issues/488


   **Describe the bug**
   A clear and concise description of what the bug is.
   
   **To Reproduce**
   Steps to reproduce the behavior:
   
   Pre-req:
   VM snaphot in expunging state must exist.
   
   1. Go to 'storage' > 'VM Snapshots'
   2. See error
   
   **Expected behavior**
   
   VMs in 'Expunging' state are not expected to be seen.
   
   **Screenshots**
   
   
![image](https://user-images.githubusercontent.com/4810220/86508715-2f29a500-bdda-11ea-8db7-9bf791bd0c19.png)
   
   **Desktop (please complete the following information):**
- OS: [e.g. Windows, Mac, iOS, Android with device/screen details if 
applicable]
- Browser [e.g. chrome, safari]
- Version [e.g. 22]
   
   **Additional context**
   Add any other context about the problem here.
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack-primate] PaulAngus opened a new issue #487: [BUG] Backup tab is shown when Backup Framework is not enabled

2020-07-04 Thread GitBox


PaulAngus opened a new issue #487:
URL: https://github.com/apache/cloudstack-primate/issues/487


   **Describe the bug**
   
   A 'Backup' tab is shown under storage when the Backup Framework has not been 
enabled.  This will cause many 'support calls' when users want try to create 
backups.
   
   **To Reproduce**
   Steps to reproduce the behavior:
   1. Ensure backup framework is not enabled
   2. Click on 'Storage' tab
   4. See error
   
   **Expected behavior**
   
   The backup tab should not be visible as the backup framework is not enabled.
   
   **Screenshots**
   
   
![image](https://user-images.githubusercontent.com/4810220/86508620-68ade080-bdd9-11ea-8296-356b1c32797f.png)
   
   
   **Desktop (please complete the following information):**
- OS: [e.g. Windows, Mac, iOS, Android with device/screen details if 
applicable]
- Browser [e.g. chrome, safari]
- Version [e.g. 22]
   
   **Additional context**
   Add any other context about the problem here.
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack-primate] rhtyd commented on pull request #454: autogenview: store API parameters as router query for history

2020-07-04 Thread GitBox


rhtyd commented on pull request #454:
URL: 
https://github.com/apache/cloudstack-primate/pull/454#issuecomment-653733068


   Hold-on merging this, we may need more tests.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack-primate] rhtyd commented on pull request #458: Adding quick-view options to list view

2020-07-04 Thread GitBox


rhtyd commented on pull request #458:
URL: 
https://github.com/apache/cloudstack-primate/pull/458#issuecomment-653732948


   Subjective/TBD - should we show labels for actions like legacy UI; should 
the quick view be in a pop/hover-over menu component? Or an icon you click (say 
the 3-dot icon, similar to chrome, android and other UXs) which shows the 
quick-view



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack-primate] rhtyd commented on issue #475: [BUG] Many screens show Account and Domain to non-root admins when they should not.

2020-07-04 Thread GitBox


rhtyd commented on issue #475:
URL: 
https://github.com/apache/cloudstack-primate/issues/475#issuecomment-653732686


   @PaulAngus 
   - The issue is subjective and I've advised already to start a discussion on 
dev/user ML
   - Ultimately if the API response is fixed no changes in Primate will be 
required, you've agreed it's an API issue
   - See my previous comments and 
http://cloudstack.apache.org/api/apidocs-4.14/apis/listAndSwitchSamlAccount.html,
 there are cases where a user may be allowed to switch between accounts/domains
   - You've agreed its redundant data which is not a bug; for backward 
compatibility with legacy UI we should not remove data from UI 
   
   As with any other reported issues, we close them when we have a PR merged or 
have established a resolution. In this case:
   - It's not an UI issue leaking account/domain information
   - The redundant data topic could be discussed on ML but it's not a bug



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack-primate] rhtyd closed issue #475: [BUG] Many screens show Account and Domain to non-root admins when they should not.

2020-07-04 Thread GitBox


rhtyd closed issue #475:
URL: https://github.com/apache/cloudstack-primate/issues/475


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack-primate] blueorangutan commented on pull request #454: autogenview: store API parameters as router query for history

2020-07-04 Thread GitBox


blueorangutan commented on pull request #454:
URL: 
https://github.com/apache/cloudstack-primate/pull/454#issuecomment-653732239


   Packaging result: :heavy_check_mark:centos :heavy_check_mark:debian 
:heavy_check_mark:archive.
   QA: http://primate-qa.cloudstack.cloud:8080/client/pr/454 (JID-2205)



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack-primate] PaulAngus commented on issue #475: [BUG] Many screens show Account and Domain to non-root admins when they should not.

2020-07-04 Thread GitBox


PaulAngus commented on issue #475:
URL: 
https://github.com/apache/cloudstack-primate/issues/475#issuecomment-653731010


   A user can only be logged into one account at a time and therefore still one 
only see their own account and domain.  therefore we are still showing 
redundant data 
   
   also it is offensive to close someone else's issue without their consent.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org