[GitHub] [cloudstack-go] mlsorensen opened a new pull request, #46: Generate account details correctly (accountdetails[0].somekey=someval)

2023-03-02 Thread via GitHub


mlsorensen opened a new pull request, #46:
URL: https://github.com/apache/cloudstack-go/pull/46

   When creating or updating accounts using the API, the parameters are 
expected to be in format:
   
   ```
   accountdetails[0].somekey=someval
   ```
   
   not
   
   ```
   accountdetails[0].key=somekey
   accountdetails[0].value=someval
   ```
   
   Since `accountdetails` is handled via `default`, I'm using the 
`detailsRequireZeroIndex` list to ensure we don't make this change broad. Any 
other APIs that require this format can just be added to 
`detailsRequireZeroIndex` as we identify them, rather than making a sweeping 
change.
   
   I don't know what's up with the change in comment on the delete calls... 
possibly a change that wasn't properly committed earlier.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [cloudstack-documentation] blueorangutan commented on pull request #306: Add Secure KVM Console Access documentation

2023-03-02 Thread via GitHub


blueorangutan commented on PR #306:
URL: 
https://github.com/apache/cloudstack-documentation/pull/306#issuecomment-1451992339

   QA-Doc build preview: https://qa.cloudstack.cloud/builds/docs-build/pr/306. 
(QA-JID 59)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [cloudstack-documentation] blueorangutan commented on pull request #306: Add Secure KVM Console Access documentation

2023-03-02 Thread via GitHub


blueorangutan commented on PR #306:
URL: 
https://github.com/apache/cloudstack-documentation/pull/306#issuecomment-1451991062

   @nvazquez a Jenkins job has been kicked to build the document. I'll keep you 
posted as I make progress.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [cloudstack-documentation] nvazquez commented on pull request #306: Add Secure KVM Console Access documentation

2023-03-02 Thread via GitHub


nvazquez commented on PR #306:
URL: 
https://github.com/apache/cloudstack-documentation/pull/306#issuecomment-1451990029

   @blueorangutan docbuild


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [cloudstack-documentation] nvazquez opened a new pull request, #306: Add Secure KVM Console Access documentation

2023-03-02 Thread via GitHub


nvazquez opened a new pull request, #306:
URL: https://github.com/apache/cloudstack-documentation/pull/306

   Secure KVM Console Access documentation:
   
   PR: https://github.com/apache/cloudstack/pull/7015 and a quick note about 
the bug fix: https://github.com/apache/cloudstack/pull/7304


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [cloudstack-cloudmonkey] borisstoyanov commented on issue #118: associatednetworkid= does not autocomplete

2023-03-02 Thread via GitHub


borisstoyanov commented on issue #118:
URL: 
https://github.com/apache/cloudstack-cloudmonkey/issues/118#issuecomment-1451776100

   @DaanHoogland can this correlate with #72 then? 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [cloudstack-cloudmonkey] rohityadavcloud commented on pull request #127: vendor: update vendor and gomod

2023-03-02 Thread via GitHub


rohityadavcloud commented on PR #127:
URL: 
https://github.com/apache/cloudstack-cloudmonkey/pull/127#issuecomment-1451676496

   The regression this fixes is the parameter autocompletion, where it includes 
resource name as in:
   ```
   templateid=99bcd10d-eaa4-4ad6-8169-7cf204fbc0b3 (Rocky 9 x64)
   ```
   
   With this fix, the autocompletion ignores the stuff starting with 
parenthesis:
   ```
   templateid=99bcd10d-eaa4-4ad6-8169-7cf204fbc0b3
   ```
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [cloudstack-cloudmonkey] borisstoyanov commented on pull request #127: vendor: update vendor and gomod

2023-03-02 Thread via GitHub


borisstoyanov commented on PR #127:
URL: 
https://github.com/apache/cloudstack-cloudmonkey/pull/127#issuecomment-1451643839

   +1 will test it out quickly and merge


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [cloudstack-cloudmonkey] rohityadavcloud commented on pull request #127: vendor: update vendor and gomod

2023-03-02 Thread via GitHub


rohityadavcloud commented on PR #127:
URL: 
https://github.com/apache/cloudstack-cloudmonkey/pull/127#issuecomment-1451600358

   Regression fixed (reverted following) + go mod updates:
   https://user-images.githubusercontent.com/95203/222395384-86391393-e65a-4b07-a008-5c35e9c99810.png;>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [cloudstack-cloudmonkey] rohityadavcloud opened a new pull request, #127: vendor: update vendor and gomod

2023-03-02 Thread via GitHub


rohityadavcloud opened a new pull request, #127:
URL: https://github.com/apache/cloudstack-cloudmonkey/pull/127

   Revert changes from previous commit on
   vendor/github.com/chzyer/readline/complete.go


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [cloudstack-cloudmonkey] DaanHoogland commented on issue #125: Provide "NOT" option when querying with cmk

2023-03-02 Thread via GitHub


DaanHoogland commented on issue #125:
URL: 
https://github.com/apache/cloudstack-cloudmonkey/issues/125#issuecomment-1451580113

   I think this is most definately an API request and not a cmk one. If to be 
implemented in cmk it would be part of an extension on the filter option. There 
is anothe request for the filter option open (also a larger feature)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [cloudstack-cloudmonkey] alexandremattioli commented on issue #118: associatednetworkid= does not autocomplete

2023-03-02 Thread via GitHub


alexandremattioli commented on issue #118:
URL: 
https://github.com/apache/cloudstack-cloudmonkey/issues/118#issuecomment-1451567175

   @borisstoyanov  it actually should list just the networks available, so 
network being created can be associated to one of them. It's just a "list 
networks"


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [4.18][RELEASE] RC2 up for vote

2023-03-02 Thread Rohit Yadav
Thanks Daan, looking at the outstanding issues/PRs list here are some 
suggestions that you can help triage and include in RC3:

https://github.com/apache/cloudstack/pull/7302
https://github.com/apache/cloudstack/pull/7304
https://github.com/apache/cloudstack/pull/7268 (needs manual QA/regression test)
https://github.com/apache/cloudstack/pull/7291 (needs manual QA/regression test)
https://github.com/apache/cloudstack/pull/7237 (PR author to advise if this is 
critical?)
https://github.com/apache/cloudstack/pull/7229 (not sure if this causes a 
critical billing/usage issue?)


Regards.


From: Daan Hoogland 
Sent: Thursday, March 2, 2023 14:31
To: dev@cloudstack.apache.org 
Cc: users ; PMC 
Subject: Re: [4.18][RELEASE] RC2 up for vote

unfortunately I am -1 myself :(

Last night Marcus and Wei explored a security issue in the new feature of
volume encryption. A fix is underway. I will create an RC3 asap.
Please reply here with any other critical issues you want included in the
next release candidate?

regard,

On Wed, Mar 1, 2023 at 5:29 PM Vladimir Petrov <
vladimir.pet...@shapeblue.com> wrote:

> Hi all,
>
> +1, I tested different upgrades (from 4.15, 4.16 and 4.17 using different
> hypervisors) and the common operations and found no issues.
>
> Best wishes,
> Vladi
>
>
>
> Daan Hoogland wrote:
>
>
> Hi All,
> some small errata,
> - I added my key
> - I will keep this vote open till friday, we've had a weekend and being
> lenient on those 72 hours will not hurt the quality, I think.
> It has taken some time but;
>
> I've created a second 4.18.0.0 release candidate, with the following
> artifacts up for a vote:
>
> Git Branch and Commit
> SH:
> https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;a=shortlog;h=refs/heads/4.18.0.0-RC20230224T1301
> Commit: 77961d6aa583a347b289af4cbb732b77c8be8ebe
>
> Source release (checksums and signatures are available at the following
> location):https://dist.apache.org/repos/dist/dev/cloudstack/4.18.0.0/
>
> PGP release keys (signed using
> 256ABDFB8D89EDE07540BE6ACEF9E802B86FEED4):
> https://dist.apache.org/repos/dist/release/cloudstack/KEYS
>
> Vote will be open for at least 72 hours.
>
> For sanity in tallying the vote, can PMC members please be sure to
> indicate "(binding)" with their vote?
>
> [ ] +1  approve
> [ ] +0  no opinion
> [ ] -1  disapprove (and reason why)
>
>
>
>

--
Daan

 



[GitHub] [cloudstack-cloudmonkey] borisstoyanov commented on issue #118: associatednetworkid= does not autocomplete

2023-03-02 Thread via GitHub


borisstoyanov commented on issue #118:
URL: 
https://github.com/apache/cloudstack-cloudmonkey/issues/118#issuecomment-1451527203

   @alexandremattioli can you give an example prompt with cmk please. From what 
I see you want it to look for associatednetworkid, but there is no such API 
listAssociatedNetworks, so I think this improvement is not achievable at the 
moment? 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [4.18][RELEASE] RC2 up for vote

2023-03-02 Thread Daan Hoogland
unfortunately I am -1 myself :(

Last night Marcus and Wei explored a security issue in the new feature of
volume encryption. A fix is underway. I will create an RC3 asap.
Please reply here with any other critical issues you want included in the
next release candidate?

regard,

On Wed, Mar 1, 2023 at 5:29 PM Vladimir Petrov <
vladimir.pet...@shapeblue.com> wrote:

> Hi all,
>
> +1, I tested different upgrades (from 4.15, 4.16 and 4.17 using different
> hypervisors) and the common operations and found no issues.
>
> Best wishes,
> Vladi
>
>
>
> Daan Hoogland wrote:
>
>
> Hi All,
> some small errata,
> - I added my key
> - I will keep this vote open till friday, we've had a weekend and being
> lenient on those 72 hours will not hurt the quality, I think.
> It has taken some time but;
>
> I've created a second 4.18.0.0 release candidate, with the following
> artifacts up for a vote:
>
> Git Branch and Commit
> SH:
> https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;a=shortlog;h=refs/heads/4.18.0.0-RC20230224T1301
> Commit: 77961d6aa583a347b289af4cbb732b77c8be8ebe
>
> Source release (checksums and signatures are available at the following
> location):https://dist.apache.org/repos/dist/dev/cloudstack/4.18.0.0/
>
> PGP release keys (signed using
> 256ABDFB8D89EDE07540BE6ACEF9E802B86FEED4):
> https://dist.apache.org/repos/dist/release/cloudstack/KEYS
>
> Vote will be open for at least 72 hours.
>
> For sanity in tallying the vote, can PMC members please be sure to
> indicate "(binding)" with their vote?
>
> [ ] +1  approve
> [ ] +0  no opinion
> [ ] -1  disapprove (and reason why)
>
>
>
>

-- 
Daan


[GitHub] [cloudstack-cloudmonkey] borisstoyanov commented on issue #126: Allow for CTRL-C to break the current operation

2023-03-02 Thread via GitHub


borisstoyanov commented on issue #126:
URL: 
https://github.com/apache/cloudstack-cloudmonkey/issues/126#issuecomment-1451514664

   I've tested it out and it terminates the current cmk process (of course not 
in Cloudstack), it's hanging or being non-responsive in any way:
   ```
   (localcloud)  > deploy virtualmachine 
templateid=3a679274-b810-11ed-94bb-1e00b200017a 
serviceofferingid=14820797-8235-414b-9df7-1c94c997c74d 
zoneid=26510f0c-a5ec-4d7e-aa78-e2fde4178ca0
   ⣯  polling for async API result ^C
   [root@ref-trl-4577-k-Mr8-boris-stoyanov-mgmt1 ~]#
   
   (localcloud)  > list events
   ^C
   [root@ref-trl-4577-k-Mr8-boris-stoyanov-mgmt1 ~]#
   
   
   ```
   
   The issue is that it kills cmk but not the api call, is this what you're 
after @serverchief ? 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [cloudstack-cloudmonkey] borisstoyanov commented on issue #117: filter is ignored on e.g. deploy virtual machine

2023-03-02 Thread via GitHub


borisstoyanov commented on issue #117:
URL: 
https://github.com/apache/cloudstack-cloudmonkey/issues/117#issuecomment-1451505946

   @DaanHoogland to look for exact estimate and come back


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [cloudstack-cloudmonkey] borisstoyanov commented on pull request #112: Enable passing of profile information via commandline

2023-03-02 Thread via GitHub


borisstoyanov commented on PR #112:
URL: 
https://github.com/apache/cloudstack-cloudmonkey/pull/112#issuecomment-1451481473

   probably Fixes: #104 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org