[GitHub] [cloudstack-cloudmonkey] Pearl1594 commented on pull request #140: Convert GET to POST requests
Pearl1594 commented on PR #140: URL: https://github.com/apache/cloudstack-cloudmonkey/pull/140#issuecomment-1672922905 @weizhouapache @rohityadavcloud I was just testing to see if there is any issue with using POST for all commands. Hence raised this draft PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[DISCUSS] Fixing npm version for building UI
All, Our UI building in packages/PRs uses npm v14, while the current LTS version is v18. However, since we use npm for only development and building the UI statically there are hopefully no concerns around security and support. I've been using both v14 and v16 to build UI across different branches that haven't EOL'd. With npm v16 and ACS 4.18, I'm not able to npm install and npm run serve without the following: export NODE_OPTIONS=--openssl-legacy-provider npm also is trying to change the package-lock file with a new format, considering this should we consider moving to support the latest LTS (v18) or switch to another UI pkg building tool (such as yarn)? Thoughts? Regards.
[GitHub] [cloudstack-cloudmonkey] rohityadavcloud commented on pull request #140: Convert GET to POST requests
rohityadavcloud commented on PR #140: URL: https://github.com/apache/cloudstack-cloudmonkey/pull/140#issuecomment-1672806226 @Pearl1594 you probably don't want to do this as a default, we need to check if mgmt server logs API requests when things are POST-ed. You can probably add conditionals for new user-data related APIs. @hrak did you face issues when using the deploy VM API or other user-data related APIs? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
