[GitHub] [cloudstack-go] vishesh92 commented on pull request #71: Fix apis for InfrastructureUsageService
vishesh92 commented on PR #71: URL: https://github.com/apache/cloudstack-go/pull/71#issuecomment-1689937657 @rohityadavcloud Please review. Also need another rc release after this PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-go] vishesh92 opened a new pull request, #71: Fix apis for InfrastructureUsageService
vishesh92 opened a new pull request, #71: URL: https://github.com/apache/cloudstack-go/pull/71 This PR fixes the json key for APIs under InfrastructureUsageService and adds more types for `double[]`, `long[]`, and `string[]`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [Consultation] Remove DB HA feature (db.ha.enabled)
Thanks João, Daniel, I see João's PR - I'm not keen on getting the mysql-ha plugin removed if it can be improved/fixed. What users complain about is when it doesn't work or the documentation isn't clear about how to use it (or in fact have any MySQL HA plan for use with CloudStack). Regards. From: João Jandre Paraquetti Sent: Wednesday, August 23, 2023 01:26 To: us...@cloudstack.apache.org ; dev@cloudstack.apache.org Subject: Re: [Consultation] Remove DB HA feature (db.ha.enabled) Sure, Daniel PR #7895 is currently in draft as we need to do some more tests. However, the intention is to enable users to configure the DB connection URI directly through `db.properties` file. These are the tests that have been done so far with ACS without this PR changeset: Using the current version in a setup with MariaDB and Galera, with a cluster size of 3 and the following configuration on the db.properties file: ``` # High Availability And Cluster Properties db.ha.enabled=true db.ha.loadBalanceStrategy=com.cloud.utils.db.StaticStrategy # cloud stack Database db.cloud.replicas=192.168.201.161,192.168.201.162 db.cloud.autoReconnect=false db.cloud.failOverReadOnly=false db.cloud.reconnectAtTxEnd=false db.cloud.autoReconnectForPools=true db.cloud.secondsBeforeRetrySource=1800 db.cloud.queriesBeforeRetrySource=5000 db.cloud.initialTimeout=3600 ``` When the MariaDB service stops in the main node, ACS switches to one of the other two nodes. However, if the host is shut down, the switch never occurs. Then, we also did tests using the changes proposed in the PR, by configuring the db.cloud.uri: ``` db.cloud.uri=jdbc:mariadb:sequential://192.168.201.160:3306,192.168.201.161:3306,192.168.201.162:3306/cloud?autoReconnect=true=517=true=sql_mode='STRICT_TRANS_TABLES,NO_ZERO_IN_DATE,NO_ZERO_DATE,ERROR_FOR_DIVISION_BY_ZERO,NO_ENGINE_SUBSTITUTION'=UTC # These properties are ignored when setting the URI manually, so no need to set them. # High Availability And Cluster Properties # db.ha.enabled=true # db.ha.loadBalanceStrategy=com.cloud.utils.db.StaticStrategy # cloud stack Database # db.cloud.replicas=192.168.201.161,192.168.201.162 # db.cloud.autoReconnect=false # db.cloud.failOverReadOnly=false # db.cloud.reconnectAtTxEnd=false # db.cloud.autoReconnectForPools=true # db.cloud.secondsBeforeRetrySource=1800 # db.cloud.queriesBeforeRetrySource=5000 # db.cloud.initialTimeout=3600 ``` I was able to configure and use the sequential failover mode. This way, when the MariaDB service stops in the main node and even if the host is shut down, ACS is able to switch to the other DBs. There are two differences between defining the URI manually (which is proposed with PR#7895) and the generated by ACS. The first one is the `jdbc:mariadb`, which is the driver that makes the connection with the DBMS, this enables usage of MariaDB URL configurations, this driver is being introduced into ACS with PR#7895. The second one is the usage of the `sequential` [1] failover mode, that will try to connect to hosts in the order in which they were declared in the connection URL, so the first available host is used for all queries, and if one of the hosts is shut down, it will try to reconnect with the other on the list. As this mode only connects to a single DB, the problems referenced by Rohit are avoided. But the failover mechanism is still in place. Best regards, João Jandre [1] - https://mariadb.com/kb/en/about-mariadb-connector-j/ On 22/08/2023 16:03, Daniel Salvador wrote: > Hello Lucian and all, > > I am -1 on removing the whole DB HA feature from CloudStack. > > As we discussed on July[1], the current properties we have on > "db.properties" regarding DB HA are hardcoded and only address some MySQL > properties, which are not fully compatible with the properties for > configuring DB HA on MariaDB. It indeed has some problems; however, I think > we should keep the functionality and improve it, to enrich CloudStack and > avoid using other layers to accomplish the goals. It is good to have a > workaround, though. > > João Jandre and I are already working on a solution to flexibilize the DB > parameters in order to allow one to configure DB HA properly when using > MariaDB (and also do several other configurations). João, could you point > to the PR that addresses the changes and share the configurations and tests > we have done so far? > > Best regards, > Daniel Salvador (gutoveronezi) > > [1] - https://lists.apache.org/thread/j0mmwy9dfr9k2kbnnjxcr2m7y8zwd34c > > On Tue, Aug 22, 2023 at 12:42 PM Nux wrote: > >> New adopters may not go ahead with it in production because they won't >> get it working, unless they fix a lot of code, that would be a nice pull >> request. :) >> >> >> On 2023-08-22 16:25, K B Shiv Kumar wrote: >>> Well, if it is broken and it is not prominently mentioned anywhere new >>> adopters may go ahead with that on production. So I guess best to >>> remove or at least mention that it is not
Re: [PROPOSE] ACS 4.19.0.0 release
Thanks for the proposal Abhishek, sounds good to me. Looking forward to 4.19! Regards. From: Abhishek Kumar Sent: Thursday, August 17, 2023 22:47 To: dev@cloudstack.apache.org ; us...@cloudstack.apache.org Subject: [PROPOSE] ACS 4.19.0.0 release Hi, Thanks all for your support on my 4.19 RM proposal thread! I propose the following timeline for the 4.19.0.0 release. Keep in mind 4.18.1.0 release work is also currently in progress and is being managed by Wei. - (8 plus weeks) Ongoing – Mid-October 2023: Accept all bugs, issues, improvements allowed in LTS [1] - (1 week) Stabilise the main (or 4.19) branch, accept only critical/blocker issues (if any) - End October 2023 and onwards: Cut 4.19.0.0 RC1 and further RCs if necessary, start/conclude vote, and finish release work I hope to get support from all active contributors during the process of reviewing/testing/merging the PRs. You can find the open issues and PRs at the 4.19.0.0 Github milestone [2]. Ping me (@shwstppr) or Daan (@DaanHoogland) on your issues and PRs, that are to be included in 4.19.0.0. Looking forward to your support on bug fixes, reviews, tests, etc. I'm happy to collaborate with others on the release management. Thanks. [1] https://cwiki.apache.org/confluence/display/CLOUDSTACK/LTS [2] https://github.com/apache/cloudstack/milestone/24 Regards, Abhishek
Re: [PROPOSE] ACS 4.18.1.0 release
Thanks for the update Wei. Regards. From: Nux Sent: Tuesday, August 22, 2023 19:42 To: us...@cloudstack.apache.org Cc: dev@cloudstack.apache.org Subject: Re: [PROPOSE] ACS 4.18.1.0 release Thanks for the update, Wei. Good job so far! On 2023-08-21 12:48, Wei ZHOU wrote: > Hi all, > > In the last weeks, we have merged a few bug fixes into the 4.18 branch. > We > are still working on remaining bug fixes and reviewing pull requests. > > 22 pull requests are open for review: > https://github.com/apache/cloudstack/pulls?q=is%3Aopen+is%3Apr+milestone%3A4.18.1.0 > > 51 issues are open (including 2 critical , 15 major, 33 minor issues): > https://github.com/apache/cloudstack/issues?q=is%3Aopen+is%3Aissue+milestone%3A4.18.1.0 > > *The code freeze time of 4.18.1.0 will be 12:00pm UTC (1pm BST, 2pm > CEST), > 28th August*. The open pull requests and issues after code freeze will > be > moved to 4.18.2.0 milestone. > > -Wei > > > > On Wed, 2 Aug 2023 at 03:22, Wei ZHOU wrote: > >> Hi all, >> >> Here is an update of Apache CloudStack 4.18.1.0 release: >> >> There are some open PRs and issues on github: >> >> 37 pull requests are open for review: >> https://github.com/apache/cloudstack/pulls?q=is%3Aopen+is%3Apr+milestone%3A4.18.1.0 >> >> 66 issues are open (including 1 BLOCKER, 1 critical , 18 major, 39 >> minor >> issues): >> https://github.com/apache/cloudstack/issues?q=is%3Aopen+is%3Aissue+milestone%3A4.18.1.0 >> >> >> We are busy with them. The processes need to be postponed for 2-4 >> weeks. >> >> >> -Wei >> >> >> >> >> On Thu, 4 May 2023 at 10:34, Wei ZHOU wrote: >> >>> Hi all, >>> >>> Currently CloudStack 4.18.0.0 is the latest LTS release. There are >>> some >>> bugs and pull requests with 4.18.0.0 [1], including the fix for the >>> upgrade >>> issue if users use MySQL 5.6 and 5.7. >>> >>> I would like to propose the release of 4.18.1.0 and the timeline >>> >>> - from now till the end of July (3 months): accept bug fixes and >>> minor >>> improvements [2] >>> - first week in Aug: stablisation efforts, accept only blocker and >>> critical bug fixes. >>> - Aug: start cutting RCs, vote and finish release work. >>> >>> I will push myself as the release manager (RM) of 4.18.1.0, if nobody >>> objects. >>> In case anyone wants to include a bug fix or a pull request in >>> 4.18.1.0 >>> milestone, please mention me (weizhouapache) on github. >>> >>> [1] https://github.com/apache/cloudstack/milestone/27 >>> [2] https://cwiki.apache.org/confluence/display/CLOUDSTACK/LTS >>> >>> >>> Any suggestions ? >>> >>> Kind regards, >>> Wei >>> >>
