Re: [PR] notes on purging expunged resources [cloudstack-documentation]

2024-05-02 Thread via GitHub


DaanHoogland commented on code in PR #397:
URL: 
https://github.com/apache/cloudstack-documentation/pull/397#discussion_r1587394782


##
source/adminguide/tuning.rst:
##
@@ -143,3 +143,76 @@ Article 
`_.The article
 refers to XenServer 5.6, but the same information applies to XenServer 6
 
 
+Purging Expunged Resources
+--
+
+..note::

Review Comment:
   ```suggestion
   .. note::
   ```
   I think, not sure but the doc show the literal `..note::`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [REVIVE][DISCUSS] Closing issues & PR after a certain time

2024-05-02 Thread Rohit Yadav
I like the general idea but at the same time want to weight in that we also do 
the right thing in handle issues and PRs. Sometimes there are genuine issues 
and PRs, however, we make no progress on them for one reason or another.

As of last week, I've triaged all the outstanding Github issues that took some 
effort, and have tagged issues with the 1yr+ and 2yr+ tags and stale tags on 
all issues that are several years old now. I hope to not have incited negative 
reactions where I had to close about 50 odd issues which were really old, or 
already fixed, or moved a few of them to discussions. I see the value in having 
an automation to something around time based manner, esp for old issues and PRs 
that nobody cares about. Other opensource projects such as Kubernetes has 
similar automation.

Many issues are (a) user queries or questions about their deployment or 
environment, and not necessarily issues or problems in CloudStack which can be 
moved to Github discussions (which are connected to our users@ ML) and (b) many 
issues are user feature requests or suggestions which nobody has cared to 
address. For (a) I've proposed a PR to drive users by default to Github 
Discussions first via the CloudStack UI and we can triage and move such user 
discussions which are not really CloudStack issues from Github issues to 
discussions.

I think 2yrs+ is a reasonable time to close old/stale/inactive issues and PRs. 
And of course, anybody should be free to re-open or request to re-open and 
retain interesting issues and PRs on case by case basis.

It's also worth encouraging and reminding everyone that CloudStack is an 
opensource project where all stakeholders including the users can pitch in, 
help with engaging in the discussions, sharing steps to reproduce a problem, or 
effort/steps to help test a change/pull-request, to improve the website and 
documentation, as well as to review/test pull requests. This means, as much as 
the development activity we get, we can also benefit from users in helping to 
address their own problems (if not including code but also) including 
documentation, website etc. "What's in it for you?" - you care, because you 
benefit from the project and you want to keep benefiting from the project.


Regards.

 



From: Daan Hoogland 
Sent: Tuesday, April 30, 2024 18:05
To: dev ; users 
Subject: [REVIVE][DISCUSS] Closing issues & PR after a certain time

People,
I want to revive this discussion and bring Vishesh' PR under your
attention again.
The discussion there is mostly about the length of the period before closing.
So here I am going to state 1year - first warning, 1.5years second
warning, 2 years closing. What do you all think?

There are also issues that we might consider interesting but not
functionally complete or clear, we can convert those to github
discussions, and I would like to encourage all of you to do that as
sometimes issues will lead to issues and not to PRs and those are
basically discussions to be had.

please respond with your comments or put them in
https://github.com/apache/cloudstack/pull/8667

regards,

On 2024/02/16 09:17:02 Vishesh Jindal wrote:
> I have created a PR with the changes 
> here:https://github.com/apache/cloudstack/pull/8667
>
> I propose that we enable it. As Daan suggested, we can always remove the 
> action if it doesn't work out. And if a PR/issue gets closed, we can always 
> reopen it.
>
>
>
> 
> From: Daan Hoogland 
> Sent: Wednesday, February 14, 2024 2:17 PM
> To: dev@cloudstack.apache.org 
> Subject: Re: [DISCUSS] Closing issues & PR after a certain time
>
> i'm a bit -0 on this. I agree that a lot of stale issues deserve
> closing, but others are really long term goals. I do not want to block
> this great idea but am just a bit worried about other great ideas
> getting lost. So I would propose to tag anything we close or not
> remove the stale tag, so these can be easily found. I am not worried
> too much about PRs, just issues.
>
> On the other hand, we can always remove the gha again, so maybe we
> should install it and see if it works for us.
>
> On Wed, Feb 14, 2024 at 4:49 AM Kiran Chavala
>  wrote:
> >
> > Good idea Vishesh
> >
> > +1 for using Githubactions
> >
> > Regards
> > Kiran
> >
> > From: Vishesh Jindal 
> > Date: Tuesday, 13 February 2024 at 6:33 PM
> > To: dev@cloudstack.apache.org 
> > Subject: [DISCUSS] Closing issues & PR after a certain time
> > Hi everyone,
> >
> > I was going through the issues and PRs, and I noticed that a lot of them 
> > are really old and some of them are waiting for the original author to 
> > reply.
> >
> > I wanted to discuss if we should add a github action 
> > (https://github.com/marketplace/actions/close-stale-issues) for auto 
> > closing the issues and PRs after a certain time.
> >
> > From the github actions' documentation, this is how it works:
> >
> >   *   Add a label "Stale" on issues and pull requests after 60 

Re: [PR] Documentation for adding NFS mount options to storage pool [cloudstack-documentation]

2024-05-02 Thread via GitHub


blueorangutan commented on PR #396:
URL: 
https://github.com/apache/cloudstack-documentation/pull/396#issuecomment-2089722181

   QA-Doc build preview: https://qa.cloudstack.cloud/builds/docs-build/pr/396. 
(QA-JID 232)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Documentation for adding NFS mount options to storage pool [cloudstack-documentation]

2024-05-02 Thread via GitHub


blueorangutan commented on PR #396:
URL: 
https://github.com/apache/cloudstack-documentation/pull/396#issuecomment-2089721126

   @abh1sar a Jenkins job has been kicked to build the document. I'll keep you 
posted as I make progress.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Documentation for adding NFS mount options to storage pool [cloudstack-documentation]

2024-05-02 Thread via GitHub


abh1sar commented on PR #396:
URL: 
https://github.com/apache/cloudstack-documentation/pull/396#issuecomment-2089720242

   @blueorangutan docbuild


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org