Re: [ANNOUNCE] New Committer Marco Sinhoreli
Congrats Marco! Regards, Gaurav On May 12, 2015, at 5:40 PM, Suresh Sadhu suresh.sa...@citrix.com wrote: Congrats, Marco! Regards sadhu 2015-05-11 1:50 GMT-07:00 sebgoa run...@gmail.com: It seems we forgot to announce that Marco was made a committer, my sincere apologies - The Project Management Committee (PMC) for Apache CloudStack has asked Marco Sinhoreli to become a committer and we are pleased to announce that he has accepted. Marco has done an outstanding job building the CloudStack community in Brazil. Parabéns por um trabalho bem feito e espero que você vai continuar a apoiar a comunidade da maneira que você tem feito até agora. Being a committer allows many contributors to contribute more autonomously. For developers, it makes it easier to submit changes and eliminates the need to have contributions reviewed via the patch submission process. Whether contributions are development-related or otherwise, it is a recognition of a contributor's participation in the project and commitment to the project and the Apache Way. Please join me in congratulating Marco ! --Sebastien Goasguen on behalf of the CloudStack PMC O Comité de Gestão do Projeto (PMC) para Apache CloudStack pediu Marco Sinhoreli para se tornar um committer e temos o prazer de anunciar que ele aceitou. Marco tem feito um trabalho notável construção da comunidade CloudStack no Brasil. Parabéns Por Um Trabalho Bem Feito e espero Que Voce vai continuar 'uma APOIAR a Comunidade da Maneira Que rápido Você tem Feito Até ágora. Sendo um committer permite que muitos colaboradores a contribuir mais autonomamente. Para os desenvolvedores, torna-se mais fácil de submeter as alterações e elimina a necessidade de ter contribuições avaliação via o patch processo de submissão. Se as contribuições são relacionadas com desenvolvimento ou caso contrário, é um reconhecimento da participação de um contribuinte no projeto e compromisso com o projeto eo Caminho Apache. Por favor, se juntar a mim para parabenizar Marco --Sebastien Goasguen em nome da CloudStack PMC 项目管理委员会（PMC）为Apache的CloudStack 已要求马可Sinhoreli变成提交，我们很高兴地 宣布，他已经接受了。 马可已经做了出色的工作在建设社区的CloudStack在巴西。 在工作祝贺做得好，希望您能继续支持社区，你目前所做的方式。 作为一个提交允许许多贡献者作出更大的贡献 自主。对于开发人员来说，它可以更容易地提交更改和 消除了需要具有贡献经由补丁审查 提交过程。是否捐款是发展相关或 否则，它是一种认可，在一个贡献者的参与 项目与承诺项目和Apache的方式。 请和我一起祝贺马可 --Sebastien Goasguen 代PMC的CloudStack的 ApacheのCloudStackのためのプロジェクト管理委員会（PMC） コミッタになるためにマルコSinhoreliに尋ねた、私たちはに満足しているしています 彼が承認したことを発表しました。 マルコは、ブラジルのCloudStackのコミュニティを構築する優れた仕事をしています。 仕事おめでとうはよくやった、あなたがこれまで行ってきた方法でコミュニティを支援していきます願っています。 コミッターであることは多くの貢献者が多くを貢献することができます 自律的。開発者にとっては、それはそれが簡単に変更を提出することになり、 パッチ経由の口コミ貢献を持ってする必要がなくなります 提出プロセス。貢献は、開発に関連しているかどうか それ以外の場合は、中の寄稿者の参加の認識があります プロジェクトとプロジェクトとApacheの道へのコミットメント。 マルコの祝福の中で私に参加してください --Sebastien Goasguen CloudStackのPMCの代わりに
Re: [GitHub] cloudstack pull request: Corrected username for Gaurav
Thanks Sebastien! Regards, Gaurav Aradhye On May 4, 2015, at 1:27 PM, runseb g...@git.apache.org wrote: Github user runseb commented on the pull request: https://github.com/apache/cloudstack/pull/227#issuecomment-98618446 I already made the correction --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
Re: [ANNOUNCE] New committer: Remi Bergsma
Congrats Remi! Regards, Gaurav Aradhye On May 3, 2015, at 10:59 PM, Somesh Naidu somesh.na...@citrix.com wrote: Congratulations Remi! Sent from my Verizon Wireless 4G LTE DROID On May 2, 2015 4:31 PM, Remi Bergsma r...@remi.nl wrote: Thanks all for the kind words :-) Looking forward to continue working with you and making CloudStack even better! Regards, Remi On 01 May 2015, at 14:24, Pierre-Luc Dion pd...@cloudops.com wrote: Congrats Remi! On Fri, May 1, 2015 at 8:07 AM, Mike Tutkowski mike.tutkow...@solidfire.com wrote: Congratulations, Remi! On Friday, May 1, 2015, Daan Hoogland daan.hoogl...@gmail.com wrote: The Project Management Committee (PMC) for Apache CloudStack has asked Remi Bergsma to become a committer and we are pleased to announce that he has accepted. Remi has reported and helped in investigating and solving many bugs. He has given talks on managing clouds on several occasions. Being a committer allows many contributors to contribute more autonomously. For developers, it makes it easier to submit changes and eliminates the need to have contributions reviewed via the patch submission process. Whether contributions are development-related or otherwise, it is a recognition of a contributor's participation in the project and commitment to the project and the Apache Way. Please join me in congratulating Remi --Daan Hoogland on behalf of the CloudStack PMC -- *Mike Tutkowski* *Senior CloudStack Developer, SolidFire Inc.* e: mike.tutkow...@solidfire.com o: 303.746.7302 Advancing the way the world uses the cloud http://solidfire.com/solution/overview/?video=play*™*
Re: [marvin tests] interpreting results
Hi Abhi, FAILED indicates it’s an assertion error. Even if the test case is expecting a failure, it must have been written in such a way that when an operation fails, test case passes. Here it indicates that operation which should have failed has succeeded, might be a product issue. Exception indicates there is an unexpected exception in the code, other than assertions. Can you please share the detailed logs from failed_plus_exceptions.txt file in the log folder? Regards, Gaurav Aradhye On Apr 24, 2015, at 4:04 PM, Abhinandan Prateek abhinandan.prat...@shapeblue.com wrote: Have been trying to run some marvin test cases. Need to know how to interpret the result. On running test cases I see several success and failure messages. Lets take example of each from output of /root/cloudstack/test/integration/component/test_acl_isolatednetwork.py on ACS 4.5, taking a sample from output: === TestName: test_02_createNetwork_admin_foruserinsamedomain | Status : SUCCESS === ***The above says the test case is successful, basically the functionality works. === TestName: test_09_createNetwork_user_foruserinsamedomain | Status : FAILED === ***From the code it appears that the test is expected to fail, this also means the test case is successful. === TestName: test_12_deployvm_admin_foruserinsamedomain | Status : EXCEPTION === I assume this means the test case did not execute successfully ? If it is on a fresh environment will that mean something is wrong with the test itself ? Can someone share some gyan on above ? -abhi Find out more about ShapeBlue and our range of CloudStack related services IaaS Cloud Design Buildhttp://shapeblue.com/iaas-cloud-design-and-build// CSForge – rapid IaaS deployment frameworkhttp://shapeblue.com/csforge/ CloudStack Consultinghttp://shapeblue.com/cloudstack-consultancy/ CloudStack Software Engineeringhttp://shapeblue.com/cloudstack-software-engineering/ CloudStack Infrastructure Supporthttp://shapeblue.com/cloudstack-infrastructure-support/ CloudStack Bootcamp Training Courseshttp://shapeblue.com/cloudstack-training/ This email and any attachments to it may be confidential and are intended solely for the use of the individual to whom it is addressed. Any views or opinions expressed are solely those of the author and do not necessarily represent those of Shape Blue Ltd or related companies. If you are not the intended recipient of this email, you must neither take any action based upon its contents, nor copy or show it to anyone. Please contact the sender if you believe you have received this email in error. Shape Blue Ltd is a company incorporated in England Wales. ShapeBlue Services India LLP is a company incorporated in India and is operated under license from Shape Blue Ltd. Shape Blue Brasil Consultoria Ltda is a company incorporated in Brasil and is operated under license from Shape Blue Ltd. ShapeBlue SA Pty Ltd is a company registered by The Republic of South Africa and is traded under license from Shape Blue Ltd. ShapeBlue is a registered trademark.
Re: [marvin tests] interpreting results
Abhi, went through the logs. The tests which have FAILED have failed because product behavior is not as expected in the test. Tests with Exception seem have issue in test code. Regards, Gaurav Aradhye On Apr 24, 2015, at 4:47 PM, Abhinandan Prateek abhinandan.prat...@shapeblue.com wrote: Attaching the logs. This is with latest 4.5 branch. Find out more about ShapeBlue and our range of CloudStack related services IaaS Cloud Design Buildhttp://shapeblue.com/iaas-cloud-design-and-build// CSForge – rapid IaaS deployment frameworkhttp://shapeblue.com/csforge/ CloudStack Consultinghttp://shapeblue.com/cloudstack-consultancy/ CloudStack Software Engineeringhttp://shapeblue.com/cloudstack-software-engineering/ CloudStack Infrastructure Supporthttp://shapeblue.com/cloudstack-infrastructure-support/ CloudStack Bootcamp Training Courseshttp://shapeblue.com/cloudstack-training/ This email and any attachments to it may be confidential and are intended solely for the use of the individual to whom it is addressed. Any views or opinions expressed are solely those of the author and do not necessarily represent those of Shape Blue Ltd or related companies. If you are not the intended recipient of this email, you must neither take any action based upon its contents, nor copy or show it to anyone. Please contact the sender if you believe you have received this email in error. Shape Blue Ltd is a company incorporated in England Wales. ShapeBlue Services India LLP is a company incorporated in India and is operated under license from Shape Blue Ltd. Shape Blue Brasil Consultoria Ltda is a company incorporated in Brasil and is operated under license from Shape Blue Ltd. ShapeBlue SA Pty Ltd is a company registered by The Republic of South Africa and is traded under license from Shape Blue Ltd. ShapeBlue is a registered trademark. test_acl_isolatednetwork.tar Regards, -abhi On 24-Apr-2015, at 4:21 pm, Gaurav Aradhye gaurav.arad...@clogeny.com wrote: Hi Abhi, FAILED indicates it’s an assertion error. Even if the test case is expecting a failure, it must have been written in such a way that when an operation fails, test case passes. Here it indicates that operation which should have failed has succeeded, might be a product issue. Exception indicates there is an unexpected exception in the code, other than assertions. Can you please share the detailed logs from failed_plus_exceptions.txt file in the log folder? Regards, Gaurav Aradhye On Apr 24, 2015, at 4:04 PM, Abhinandan Prateek abhinandan.prat...@shapeblue.com wrote: Have been trying to run some marvin test cases. Need to know how to interpret the result. On running test cases I see several success and failure messages. Lets take example of each from output of /root/cloudstack/test/integration/component/test_acl_isolatednetwork.py on ACS 4.5, taking a sample from output: === TestName: test_02_createNetwork_admin_foruserinsamedomain | Status : SUCCESS === ***The above says the test case is successful, basically the functionality works. === TestName: test_09_createNetwork_user_foruserinsamedomain | Status : FAILED === ***From the code it appears that the test is expected to fail, this also means the test case is successful. === TestName: test_12_deployvm_admin_foruserinsamedomain | Status : EXCEPTION === I assume this means the test case did not execute successfully ? If it is on a fresh environment will that mean something is wrong with the test itself ? Can someone share some gyan on above ? -abhi Find out more about ShapeBlue and our range of CloudStack related services IaaS Cloud Design Buildhttp://shapeblue.com/iaas-cloud-design-and-build// CSForge – rapid IaaS deployment frameworkhttp://shapeblue.com/csforge/ CloudStack Consultinghttp://shapeblue.com/cloudstack-consultancy/ CloudStack Software Engineeringhttp://shapeblue.com/cloudstack-software-engineering/ CloudStack Infrastructure Supporthttp://shapeblue.com/cloudstack-infrastructure-support/ CloudStack Bootcamp Training Courseshttp://shapeblue.com/cloudstack-training/ This email and any attachments to it may be confidential and are intended solely for the use of the individual to whom it is addressed. Any views or opinions expressed are solely those of the author and do not necessarily represent those of Shape Blue Ltd or related companies. If you are not the intended recipient of this email, you must neither take any action based upon its contents, nor copy or show it to anyone. Please contact the sender if you believe you have received this email in error. Shape Blue Ltd is a company incorporated in England Wales. ShapeBlue Services India LLP is a company incorporated in India and is operated under license from Shape Blue Ltd. Shape Blue Brasil Consultoria Ltda is a company incorporated in Brasil
Re: Downloading pom from ceph.com fails
Thanks.. build on master succeeds now. Regards, Gaurav Aradhye On Apr 16, 2015, at 10:06 PM, Nux! n...@li.nux.ro wrote: No need, Rohit did the master afaik. -- Sent from the Delta quadrant using Borg technology! Nux! www.nux.ro - Original Message - From: Gaurav Aradhye gaurav.arad...@clogeny.com To: dev@cloudstack.apache.org Sent: Thursday, 16 April, 2015 14:51:23 Subject: Re: Downloading pom from ceph.com fails Thanks nux! Should it be cherry picked to master also? I have observed failure on master too. On Apr 16, 2015 7:13 PM, Nux! n...@li.nux.ro wrote: Ok, did a pull request for 4.4 branch. In the meanwhile EL6 RPMs here: http://tmp.nux.ro/acs443/el6/ -- Sent from the Delta quadrant using Borg technology! Nux! www.nux.ro - Original Message - From: Ian Southam isout...@schubergphilis.com To: dev@cloudstack.apache.org Sent: Thursday, 16 April, 2015 14:01:30 Subject: Re: Downloading pom from ceph.com fails Hi, Probably a good idea to commit but I confess it is a “works on my laptop” change ;). — Ian On 16 Apr 2015, at 14:41, Gaurav Aradhye gaurav.arad...@clogeny.com wrote: Changed subject to not spam original post. I encountered this issue in building latest master also. Ian, should this change be committed? Regards, Gaurav Aradhye On Apr 16, 2015, at 6:07 PM, Ian Southam isout...@schubergphilis.com wrote: Change ceph.com to eu.ceph.com in ./plugins/hypervisors/kvm/pom.xml then it will compile again. — Grts! Ian On 16 Apr 2015, at 10:37, Nux! n...@li.nux.ro wrote: Looks like there is a pom here http://repo1.maven.org/maven2/com/github/K0zka/libvirt/0.5.1/ What file needs to be modified to point the build process there? -- Sent from the Delta quadrant using Borg technology! Nux! www.nux.ro - Original Message - From: Nux! n...@li.nux.ro To: dev@cloudstack.apache.org Sent: Thursday, 16 April, 2015 09:30:24 Subject: Re: [VOTE] Apache Cloudstack 4.4.3 Ok, I can't even build it, it stops at: [INFO] [INFO] Building Apache CloudStack Plugin - Hypervisor KVM 4.4.3 [INFO] Downloading: http://libvirt.org/maven2/org/libvirt/libvirt/0.5.1/libvirt-0.5.1.pom Downloading: http://ceph.com/maven/org/libvirt/libvirt/0.5.1/libvirt-0.5.1.pom Apparently those URLs do not work. -- Sent from the Delta quadrant using Borg technology! Nux! www.nux.ro - Original Message - From: Nux! n...@li.nux.ro To: dev@cloudstack.apache.org Sent: Thursday, 16 April, 2015 09:00:50 Subject: Re: [VOTE] Apache Cloudstack 4.4.3 https://dist.apache.org/repos/dist/dev/cloudstack/4.4/ does not exist. I guess the valid one is either https://dist.apache.org/repos/dist/dev/cloudstack/4.4.3/ OR simply https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;a=snapshot;h=e9441d47867104505ef260c1857549f93df96aba;sf=tgz -- Sent from the Delta quadrant using Borg technology! Nux! www.nux.ro - Original Message - From: Daan Hoogland daan.hoogl...@gmail.com To: dev dev@cloudstack.apache.org Sent: Wednesday, 15 April, 2015 23:02:55 Subject: [VOTE] Apache Cloudstack 4.4.3 Hi All, I've created a 4.4.3 release, with the following artifacts up for a vote: Git Branch and Commit SH: https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;a=shortlog;h=refs/heads/4.4 Commit: e9441d47867104505ef260c1857549f93df96aba List of changes: https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;a=shortlog;h=refs/heads/4.4 https://issues.apache.org/jira/issues/?filter=12330007 Source release (checksums and signatures are available at the same location): https://dist.apache.org/repos/dist/dev/cloudstack/4.4/ PGP release keys (signed using 2048D/5AABEBEA): https://dist.apache.org/repos/dist/release/cloudstack/KEYS Vote will be open for 72 hours. For sanity in tallying the vote, can PMC members please be sure to indicate (binding) with their vote? [ ] +1 approve [ ] +0 no opinion [ ] -1 disapprove (and reason why) -- Daan
Re: [ANNOUNCE] New committer: Gaurav Nandkumar Aradhye
Thanks Giles, Nux! Regards, Gaurav Aradhye On Apr 16, 2015, at 6:49 PM, Nux! n...@li.nux.ro wrote: Congrats :) -- Sent from the Delta quadrant using Borg technology! Nux! www.nux.ro - Original Message - From: Daan Hoogland daan.hoogl...@gmail.com To: dev dev@cloudstack.apache.org Sent: Monday, 13 April, 2015 20:43:30 Subject: [ANNOUNCE] New committer: Gaurav Nandkumar Aradhye The Project Management Committee (PMC) for Apache CloudStack has asked Gaurav Aradhya to become a committer and we are pleased to announce that they have accepted. Being a committer allows many contributors to contribute more autonomously. For developers, it makes it easier to submit changes and eliminates the need to have contributions reviewed via the patch submission process. Whether contributions are development-related or otherwise, it is a recognition of a contributor's participation in the project and commitment to the project and the Apache Way. Please join me in congratulating Gaurav -- Daan on behalf of the CloudStack PMC
Downloading pom from ceph.com fails
Changed subject to not spam original post. I encountered this issue in building latest master also. Ian, should this change be committed? Regards, Gaurav Aradhye On Apr 16, 2015, at 6:07 PM, Ian Southam isout...@schubergphilis.com wrote: Change ceph.com to eu.ceph.com in ./plugins/hypervisors/kvm/pom.xml then it will compile again. — Grts! Ian On 16 Apr 2015, at 10:37, Nux! n...@li.nux.ro wrote: Looks like there is a pom here http://repo1.maven.org/maven2/com/github/K0zka/libvirt/0.5.1/ What file needs to be modified to point the build process there? -- Sent from the Delta quadrant using Borg technology! Nux! www.nux.ro - Original Message - From: Nux! n...@li.nux.ro To: dev@cloudstack.apache.org Sent: Thursday, 16 April, 2015 09:30:24 Subject: Re: [VOTE] Apache Cloudstack 4.4.3 Ok, I can't even build it, it stops at: [INFO] [INFO] Building Apache CloudStack Plugin - Hypervisor KVM 4.4.3 [INFO] Downloading: http://libvirt.org/maven2/org/libvirt/libvirt/0.5.1/libvirt-0.5.1.pom Downloading: http://ceph.com/maven/org/libvirt/libvirt/0.5.1/libvirt-0.5.1.pom Apparently those URLs do not work. -- Sent from the Delta quadrant using Borg technology! Nux! www.nux.ro - Original Message - From: Nux! n...@li.nux.ro To: dev@cloudstack.apache.org Sent: Thursday, 16 April, 2015 09:00:50 Subject: Re: [VOTE] Apache Cloudstack 4.4.3 https://dist.apache.org/repos/dist/dev/cloudstack/4.4/ does not exist. I guess the valid one is either https://dist.apache.org/repos/dist/dev/cloudstack/4.4.3/ OR simply https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;a=snapshot;h=e9441d47867104505ef260c1857549f93df96aba;sf=tgz -- Sent from the Delta quadrant using Borg technology! Nux! www.nux.ro - Original Message - From: Daan Hoogland daan.hoogl...@gmail.com To: dev dev@cloudstack.apache.org Sent: Wednesday, 15 April, 2015 23:02:55 Subject: [VOTE] Apache Cloudstack 4.4.3 Hi All, I've created a 4.4.3 release, with the following artifacts up for a vote: Git Branch and Commit SH: https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;a=shortlog;h=refs/heads/4.4 Commit: e9441d47867104505ef260c1857549f93df96aba List of changes: https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;a=shortlog;h=refs/heads/4.4 https://issues.apache.org/jira/issues/?filter=12330007 Source release (checksums and signatures are available at the same location): https://dist.apache.org/repos/dist/dev/cloudstack/4.4/ PGP release keys (signed using 2048D/5AABEBEA): https://dist.apache.org/repos/dist/release/cloudstack/KEYS Vote will be open for 72 hours. For sanity in tallying the vote, can PMC members please be sure to indicate (binding) with their vote? [ ] +1 approve [ ] +0 no opinion [ ] -1 disapprove (and reason why) -- Daan
Re: Downloading pom from ceph.com fails
Thanks nux! Should it be cherry picked to master also? I have observed failure on master too. On Apr 16, 2015 7:13 PM, Nux! n...@li.nux.ro wrote: Ok, did a pull request for 4.4 branch. In the meanwhile EL6 RPMs here: http://tmp.nux.ro/acs443/el6/ -- Sent from the Delta quadrant using Borg technology! Nux! www.nux.ro - Original Message - From: Ian Southam isout...@schubergphilis.com To: dev@cloudstack.apache.org Sent: Thursday, 16 April, 2015 14:01:30 Subject: Re: Downloading pom from ceph.com fails Hi, Probably a good idea to commit but I confess it is a “works on my laptop” change ;). — Ian On 16 Apr 2015, at 14:41, Gaurav Aradhye gaurav.arad...@clogeny.com wrote: Changed subject to not spam original post. I encountered this issue in building latest master also. Ian, should this change be committed? Regards, Gaurav Aradhye On Apr 16, 2015, at 6:07 PM, Ian Southam isout...@schubergphilis.com wrote: Change ceph.com to eu.ceph.com in ./plugins/hypervisors/kvm/pom.xml then it will compile again. — Grts! Ian On 16 Apr 2015, at 10:37, Nux! n...@li.nux.ro wrote: Looks like there is a pom here http://repo1.maven.org/maven2/com/github/K0zka/libvirt/0.5.1/ What file needs to be modified to point the build process there? -- Sent from the Delta quadrant using Borg technology! Nux! www.nux.ro - Original Message - From: Nux! n...@li.nux.ro To: dev@cloudstack.apache.org Sent: Thursday, 16 April, 2015 09:30:24 Subject: Re: [VOTE] Apache Cloudstack 4.4.3 Ok, I can't even build it, it stops at: [INFO] [INFO] Building Apache CloudStack Plugin - Hypervisor KVM 4.4.3 [INFO] Downloading: http://libvirt.org/maven2/org/libvirt/libvirt/0.5.1/libvirt-0.5.1.pom Downloading: http://ceph.com/maven/org/libvirt/libvirt/0.5.1/libvirt-0.5.1.pom Apparently those URLs do not work. -- Sent from the Delta quadrant using Borg technology! Nux! www.nux.ro - Original Message - From: Nux! n...@li.nux.ro To: dev@cloudstack.apache.org Sent: Thursday, 16 April, 2015 09:00:50 Subject: Re: [VOTE] Apache Cloudstack 4.4.3 https://dist.apache.org/repos/dist/dev/cloudstack/4.4/ does not exist. I guess the valid one is either https://dist.apache.org/repos/dist/dev/cloudstack/4.4.3/ OR simply https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;a=snapshot;h=e9441d47867104505ef260c1857549f93df96aba;sf=tgz -- Sent from the Delta quadrant using Borg technology! Nux! www.nux.ro - Original Message - From: Daan Hoogland daan.hoogl...@gmail.com To: dev dev@cloudstack.apache.org Sent: Wednesday, 15 April, 2015 23:02:55 Subject: [VOTE] Apache Cloudstack 4.4.3 Hi All, I've created a 4.4.3 release, with the following artifacts up for a vote: Git Branch and Commit SH: https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;a=shortlog;h=refs/heads/4.4 Commit: e9441d47867104505ef260c1857549f93df96aba List of changes: https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;a=shortlog;h=refs/heads/4.4 https://issues.apache.org/jira/issues/?filter=12330007 Source release (checksums and signatures are available at the same location): https://dist.apache.org/repos/dist/dev/cloudstack/4.4/ PGP release keys (signed using 2048D/5AABEBEA): https://dist.apache.org/repos/dist/release/cloudstack/KEYS Vote will be open for 72 hours. For sanity in tallying the vote, can PMC members please be sure to indicate (binding) with their vote? [ ] +1 approve [ ] +0 no opinion [ ] -1 disapprove (and reason why) -- Daan
Re: Inconsistencies in tests
Talluri, I still have to do it. Didn’t get enough time on it. Not a jenkins expert. Can anybody help me in setting jenkins job for tests which will do static code analysis (python) and pep8 analysis? Regards, Gaurav Aradhye On Apr 15, 2015, at 12:28 PM, Srikanteswararao Talluri srikanteswararao.tall...@citrix.com wrote: +1 Gaurav, You were talking about integrating static code analysis in jenkins.b.a.c.o. How is it going? Thanks, ~Talluri On 14/04/15 3:50 pm, Sebastien Goasguen run...@gmail.com wrote: On Apr 14, 2015, at 9:06 AM, Gaurav Aradhye gaurav.arad...@clogeny.com wrote: Hi all, I feel that the test code in BVT and Regression tests (smoke and component folders) should be more consistent. There are feature developers adding tests into smoke and different test developers adding more tests into component folder, it is evident that inconsistencies are bound to arise. But with time, we should be striving to minimize them. I have listed few of the inconsistencies below. Feel free to add to the list if you think of more. 1. List Methods: If we want to list accounts, some tests use Account.list method, while some use list_accounts method. Both methods finally do the same thing, but there are many list methods in common.py file corresponding base class methods in base.py. This is code duplication. I feel that BaseClass.method() is more readable than list_xyz(), or should be preferred. 2. Checking empty/None lists: We already have validateList utility method which checks both empty lists and None objects. No need to use ³isinstance² method, or add additional None checks. 3. Pep8 issues: Many files are not pep8 consistent. In the past I have tried to fix pep8 issues in files and the mission is ON. Efforts need to be put into this. We already have autopep8 tool which does most of the things. +1 that¹s really a low hanging fruit and best practice. we should not be merging anything that breaks pep8 we should also add pylint tests checking for pep8 and python of all python code can be done at the high level using something like tox, kind of like the RAT tests I will be creating separate issues in JIRA for listed things. Everyone is welcome to add pull requests for these tasks. I personally will be putting more efforts into these in upcoming few months. 2-3 months and we should see most of the tests consistent with each other. Regards, Gaurav
Re: Inconsistencies in tests
Thanks Talluri, I will catch up with you on this. Regards, Gaurav Aradhye On Apr 15, 2015, at 12:37 PM, Srikanteswararao Talluri srikanteswararao.tall...@citrix.com wrote: I will help you set the job up. On 15/04/15 12:34 pm, Gaurav Aradhye gaurav.arad...@clogeny.com wrote: Talluri, I still have to do it. Didn’t get enough time on it. Not a jenkins expert. Can anybody help me in setting jenkins job for tests which will do static code analysis (python) and pep8 analysis? Regards, Gaurav Aradhye On Apr 15, 2015, at 12:28 PM, Srikanteswararao Talluri srikanteswararao.tall...@citrix.com wrote: +1 Gaurav, You were talking about integrating static code analysis in jenkins.b.a.c.o. How is it going? Thanks, ~Talluri On 14/04/15 3:50 pm, Sebastien Goasguen run...@gmail.com wrote: On Apr 14, 2015, at 9:06 AM, Gaurav Aradhye gaurav.arad...@clogeny.com wrote: Hi all, I feel that the test code in BVT and Regression tests (smoke and component folders) should be more consistent. There are feature developers adding tests into smoke and different test developers adding more tests into component folder, it is evident that inconsistencies are bound to arise. But with time, we should be striving to minimize them. I have listed few of the inconsistencies below. Feel free to add to the list if you think of more. 1. List Methods: If we want to list accounts, some tests use Account.list method, while some use list_accounts method. Both methods finally do the same thing, but there are many list methods in common.py file corresponding base class methods in base.py. This is code duplication. I feel that BaseClass.method() is more readable than list_xyz(), or should be preferred. 2. Checking empty/None lists: We already have validateList utility method which checks both empty lists and None objects. No need to use ³isinstance² method, or add additional None checks. 3. Pep8 issues: Many files are not pep8 consistent. In the past I have tried to fix pep8 issues in files and the mission is ON. Efforts need to be put into this. We already have autopep8 tool which does most of the things. +1 that¹s really a low hanging fruit and best practice. we should not be merging anything that breaks pep8 we should also add pylint tests checking for pep8 and python of all python code can be done at the high level using something like tox, kind of like the RAT tests I will be creating separate issues in JIRA for listed things. Everyone is welcome to add pull requests for these tasks. I personally will be putting more efforts into these in upcoming few months. 2-3 months and we should see most of the tests consistent with each other. Regards, Gaurav
Inconsistencies in tests
Hi all, I feel that the test code in BVT and Regression tests (smoke and component folders) should be more consistent. There are feature developers adding tests into smoke and different test developers adding more tests into component folder, it is evident that inconsistencies are bound to arise. But with time, we should be striving to minimize them. I have listed few of the inconsistencies below. Feel free to add to the list if you think of more. 1. List Methods: If we want to list accounts, some tests use Account.list method, while some use list_accounts method. Both methods finally do the same thing, but there are many list methods in common.py file corresponding base class methods in base.py. This is code duplication. I feel that BaseClass.method() is more readable than list_xyz(), or should be preferred. 2. Checking empty/None lists: We already have validateList utility method which checks both empty lists and None objects. No need to use “isinstance” method, or add additional None checks. 3. Pep8 issues: Many files are not pep8 consistent. In the past I have tried to fix pep8 issues in files and the mission is ON. Efforts need to be put into this. We already have autopep8 tool which does most of the things. I will be creating separate issues in JIRA for listed things. Everyone is welcome to add pull requests for these tasks. I personally will be putting more efforts into these in upcoming few months. 2-3 months and we should see most of the tests consistent with each other. Regards, Gaurav
Re: [ANNOUNCE] New committer: Gaurav Nandkumar Aradhye
That’s true Rohit! Thanks! :-) Thank you Talluri, Ahmad, Punith, Koushik! Regards, Gaurav Aradhye On Apr 14, 2015, at 2:20 PM, Rohit Yadav rohit.ya...@shapeblue.com wrote: Congrats Gaurav! Now you can to merge your pending PRs yourself (less work for the rest of us :)). On 14-Apr-2015, at 1:13 am, Daan Hoogland daan.hoogl...@gmail.com wrote: The Project Management Committee (PMC) for Apache CloudStack has asked Gaurav Aradhya to become a committer and we are pleased to announce that they have accepted. Being a committer allows many contributors to contribute more autonomously. For developers, it makes it easier to submit changes and eliminates the need to have contributions reviewed via the patch submission process. Whether contributions are development-related or otherwise, it is a recognition of a contributor's participation in the project and commitment to the project and the Apache Way. Please join me in congratulating Gaurav -- Daan on behalf of the CloudStack PMC Regards, Rohit Yadav Software Architect, ShapeBlue M. +91 88 262 30892 | rohit.ya...@shapeblue.com Blog: bhaisaab.org | Twitter: @_bhaisaab Find out more about ShapeBlue and our range of CloudStack related services IaaS Cloud Design Buildhttp://shapeblue.com/iaas-cloud-design-and-build// CSForge – rapid IaaS deployment frameworkhttp://shapeblue.com/csforge/ CloudStack Consultinghttp://shapeblue.com/cloudstack-consultancy/ CloudStack Software Engineeringhttp://shapeblue.com/cloudstack-software-engineering/ CloudStack Infrastructure Supporthttp://shapeblue.com/cloudstack-infrastructure-support/ CloudStack Bootcamp Training Courseshttp://shapeblue.com/cloudstack-training/ This email and any attachments to it may be confidential and are intended solely for the use of the individual to whom it is addressed. Any views or opinions expressed are solely those of the author and do not necessarily represent those of Shape Blue Ltd or related companies. If you are not the intended recipient of this email, you must neither take any action based upon its contents, nor copy or show it to anyone. Please contact the sender if you believe you have received this email in error. Shape Blue Ltd is a company incorporated in England Wales. ShapeBlue Services India LLP is a company incorporated in India and is operated under license from Shape Blue Ltd. Shape Blue Brasil Consultoria Ltda is a company incorporated in Brasil and is operated under license from Shape Blue Ltd. ShapeBlue SA Pty Ltd is a company registered by The Republic of South Africa and is traded under license from Shape Blue Ltd. ShapeBlue is a registered trademark.
Re: [ANNOUNCE] New committer: Gaurav Nandkumar Aradhye
Thanks Raja! Regards, Gaurav Aradhye On Apr 14, 2015, at 5:24 PM, Raja Pullela raja.pull...@citrix.com wrote: Congratulations Gaurav! -Original Message- From: Rajani Karuturi [mailto:raj...@apache.org] Sent: Tuesday, April 14, 2015 9:10 AM To: dev@cloudstack.apache.org Subject: Re: [ANNOUNCE] New committer: Gaurav Nandkumar Aradhye congratulations Gaurav.. ~Rajani On Tue, Apr 14, 2015 at 1:35 AM, Erik Weber terbol...@gmail.com wrote: On Mon, Apr 13, 2015 at 9:43 PM, Daan Hoogland daan.hoogl...@gmail.com wrote: The Project Management Committee (PMC) for Apache CloudStack has asked Gaurav Aradhya to become a committer and we are pleased to announce that they have accepted. Being a committer allows many contributors to contribute more autonomously. For developers, it makes it easier to submit changes and eliminates the need to have contributions reviewed via the patch submission process. Whether contributions are development-related or otherwise, it is a recognition of a contributor's participation in the project and commitment to the project and the Apache Way. Please join me in congratulating Gaurav Well deserved, welcome! Congratulations :-) -- Erik
Re: [GitHub] cloudstack pull request: CLOUDSTACK-8374: Adding tests for guest t...
Sure Sebastien, I missed squashing. Thanks. Regards, Gaurav Aradhye On Apr 14, 2015, at 6:50 PM, runseb g...@git.apache.org wrote: Github user runseb commented on the pull request: https://github.com/apache/cloudstack/pull/166#issuecomment-92825534 in cases like this, make sure to squash commits. and if pep8 does not pass, then ask for revision to PR --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
Re: How do the committers generally merge the pull requests?
Thanks Sebastien for detailed steps! Regards, Gaurav Aradhye On Apr 14, 2015, at 6:30 PM, Sebastien Goasguen run...@gmail.com wrote: On Apr 14, 2015, at 2:53 PM, Gaurav Aradhye gaurav.arad...@clogeny.com wrote: Need to some advice from established committers :-) How do you merge the pull request? Through button on github? Or applying patch locally and then committing it? Where to add “This closes ###” comment exactly? Please help me out with steps! Regards, Gaurav Aradhye personally I do this: wget https://github.com/apache/cloudstack/pull/166.patch review patch manually git apply —check…. then git am -s 166.patch git rebase -i (to squash if needed and edit commit message…) git commit —amend allows you to edit the commit message, that’s where you add the “This closes #xyz” , remember to leave the original message… git push if applicable, make sure to cherry-pick to all branches concerned.
How do the committers generally merge the pull requests?
Need to some advice from established committers :-) How do you merge the pull request? Through button on github? Or applying patch locally and then committing it? Where to add “This closes ###” comment exactly? Please help me out with steps! Regards, Gaurav Aradhye
Re: How do the committers generally merge the pull requests?
Should I add this to any existing/new wiki page? Regards, Gaurav Aradhye On Apr 14, 2015, at 6:34 PM, Gaurav Aradhye gaurav.arad...@clogeny.com wrote: Thanks Sebastien for detailed steps! Regards, Gaurav Aradhye On Apr 14, 2015, at 6:30 PM, Sebastien Goasguen run...@gmail.com wrote: On Apr 14, 2015, at 2:53 PM, Gaurav Aradhye gaurav.arad...@clogeny.com wrote: Need to some advice from established committers :-) How do you merge the pull request? Through button on github? Or applying patch locally and then committing it? Where to add “This closes ###” comment exactly? Please help me out with steps! Regards, Gaurav Aradhye personally I do this: wget https://github.com/apache/cloudstack/pull/166.patch review patch manually git apply —check…. then git am -s 166.patch git rebase -i (to squash if needed and edit commit message…) git commit —amend allows you to edit the commit message, that’s where you add the “This closes #xyz” , remember to leave the original message… git push if applicable, make sure to cherry-pick to all branches concerned.
Re: [ANNOUNCE] New committer: Funs Kessen
Congrats Funs! Regards, Gaurav On Apr 14, 2015, at 10:45 AM, Abhinandan Prateek abhinandan.prat...@shapeblue.com wrote: Congrats Funs ! It will be good to have you around :-) On 14-Apr-2015, at 3:00 am, Sebastien Goasguen run...@gmail.com wrote: we are doomed :) On Apr 13, 2015, at 10:05 PM, Erik Weber terbol...@gmail.com wrote: On Mon, Apr 13, 2015 at 9:41 PM, Daan Hoogland daan.hoogl...@gmail.com wrote: The Project Management Committee (PMC) for Apache CloudStack has asked Funs Kessen to become a committer and we are pleased to announce that they have accepted. Being a committer allows many contributors to contribute more autonomously. For developers, it makes it easier to submit changes and eliminates the need to have contributions reviewed via the patch submission process. Whether contributions are development-related or otherwise, it is a recognition of a contributor's participation in the project and commitment to the project and the Apache Way. Please join me in congratulating Funs Congratulations Funs! -- Erik Find out more about ShapeBlue and our range of CloudStack related services IaaS Cloud Design Buildhttp://shapeblue.com/iaas-cloud-design-and-build// CSForge – rapid IaaS deployment frameworkhttp://shapeblue.com/csforge/ CloudStack Consultinghttp://shapeblue.com/cloudstack-consultancy/ CloudStack Software Engineeringhttp://shapeblue.com/cloudstack-software-engineering/ CloudStack Infrastructure Supporthttp://shapeblue.com/cloudstack-infrastructure-support/ CloudStack Bootcamp Training Courseshttp://shapeblue.com/cloudstack-training/ This email and any attachments to it may be confidential and are intended solely for the use of the individual to whom it is addressed. Any views or opinions expressed are solely those of the author and do not necessarily represent those of Shape Blue Ltd or related companies. If you are not the intended recipient of this email, you must neither take any action based upon its contents, nor copy or show it to anyone. Please contact the sender if you believe you have received this email in error. Shape Blue Ltd is a company incorporated in England Wales. ShapeBlue Services India LLP is a company incorporated in India and is operated under license from Shape Blue Ltd. Shape Blue Brasil Consultoria Ltda is a company incorporated in Brasil and is operated under license from Shape Blue Ltd. ShapeBlue SA Pty Ltd is a company registered by The Republic of South Africa and is traded under license from Shape Blue Ltd. ShapeBlue is a registered trademark.
Re: [ANNOUNCE] New committer: Gaurav Nandkumar Aradhye
Thanks all! :-) Regards, Gaurav Aradhye On Apr 14, 2015, at 10:46 AM, Abhinandan Prateek abhinandan.prat...@shapeblue.com wrote: Welcome Gaurav ! On 14-Apr-2015, at 1:13 am, Daan Hoogland daan.hoogl...@gmail.com wrote: The Project Management Committee (PMC) for Apache CloudStack has asked Gaurav Aradhya to become a committer and we are pleased to announce that they have accepted. Being a committer allows many contributors to contribute more autonomously. For developers, it makes it easier to submit changes and eliminates the need to have contributions reviewed via the patch submission process. Whether contributions are development-related or otherwise, it is a recognition of a contributor's participation in the project and commitment to the project and the Apache Way. Please join me in congratulating Gaurav -- Daan on behalf of the CloudStack PMC Find out more about ShapeBlue and our range of CloudStack related services IaaS Cloud Design Buildhttp://shapeblue.com/iaas-cloud-design-and-build// CSForge – rapid IaaS deployment frameworkhttp://shapeblue.com/csforge/ CloudStack Consultinghttp://shapeblue.com/cloudstack-consultancy/ CloudStack Software Engineeringhttp://shapeblue.com/cloudstack-software-engineering/ CloudStack Infrastructure Supporthttp://shapeblue.com/cloudstack-infrastructure-support/ CloudStack Bootcamp Training Courseshttp://shapeblue.com/cloudstack-training/ This email and any attachments to it may be confidential and are intended solely for the use of the individual to whom it is addressed. Any views or opinions expressed are solely those of the author and do not necessarily represent those of Shape Blue Ltd or related companies. If you are not the intended recipient of this email, you must neither take any action based upon its contents, nor copy or show it to anyone. Please contact the sender if you believe you have received this email in error. Shape Blue Ltd is a company incorporated in England Wales. ShapeBlue Services India LLP is a company incorporated in India and is operated under license from Shape Blue Ltd. Shape Blue Brasil Consultoria Ltda is a company incorporated in Brasil and is operated under license from Shape Blue Ltd. ShapeBlue SA Pty Ltd is a company registered by The Republic of South Africa and is traded under license from Shape Blue Ltd. ShapeBlue is a registered trademark.
Re: Review Request 31302: CLOUDSTACK-8278: Usage test path - Correct code flow in case the usage job configuration is not to be set through test case
Done. No open requests now. Regards, Gaurav On Mon, Mar 30, 2015 at 1:54 PM, Sebastien Goasguen run...@gmail.com wrote: This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31302/ Gaurav, can you move this one to GitHub and mark it as discarded. thanks - Sebastien Goasguen On February 23rd, 2015, 11:19 a.m. UTC, Gaurav Aradhye wrote: Review request for cloudstack and sanjeev n. By Gaurav Aradhye. *Updated Feb. 23, 2015, 11:19 a.m.* *Bugs: * CLOUDSTACK-8278 https://issues.apache.org/jira/browse/CLOUDSTACK-8278 *Repository: * cloudstack-git Description The flag setUsageConfigurationThroughTestCase dictates whether we should set the usage related config from test case itself (And restart the management server and usage server in the process) or not. When the flag is False (When we don't want to disrupt other test cases and/or usage server/job is already configured), then it should be ensured that the code is broken anywhere. Set the current date to cls.curDate variable in this case to avoid code break. Ensured above changes are in. Testing yes. Diffs - test/integration/testpaths/testpath_usage.py (17d56cc) View Diff https://reviews.apache.org/r/31302/diff/
Re: [DISCUSS] Stop using Review Board
Agree. I even ported few patches from RB to PRs last week. I request all to port old patches to Github PRs. Also, learning to create pull requests takes very few minutes for those who don't know how to. Adding the message with the proper link will greatly help. Regards, Gaurav On Fri, Mar 27, 2015 at 3:55 PM, Stephen Turner stephen.tur...@citrix.com wrote: +1 from me. All our process discussions over the (Northern Hemisphere) winter agreed that GitHub is the way forward. -- Stephen Turner -Original Message- From: Sebastien Goasguen [mailto:run...@gmail.com] Sent: 27 March 2015 08:52 To: dev@cloudstack.apache.org Subject: [DISCUSS] Stop using Review Board Hi everyone, Since GitHub pull requests have been enabled for cloudstack, we have closed 127 commits. I believe this is a nicer interface, one that folks are used to when contributing to other open source projects. In the meantime, we still have 73 open reviews on Review Board https://reviews.apache.org/ * I propose that we stop using RB all together, and remove any links to it from our website and README. A few of us have tried to close some of the reviews by pinging the authors already. * My second proposition is that we write a comment in all reviews: “Thanks for the patch, the cloudstack community has decided to stop using Review Board in favor of github pull request. You can see link to learn how to submit a pull request to cloudstack. Could you move your patch to a PR ? Without response from you we will close this review within 7 days. There is good contribution guidelines in our docs README: https://github.com/apache/cloudstack-docs -Sebastien
Re: [ANNOUNCE] Rohit Yadav as new PMC member of CloudStack
Congrats Rohit! Regards, Gaurav On Fri, Mar 27, 2015 at 5:39 PM, Rohit Yadav rohit.ya...@shapeblue.com wrote: Thank you everyone :) Hope to work with you all to ship great software over years. Regards. From: Sebastien Goasguen run...@gmail.com Sent: Friday, March 27, 2015 1:37:55 PM To: dev@cloudstack.apache.org Subject: [ANNOUNCE] Rohit Yadav as new PMC member of CloudStack The Project Management Committee (PMC) for Apache CloudStack are pleased to announce that Rohit Yadav has accepted our invitation to join the PMC. Please join me in congratulating him. On behalf of the Apache CloudStack PMC Find out more about ShapeBlue and our range of CloudStack related services IaaS Cloud Design Build http://shapeblue.com/iaas-cloud-design-and-build// CSForge – rapid IaaS deployment frameworkhttp://shapeblue.com/csforge/ CloudStack Consultinghttp://shapeblue.com/cloudstack-consultancy/ CloudStack Software Engineering http://shapeblue.com/cloudstack-software-engineering/ CloudStack Infrastructure Support http://shapeblue.com/cloudstack-infrastructure-support/ CloudStack Bootcamp Training Courses http://shapeblue.com/cloudstack-training/ This email and any attachments to it may be confidential and are intended solely for the use of the individual to whom it is addressed. Any views or opinions expressed are solely those of the author and do not necessarily represent those of Shape Blue Ltd or related companies. If you are not the intended recipient of this email, you must neither take any action based upon its contents, nor copy or show it to anyone. Please contact the sender if you believe you have received this email in error. Shape Blue Ltd is a company incorporated in England Wales. ShapeBlue Services India LLP is a company incorporated in India and is operated under license from Shape Blue Ltd. Shape Blue Brasil Consultoria Ltda is a company incorporated in Brasil and is operated under license from Shape Blue Ltd. ShapeBlue SA Pty Ltd is a company registered by The Republic of South Africa and is traded under license from Shape Blue Ltd. ShapeBlue is a registered trademark.
Re: [Announce] - New VP Apache Cloudstack
Congrats Sebastien! Regards, Gaurav On Mon, Mar 23, 2015 at 7:32 PM, Sanjeev Neelarapu sanjeev.neelar...@citrix.com wrote: Congrats Sebastien!! On Mar 23, 2015 6:48 PM, Todd Pigram t...@toddpigram.com wrote: Congrats Sebastien! Thanks Hugo! On Mon, Mar 23, 2015 at 8:59 AM, Srikanteswararao Talluri srikanteswararao.tall...@citrix.com wrote: Congratulations Sebastien! And Thanks Hugo. ~Talluri On 23/03/15 5:46 pm, Paul Angus paul.an...@shapeblue.com wrote: Congratulations Sebastien!! Regards, Paul Angus Cloud Architect D: +44 20 3468 5163 |S: +44 20 3603 0540 | M: +44 7711 418 784 | T: @CloudyAngus paul.an...@shapeblue.com -Original Message- From: Erik Weber [mailto:terbol...@gmail.com] Sent: 23 March 2015 12:04 To: dev Subject: Re: [Announce] - New VP Apache Cloudstack On Mon, Mar 23, 2015 at 12:40 PM, Giles Sirett giles.sir...@shapeblue.com wrote: All The Apache Cloudstack PMC is delighted to announce that on March 18 an ASF board resolution was passed to make Sebastien Goasguen the new Chair/VP of Apache CloudStack. Sebastien replaces Hugo in this role I¹m sure you¹ll all join me in wishing Sebastien all the best for the next 12 months and also in thanking Hugo for all of his hard work over the last year. Congratulations Sebastien! Thanks for all your work Hugo! -- Erik Find out more about ShapeBlue and our range of CloudStack related services IaaS Cloud Design Buildhttp://shapeblue.com/iaas-cloud-design-and-build// CSForge rapid IaaS deployment frameworkhttp://shapeblue.com/csforge/ CloudStack Consultinghttp://shapeblue.com/cloudstack-consultancy/ CloudStack Software Engineeringhttp://shapeblue.com/cloudstack-software-engineering/ CloudStack Infrastructure Supporthttp://shapeblue.com/cloudstack-infrastructure-support/ CloudStack Bootcamp Training Courseshttp://shapeblue.com/cloudstack-training/ This email and any attachments to it may be confidential and are intended solely for the use of the individual to whom it is addressed. Any views or opinions expressed are solely those of the author and do not necessarily represent those of Shape Blue Ltd or related companies. If you are not the intended recipient of this email, you must neither take any action based upon its contents, nor copy or show it to anyone. Please contact the sender if you believe you have received this email in error. Shape Blue Ltd is a company incorporated in England Wales. ShapeBlue Services India LLP is a company incorporated in India and is operated under license from Shape Blue Ltd. Shape Blue Brasil Consultoria Ltda is a company incorporated in Brasil and is operated under license from Shape Blue Ltd. ShapeBlue SA Pty Ltd is a company registered by The Republic of South Africa and is traded under license from Shape Blue Ltd. ShapeBlue is a registered trademark. -- Todd Pigram http://about.me/ToddPigram www.linkedin.com/in/toddpigram/http://www.linkedin.com/in/toddpigram/ @pigram86 on twitter https://plus.google.com/+ToddPigram86 Mobile - 216-224-5769
Re: [GitHub] cloudstack pull request: CLOUDSTACK-8340: Adding test case for sto...
Yes, will keep it separate in future requests. Regards, Gaurav On Mon, Mar 23, 2015 at 3:55 PM, srikanteswartalluri g...@git.apache.org wrote: Github user srikanteswartalluri commented on the pull request: https://github.com/apache/cloudstack/pull/122#issuecomment-84935073 It will be easier to focus on the new tests if you keep pep8 issues separate from the intended patch. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
Re: [ANNOUNCE] New committer: Karen Vuong
Congrats Karen! Regards, Gaurav On Fri, Mar 20, 2015 at 11:58 AM, Rohit Yadav rohit.ya...@shapeblue.com wrote: Congratulations Karen, I appreciate your commitment to the project and its community! On 20-Mar-2015, at 10:10 am, Mike Tutkowski mike.tutkow...@solidfire.com wrote: Congratulations, Karen! On Thu, Mar 19, 2015 at 4:07 PM, Pierre-Luc Dion pd...@cloudops.com wrote: The Project Management Committee (PMC) for Apache CloudStack has asked Karen Vuong to become a committer and we are pleased to announce that she have accepted. Karen is doing a huge effort on promoting CloudStack and organizing events such as CloudStack days, CloudStack collaboration conferences and meetups. She is helping a lot on the marketing effort as well. Being a committer allows many contributors to contribute more autonomously. For developers, it makes it easier to submit changes and eliminates the need to have contributions reviewed via the patch submission process. Whether contributions are development-related or otherwise, it is a recognition of a contributor's participation in the project and commitment to the project and the Apache Way. Please join me in congratulating Karen (karenv) --Pierre-Luc on behalf of the CloudStack PMC -- *Mike Tutkowski* *Senior CloudStack Developer, SolidFire Inc.* e: mike.tutkow...@solidfire.com o: 303.746.7302 Advancing the way the world uses the cloud http://solidfire.com/solution/overview/?video=play*™* Regards, Rohit Yadav Software Architect, ShapeBlue M. +91 88 262 30892 | rohit.ya...@shapeblue.com Blog: bhaisaab.org | Twitter: @_bhaisaab Find out more about ShapeBlue and our range of CloudStack related services IaaS Cloud Design Build http://shapeblue.com/iaas-cloud-design-and-build// CSForge – rapid IaaS deployment frameworkhttp://shapeblue.com/csforge/ CloudStack Consultinghttp://shapeblue.com/cloudstack-consultancy/ CloudStack Software Engineering http://shapeblue.com/cloudstack-software-engineering/ CloudStack Infrastructure Support http://shapeblue.com/cloudstack-infrastructure-support/ CloudStack Bootcamp Training Courses http://shapeblue.com/cloudstack-training/ This email and any attachments to it may be confidential and are intended solely for the use of the individual to whom it is addressed. Any views or opinions expressed are solely those of the author and do not necessarily represent those of Shape Blue Ltd or related companies. If you are not the intended recipient of this email, you must neither take any action based upon its contents, nor copy or show it to anyone. Please contact the sender if you believe you have received this email in error. Shape Blue Ltd is a company incorporated in England Wales. ShapeBlue Services India LLP is a company incorporated in India and is operated under license from Shape Blue Ltd. Shape Blue Brasil Consultoria Ltda is a company incorporated in Brasil and is operated under license from Shape Blue Ltd. ShapeBlue SA Pty Ltd is a company registered by The Republic of South Africa and is traded under license from Shape Blue Ltd. ShapeBlue is a registered trademark.
Re: Need a Jenkins account
Thanks Talluri! Regards, Gaurav On Fri, Mar 20, 2015 at 3:10 PM, Srikanteswararao Talluri srikanteswararao.tall...@citrix.com wrote: Done. Details sent to your email. ~Talluri On 20/03/15 3:03 pm, Gaurav Aradhye gaurav.arad...@clogeny.com wrote: Hello all, I need a Jenkins account, to examine current jobs and also to create a new job that will statically analyze the test cases added to repository and generate a report with any issues found with the script. It will use static code analyzers for python and we can expect a report generated for every commit which modifies tests folder. Can somebody please create an account for me and give me required access? Regards, Gaurav
Need a Jenkins account
Hello all, I need a Jenkins account, to examine current jobs and also to create a new job that will statically analyze the test cases added to repository and generate a report with any issues found with the script. It will use static code analyzers for python and we can expect a report generated for every commit which modifies tests folder. Can somebody please create an account for me and give me required access? Regards, Gaurav
Guidelines for test developers
Hello all, Last year after improving Marvin framework, we have been continuously spending time in improving old test cases which are written in old style or they don't abide to certain guidelines, also which don't use new functions available in marvin. Many times a test developer who is adding test case for the first time or feature developers adding Basic Validation Tests (BVTs) tend to copy paste the code available in certain test case and try to modify it according to feature and commit it. This adds to inconsistencies. As and when I touch a file for fixing an issue or adding/editing it, I try to incorporate below guidelines and improve the existing code. But still few test files are not up to the mark. Our final goal is to have good code in every file.So writing this mail to consolidate few rules that should be known/considered by everyone adding tests to Marvin. Also, if you touch a file, feel free to remove any inconsistencies that are already present in the file. *1. Import * should always be avoided*. When I started two years back, and tried to understand the code flow/ test cases, I could not easily understand from where the particular module is imported. The imports must be specific. When the imports are specific, it eliminates the possibility of test case failure due to invalid import when specific import is removed from dependent module. E.g. If your test case has following import. from A import * And it uses time module which is not imported explicitly in test case and comes from module A. Then the test case will start failing when import timeis removed from module A. You certainly don't want this to happen. *2. Maintaining Pep8 standards for python code.* The code is read more often that it is written. Pep8 standards improve the readability of the code making it consistent in style. There is a tool named *autopep8* which you can install with pip install and then you can run following command on your test file. autopep8 -i -a -a testFile.py This will make the file pep8 consistent and will also remove the white spaces. But some issues need human intervention and can't be fixed with tool. For fixing those, check the pep8 issues with pep8 testFile.py and fix manually. *3. Keep only imports which are used* in the test suite and remove unwanted imports. *4. Keep all the configuration parameters* (such as data which is passed to API while creating Network offering, Service offering, account etc...) *in tools/marvin/marvin/config/test_data.py file*. Don't include them in test suite itself. Many of the dictionaries are reusable and if you are adding a new test, there are only a few dictionaries you will have to add in the file. If any of the data contains URLs or any data which should be changed according to setup/env, then include the dict in *configurableData* section in test_data.py file. This makes it easier to identify which data needs to be dynamic according to the setup and which data doesn't need to be touched when env is changed. *5. Before committing a test case, run it* with the latest branch against which you are adding the test case and attach the results in Pull Request. If in case change is very small, and doesn't need to be run, then at least check syntactical errors with python command and also with the help of tools such as pyflakes. 6. If you add a new function in your test case and you think it can be used in future by other test cases, then please *add that function to common or utils file* in Marvin. Don't keep it local to test case. This will prevent multiple contributors adding same functions in their test case to achieve a particular goal. *7. Please make sure all the resources created through the test cases are deleted *when test case execution completes, or even when the test case fails. 8. If same test case is to be run with different configuration or setting, you can *make use of ddt library*. For example, if you have added test case for isolated networks, and you need to run the same code for shared and VPC networks, then you don't need to add 3 test cases. Just add relevant tags to the test case and you are good to go. Although you will need to write code for handling those tags. It is already used in few test cases. A simple grep over component folder and you can see how it is used. This blog explains how it works. https://technomilk.wordpress.com/2012/02/12/multiplying-python-unit-test-cases-with-different-sets-of-data/ I will check if this is in any wiki page currently, and edit it. Or will add a new page. I hope everyone adding test cases follows above guidelines. Feel free to add more. Regards, Gaurav
Require write/edit access to Cloudstack wiki
I would like to add a page to wiki stating Guidelines for test developers. Can somebody give me access? My username is aradhye.gaurav Regards, Gaurav
Re: Review Request 27611: CLOUDSTACK-6282 - Added automated tests for filter feature
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27611/#review77011 --- test/integration/component/test_escalations_ipaddresses.py https://reviews.apache.org/r/27611/#comment124768 Please remove white-spaces. test/integration/component/test_escalations_vpncustomergateways.py https://reviews.apache.org/r/27611/#comment124772 Please fix pep8 issues - Gaurav Aradhye On March 19, 2015, 10:38 a.m., Avinash Gautam wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27611/ --- (Updated March 19, 2015, 10:38 a.m.) Review request for cloudstack and Santhosh Edukulla. Bugs: CLOUDSTACK-6282 https://issues.apache.org/jira/browse/CLOUDSTACK-6282 Repository: cloudstack-git Description --- CLOUDSTACK-6282 - Added automated tests for filter feature Diffs - test/integration/component/test_escalations_ipaddresses.py c60c5b6 test/integration/component/test_escalations_isos.py 4e818a5 test/integration/component/test_escalations_networks.py fb2196c test/integration/component/test_escalations_volumes.py 58f5845 test/integration/component/test_escalations_vpncustomergateways.py b09930a Diff: https://reviews.apache.org/r/27611/diff/ Testing --- Tested all the files to which tests are added and atatched are the result files File Attachments IPAddressresults.txt https://reviews.apache.org/media/uploaded/files/2014/11/05/3b21a80f-2917-4650-a9ca-3e213afb26fc__IPAddressresults.txt ISOresults.txt https://reviews.apache.org/media/uploaded/files/2014/11/05/2cd44d83-e7e5-47be-9c80-03d9a2f4f710__ISOresults.txt Networksresults.txt https://reviews.apache.org/media/uploaded/files/2014/11/05/7661c962-f561-4e83-8b37-bc6676bc6808__Networksresults.txt SecurityGroupsresults.txt https://reviews.apache.org/media/uploaded/files/2014/11/05/2a2d8465-2f58-4049-ad93-f878c33d5faa__SecurityGroupsresults.txt Snapshotresults.txt https://reviews.apache.org/media/uploaded/files/2014/11/05/63ba74be-bc72-4419-8b7b-1fa788275be2__Snapshotresults.txt Templatesresults.txt https://reviews.apache.org/media/uploaded/files/2014/11/05/c51e1861-7137-4186-82c8-7e3c85a31905__Templatesresults.txt Volumeresults.txt https://reviews.apache.org/media/uploaded/files/2014/11/05/f1a11419-aa10-48e0-8291-ceb762d4a734__Volumeresults.txt VPNCustomerGatewaysresults.txt https://reviews.apache.org/media/uploaded/files/2014/11/05/4c8d2447-016e-49c0-9db2-b255625cd33f__VPNCustomerGatewaysresults.txt Thanks, Avinash Gautam
Re: Guidelines for test developers
Paul, Some pages on wiki talk about general guidelines to Dev, but there is no page stating detailed guidelines for test developers. I would like to add a new page in QA section for this. Will drop separate mail for write access to wiki. Daan, I will have to check on this. I will find out how we can include static analysis for tests similar to that it is in place for dev code (findbugs). Regards, Gaurav On Wed, Mar 18, 2015 at 8:22 PM, Daan Hoogland daan.hoogl...@gmail.com wrote: good write-up Gaurav, I hope that most of these can be validated/verified checkstyle-style. pep8 can of course. Some others must remain judged by humanoids, like the one where functions are pulled up to higher abstraction layers. Maybe you could shine your light on what we can automate? i.e. can pyflakes be added to a target? -Original Message- From: Gaurav Aradhye [mailto:gaurav.arad...@clogeny.com] Sent: 18 March 2015 07:16 To: dev@cloudstack.apache.org Subject: Guidelines for test developers Hello all, Last year after improving Marvin framework, we have been continuously spending time in improving old test cases which are written in old style or they don't abide to certain guidelines, also which don't use new functions available in marvin. Many times a test developer who is adding test case for the first time or feature developers adding Basic Validation Tests (BVTs) tend to copy paste the code available in certain test case and try to modify it according to feature and commit it. This adds to inconsistencies. As and when I touch a file for fixing an issue or adding/editing it, I try to incorporate below guidelines and improve the existing code. But still few test files are not up to the mark. Our final goal is to have good code in every file.So writing this mail to consolidate few rules that should be known/considered by everyone adding tests to Marvin. Also, if you touch a file, feel free to remove any inconsistencies that are already present in the file. *1. Import * should always be avoided*. When I started two years back, and tried to understand the code flow/ test cases, I could not easily understand from where the particular module is imported. The imports must be specific. When the imports are specific, it eliminates the possibility of test case failure due to invalid import when specific import is removed from dependent module. E.g. If your test case has following import. from A import * And it uses time module which is not imported explicitly in test case and comes from module A. Then the test case will start failing when import timeis removed from module A. You certainly don't want this to happen. *2. Maintaining Pep8 standards for python code.* The code is read more often that it is written. Pep8 standards improve the readability of the code making it consistent in style. There is a tool named *autopep8* which you can install with pip install and then you can run following command on your test file. autopep8 -i -a -a testFile.py This will make the file pep8 consistent and will also remove the white spaces. But some issues need human intervention and can't be fixed with tool. For fixing those, check the pep8 issues with pep8 testFile.py and fix manually. *3. Keep only imports which are used* in the test suite and remove unwanted imports. *4. Keep all the configuration parameters* (such as data which is passed to API while creating Network offering, Service offering, account etc...) *in tools/marvin/marvin/config/test_data.py file*. Don't include them in test suite itself. Many of the dictionaries are reusable and if you are adding a new test, there are only a few dictionaries you will have to add in the file. If any of the data contains URLs or any data which should be changed according to setup/env, then include the dict in *configurableData* section in test_data.py file. This makes it easier to identify which data needs to be dynamic according to the setup and which data doesn't need to be touched when env is changed. *5. Before committing a test case, run it* with the latest branch against which you are adding the test case and attach the results in Pull Request. If in case change is very small, and doesn't need to be run, then at least check syntactical errors with python command and also with the help of tools such as pyflakes. 6. If you add a new function in your test case and you think it can be used in future by other test cases, then please *add that function to common or utils file* in Marvin. Don't keep it local to test case. This will prevent multiple contributors adding same functions in their test case to achieve a particular goal. *7. Please make sure all the resources created through the test cases are deleted *when test case execution completes, or even when the test case fails. 8. If same test case is to be run with different configuration
Re: Review Request 27611: CLOUDSTACK-6282 - Added automated tests for filter feature
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27611/#review77013 --- Please close the fixed issues. - Gaurav Aradhye On March 19, 2015, 10:38 a.m., Avinash Gautam wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27611/ --- (Updated March 19, 2015, 10:38 a.m.) Review request for cloudstack and Santhosh Edukulla. Bugs: CLOUDSTACK-6282 https://issues.apache.org/jira/browse/CLOUDSTACK-6282 Repository: cloudstack-git Description --- CLOUDSTACK-6282 - Added automated tests for filter feature Diffs - test/integration/component/test_escalations_ipaddresses.py c60c5b6 test/integration/component/test_escalations_isos.py 4e818a5 test/integration/component/test_escalations_networks.py fb2196c test/integration/component/test_escalations_volumes.py 58f5845 test/integration/component/test_escalations_vpncustomergateways.py b09930a Diff: https://reviews.apache.org/r/27611/diff/ Testing --- Tested all the files to which tests are added and atatched are the result files File Attachments IPAddressresults.txt https://reviews.apache.org/media/uploaded/files/2014/11/05/3b21a80f-2917-4650-a9ca-3e213afb26fc__IPAddressresults.txt ISOresults.txt https://reviews.apache.org/media/uploaded/files/2014/11/05/2cd44d83-e7e5-47be-9c80-03d9a2f4f710__ISOresults.txt Networksresults.txt https://reviews.apache.org/media/uploaded/files/2014/11/05/7661c962-f561-4e83-8b37-bc6676bc6808__Networksresults.txt SecurityGroupsresults.txt https://reviews.apache.org/media/uploaded/files/2014/11/05/2a2d8465-2f58-4049-ad93-f878c33d5faa__SecurityGroupsresults.txt Snapshotresults.txt https://reviews.apache.org/media/uploaded/files/2014/11/05/63ba74be-bc72-4419-8b7b-1fa788275be2__Snapshotresults.txt Templatesresults.txt https://reviews.apache.org/media/uploaded/files/2014/11/05/c51e1861-7137-4186-82c8-7e3c85a31905__Templatesresults.txt Volumeresults.txt https://reviews.apache.org/media/uploaded/files/2014/11/05/f1a11419-aa10-48e0-8291-ceb762d4a734__Volumeresults.txt VPNCustomerGatewaysresults.txt https://reviews.apache.org/media/uploaded/files/2014/11/05/4c8d2447-016e-49c0-9db2-b255625cd33f__VPNCustomerGatewaysresults.txt Thanks, Avinash Gautam
Re: Require write/edit access to Cloudstack wiki
Thanks Rajani. Regards, Gaurav On Thu, Mar 19, 2015 at 10:05 AM, Rajani Karuturi raj...@apache.org wrote: done ~Rajani On Thu, Mar 19, 2015 at 9:53 AM, Gaurav Aradhye gaurav.arad...@clogeny.com wrote: I would like to add a page to wiki stating Guidelines for test developers. Can somebody give me access? My username is aradhye.gaurav Regards, Gaurav
Re: Guidelines for test developers
I have added Wiki page for this in QA section. https://cwiki.apache.org/confluence/display/CLOUDSTACK/Guidelines+for+test+developers Not a very polished one, but I will be adding and polishing it soon. Regards, Gaurav On Thu, Mar 19, 2015 at 9:52 AM, Gaurav Aradhye gaurav.arad...@clogeny.com wrote: Paul, Some pages on wiki talk about general guidelines to Dev, but there is no page stating detailed guidelines for test developers. I would like to add a new page in QA section for this. Will drop separate mail for write access to wiki. Daan, I will have to check on this. I will find out how we can include static analysis for tests similar to that it is in place for dev code (findbugs). Regards, Gaurav On Wed, Mar 18, 2015 at 8:22 PM, Daan Hoogland daan.hoogl...@gmail.com wrote: good write-up Gaurav, I hope that most of these can be validated/verified checkstyle-style. pep8 can of course. Some others must remain judged by humanoids, like the one where functions are pulled up to higher abstraction layers. Maybe you could shine your light on what we can automate? i.e. can pyflakes be added to a target? -Original Message- From: Gaurav Aradhye [mailto:gaurav.arad...@clogeny.com] Sent: 18 March 2015 07:16 To: dev@cloudstack.apache.org Subject: Guidelines for test developers Hello all, Last year after improving Marvin framework, we have been continuously spending time in improving old test cases which are written in old style or they don't abide to certain guidelines, also which don't use new functions available in marvin. Many times a test developer who is adding test case for the first time or feature developers adding Basic Validation Tests (BVTs) tend to copy paste the code available in certain test case and try to modify it according to feature and commit it. This adds to inconsistencies. As and when I touch a file for fixing an issue or adding/editing it, I try to incorporate below guidelines and improve the existing code. But still few test files are not up to the mark. Our final goal is to have good code in every file.So writing this mail to consolidate few rules that should be known/considered by everyone adding tests to Marvin. Also, if you touch a file, feel free to remove any inconsistencies that are already present in the file. *1. Import * should always be avoided*. When I started two years back, and tried to understand the code flow/ test cases, I could not easily understand from where the particular module is imported. The imports must be specific. When the imports are specific, it eliminates the possibility of test case failure due to invalid import when specific import is removed from dependent module. E.g. If your test case has following import. from A import * And it uses time module which is not imported explicitly in test case and comes from module A. Then the test case will start failing when import timeis removed from module A. You certainly don't want this to happen. *2. Maintaining Pep8 standards for python code.* The code is read more often that it is written. Pep8 standards improve the readability of the code making it consistent in style. There is a tool named *autopep8* which you can install with pip install and then you can run following command on your test file. autopep8 -i -a -a testFile.py This will make the file pep8 consistent and will also remove the white spaces. But some issues need human intervention and can't be fixed with tool. For fixing those, check the pep8 issues with pep8 testFile.py and fix manually. *3. Keep only imports which are used* in the test suite and remove unwanted imports. *4. Keep all the configuration parameters* (such as data which is passed to API while creating Network offering, Service offering, account etc...) *in tools/marvin/marvin/config/test_data.py file*. Don't include them in test suite itself. Many of the dictionaries are reusable and if you are adding a new test, there are only a few dictionaries you will have to add in the file. If any of the data contains URLs or any data which should be changed according to setup/env, then include the dict in *configurableData* section in test_data.py file. This makes it easier to identify which data needs to be dynamic according to the setup and which data doesn't need to be touched when env is changed. *5. Before committing a test case, run it* with the latest branch against which you are adding the test case and attach the results in Pull Request. If in case change is very small, and doesn't need to be run, then at least check syntactical errors with python command and also with the help of tools such as pyflakes. 6. If you add a new function in your test case and you think it can be used in future by other test cases, then please *add that function to common or utils file* in Marvin. Don't keep it local to test case. This will prevent
Re: Review Request 32094: test case added to verify restore VM operation
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32094/#review76540 --- test/integration/component/test_escalations_instances.py https://reviews.apache.org/r/32094/#comment124110 Please keep specific imports rather than import * test/integration/component/test_escalations_instances.py https://reviews.apache.org/r/32094/#comment124111 Not sure if we running/skipping tests on specific hypervisor depending uppon tags. Can you add a condition in the test case? test/integration/component/test_escalations_instances.py https://reviews.apache.org/r/32094/#comment124113 Please remove pep8 issues test/integration/component/test_escalations_instances.py https://reviews.apache.org/r/32094/#comment124112 Please use validateList method fomr utils.py test/integration/component/test_escalations_instances.py https://reviews.apache.org/r/32094/#comment124115 Please read host credentails from configurableData section in test_data.py file test/integration/component/test_escalations_instances.py https://reviews.apache.org/r/32094/#comment124116 No need to sleep as the check is included in base library, check VirtualMachine.start() function tools/marvin/marvin/config/test_data.py https://reviews.apache.org/r/32094/#comment124117 Will this work on automated builds? tools/marvin/marvin/config/test_data.py https://reviews.apache.org/r/32094/#comment124118 Unwanted change? - Gaurav Aradhye On March 16, 2015, 2:53 p.m., shweta agarwal wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32094/ --- (Updated March 16, 2015, 2:53 p.m.) Review request for cloudstack, sanjeev n and SrikanteswaraRao Talluri. Repository: cloudstack-git Description --- test case added to verify restore VM operation Diffs - test/integration/component/test_escalations_instances.py 4b22016 tools/marvin/marvin/config/test_data.py 80ead64 Diff: https://reviews.apache.org/r/32094/diff/ Testing --- Yes Thanks, shweta agarwal
Re: Review Request 28437: CLOUDSTACK-6282 Added automated ACL tests
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28437/#review76539 --- test/integration/component/test_escalations_networks.py https://reviews.apache.org/r/28437/#comment124109 Please remvoe all import * - Gaurav Aradhye On March 16, 2015, 2:08 p.m., anusha bilgi wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28437/ --- (Updated March 16, 2015, 2:08 p.m.) Review request for cloudstack and Santhosh Edukulla. Bugs: cloudstack-6282 https://issues.apache.org/jira/browse/cloudstack-6282 Repository: cloudstack-git Description --- CLOUDSTACK-6282 Added automated ACL tests Diffs - test/integration/component/test_escalations_networks.py fb2196c Diff: https://reviews.apache.org/r/28437/diff/ Testing --- Tests the changed files and attached are the results for the same File Attachments results.txt https://reviews.apache.org/media/uploaded/files/2014/11/25/61351189-70e9-4fa6-8bcf-035d28fa61e6__results.txt Thanks, anusha bilgi
Re: Review Request 28437: CLOUDSTACK-6282 Added automated ACL tests
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28437/#review76351 --- test/integration/component/test_escalations_networks.py https://reviews.apache.org/r/28437/#comment123913 Please change import * to specific imports. test/integration/component/test_escalations_networks.py https://reviews.apache.org/r/28437/#comment123914 Please remove the white-spaces. - Gaurav Aradhye On March 13, 2015, 4:43 p.m., anusha bilgi wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28437/ --- (Updated March 13, 2015, 4:43 p.m.) Review request for cloudstack and Santhosh Edukulla. Bugs: cloudstack-6282 https://issues.apache.org/jira/browse/cloudstack-6282 Repository: cloudstack-git Description --- CLOUDSTACK-6282 Added automated ACL tests Diffs - test/integration/component/test_escalations_networks.py fb2196c Diff: https://reviews.apache.org/r/28437/diff/ Testing --- Tests the changed files and attached are the results for the same File Attachments results.txt https://reviews.apache.org/media/uploaded/files/2014/11/25/61351189-70e9-4fa6-8bcf-035d28fa61e6__results.txt Thanks, anusha bilgi
Re: [GitHub] cloudstack pull request: CLOUDSTACK-8323: Adding test case to veri...
Yes ran the test case on master. It succeeded. Although it is skipped for now because it needs VCenter integration. It will be easy to enable this test in future once it is available. Log: Add network to running VM ... === TestName: test_vm_nic_adapter_vmxnet3 | Status : SUCCESS === ok -- Ran 1 test in 490.175s OK Regards, Gaurav On Thu, Mar 12, 2015 at 3:27 PM, bhaisaab g...@git.apache.org wrote: Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/116#issuecomment-78451371 @gauravaradhye looks good, any results/outputs? Sorry not a test guru to help review/merge it. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
Re: Jira Housekeeping - 'Old Blockers'
5108, 5095, 5195 are no more relevant and are closed now. Those were test failures, and not product failures. Regards, Gaurav On Thu, Mar 12, 2015 at 11:41 PM, Paul Angus paul.an...@shapeblue.com wrote: Thanks Francois, I'll go through them and see what looks fair. Regards Paul Angus Cloud Architect S: +44 20 3603 0540 | M: +447711418784 | T: CloudyAngus paul.an...@shapeblue.com -Original Message- From: Francois Gaudreault [mailto:fgaudrea...@cloudops.com] Sent: 12 March 2015 03:49 To: dev@cloudstack.apache.org Subject: Re: Jira Housekeeping - 'Old Blockers' Paul, I do see my name beside some of these :S I believe it's fair to downgrade mine to something lower and/or close them. However, I am pretty sure these bugs still exists today, but unfortunately I'm not equipped to fully retest them. If you go with the close option, I can reopen them later if needed. Thanks! FG On 2015-03-10 9:26 AM, Paul Angus wrote: Thanks Rajani, It's an interesting read. I'm hoping to rope a load of people into the overall effort. There are 1468 open issues in Jira, we really need to start by cleaning up duplicates, obsolete issues, and 'non-issues'. Regards Paul Angus Cloud Architect S: +44 20 3603 0540 | M: +447711418784 | T: CloudyAngus paul.an...@shapeblue.com -Original Message- From: Rajani Karuturi [mailto:raj...@apache.org] Sent: 08 March 2015 10:50 To: dev@cloudstack.apache.org Subject: Re: Jira Housekeeping - 'Old Blockers' I would like to share a blog post I read recently which I believe is relevant in this context. http://words.steveklabnik.com/how-to-be-an-open-source-gardener ~Rajani On Sat, Mar 7, 2015 at 11:18 PM, Daan Hoogland daan.hoogl...@gmail.com wrote: Guys, It has been discussed before and My proposal was that no issue is a blocker unless it has been discussed as such on dev@. This has never been voted on AFAIR. No release should go out with a blocker open, so 'old' blockers is kind of awkward. I'd say triage them and close or downgrade. On Fri, Mar 6, 2015 at 12:51 PM, Abhinandan Prateek abhinandan.prat...@shapeblue.com wrote: Hi Paul, This is a good initiative ! I think we should clean up Jira as we go forward. Blockers languishing around is not a good sign. I personally feel that blockers that are more than a year old can be safely closed, as these may be hard to reproduce as things have changed since then or probably these are not relevant now. anything remaining should then be worked upon and resolved/closed. On 06-Mar-2015, at 3:42 pm, Paul Angus paul.an...@shapeblue.com mailto: paul.an...@shapeblue.com wrote: Hey Guys, I’m thinking that it would be a good idea to do a bit of Jira housekeeping to clear up any orphaned bugs (or fix any long standing issues). So, starting at the top, we have 9 ‘Blockers’ to old releases. Which are still hanging around. Could people maybe pick one or two and close them if no longer an issue or update the Affects Version(s) if it’s still relevant ? Issue Type Key Summary Assignee Reporter Priority Status Resolution Created Updated Affects Version/s Bug CLOUDSTACK-6801https://issues.apache.org/jira/browse/CLOUDSTACK-680 1 Public IP not assigned to eth1 on VR in VPC Unassigned Andrija Panic Blocker Open Unresolved 28/05/2014 20:19 30/05/2014 18:36 4.3.0 Bug CLOUDSTACK-6004https://issues.apache.org/jira/browse/CLOUDSTACK-600 4 Cannot do Local to Local Xen StorageMotion using XS6.2SP1 Unassigned Francois Gaudreault Blocker Open Unresolved 31/01/2014 15:21 31/01/2014 15:24 4.2.1 Bug CLOUDSTACK-5717https://issues.apache.org/jira/browse/CLOUDSTACK-571 7 Unable to start new instance Unassigned Alex Rybchenko Blocker Open Unresolved 02/01/2014 11:34 02/01/2014 11:44 4.2.0 Bug CLOUDSTACK-5397https://issues.apache.org/jira/browse/CLOUDSTACK-539 7 Starting VM fails if VM snapshot is created Unassigned Antonio Petrocelli Blocker Open Unresolved 06/12/2013 08:31 06/12/2013 08:31 4.2.0 Bug CLOUDSTACK-5159https://issues.apache.org/jira/browse/CLOUDSTACK-515 9 Reset SSH keypair sometimes fails in Vmware Unassigned Girish Shilamkar Blocker Open Unresolved 14/11/2013 05:29 14/11/2013 05:29 4.2.1 Bug CLOUDSTACK-5108https://issues.apache.org/jira/browse/CLOUDSTACK-510 8 test_vpc_network_pfules tests sometimes fails to wget from spawned instance Unassigned Girish Shilamkar Blocker Open Unresolved 08/11/2013 13:13 08/11/2013 14:46 4.2.1 Bug CLOUDSTACK-5095https://issues.apache.org/jira/browse/CLOUDSTACK-509 5 est_project_limits.TestResourceLimitsProject.test_05_snapshots_per_pr o ject fails
Re: [GitHub] cloudstack pull request: CLOUDSTACK-8323: Adding test case to veri...
Rebased, please try now. Regards, Gaurav On Thu, Mar 12, 2015 at 4:41 PM, bhaisaab g...@git.apache.org wrote: Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/116#issuecomment-78461087 @gauravaradhye patch fails to apply on latest master, please rebase and send a mergeable patch --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
Re: Review Request 31526: CLOUDSTACK-8290: Adding BVT to verify public IP data is removed from router once network rule is deleted.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31526/ --- (Updated March 12, 2015, 11:16 a.m.) Review request for cloudstack, Jayapal Reddy and SrikanteswaraRao Talluri. Summary (updated) - CLOUDSTACK-8290: Adding BVT to verify public IP data is removed from router once network rule is deleted. Bugs: CLOUDSTACK-8290 https://issues.apache.org/jira/browse/CLOUDSTACK-8290 Repository: cloudstack-git Description (updated) --- Steps that should be added to verify absence of the defect. 1. Create a VM in an isolated network 2. Acquire a public IP in the network 3. Enable static NAT rule / LB rule / NAT rule for the IP 4. Check we are able to SSH to VM 5. Check the ip addr command output on VR, the rules should be present on VR for the public IP 6. Disable static NAT / Delete NAT/ LB Rule or disassociate public IP 7. Check SSH to VM, it should fail 8. Check the ip addr command output on VR, the rules should now not be present on VR for the public IP Diffs - test/integration/smoke/test_network.py cca1803 tools/marvin/marvin/codes.py a7e8ec8 Diff: https://reviews.apache.org/r/31526/diff/ Testing --- Test for Static NAT rule for acquired public IP ... === TestName: test_network_rules_acquired_public_ip_1_static_nat_rule | Status : SUCCESS === ok Test for Static NAT rule for acquired public IP ... === TestName: test_network_rules_acquired_public_ip_2_nat_rule | Status : SUCCESS === ok Test for Static NAT rule for acquired public IP ... === TestName: test_network_rules_acquired_public_ip_3_Load_Balancer_Rule | Status : SUCCESS === ok -- Ran 3 tests in 409.871s OK Thanks, Gaurav Aradhye
Re: [ANNOUNCE] New committer: Harikrishna Patnala
Congrats Hari! Regards, Gaurav On Tue, Mar 10, 2015 at 12:50 PM, Rajesh Battala rajesh.batt...@citrix.com wrote: Hearty Congratulations Harikrishna :) -Original Message- From: Rajani Karuturi [mailto:raj...@apache.org] Sent: Tuesday, March 10, 2015 11:00 AM To: dev@cloudstack.apache.org Subject: [ANNOUNCE] New committer: Harikrishna Patnala The Project Management Committee (PMC) for Apache CloudStack has asked Harikrishna Patnala to become a committer and we are pleased to announce that he has accepted. Being a committer allows many contributors to contribute more autonomously. For developers, it makes it easier to submit changes and eliminates the need to have contributions reviewed via the patch submission process. Whether contributions are development-related or otherwise, it is a recognition of a contributor's participation in the project and commitment to the project and the Apache Way. Please join me in congratulating Hari. https://github.com/apache/cloudstack/commits/master?author=harikrishna-patnala Keep them coming. :) -- on behalf of the CloudStack PMC, ~Rajani
Re: [GitHub] cloudstack pull request: CLOUDSTACK-8299: Adding test case to test...
Regards, Gaurav On Wed, Mar 4, 2015 at 6:36 PM, gauravaradhye g...@git.apache.org wrote: GitHub user gauravaradhye opened a pull request: https://github.com/apache/cloudstack/pull/95 CLOUDSTACK-8299: Adding test case to test ingress rule for security group for specific IP set Adding test case to test ingress rules for specific IP sets (Not 0.0.0.0/0, e.g. 10.2.3.4/32) and also to test that VM is not accessed from outside the given IP range. You can merge this pull request into a Git repository by running: $ git pull https://github.com/gauravaradhye/cloudstack master Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cloudstack/pull/95.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #95 commit a86ed2ce71563bb7501e7e53c5f08d49327da496 Author: Gaurav Aradhye gaurav.arad...@clogeny.com Date: 2015-03-04T12:59:18Z CLOUDSTACK-8299: Adding test case to test security group ingress rules for a specific IP set --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
Re: Review Request 31526: CLOUDSTACK-8290: Adding BVT to verofy product issue CS-27153
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31526/ --- (Updated Feb. 27, 2015, 4:55 p.m.) Review request for cloudstack, Jayapal Reddy and SrikanteswaraRao Talluri. Bugs: CLOUDSTACK-8290 https://issues.apache.org/jira/browse/CLOUDSTACK-8290 Repository: cloudstack-git Description (updated) --- The bug that was found is Public IP data remained on router even after disabling the static NAT rule configured on public IP Steps that should be added to verify absence of the defect. 1. Create a VM in an isolated network 2. Acquire a public IP in the network 3. Enable static NAT rule / LB rule / NAT rule for the IP 4. Check we are able to SSH to VM 5. Check the ip addr command output on VR, the rules should be present on VR for the public IP 6. Disable static NAT / Delete NAT/ LB Rule or disassociate public IP 7. Check SSH to VM, it should fail 8. Check the ip addr command output on VR, the rules should now not be present on VR for the public IP Diffs (updated) - test/integration/smoke/test_network.py cca1803 tools/marvin/marvin/codes.py a7e8ec8 Diff: https://reviews.apache.org/r/31526/diff/ Testing (updated) --- Test for Static NAT rule for acquired public IP ... === TestName: test_network_rules_acquired_public_ip_1_static_nat_rule | Status : SUCCESS === ok Test for Static NAT rule for acquired public IP ... === TestName: test_network_rules_acquired_public_ip_2_nat_rule | Status : SUCCESS === ok Test for Static NAT rule for acquired public IP ... === TestName: test_network_rules_acquired_public_ip_3_Load_Balancer_Rule | Status : SUCCESS === ok -- Ran 3 tests in 409.871s OK Thanks, Gaurav Aradhye
Review Request 31526: CLOUDSTACK-8290: Adding BVT to verofy product issue CS-27153
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31526/ --- Review request for cloudstack, Jayapal Reddy and SrikanteswaraRao Talluri. Bugs: CLOUDSTACK-8290 https://issues.apache.org/jira/browse/CLOUDSTACK-8290 Repository: cloudstack-git Description --- The bug that was found is Public IP data remained on router even after disabling the static NAT rule configured on public IP Steps that should be added to verify absence of the defect. 1. Create a VM in an isolated network 2. Acquire a public IP in the network 3. Enable static NAT rule / LB rule / NAT rule for the IP 4. Check we are able to SSH to VM 5. Check the ip addr command output on VR, the rules should be present on VR for the public IP 6. Disable static NAT / Delete NAT/ LB Rule or disassociate public IP 7. Check SSH to VM, it should fail 8. Check the ip addr command output on VR, the rules should now not be present on VR for the public IP Added a new test case with above steps. Currently done only for Static NAT rule. I am in process of validating this for LB and NAT rules. Diffs - test/integration/smoke/test_network.py cca1803 Diff: https://reviews.apache.org/r/31526/diff/ Testing --- Test for Static NAT rule for acquired public IP ... === TestName: test_network_rules_acquired_public_ip_1_static_nat_rule | Status : SUCCESS === ok -- Ran 1 test in 839.046s OK Thanks, Gaurav Aradhye
Review Request 31482: CLOUDSTACK-8286: Adding Basic validation test case to test deploying VM from ISO and correcting old regression test case to test HA VM from ISO
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31482/ --- Review request for cloudstack and SrikanteswaraRao Talluri. Bugs: CLOUDSTACK-8286 https://issues.apache.org/jira/browse/CLOUDSTACK-8286 Repository: cloudstack-git Description --- Corrected regression test case to deploy HA VM from ISO, and also added a new BVT to test basic VM deplopyment from ISO. ISO URL modified in test_data.py Diffs - test/integration/component/test_stopped_vm.py 92822c3 test/integration/smoke/test_deploy_vm_iso.py PRE-CREATION tools/marvin/marvin/config/test_data.py 80e0abd Diff: https://reviews.apache.org/r/31482/diff/ Testing --- Test Deploy HA enabled Virtual Machine from ISO ... === TestName: test_02_deploy_ha_vm_from_iso | Status : SUCCESS === ok -- Ran 1 test in 3108.763s OK Thanks, Gaurav Aradhye
Review Request 31302: CLOUDSTACK-8278: Usage test path - Correct code flow in case the usage job configuration is not to be set through test case
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31302/ --- Review request for cloudstack and sanjeev n. Bugs: CLOUDSTACK-8278 https://issues.apache.org/jira/browse/CLOUDSTACK-8278 Repository: cloudstack-git Description --- The flag setUsageConfigurationThroughTestCase dictates whether we should set the usage related config from test case itself (And restart the management server and usage server in the process) or not. When the flag is False (When we don't want to disrupt other test cases and/or usage server/job is already configured), then it should be ensured that the code is broken anywhere. Set the current date to cls.curDate variable in this case to avoid code break. Ensured above changes are in. Diffs - test/integration/testpaths/testpath_usage.py 17d56cc Diff: https://reviews.apache.org/r/31302/diff/ Testing --- yes. Thanks, Gaurav Aradhye
Review Request 31295: CLOUDSTACK-8276: Changes in Marvin to find free vlan in a setup when vlan is not returned for an existing network with listNetworks API
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31295/ --- Review request for cloudstack and sanjeev n. Bugs: CLOUDSTACK-8276 https://issues.apache.org/jira/browse/CLOUDSTACK-8276 Repository: cloudstack-git Description --- listNetworks API previously returned the value for vlan as untagged when vlan was not assigned to a network. Now the vlan attribute itself is not returned in this case. In this case, vlan attribute value by default will be None. Added the extra check in common function. Diffs - tools/marvin/marvin/lib/common.py c59cf10 Diff: https://reviews.apache.org/r/31295/diff/ Testing --- Add secondary IP to NIC of a VM ... === TestName: test_delete_PF_nat_rule_1_ISOLATED | Status : SUCCESS === ok Add secondary IP to NIC of a VM ... === TestName: test_delete_PF_nat_rule_2_SHARED | Status : SUCCESS === ok Add secondary IP to NIC of a VM ... === TestName: test_delete_PF_nat_rule_3_VPC | Status : SUCCESS === ok Add secondary IP to NIC of a VM ... === TestName: test_disable_static_nat_1_ISOLATED | Status : SUCCESS === ok Add secondary IP to NIC of a VM ... === TestName: test_disable_static_nat_2_SHARED | Status : SUCCESS === ok Add secondary IP to NIC of a VM ... === TestName: test_disable_static_nat_3_VPC | Status : SUCCESS === ok Add secondary IP to NIC of a VM ... === TestName: test_disassociate_ip_mapped_to_secondary_ip_through_PF_rule_1_ISOLATED | Status : SUCCESS === ok Add secondary IP to NIC of a VM ... === TestName: test_disassociate_ip_mapped_to_secondary_ip_through_PF_rule_2_SHARED | Status : SUCCESS === ok Add secondary IP to NIC of a VM ... === TestName: test_disassociate_ip_mapped_to_secondary_ip_through_PF_rule_3_VPC | Status : SUCCESS === ok Test Shared Network ALL ... -- Ran 1 test in 570.117s OK Thanks, Gaurav Aradhye
Review Request 31296: CLOUDSTACK-8277: Code improvement - test_multiple_ip_ranges.py, test_shared_networks.py
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31296/ --- Review request for cloudstack and sanjeev n. Bugs: CLOUDSTACK-8277 https://issues.apache.org/jira/browse/CLOUDSTACK-8277 Repository: cloudstack-git Description --- The test suites require following code improvements. 1. Remove import *, and replace with specific imports 2. Fix pep8 issues. 3. Remove unnecessary try catch blocks 4. Print detailed exception message whenever missing Above changes included in the patch. Diffs - test/integration/component/test_multiple_ips_per_nic.py 58aac9f test/integration/component/test_shared_networks.py 4d71ed3 Diff: https://reviews.apache.org/r/31296/diff/ Testing --- Yes. Add secondary IP to NIC of a VM ... === TestName: test_add_ip_to_nic_1_SHARED | Status : SUCCESS === ok Test listing nics associated with the ip address ... === TestName: test_list_nics_1_SHARED | Status : SUCCESS === ok Test basic operations using non root admin apii client ... === TestName: test_operations_non_root_admin_api_client_1_SHARED | Status : SUCCESS === ok Remove invalid ip ... === TestName: test_remove_invalid_ip | Status : SUCCESS === ok Add secondary IP to NIC of a VM ... === TestName: test_delete_PF_nat_rule_1_ISOLATED | Status : SUCCESS === ok Add secondary IP to NIC of a VM ... === TestName: test_delete_PF_nat_rule_2_SHARED | Status : SUCCESS === ok Add secondary IP to NIC of a VM ... === TestName: test_delete_PF_nat_rule_3_VPC | Status : SUCCESS === ok Add secondary IP to NIC of a VM ... === TestName: test_disable_static_nat_1_ISOLATED | Status : SUCCESS === ok Add secondary IP to NIC of a VM ... === TestName: test_disable_static_nat_2_SHARED | Status : SUCCESS === ok Add secondary IP to NIC of a VM ... === TestName: test_disable_static_nat_3_VPC | Status : SUCCESS === ok Add secondary IP to NIC of a VM ... === TestName: test_disassociate_ip_mapped_to_secondary_ip_through_PF_rule_1_ISOLATED | Status : SUCCESS === ok Add secondary IP to NIC of a VM ... === TestName: test_disassociate_ip_mapped_to_secondary_ip_through_PF_rule_2_SHARED | Status : SUCCESS === ok Add secondary IP to NIC of a VM ... === TestName: test_disassociate_ip_mapped_to_secondary_ip_through_PF_rule_3_VPC | Status : SUCCESS === ok Test Shared Network ALL ... -- Ran 1 test in 570.117s OK Thanks, Gaurav Aradhye
Re: [QUESTION] How is snapshot size counted in secondary storage?
Hello all, A small update which closes this question. Now the listSnapshots API provides the size of the snapshot precisely (physicalsize attribute), and when I count it to match with total secondary storage count for an account, then there is no descrepancy. This facility is in with commit 9153b8bede3350750cb7a78891e0479cc72aa2ec. Also the regression tests have been modified accordingly to test secondary storage limits functionality correctly according to above mentioned changes. Regards, Gaurav On Thu, Dec 11, 2014 at 3:48 AM, Mike Tutkowski mike.tutkow...@solidfire.com wrote: Including Kelven directly on this using a different e-mail address (first e-mail address bounced). On Wed, Dec 10, 2014 at 3:16 PM, Mike Tutkowski mike.tutkow...@solidfire.com wrote: Hi everyone, Can anyone answer these questions Gaurav has about secondary storage? Marcus - Perhaps you know for KVM? Kelven - Perhaps you know for VMware? Thanks! Mike On Wed, Dec 10, 2014 at 4:55 AM, Gaurav Aradhye gaurav.arad...@clogeny.com wrote: Thanks Mike for details reply! I checked on VMware and KVM. On KVM, after first snapshot, the secondary storage count for account increases by 1 (template + snapshot I suppose). After second snapshot, it again increases by 1. On VmWare, the secondary storage count remains the same irrespective of how many snapshots I create. This is clearly an issue. I have two questions. 1) How can we know the snapshot size? The size is not listed in any API. 2) Is snapshot size counted in secondary storage count (and hence considered in SS limits)? I just want to be sure here. Regards, Gaurav On Tue, Dec 9, 2014 at 11:17 AM, Mike Tutkowski mike.tutkow...@solidfire.com wrote: I guess I would expect the non-zero blocks of your disk to be backed up the first time, which could lead to anywhere from some small amount of space all the way up to 8 GB (in your situation). However, you mentioned that you see 9 GB consumed, which does seem unexpected. When you say your template is 8 GB, I assume that's its physical size (and the root disk's virtual size could be larger). If that's the case, I would expect 8 GB to be backed up for the first snapshot. On Mon, Dec 8, 2014 at 10:39 PM, Gaurav Aradhye gaurav.arad...@clogeny.com wrote: Thanks Mike! However, I am observing this in case of first snapshot also. Let me try on various hypervisors to see the behavior. Regards, Gaurav On Tue, Dec 9, 2014 at 11:04 AM, Mike Tutkowski mike.tutkow...@solidfire.com wrote: I'm not exactly sure how this number is calculated, but - if you are using XenServer - remember that after the first snapshot for a volume, each subsequent snapshot is only the blocks that have changed since the prior snapshot (this might even be true for ESX these days with CloudStack). That being the case, unless you change all 8 GB of blocks each time before doing a snapshot, you should expect your snapshots to be 8 GB (potentially very small, if you didn't change much since the last snapshot). On Mon, Dec 8, 2014 at 10:15 PM, Gaurav Aradhye gaurav.arad...@clogeny.com wrote: Hello, When I create a snapshot, from say, template registered through an account, then 1) How can I know the snapshot size on secondary storage? (API listSnapshots does not specify the snapshot size) 2) How is snapshot size counted in secondary storage used by the account? Currently I can see secondary storage count increasing by the (number of snapshots) and not the snapshot size. E.g. I have template sized 8 GB. I create a snapshot from it. Now if I list the secondary storage used by the account, then it lists as 9 (GB). If I create another snapshot, then it lists it as 10. It is not possible for my snapshot size to be 1 (GB) because it's created from root volume having size 8 GB. Can I say it's a bug? Secondary storage count being listed as (Storage other than snapshot + number of snapshots) GB. Regards, Gaurav -- *Mike Tutkowski* *Senior CloudStack Developer, SolidFire Inc.* e: mike.tutkow...@solidfire.com o: 303.746.7302 Advancing the way the world uses the cloud http://solidfire.com/solution/overview/?video=play*™* -- *Mike Tutkowski* *Senior CloudStack Developer, SolidFire Inc.* e: mike.tutkow...@solidfire.com o: 303.746.7302 Advancing the way the world uses the cloud http://solidfire.com/solution/overview/?video=play*™* -- *Mike Tutkowski* *Senior CloudStack Developer, SolidFire Inc.* e: mike.tutkow
Review Request 31180: CLOUDSTACK-8269: Code changes in primary storage test cases as per recent change in product behavior
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31180/ --- Review request for cloudstack and SrikanteswaraRao Talluri. Bugs: CLOUDSTACK-8269 https://issues.apache.org/jira/browse/CLOUDSTACK-8269 Repository: cloudstack-git Description --- 1. Earlier volume would get deleted when vm is deleted, now the volume does not get deleted and it remains in detached state unless account is removed. This volume gets counted in primary storage count of the account. 2. Earlier when volume was detached from VM, the primary storage count of the account would get reduced by the volume size. Now the primary storage count does not get reduced unless the volume is deleted. The patch contains appropriate changes in the test cases as per changed behavior in product as stated above. Diffs - test/integration/component/test_ps_domain_limits.py d9c1018 test/integration/component/test_ps_limits.py c9a754b Diff: https://reviews.apache.org/r/31180/diff/ Testing --- Test primary storage limit of domain and its sub-domains ... === TestName: test_01_multiple_domains_primary_storage_limits | Status : SUCCESS === ok Test primary storage counts in multiple child domains ... === TestName: test_02_multiple_domains_primary_storage_limits | Status : SUCCESS === ok Test primary storage counts in multiple child domains ... === TestName: test_03_multiple_domains_multiple_volumes | Status : SUCCESS === ok Test create snapshot and templates from volume ... === TestName: test_04_create_template_snapshot | Status : SUCCESS === ok Test assign virtual machine to account belonging to different domain ... === TestName: test_05_assign_virtual_machine_different_domain | Status : SUCCESS === ok Test primary storage counts while destroying and recovering VM ... === TestName: test_06_destroy_recover_vm | Status : SUCCESS === ok -- Ran 6 tests in 1619.606s OK Test Deploy multiple VMs with verify the usage ... === TestName: test_deploy_multiple_vm_1_root_domain_admin | Status : SUCCESS === ok Test Deploy multiple VMs with verify the usage ... === TestName: test_deploy_multiple_vm_2_child_domain_admin | Status : SUCCESS === ok -- Ran 2 tests in 399.904s OK Thanks, Gaurav Aradhye
Review Request 31181: CLOUDSTACK-8268: Code improvement - test_stopped_vm.py
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31181/ --- Review request for cloudstack and SrikanteswaraRao Talluri. Bugs: CLOUDSTACK-8268 https://issues.apache.org/jira/browse/CLOUDSTACK-8268 Repository: cloudstack-git Description --- 1. Read all the test data from test_data.py 2. Remove hard coded test data (Services class) from the test suite 3. Fix autopep8 issues 4. Move bootableVolume to configurableData section and make relevant changes in test case to read the data according to hypervisor Diffs - test/integration/component/test_stopped_vm.py 1cefc07 tools/marvin/marvin/config/test_data.py e8365ed Diff: https://reviews.apache.org/r/31181/diff/ Testing --- Test Deploy HA enabled Virtual Machine with startvm=false ... === TestName: test_01_deploy_ha_vm_startvm_false | Status : SUCCESS === ok Test Deploy HA enabled Virtual Machine from ISO ... SKIP: Bootable Iso URL not present in test data for xenserver Test Deploy HA enabled Virtual Machine from ISO with startvm=false ... === TestName: test_03_deploy_ha_vm_iso_startvm_false | Status : SUCCESS === ok Test deploy VM on specific host ... === TestName: test_deployVmOnGivenHost | Status : SUCCESS === ok Test Deploy Virtual Machine with no startVM parameter ... === TestName: test_01_deploy_vm_no_startvm | Status : SUCCESS === ok Test Deploy Virtual Machine with startVM=true parameter ... === TestName: test_02_deploy_vm_startvm_true | Status : SUCCESS === ok Test Deploy Virtual Machine with startVM=false parameter ... === TestName: test_03_deploy_vm_startvm_false | Status : SUCCESS === ok Test Deploy Virtual Machine with startVM=false and attach volume ... === TestName: test_04_deploy_startvm_false_attach_volume | Status : SUCCESS === ok Test Deploy Virtual Machine with startVM=false and change service offering ... === TestName: test_05_deploy_startvm_false_change_so | Status : SUCCESS === ok Test Deploy Virtual Machine with startVM=false and ... === TestName: test_06_deploy_startvm_attach_detach | Status : SUCCESS === ok Test Deploy Virtual Machine with startVM=false and attach ISO ... === TestName: test_07_deploy_startvm_attach_iso | Status : SUCCESS === ok Test Deploy Virtual Machine with startVM=false and attach volume already attached to different machine ... === TestName: test_08_deploy_attached_volume | Status : SUCCESS === ok Test Stopped Virtual Machine's ROOT volume migration ... SKIP: No cluster with more than one primary storage pool to perform migrate volume test Test Deploy Virtual Machine with startVM=false enabledpassword in ... === TestName: test_deploy_vm_password_enabled | Status : SUCCESS === ok Test Deploy Virtual Machine with no startVM parameter ... === TestName: test_01_deploy_vm_no_startvm | Status : SUCCESS === ok Test Upload volume and attach to VM in stopped state ... === TestName: test_upload_attach_volume | Status : SUCCESS === ok Test VM limit per account ... === TestName: test_vm_per_account | Status : SUCCESS === ok -- Ran 17 tests in 1834.202s OK (SKIP=2) Thanks, Gaurav Aradhye
Re: Review Request 31181: CLOUDSTACK-8268: Code improvement - test_stopped_vm.py
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31181/ --- (Updated Feb. 20, 2015, 12:02 p.m.) Review request for cloudstack and SrikanteswaraRao Talluri. Bugs: CLOUDSTACK-8268 https://issues.apache.org/jira/browse/CLOUDSTACK-8268 Repository: cloudstack-git Description --- 1. Read all the test data from test_data.py 2. Remove hard coded test data (Services class) from the test suite 3. Fix autopep8 issues 4. Move bootableVolume to configurableData section and make relevant changes in test case to read the data according to hypervisor Diffs (updated) - test/integration/component/test_stopped_vm.py 1cefc07 tools/marvin/marvin/config/test_data.py e8365ed Diff: https://reviews.apache.org/r/31181/diff/ Testing --- Test Deploy HA enabled Virtual Machine with startvm=false ... === TestName: test_01_deploy_ha_vm_startvm_false | Status : SUCCESS === ok Test Deploy HA enabled Virtual Machine from ISO ... SKIP: Bootable Iso URL not present in test data for xenserver Test Deploy HA enabled Virtual Machine from ISO with startvm=false ... === TestName: test_03_deploy_ha_vm_iso_startvm_false | Status : SUCCESS === ok Test deploy VM on specific host ... === TestName: test_deployVmOnGivenHost | Status : SUCCESS === ok Test Deploy Virtual Machine with no startVM parameter ... === TestName: test_01_deploy_vm_no_startvm | Status : SUCCESS === ok Test Deploy Virtual Machine with startVM=true parameter ... === TestName: test_02_deploy_vm_startvm_true | Status : SUCCESS === ok Test Deploy Virtual Machine with startVM=false parameter ... === TestName: test_03_deploy_vm_startvm_false | Status : SUCCESS === ok Test Deploy Virtual Machine with startVM=false and attach volume ... === TestName: test_04_deploy_startvm_false_attach_volume | Status : SUCCESS === ok Test Deploy Virtual Machine with startVM=false and change service offering ... === TestName: test_05_deploy_startvm_false_change_so | Status : SUCCESS === ok Test Deploy Virtual Machine with startVM=false and ... === TestName: test_06_deploy_startvm_attach_detach | Status : SUCCESS === ok Test Deploy Virtual Machine with startVM=false and attach ISO ... === TestName: test_07_deploy_startvm_attach_iso | Status : SUCCESS === ok Test Deploy Virtual Machine with startVM=false and attach volume already attached to different machine ... === TestName: test_08_deploy_attached_volume | Status : SUCCESS === ok Test Stopped Virtual Machine's ROOT volume migration ... SKIP: No cluster with more than one primary storage pool to perform migrate volume test Test Deploy Virtual Machine with startVM=false enabledpassword in ... === TestName: test_deploy_vm_password_enabled | Status : SUCCESS === ok Test Deploy Virtual Machine with no startVM parameter ... === TestName: test_01_deploy_vm_no_startvm | Status : SUCCESS === ok Test Upload volume and attach to VM in stopped state ... === TestName: test_upload_attach_volume | Status : SUCCESS === ok Test VM limit per account ... === TestName: test_vm_per_account | Status : SUCCESS === ok -- Ran 17 tests in 1834.202s OK (SKIP=2) Thanks, Gaurav Aradhye
Review Request 31108: CLOUDSTACK-8261: test_haproxy.py - Remove the code checking AppCookle and LbCookie Stickiness policies
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31108/ --- Review request for cloudstack and SrikanteswaraRao Talluri. Bugs: CLOUDSTACK-8261 https://issues.apache.org/jira/browse/CLOUDSTACK-8261 Repository: cloudstack-git Description --- The code checks the AppCookie and LbCookie Stickiness policies by doing SSH to VM. This is wrong because these policies are for HTTP requests. Removing the wrong code. We need to device a way to verify these policies through test case. Added TODO comments for these. Will address them in separate patch. Diffs - test/integration/component/test_haproxy.py 73257e6 Diff: https://reviews.apache.org/r/31108/diff/ Testing --- Test Configure stickiness policies with default values ... === TestName: test_01_create_sticky_policy_default_values | Status : SUCCESS === ok Test Configure stickiness policies with custom values ... === TestName: test_02_create_sticky_policy_custom_values | Status : SUCCESS === ok Test listnetworks response to check supported stickiness policies ... === TestName: test_03_supported_policies_by_network | Status : SUCCESS === ok Test LB rule before/after stickiness policy creation ... === TestName: test_04_delete_lb_rule | Status : SUCCESS === ok Test error/alerts after creating stickiness policy ... === TestName: test_05_error_alerts_after_create | Status : SUCCESS === ok Test release public IP with stickiness policy ... === TestName: test_06_release_ip | Status : SUCCESS === ok Test Delete account and check the router and its rules ... === TestName: test_07_delete_account | Status : SUCCESS === ok Test verify create stickiness policy when router is stopped state ... === TestName: test_08_create_policy_router_stopped | Status : SUCCESS === ok Test check the stickiness policy rules after destroying router ... === TestName: test_09_create_policy_router_destroy | Status : SUCCESS === ok Test enable/disable the VPN after applying sticky policy rules ... === TestName: test_10_create_policy_enable_disable_vpn | Status : SUCCESS === ok Test verfify functionality syncronous and asyncronous validations ... === TestName: test_11_invalid_params | Status : SUCCESS === ok -- Ran 11 tests in 3133.053s OK Thanks, Gaurav Aradhye
Review Request 31105: CLOUDSTACK-8259: test_routers.py - Code improvement
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31105/ --- Review request for cloudstack and SrikanteswaraRao Talluri. Bugs: CLOUDSTACK-8259 https://issues.apache.org/jira/browse/CLOUDSTACK-8259 Repository: cloudstack-git Description --- 1. Read all the test data from test_data.py, removed services dict from test case 2. Read host credentials from configurableData section Additional change: Increased the memory and cpu for default service offering from 128 to 256 to avoid SSH failures. Diffs - test/integration/component/test_routers.py 0a74234 tools/marvin/marvin/config/test_data.py e3645a7 Diff: https://reviews.apache.org/r/31105/diff/ Testing --- Yes. All test cases passed. Thanks, Gaurav Aradhye
Review Request 31081: CLOUDSTACK-8257: test_iso.py - Removed assertion on Iso name when random character s are appended to test data before creating Iso
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31081/ --- Review request for cloudstack and SrikanteswaraRao Talluri. Bugs: CLOUDSTACK-8258 https://issues.apache.org/jira/browse/CLOUDSTACK-8258 Repository: cloudstack-git Description --- Create method in Class Iso in base library now appends random characters (6) to the Iso name passed from test data so that each Iso created through test case has different name. Hence assertios based on Iso name should be removed from test case as they won't hold true anymore (Iso name will not match with that passed through the test data). Other changes: 1. Pep8 fixes 2. Import fixes 3. Removing white-spaces 4. Removing unused variables Diffs - test/integration/smoke/test_iso.py 4bd66b5 Diff: https://reviews.apache.org/r/31081/diff/ Testing --- Yes. One test case failed in downloading Iso due to DNS issue in the setup. Otherwise should pass. The test case which failed in BVT build passed in my testing. Thanks, Gaurav Aradhye
Re: Review Request 30660: CLOUDSTACK-8219: Marvin: Correct code related to getting free vlan in the setup
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30660/#review72610 --- This is pending for review. - Gaurav Aradhye On Feb. 5, 2015, 4:26 p.m., Gaurav Aradhye wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30660/ --- (Updated Feb. 5, 2015, 4:26 p.m.) Review request for cloudstack and SrikanteswaraRao Talluri. Bugs: CLOUDSTACK-8219 https://issues.apache.org/jira/browse/CLOUDSTACK-8219 Repository: cloudstack-git Description --- The function get_free_vlan lists all the networks in the setup and generates a vlan in the physical vlan range which is not used by any of the listed networks. However the method lists only shared networks. It should list all the networks so that the vlan does not overlap with any of the used vlans. Diffs - tools/marvin/marvin/lib/common.py 28ec024 Diff: https://reviews.apache.org/r/30660/diff/ Testing --- Yes. Test Shared Network ALL ... === TestName: test_createSharedNetwork_All | Status : SUCCESS === ok Test Shared Network with scope account ... === TestName: test_createSharedNetwork_accountSpecific | Status : SUCCESS === ok Test Shared Network with scope domain ... === TestName: test_createSharedNetwork_domainSpecific | Status : SUCCESS === ok Thanks, Gaurav Aradhye
Review Request 31078: CLOUDSTACK-8257: test_escalations_volume.py - Removing asserts on volumes names as they don't hold true when random cha racters are appended to the volume name before creation
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31078/ --- Review request for cloudstack, sanjeev n and SrikanteswaraRao Talluri. Bugs: CLOUDSTACK-8257 https://issues.apache.org/jira/browse/CLOUDSTACK-8257 Repository: cloudstack-git Description --- Test_escalations_volume.py has two test cases which assert the created volume name with the name passed through test data. However this won't hold true when random characters are appended to the volume before its creation. There is no need of such assert as we are already checking the API response is not None. Removed the unnecessary asserts. Diffs - test/integration/component/test_escalations_volumes.py d650121 Diff: https://reviews.apache.org/r/31078/diff/ Testing --- Did not run these. Should run fine. Thanks, Gaurav Aradhye
Review Request 30990: CLOUDSTACK-8255: Adding secondary IP to correct ethernet interface present on the VM
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30990/ --- Review request for cloudstack and SrikanteswaraRao Talluri. Bugs: CLOUDSTACK-8255 https://issues.apache.org/jira/browse/CLOUDSTACK-8255 Repository: cloudstack-git Description --- In test_lb_secondary_ip.py test cases, secondary ip is added to eth0 interface. However in some of the VMs, this interface is absent and eth2 is present. It is wise to list the ethernet interface first, and then use the ethernet interface present on the VM to add the secondary IP to, rather than hard coding the name of the ethernet interface. Other change: Use high end service offering for Hyperv VMs Diffs - test/integration/component/test_lb_secondary_ip.py ecf0985 Diff: https://reviews.apache.org/r/30990/diff/ Testing --- Yes. Tested the SSH test cases. SSH to VM using LB rule assigned to secondary IP of VM ... === TestName: test_11_ssh_to_secondary_ip | Status : SUCCESS === ok SSH to VM using LB rule assigned to primary and secondary IP of VM ... SKIP: Failing-WIP SSH to VM after deleting LB rule ... === TestName: test_13_delete_lb_rule | Status : SUCCESS === ok ssh to vm after removing secondary ip from load balancer rule ... SKIP: Skip ssh to vm after removing secondary ip from load balancer rule ... === TestName: test_15_remove_lb_rule_primary_ip | Status : SUCCESS === ok ssh to vm after removing secondary ip from load balancer rule ... === TestName: test_16_delete_vm_from_lb_rule | Status : SUCCESS === ok Verify LB rules after destroying and recovering VM ... === TestName: test_20_destroy_recover_vm | Status : SUCCESS === ok Verify LB rule functioning with different algorithm ... === TestName: test_21_modify_lb_rule_algorithm | Status : SUCCESS === ok -- Ran 19 tests in 2922.113s OK (SKIP=14) Thanks, Gaurav Aradhye
Review Request 30967: CLOUDSTACK-8253: Code correction and improvement: test_haproxy.py
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30967/ --- Review request for cloudstack and SrikanteswaraRao Talluri. Bugs: CLOUDSTACK-8253 https://issues.apache.org/jira/browse/CLOUDSTACK-8253 Repository: cloudstack-git Description --- test_haproxy.py is using the config data included in the test file itself, however it should consume the data from test_data.py file. Also the code is testing LB rule stickiness policies but there is an extra NAT rule present for the same IP addresses which prevents the test case from testing the Stickiness policies alone. Diffs - test/integration/component/test_haproxy.py e941e5b Diff: https://reviews.apache.org/r/30967/diff/ Testing --- Currently failing for Stickiness policies AppCookie and LbCookie. Thanks, Gaurav Aradhye
Review Request 30975: CLOUDSTACK-8254: Choosing high end service offering for HyperV in case it tries to SSH to VM because Hyperv needs more resources because it is GUI based VM
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30975/ --- Review request for cloudstack and SrikanteswaraRao Talluri. Bugs: CLOUDSTACK-8254 https://issues.apache.org/jira/browse/CLOUDSTACK-8254 Repository: cloudstack-git Description --- The service offering should be with cpuspeed 1 GHz and memory 1 GB for Hyperv VMs while trying to connect to them via SSH as if the memory is low, the machine won't come up properly and SSH will fail. Diffs - test/integration/component/test_egress_fw_rules.py 5f0ca92 Diff: https://reviews.apache.org/r/30975/diff/ Testing --- Yes. Test By-default the communication from guest n/w to public n/w is NOT allowed. ... === TestName: test_01_1_egress_fr1 | Status : SUCCESS === ok Test By-default the communication from guest n/w to public n/w is allowed. ... === TestName: test_01_egress_fr1 | Status : SUCCESS === ok Test Allow Communication using Egress rule with CIDR + Port Range + Protocol. ... === TestName: test_02_1_egress_fr2 | Status : SUCCESS === ok Test Allow Communication using Egress rule with CIDR + Port Range + Protocol. ... === TestName: test_02_egress_fr2 | Status : SUCCESS === ok Test Communication blocked with network that is other than specified ... === TestName: test_03_1_egress_fr3 | Status : SUCCESS === ok Test Communication blocked with network that is other than specified ... === TestName: test_03_egress_fr3 | Status : SUCCESS === ok Test Create Egress rule and check the Firewall_Rules DB table ... === TestName: test_04_1_egress_fr4 | Status : SUCCESS === ok Test Create Egress rule and check the Firewall_Rules DB table ... === TestName: test_04_egress_fr4 | Status : SUCCESS === ok Test Create Egress rule and check the IP tables ... SKIP: Skip Test Create Egress rule and check the IP tables ... SKIP: Skip Test Create Egress rule without CIDR ... === TestName: test_06_1_egress_fr6 | Status : SUCCESS === ok Test Create Egress rule without CIDR ... === TestName: test_06_egress_fr6 | Status : SUCCESS === ok Test Create Egress rule without End Port ... === TestName: test_07_1_egress_fr7 | Status : SUCCESS === ok Test Create Egress rule without End Port ... === TestName: test_07_egress_fr7 | Status : SUCCESS === ok Test Port Forwarding and Egress Conflict ... SKIP: Skip Test Port Forwarding and Egress Conflict ... SKIP: Skip Test Delete Egress rule ... === TestName: test_09_1_egress_fr9 | Status : SUCCESS === ok Test Delete Egress rule ... === TestName: test_09_egress_fr9 | Status : SUCCESS === ok Test Invalid CIDR and Invalid Port ranges ... === TestName: test_10_1_egress_fr10 | Status : SUCCESS === ok Test Invalid CIDR and Invalid Port ranges ... === TestName: test_10_egress_fr10 | Status : SUCCESS === ok Test Regression on Firewall + PF + LB + SNAT ... === TestName: test_11_1_egress_fr11 | Status : SUCCESS === ok Test Regression on Firewall + PF + LB + SNAT ... === TestName: test_11_egress_fr11 | Status : SUCCESS === ok Test Reboot Router ... === TestName: test_12_1_egress_fr12 | Status : SUCCESS === ok Test Reboot Router ... === TestName: test_12_egress_fr12 | Status : SUCCESS === Thanks, Gaurav Aradhye
Review Request 30866: CLOUDSTACK-8241: Moved upload volume dict data to configurableData section of the test_data.py file so that data can be changed according to the setup, also made relevant changes
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30866/ --- Review request for cloudstack and SrikanteswaraRao Talluri. Bugs: CLOUDSTACK-8241 https://issues.apache.org/jira/browse/CLOUDSTACK-8241 Repository: cloudstack-git Description --- The volume upload URL is hard coded right now and should be moved to configurableData section so that appropriate data can be filled before the running the relevant test cases. Diffs - test/integration/component/test_escalations_volumes.py fe9d5e1 test/integration/testpaths/testpath_volumelifecycle.py 6e56697 tools/marvin/marvin/config/test_data.py d5ed353 Diff: https://reviews.apache.org/r/30866/diff/ Testing --- Did not run the test cases. Only the path changes in test cases. Should be tested with correct volume path. Thanks, Gaurav Aradhye
Review Request 30865: CLOUDSTACK-8240: Skipping test case in test_vmware_drs.py because the scenario is not testable through automation
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30865/ --- Review request for cloudstack and SrikanteswaraRao Talluri. Bugs: CLOUDSTACK-8240 https://issues.apache.org/jira/browse/CLOUDSTACK-8240 Repository: cloudstack-git Description --- The test case tries to deploy a VM with memory just below the host capacity (which is normally in many GBs). This goes beyond the account capacity, and also it is not feasible in automation to allocate such huge resources to single account. Hence skipping the test case and marking it as invalid. Diffs - test/integration/component/test_vmware_drs.py 20d3839 Diff: https://reviews.apache.org/r/30865/diff/ Testing --- Tested with python command and pyflakes. Thanks, Gaurav Aradhye
Review Request 30793: CLOUDSTACK-8235: Fixed test case in test_bugs.py to read variable data from configurableData section of test_data.py an d also fixed wrong parameter name
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30793/ --- Review request for cloudstack and SrikanteswaraRao Talluri. Bugs: CLOUDSTACK-8235 https://issues.apache.org/jira/browse/CLOUDSTACK-8235 Repository: cloudstack-git Description --- Changes: 1. Corrected paramater name podId to podid while adding externally managed cluster in vmware 2. Specified detailed imports 3. Moved the vmware_cluster dict to configurableData section. 4. Pep8 fuixes. Diffs - test/integration/component/maint/test_bugs.py 160cd1d tools/marvin/marvin/config/test_data.py d5ed353 Diff: https://reviews.apache.org/r/30793/diff/ Testing --- Did not test the actual adding cluster scenario. But the Invalid parameter error is gone. Test case needs to be run against proper data (vmware_cluster information). Checked the static errors and imports with pyflakes and python command. Thanks, Gaurav Aradhye
Review Request 30660: CLOUDSTACK-8219: Marvin: Correct code related to getting free vlan in the setup
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30660/ --- Review request for cloudstack and SrikanteswaraRao Talluri. Bugs: CLOUDSTACK-8219 https://issues.apache.org/jira/browse/CLOUDSTACK-8219 Repository: cloudstack-git Description --- The function get_free_vlan lists all the networks in the setup and generates a vlan in the physical vlan range which is not used by any of the listed networks. However the method lists only shared networks. It should list all the networks so that the vlan does not overlap with any of the used vlans. Diffs - tools/marvin/marvin/lib/common.py 28ec024 Diff: https://reviews.apache.org/r/30660/diff/ Testing --- Yes. Test Shared Network ALL ... === TestName: test_createSharedNetwork_All | Status : SUCCESS === ok Test Shared Network with scope account ... === TestName: test_createSharedNetwork_accountSpecific | Status : SUCCESS === ok Test Shared Network with scope domain ... === TestName: test_createSharedNetwork_domainSpecific | Status : SUCCESS === ok Thanks, Gaurav Aradhye
Review Request 30656: CLOUDSTACK-8214: test_netscaler_nw_off.py - Skip test if enough zones are not present instead of throwing exception
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30656/ --- Review request for cloudstack and SrikanteswaraRao Talluri. Bugs: CLOUDSTACK-8214 https://issues.apache.org/jira/browse/CLOUDSTACK-8214 Repository: cloudstack-git Description --- The test case asserts the total number of zones available in the setup and throws exception if the zones are less than 2. Instead skip the test case in this case. Diffs - test/integration/component/test_netscaler_nw_off.py 301c866 Diff: https://reviews.apache.org/r/30656/diff/ Testing --- Yes Thanks, Gaurav Aradhye
Review Request 30613: CLOUDSTACK-8211: Correcting expected secondary storage count value by rounding off to floor value and including the physicalsize of snapshot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30613/ --- Review request for cloudstack, Anshul Gangwar and SrikanteswaraRao Talluri. Bugs: CLOUDSTACK-8211 https://issues.apache.org/jira/browse/CLOUDSTACK-8211 Repository: cloudstack-git Description --- The expected secondary storage count needs to rounded off to integer floor. Also the physicalsize of the snapshot needs to be included in the expected count. Diffs - test/integration/component/test_ss_limits.py 8662cd5 Diff: https://reviews.apache.org/r/30613/diff/ Testing --- Test register template ... SKIP: skip Test register template ... SKIP: skip Test create snapshot and templates from volume ... === TestName: test_02_create_template_snapshot_1_root_domain_admin | Status : SUCCESS === ok Test create snapshot and templates from volume ... === TestName: test_02_create_template_snapshot_2_child_domain_admin | Status : SUCCESS === ok Test register iso ... SKIP: skip Test register iso ... SKIP: skip Test copy template between zones ... SKIP: skip Test copy template between zones ... SKIP: skip -- Ran 8 tests in 685.637s OK (SKIP=6) ~ Thanks, Gaurav Aradhye
Re: Review Request 30075: CLOUDSTACK-8124: Skipping snapshot tests on Hyper-V
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30075/#review69779 --- Please cherry-pick missing commit 214d63ee1eb393168c2f91a646a775cdaeb5cae8 to 4.5 from master and then apply this patch to 4.5. - Gaurav Aradhye On Jan. 22, 2015, 10:59 a.m., Gaurav Aradhye wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30075/ --- (Updated Jan. 22, 2015, 10:59 a.m.) Review request for cloudstack, sanjeev n and SrikanteswaraRao Talluri. Bugs: CLOUDSTACK-8124 https://issues.apache.org/jira/browse/CLOUDSTACK-8124 Repository: cloudstack-git Description --- Snapshot feature is not supported on hyper-V. Skipping the tests. Diffs - test/integration/component/test_snapshots.py 5b8cdc7 Diff: https://reviews.apache.org/r/30075/diff/ Testing --- Yes. Thanks, Gaurav Aradhye
Re: Review Request 29394: CLOUDSTACK-8124: Skipping snapshot test cases on hyperv
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29394/#review69780 --- This is absent in 4.5. Instructions included in RR https://reviews.apache.org/r/30075/ - Gaurav Aradhye On Dec. 24, 2014, 3:08 p.m., Gaurav Aradhye wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29394/ --- (Updated Dec. 24, 2014, 3:08 p.m.) Review request for cloudstack and SrikanteswaraRao Talluri. Bugs: CLOUDSTACK-4124 https://issues.apache.org/jira/browse/CLOUDSTACK-4124 Repository: cloudstack-git Description --- Snapshot feature is not supported on hyperV. Skipping related test cases. Diffs - test/integration/component/test_blocker_bugs.py f9530f0 Diff: https://reviews.apache.org/r/29394/diff/ Testing --- yes. Thanks, Gaurav Aradhye
Re: Review Request 30067: CLOUDSTACK-8170: Skipping tests on HyperV which try to scale VM in running state because feature not supported
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30067/ --- (Updated Jan. 22, 2015, 10:59 a.m.) Review request for cloudstack, sanjeev n and SrikanteswaraRao Talluri. Bugs: CLOUDSTACK-8170 https://issues.apache.org/jira/browse/CLOUDSTACK-8170 Repository: cloudstack-git Description --- Skipping tests on HyperV because scaling VM in running state is not supported. Diffs - test/integration/component/test_dynamic_compute_offering.py 5215f84 Diff: https://reviews.apache.org/r/30067/diff/ Testing --- Yes. Thanks, Gaurav Aradhye
Re: Review Request 29845: CLOUDSTACK-8152: Adding delay before creating snapshot/template from root disk after writing data to disk - test_vm_passwordenabled.py
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29845/ --- (Updated Jan. 22, 2015, 10:59 a.m.) Review request for cloudstack, sanjeev n and SrikanteswaraRao Talluri. Bugs: CLOUDSTACK-8152 https://issues.apache.org/jira/browse/CLOUDSTACK-8152 Repository: cloudstack-git Description --- Due to timing issue, sometimes data gets lost if snapshot/template is created from root volume immediately after writing data to disk. Add delay to bypass this issue. Diffs - test/integration/component/test_vm_passwdenabled.py d998ed5 Diff: https://reviews.apache.org/r/29845/diff/ Testing --- Test get VM password for password enabled template ... === TestName: test_11_get_vm_password | Status : SUCCESS === ok -- Ran 1 test in 751.495s OK Thanks, Gaurav Aradhye
Re: Review Request 30075: CLOUDSTACK-8124: Skipping snapshot tests on Hyper-V
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30075/ --- (Updated Jan. 22, 2015, 10:59 a.m.) Review request for cloudstack, sanjeev n and SrikanteswaraRao Talluri. Bugs: CLOUDSTACK-8124 https://issues.apache.org/jira/browse/CLOUDSTACK-8124 Repository: cloudstack-git Description --- Snapshot feature is not supported on hyper-V. Skipping the tests. Diffs - test/integration/component/test_snapshots.py 5b8cdc7 Diff: https://reviews.apache.org/r/30075/diff/ Testing --- Yes. Thanks, Gaurav Aradhye
Review Request 30157: CLOUDSTACK-8174: Fixed network delete issue in test_add_remove_network.py
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30157/ --- Review request for cloudstack, sanjeev n and SrikanteswaraRao Talluri. Bugs: CLOUDSTACK-8174 https://issues.apache.org/jira/browse/CLOUDSTACK-8174 Repository: cloudstack-git Description --- The test case failed while cleaning up the network. The network will be cleaned up as part of account cleanup, no need to add it separately to the cleanup list. Diffs - test/integration/component/test_add_remove_network.py 2f685b5 Diff: https://reviews.apache.org/r/30157/diff/ Testing --- Yes. LOg: Add network to vm with wrong vm id ... === TestName: test_15_add_nic_wrong_vm_id | Status : SUCCESS === ok Add network to vm with wrong network id ... === TestName: test_16_add_nic_wrong_network_id | Status : SUCCESS === ok Add network to vm where both belong to different zones ... === TestName: test_17_add_nic_different_zone | Status : SUCCESS === ok Add network to vm in basic zone ... SKIP: This test requires at least one basic zone to be present in the setup Try to add network to vm with insufficient permission ... === TestName: test_26_add_nic_insufficient_permission | Status : SUCCESS === ok -- Ran 5 tests in 285.485s OK (SKIP=1) Thanks, Gaurav Aradhye
Review Request 30067: CLOUDSTACK-8170: Skipping tests on HyperV which try to scale VM in running state because feature not supported
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30067/ --- Review request for cloudstack and SrikanteswaraRao Talluri. Bugs: CLOUDSTACK-8170 https://issues.apache.org/jira/browse/CLOUDSTACK-8170 Repository: cloudstack-git Description --- Skipping tests on HyperV because scaling VM in running state is not supported. Diffs - test/integration/component/test_dynamic_compute_offering.py 5215f84 Diff: https://reviews.apache.org/r/30067/diff/ Testing --- Yes. Thanks, Gaurav Aradhye
Review Request 30075: CLOUDSTACK-8124: Skipping snapshot tests on Hyper-V
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30075/ --- Review request for cloudstack and SrikanteswaraRao Talluri. Bugs: CLOUDSTACK-8124 https://issues.apache.org/jira/browse/CLOUDSTACK-8124 Repository: cloudstack-git Description --- Snapshot feature is not supported on hyper-V. Skipping the tests. Diffs - test/integration/component/test_snapshots.py 5b8cdc7 Diff: https://reviews.apache.org/r/30075/diff/ Testing --- Yes. Thanks, Gaurav Aradhye
Review Request 29845: CLOUDSTACK-8152: Adding delay before creating snapshot/template from root disk after writing data to disk - test_vm_passwordenabled.py
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29845/ --- Review request for cloudstack and SrikanteswaraRao Talluri. Bugs: CLOUDSTACK-8152 https://issues.apache.org/jira/browse/CLOUDSTACK-8152 Repository: cloudstack-git Description --- Due to timing issue, sometimes data gets lost if snapshot/template is created from root volume immediately after writing data to disk. Add delay to bypass this issue. Diffs - test/integration/component/test_vm_passwdenabled.py d998ed5 Diff: https://reviews.apache.org/r/29845/diff/ Testing --- Test get VM password for password enabled template ... === TestName: test_11_get_vm_password | Status : SUCCESS === ok -- Ran 1 test in 751.495s OK Thanks, Gaurav Aradhye
Re: Review Request 29845: CLOUDSTACK-8152: Adding delay before creating snapshot/template from root disk after writing data to disk - test_vm_passwordenabled.py
On Jan. 13, 2015, 3:37 p.m., SrikanteswaraRao Talluri wrote: d79837b67a481e618c8291152a9ecec299ff02dd master doesn't apply on 4.5 Applying: CLOUDSTACK-8152: Adding delay before creating snapshot/template from root disk after writing data to disk - test_vm_passwordenabled.py Using index info to reconstruct a base tree... M test/integration/component/test_vm_passwdenabled.py Falling back to patching base and 3-way merge... Auto-merging test/integration/component/test_vm_passwdenabled.py CONFLICT (content): Merge conflict in test/integration/component/test_vm_passwdenabled.py Failed to merge in the changes. Patch failed at 0001 CLOUDSTACK-8152: Adding delay before creating snapshot/template from root disk after writing data to disk - test_vm_passwordenabled.py The copy of the patch that failed is found in: /Users/talluri/asf/cloudstack/.git/rebase-apply/patch When you have resolved this problem, run git am --continue. If you prefer to skip this patch, run git am --skip instead. To restore the original branch and stop patching, run git am --abort. Please cherry-pick 41b871b6bdfd48f673e1fdc011069dd3c7ca032b from master to 4.5 and then apply this patch to 4.5. - Gaurav --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29845/#review67830 --- On Jan. 13, 2015, 2:01 p.m., Gaurav Aradhye wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29845/ --- (Updated Jan. 13, 2015, 2:01 p.m.) Review request for cloudstack and SrikanteswaraRao Talluri. Bugs: CLOUDSTACK-8152 https://issues.apache.org/jira/browse/CLOUDSTACK-8152 Repository: cloudstack-git Description --- Due to timing issue, sometimes data gets lost if snapshot/template is created from root volume immediately after writing data to disk. Add delay to bypass this issue. Diffs - test/integration/component/test_vm_passwdenabled.py d998ed5 Diff: https://reviews.apache.org/r/29845/diff/ Testing --- Test get VM password for password enabled template ... === TestName: test_11_get_vm_password | Status : SUCCESS === ok -- Ran 1 test in 751.495s OK Thanks, Gaurav Aradhye
Re: Review Request 29509: CLOUDSATCK-8138: Fixed VmSnapshot revert issue in test_escalations_instances.py
On Jan. 5, 2015, 6:50 p.m., SrikanteswaraRao Talluri wrote: 22d6565434e31a8c65953a9eb1b8bfeea1c0f1d0 master SrikanteswaraRao Talluri wrote: doesn't apply on 4.5 4.5 branch does not need this patch, closing the review request. - Gaurav --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29509/#review66632 --- On Dec. 31, 2014, 3:22 p.m., Gaurav Aradhye wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29509/ --- (Updated Dec. 31, 2014, 3:22 p.m.) Review request for cloudstack and SrikanteswaraRao Talluri. Bugs: CLOUDSTACK-8138 https://issues.apache.org/jira/browse/CLOUDSTACK-8138 Repository: cloudstack-git Description --- The VM should be in running state while reverting the snapshot because the VmSnapshot includes memorySnapshot too. Diffs - test/integration/component/test_escalations_instances.py 1e5ec5331b9e95d9e7cae5cd5071e0789525c67e Diff: https://reviews.apache.org/r/29509/diff/ Testing --- Yes. Thanks, Gaurav Aradhye
Review Request 29759: CLOUDSTACK-8145: Adding new test to test blocker bugs and modifying other test case to work around the bug
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29759/ --- Review request for cloudstack and SrikanteswaraRao Talluri. Bugs: CLOUDSTACK-8145 https://issues.apache.org/jira/browse/CLOUDSTACK-8145 Repository: cloudstack-git Description --- Few test cases failed due to timing issue in data syncof root disk data. Adding a new test case to test this issue, while changing other test cases with work around so that those are not blokced. More details are mentioned in the jira issue. Diffs - test/integration/component/test_blocker_bugs.py 8ba563f test/integration/component/test_reset_ssh_keypair.py a2e743a Diff: https://reviews.apache.org/r/29759/diff/ Testing --- Yes. Thanks, Gaurav Aradhye
Re: Review Request 29759: CLOUDSTACK-8145: Adding new test to test blocker bugs and modifying other test case to work around the bug
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29759/ --- (Updated Jan. 9, 2015, 4:36 p.m.) Review request for cloudstack and SrikanteswaraRao Talluri. Bugs: CLOUDSTACK-8145 https://issues.apache.org/jira/browse/CLOUDSTACK-8145 Repository: cloudstack-git Description --- Few test cases failed due to timing issue in data syncof root disk data. Adding a new test case to test this issue, while changing other test cases with work around so that those are not blokced. More details are mentioned in the jira issue. Diffs (updated) - test/integration/component/test_blocker_bugs.py 8ba563f test/integration/component/test_reset_ssh_keypair.py a2e743a Diff: https://reviews.apache.org/r/29759/diff/ Testing --- Yes. Thanks, Gaurav Aradhye
Re: Review Request 29395: CLOUDSTACK-8124: Skipping snapshot tests on hyperv hypervisor
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29395/#review67017 --- This is pending for 4.5. Please cherry-pick b0d74ad6fc68fd7022ec6cf378736430f0908a75 to 4.5 branch from master before applying this patch. - Gaurav Aradhye On Dec. 24, 2014, 6:05 p.m., Gaurav Aradhye wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29395/ --- (Updated Dec. 24, 2014, 6:05 p.m.) Review request for cloudstack and SrikanteswaraRao Talluri. Repository: cloudstack-git Description --- In continuation with https://reviews.apache.org/r/29394/. Did not rebase it to make one patch because one commit is missing in 4.5 branch for one of the files. Please cherry-pick b0d74ad6fc68fd7022ec6cf378736430f0908a75 to 4.5 branch from master before applying this patch. Diffs - test/integration/component/test_project_limits.py d4fb92d test/integration/component/test_ps_domain_limits.py 268174f test/integration/component/test_ps_limits.py e557249 test/integration/component/test_resource_limits.py f7fecb0 test/integration/component/test_snapshots.py 4bb2dcf test/integration/component/test_ss_limits.py c498302 test/integration/component/test_tags.py 2b05fbb test/integration/component/test_templates.py 753e71a test/integration/component/test_usage.py 58cfbed Diff: https://reviews.apache.org/r/29395/diff/ Testing --- Tested with python and pyflakes. Thanks, Gaurav Aradhye
Review Request 29509: CLOUDSATCK-8138: Fixed VmSnapshot revert issue in test_escalations_instances.py
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29509/ --- Review request for cloudstack and SrikanteswaraRao Talluri. Bugs: CLOUDSTACK-8138 https://issues.apache.org/jira/browse/CLOUDSTACK-8138 Repository: cloudstack-git Description --- The VM should be in running state while reverting the snapshot because the VmSnapshot includes memorySnapshot too. Diffs - test/integration/component/test_escalations_instances.py 1e5ec5331b9e95d9e7cae5cd5071e0789525c67e Diff: https://reviews.apache.org/r/29509/diff/ Testing --- Yes. Thanks, Gaurav Aradhye
Review Request 29394: CLOUDSTACK-8124: Skipping snapshot test cases on hyperv
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29394/ --- Review request for cloudstack and SrikanteswaraRao Talluri. Bugs: CLOUDSTACK-4124 https://issues.apache.org/jira/browse/CLOUDSTACK-4124 Repository: cloudstack-git Description --- Snapshot feature is not supported on hyperV. Skipping related test cases. Diffs - test/integration/component/test_blocker_bugs.py f9530f0 Diff: https://reviews.apache.org/r/29394/diff/ Testing --- yes. Thanks, Gaurav Aradhye
Review Request 29395: CLOUDSTACK-8124: Skipping snapshot tests on hyperv hypervisor
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29395/ --- Review request for cloudstack and SrikanteswaraRao Talluri. Repository: cloudstack-git Description --- In continuation with https://reviews.apache.org/r/29394/. Did not rebase it to make one patch because one commit is missing in 4.5 branch for one of the files. Please cherry-pick b0d74ad6fc68fd7022ec6cf378736430f0908a75 to 4.5 branch from master before applying this patch. Diffs - test/integration/component/test_project_limits.py d4fb92d test/integration/component/test_ps_domain_limits.py 268174f test/integration/component/test_ps_limits.py e557249 test/integration/component/test_resource_limits.py f7fecb0 test/integration/component/test_snapshots.py 4bb2dcf test/integration/component/test_ss_limits.py c498302 test/integration/component/test_tags.py 2b05fbb test/integration/component/test_templates.py 753e71a test/integration/component/test_usage.py 58cfbed Diff: https://reviews.apache.org/r/29395/diff/ Testing --- Tested with python and pyflakes. Thanks, Gaurav Aradhye
Review Request 29363: CLOUDSTACK-8116: Moved ldap data to configurableData section in test_data.py and made related changes in the test case
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29363/ --- Review request for cloudstack and SrikanteswaraRao Talluri. Bugs: CLOUDSTACK-8116 https://issues.apache.org/jira/browse/CLOUDSTACK-8116 Repository: cloudstack-git Description --- Moved ldap data to configurableData section in test_data.py and made related changes in the test case. Also fixed pep8 issues and imports. Diffs - test/integration/component/test_ldap.py 5a78957 tools/marvin/marvin/config/test_data.py ba2fb24 Diff: https://reviews.apache.org/r/29363/diff/ Testing --- Not tested. Requires ldap server to be setup. The test case will be run successfully when correct information is filled in test_data.py file. Thanks, Gaurav Aradhye
Review Request 29369: CLOUDSTACK-8117: Increased the allowed margin (+/-) for memory of VM on hyperv used to equate with the memory specified in service offering
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29369/ --- Review request for cloudstack and SrikanteswaraRao Talluri. Bugs: CLOUDSTACK-8117 https://issues.apache.org/jira/browse/CLOUDSTACK-8117 Repository: cloudstack-git Description --- Increased the allowed margin (+/-) for memory of VM on hyperv used to equate with the memory specified in service offering. Large component of memory is consumed by the UI component, hence the memory for VM is listed lesser than that is specified in the service offering. Increase the range from 20 to 200 for hyperv because of the difference in template used. TODO: Find a way to get memory allolcated to VM on hyperv using powershell commands and use it to equate it to the memory specified in service offering. Also fixed pep8 issues. Diffs - test/integration/smoke/test_service_offerings.py e390f75 Diff: https://reviews.apache.org/r/29369/diff/ Testing --- Yes. Thanks, Gaurav Aradhye
Re: Review Request 29242: CLOUDSTACK-8096: Fixed test_ssvm.py for issues while checking the result of diagnostic scripts
On Dec. 22, 2014, 12:56 p.m., SrikanteswaraRao Talluri wrote: Applying: CLOUDSTACK-8096: Fixed test_ssvm.py for issues while checking the result of diagnostic scripts Using index info to reconstruct a base tree... M test/integration/smoke/test_ssvm.py M tools/marvin/marvin/config/test_data.py Falling back to patching base and 3-way merge... Auto-merging tools/marvin/marvin/config/test_data.py Auto-merging test/integration/smoke/test_ssvm.py CONFLICT (content): Merge conflict in test/integration/smoke/test_ssvm.py Failed to merge in the changes. Patch failed at 0001 CLOUDSTACK-8096: Fixed test_ssvm.py for issues while checking the result of diagnostic scripts The copy of the patch that failed is found in: /Users/talluri/asf/cloudstack/.git/rebase-apply/patch When you have resolved this problem, run git am --continue. If you prefer to skip this patch, run git am --skip instead. To restore the original branch and stop patching, run git am --abort. Please cherry-pick b10f0a7990b916aebf73291e3807cb7eff5fc5ca into master branch, then apply updated patch to both 4.5, master. - Gaurav --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29242/#review65761 --- On Dec. 19, 2014, 3:28 p.m., Gaurav Aradhye wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29242/ --- (Updated Dec. 19, 2014, 3:28 p.m.) Review request for cloudstack and SrikanteswaraRao Talluri. Bugs: CLOUDSTACK-8096 https://issues.apache.org/jira/browse/CLOUDSTACK-8096 Repository: cloudstack-git Description --- After reboot SSVM and CPVM operation, if we run diagnostic script on SSVM, it fails with NFS server is not currently mounted. Also if we run command service cloud status, it says Cloudstack cloud service is not running. But if we check after some time, everything is fine. Some delay in test cases is needed to allow the SSVM and CPVM to start all services. Added the delay as part of configurableData section so that it can be changed whenever required using external script without touching the test case. Also fixed import issues and pep8 issues. Diffs - test/integration/smoke/test_ssvm.py 5713569 tools/marvin/marvin/config/test_data.py 4ab7e56 Diff: https://reviews.apache.org/r/29242/diff/ Testing --- Test List secondary storage VMs ... === TestName: test_01_list_sec_storage_vm | Status : SUCCESS === ok Test List console proxy VMs ... === TestName: test_02_list_cpvm_vm | Status : SUCCESS === ok Test SSVM Internals ... === TestName: test_03_ssvm_internals | Status : SUCCESS === ok Test CPVM Internals ... === TestName: test_04_cpvm_internals | Status : SUCCESS === ok Test stop SSVM ... === TestName: test_05_stop_ssvm | Status : SUCCESS === ok Test stop CPVM ... === TestName: test_06_stop_cpvm | Status : SUCCESS === ok Test reboot SSVM ... === TestName: test_07_reboot_ssvm | Status : SUCCESS === ok Test reboot CPVM ... === TestName: test_08_reboot_cpvm | Status : SUCCESS === ok Test destroy SSVM ... === TestName: test_09_destroy_ssvm | Status : SUCCESS === ok Test destroy CPVM ... === TestName: test_10_destroy_cpvm | Status : SUCCESS === ok -- Ran 10 tests in 1555.479s OK Thanks, Gaurav Aradhye
Re: Review Request 29242: CLOUDSTACK-8096: Fixed test_ssvm.py for issues while checking the result of diagnostic scripts
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29242/ --- (Updated Dec. 22, 2014, 2:57 p.m.) Review request for cloudstack and SrikanteswaraRao Talluri. Bugs: CLOUDSTACK-8096 https://issues.apache.org/jira/browse/CLOUDSTACK-8096 Repository: cloudstack-git Description --- After reboot SSVM and CPVM operation, if we run diagnostic script on SSVM, it fails with NFS server is not currently mounted. Also if we run command service cloud status, it says Cloudstack cloud service is not running. But if we check after some time, everything is fine. Some delay in test cases is needed to allow the SSVM and CPVM to start all services. Added the delay as part of configurableData section so that it can be changed whenever required using external script without touching the test case. Also fixed import issues and pep8 issues. Diffs (updated) - test/integration/smoke/test_ssvm.py ed9eab0 tools/marvin/marvin/config/test_data.py 9add0fa Diff: https://reviews.apache.org/r/29242/diff/ Testing --- Test List secondary storage VMs ... === TestName: test_01_list_sec_storage_vm | Status : SUCCESS === ok Test List console proxy VMs ... === TestName: test_02_list_cpvm_vm | Status : SUCCESS === ok Test SSVM Internals ... === TestName: test_03_ssvm_internals | Status : SUCCESS === ok Test CPVM Internals ... === TestName: test_04_cpvm_internals | Status : SUCCESS === ok Test stop SSVM ... === TestName: test_05_stop_ssvm | Status : SUCCESS === ok Test stop CPVM ... === TestName: test_06_stop_cpvm | Status : SUCCESS === ok Test reboot SSVM ... === TestName: test_07_reboot_ssvm | Status : SUCCESS === ok Test reboot CPVM ... === TestName: test_08_reboot_cpvm | Status : SUCCESS === ok Test destroy SSVM ... === TestName: test_09_destroy_ssvm | Status : SUCCESS === ok Test destroy CPVM ... === TestName: test_10_destroy_cpvm | Status : SUCCESS === ok -- Ran 10 tests in 1555.479s OK Thanks, Gaurav Aradhye
Re: Review Request 29245: CLOUDSTACK-8098: Fixed VM snapshot issue in smoke/test_vm_snapshots.py
On Dec. 20, 2014, 3:51 p.m., SrikanteswaraRao Talluri wrote: git am -3s /Users/talluri/Downloads/0002-CLOUDSTACK-8098-Fixed-VM-snapshot-issue-in-smoke-tes.patch Applying: CLOUDSTACK-8098: Fixed VM snapshot issue in smoke/test_vm_snapshots.py Using index info to reconstruct a base tree... M test/integration/smoke/test_vm_snapshots.py Falling back to patching base and 3-way merge... Auto-merging test/integration/smoke/test_vm_snapshots.py CONFLICT (content): Merge conflict in test/integration/smoke/test_vm_snapshots.py Failed to merge in the changes. Patch failed at 0001 CLOUDSTACK-8098: Fixed VM snapshot issue in smoke/test_vm_snapshots.py The copy of the patch that failed is found in: /Users/talluri/asf/cloudstack/.git/rebase-apply/patch When you have resolved this problem, run git am --continue. If you prefer to skip this patch, run git am --skip instead. To restore the original branch and stop patching, run git am --abort. Commit f510ef995baaa9addefc22ff0330cd51dee1dd95 (master )is absent in 4.5. Can you please cherry-pick? - Gaurav --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29245/#review65734 --- On Dec. 19, 2014, 5:42 p.m., Gaurav Aradhye wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29245/ --- (Updated Dec. 19, 2014, 5:42 p.m.) Review request for cloudstack and SrikanteswaraRao Talluri. Bugs: CLOUDSTACK-8098 https://issues.apache.org/jira/browse/CLOUDSTACK-8098 Repository: cloudstack-git Description --- The test case fails while reverting the VM snapshot because the snapshot does not contain the memory and VM is not in stopped state. Solution: Stop the VM before reverting the snapshot Also fixed pep8 issues and imports. Diffs - test/integration/smoke/test_vm_snapshots.py 131da99 Diff: https://reviews.apache.org/r/29245/diff/ Testing --- Yes. Log: Test to create VM snapshots ... === TestName: test_01_create_vm_snapshots | Status : SUCCESS === ok Test to revert VM snapshots ... === TestName: test_02_revert_vm_snapshots | Status : SUCCESS === ok Test to delete vm snapshots ... === TestName: test_03_delete_vm_snapshots | Status : SUCCESS === ok -- Ran 3 tests in 759.977s OK Thanks, Gaurav Aradhye
Review Request 29242: CLOUDSTACK-8096: Fixed test_ssvm.py for issues while checking the result of diagnostic scripts
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29242/ --- Review request for cloudstack and SrikanteswaraRao Talluri. Bugs: CLOUDSTACK-8096 https://issues.apache.org/jira/browse/CLOUDSTACK-8096 Repository: cloudstack-git Description --- After reboot SSVM and CPVM operation, if we run diagnostic script on SSVM, it fails with NFS server is not currently mounted. Also if we run command service cloud status, it says Cloudstack cloud service is not running. But if we check after some time, everything is fine. Some delay in test cases is needed to allow the SSVM and CPVM to start all services. Added the delay as part of configurableData section so that it can be changed whenever required using external script without touching the test case. Also fixed import issues and pep8 issues. Diffs - test/integration/smoke/test_ssvm.py 5713569 tools/marvin/marvin/config/test_data.py 4ab7e56 Diff: https://reviews.apache.org/r/29242/diff/ Testing --- Test List secondary storage VMs ... === TestName: test_01_list_sec_storage_vm | Status : SUCCESS === ok Test List console proxy VMs ... === TestName: test_02_list_cpvm_vm | Status : SUCCESS === ok Test SSVM Internals ... === TestName: test_03_ssvm_internals | Status : SUCCESS === ok Test CPVM Internals ... === TestName: test_04_cpvm_internals | Status : SUCCESS === ok Test stop SSVM ... === TestName: test_05_stop_ssvm | Status : SUCCESS === ok Test stop CPVM ... === TestName: test_06_stop_cpvm | Status : SUCCESS === ok Test reboot SSVM ... === TestName: test_07_reboot_ssvm | Status : SUCCESS === ok Test reboot CPVM ... === TestName: test_08_reboot_cpvm | Status : SUCCESS === ok Test destroy SSVM ... === TestName: test_09_destroy_ssvm | Status : SUCCESS === ok Test destroy CPVM ... === TestName: test_10_destroy_cpvm | Status : SUCCESS === ok -- Ran 10 tests in 1555.479s OK Thanks, Gaurav Aradhye
Review Request 29245: CLOUDSTACK-8098: Fixed VM snapshot issue in smoke/test_vm_snapshots.py
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29245/ --- Review request for cloudstack and SrikanteswaraRao Talluri. Bugs: CLOUDSTACK-8098 https://issues.apache.org/jira/browse/CLOUDSTACK-8098 Repository: cloudstack-git Description --- The test case fails while reverting the VM snapshot because the snapshot does not contain the memory and VM is not in stopped state. Solution: Stop the VM before reverting the snapshot Also fixed pep8 issues and imports. Diffs - test/integration/smoke/test_vm_snapshots.py 131da99 Diff: https://reviews.apache.org/r/29245/diff/ Testing --- Yes. Log: Test to create VM snapshots ... === TestName: test_01_create_vm_snapshots | Status : SUCCESS === ok Test to revert VM snapshots ... === TestName: test_02_revert_vm_snapshots | Status : SUCCESS === ok Test to delete vm snapshots ... === TestName: test_03_delete_vm_snapshots | Status : SUCCESS === ok -- Ran 3 tests in 759.977s OK Thanks, Gaurav Aradhye
Review Request 29247: CLOUDSATCK-8100: Fixed pep8 issues in test_vpc.py
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29247/ --- Review request for cloudstack and SrikanteswaraRao Talluri. Bugs: CLOUDSTACK-8100 https://issues.apache.org/jira/browse/CLOUDSTACK-8100 Repository: cloudstack-git Description --- Fixed pep8 issues and imports. Diffs - test/integration/component/test_vpc.py 13f0eff Diff: https://reviews.apache.org/r/29247/diff/ Testing --- Yes. Thanks, Gaurav Aradhye
Review Request 29201: CLOUDSTACK-8089: Fixed test_explicit_dedication.py test case and moved to maint folder for it is to be run separately
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29201/ --- Review request for cloudstack and SrikanteswaraRao Talluri. Bugs: CLOUDSTACK-8089 https://issues.apache.org/jira/browse/CLOUDSTACK-8089 Repository: cloudstack-git Description --- This is extension of patch submitted by Saksham: https://reviews.apache.org/r/13560/diff/# Imroved the code further and also moved the test case to maint folder because it needs to be run separately. Diffs - test/integration/component/maint/test_explicit_dedication.py PRE-CREATION test/integration/component/test_explicit_dedication.py 71c4141 Diff: https://reviews.apache.org/r/29201/diff/ Testing --- Yes. Log: Test explicit dedication is placing vms of an account on dedicated hosts. ... === TestName: test_01_deploy_vm_with_explicit_dedication | Status : SUCCESS === ok -- Ran 1 test in 258.255s OK Thanks, Gaurav Aradhye
Review Request 29202: CLOUDSTACK-8090: Moving test_dedicated_guest_vlan_ranges.py to maint folder for the test cases need to be run separately, serially
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29202/ --- Review request for cloudstack and SrikanteswaraRao Talluri. Bugs: CLOUDSTACK-8090 https://issues.apache.org/jira/browse/CLOUDSTACK-8090 Repository: cloudstack-git Description --- The test cases need to be run separately as they create vlan ranges, and dedicated them to an account/project. In between the vlans should not get consumed by other account. Else test cases will fail like following Execute cmd: dedicateguestvlanrange failed, due to: errorCode: 431, errorText:Guest vlan from this range 3390 is allocated to a different account. Can only dedicate a range which has no allocated vlans or has vlans allocated to the same account Diffs - test/integration/component/maint/test_dedicate_guest_vlan_ranges.py PRE-CREATION test/integration/component/test_dedicate_guest_vlan_ranges.py 9a0e7f0 Diff: https://reviews.apache.org/r/29202/diff/ Testing --- N/A Thanks, Gaurav Aradhye
Re: Review Request 29201: CLOUDSTACK-8089: Fixed test_explicit_dedication.py test case and moved to maint folder for it is to be run separately
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29201/ --- (Updated Dec. 19, 2014, 12:56 a.m.) Review request for cloudstack, Pierre-Luc Dion and SrikanteswaraRao Talluri. Bugs: CLOUDSTACK-8089 https://issues.apache.org/jira/browse/CLOUDSTACK-8089 Repository: cloudstack-git Description --- This is extension of patch submitted by Saksham: https://reviews.apache.org/r/13560/diff/# Imroved the code further and also moved the test case to maint folder because it needs to be run separately. Diffs - test/integration/component/maint/test_explicit_dedication.py PRE-CREATION test/integration/component/test_explicit_dedication.py 71c4141 Diff: https://reviews.apache.org/r/29201/diff/ Testing --- Yes. Log: Test explicit dedication is placing vms of an account on dedicated hosts. ... === TestName: test_01_deploy_vm_with_explicit_dedication | Status : SUCCESS === ok -- Ran 1 test in 258.255s OK Thanks, Gaurav Aradhye
Review Request 29150: CLOUDSTACK-8055: test_portable_ip.py - Tagging test case which can't be run on simulator
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29150/ --- Review request for cloudstack and SrikanteswaraRao Talluri. Bugs: CLOUDSTACK-8055 https://issues.apache.org/jira/browse/CLOUDSTACK-8055 Repository: cloudstack-git Description --- The test case tries to SSH to VM, can't be run on simulator. Diffs - test/integration/component/test_portable_ip.py 6bdc61a Diff: https://reviews.apache.org/r/29150/diff/ Testing --- N/A Thanks, Gaurav Aradhye
Review Request 29151: CLOUDSTACK-8084: Fixed test_17_add_nic_different_zone in test_add_remove_network.py
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29151/ --- Review request for cloudstack and SrikanteswaraRao Talluri. Bugs: CLOUDSTACK-8084 https://issues.apache.org/jira/browse/CLOUDSTACK-8084 Repository: cloudstack-git Description --- The network was created within root admin account, so it had a risk of getting used by other test cases by default. In that case cleanup would fail. Created the network in account created by the test case. Diffs - test/integration/component/test_add_remove_network.py aacd44b Diff: https://reviews.apache.org/r/29151/diff/ Testing --- Yes. Log: Add network to vm where both belong to different zones ... === TestName: test_17_add_nic_different_zone | Status : SUCCESS === ok -- Ran 1 test in 308.910s OK Thanks, Gaurav Aradhye
Review Request 29144: CLOUDSTACK-8081: Fixed VM snapshot test cases in test_escalation_instances.py and also dealt cleanup issues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29144/ --- Review request for cloudstack and SrikanteswaraRao Talluri. Bugs: CLOUDSTACK-8081 https://issues.apache.org/jira/browse/CLOUDSTACK-8081 Repository: cloudstack-git Description --- The VM snapshot test case was failiong while reverting the snapshot. That is because the VM snapshot created included only the disk, not memory. And reverting a VM snapshot having only disk is possible only when the VM is in stopped state. So either stop the VM before reverting the snapshot, or inlude memory too while creating the VM snapshot. Changes: 1) Included memory while creating VM snapshot. 2) Created separate account for each test case rather than using common account (Common account might leads to cleanup complexities, where the test cases affect each other) Diffs - test/integration/component/test_escalations_instances.py 9f053a1 Diff: https://reviews.apache.org/r/29144/diff/ Testing --- Yes. Thanks, Gaurav Aradhye
Re: Review Request 28748: CLOUDSTACK-8021: Change test cases to use host information from configurableData section in test_data.py
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28748/ --- (Updated Dec. 16, 2014, 11:41 a.m.) Review request for cloudstack and SrikanteswaraRao Talluri. Bugs: CLOUDSTACK-8021 https://issues.apache.org/jira/browse/CLOUDSTACK-8021 Repository: cloudstack-git Description --- Changing few test cases to use the host username, password from the configurableData section in test_data.py. Earlier they were reading the hard coded value. Removed old host_password value from test_data.py Also fixed few pep8 issues. Diffs - test/integration/component/test_deploy_vgpu_vm.py 0284eab test/integration/component/test_persistent_networks.py 4b1bc7a test/integration/smoke/test_deploy_vgpu_enabled_vm.py f13ac92 Diff: https://reviews.apache.org/r/28748/diff/ Testing --- Tested test_persistent_networks.py Other test cases not testable right now. Change is only in reading the config value. File Attachments (updated) Patch for 4.5 https://reviews.apache.org/media/uploaded/files/2014/12/16/3251644a-f44e-49b1-af90-78a10492cd71__0001-CLOUDSTACK-8021-Change-test-cases-to-use-host-inform.patch Thanks, Gaurav Aradhye
