Re: master marvin install problem
Looks like Prasanna filed a bug for mysql : https://bugs.mysql.com/bug.php?id=68549 Daan, Problem you are facing is because pypi is being updated manually. It should go away, try after some time or manually install that package. Thanks, ~Talluri On Mon, Dec 28, 2015 at 6:21 PM, Daan Hooglandwrote: > People, > > I tried to install marvin 4.8.0-SNAPSHOT this afternoon and found > mysql-connector-python missing from pypi. Is this expected? I tried last > week and everything was dandy. > > -- > Daan >
DoNot host Copyrighted stuff on home.apache.org/
Hello All, Please do not host any copyrighted material like windows templates on your apache home directory. There are concerns from Apache Infra team on presence of such copyrighted stuff on our home directories. Act on this immediately and remove them. @Testing team, We need to disable tests which are using the above until we find a way to use the copyrighted templates. Thanks, ~Talluri
Re: deploy dc with marvin
Daan, All of them are possible through marvin. Let me know if you don't figure them out. Thanks, ~Talluri On Tue, Dec 1, 2015 at 8:34 PM, Daan Hooglandwrote: > thanks Patrick, I'll look at those. I found how to enable > zonewideprimarystorage in the meanwhile. My intuition said to just place it > on zone level in the json but it turns out you need to add the scope to it. > I am going to make a patch that will deduct this from the place in the json > structure. > > On Tue, Dec 1, 2015 at 3:15 PM, Patrick Dube > wrote: > > > Hey Daahn, > > > > Not sure because I haven't tested, but there are files in /setup/dev that > > give hints. There are advancedsg.cfg and basic.cfg. Both have > > "securitygroupenabled": "true". Nothing about zone wide primary storage > > though. > > > > Cheers, > > > > Patrick > > > > On Tue, Dec 1, 2015 at 7:35 AM, Daan Hoogland > > wrote: > > > > > Santosh, Gaurav, > > > > > > I am looking for functionality to deploy a data center with features > > that I > > > don't see supported (or am to dumb to see). the things I want are: > > > > > > deploy basic zone with security groups > > > deploy advanced zone with security groups > > > deploy a zone with zone wide primary storage > > > > > > I don't think these are supported by marvin at the moment. Can you > > confirm > > > that? > > > > > > Are the internals of marvin documented somewhere? > > > > > > -- > > > Daan > > > > > > > > > -- > Daan >
Re: [NOTICE] people.apache.org web space is moving to home.apache.org
Sebastien and Ian, We should remove any copyrighted stuff. I was just facilitating the movement. I remember we added some Linux distros earlier. Sanjeev, Do you know why these were added to the tests as a requirement (I didn't track them at the time they were added)? In any case, we should sort out these issues before using/hosting them. Removed the images until there is a proper reason/permission for us to use them. ~Talluri On Mon, Nov 30, 2015 at 2:49 PM, sebgoa <run...@gmail.com> wrote: > Talluri, > > Can you answer Ian's comment below ? > > -sebastien > > On Nov 28, 2015, at 3:03 AM, Ian Duffy <i...@ianduffy.ie> wrote: > > > What are the legal implications of any of hosting that > > licensed/copyrighted/paid-for material if any? > > > > windows7.vhd > > RHEL6-64bit.ova > > RHEL764bitwithtools.vhd > > 79211594-1d4a-4dee-ae6c-c5c315ded2be.vhd which appears to be windows 8 > > > > On 25 November 2015 at 18:44, Srikanteswararao talluri < > > talluri.w...@gmail.com> wrote: > > > >> Moved all the following references in the test code to > >> https://home.apache.org/~talluri/ . github PR > >> https://github.com/apache/cloudstack/pull/1123 > >> > >> http://people.apache.org/~tsp/cloud-set-guest-password > >> > >> http://people.apache.org/~tsp/dummy.iso > >> > >> "http://people.apache.org/~sanjeev/centos63.ova;, > >> > >> "http://people.apache.org/~sanjeev/windows7.vhd;, > >> > >> "http://people.apache.org/~sanjeev/new-test-win.ova;, > >> > >> "http://people.apache.org/~sanjeev/Rhel6-64bit.ova;, > >> > >> "http://people.apache.org/~sanjeev/ttylinux_pv.vhd.bz2;, > >> > >> "http://people.apache.org/~sanjeev/RHEL764bitwithtools.vhd;, > >> > >> " > >> > http://people.apache.org/~sanjeev/79211594-1d4a-4dee-ae6c-c5c315ded2be.vhd > >> ", > >> > >> "http://people.apache.org/~sanjeev/rajani-thin-volume.vhd;, > >> > >> " > http://people.apache.org/~sanjeev/CentOS5.5(64bit)-vmware-autoscale.ova", > >> > >> "http://people.apache.org/~sanjeev/rajani-thin-volume.qcow2;, > >> > >> "http://people.apache.org/~sanjeev/centos56-x86_64.vhd.bz2;, > >> > >> "http://people.apache.org/~sanjeev/CentOS5.3-x86_64.ova; > >> > >> " > >> > http://people.apache.org/~sanjeev/eec2209b-9875-3c8d-92be-c001bd8a0faf.qcow2.bz2 > >> " > >> > >> "url": " > http://people.apache.org/~sanjeev/CentOS-6.3-x86_64-bin-DVD1.iso; > >> > >> " > >> > http://people.apache.org/~sanjeev/systemvm64template-2014-09-30-4.3-vmware.ova > >> ", > >> > >> > >> Thanks, > >> > >> ~Talluri > >> > >> > >> On Wed, Nov 25, 2015 at 8:28 PM, Daan Hoogland <daan.hoogl...@gmail.com > > > >> wrote: > >> > >>> You are right, Sebastien. @Rajani, do you have an idea on the volume of > >>> work, here? > >>> > >>> On Wed, Nov 25, 2015 at 2:10 PM, sebgoa <run...@gmail.com> wrote: > >>> > >>>> > >>>> On Nov 25, 2015, at 2:07 PM, Daan Hoogland <daan.hoogl...@gmail.com> > >>>> wrote: > >>>> > >>>>> are those refs expecting particular content returned? (it will be > >>>>> redirected) > >>>>> > >>>> > >>>> the way I read the email, it will be redirected but would give a 404 > if > >>>> you don't move the data yourself :) > >>>> > >>>>> On Wed, Nov 25, 2015 at 1:40 PM, Rajani Karuturi <raj...@apache.org> > >>>> wrote: > >>>>> > >>>>>> We have references to people.apache.org in our testdata. > >>>>>> > >>>>>> ~Rajani > >>>>>> > >>>>>> On Wed, Nov 25, 2015 at 5:50 PM, Daniel Gruno <humbed...@apache.org > >>> > >>>>>> wrote: > >>>>>> > >>>>>>> Hi folks, > >>>>>>> as the subject says, people.apache.org is being decommissioned > >> soon, > >>>> and > >>>>>>> personal web space is being moved to a new home, aptly named > >>>>>>> home.apache.org ( https://home.apache.org/ ) > >&
Re: [NOTICE] people.apache.org web space is moving to home.apache.org
Moved all the following references in the test code to https://home.apache.org/~talluri/ . github PR https://github.com/apache/cloudstack/pull/1123 http://people.apache.org/~tsp/cloud-set-guest-password http://people.apache.org/~tsp/dummy.iso "http://people.apache.org/~sanjeev/centos63.ova;, "http://people.apache.org/~sanjeev/windows7.vhd;, "http://people.apache.org/~sanjeev/new-test-win.ova;, "http://people.apache.org/~sanjeev/Rhel6-64bit.ova;, "http://people.apache.org/~sanjeev/ttylinux_pv.vhd.bz2;, "http://people.apache.org/~sanjeev/RHEL764bitwithtools.vhd;, "http://people.apache.org/~sanjeev/79211594-1d4a-4dee-ae6c-c5c315ded2be.vhd;, "http://people.apache.org/~sanjeev/rajani-thin-volume.vhd;, "http://people.apache.org/~sanjeev/CentOS5.5(64bit)-vmware-autoscale.ova", "http://people.apache.org/~sanjeev/rajani-thin-volume.qcow2;, "http://people.apache.org/~sanjeev/centos56-x86_64.vhd.bz2;, "http://people.apache.org/~sanjeev/CentOS5.3-x86_64.ova; "http://people.apache.org/~sanjeev/eec2209b-9875-3c8d-92be-c001bd8a0faf.qcow2.bz2; "url": "http://people.apache.org/~sanjeev/CentOS-6.3-x86_64-bin-DVD1.iso; "http://people.apache.org/~sanjeev/systemvm64template-2014-09-30-4.3-vmware.ova;, Thanks, ~Talluri On Wed, Nov 25, 2015 at 8:28 PM, Daan Hooglandwrote: > You are right, Sebastien. @Rajani, do you have an idea on the volume of > work, here? > > On Wed, Nov 25, 2015 at 2:10 PM, sebgoa wrote: > > > > > On Nov 25, 2015, at 2:07 PM, Daan Hoogland > > wrote: > > > > > are those refs expecting particular content returned? (it will be > > > redirected) > > > > > > > the way I read the email, it will be redirected but would give a 404 if > > you don't move the data yourself :) > > > > > On Wed, Nov 25, 2015 at 1:40 PM, Rajani Karuturi > > wrote: > > > > > >> We have references to people.apache.org in our testdata. > > >> > > >> ~Rajani > > >> > > >> On Wed, Nov 25, 2015 at 5:50 PM, Daniel Gruno > > >> wrote: > > >> > > >>> Hi folks, > > >>> as the subject says, people.apache.org is being decommissioned soon, > > and > > >>> personal web space is being moved to a new home, aptly named > > >>> home.apache.org ( https://home.apache.org/ ) > > >>> > > >>> IMPORTANT: > > >>> If you have things on people.apache.org that you would like to > retain, > > >>> please make a copy of it and move it to home.apache.org. (note, you > > will > > >>> have to make a folder called 'public_html' there, for items to show > up > > >>> under https://home.apache.org/~yourID/ ). > > >>> > > >>> We will _NOT_ be moving your data for you. There is simply too much > old > > >>> junk data on minotaur (the current people.apache.org machine) for it > > to > > >>> make sense to rsync it across, so we have made the decision that > moving > > >>> data is up to each individual committer. > > >>> > > >>> The new host, home.apache.org, will ONLY be for web space, you will > > not > > >>> have shell access to the machine (but you can copy data to it using > > SFTP > > >>> and your SSH key). Access to modify LDAP records (for project chairs) > > >>> will be moved to a separate host when the time comes. > > >>> > > >>> There will be a 3 month grace period to move your data across. After > > >>> this time span (March 1st, 2016), minotaur will no longer serve up > > >>> personal web space, and visits to people.apache.org will be > redirected > > >>> to home.apache.org. > > >>> > > >>> With regards, > > >>> Daniel on behalf of the Apache Infrastructure Team. > > >>> > > >>> PS: All replies to this should go to infrastruct...@apache.org > > >>> > > >> > > > > > > > > > > > > -- > > > Daan > > > > > > > -- > Daan >
Re: [VOTE] jenkins jobs removal
test-matrix-* and test-yumreporefresh* can safely be deleted. Thanks, ~Talluri On Tue, Oct 6, 2015 at 1:23 PM, Rohit Yadavwrote: > +1 on removing pre-4.5 jobs. > > On 02-Oct-2015, at 6:47 am, Remi Bergsma > wrote: > > +1 on 4.3 jobs, although I'd like to hear from Rohit to confirm > > +0 on the rest as I cannot judge it. > > Regards, Remi > > Sent from my iPhone > > On 02 Oct 2015, at 02:44, Pierre-Luc Dion wrote: > > Following Jenkins jobs on j.bac.o will be deleted doing the following > tasks: > 1. backup of the jobs configuration will be taken: > tar -zcvf j.bac.o_jobs-archive_20151005.tgz ~jenkins/jobs > 2. job will be deleted from jenkins > 3. workspaces will be deleted from jenkins master server to free up disk > space. > > > VIEW | NAME | > STATE| LAST_SUCCESS > > -|---|--|-- > 4.3 | cloudstack-4.3-maven-build| blue > | 2015-08-14 01:59:15 > 4.3 | cloudstack-4.3-maven-build-noredist | > aborted | 2015-03-11 08:11:01 > 4.3 | cloudstack-4.3-package-deb| blue > | 2015-08-14 02:04:39 > 4.3 | cloudstack-4.3-package-rpm| blue > | 2015-03-11 08:11:01 > 4.3 | cloudstack-4.3-package-rpm-noredist | blue > | 2014-09-02 10:29:12 > 4.3 | cloudstack-4.3-systemvm | blue > | 2015-01-28 15:33:09 > 4.3 | cloudstack-4.3-systemvm64 | blue > | 2015-01-28 13:25:12 > 4.3 | HyperVAgent4.3| blue > | 2014-12-04 11:27:14 > disabled | build-docs-admin-master | > disabled | 2014-03-25 13:20:25 > disabled | build-docs-devguide-master| > disabled | 2014-03-25 13:26:51 > disabled | build-docs-install-master | > disabled | 2014-03-25 13:26:51 > disabled | build-docs-midonet-master | > disabled | 2014-02-06 06:44:22 > disabled | build-docs-niciranvp-master | > disabled | 2014-02-06 06:42:37 > disabled | build-docs-release-notes-master | > disabled | 2014-02-06 06:48:51 > disabled | build-docs-vxlan-master | > disabled | 2014-02-06 06:26:57 > disabled | build-test-centos-builtin | > disabled | n/a > disabled | built-test-archive| > disabled | 2014-06-06 01:38:51 > disabled | cloudstack-4.4-auto-marvin| > disabled | 2015-06-15 13:28:22 > disabled | docs-4.3-gsoc-guide | > disabled | 2015-03-08 18:20:07 > disabled | Master - Python Static Code Analysis | > disabled | n/a > disabled | mgmt-build-reviewboard-requests | > disabled | n/a > disabled | run-checkin-tests | > disabled | n/a > disabled | simulator-build | > disabled | 2014-07-31 09:47:03 > disabled | simulator-deploydb| > disabled | 2014-02-12 19:50:50 > disabled | simulator-gate| > disabled | 2014-01-23 04:18:31 > disabled | simulator-singlerun | > disabled | 2015-05-01 10:30:28 > disabled | start-jetty | > disabled | 2014-02-12 19:23:03 > disabled | stop-jetty| > disabled | 2013-11-20 08:14:46 > disabled | test-matrix-4.4 | > disabled | n/a > disabled | test-matrix-extended-4.4 | > disabled | n/a > disabled | test-matrix-extended-master | > disabled | 2014-02-21 04:35:36 > disabled | test-matrix-master| > disabled | n/a > disabled | test-smoke-matrix-master | > disabled | 2014-12-21 10:39:18 > disabled | test-yumrepo-refresh-4.4 | > disabled | 2014-10-21 09:43:33 > disabled | test-yumrepo-refresh-master | > disabled | 2014-11-21 05:32:00 > management | mgmt-build-reviewboard-requests | > disabled | n/a > master | build-systemvm64-master-with-debian8 | red >| n/a > master | cloudstack-rpm-packages-with-branch-parameter | > notbuilt | n/a > master | pull-requests | > notbuilt | n/a > parameterized
Re: test failure question
I don't see any problem in my env. Anyways, I submitted a pull request to fix this. will push that fix once I get comments, you should be able to use the freshly built marvin in your env with this fix. https://github.com/apache/cloudstack/pull/537 ~Talluri On Fri, Jun 26, 2015 at 9:18 PM, Daan Hoogland daan.hoogl...@gmail.com wrote: H, In a new environment I cannot get marvin tests to run: 2015-06-26 11:36:54,022 - DEBUG - Parsing Test data successful 2015-06-26 11:36:54,023 - DEBUG - Payload: {'account': 'admin', 'command': 'listUsers', 'response': 'json'} 2015-06-26 11:36:54,023 - DEBUG - Sending GET Cmd : listUsers=== 2015-06-26 11:36:54,087 - DEBUG - Response : [{username : u'admin', account : u'admin', domainid : u'6891906c-19e5-11e5-a53a-5254001daa60', firstname : u'Admin', created : u'2015-06-23T12:21:19-0400', lastname : u'User', apikey : u'kjjGt2xnauAxcxx0xCXYq1ltEhtqetVQb42W0YylZDMAohjZZ6xPhihsyUHQdhBKO7Q4AsU-ejF32IWWnljl-g', domain : u'ROOT', id : u'6892187f-19e5-11e5-a53a-5254001daa60', secretkey : u'2mYsMA-bqMkuhXhS7qM-YPlK_Jgd4BhUEh67p87pgw4XdBE1Wuh9vNPI--ryFBVciSgcvJzOe2f9cyRO57RBGQ', iscallerchilddomain : False, state : u'enabled', accounttype : 1, email : u'ad...@mailprovider.com', isdefault : True, accountid : u'6891c9f6-19e5-11e5-a53a-5254001daa60'}] 2015-06-26 11:36:54,088 - DEBUG - Test Client Creation Successful 2015-06-26 11:36:54,094 - CRITICAL - EXCEPTION: Failure:: ['Traceback (most recent call last):\n', ' File /usr/lib/python2.7/site-packages/nose/case.py, line 132, in run\n self.beforeTest(result)\n', ' File /usr/lib/python2.7/site-packages/nose/case.py, line 74, in beforeTest\nbeforeTest(self.test)\n', ' File /usr/lib/python2.7/site-packages/nose/proxy.py, line 117, in beforeTest\nself.plugins.beforeTest(self.test)\n', ' File /usr/lib/python2.7/site-packages/nose/plugins/manager.py, line 99, in __call__\nreturn self.call(*arg, **kw)\n', ' File /usr/lib/python2.7/site-packages/nose/plugins/manager.py, line 167, in simple\nresult = meth(*arg, **kw)\n', ' File /usr/lib/python2.7/site-packages/Marvin-4.6.0_SNAPSHOT-py2.7.egg/marvin/marvinPlugin.py, line 172, in beforeTest\njoin([self.__identifier, self.__testName])\n', 'TypeError: sequence item 0: expected string, NoneType found\n'] Can anyone see in this output If I forgot to configure something? cl is nosetests --with-marvin --marvin-config=/data/shared/marvin/mct-zone1-xen1.cfg -s -a tags=advanced,required_hardware=false smoke/test_vm_life_cycle.py but other tests have failed in the same way. content of mct-zone1-xen1.cfg is { zones: [ { name: MCCT-SHARED-1, guestcidraddress: 10.1.1.0/24, dns1: 8.8.8.8, physical_networks: [ { broadcastdomainrange: Zone, vlan: 100-200, name: mcct-pnet, traffictypes: [ { typ: Guest }, { typ: Management }, { typ: Public } ], providers: [ { broadcastdomainrange: ZONE, name: VirtualRouter }, { broadcastdomainrange: ZONE, name: VpcVirtualRouter }, { broadcastdomainrange: ZONE, name: InternalLbVm } ], isolationmethods: [ VLAN ] } ], ipranges: [ { startip: 192.168.23.2, endip: 192.168.23.20, netmask: 255.255.255.0, vlan: 50, gateway: 192.168.23.1 } ], networktype: Advanced, pods: [ { endip: 192.168.22.150, name: MCCT-POD, startip: 192.168.22.130, netmask: 255.255.255.0, clusters: [ ], clusters: [ { clustername: MCCT-XEN-1, hypervisor: XenServer, hosts: [ { username: root, url: http://192.168.22.11;, password: password
Re: jenkins disk full ?
There is no space . /dev/xvdf1 50G 47G 0 100% /var/lib/jenkins/workspace I have cleaned up builds for 'fastsimulatorbuild' job which were using 9G. Modified the job to delete old builds and artefacts after 30 builds/30days. ~Talluri On Mon, Jun 1, 2015 at 8:14 PM, Pierre-Luc Dion pd...@cloudops.com wrote: Can someone that have access to the principal jenkins server to check disk space left? getting this error on few slave, the one I've check does not have disk full Thread has died java.io.IOException: No space left on device at java.io.FileOutputStream.writeBytes(Native Method) at java.io.FileOutputStream.write(FileOutputStream.java:318) at sun.nio.cs.StreamEncoder.writeBytes(StreamEncoder.java:221) at sun.nio.cs.StreamEncoder.implClose(StreamEncoder.java:316) at sun.nio.cs.StreamEncoder.close(StreamEncoder.java:149) at java.io.OutputStreamWriter.close(OutputStreamWriter.java:233) at java.io.BufferedWriter.close(BufferedWriter.java:266) at hudson.util.AtomicFileWriter.close(AtomicFileWriter.java:94) at hudson.util.AtomicFileWriter.commit(AtomicFileWriter.java:109) at hudson.util.TextFile.write(TextFile.java:121) at hudson.model.Job.saveNextBuildNumber(Job.java:274) at hudson.model.Job.assignBuildNumber(Job.java:332) at hudson.model.Run.init(Run.java:286) at hudson.model.AbstractBuild.init(AbstractBuild.java:167) at hudson.model.Build.init(Build.java:92) at hudson.model.FreeStyleBuild.init(FreeStyleBuild.java:34) at sun.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method) at sun.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:57) at sun.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45) at java.lang.reflect.Constructor.newInstance(Constructor.java:525) at jenkins.model.lazy.LazyBuildMixIn.newBuild(LazyBuildMixIn.java:186) at hudson.model.AbstractProject.newBuild(AbstractProject.java:1000) at hudson.model.AbstractProject.createExecutable(AbstractProject.java:1193) at hudson.model.AbstractProject.createExecutable(AbstractProject.java:143) at hudson.model.Executor.run(Executor.java:213) more info http://wiki.jenkins-ci.org/display/JENKINS/Dead+Executor ref: http://jenkins.buildacloud.org/computer/cca-slave-02/executors/0/causeOfDeath Thanks!
Re: Marvin Error
Yeah, it is available post 2.7.9, Its my bad to use the private variable from module. I¹ll see If I can fix that. ~Talluri On 28/04/15 5:54 pm, Rohit Yadav rohit.ya...@shapeblue.com wrote: Hi Ian, Turns out this is an environment issue, the attribute maybe only available with ssl module of Python 2.7+ and not all 2.x ones. I¹ve fixed it on master now. On 28-Apr-2015, at 12:29 pm, Ian Southam isout...@schubergphilis.com wrote: Hi, Latest Marvin build has an error in it. Has anyone already worked out the cause before I put work into it? Common.py will not load because of an unresolved symbol in vcenter.py Traceback (most recent call last): File /cloudstack/cloudstack/test/integration/smoke/misc/test_deploy_vm.py, line 33, in module from marvin.lib.common import get_zone, get_domain, get_template File /cloudstack/test/venv/lib/python2.7/site-packages/marvin/lib/common.py, line 91, in module from marvin.lib.vcenter import Vcenter File /cloudstack/test/venv/lib/python2.7/site-packages/marvin/lib/vcenter.py , line 22, in module ssl._create_default_https_context = ssl._create_unverified_context AttributeError: 'module' object has no attribute Œ_create_unverified_context' ‹ Grts! Ian Regards, Rohit Yadav Software Architect, ShapeBlue M. +91 88 262 30892 | rohit.ya...@shapeblue.com Blog: bhaisaab.org | Twitter: @_bhaisaab Find out more about ShapeBlue and our range of CloudStack related services IaaS Cloud Design Buildhttp://secure-web.cisco.com/1JRBZ2tHThxZmrfZ-PjiksQzmgirJbQ9_z-NJqRG 87eUIbwdSEb9GowMC62K5dqF8JJUcxQiF5L1NLZSo-N04_9RnOkwYm8kXFzdJBkyFP1ZRkginY CvvshGkloa3krD506R2nElv-2c0QNC0H0MuliyqYNYTwnHOeVsNWMJgI-Zq48tRIXbEb946SFP 0tm4e/http%3A%2F%2Fshapeblue.com%2Fiaas-cloud-design-and-build%2F%2F CSForge rapid IaaS deployment frameworkhttp://secure-web.cisco.com/1jqXHXSSUbv8qeK6MHY1ojhPugImyZ7C6mEv g9Xvm8oKaxbEcF10KSZa5Qa-eR36AkIHbKWQbQpU4CT0Da2NNj9_UFGyaEzIGvz2ykzBwWIHOk fyErFKKcw1PU1WAYAHKU5j9j-MqsYb48W8t0cK5dgE4_8AnTscnej0sLDV0o5t2aNRD8kJl1TG 3Cbikpw0r/http%3A%2F%2Fshapeblue.com%2Fcsforge%2F CloudStack Consultinghttp://secure-web.cisco.com/1oYDQulyDWVvx3jGMRlI18C7PB0NxyuTKUs tfK2HPzeX0M-rIxFdddAcYFLmFA3VDGpdZXEJ13dEmtuDf9mJCzBzjJzCCaROeadTC6yGB5Fr_ yYkEd_MQTP8lg2t90pjLbZHgefXnzshsriEvalCvHC_H-G7b3STObJwFZIdmbPCAb-wgrJtrmi 1vuo-BsqLy/http%3A%2F%2Fshapeblue.com%2Fcloudstack-consultancy%2F CloudStack Software Engineeringhttp://secure-web.cisco.com/1xCgMi7FhUk8kLXLy0kOG-KVpTOWVGkPIR IwCj04qfLBi9oLhB1xfabHvIvD8wVxRLlkUTgTXJMMhS-cfo8M5fxi1SCkJ0puiCUhCk-UwSgU cPD5l7S7tr6XjJZTG0Z8r8Wx3C0l43mA3Ru1HgLnsXihpRLGAwpnQTo1ixM96j9jSRKQNcLU7V wRxl0-FxlXp/http%3A%2F%2Fshapeblue.com%2Fcloudstack-software-engineering%2 F CloudStack Infrastructure Supporthttp://secure-web.cisco.com/1Qh4jT0q6pjdUYr5Xh_RkG1fh0tqvwE1nGkivZ B9Cd0DSPp6KeDQ-BhvB-1udPqVT9gbQn7vEnhb5UcGfYe0JdWcD4QbmEIFlBLj8Q71l28tcGlp oOtVmXPwX4F5yIl3TzYvG9MhjvES_Oed65ElE7T-Z00kfFjSis8K61WF17ackCPr6lUpqNVr6k 0YoCE9W/http%3A%2F%2Fshapeblue.com%2Fcloudstack-infrastructure-support%2F CloudStack Bootcamp Training Courseshttp://secure-web.cisco.com/10nWgATEhsj0n2TPooKG4i0r9LBQt1X8pqcHOH _us8-YHyeYvF60c4qlZFAVKK8eaAYf7qC5CleKXru-PTZLSLmtfAs3yY5_Li4lEC8OjYFaZYEJ B_e79rUP7fUNdPg9rzpN37pG-r9vcCOTa_yiN3d4DVHV1dyGV3T7hoxA6JgfAc4zefEqh6-wf7 26Q3AJw/http%3A%2F%2Fshapeblue.com%2Fcloudstack-training%2F This email and any attachments to it may be confidential and are intended solely for the use of the individual to whom it is addressed. Any views or opinions expressed are solely those of the author and do not necessarily represent those of Shape Blue Ltd or related companies. If you are not the intended recipient of this email, you must neither take any action based upon its contents, nor copy or show it to anyone. Please contact the sender if you believe you have received this email in error. Shape Blue Ltd is a company incorporated in England Wales. ShapeBlue Services India LLP is a company incorporated in India and is operated under license from Shape Blue Ltd. Shape Blue Brasil Consultoria Ltda is a company incorporated in Brasil and is operated under license from Shape Blue Ltd. ShapeBlue SA Pty Ltd is a company registered by The Republic of South Africa and is traded under license from Shape Blue Ltd. ShapeBlue is a registered trademark.
Re: simulator failing runs in j.b.a.c.o
Multi python version issue on slave. Fixed it too Dan. On 19/04/15 2:06 pm, Daan Hoogland daan.hoogl...@gmail.com wrote: Thanks Talluri, I see the test now passes somewhat further it is not successful yet. the jenkins user cannot access the module urandom. Not sure if this should be fixed in the build job or on the slave. On Sun, Apr 19, 2015 at 8:22 AM, Srikanteswararao Talluri srikanteswararao.tall...@citrix.com wrote: Simulator jobs have been failing for a while due to incompatible/missing python nose plugins. I fixed the jenkins slave and the jobs to update the marvin for each build. http://jenkins.buildacloud.org/view/simulator/job/simulator-singlerun/ Thanks, ~Talluri -- Daan
simulator failing runs in j.b.a.c.o
Simulator jobs have been failing for a while due to incompatible/missing python nose plugins. I fixed the jenkins slave and the jobs to update the marvin for each build. http://jenkins.buildacloud.org/view/simulator/job/simulator-singlerun/ Thanks, ~Talluri
Re: simulator failing runs in j.b.a.c.o
Downgraded jenkins s3 plugin. Master systemvm build is also successful. On 19/04/15 10:37 pm, Srikanteswararao Talluri srikanteswararao.tall...@citrix.com wrote: Master systemvms were built successfully, however, jenkins job fails to push the artifacts to S3. This could be due to a bug in jenkins s3 plugin which is still in open state : https://issues.jenkins-ci.org/browse/JENKINS-27660 We might need to downgrade jenkins s3 plugin for time being. (downgrade to v0.6) Hugo?? ~Talluri On 19/04/15 4:27 pm, Daan Hoogland daan.hoogl...@gmail.com wrote: great, all master builds succeed now, only systemvm is unstable. let's not slack anymore people. Good work Tulari. Any volunteers? some builds in other groups are still a problem. On Sun, Apr 19, 2015 at 12:02 PM, Srikanteswararao Talluri srikanteswararao.tall...@citrix.com wrote: Multi python version issue on slave. Fixed it too Dan. On 19/04/15 2:06 pm, Daan Hoogland daan.hoogl...@gmail.com wrote: Thanks Talluri, I see the test now passes somewhat further it is not successful yet. the jenkins user cannot access the module urandom. Not sure if this should be fixed in the build job or on the slave. On Sun, Apr 19, 2015 at 8:22 AM, Srikanteswararao Talluri srikanteswararao.tall...@citrix.com wrote: Simulator jobs have been failing for a while due to incompatible/missing python nose plugins. I fixed the jenkins slave and the jobs to update the marvin for each build. http://jenkins.buildacloud.org/view/simulator/job/simulator-singlerun/ Thanks, ~Talluri -- Daan -- Daan
Re: simulator failing runs in j.b.a.c.o
Master systemvms were built successfully, however, jenkins job fails to push the artifacts to S3. This could be due to a bug in jenkins s3 plugin which is still in open state : https://issues.jenkins-ci.org/browse/JENKINS-27660 We might need to downgrade jenkins s3 plugin for time being. (downgrade to v0.6) Hugo?? ~Talluri On 19/04/15 4:27 pm, Daan Hoogland daan.hoogl...@gmail.com wrote: great, all master builds succeed now, only systemvm is unstable. let's not slack anymore people. Good work Tulari. Any volunteers? some builds in other groups are still a problem. On Sun, Apr 19, 2015 at 12:02 PM, Srikanteswararao Talluri srikanteswararao.tall...@citrix.com wrote: Multi python version issue on slave. Fixed it too Dan. On 19/04/15 2:06 pm, Daan Hoogland daan.hoogl...@gmail.com wrote: Thanks Talluri, I see the test now passes somewhat further it is not successful yet. the jenkins user cannot access the module urandom. Not sure if this should be fixed in the build job or on the slave. On Sun, Apr 19, 2015 at 8:22 AM, Srikanteswararao Talluri srikanteswararao.tall...@citrix.com wrote: Simulator jobs have been failing for a while due to incompatible/missing python nose plugins. I fixed the jenkins slave and the jobs to update the marvin for each build. http://jenkins.buildacloud.org/view/simulator/job/simulator-singlerun/ Thanks, ~Talluri -- Daan -- Daan
Re: Inconsistencies in tests
I will help you set the job up. On 15/04/15 12:34 pm, Gaurav Aradhye gaurav.arad...@clogeny.com wrote: Talluri, I still have to do it. Didn’t get enough time on it. Not a jenkins expert. Can anybody help me in setting jenkins job for tests which will do static code analysis (python) and pep8 analysis? Regards, Gaurav Aradhye On Apr 15, 2015, at 12:28 PM, Srikanteswararao Talluri srikanteswararao.tall...@citrix.com wrote: +1 Gaurav, You were talking about integrating static code analysis in jenkins.b.a.c.o. How is it going? Thanks, ~Talluri On 14/04/15 3:50 pm, Sebastien Goasguen run...@gmail.com wrote: On Apr 14, 2015, at 9:06 AM, Gaurav Aradhye gaurav.arad...@clogeny.com wrote: Hi all, I feel that the test code in BVT and Regression tests (smoke and component folders) should be more consistent. There are feature developers adding tests into smoke and different test developers adding more tests into component folder, it is evident that inconsistencies are bound to arise. But with time, we should be striving to minimize them. I have listed few of the inconsistencies below. Feel free to add to the list if you think of more. 1. List Methods: If we want to list accounts, some tests use Account.list method, while some use list_accounts method. Both methods finally do the same thing, but there are many list methods in common.py file corresponding base class methods in base.py. This is code duplication. I feel that BaseClass.method() is more readable than list_xyz(), or should be preferred. 2. Checking empty/None lists: We already have validateList utility method which checks both empty lists and None objects. No need to use ³isinstance² method, or add additional None checks. 3. Pep8 issues: Many files are not pep8 consistent. In the past I have tried to fix pep8 issues in files and the mission is ON. Efforts need to be put into this. We already have autopep8 tool which does most of the things. +1 that¹s really a low hanging fruit and best practice. we should not be merging anything that breaks pep8 we should also add pylint tests checking for pep8 and python of all python code can be done at the high level using something like tox, kind of like the RAT tests I will be creating separate issues in JIRA for listed things. Everyone is welcome to add pull requests for these tasks. I personally will be putting more efforts into these in upcoming few months. 2-3 months and we should see most of the tests consistent with each other. Regards, Gaurav
Re: Inconsistencies in tests
+1 Gaurav, You were talking about integrating static code analysis in jenkins.b.a.c.o. How is it going? Thanks, ~Talluri On 14/04/15 3:50 pm, Sebastien Goasguen run...@gmail.com wrote: On Apr 14, 2015, at 9:06 AM, Gaurav Aradhye gaurav.arad...@clogeny.com wrote: Hi all, I feel that the test code in BVT and Regression tests (smoke and component folders) should be more consistent. There are feature developers adding tests into smoke and different test developers adding more tests into component folder, it is evident that inconsistencies are bound to arise. But with time, we should be striving to minimize them. I have listed few of the inconsistencies below. Feel free to add to the list if you think of more. 1. List Methods: If we want to list accounts, some tests use Account.list method, while some use list_accounts method. Both methods finally do the same thing, but there are many list methods in common.py file corresponding base class methods in base.py. This is code duplication. I feel that BaseClass.method() is more readable than list_xyz(), or should be preferred. 2. Checking empty/None lists: We already have validateList utility method which checks both empty lists and None objects. No need to use ³isinstance² method, or add additional None checks. 3. Pep8 issues: Many files are not pep8 consistent. In the past I have tried to fix pep8 issues in files and the mission is ON. Efforts need to be put into this. We already have autopep8 tool which does most of the things. +1 that¹s really a low hanging fruit and best practice. we should not be merging anything that breaks pep8 we should also add pylint tests checking for pep8 and python of all python code can be done at the high level using something like tox, kind of like the RAT tests I will be creating separate issues in JIRA for listed things. Everyone is welcome to add pull requests for these tasks. I personally will be putting more efforts into these in upcoming few months. 2-3 months and we should see most of the tests consistent with each other. Regards, Gaurav
Re: [ANNOUNCE] New committer: Gaurav Nandkumar Aradhye
Congrats Gaurav! Well deserved. ~Talluri On 14/04/15 1:13 am, Daan Hoogland daan.hoogl...@gmail.com wrote: The Project Management Committee (PMC) for Apache CloudStack has asked Gaurav Aradhya to become a committer and we are pleased to announce that they have accepted. Being a committer allows many contributors to contribute more autonomously. For developers, it makes it easier to submit changes and eliminates the need to have contributions reviewed via the patch submission process. Whether contributions are development-related or otherwise, it is a recognition of a contributor's participation in the project and commitment to the project and the Apache Way. Please join me in congratulating Gaurav -- Daan on behalf of the CloudStack PMC
Re: vim25.jar missing from mvn repo?
You need to get the dependencies before you build. Following links should help you. https://cwiki.apache.org/confluence/display/CLOUDSTACK/How+to+build+CloudSt ack#HowtobuildCloudStack-Dependencies https://cwiki.apache.org/confluence/display/CLOUDSTACK/Hypervisor+VMWare Thanks, ~Talluri On 01/04/15 10:14 pm, Jeronimo Garcia garciaj...@gmail.com wrote: Hi list. I'm trying to build the master on git and I'm getting this: [ERROR] Failed to execute goal on project cloud-vmware-base: Could not resolve dependencies for project org.apache.cloudstack:cloud-vmware-base:jar:4.6.0-SNAPSHOT: Failure to find com.cloud.com.vmware:vmware-vim25:jar:5.1 in https://repo.maven.apache.org/maven2 was cached in the local repository, resolution will not be reattempted until the update interval of central has elapsed or updates are forced - [Help 1] command: mvn -DskipTests=true -P vmware clean install Am i missing something? the jar file is not in the remote maven repos .. Thanks!
Re: [ANNOUNCE] Rohit Yadav as new PMC member of CloudStack
Congrats Rohit! ~Talluri On 31/03/15 11:05 am, Harikrishna Patnala harikrishna.patn...@citrix.com wrote: Congrats Rohit :) -Harikrishna On 31-Mar-2015, at 10:45 am, Wilder Rodrigues wrodrig...@schubergphilis.com wrote: Congratulation, Rohit! Keep up the cool stuff! ;) Cheers, Wilder On 27 Mar 2015, at 09:07, Sebastien Goasguen run...@gmail.com wrote: The Project Management Committee (PMC) for Apache CloudStack are pleased to announce that Rohit Yadav has accepted our invitation to join the PMC. Please join me in congratulating him. On behalf of the Apache CloudStack PMC
Re: [ANNOUNCE] New PMC Member: Lucian (Nux)
Congratulations Lucian!! ~Talluri On 26/03/15 10:32 am, Rohit Yadav rohit.ya...@shapeblue.com wrote: Congrats Lucian! On 26-Mar-2015, at 9:12 am, Rajani Karuturi raj...@apache.org wrote: The Project Management Committee (PMC) for Apache CloudStack has asked Lucian to join the PMC and we are pleased to announce that he has accepted. Join me in congratulating Lucian! On behalf of the Apache CloudStack PMC ~Rajani Regards, Rohit Yadav Software Architect, ShapeBlue M. +91 88 262 30892 | rohit.ya...@shapeblue.com Blog: bhaisaab.org | Twitter: @_bhaisaab Find out more about ShapeBlue and our range of CloudStack related services IaaS Cloud Design Buildhttp://shapeblue.com/iaas-cloud-design-and-build// CSForge rapid IaaS deployment frameworkhttp://shapeblue.com/csforge/ CloudStack Consultinghttp://shapeblue.com/cloudstack-consultancy/ CloudStack Software Engineeringhttp://shapeblue.com/cloudstack-software-engineering/ CloudStack Infrastructure Supporthttp://shapeblue.com/cloudstack-infrastructure-support/ CloudStack Bootcamp Training Courseshttp://shapeblue.com/cloudstack-training/ This email and any attachments to it may be confidential and are intended solely for the use of the individual to whom it is addressed. Any views or opinions expressed are solely those of the author and do not necessarily represent those of Shape Blue Ltd or related companies. If you are not the intended recipient of this email, you must neither take any action based upon its contents, nor copy or show it to anyone. Please contact the sender if you believe you have received this email in error. Shape Blue Ltd is a company incorporated in England Wales. ShapeBlue Services India LLP is a company incorporated in India and is operated under license from Shape Blue Ltd. Shape Blue Brasil Consultoria Ltda is a company incorporated in Brasil and is operated under license from Shape Blue Ltd. ShapeBlue SA Pty Ltd is a company registered by The Republic of South Africa and is traded under license from Shape Blue Ltd. ShapeBlue is a registered trademark.
Re: [Announce] - New VP Apache Cloudstack
Congratulations Sebastien! And Thanks Hugo. ~Talluri On 23/03/15 5:46 pm, Paul Angus paul.an...@shapeblue.com wrote: Congratulations Sebastien!! Regards, Paul Angus Cloud Architect D: +44 20 3468 5163 |S: +44 20 3603 0540 | M: +44 7711 418 784 | T: @CloudyAngus paul.an...@shapeblue.com -Original Message- From: Erik Weber [mailto:terbol...@gmail.com] Sent: 23 March 2015 12:04 To: dev Subject: Re: [Announce] - New VP Apache Cloudstack On Mon, Mar 23, 2015 at 12:40 PM, Giles Sirett giles.sir...@shapeblue.com wrote: All The Apache Cloudstack PMC is delighted to announce that on March 18 an ASF board resolution was passed to make Sebastien Goasguen the new Chair/VP of Apache CloudStack. Sebastien replaces Hugo in this role I¹m sure you¹ll all join me in wishing Sebastien all the best for the next 12 months and also in thanking Hugo for all of his hard work over the last year. Congratulations Sebastien! Thanks for all your work Hugo! -- Erik Find out more about ShapeBlue and our range of CloudStack related services IaaS Cloud Design Buildhttp://shapeblue.com/iaas-cloud-design-and-build// CSForge rapid IaaS deployment frameworkhttp://shapeblue.com/csforge/ CloudStack Consultinghttp://shapeblue.com/cloudstack-consultancy/ CloudStack Software Engineeringhttp://shapeblue.com/cloudstack-software-engineering/ CloudStack Infrastructure Supporthttp://shapeblue.com/cloudstack-infrastructure-support/ CloudStack Bootcamp Training Courseshttp://shapeblue.com/cloudstack-training/ This email and any attachments to it may be confidential and are intended solely for the use of the individual to whom it is addressed. Any views or opinions expressed are solely those of the author and do not necessarily represent those of Shape Blue Ltd or related companies. If you are not the intended recipient of this email, you must neither take any action based upon its contents, nor copy or show it to anyone. Please contact the sender if you believe you have received this email in error. Shape Blue Ltd is a company incorporated in England Wales. ShapeBlue Services India LLP is a company incorporated in India and is operated under license from Shape Blue Ltd. Shape Blue Brasil Consultoria Ltda is a company incorporated in Brasil and is operated under license from Shape Blue Ltd. ShapeBlue SA Pty Ltd is a company registered by The Republic of South Africa and is traded under license from Shape Blue Ltd. ShapeBlue is a registered trademark.
Re: Jenkins access
You have already a user id ŒIlya¹. What exactly are you looking for? ~Talluri On 21/03/15 12:10 am, ilya ilya.mailing.li...@gmail.com wrote: How do i get access to Jenkins? Thanks ilya
Re: Jenkins access
Okay, you have required access to jenkins jobs. ~Talluri On 21/03/15 12:10 am, ilya ilya.mailing.li...@gmail.com wrote: How do i get access to Jenkins? Thanks ilya
Re: Jenkins access
I think he is talking about jenkins.buildacloud.org as he expressed interest in enhancing vmware system vm template job. ~Talluri On 21/03/15 3:19 am, David Nalley da...@gnsa.us wrote: which jenkins? On Fri, Mar 20, 2015 at 2:40 PM, ilya ilya.mailing.li...@gmail.com wrote: How do i get access to Jenkins? Thanks ilya
Re: [ANNOUNCE] New committer: Karen Vuong
Congts Karen! ~Talluri On 20/03/15 2:15 pm, Daan Hoogland daan.hoogl...@gmail.com wrote: thanks for everything Karen, On Fri, Mar 20, 2015 at 9:20 AM, Paul Angus paul.an...@shapeblue.com wrote: Congratulations Karen! Regards, Paul Angus Cloud Architect D: +44 20 3468 5163 |S: +44 20 3603 0540 | M: +44 7711 418 784 | T: @CloudyAngus paul.an...@shapeblue.com -Original Message- From: Rohit Yadav [mailto:rohit.ya...@shapeblue.com] Sent: 20 March 2015 06:28 To: us...@cloudstack.apache.org Cc: dev@cloudstack.apache.org Subject: Re: [ANNOUNCE] New committer: Karen Vuong Congratulations Karen, I appreciate your commitment to the project and its community! On 20-Mar-2015, at 10:10 am, Mike Tutkowski mike.tutkow...@solidfire.com wrote: Congratulations, Karen! On Thu, Mar 19, 2015 at 4:07 PM, Pierre-Luc Dion pd...@cloudops.com wrote: The Project Management Committee (PMC) for Apache CloudStack has asked Karen Vuong to become a committer and we are pleased to announce that she have accepted. Karen is doing a huge effort on promoting CloudStack and organizing events such as CloudStack days, CloudStack collaboration conferences and meetups. She is helping a lot on the marketing effort as well. Being a committer allows many contributors to contribute more autonomously. For developers, it makes it easier to submit changes and eliminates the need to have contributions reviewed via the patch submission process. Whether contributions are development-related or otherwise, it is a recognition of a contributor's participation in the project and commitment to the project and the Apache Way. Please join me in congratulating Karen (karenv) --Pierre-Luc on behalf of the CloudStack PMC -- *Mike Tutkowski* *Senior CloudStack Developer, SolidFire Inc.* e: mike.tutkow...@solidfire.com o: 303.746.7302 Advancing the way the world uses the cloud http://solidfire.com/solution/overview/?video=play** Regards, Rohit Yadav Software Architect, ShapeBlue M. +91 88 262 30892 | rohit.ya...@shapeblue.com Blog: bhaisaab.org | Twitter: @_bhaisaab Find out more about ShapeBlue and our range of CloudStack related services IaaS Cloud Design Buildhttp://shapeblue.com/iaas-cloud-design-and-build// CSForge rapid IaaS deployment frameworkhttp://shapeblue.com/csforge/ CloudStack Consultinghttp://shapeblue.com/cloudstack-consultancy/ CloudStack Software Engineeringhttp://shapeblue.com/cloudstack-software-engineering/ CloudStack Infrastructure Supporthttp://shapeblue.com/cloudstack-infrastructure-support/ CloudStack Bootcamp Training Courseshttp://shapeblue.com/cloudstack-training/ This email and any attachments to it may be confidential and are intended solely for the use of the individual to whom it is addressed. Any views or opinions expressed are solely those of the author and do not necessarily represent those of Shape Blue Ltd or related companies. If you are not the intended recipient of this email, you must neither take any action based upon its contents, nor copy or show it to anyone. Please contact the sender if you believe you have received this email in error. Shape Blue Ltd is a company incorporated in England Wales. ShapeBlue Services India LLP is a company incorporated in India and is operated under license from Shape Blue Ltd. Shape Blue Brasil Consultoria Ltda is a company incorporated in Brasil and is operated under license from Shape Blue Ltd. ShapeBlue SA Pty Ltd is a company registered by The Republic of South Africa and is traded under license from Shape Blue Ltd. ShapeBlue is a registered trademark. Find out more about ShapeBlue and our range of CloudStack related services IaaS Cloud Design Buildhttp://shapeblue.com/iaas-cloud-design-and-build// CSForge rapid IaaS deployment frameworkhttp://shapeblue.com/csforge/ CloudStack Consultinghttp://shapeblue.com/cloudstack-consultancy/ CloudStack Software Engineeringhttp://shapeblue.com/cloudstack-software-engineering/ CloudStack Infrastructure Supporthttp://shapeblue.com/cloudstack-infrastructure-support/ CloudStack Bootcamp Training Courseshttp://shapeblue.com/cloudstack-training/ This email and any attachments to it may be confidential and are intended solely for the use of the individual to whom it is addressed. Any views or opinions expressed are solely those of the author and do not necessarily represent those of Shape Blue Ltd or related companies. If you are not the intended recipient of this email, you must neither take any action based upon its contents, nor copy or show it to anyone. Please contact the sender if you believe you have received this email in error. Shape Blue Ltd is a company incorporated in England Wales. ShapeBlue Services India LLP is a company incorporated in India and is operated under license from Shape Blue Ltd. Shape Blue Brasil Consultoria Ltda is a company incorporated in Brasil and is operated under license from Shape Blue Ltd. ShapeBlue SA Pty Ltd is a
Re: Need a Jenkins account
Done. Details sent to your email. ~Talluri On 20/03/15 3:03 pm, Gaurav Aradhye gaurav.arad...@clogeny.com wrote: Hello all, I need a Jenkins account, to examine current jobs and also to create a new job that will statically analyze the test cases added to repository and generate a report with any issues found with the script. It will use static code analyzers for python and we can expect a report generated for every commit which modifies tests folder. Can somebody please create an account for me and give me required access? Regards, Gaurav
Re: Guidelines for test developers
Thanks Gaurav for putting up this guidelines page. Good work! ~Talluri On 19/03/15 10:59 am, Gaurav Aradhye gaurav.arad...@clogeny.com wrote: I have added Wiki page for this in QA section. https://cwiki.apache.org/confluence/display/CLOUDSTACK/Guidelines+for+test +developers Not a very polished one, but I will be adding and polishing it soon. Regards, Gaurav On Thu, Mar 19, 2015 at 9:52 AM, Gaurav Aradhye gaurav.arad...@clogeny.com wrote: Paul, Some pages on wiki talk about general guidelines to Dev, but there is no page stating detailed guidelines for test developers. I would like to add a new page in QA section for this. Will drop separate mail for write access to wiki. Daan, I will have to check on this. I will find out how we can include static analysis for tests similar to that it is in place for dev code (findbugs). Regards, Gaurav On Wed, Mar 18, 2015 at 8:22 PM, Daan Hoogland daan.hoogl...@gmail.com wrote: good write-up Gaurav, I hope that most of these can be validated/verified checkstyle-style. pep8 can of course. Some others must remain judged by humanoids, like the one where functions are pulled up to higher abstraction layers. Maybe you could shine your light on what we can automate? i.e. can pyflakes be added to a target? -Original Message- From: Gaurav Aradhye [mailto:gaurav.arad...@clogeny.com] Sent: 18 March 2015 07:16 To: dev@cloudstack.apache.org Subject: Guidelines for test developers Hello all, Last year after improving Marvin framework, we have been continuously spending time in improving old test cases which are written in old style or they don't abide to certain guidelines, also which don't use new functions available in marvin. Many times a test developer who is adding test case for the first time or feature developers adding Basic Validation Tests (BVTs) tend to copy paste the code available in certain test case and try to modify it according to feature and commit it. This adds to inconsistencies. As and when I touch a file for fixing an issue or adding/editing it, I try to incorporate below guidelines and improve the existing code. But still few test files are not up to the mark. Our final goal is to have good code in every file.So writing this mail to consolidate few rules that should be known/considered by everyone adding tests to Marvin. Also, if you touch a file, feel free to remove any inconsistencies that are already present in the file. *1. Import * should always be avoided*. When I started two years back, and tried to understand the code flow/ test cases, I could not easily understand from where the particular module is imported. The imports must be specific. When the imports are specific, it eliminates the possibility of test case failure due to invalid import when specific import is removed from dependent module. E.g. If your test case has following import. from A import * And it uses time module which is not imported explicitly in test case and comes from module A. Then the test case will start failing when import timeis removed from module A. You certainly don't want this to happen. *2. Maintaining Pep8 standards for python code.* The code is read more often that it is written. Pep8 standards improve the readability of the code making it consistent in style. There is a tool named *autopep8* which you can install with pip install and then you can run following command on your test file. autopep8 -i -a -a testFile.py This will make the file pep8 consistent and will also remove the white spaces. But some issues need human intervention and can't be fixed with tool. For fixing those, check the pep8 issues with pep8 testFile.py and fix manually. *3. Keep only imports which are used* in the test suite and remove unwanted imports. *4. Keep all the configuration parameters* (such as data which is passed to API while creating Network offering, Service offering, account etc...) *in tools/marvin/marvin/config/test_data.py file*. Don't include them in test suite itself. Many of the dictionaries are reusable and if you are adding a new test, there are only a few dictionaries you will have to add in the file. If any of the data contains URLs or any data which should be changed according to setup/env, then include the dict in *configurableData* section in test_data.py file. This makes it easier to identify which data needs to be dynamic according to the setup and which data doesn't need to be touched when env is changed. *5. Before committing a test case, run it* with the latest branch against which you are adding the test case and attach the results in Pull Request. If in case change is very small, and doesn't need to be run, then at least check syntactical errors with python command and also with the help of tools such as pyflakes. 6. If you add a new function in your test case and you think it can be used in future
Re: Review Request 30821: CLOUDSTACK-8236: Automation test cases for storage migration test path
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30821/#review76043 --- test/integration/testpaths/testpath_storage_migration.py https://reviews.apache.org/r/30821/#comment123424 fix the license text test/integration/testpaths/testpath_storage_migration.py https://reviews.apache.org/r/30821/#comment123693 on Vmware zwps and cwps can not exist at the same time. Please change the comment. test/integration/testpaths/testpath_storage_migration.py https://reviews.apache.org/r/30821/#comment123694 good to check self.hypervisor.lower() correct all other instances - SrikanteswaraRao Talluri On March 2, 2015, 9:12 a.m., Ashutosh Kelkar wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30821/ --- (Updated March 2, 2015, 9:12 a.m.) Review request for cloudstack and SrikanteswaraRao Talluri. Bugs: CLOUDSTACK-8236 https://issues.apache.org/jira/browse/CLOUDSTACK-8236 Repository: cloudstack-git Description --- Test cases for Storage Migration test path. Diffs - test/integration/testpaths/testpath_storage_migration.py PRE-CREATION tools/marvin/marvin/codes.py a7e8ec8 tools/marvin/marvin/config/test_data.py 80e0abd tools/marvin/marvin/lib/base.py 7443373 Diff: https://reviews.apache.org/r/30821/diff/ Testing --- Live migrate scenario log on Xen. Test migrate Volume (root and data disk) ... === TestName: test_01_migrate_root_and_data_disk_live | Status : SUCCESS === ok -- Ran 1 test in 529.320s OK Thanks, Ashutosh Kelkar
Re: Review Request 31482: CLOUDSTACK-8286: Adding Basic validation test case to test deploying VM from ISO and correcting old regression test case to test HA VM from ISO
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31482/#review76211 --- d8bb1fad5ed1f2d31f38c632b436eb96f3930b3d master - SrikanteswaraRao Talluri On Feb. 27, 2015, 4:49 a.m., Gaurav Aradhye wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31482/ --- (Updated Feb. 27, 2015, 4:49 a.m.) Review request for cloudstack and SrikanteswaraRao Talluri. Bugs: CLOUDSTACK-8286 https://issues.apache.org/jira/browse/CLOUDSTACK-8286 Repository: cloudstack-git Description --- Corrected regression test case to deploy HA VM from ISO, and also added a new BVT to test basic VM deplopyment from ISO. ISO URL modified in test_data.py Diffs - test/integration/component/test_stopped_vm.py 92822c3 test/integration/smoke/test_deploy_vm_iso.py PRE-CREATION tools/marvin/marvin/config/test_data.py 80e0abd Diff: https://reviews.apache.org/r/31482/diff/ Testing --- Test Deploy HA enabled Virtual Machine from ISO ... === TestName: test_02_deploy_ha_vm_from_iso | Status : SUCCESS === ok -- Ran 1 test in 3108.763s OK Thanks, Gaurav Aradhye
Re: Review Request 31482: CLOUDSTACK-8286: Adding Basic validation test case to test deploying VM from ISO and correcting old regression test case to test HA VM from ISO
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31482/#review76212 --- Ship it! Ship It! - SrikanteswaraRao Talluri On Feb. 27, 2015, 4:49 a.m., Gaurav Aradhye wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31482/ --- (Updated Feb. 27, 2015, 4:49 a.m.) Review request for cloudstack and SrikanteswaraRao Talluri. Bugs: CLOUDSTACK-8286 https://issues.apache.org/jira/browse/CLOUDSTACK-8286 Repository: cloudstack-git Description --- Corrected regression test case to deploy HA VM from ISO, and also added a new BVT to test basic VM deplopyment from ISO. ISO URL modified in test_data.py Diffs - test/integration/component/test_stopped_vm.py 92822c3 test/integration/smoke/test_deploy_vm_iso.py PRE-CREATION tools/marvin/marvin/config/test_data.py 80e0abd Diff: https://reviews.apache.org/r/31482/diff/ Testing --- Test Deploy HA enabled Virtual Machine from ISO ... === TestName: test_02_deploy_ha_vm_from_iso | Status : SUCCESS === ok -- Ran 1 test in 3108.763s OK Thanks, Gaurav Aradhye
Re: Review Request 31526: CLOUDSTACK-8290: Adding BVT to verify public IP data is removed from router once network rule is deleted.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31526/#review76215 --- Ship it! ff9ab5caa96f4b3cac9eabf08034ce40c4b389be master - SrikanteswaraRao Talluri On March 12, 2015, 5:46 a.m., Gaurav Aradhye wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31526/ --- (Updated March 12, 2015, 5:46 a.m.) Review request for cloudstack, Jayapal Reddy and SrikanteswaraRao Talluri. Bugs: CLOUDSTACK-8290 https://issues.apache.org/jira/browse/CLOUDSTACK-8290 Repository: cloudstack-git Description --- Steps that should be added to verify absence of the defect. 1. Create a VM in an isolated network 2. Acquire a public IP in the network 3. Enable static NAT rule / LB rule / NAT rule for the IP 4. Check we are able to SSH to VM 5. Check the ip addr command output on VR, the rules should be present on VR for the public IP 6. Disable static NAT / Delete NAT/ LB Rule or disassociate public IP 7. Check SSH to VM, it should fail 8. Check the ip addr command output on VR, the rules should now not be present on VR for the public IP Diffs - test/integration/smoke/test_network.py cca1803 tools/marvin/marvin/codes.py a7e8ec8 Diff: https://reviews.apache.org/r/31526/diff/ Testing --- Test for Static NAT rule for acquired public IP ... === TestName: test_network_rules_acquired_public_ip_1_static_nat_rule | Status : SUCCESS === ok Test for Static NAT rule for acquired public IP ... === TestName: test_network_rules_acquired_public_ip_2_nat_rule | Status : SUCCESS === ok Test for Static NAT rule for acquired public IP ... === TestName: test_network_rules_acquired_public_ip_3_Load_Balancer_Rule | Status : SUCCESS === ok -- Ran 3 tests in 409.871s OK Thanks, Gaurav Aradhye
Re: [ANNOUNCE] New committer: Harikrishna Patnala
Congrats Hari!! Well deserved. ~Talluri On 10/03/15 11:00 am, Rajani Karuturi raj...@apache.org wrote: The Project Management Committee (PMC) for Apache CloudStack has asked Harikrishna Patnala to become a committer and we are pleased to announce that he has accepted. Being a committer allows many contributors to contribute more autonomously. For developers, it makes it easier to submit changes and eliminates the need to have contributions reviewed via the patch submission process. Whether contributions are development-related or otherwise, it is a recognition of a contributor's participation in the project and commitment to the project and the Apache Way. Please join me in congratulating Hari. https://github.com/apache/cloudstack/commits/master?author=harikrishna-pat nala Keep them coming. :) -- on behalf of the CloudStack PMC, ~Rajani
Re: Review Request 31296: CLOUDSTACK-8277: Code improvement - test_multiple_ip_ranges.py, test_shared_networks.py
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31296/#review74235 --- Ship it! f39319932576804eaafb9e51235290fdf23f3841 master - SrikanteswaraRao Talluri On Feb. 23, 2015, 8:57 a.m., Gaurav Aradhye wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31296/ --- (Updated Feb. 23, 2015, 8:57 a.m.) Review request for cloudstack and sanjeev n. Bugs: CLOUDSTACK-8277 https://issues.apache.org/jira/browse/CLOUDSTACK-8277 Repository: cloudstack-git Description --- The test suites require following code improvements. 1. Remove import *, and replace with specific imports 2. Fix pep8 issues. 3. Remove unnecessary try catch blocks 4. Print detailed exception message whenever missing Above changes included in the patch. Diffs - test/integration/component/test_multiple_ips_per_nic.py 58aac9f test/integration/component/test_shared_networks.py 4d71ed3 Diff: https://reviews.apache.org/r/31296/diff/ Testing --- Yes. Add secondary IP to NIC of a VM ... === TestName: test_add_ip_to_nic_1_SHARED | Status : SUCCESS === ok Test listing nics associated with the ip address ... === TestName: test_list_nics_1_SHARED | Status : SUCCESS === ok Test basic operations using non root admin apii client ... === TestName: test_operations_non_root_admin_api_client_1_SHARED | Status : SUCCESS === ok Remove invalid ip ... === TestName: test_remove_invalid_ip | Status : SUCCESS === ok Add secondary IP to NIC of a VM ... === TestName: test_delete_PF_nat_rule_1_ISOLATED | Status : SUCCESS === ok Add secondary IP to NIC of a VM ... === TestName: test_delete_PF_nat_rule_2_SHARED | Status : SUCCESS === ok Add secondary IP to NIC of a VM ... === TestName: test_delete_PF_nat_rule_3_VPC | Status : SUCCESS === ok Add secondary IP to NIC of a VM ... === TestName: test_disable_static_nat_1_ISOLATED | Status : SUCCESS === ok Add secondary IP to NIC of a VM ... === TestName: test_disable_static_nat_2_SHARED | Status : SUCCESS === ok Add secondary IP to NIC of a VM ... === TestName: test_disable_static_nat_3_VPC | Status : SUCCESS === ok Add secondary IP to NIC of a VM ... === TestName: test_disassociate_ip_mapped_to_secondary_ip_through_PF_rule_1_ISOLATED | Status : SUCCESS === ok Add secondary IP to NIC of a VM ... === TestName: test_disassociate_ip_mapped_to_secondary_ip_through_PF_rule_2_SHARED | Status : SUCCESS === ok Add secondary IP to NIC of a VM ... === TestName: test_disassociate_ip_mapped_to_secondary_ip_through_PF_rule_3_VPC | Status : SUCCESS === ok Test Shared Network ALL ... -- Ran 1 test in 570.117s OK Thanks, Gaurav Aradhye
Re: Review Request 31295: CLOUDSTACK-8276: Changes in Marvin to find free vlan in a setup when vlan is not returned for an existing network with listNetworks API
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31295/#review74236 --- Ship it! 429abe2bd53147381f3be1d1eae37cef7f5894cc marvin - SrikanteswaraRao Talluri On Feb. 23, 2015, 8:39 a.m., Gaurav Aradhye wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31295/ --- (Updated Feb. 23, 2015, 8:39 a.m.) Review request for cloudstack and sanjeev n. Bugs: CLOUDSTACK-8276 https://issues.apache.org/jira/browse/CLOUDSTACK-8276 Repository: cloudstack-git Description --- listNetworks API previously returned the value for vlan as untagged when vlan was not assigned to a network. Now the vlan attribute itself is not returned in this case. In this case, vlan attribute value by default will be None. Added the extra check in common function. Diffs - tools/marvin/marvin/lib/common.py c59cf10 Diff: https://reviews.apache.org/r/31295/diff/ Testing --- Add secondary IP to NIC of a VM ... === TestName: test_delete_PF_nat_rule_1_ISOLATED | Status : SUCCESS === ok Add secondary IP to NIC of a VM ... === TestName: test_delete_PF_nat_rule_2_SHARED | Status : SUCCESS === ok Add secondary IP to NIC of a VM ... === TestName: test_delete_PF_nat_rule_3_VPC | Status : SUCCESS === ok Add secondary IP to NIC of a VM ... === TestName: test_disable_static_nat_1_ISOLATED | Status : SUCCESS === ok Add secondary IP to NIC of a VM ... === TestName: test_disable_static_nat_2_SHARED | Status : SUCCESS === ok Add secondary IP to NIC of a VM ... === TestName: test_disable_static_nat_3_VPC | Status : SUCCESS === ok Add secondary IP to NIC of a VM ... === TestName: test_disassociate_ip_mapped_to_secondary_ip_through_PF_rule_1_ISOLATED | Status : SUCCESS === ok Add secondary IP to NIC of a VM ... === TestName: test_disassociate_ip_mapped_to_secondary_ip_through_PF_rule_2_SHARED | Status : SUCCESS === ok Add secondary IP to NIC of a VM ... === TestName: test_disassociate_ip_mapped_to_secondary_ip_through_PF_rule_3_VPC | Status : SUCCESS === ok Test Shared Network ALL ... -- Ran 1 test in 570.117s OK Thanks, Gaurav Aradhye
Re: Review Request 25885: CLOUDSTACK-7594: Adding automation test cases for Stopped VM test path
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25885/#review73275 --- Ship it! 04409609336f3aee1bc91c875dd3c3badcc71ae5 master - SrikanteswaraRao Talluri On Feb. 16, 2015, 5:16 a.m., Ashutosh Kelkar wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25885/ --- (Updated Feb. 16, 2015, 5:16 a.m.) Review request for cloudstack, suresh sadhu and SrikanteswaraRao Talluri. Bugs: CLOUDSTACK-7594 https://issues.apache.org/jira/browse/CLOUDSTACK-7594 Repository: cloudstack-git Description --- Automation test cases for Stopped VM test path. Diffs - test/integration/testpaths/testpath_stopped_vm.py PRE-CREATION Diff: https://reviews.apache.org/r/25885/diff/ Testing --- Yes. Advanced zone: Positive test for stopped VM test path - T1 ... === TestName: test_01_pt_deploy_vm_without_startvm | Status : SUCCESS === ok Positive test for stopped VM test path - T1 variant ... === TestName: test_02_pt_deploy_vm_with_startvm_true | Status : SUCCESS === ok Positive test for stopped VM test path - T2 ... === TestName: test_03_pt_deploy_vm_with_startvm_false | Status : SUCCESS === ok Positive test for stopped VM test path - T3 and variant, T9 ... === TestName: test_04_pt_startvm_false_attach_disk | Status : SUCCESS === ok Positive test for stopped VM test path - T4 ... === TestName: test_05_pt_startvm_false_attach_disk_change_SO | Status : SUCCESS === ok Positive test for stopped VM test path - T5 ... === TestName: test_06_pt_startvm_false_attach_iso | Status : SUCCESS === ok Positive test for stopped VM test path - T5 variant ... === TestName: test_07_pt_startvm_false_attach_iso_running_vm | Status : SUCCESS === ok Positive test for stopped VM test path - T10 ... === TestName: test_08_pt_startvm_false_password_enabled_template | Status : SUCCESS === ok Positive test for stopped VM test path - T11 ... === TestName: test_09_pt_destroy_stopped_vm | Status : SUCCESS === ok Positive test for stopped VM test path - T12 ... === TestName: test_10_max_account_limit | Status : SUCCESS === ok Basic zone: Positive test for stopped VM test path - T1 ... === TestName: test_01_pt_deploy_vm_without_startvm | Status : SUCCESS === ok Positive test for stopped VM test path - T1 variant ... === TestName: test_02_pt_deploy_vm_with_startvm_true | Status : SUCCESS === ok Positive test for stopped VM test path - T2 ... === TestName: test_03_pt_deploy_vm_with_startvm_false | Status : SUCCESS === ok Positive test for stopped VM test path - T3 and variant, T9 ... === TestName: test_04_pt_startvm_false_attach_disk | Status : SUCCESS === ok Positive test for stopped VM test path - T4 ... === TestName: test_05_pt_startvm_false_attach_disk_change_SO | Status : SUCCESS === ok Positive test for stopped VM test path - T5 ... === TestName: test_06_pt_startvm_false_attach_iso | Status : SUCCESS === ok Positive test for stopped VM test path - T5 variant ... === TestName: test_07_pt_startvm_false_attach_iso_running_vm | Status : SUCCESS === ok Positive test for stopped VM test path - T10 ... === TestName: test_08_pt_startvm_false_password_enabled_template | Status : SUCCESS === ok Positive test for stopped VM test path - T11 ... === TestName: test_09_pt_destroy_stopped_vm | Status : SUCCESS === ok Positive test for stopped VM test path - T12 ... === TestName: test_10_max_account_limit | Status : SUCCESS === ok -- Ran 10 tests in 2792.968s OK Thanks, Ashutosh Kelkar
Re: Review Request 31180: CLOUDSTACK-8269: Code changes in primary storage test cases as per recent change in product behavior
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31180/#review73274 --- Ship it! 53bae00801235c104f73a56501ff417209154546 master - SrikanteswaraRao Talluri On Feb. 19, 2015, 9:05 a.m., Gaurav Aradhye wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31180/ --- (Updated Feb. 19, 2015, 9:05 a.m.) Review request for cloudstack and SrikanteswaraRao Talluri. Bugs: CLOUDSTACK-8269 https://issues.apache.org/jira/browse/CLOUDSTACK-8269 Repository: cloudstack-git Description --- 1. Earlier volume would get deleted when vm is deleted, now the volume does not get deleted and it remains in detached state unless account is removed. This volume gets counted in primary storage count of the account. 2. Earlier when volume was detached from VM, the primary storage count of the account would get reduced by the volume size. Now the primary storage count does not get reduced unless the volume is deleted. The patch contains appropriate changes in the test cases as per changed behavior in product as stated above. Diffs - test/integration/component/test_ps_domain_limits.py d9c1018 test/integration/component/test_ps_limits.py c9a754b Diff: https://reviews.apache.org/r/31180/diff/ Testing --- Test primary storage limit of domain and its sub-domains ... === TestName: test_01_multiple_domains_primary_storage_limits | Status : SUCCESS === ok Test primary storage counts in multiple child domains ... === TestName: test_02_multiple_domains_primary_storage_limits | Status : SUCCESS === ok Test primary storage counts in multiple child domains ... === TestName: test_03_multiple_domains_multiple_volumes | Status : SUCCESS === ok Test create snapshot and templates from volume ... === TestName: test_04_create_template_snapshot | Status : SUCCESS === ok Test assign virtual machine to account belonging to different domain ... === TestName: test_05_assign_virtual_machine_different_domain | Status : SUCCESS === ok Test primary storage counts while destroying and recovering VM ... === TestName: test_06_destroy_recover_vm | Status : SUCCESS === ok -- Ran 6 tests in 1619.606s OK Test Deploy multiple VMs with verify the usage ... === TestName: test_deploy_multiple_vm_1_root_domain_admin | Status : SUCCESS === ok Test Deploy multiple VMs with verify the usage ... === TestName: test_deploy_multiple_vm_2_child_domain_admin | Status : SUCCESS === ok -- Ran 2 tests in 399.904s OK Thanks, Gaurav Aradhye
Re: Review Request 31181: CLOUDSTACK-8268: Code improvement - test_stopped_vm.py
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31181/#review73276 --- Ship it! ba08229ff9a8246eddfc9e373dd4efdf35268013 master - SrikanteswaraRao Talluri On Feb. 20, 2015, 6:32 a.m., Gaurav Aradhye wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31181/ --- (Updated Feb. 20, 2015, 6:32 a.m.) Review request for cloudstack and SrikanteswaraRao Talluri. Bugs: CLOUDSTACK-8268 https://issues.apache.org/jira/browse/CLOUDSTACK-8268 Repository: cloudstack-git Description --- 1. Read all the test data from test_data.py 2. Remove hard coded test data (Services class) from the test suite 3. Fix autopep8 issues 4. Move bootableVolume to configurableData section and make relevant changes in test case to read the data according to hypervisor Diffs - test/integration/component/test_stopped_vm.py 1cefc07 tools/marvin/marvin/config/test_data.py e8365ed Diff: https://reviews.apache.org/r/31181/diff/ Testing --- Test Deploy HA enabled Virtual Machine with startvm=false ... === TestName: test_01_deploy_ha_vm_startvm_false | Status : SUCCESS === ok Test Deploy HA enabled Virtual Machine from ISO ... SKIP: Bootable Iso URL not present in test data for xenserver Test Deploy HA enabled Virtual Machine from ISO with startvm=false ... === TestName: test_03_deploy_ha_vm_iso_startvm_false | Status : SUCCESS === ok Test deploy VM on specific host ... === TestName: test_deployVmOnGivenHost | Status : SUCCESS === ok Test Deploy Virtual Machine with no startVM parameter ... === TestName: test_01_deploy_vm_no_startvm | Status : SUCCESS === ok Test Deploy Virtual Machine with startVM=true parameter ... === TestName: test_02_deploy_vm_startvm_true | Status : SUCCESS === ok Test Deploy Virtual Machine with startVM=false parameter ... === TestName: test_03_deploy_vm_startvm_false | Status : SUCCESS === ok Test Deploy Virtual Machine with startVM=false and attach volume ... === TestName: test_04_deploy_startvm_false_attach_volume | Status : SUCCESS === ok Test Deploy Virtual Machine with startVM=false and change service offering ... === TestName: test_05_deploy_startvm_false_change_so | Status : SUCCESS === ok Test Deploy Virtual Machine with startVM=false and ... === TestName: test_06_deploy_startvm_attach_detach | Status : SUCCESS === ok Test Deploy Virtual Machine with startVM=false and attach ISO ... === TestName: test_07_deploy_startvm_attach_iso | Status : SUCCESS === ok Test Deploy Virtual Machine with startVM=false and attach volume already attached to different machine ... === TestName: test_08_deploy_attached_volume | Status : SUCCESS === ok Test Stopped Virtual Machine's ROOT volume migration ... SKIP: No cluster with more than one primary storage pool to perform migrate volume test Test Deploy Virtual Machine with startVM=false enabledpassword in ... === TestName: test_deploy_vm_password_enabled | Status : SUCCESS === ok Test Deploy Virtual Machine with no startVM parameter ... === TestName: test_01_deploy_vm_no_startvm | Status : SUCCESS === ok Test Upload volume and attach to VM in stopped state ... === TestName: test_upload_attach_volume | Status : SUCCESS === ok Test VM limit per account ... === TestName: test_vm_per_account | Status : SUCCESS === ok -- Ran 17 tests in 1834.202s OK (SKIP=2) Thanks, Gaurav Aradhye
Re: Review Request 31155: CLOUDSTACK-8264: Adding missing change in test_data.py caused due to commit 500baea9b6c816caae93ab2f8d0ba31f99c3f8fc
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31155/#review73116 --- Ship it! 7629000ffe96afdbe83d268e9be38b7fdb2ba300 master - SrikanteswaraRao Talluri On Feb. 18, 2015, 11:54 a.m., Gaurav Aradhye wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31155/ --- (Updated Feb. 18, 2015, 11:54 a.m.) Review request for cloudstack and SrikanteswaraRao Talluri. Bugs: CLOUDSTACK-8264 https://issues.apache.org/jira/browse/CLOUDSTACK-8264 Repository: cloudstack-git Description --- Adding missing change in test_data.py caused due to commit 500baea9b6c816caae93ab2f8d0ba31f99c3f8fc Diffs - tools/marvin/marvin/config/test_data.py f8cadf5 Diff: https://reviews.apache.org/r/31155/diff/ Testing --- N/A Thanks, Gaurav Aradhye
Re: Review Request 31108: CLOUDSTACK-8261: test_haproxy.py - Remove the code checking AppCookle and LbCookie Stickiness policies
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31108/#review72706 --- Ship it! e768d702cb4edbf544805de6bb79854c5c55289a master - SrikanteswaraRao Talluri On Feb. 17, 2015, 11:56 a.m., Gaurav Aradhye wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31108/ --- (Updated Feb. 17, 2015, 11:56 a.m.) Review request for cloudstack and SrikanteswaraRao Talluri. Bugs: CLOUDSTACK-8261 https://issues.apache.org/jira/browse/CLOUDSTACK-8261 Repository: cloudstack-git Description --- The code checks the AppCookie and LbCookie Stickiness policies by doing SSH to VM. This is wrong because these policies are for HTTP requests. Removing the wrong code. We need to device a way to verify these policies through test case. Added TODO comments for these. Will address them in separate patch. Diffs - test/integration/component/test_haproxy.py 73257e6 Diff: https://reviews.apache.org/r/31108/diff/ Testing --- Test Configure stickiness policies with default values ... === TestName: test_01_create_sticky_policy_default_values | Status : SUCCESS === ok Test Configure stickiness policies with custom values ... === TestName: test_02_create_sticky_policy_custom_values | Status : SUCCESS === ok Test listnetworks response to check supported stickiness policies ... === TestName: test_03_supported_policies_by_network | Status : SUCCESS === ok Test LB rule before/after stickiness policy creation ... === TestName: test_04_delete_lb_rule | Status : SUCCESS === ok Test error/alerts after creating stickiness policy ... === TestName: test_05_error_alerts_after_create | Status : SUCCESS === ok Test release public IP with stickiness policy ... === TestName: test_06_release_ip | Status : SUCCESS === ok Test Delete account and check the router and its rules ... === TestName: test_07_delete_account | Status : SUCCESS === ok Test verify create stickiness policy when router is stopped state ... === TestName: test_08_create_policy_router_stopped | Status : SUCCESS === ok Test check the stickiness policy rules after destroying router ... === TestName: test_09_create_policy_router_destroy | Status : SUCCESS === ok Test enable/disable the VPN after applying sticky policy rules ... === TestName: test_10_create_policy_enable_disable_vpn | Status : SUCCESS === ok Test verfify functionality syncronous and asyncronous validations ... === TestName: test_11_invalid_params | Status : SUCCESS === ok -- Ran 11 tests in 3133.053s OK Thanks, Gaurav Aradhye
Re: Review Request 31105: CLOUDSTACK-8259: test_routers.py - Code improvement
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31105/#review72705 --- Ship it! 8bfda973c2d22b075c51fc6a055017b5796dd88b master - SrikanteswaraRao Talluri On Feb. 17, 2015, 8:02 a.m., Gaurav Aradhye wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31105/ --- (Updated Feb. 17, 2015, 8:02 a.m.) Review request for cloudstack and SrikanteswaraRao Talluri. Bugs: CLOUDSTACK-8259 https://issues.apache.org/jira/browse/CLOUDSTACK-8259 Repository: cloudstack-git Description --- 1. Read all the test data from test_data.py, removed services dict from test case 2. Read host credentials from configurableData section Additional change: Increased the memory and cpu for default service offering from 128 to 256 to avoid SSH failures. Diffs - test/integration/component/test_routers.py 0a74234 tools/marvin/marvin/config/test_data.py e3645a7 Diff: https://reviews.apache.org/r/31105/diff/ Testing --- Yes. All test cases passed. Thanks, Gaurav Aradhye
Re: Review Request 31081: CLOUDSTACK-8257: test_iso.py - Removed assertion on Iso name when random character s are appended to test data before creating Iso
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31081/#review72700 --- Ship it! 973458219734ead34253b1bf8f2b0bd29dd1b152 master - SrikanteswaraRao Talluri On Feb. 16, 2015, 12:07 p.m., Gaurav Aradhye wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31081/ --- (Updated Feb. 16, 2015, 12:07 p.m.) Review request for cloudstack and SrikanteswaraRao Talluri. Bugs: CLOUDSTACK-8258 https://issues.apache.org/jira/browse/CLOUDSTACK-8258 Repository: cloudstack-git Description --- Create method in Class Iso in base library now appends random characters (6) to the Iso name passed from test data so that each Iso created through test case has different name. Hence assertios based on Iso name should be removed from test case as they won't hold true anymore (Iso name will not match with that passed through the test data). Other changes: 1. Pep8 fixes 2. Import fixes 3. Removing white-spaces 4. Removing unused variables Diffs - test/integration/smoke/test_iso.py 4bd66b5 Diff: https://reviews.apache.org/r/31081/diff/ Testing --- Yes. One test case failed in downloading Iso due to DNS issue in the setup. Otherwise should pass. The test case which failed in BVT build passed in my testing. Thanks, Gaurav Aradhye
Re: Review Request 31078: CLOUDSTACK-8257: test_escalations_volume.py - Removing asserts on volumes names as they don't hold true when random cha racters are appended to the volume name before creatio
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31078/#review72701 --- Ship it! a95ce8138adc8b0f51e90d6e4c5487d48be81085 master - SrikanteswaraRao Talluri On Feb. 16, 2015, 7:53 a.m., Gaurav Aradhye wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31078/ --- (Updated Feb. 16, 2015, 7:53 a.m.) Review request for cloudstack, sanjeev n and SrikanteswaraRao Talluri. Bugs: CLOUDSTACK-8257 https://issues.apache.org/jira/browse/CLOUDSTACK-8257 Repository: cloudstack-git Description --- Test_escalations_volume.py has two test cases which assert the created volume name with the name passed through test data. However this won't hold true when random characters are appended to the volume before its creation. There is no need of such assert as we are already checking the API response is not None. Removed the unnecessary asserts. Diffs - test/integration/component/test_escalations_volumes.py d650121 Diff: https://reviews.apache.org/r/31078/diff/ Testing --- Did not run these. Should run fine. Thanks, Gaurav Aradhye
Re: Review Request 19195: Automation of CCP Objects Verification after external changes made to the original setup
On Feb. 13, 2015, 6:42 a.m., SrikanteswaraRao Talluri wrote: pushed to master 7461297f3e17b431643e7a8c575e799d0e151261 reverted this from master as this is not tested and causing other tests to fail. Please resubmit a fresh patch for master. - SrikanteswaraRao --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19195/#review72329 --- On March 14, 2014, 12:33 a.m., Chandan Purushothama wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19195/ --- (Updated March 14, 2014, 12:33 a.m.) Review request for cloudstack, Girish Shilamkar, Raja Pullela, sanjeev n, Santhosh Edukulla, and SrikanteswaraRao Talluri. Repository: cloudstack-git Description --- Purpose of this code: Generate CCP Objects (VMs, Volumes, Snapshots, VPC, etc..) and CCP Use Cases (Networking, Data Content,etc) before an external action on the CCP Setup and verify the integrity of the CCP Objects and the Use Cases after the external action on the CCP Setup. The integrity of the CCP Objects is verified by performing operations that test the Usability of the objects. This validates the intactness of the setup after an external action. The submitted patch covers only few major use cases. It proves that similar code can be added in future to address similar goals in verifying the integrity of CCP objects belonging to different components of the product. The code format can be followed to verify validity of real time business use cases while any code changes (CCP,hypervisor,external devices code, etc…) happen over a period of time. The following are the scenarios that the code format can be used for: 1.Upgrade Validity Verification a. CCP Upgrade b. Hypervisors Upgrade c. External Devices Upgrade d. System VM Template Changes. 2.Patch Validity Verification Code can be used as one of the primary Components to validity Upgrades. It will facilitate the automation of Upgrade Test Verification completely. How to use the code: *Kindly make the corresponding substitutions in the commands listed below. Execute: nosetests --with-marvin --marvin-config=$CONFIG $BASEDIR/integration/component/ test_minimal_ug_check.py --load -a tags=preupgrade After Upgrade or any Changes done to the Setup, Verify that the existing CCP objects are not affected due to the external changes. Execute: nosetests --with-marvin --marvin-config=$CONFIG $BASEDIR/integration/component/ test_minimal_ug_check.py --load -a tags=postupgrade Diffs - test/integration/component/test_minimal_ug_check.py PRE-CREATION Diff: https://reviews.apache.org/r/19195/diff/ Testing --- PreUpgrade Output: Test case no : Enable VPN for Public IP Address on the VPC ... ok-- Will fix the description in the next patch -- Ran 1 test in 1683.515s OK Post Upgrade Output: Test case no : Remote a VPN User ... ok -- Will fix the description in the next patch -- Ran 1 test in 1269.134s OK Thanks, Chandan Purushothama
Re: Review Request 28030: CLOUDSTACK-7911: Automation test cases for Usage test path
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28030/#review72352 --- Ship it! ada8cdce7009e41ddf37348cfac2d4f79592379e master - SrikanteswaraRao Talluri On Feb. 11, 2015, 9:30 a.m., Ashutosh Kelkar wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28030/ --- (Updated Feb. 11, 2015, 9:30 a.m.) Review request for cloudstack and SrikanteswaraRao Talluri. Bugs: CLOUDSTACK-7911 https://issues.apache.org/jira/browse/CLOUDSTACK-7911 Repository: cloudstack-git Description --- Automation test cases for Usage test path. More test cases to follow. This is first patch. Diffs - test/integration/testpaths/testpath_usage.py PRE-CREATION tools/marvin/marvin/config/test_data.py d5ed353 tools/marvin/marvin/dbConnection.py 66c6cb1 tools/marvin/marvin/lib/base.py e38c394 tools/marvin/marvin/lib/utils.py 8788b3b Diff: https://reviews.apache.org/r/28030/diff/ Testing --- Yes. Thanks, Ashutosh Kelkar
Re: Review Request 30967: CLOUDSTACK-8253: Code correction and improvement: test_haproxy.py
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30967/#review72335 --- Ship it! d849a66b47e81e9da234af0ba376327d626462dc master - SrikanteswaraRao Talluri On Feb. 13, 2015, 6:17 a.m., Gaurav Aradhye wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30967/ --- (Updated Feb. 13, 2015, 6:17 a.m.) Review request for cloudstack and SrikanteswaraRao Talluri. Bugs: CLOUDSTACK-8253 https://issues.apache.org/jira/browse/CLOUDSTACK-8253 Repository: cloudstack-git Description --- test_haproxy.py is using the config data included in the test file itself, however it should consume the data from test_data.py file. Also the code is testing LB rule stickiness policies but there is an extra NAT rule present for the same IP addresses which prevents the test case from testing the Stickiness policies alone. Diffs - test/integration/component/test_haproxy.py e941e5b Diff: https://reviews.apache.org/r/30967/diff/ Testing --- Currently failing for Stickiness policies AppCookie and LbCookie. Thanks, Gaurav Aradhye
Re: Review Request 30661: LDAP:automation:added missing scenrio and additional checks for better debugging
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30661/#review71956 --- test/integration/component/test_ldap.py https://reviews.apache.org/r/30661/#comment117871 please remove author details - SrikanteswaraRao Talluri On Feb. 5, 2015, 11:10 a.m., suresh sadhu wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30661/ --- (Updated Feb. 5, 2015, 11:10 a.m.) Review request for cloudstack, sanjeev n and SrikanteswaraRao Talluri. Bugs: CLOUDSTACK-8218 https://issues.apache.org/jira/browse/CLOUDSTACK-8218 Repository: cloudstack-git Description --- added missing scenrio and additional checks for better debugging Diffs - test/integration/component/test_ldap.py 3464022 Diff: https://reviews.apache.org/r/30661/diff/ Testing --- Yes Thanks, suresh sadhu
Re: Review Request 30658: CLOUDSTACK-8217: Fixed marvin base library method for passing 'lbdevicecapacity' parameter while adding netscaler device
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30658/#review72340 --- Ship it! 015aed9befcd4f433bebe2f01135456b9688f3c9 master - SrikanteswaraRao Talluri On Feb. 5, 2015, 10:26 a.m., Gaurav Aradhye wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30658/ --- (Updated Feb. 5, 2015, 10:26 a.m.) Review request for cloudstack and SrikanteswaraRao Talluri. Bugs: CLOUDSTACK-8217 https://issues.apache.org/jira/browse/CLOUDSTACK-8217 Repository: cloudstack-git Description --- The code in marvin base library passes the lbdevicecapcity parameter while adding netscaler device only if the key lbdevicededicated is not present in services dict, which is wrong. The value of lbdevicecapacity should be passed to API irrespective of lbdevicededicated key and its value. Diffs - tools/marvin/marvin/lib/base.py e38c394 Diff: https://reviews.apache.org/r/30658/diff/ Testing --- Yes. Thanks, Gaurav Aradhye
Re: Review Request 30793: CLOUDSTACK-8235: Fixed test case in test_bugs.py to read variable data from configurableData section of test_data.py an d also fixed wrong parameter name
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30793/#review72343 --- Ship it! 500baea9b6c816caae93ab2f8d0ba31f99c3f8fc master - SrikanteswaraRao Talluri On Feb. 9, 2015, 11:09 a.m., Gaurav Aradhye wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30793/ --- (Updated Feb. 9, 2015, 11:09 a.m.) Review request for cloudstack and SrikanteswaraRao Talluri. Bugs: CLOUDSTACK-8235 https://issues.apache.org/jira/browse/CLOUDSTACK-8235 Repository: cloudstack-git Description --- Changes: 1. Corrected paramater name podId to podid while adding externally managed cluster in vmware 2. Specified detailed imports 3. Moved the vmware_cluster dict to configurableData section. 4. Pep8 fuixes. Diffs - test/integration/component/maint/test_bugs.py 160cd1d tools/marvin/marvin/config/test_data.py d5ed353 Diff: https://reviews.apache.org/r/30793/diff/ Testing --- Did not test the actual adding cluster scenario. But the Invalid parameter error is gone. Test case needs to be run against proper data (vmware_cluster information). Checked the static errors and imports with pyflakes and python command. Thanks, Gaurav Aradhye
Re: Review Request 30872: CLOUDSTACK-8149: Fixed test_Virtualrouter_alerts, py for Vmware
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30872/#review72337 --- Ship it! eab63a6dd911d3358a1903acf8e510880bfa9ea9 master - SrikanteswaraRao Talluri On Feb. 11, 2015, 9:55 a.m., Gaurav Aradhye wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30872/ --- (Updated Feb. 11, 2015, 9:55 a.m.) Review request for cloudstack and SrikanteswaraRao Talluri. Bugs: CLOUDSTACK-8149 https://issues.apache.org/jira/browse/CLOUDSTACK-8149 Repository: cloudstack-git Description --- The test case failed for vmware because the service dnsmasq was not stopped. Further, the waiting time was hard coded. Fixed above issues. Diffs - test/integration/component/test_VirtualRouter_alerts.py 91a4fcf Diff: https://reviews.apache.org/r/30872/diff/ Testing --- test_01_VRServiceFailureAlerting (test_VirtualRouter_alerts.TestVRServiceFailureAlerting) ... === TestName: test_01_VRServiceFailureAlerting | Status : SUCCESS === ok -- Ran 1 test in 2588.687s OK Thanks, Gaurav Aradhye
Re: Review Request 19195: Automation of CCP Objects Verification after external changes made to the original setup
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19195/#review72329 --- pushed to master 7461297f3e17b431643e7a8c575e799d0e151261 - SrikanteswaraRao Talluri On March 14, 2014, 12:33 a.m., Chandan Purushothama wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19195/ --- (Updated March 14, 2014, 12:33 a.m.) Review request for cloudstack, Girish Shilamkar, Raja Pullela, sanjeev n, Santhosh Edukulla, and SrikanteswaraRao Talluri. Repository: cloudstack-git Description --- Purpose of this code: Generate CCP Objects (VMs, Volumes, Snapshots, VPC, etc..) and CCP Use Cases (Networking, Data Content,etc) before an external action on the CCP Setup and verify the integrity of the CCP Objects and the Use Cases after the external action on the CCP Setup. The integrity of the CCP Objects is verified by performing operations that test the Usability of the objects. This validates the intactness of the setup after an external action. The submitted patch covers only few major use cases. It proves that similar code can be added in future to address similar goals in verifying the integrity of CCP objects belonging to different components of the product. The code format can be followed to verify validity of real time business use cases while any code changes (CCP,hypervisor,external devices code, etc…) happen over a period of time. The following are the scenarios that the code format can be used for: 1.Upgrade Validity Verification a. CCP Upgrade b. Hypervisors Upgrade c. External Devices Upgrade d. System VM Template Changes. 2.Patch Validity Verification Code can be used as one of the primary Components to validity Upgrades. It will facilitate the automation of Upgrade Test Verification completely. How to use the code: *Kindly make the corresponding substitutions in the commands listed below. Execute: nosetests --with-marvin --marvin-config=$CONFIG $BASEDIR/integration/component/ test_minimal_ug_check.py --load -a tags=preupgrade After Upgrade or any Changes done to the Setup, Verify that the existing CCP objects are not affected due to the external changes. Execute: nosetests --with-marvin --marvin-config=$CONFIG $BASEDIR/integration/component/ test_minimal_ug_check.py --load -a tags=postupgrade Diffs - test/integration/component/test_minimal_ug_check.py PRE-CREATION Diff: https://reviews.apache.org/r/19195/diff/ Testing --- PreUpgrade Output: Test case no : Enable VPN for Public IP Address on the VPC ... ok-- Will fix the description in the next patch -- Ran 1 test in 1683.515s OK Post Upgrade Output: Test case no : Remote a VPN User ... ok -- Will fix the description in the next patch -- Ran 1 test in 1269.134s OK Thanks, Chandan Purushothama
Re: Review Request 30661: LDAP:automation:added missing scenrio and additional checks for better debugging
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30661/#review72341 --- test/integration/component/test_ldap.py https://reviews.apache.org/r/30661/#comment118431 It is better to skip the test when there are no required fields. test/integration/component/test_ldap.py https://reviews.apache.org/r/30661/#comment118432 remove this if it is no more required - SrikanteswaraRao Talluri On Feb. 5, 2015, 11:10 a.m., suresh sadhu wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30661/ --- (Updated Feb. 5, 2015, 11:10 a.m.) Review request for cloudstack, sanjeev n and SrikanteswaraRao Talluri. Bugs: CLOUDSTACK-8218 https://issues.apache.org/jira/browse/CLOUDSTACK-8218 Repository: cloudstack-git Description --- added missing scenrio and additional checks for better debugging Diffs - test/integration/component/test_ldap.py 3464022 Diff: https://reviews.apache.org/r/30661/diff/ Testing --- Yes Thanks, suresh sadhu
Re: Review Request 30865: CLOUDSTACK-8240: Skipping test case in test_vmware_drs.py because the scenario is not testable through automation
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30865/#review71955 --- Ship it! ec1c3894f0a2cfdd9b9b96e4e01b6e8bba77af0f master - SrikanteswaraRao Talluri On Feb. 11, 2015, 5:23 a.m., Gaurav Aradhye wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30865/ --- (Updated Feb. 11, 2015, 5:23 a.m.) Review request for cloudstack and SrikanteswaraRao Talluri. Bugs: CLOUDSTACK-8240 https://issues.apache.org/jira/browse/CLOUDSTACK-8240 Repository: cloudstack-git Description --- The test case tries to deploy a VM with memory just below the host capacity (which is normally in many GBs). This goes beyond the account capacity, and also it is not feasible in automation to allocate such huge resources to single account. Hence skipping the test case and marking it as invalid. Diffs - test/integration/component/test_vmware_drs.py 20d3839 Diff: https://reviews.apache.org/r/30865/diff/ Testing --- Tested with python command and pyflakes. Thanks, Gaurav Aradhye
Re: Review Request 30866: CLOUDSTACK-8241: Moved upload volume dict data to configurableData section of the test_data.py file so that data can be changed according to the setup, also made relevant cha
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30866/#review71953 --- Ship it! af09388eda491a529e88ed62fb2c3d62fe554a4d master - SrikanteswaraRao Talluri On Feb. 11, 2015, 5:53 a.m., Gaurav Aradhye wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30866/ --- (Updated Feb. 11, 2015, 5:53 a.m.) Review request for cloudstack and SrikanteswaraRao Talluri. Bugs: CLOUDSTACK-8241 https://issues.apache.org/jira/browse/CLOUDSTACK-8241 Repository: cloudstack-git Description --- The volume upload URL is hard coded right now and should be moved to configurableData section so that appropriate data can be filled before the running the relevant test cases. Diffs - test/integration/component/test_escalations_volumes.py fe9d5e1 test/integration/testpaths/testpath_volumelifecycle.py 6e56697 tools/marvin/marvin/config/test_data.py d5ed353 Diff: https://reviews.apache.org/r/30866/diff/ Testing --- Did not run the test cases. Only the path changes in test cases. Should be tested with correct volume path. Thanks, Gaurav Aradhye
Re: Review Request 30611: Before throwing exception for iso download try one more time
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30611/#review71186 --- Ship it! Ship It! - SrikanteswaraRao Talluri On Feb. 4, 2015, 9:58 a.m., sanjeev n wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30611/ --- (Updated Feb. 4, 2015, 9:58 a.m.) Review request for cloudstack and SrikanteswaraRao Talluri. Repository: cloudstack-git Description --- Before throwing exception for iso download try one more time Diffs - tools/marvin/marvin/lib/base.py e38c394 Diff: https://reviews.apache.org/r/30611/diff/ Testing --- Yes Thanks, sanjeev n
Re: Review Request 30653: CLOUDSTACK-8213: Fixed typo in test_lb_secondary_ip.py
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30653/#review71189 --- Ship it! 82b6c1377b40a14acda7cf9827f0f41f55900166 master - SrikanteswaraRao Talluri On Feb. 5, 2015, 6:46 a.m., Gaurav Aradhye wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30653/ --- (Updated Feb. 5, 2015, 6:46 a.m.) Review request for cloudstack and SrikanteswaraRao Talluri. Bugs: CLOUDSTACK-8213 https://issues.apache.org/jira/browse/CLOUDSTACK-8213 Repository: cloudstack-git Description --- Changed self.secondaryip to secondaryip. It's a local variable. Diffs - test/integration/component/test_lb_secondary_ip.py c76ab2c Diff: https://reviews.apache.org/r/30653/diff/ Testing --- Yes, Thanks, Gaurav Aradhye
Re: Review Request 30075: CLOUDSTACK-8124: Skipping snapshot tests on Hyper-V
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30075/#review71198 --- Ship it! Pushed to master and 4.5 - SrikanteswaraRao Talluri On Jan. 22, 2015, 5:29 a.m., Gaurav Aradhye wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30075/ --- (Updated Jan. 22, 2015, 5:29 a.m.) Review request for cloudstack, sanjeev n and SrikanteswaraRao Talluri. Bugs: CLOUDSTACK-8124 https://issues.apache.org/jira/browse/CLOUDSTACK-8124 Repository: cloudstack-git Description --- Snapshot feature is not supported on hyper-V. Skipping the tests. Diffs - test/integration/component/test_snapshots.py 5b8cdc7 Diff: https://reviews.apache.org/r/30075/diff/ Testing --- Yes. Thanks, Gaurav Aradhye
Re: Review Request 30613: CLOUDSTACK-8211: Correcting expected secondary storage count value by rounding off to floor value and including the physicalsize of snapshot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30613/#review71196 --- Ship it! a4e9b4e8a4e6bdcec8ad1cda0435f8c61589576f master - SrikanteswaraRao Talluri On Feb. 4, 2015, 12:44 p.m., Gaurav Aradhye wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30613/ --- (Updated Feb. 4, 2015, 12:44 p.m.) Review request for cloudstack, Anshul Gangwar and SrikanteswaraRao Talluri. Bugs: CLOUDSTACK-8211 https://issues.apache.org/jira/browse/CLOUDSTACK-8211 Repository: cloudstack-git Description --- The expected secondary storage count needs to rounded off to integer floor. Also the physicalsize of the snapshot needs to be included in the expected count. Diffs - test/integration/component/test_ss_limits.py 8662cd5 Diff: https://reviews.apache.org/r/30613/diff/ Testing --- Test register template ... SKIP: skip Test register template ... SKIP: skip Test create snapshot and templates from volume ... === TestName: test_02_create_template_snapshot_1_root_domain_admin | Status : SUCCESS === ok Test create snapshot and templates from volume ... === TestName: test_02_create_template_snapshot_2_child_domain_admin | Status : SUCCESS === ok Test register iso ... SKIP: skip Test register iso ... SKIP: skip Test copy template between zones ... SKIP: skip Test copy template between zones ... SKIP: skip -- Ran 8 tests in 685.637s OK (SKIP=6) ~ Thanks, Gaurav Aradhye
Re: Review Request 30656: CLOUDSTACK-8214: test_netscaler_nw_off.py - Skip test if enough zones are not present instead of throwing exception
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30656/#review71190 --- Ship it! 8354d4a765b98006192076b8c4ace045c36b0aa4 master - SrikanteswaraRao Talluri On Feb. 5, 2015, 7:29 a.m., Gaurav Aradhye wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30656/ --- (Updated Feb. 5, 2015, 7:29 a.m.) Review request for cloudstack and SrikanteswaraRao Talluri. Bugs: CLOUDSTACK-8214 https://issues.apache.org/jira/browse/CLOUDSTACK-8214 Repository: cloudstack-git Description --- The test case asserts the total number of zones available in the setup and throws exception if the zones are less than 2. Instead skip the test case in this case. Diffs - test/integration/component/test_netscaler_nw_off.py 301c866 Diff: https://reviews.apache.org/r/30656/diff/ Testing --- Yes Thanks, Gaurav Aradhye
Re: Review Request 30555: Minor typo correction in test_deploy_vgpu_vm.py
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30555/#review70734 --- Ship it! Ship It! - SrikanteswaraRao Talluri On Feb. 3, 2015, 10:02 a.m., abhinav roy wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30555/ --- (Updated Feb. 3, 2015, 10:02 a.m.) Review request for cloudstack, sailaja mada, sanjeev n, and SrikanteswaraRao Talluri. Repository: cloudstack-git Description --- Minor typo correction from configurabledata to configurableData in test_deploy_vgpu_vm.py Diffs - test/integration/component/test_deploy_vgpu_vm.py 15ad2d9 Diff: https://reviews.apache.org/r/30555/diff/ Testing --- Tested on my local environment. Thanks, abhinav roy
Re: Review Request 26842: CLOUDSTACK-7745: Fixed the script 'test_ssvm.py' - Private IP of System VMs can change on systemVMs reboot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26842/#review70744 --- Ship it! cfc0e12432163a27c6d3f4f4658c06d27cb18e7d master - SrikanteswaraRao Talluri On Oct. 16, 2014, 11:29 p.m., Chandan Purushothama wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26842/ --- (Updated Oct. 16, 2014, 11:29 p.m.) Review request for cloudstack, edison su, sangeetha hariharan, and SrikanteswaraRao Talluri. Bugs: CLOUDSTACK-7745 https://issues.apache.org/jira/browse/CLOUDSTACK-7745 Repository: cloudstack-git Description --- Test Suite assumes that private ip of SSVM and CPVM cannot change after reboot. Fixing the test suite to allow private ip change. Diffs - test/integration/smoke/test_ssvm.py 5713569 Diff: https://reviews.apache.org/r/26842/diff/ Testing --- No Testing done. Thanks, Chandan Purushothama
Re: Review Request 29847: CLOUDSTACK-8153: Adding global setting value check for few test cases in test_custom_hostname.py
On Feb. 3, 2015, 12:28 p.m., SrikanteswaraRao Talluri wrote: Ship It! dbe9d93ec61948097c4c076bbeb13d30a8b5c44a master - SrikanteswaraRao --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29847/#review70737 --- On Jan. 22, 2015, 10:27 a.m., Ashutosh Kelkar wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29847/ --- (Updated Jan. 22, 2015, 10:27 a.m.) Review request for cloudstack, sanjeev n and SrikanteswaraRao Talluri. Bugs: CLOUDSTACK-8153 https://issues.apache.org/jira/browse/CLOUDSTACK-8153 Repository: cloudstack-git Description --- The test cases need vm.instancename.flag set to be true. Added check for that. Diffs - test/integration/component/test_custom_hostname.py fcd497e Diff: https://reviews.apache.org/r/29847/diff/ Testing --- Yes. Thanks, Ashutosh Kelkar
Re: Review Request 30555: Minor typo correction in test_deploy_vgpu_vm.py
On Feb. 3, 2015, 12:26 p.m., SrikanteswaraRao Talluri wrote: Ship It! f2ea6172386277f644fd4f20bb7f8fb065c30684 master - SrikanteswaraRao --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30555/#review70734 --- On Feb. 3, 2015, 10:02 a.m., abhinav roy wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30555/ --- (Updated Feb. 3, 2015, 10:02 a.m.) Review request for cloudstack, sailaja mada, sanjeev n, and SrikanteswaraRao Talluri. Repository: cloudstack-git Description --- Minor typo correction from configurabledata to configurableData in test_deploy_vgpu_vm.py Diffs - test/integration/component/test_deploy_vgpu_vm.py 15ad2d9 Diff: https://reviews.apache.org/r/30555/diff/ Testing --- Tested on my local environment. Thanks, abhinav roy
Re: Review Request 29847: CLOUDSTACK-8153: Adding global setting value check for few test cases in test_custom_hostname.py
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29847/#review70737 --- Ship it! Ship It! - SrikanteswaraRao Talluri On Jan. 22, 2015, 10:27 a.m., Ashutosh Kelkar wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29847/ --- (Updated Jan. 22, 2015, 10:27 a.m.) Review request for cloudstack, sanjeev n and SrikanteswaraRao Talluri. Bugs: CLOUDSTACK-8153 https://issues.apache.org/jira/browse/CLOUDSTACK-8153 Repository: cloudstack-git Description --- The test cases need vm.instancename.flag set to be true. Added check for that. Diffs - test/integration/component/test_custom_hostname.py fcd497e Diff: https://reviews.apache.org/r/29847/diff/ Testing --- Yes. Thanks, Ashutosh Kelkar
Re: Review Request 30553: A new script to test_hosts and added update modules for few classes in base.py
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30553/#review70726 --- test/integration/component/test_escalations_hosts.py https://reviews.apache.org/r/30553/#comment116088 Isn't this redundant? test/integration/component/test_escalations_hosts.py https://reviews.apache.org/r/30553/#comment116089 you can make use of cls.apiclient here too instead of getting again in cls.api_client test/integration/component/test_escalations_hosts.py https://reviews.apache.org/r/30553/#comment116090 setupClass has the same code to get cls.testdata, you can reuse that here. test/integration/component/test_escalations_hosts.py https://reviews.apache.org/r/30553/#comment116091 If you intend to maintain 'cleanup' list for each test, you need not want to initialize in setupClass() line 56 test/integration/component/test_escalations_hosts.py https://reviews.apache.org/r/30553/#comment116093 I assume that you don't want to have update_host as a test, hence, @attr decorator doesn't make sense here. Please remove that. test/integration/component/test_escalations_hosts.py https://reviews.apache.org/r/30553/#comment116098 you can return SUCCESS or FAILURE based on the state of the resource. test/integration/component/test_escalations_hosts.py https://reviews.apache.org/r/30553/#comment116094 same as above comment test/integration/component/test_escalations_hosts.py https://reviews.apache.org/r/30553/#comment116095 same as above comment test/integration/component/test_escalations_hosts.py https://reviews.apache.org/r/30553/#comment116106 assertEqual and others are used to determine the result of a testcase, hence, it is not appropriate to use them here inside the helper functions. Have a proper return statements for these helper functions and check them inside the test case to determine the expected output of the test. test/integration/component/test_escalations_hosts.py https://reviews.apache.org/r/30553/#comment116096 same as above comment test/integration/component/test_escalations_hosts.py https://reviews.apache.org/r/30553/#comment116097 same as above comment - SrikanteswaraRao Talluri On Feb. 3, 2015, 9:21 a.m., abhinav roy wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30553/ --- (Updated Feb. 3, 2015, 9:21 a.m.) Review request for cloudstack, sanjeev n and SrikanteswaraRao Talluri. Repository: cloudstack-git Description --- This Patch has following changes : 1. A new script to test host status after enabling/disabling of Pods, Clusters, Zones or by managing/unmanaging of clusters etc. 2. update Modules added for Pod, Zone, cluster classes in base.py Diffs - test/integration/component/test_escalations_hosts.py PRE-CREATION tools/marvin/marvin/lib/base.py e38c394 Diff: https://reviews.apache.org/r/30553/diff/ Testing --- Disable the host and it's cluster, ... === TestName: test_01_op_host_capacity_disable_cluster | Status : SUCCESS === ok Disable the host and it's pod, ... === TestName: test_02_op_host_capacity_disable_pod | Status : SUCCESS === ok Disable the host and it's zone, ... === TestName: test_03_op_host_capacity_disable_zone | Status : SUCCESS === ok Disable the host then unmanage the cluster, ... === TestName: test_04_disable_host_unmanage_cluster_check_hosts_status | Status : SUCCESS === ok -- Ran 4 tests in 126.360s Thanks, abhinav roy
Re: Review Request 29845: CLOUDSTACK-8152: Adding delay before creating snapshot/template from root disk after writing data to disk - test_vm_passwordenabled.py
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29845/#review67830 --- Ship it! d79837b67a481e618c8291152a9ecec299ff02dd master doesn't apply on 4.5 Applying: CLOUDSTACK-8152: Adding delay before creating snapshot/template from root disk after writing data to disk - test_vm_passwordenabled.py Using index info to reconstruct a base tree... M test/integration/component/test_vm_passwdenabled.py Falling back to patching base and 3-way merge... Auto-merging test/integration/component/test_vm_passwdenabled.py CONFLICT (content): Merge conflict in test/integration/component/test_vm_passwdenabled.py Failed to merge in the changes. Patch failed at 0001 CLOUDSTACK-8152: Adding delay before creating snapshot/template from root disk after writing data to disk - test_vm_passwordenabled.py The copy of the patch that failed is found in: /Users/talluri/asf/cloudstack/.git/rebase-apply/patch When you have resolved this problem, run git am --continue. If you prefer to skip this patch, run git am --skip instead. To restore the original branch and stop patching, run git am --abort. - SrikanteswaraRao Talluri On Jan. 13, 2015, 8:31 a.m., Gaurav Aradhye wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29845/ --- (Updated Jan. 13, 2015, 8:31 a.m.) Review request for cloudstack and SrikanteswaraRao Talluri. Bugs: CLOUDSTACK-8152 https://issues.apache.org/jira/browse/CLOUDSTACK-8152 Repository: cloudstack-git Description --- Due to timing issue, sometimes data gets lost if snapshot/template is created from root volume immediately after writing data to disk. Add delay to bypass this issue. Diffs - test/integration/component/test_vm_passwdenabled.py d998ed5 Diff: https://reviews.apache.org/r/29845/diff/ Testing --- Test get VM password for password enabled template ... === TestName: test_11_get_vm_password | Status : SUCCESS === ok -- Ran 1 test in 751.495s OK Thanks, Gaurav Aradhye
Re: Review Request 29478: CLOUDSTACK-8137: Fixed cleanup issue in sec group tests in test_escalations_instances.py
On Jan. 5, 2015, 1:21 p.m., SrikanteswaraRao Talluri wrote: eae9f0f0b0904a9dad025d4278b5e9b4fdf02b5e master 2dcfa157d37b9306c48f12aee54cb3b6f409277b 4.5 correcting hash for 4.5 17e19224398ac38bc9171bd157fb376361630f6d - SrikanteswaraRao --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29478/#review66633 --- On Dec. 30, 2014, 9:46 a.m., Ashutosh Kelkar wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29478/ --- (Updated Dec. 30, 2014, 9:46 a.m.) Review request for cloudstack and SrikanteswaraRao Talluri. Bugs: CLOUDSTACK-8137 https://issues.apache.org/jira/browse/CLOUDSTACK-8137 Repository: cloudstack-git Description --- The test case failed while deleting the security groups in cleanup operation because those were deleted as part of account cleanup. No need to add security groups in cleanup list explicitly. Diffs - test/integration/component/test_escalations_instances.py 1e5ec53 Diff: https://reviews.apache.org/r/29478/diff/ Testing --- @Desc: Test to verify deploy VM with multiple Security Groups ... -- Ran 1 test in 0.477s OK Thanks, Ashutosh Kelkar
Re: Review Request 29806: CLOUDSTACK-8147: Fixed typo in test case test_redundant_router.py
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29806/#review67826 --- Ship it! 032a00390561005dabdaa840c8ae8b36d136ccbd 4.5 9056e4c3fb568a4cbb978ef0c798bc2dd2c43bf1 master - SrikanteswaraRao Talluri On Jan. 12, 2015, 12:55 p.m., Ashutosh Kelkar wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29806/ --- (Updated Jan. 12, 2015, 12:55 p.m.) Review request for cloudstack and SrikanteswaraRao Talluri. Bugs: CLOUDSTACK-8147 https://issues.apache.org/jira/browse/CLOUDSTACK-8147 Repository: cloudstack-git Description --- The test case has typo connction instead of connection. Diffs - test/integration/component/maint/test_redundant_router.py 01d635b Diff: https://reviews.apache.org/r/29806/diff/ Testing --- yes. Thanks, Ashutosh Kelkar
Re: Review Request 29477: CLOUDSTACK-8135: Fixed cleanup issue in test_escalations_instances.py
On Jan. 5, 2015, 1:21 p.m., SrikanteswaraRao Talluri wrote: 1ee41888353d87f4972e6ccb492817133805a88e master 4e7f0d277b36be91ef041fc5ae59002679abe2e1 4.5 correcting the hash for 4.5 613aa8ea28b7670b13792a638fc493b6fe8ebb21 - SrikanteswaraRao --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29477/#review66634 --- On Dec. 30, 2014, 7:30 a.m., Ashutosh Kelkar wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29477/ --- (Updated Dec. 30, 2014, 7:30 a.m.) Review request for cloudstack and SrikanteswaraRao Talluri. Bugs: CLOUDSTACK-8135 https://issues.apache.org/jira/browse/CLOUDSTACK-8135 Repository: cloudstack-git Description --- The test case failed in cleanup operation because the VM gets cleaned up as a part of account cleanup. Hence no need to add the VM in to cleanup list explicitly. Diffs - test/integration/component/test_escalations_instances.py 1e5ec53 Diff: https://reviews.apache.org/r/29477/diff/ Testing --- @Desc: Test Attach ISO to VM and Detach ISO from VM. ... === TestName: test_13_attach_detach_iso | Status : SUCCESS === ok -- Ran 1 test in 167.918s OK Thanks, Ashutosh Kelkar
Re: Review Request 29759: CLOUDSTACK-8145: Adding new test to test blocker bugs and modifying other test case to work around the bug
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29759/#review67829 --- Ship it! f11e5707961f7a8e18238d06848d1bce6f0172ab master 9278ac1130683057cfbd752138b266565bd0f695 4.5 - SrikanteswaraRao Talluri On Jan. 9, 2015, 11:06 a.m., Gaurav Aradhye wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29759/ --- (Updated Jan. 9, 2015, 11:06 a.m.) Review request for cloudstack and SrikanteswaraRao Talluri. Bugs: CLOUDSTACK-8145 https://issues.apache.org/jira/browse/CLOUDSTACK-8145 Repository: cloudstack-git Description --- Few test cases failed due to timing issue in data syncof root disk data. Adding a new test case to test this issue, while changing other test cases with work around so that those are not blokced. More details are mentioned in the jira issue. Diffs - test/integration/component/test_blocker_bugs.py 8ba563f test/integration/component/test_reset_ssh_keypair.py a2e743a Diff: https://reviews.apache.org/r/29759/diff/ Testing --- Yes. Thanks, Gaurav Aradhye
Re: Review Request 29395: CLOUDSTACK-8124: Skipping snapshot tests on hyperv hypervisor
On Jan. 5, 2015, 1:16 p.m., SrikanteswaraRao Talluri wrote: 214d63ee1eb393168c2f91a646a775cdaeb5cae8 master 15858c56add3fe61e1c63c8fb3dfdeb8a4a85a2d 4.5 - SrikanteswaraRao --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29395/#review66631 --- On Dec. 24, 2014, 12:35 p.m., Gaurav Aradhye wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29395/ --- (Updated Dec. 24, 2014, 12:35 p.m.) Review request for cloudstack and SrikanteswaraRao Talluri. Repository: cloudstack-git Description --- In continuation with https://reviews.apache.org/r/29394/. Did not rebase it to make one patch because one commit is missing in 4.5 branch for one of the files. Please cherry-pick b0d74ad6fc68fd7022ec6cf378736430f0908a75 to 4.5 branch from master before applying this patch. Diffs - test/integration/component/test_project_limits.py d4fb92d test/integration/component/test_ps_domain_limits.py 268174f test/integration/component/test_ps_limits.py e557249 test/integration/component/test_resource_limits.py f7fecb0 test/integration/component/test_snapshots.py 4bb2dcf test/integration/component/test_ss_limits.py c498302 test/integration/component/test_tags.py 2b05fbb test/integration/component/test_templates.py 753e71a test/integration/component/test_usage.py 58cfbed Diff: https://reviews.apache.org/r/29395/diff/ Testing --- Tested with python and pyflakes. Thanks, Gaurav Aradhye
Re: Review Request 29394: CLOUDSTACK-8124: Skipping snapshot test cases on hyperv
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29394/#review66638 --- Ship it! 7f10e6fe0b6744dd6d3ce5942baa70dc19a1040a master ff1035b6b85a5cd726f4a7297b6eb2066bdcb91c 4.5 - SrikanteswaraRao Talluri On Dec. 24, 2014, 9:38 a.m., Gaurav Aradhye wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29394/ --- (Updated Dec. 24, 2014, 9:38 a.m.) Review request for cloudstack and SrikanteswaraRao Talluri. Bugs: CLOUDSTACK-4124 https://issues.apache.org/jira/browse/CLOUDSTACK-4124 Repository: cloudstack-git Description --- Snapshot feature is not supported on hyperV. Skipping related test cases. Diffs - test/integration/component/test_blocker_bugs.py f9530f0 Diff: https://reviews.apache.org/r/29394/diff/ Testing --- yes. Thanks, Gaurav Aradhye
Re: Review Request 29395: CLOUDSTACK-8124: Skipping snapshot tests on hyperv hypervisor
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29395/#review66631 --- Ship it! 214d63ee1eb393168c2f91a646a775cdaeb5cae8 master - SrikanteswaraRao Talluri On Dec. 24, 2014, 12:35 p.m., Gaurav Aradhye wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29395/ --- (Updated Dec. 24, 2014, 12:35 p.m.) Review request for cloudstack and SrikanteswaraRao Talluri. Repository: cloudstack-git Description --- In continuation with https://reviews.apache.org/r/29394/. Did not rebase it to make one patch because one commit is missing in 4.5 branch for one of the files. Please cherry-pick b0d74ad6fc68fd7022ec6cf378736430f0908a75 to 4.5 branch from master before applying this patch. Diffs - test/integration/component/test_project_limits.py d4fb92d test/integration/component/test_ps_domain_limits.py 268174f test/integration/component/test_ps_limits.py e557249 test/integration/component/test_resource_limits.py f7fecb0 test/integration/component/test_snapshots.py 4bb2dcf test/integration/component/test_ss_limits.py c498302 test/integration/component/test_tags.py 2b05fbb test/integration/component/test_templates.py 753e71a test/integration/component/test_usage.py 58cfbed Diff: https://reviews.apache.org/r/29395/diff/ Testing --- Tested with python and pyflakes. Thanks, Gaurav Aradhye
Re: Review Request 29509: CLOUDSATCK-8138: Fixed VmSnapshot revert issue in test_escalations_instances.py
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29509/#review66632 --- Ship it! 22d6565434e31a8c65953a9eb1b8bfeea1c0f1d0 master - SrikanteswaraRao Talluri On Dec. 31, 2014, 9:52 a.m., Gaurav Aradhye wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29509/ --- (Updated Dec. 31, 2014, 9:52 a.m.) Review request for cloudstack and SrikanteswaraRao Talluri. Bugs: CLOUDSTACK-8138 https://issues.apache.org/jira/browse/CLOUDSTACK-8138 Repository: cloudstack-git Description --- The VM should be in running state while reverting the snapshot because the VmSnapshot includes memorySnapshot too. Diffs - test/integration/component/test_escalations_instances.py 1e5ec5331b9e95d9e7cae5cd5071e0789525c67e Diff: https://reviews.apache.org/r/29509/diff/ Testing --- Yes. Thanks, Gaurav Aradhye
Re: Review Request 29509: CLOUDSATCK-8138: Fixed VmSnapshot revert issue in test_escalations_instances.py
On Jan. 5, 2015, 1:20 p.m., SrikanteswaraRao Talluri wrote: 22d6565434e31a8c65953a9eb1b8bfeea1c0f1d0 master doesn't apply on 4.5 - SrikanteswaraRao --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29509/#review66632 --- On Dec. 31, 2014, 9:52 a.m., Gaurav Aradhye wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29509/ --- (Updated Dec. 31, 2014, 9:52 a.m.) Review request for cloudstack and SrikanteswaraRao Talluri. Bugs: CLOUDSTACK-8138 https://issues.apache.org/jira/browse/CLOUDSTACK-8138 Repository: cloudstack-git Description --- The VM should be in running state while reverting the snapshot because the VmSnapshot includes memorySnapshot too. Diffs - test/integration/component/test_escalations_instances.py 1e5ec5331b9e95d9e7cae5cd5071e0789525c67e Diff: https://reviews.apache.org/r/29509/diff/ Testing --- Yes. Thanks, Gaurav Aradhye
Re: Review Request 29477: CLOUDSTACK-8135: Fixed cleanup issue in test_escalations_instances.py
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29477/#review66634 --- Ship it! 1ee41888353d87f4972e6ccb492817133805a88e master 4e7f0d277b36be91ef041fc5ae59002679abe2e1 4.5 - SrikanteswaraRao Talluri On Dec. 30, 2014, 7:30 a.m., Ashutosh Kelkar wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29477/ --- (Updated Dec. 30, 2014, 7:30 a.m.) Review request for cloudstack and SrikanteswaraRao Talluri. Bugs: CLOUDSTACK-8135 https://issues.apache.org/jira/browse/CLOUDSTACK-8135 Repository: cloudstack-git Description --- The test case failed in cleanup operation because the VM gets cleaned up as a part of account cleanup. Hence no need to add the VM in to cleanup list explicitly. Diffs - test/integration/component/test_escalations_instances.py 1e5ec53 Diff: https://reviews.apache.org/r/29477/diff/ Testing --- @Desc: Test Attach ISO to VM and Detach ISO from VM. ... === TestName: test_13_attach_detach_iso | Status : SUCCESS === ok -- Ran 1 test in 167.918s OK Thanks, Ashutosh Kelkar
Re: Review Request 29453: CLOUDSTACK-8132: Fixed issue related to secondary storage count of template
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29453/#review66635 --- Ship it! f938a5e1c352971aa61e75a60935c735c3d3920c master 6eba01d910c9e9cc1d1490d13e7870b74a4ea6a1 4.5 - SrikanteswaraRao Talluri On Dec. 29, 2014, 12:41 p.m., Ashutosh Kelkar wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29453/ --- (Updated Dec. 29, 2014, 12:41 p.m.) Review request for cloudstack and SrikanteswaraRao Talluri. Bugs: CLOUDSTACK-8132 https://issues.apache.org/jira/browse/CLOUDSTACK-8132 Repository: cloudstack-git Description --- The test case faiiled because the tempalte was registered through root account api client. It was supposed to be registered using the api client of the correct account (child account in this case). Corrected the code related to it. Diffs - test/integration/component/test_ss_limits.py c498302 Diff: https://reviews.apache.org/r/29453/diff/ Testing --- Yes. Thanks, Ashutosh Kelkar
Re: Review Request 29425: CLOUDSTACK-8130: Fixed test_escalations_templates.py - Removed test case dependency on each other
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29425/#review66636 --- Ship it! 17da2e9ce9894b67c32306fb36d02786d34ad0d0 master 6e4fd379f48721bffc2814052681970307db2f1f 4.5 - SrikanteswaraRao Talluri On Dec. 26, 2014, 7:03 a.m., Ashutosh Kelkar wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29425/ --- (Updated Dec. 26, 2014, 7:03 a.m.) Review request for cloudstack, sanjeev n and SrikanteswaraRao Talluri. Bugs: CLOUDSTACK-7130 https://issues.apache.org/jira/browse/CLOUDSTACK-7130 Repository: cloudstack-git Description --- The test cases were using the common account, hence one test affected other test case oepration sometimes. Created new account for each test case. Diffs - test/integration/component/test_escalations_templates.py 3dc24c1 Diff: https://reviews.apache.org/r/29425/diff/ Testing --- Yes. Thanks, Ashutosh Kelkar
simulator-singlerun job is failing in jenkins
simulator-singlerun has been failing while fetching from git. This was because of the zero disk space availability. I have cleaned up the machine and modified job to not to leave log files from the builds. Thanks, ~Talluri
Re: Review Request 29369: CLOUDSTACK-8117: Increased the allowed margin (+/-) for memory of VM on hyperv used to equate with the memory specified in service offering
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29369/#review66020 --- Ship it! Ship It! - SrikanteswaraRao Talluri On Dec. 23, 2014, 1:39 p.m., Gaurav Aradhye wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29369/ --- (Updated Dec. 23, 2014, 1:39 p.m.) Review request for cloudstack and SrikanteswaraRao Talluri. Bugs: CLOUDSTACK-8117 https://issues.apache.org/jira/browse/CLOUDSTACK-8117 Repository: cloudstack-git Description --- Increased the allowed margin (+/-) for memory of VM on hyperv used to equate with the memory specified in service offering. Large component of memory is consumed by the UI component, hence the memory for VM is listed lesser than that is specified in the service offering. Increase the range from 20 to 200 for hyperv because of the difference in template used. TODO: Find a way to get memory allolcated to VM on hyperv using powershell commands and use it to equate it to the memory specified in service offering. Also fixed pep8 issues. Diffs - test/integration/smoke/test_service_offerings.py e390f75 Diff: https://reviews.apache.org/r/29369/diff/ Testing --- Yes. Thanks, Gaurav Aradhye
Re: Review Request 29363: CLOUDSTACK-8116: Moved ldap data to configurableData section in test_data.py and made related changes in the test case
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29363/#review66021 --- Ship it! Ship It! - SrikanteswaraRao Talluri On Dec. 23, 2014, 12:13 p.m., Gaurav Aradhye wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29363/ --- (Updated Dec. 23, 2014, 12:13 p.m.) Review request for cloudstack and SrikanteswaraRao Talluri. Bugs: CLOUDSTACK-8116 https://issues.apache.org/jira/browse/CLOUDSTACK-8116 Repository: cloudstack-git Description --- Moved ldap data to configurableData section in test_data.py and made related changes in the test case. Also fixed pep8 issues and imports. Diffs - test/integration/component/test_ldap.py 5a78957 tools/marvin/marvin/config/test_data.py ba2fb24 Diff: https://reviews.apache.org/r/29363/diff/ Testing --- Not tested. Requires ldap server to be setup. The test case will be run successfully when correct information is filled in test_data.py file. Thanks, Gaurav Aradhye
Re: Review Request 29242: CLOUDSTACK-8096: Fixed test_ssvm.py for issues while checking the result of diagnostic scripts
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29242/#review65894 --- Ship it! 1413efcac3c80e0dd6561a35cf8fa2df10c2ad46 4.5 77bd069cc7b38bf93cc4e314d5d1ddcada56f11d master - SrikanteswaraRao Talluri On Dec. 22, 2014, 9:27 a.m., Gaurav Aradhye wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29242/ --- (Updated Dec. 22, 2014, 9:27 a.m.) Review request for cloudstack and SrikanteswaraRao Talluri. Bugs: CLOUDSTACK-8096 https://issues.apache.org/jira/browse/CLOUDSTACK-8096 Repository: cloudstack-git Description --- After reboot SSVM and CPVM operation, if we run diagnostic script on SSVM, it fails with NFS server is not currently mounted. Also if we run command service cloud status, it says Cloudstack cloud service is not running. But if we check after some time, everything is fine. Some delay in test cases is needed to allow the SSVM and CPVM to start all services. Added the delay as part of configurableData section so that it can be changed whenever required using external script without touching the test case. Also fixed import issues and pep8 issues. Diffs - test/integration/smoke/test_ssvm.py ed9eab0 tools/marvin/marvin/config/test_data.py 9add0fa Diff: https://reviews.apache.org/r/29242/diff/ Testing --- Test List secondary storage VMs ... === TestName: test_01_list_sec_storage_vm | Status : SUCCESS === ok Test List console proxy VMs ... === TestName: test_02_list_cpvm_vm | Status : SUCCESS === ok Test SSVM Internals ... === TestName: test_03_ssvm_internals | Status : SUCCESS === ok Test CPVM Internals ... === TestName: test_04_cpvm_internals | Status : SUCCESS === ok Test stop SSVM ... === TestName: test_05_stop_ssvm | Status : SUCCESS === ok Test stop CPVM ... === TestName: test_06_stop_cpvm | Status : SUCCESS === ok Test reboot SSVM ... === TestName: test_07_reboot_ssvm | Status : SUCCESS === ok Test reboot CPVM ... === TestName: test_08_reboot_cpvm | Status : SUCCESS === ok Test destroy SSVM ... === TestName: test_09_destroy_ssvm | Status : SUCCESS === ok Test destroy CPVM ... === TestName: test_10_destroy_cpvm | Status : SUCCESS === ok -- Ran 10 tests in 1555.479s OK Thanks, Gaurav Aradhye
Re: Review Request 29245: CLOUDSTACK-8098: Fixed VM snapshot issue in smoke/test_vm_snapshots.py
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29245/#review65905 --- Ship it! fc2c1a09a7064aa9121ead7c9f88fb268698c22e master 125c1c27fc0ebe3781fd2fb63e2d2dd5689c9fa0 4.5 - SrikanteswaraRao Talluri On Dec. 19, 2014, 12:12 p.m., Gaurav Aradhye wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29245/ --- (Updated Dec. 19, 2014, 12:12 p.m.) Review request for cloudstack and SrikanteswaraRao Talluri. Bugs: CLOUDSTACK-8098 https://issues.apache.org/jira/browse/CLOUDSTACK-8098 Repository: cloudstack-git Description --- The test case fails while reverting the VM snapshot because the snapshot does not contain the memory and VM is not in stopped state. Solution: Stop the VM before reverting the snapshot Also fixed pep8 issues and imports. Diffs - test/integration/smoke/test_vm_snapshots.py 131da99 Diff: https://reviews.apache.org/r/29245/diff/ Testing --- Yes. Log: Test to create VM snapshots ... === TestName: test_01_create_vm_snapshots | Status : SUCCESS === ok Test to revert VM snapshots ... === TestName: test_02_revert_vm_snapshots | Status : SUCCESS === ok Test to delete vm snapshots ... === TestName: test_03_delete_vm_snapshots | Status : SUCCESS === ok -- Ran 3 tests in 759.977s OK Thanks, Gaurav Aradhye
Re: Review Request 29246: CLOUDSTACK-8099: Fixed missing import in test_dynamic_compute_offering.py
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29246/#review65907 --- Ship it! bce67bc282e12db15a2630af30a0bf9ea5d46c29 master - SrikanteswaraRao Talluri On Dec. 22, 2014, 10:16 a.m., Ashutosh Kelkar wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29246/ --- (Updated Dec. 22, 2014, 10:16 a.m.) Review request for cloudstack and SrikanteswaraRao Talluri. Bugs: CLOUDSTACK-8099 https://issues.apache.org/jira/browse/CLOUDSTACK-8099 Repository: cloudstack-git Description --- Fixed the missing unittest import and pep8 issues. Diffs - test/integration/component/test_dynamic_compute_offering.py 1e47579 Diff: https://reviews.apache.org/r/29246/diff/ Testing --- Tested with python command and pylint. Thanks, Ashutosh Kelkar
Re: Review Request 29241: CLOUDSTACK-8095: Fixed Iso attach issue in test_escalations_instances.py
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29241/#review65796 --- Ship it! Ship It! - SrikanteswaraRao Talluri On Dec. 19, 2014, 7:26 a.m., Ashutosh Kelkar wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29241/ --- (Updated Dec. 19, 2014, 7:26 a.m.) Review request for cloudstack and SrikanteswaraRao Talluri. Bugs: CLOUDSTACK-8095 https://issues.apache.org/jira/browse/CLOUDSTACK-8095 Repository: cloudstack-git Description --- The test case was failing while attaching Iso to VM because it did not check whether the Iso is compatible to the VM. Added the check for xenserver and vmware compatible Iso so that xs-tools iso would get attached in case of XenServer and similar to vmware. Also fixed pep8 issues. Diffs - test/integration/component/test_escalations_instances.py e79cd3d Diff: https://reviews.apache.org/r/29241/diff/ Testing --- @Desc: Test Attach ISO to VM and Detach ISO from VM. ... === TestName: test_13_attach_detach_iso | Status : SUCCESS === ok -- Ran 1 test in 167.657s OK Thanks, Ashutosh Kelkar
Re: Review Request 29242: CLOUDSTACK-8096: Fixed test_ssvm.py for issues while checking the result of diagnostic scripts
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29242/#review65761 --- Applying: CLOUDSTACK-8096: Fixed test_ssvm.py for issues while checking the result of diagnostic scripts Using index info to reconstruct a base tree... M test/integration/smoke/test_ssvm.py M tools/marvin/marvin/config/test_data.py Falling back to patching base and 3-way merge... Auto-merging tools/marvin/marvin/config/test_data.py Auto-merging test/integration/smoke/test_ssvm.py CONFLICT (content): Merge conflict in test/integration/smoke/test_ssvm.py Failed to merge in the changes. Patch failed at 0001 CLOUDSTACK-8096: Fixed test_ssvm.py for issues while checking the result of diagnostic scripts The copy of the patch that failed is found in: /Users/talluri/asf/cloudstack/.git/rebase-apply/patch When you have resolved this problem, run git am --continue. If you prefer to skip this patch, run git am --skip instead. To restore the original branch and stop patching, run git am --abort. - SrikanteswaraRao Talluri On Dec. 19, 2014, 9:58 a.m., Gaurav Aradhye wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29242/ --- (Updated Dec. 19, 2014, 9:58 a.m.) Review request for cloudstack and SrikanteswaraRao Talluri. Bugs: CLOUDSTACK-8096 https://issues.apache.org/jira/browse/CLOUDSTACK-8096 Repository: cloudstack-git Description --- After reboot SSVM and CPVM operation, if we run diagnostic script on SSVM, it fails with NFS server is not currently mounted. Also if we run command service cloud status, it says Cloudstack cloud service is not running. But if we check after some time, everything is fine. Some delay in test cases is needed to allow the SSVM and CPVM to start all services. Added the delay as part of configurableData section so that it can be changed whenever required using external script without touching the test case. Also fixed import issues and pep8 issues. Diffs - test/integration/smoke/test_ssvm.py 5713569 tools/marvin/marvin/config/test_data.py 4ab7e56 Diff: https://reviews.apache.org/r/29242/diff/ Testing --- Test List secondary storage VMs ... === TestName: test_01_list_sec_storage_vm | Status : SUCCESS === ok Test List console proxy VMs ... === TestName: test_02_list_cpvm_vm | Status : SUCCESS === ok Test SSVM Internals ... === TestName: test_03_ssvm_internals | Status : SUCCESS === ok Test CPVM Internals ... === TestName: test_04_cpvm_internals | Status : SUCCESS === ok Test stop SSVM ... === TestName: test_05_stop_ssvm | Status : SUCCESS === ok Test stop CPVM ... === TestName: test_06_stop_cpvm | Status : SUCCESS === ok Test reboot SSVM ... === TestName: test_07_reboot_ssvm | Status : SUCCESS === ok Test reboot CPVM ... === TestName: test_08_reboot_cpvm | Status : SUCCESS === ok Test destroy SSVM ... === TestName: test_09_destroy_ssvm | Status : SUCCESS === ok Test destroy CPVM ... === TestName: test_10_destroy_cpvm | Status : SUCCESS === ok -- Ran 10 tests in 1555.479s OK Thanks, Gaurav Aradhye
Re: Review Request 29246: CLOUDSTACK-8099: Fixed missing import in test_dynamic_compute_offering.py
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29246/#review65733 --- doesn't apply cleanly on master: git am -3s /Users/talluri/Downloads/0001-CLOUDSTACK-8099-Fixed-missing-import-in-test_dynamic.patch Applying: CLOUDSTACK-8099: Fixed missing import in test_dynamic_compute_offering.py Using index info to reconstruct a base tree... M test/integration/component/test_dynamic_compute_offering.py Falling back to patching base and 3-way merge... Auto-merging test/integration/component/test_dynamic_compute_offering.py CONFLICT (content): Merge conflict in test/integration/component/test_dynamic_compute_offering.py Failed to merge in the changes. Patch failed at 0001 CLOUDSTACK-8099: Fixed missing import in test_dynamic_compute_offering.py The copy of the patch that failed is found in: /Users/talluri/asf/cloudstack/.git/rebase-apply/patch When you have resolved this problem, run git am --continue. If you prefer to skip this patch, run git am --skip instead. - SrikanteswaraRao Talluri On Dec. 19, 2014, 12:56 p.m., Ashutosh Kelkar wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29246/ --- (Updated Dec. 19, 2014, 12:56 p.m.) Review request for cloudstack and SrikanteswaraRao Talluri. Bugs: CLOUDSTACK-8099 https://issues.apache.org/jira/browse/CLOUDSTACK-8099 Repository: cloudstack-git Description --- Fixed the missing unittest import and pep8 issues. Diffs - test/integration/component/test_dynamic_compute_offering.py d96fd84 Diff: https://reviews.apache.org/r/29246/diff/ Testing --- Tested with python command and pylint. Thanks, Ashutosh Kelkar
Re: Review Request 29245: CLOUDSTACK-8098: Fixed VM snapshot issue in smoke/test_vm_snapshots.py
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29245/#review65734 --- git am -3s /Users/talluri/Downloads/0002-CLOUDSTACK-8098-Fixed-VM-snapshot-issue-in-smoke-tes.patch Applying: CLOUDSTACK-8098: Fixed VM snapshot issue in smoke/test_vm_snapshots.py Using index info to reconstruct a base tree... M test/integration/smoke/test_vm_snapshots.py Falling back to patching base and 3-way merge... Auto-merging test/integration/smoke/test_vm_snapshots.py CONFLICT (content): Merge conflict in test/integration/smoke/test_vm_snapshots.py Failed to merge in the changes. Patch failed at 0001 CLOUDSTACK-8098: Fixed VM snapshot issue in smoke/test_vm_snapshots.py The copy of the patch that failed is found in: /Users/talluri/asf/cloudstack/.git/rebase-apply/patch When you have resolved this problem, run git am --continue. If you prefer to skip this patch, run git am --skip instead. To restore the original branch and stop patching, run git am --abort. - SrikanteswaraRao Talluri On Dec. 19, 2014, 12:12 p.m., Gaurav Aradhye wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29245/ --- (Updated Dec. 19, 2014, 12:12 p.m.) Review request for cloudstack and SrikanteswaraRao Talluri. Bugs: CLOUDSTACK-8098 https://issues.apache.org/jira/browse/CLOUDSTACK-8098 Repository: cloudstack-git Description --- The test case fails while reverting the VM snapshot because the snapshot does not contain the memory and VM is not in stopped state. Solution: Stop the VM before reverting the snapshot Also fixed pep8 issues and imports. Diffs - test/integration/smoke/test_vm_snapshots.py 131da99 Diff: https://reviews.apache.org/r/29245/diff/ Testing --- Yes. Log: Test to create VM snapshots ... === TestName: test_01_create_vm_snapshots | Status : SUCCESS === ok Test to revert VM snapshots ... === TestName: test_02_revert_vm_snapshots | Status : SUCCESS === ok Test to delete vm snapshots ... === TestName: test_03_delete_vm_snapshots | Status : SUCCESS === ok -- Ran 3 tests in 759.977s OK Thanks, Gaurav Aradhye
Re: Review Request 29194: CLOUDSTACK-8087: Fixed test_vpc_on_host_maintenance.py
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29194/#review65601 --- Ship it! 162f61b73fa0e8faa981bc090df27fea8afc4c50 master 6c722c9d219ae3bedad12a28105800b096eeb147 4.5 - SrikanteswaraRao Talluri On Dec. 18, 2014, 6:39 a.m., Ashutosh Kelkar wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29194/ --- (Updated Dec. 18, 2014, 6:39 a.m.) Review request for cloudstack and SrikanteswaraRao Talluri. Bugs: CLOUDSTACK-8087 https://issues.apache.org/jira/browse/CLOUDSTACK-8087 Repository: cloudstack-git Description --- Passed start=False while creating VPC because it is being created when hosts are in maintenance state. Fixed pep8 issues too. Diffs - test/integration/component/maint/test_vpc_on_host_maintenance.py eb3360a Diff: https://reviews.apache.org/r/29194/diff/ Testing --- Yes. It still fails while asserting the state of VPC. On hold until heard from developer. Logged product bug for this. Thanks, Ashutosh Kelkar
Re: Review Request 29187: CLOUDSTACK-8086: Simulator needs a Portable IP Range to execute Portable IP Test Cases
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29187/#review65605 --- Ship it! 696698090eb2ea548bfc74b802ba7dd01a584b91 master f2c7ead8ee68de963a97eae9dc78bf524565691e 4.5 - SrikanteswaraRao Talluri On Dec. 18, 2014, 2:29 a.m., Chandan Purushothama wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29187/ --- (Updated Dec. 18, 2014, 2:29 a.m.) Review request for cloudstack and SrikanteswaraRao Talluri. Bugs: CLOUDSTACK-8086 https://issues.apache.org/jira/browse/CLOUDSTACK-8086 Repository: cloudstack-git Description --- Currently test cases are failing in Simulator, since the portable IP Range dictionary is empty in testdata.py. Fake IP Range information needs to be provided so that the test cases can be run without any issues. Diffs - tools/marvin/marvin/config/test_data.py 269f46e Diff: https://reviews.apache.org/r/29187/diff/ Testing --- Testing not done Thanks, Chandan Purushothama
Re: Review Request 29151: CLOUDSTACK-8084: Fixed test_17_add_nic_different_zone in test_add_remove_network.py
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29151/#review65604 --- Ship it! 3090e4a0301c4be50d0d46703b2d9fa070c2e91b master 0db63d87aa40de7493a6bc66b7686cf8922bc742 4.5 - SrikanteswaraRao Talluri On Dec. 17, 2014, 12:17 p.m., Gaurav Aradhye wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29151/ --- (Updated Dec. 17, 2014, 12:17 p.m.) Review request for cloudstack and SrikanteswaraRao Talluri. Bugs: CLOUDSTACK-8084 https://issues.apache.org/jira/browse/CLOUDSTACK-8084 Repository: cloudstack-git Description --- The network was created within root admin account, so it had a risk of getting used by other test cases by default. In that case cleanup would fail. Created the network in account created by the test case. Diffs - test/integration/component/test_add_remove_network.py aacd44b Diff: https://reviews.apache.org/r/29151/diff/ Testing --- Yes. Log: Add network to vm where both belong to different zones ... === TestName: test_17_add_nic_different_zone | Status : SUCCESS === ok -- Ran 1 test in 308.910s OK Thanks, Gaurav Aradhye
Re: Review Request 29202: CLOUDSTACK-8090: Moving test_dedicated_guest_vlan_ranges.py to maint folder for the test cases need to be run separately, serially
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29202/#review65606 --- Ship it! 95b558414f0808d63920a2906f484fd6b15a4713 master d88126988b04bb8a58fb70e195722b01b45f05dc 4.5 - SrikanteswaraRao Talluri On Dec. 18, 2014, 10:33 a.m., Gaurav Aradhye wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29202/ --- (Updated Dec. 18, 2014, 10:33 a.m.) Review request for cloudstack and SrikanteswaraRao Talluri. Bugs: CLOUDSTACK-8090 https://issues.apache.org/jira/browse/CLOUDSTACK-8090 Repository: cloudstack-git Description --- The test cases need to be run separately as they create vlan ranges, and dedicated them to an account/project. In between the vlans should not get consumed by other account. Else test cases will fail like following Execute cmd: dedicateguestvlanrange failed, due to: errorCode: 431, errorText:Guest vlan from this range 3390 is allocated to a different account. Can only dedicate a range which has no allocated vlans or has vlans allocated to the same account Diffs - test/integration/component/maint/test_dedicate_guest_vlan_ranges.py PRE-CREATION test/integration/component/test_dedicate_guest_vlan_ranges.py 9a0e7f0 Diff: https://reviews.apache.org/r/29202/diff/ Testing --- N/A Thanks, Gaurav Aradhye
Re: Review Request 29094: CLOUDSTACK-8074: Fixed maint/test_multiple_ip_ranges.py
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29094/#review65307 --- Ship it! It would be nice to fix these irrespective of the code modified by you: pep8 test/integration/component/maint/test_multiple_ip_ranges.py test/integration/component/maint/test_multiple_ip_ranges.py:83:80: E501 line too long (102 79 characters) test/integration/component/maint/test_multiple_ip_ranges.py:142:50: E231 missing whitespace after ',' test/integration/component/maint/test_multiple_ip_ranges.py:160:17: E126 continuation line over-indented for hanging indent test/integration/component/maint/test_multiple_ip_ranges.py:168:80: E501 line too long (85 79 characters) - SrikanteswaraRao Talluri On Dec. 16, 2014, 11:53 a.m., Ashutosh Kelkar wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29094/ --- (Updated Dec. 16, 2014, 11:53 a.m.) Review request for cloudstack and SrikanteswaraRao Talluri. Bugs: CLOUDSTACK-8074 https://issues.apache.org/jira/browse/CLOUDSTACK-8074 Repository: cloudstack-git Description --- There were many issues in this test suite, almost rewrote it (69%). Diffs - test/integration/component/maint/test_multiple_ip_ranges.py 982dd7c Diff: https://reviews.apache.org/r/29094/diff/ Testing --- Deploy guest vm after adding guest IP range in new CIDR ... === TestName: test_01_deploy_vm_in_new_cidr | Status : SUCCESS === ok Deploy guest vm in new CIDR and verify dns service on alias ip ... === TestName: test_02_dns_service_on_alias_ip | Status : SUCCESS === ok Deploy guest vm in new CIDR and verify passwd service on alias ip ... === TestName: test_03_passwd_service_on_alias_IP | Status : SUCCESS === ok Deploy guest vm in new CIDR and verify userdata service on alias ip ... === TestName: test_04_userdata_service_on_alias_IP | Status : SUCCESS === ok Destroy lastvm in the CIDR and verifly alias removal ... === TestName: test_05_del_cidr_verify_alias_removal | Status : SUCCESS === ok Reboot VR and verify ip alias ... === TestName: test_06_reboot_VR_verify_ip_alias | Status : SUCCESS === ok Reboot VR and verify ip alias ... === TestName: test_07_stop_start_VR_verify_ip_alias | Status : SUCCESS === ok -- Ran 7 tests in 1151.865s OK Thanks, Ashutosh Kelkar
Re: Review Request 29094: CLOUDSTACK-8074: Fixed maint/test_multiple_ip_ranges.py
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29094/#review65312 --- Ship it! c3508f61a18384e9201d3d1dc87c35c67e200039 4.5 7cf94260ee6adc49df97214ea7410dd387be11e5 master - SrikanteswaraRao Talluri On Dec. 16, 2014, 11:53 a.m., Ashutosh Kelkar wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29094/ --- (Updated Dec. 16, 2014, 11:53 a.m.) Review request for cloudstack and SrikanteswaraRao Talluri. Bugs: CLOUDSTACK-8074 https://issues.apache.org/jira/browse/CLOUDSTACK-8074 Repository: cloudstack-git Description --- There were many issues in this test suite, almost rewrote it (69%). Diffs - test/integration/component/maint/test_multiple_ip_ranges.py 982dd7c Diff: https://reviews.apache.org/r/29094/diff/ Testing --- Deploy guest vm after adding guest IP range in new CIDR ... === TestName: test_01_deploy_vm_in_new_cidr | Status : SUCCESS === ok Deploy guest vm in new CIDR and verify dns service on alias ip ... === TestName: test_02_dns_service_on_alias_ip | Status : SUCCESS === ok Deploy guest vm in new CIDR and verify passwd service on alias ip ... === TestName: test_03_passwd_service_on_alias_IP | Status : SUCCESS === ok Deploy guest vm in new CIDR and verify userdata service on alias ip ... === TestName: test_04_userdata_service_on_alias_IP | Status : SUCCESS === ok Destroy lastvm in the CIDR and verifly alias removal ... === TestName: test_05_del_cidr_verify_alias_removal | Status : SUCCESS === ok Reboot VR and verify ip alias ... === TestName: test_06_reboot_VR_verify_ip_alias | Status : SUCCESS === ok Reboot VR and verify ip alias ... === TestName: test_07_stop_start_VR_verify_ip_alias | Status : SUCCESS === ok -- Ran 7 tests in 1151.865s OK Thanks, Ashutosh Kelkar
Re: Review Request 29144: CLOUDSTACK-8081: Fixed VM snapshot test cases in test_escalation_instances.py and also dealt cleanup issues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29144/#review65313 --- Ship it! daabe92a992f072c6305b14b88fcda99e19a7190 4.5 6674f95cdd268652d109558eabb3402a4e6f7e43 master - SrikanteswaraRao Talluri On Dec. 17, 2014, 6:09 a.m., Gaurav Aradhye wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29144/ --- (Updated Dec. 17, 2014, 6:09 a.m.) Review request for cloudstack and SrikanteswaraRao Talluri. Bugs: CLOUDSTACK-8081 https://issues.apache.org/jira/browse/CLOUDSTACK-8081 Repository: cloudstack-git Description --- The VM snapshot test case was failiong while reverting the snapshot. That is because the VM snapshot created included only the disk, not memory. And reverting a VM snapshot having only disk is possible only when the VM is in stopped state. So either stop the VM before reverting the snapshot, or inlude memory too while creating the VM snapshot. Changes: 1) Included memory while creating VM snapshot. 2) Created separate account for each test case rather than using common account (Common account might leads to cleanup complexities, where the test cases affect each other) Diffs - test/integration/component/test_escalations_instances.py 9f053a1 Diff: https://reviews.apache.org/r/29144/diff/ Testing --- Yes. Thanks, Gaurav Aradhye
Re: Review Request 29046: CLOUDSTACK-8071: Fixed api key issue in test_snapshots_improvement.py
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29046/#review65315 --- Ship it! ed5bc1c7ea1885e95c7cad0045243c7f43e9f516 4.5 391108ff533bdaa40356538ccf04a77498398ad9 master - SrikanteswaraRao Talluri On Dec. 15, 2014, 10:32 a.m., Ashutosh Kelkar wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29046/ --- (Updated Dec. 15, 2014, 10:32 a.m.) Review request for cloudstack and SrikanteswaraRao Talluri. Bugs: CLOUDSTACK-8071 https://issues.apache.org/jira/browse/CLOUDSTACK-8071 Repository: cloudstack-git Description --- The test case failed with Api key does not map with valid account. That is because the apiclient object was assigned previous account's value in another test case. It is important that all test cases use different account and their respective api clients. Made appropriate changes. Diffs - test/integration/component/test_snapshots_improvement.py 6638ddd Diff: https://reviews.apache.org/r/29046/diff/ Testing --- Test perform concurrent snapshots and migrate the vm from one host ... === TestName: test_01_concurrent_snapshots_live_migrate | Status : SUCCESS === ok Test stop running VM while performing concurrent snapshot on volume ... === TestName: test_02_stop_vm_concurrent_snapshots | Status : SUCCESS === ok Test while parent concurrent snapshot job in progress,create ... === TestName: test_03_concurrent_snapshots_create_template | Status : SUCCESS === ok Test while parent concurrent snapshot job in progress,create volume ... === TestName: test_04_concurrent_snapshots_create_volume | Status : SUCCESS === ok -- Ran 4 tests in 1132.201s OK Thanks, Ashutosh Kelkar
Re: [ANNOUNCE] New committer: Erik Weber (terbolous)
Congrats Erik! ~Talluri On 15/12/14 10:59 am, Punith S punit...@cloudbyte.com wrote: congrats Erik :) On Sun, Dec 14, 2014 at 11:32 PM, Mike Tutkowski mike.tutkow...@solidfire.com wrote: Congratulations, Erik! On Sat, Dec 13, 2014 at 9:16 PM, Rajani Karuturi raj...@apache.org wrote: Congratulations Eric :) On Sun, Dec 14, 2014 at 9:01 AM, Todd Pigram t...@toddpigram.com wrote: Congrats! On Saturday, December 13, 2014, ilya musayev ilya.mailing.li...@gmail.com javascript:; wrote: Congrats and welcome! On 12/13/14, 12:27 PM, Rohit Yadav wrote: Congrats Erik! On 14-Dec-2014, at 1:27 am, Nux! n...@li.nux.ro javascript:; wrote: Gratulerer :-) Lucian -- Sent from the Delta quadrant using Borg technology! Nux! www.nux.ro - Original Message - From: Pierre-Luc Dion pdion...@apache.org javascript:; To: dev@cloudstack.apache.org javascript:; Sent: Saturday, 13 December, 2014 17:03:32 Subject: [ANNOUNCE] New committer: Erik Weber (terbolous) The Project Management Committee (PMC) for Apache CloudStack has asked Erik Weber to become a committer and we are pleased to announce that they have accepted. Erik is doing a great job on helping the community thru the mailing list. He helped a lot on testing and troubleshooting new releases of CloudStack as well as contributing to the documentation. Thanks Erik and Congrat! Being a committer allows many contributors to contribute more autonomously. For developers, it makes it easier to submit changes and eliminates the need to have contributions reviewed via the patch submission process. Whether contributions are development-related or otherwise, it is a recognition of a contributor's participation in the project and commitment to the project and the Apache Way. Please join me in congratulating Erik Pierre-Luc on behalf of the CloudStack PMC Regards, Rohit Yadav Software Architect, ShapeBlue M. +91 88 262 30892 | rohit.ya...@shapeblue.com javascript:; Blog: bhaisaab.org | Twitter: @_bhaisaab Find out more about ShapeBlue and our range of CloudStack related services IaaS Cloud Design Buildhttp://shapeblue.com/ iaas-cloud-design-and-build// CSForge rapid IaaS deployment framework http://shapeblue.com/csforge/ CloudStack Consultinghttp://shapeblue.com/cloudstack-consultancy/ CloudStack Software Engineering http://shapeblue.com/cloudstack-software- engineering/ CloudStack Infrastructure Supporthttp://shapeblue.com/ cloudstack-infrastructure-support/ CloudStack Bootcamp Training Courseshttp://shapeblue.com/ cloudstack-training/ This email and any attachments to it may be confidential and are intended solely for the use of the individual to whom it is addressed. Any views or opinions expressed are solely those of the author and do not necessarily represent those of Shape Blue Ltd or related companies. If you are not the intended recipient of this email, you must neither take any action based upon its contents, nor copy or show it to anyone. Please contact the sender if you believe you have received this email in error. Shape Blue Ltd is a company incorporated in England Wales. ShapeBlue Services India LLP is a company incorporated in India and is operated under license from Shape Blue Ltd. Shape Blue Brasil Consultoria Ltda is a company incorporated in Brasil and is operated under license from Shape Blue Ltd. ShapeBlue SA Pty Ltd is a company registered by The Republic of South Africa and is traded under license from Shape Blue Ltd. ShapeBlue is a registered trademark. -- Todd Pigram http://about.me/ToddPigram www.linkedin.com/in/toddpigram/ @pigram86 on twitter https://plus.google.com/+ToddPigram86 Mobile - 216-224-5769 -- Sent from Windows Phone -- *Mike Tutkowski* *Senior CloudStack Developer, SolidFire Inc.* e: mike.tutkow...@solidfire.com o: 303.746.7302 Advancing the way the world uses the cloud http://solidfire.com/solution/overview/?video=play** -- regards, punith s cloudbyte.com
Re: Review Request 28992: CLOUDSTACK-8055: Tagging test cases which can't be run on simulator accordingly
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28992/#review64900 --- Ship it! ff15320a4e0bd11d90b799e9a2ff24d91750bfc6 master ecbeb003ec94149adfeb8234f11979b5d99fba7b 4.5 - SrikanteswaraRao Talluri On Dec. 12, 2014, 9:04 a.m., Gaurav Aradhye wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28992/ --- (Updated Dec. 12, 2014, 9:04 a.m.) Review request for cloudstack and SrikanteswaraRao Talluri. Bugs: CLOUDSTACK-8055 https://issues.apache.org/jira/browse/CLOUDSTACK-8055 Repository: cloudstack-git Description --- The test case tries to SSH to VM. Should not be running on Simulator. Diffs - test/integration/component/test_ip_reservation.py 37b783f Diff: https://reviews.apache.org/r/28992/diff/ Testing --- N/A Thanks, Gaurav Aradhye
Re: Review Request 28993: CLOUDSTACK-8069: Fixed test script in test_tags.py
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28993/#review64902 --- Ship it! e791e8ec6d6484c5ea7853bf7e8184103846a75e 4.5 9c7f50aaac83313d7f3e71ddd5b83a001402d7f7 master - SrikanteswaraRao Talluri On Dec. 12, 2014, 11:34 a.m., Gaurav Aradhye wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28993/ --- (Updated Dec. 12, 2014, 11:34 a.m.) Review request for cloudstack and SrikanteswaraRao Talluri. Bugs: CLOUDSTACK-8069 https://issues.apache.org/jira/browse/CLOUDSTACK-8069 Repository: cloudstack-git Description --- Test case failed while listing tags because it passed projectid instead of resourceIds parameter. Diffs - test/integration/component/test_tags.py c5a8ced Diff: https://reviews.apache.org/r/28993/diff/ Testing --- Log: Test creation, listing and deletion tags on projects ... === TestName: test_15_project_tag | Status : SUCCESS === ok -- Ran 1 test in 279.514s OK Thanks, Gaurav Aradhye
Re: Review Request 28748: CLOUDSTACK-8021: Change test cases to use host information from configurableData section in test_data.py
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28748/#review64718 --- doesn't apply cleanly on 4.5 git am -s /Users/talluri/Downloads/0001-CLOUDSTACK-8021-Change-test-cases-to-use-host-inform.patch Applying: CLOUDSTACK-8021: Change test cases to use host information from configurableData section in test_data.py error: patch failed: test/integration/component/test_deploy_vgpu_vm.py:15 error: test/integration/component/test_deploy_vgpu_vm.py: patch does not apply Patch failed at 0001 CLOUDSTACK-8021: Change test cases to use host information from configurableData section in test_data.py The copy of the patch that failed is found in: /Users/talluri/asf/cloudstack/.git/rebase-apply/patch When you have resolved this problem, run git am --continue. If you prefer to skip this patch, run git am --skip instead. To restore the original branch and stop patching, run git am --abort. - SrikanteswaraRao Talluri On Dec. 5, 2014, 2:37 p.m., Gaurav Aradhye wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28748/ --- (Updated Dec. 5, 2014, 2:37 p.m.) Review request for cloudstack and SrikanteswaraRao Talluri. Bugs: CLOUDSTACK-8021 https://issues.apache.org/jira/browse/CLOUDSTACK-8021 Repository: cloudstack-git Description --- Changing few test cases to use the host username, password from the configurableData section in test_data.py. Earlier they were reading the hard coded value. Removed old host_password value from test_data.py Also fixed few pep8 issues. Diffs - test/integration/component/test_deploy_vgpu_vm.py 0284eab test/integration/component/test_persistent_networks.py 4b1bc7a test/integration/smoke/test_deploy_vgpu_enabled_vm.py f13ac92 Diff: https://reviews.apache.org/r/28748/diff/ Testing --- Tested test_persistent_networks.py Other test cases not testable right now. Change is only in reading the config value. Thanks, Gaurav Aradhye
Re: Review Request 28931: CLOUDSTACK:8058: Fix test_reset_ssh_keypair.py for EIP setup
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28931/#review64720 --- Ship it! 9aefd9bf4f580dd5954520b6b53909b1f732b7f8 4.5 - SrikanteswaraRao Talluri On Dec. 11, 2014, 4:55 a.m., Gaurav Aradhye wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28931/ --- (Updated Dec. 11, 2014, 4:55 a.m.) Review request for cloudstack and SrikanteswaraRao Talluri. Bugs: CLOUDSTACK-8058 https://issues.apache.org/jira/browse/CLOUDSTACK-8058 Repository: cloudstack-git Description --- The publicIP of the VM changes on EIP setup after stop and start operation. Hence it is necessary that on such setup, new publicip should be used for the SSH. Made the necessary changes to use the new publicip. Diffs - test/integration/component/test_reset_ssh_keypair.py 370e9a8 Diff: https://reviews.apache.org/r/28931/diff/ Testing --- Yes. On Advanced zone: Verify API resetSSHKeyForVirtualMachine for non admin non root ... === TestName: test_01_reset_keypair_normal_user | Status : SUCCESS === ok Verify API resetSSHKeyForVirtualMachine for domain admin non root ... === TestName: test_02_reset_keypair_domain_admin | Status : SUCCESS === ok Verify API resetSSHKeyForVirtualMachine for domain admin root ... === TestName: test_03_reset_keypair_root_admin | Status : SUCCESS === ok Test Reset SSH keys for VM already having SSH key ... === TestName: test_01_reset_ssh_keys | Status : SUCCESS === ok Reset SSH keys for VM created from password enabled template and ... === TestName: test_02_reset_ssh_key_password_enabled_template | Status : SUCCESS === ok Reset SSH key for VM having no SSH key ... === TestName: test_03_reset_ssh_with_no_key | Status : SUCCESS === ok Reset SSH keys for VM created from password enabled template and ... === TestName: test_04_reset_key_passwd_enabled_no_key | Status : SUCCESS === ok Reset SSH keys for VM already having SSH key when VM is in running ... === TestName: test_05_reset_key_in_running_state | Status : SUCCESS === ok Reset SSH keys for VM created from password enabled template and ... === TestName: test_06_reset_key_passwd_enabled_vm_running | Status : SUCCESS === ok Verify API resetSSHKeyForVirtualMachine with incorrect parameters ... === TestName: test_07_reset_keypair_invalid_params | Status : SUCCESS === ok -- Ran 10 tests in 4553.103s OK On EIP setup (basic zone): Verify API resetSSHKeyForVirtualMachine for non admin non root ... === TestName: test_01_reset_keypair_normal_user | Status : SUCCESS === ok Verify API resetSSHKeyForVirtualMachine for domain admin non root ... === TestName: test_02_reset_keypair_domain_admin | Status : SUCCESS === ok Verify API resetSSHKeyForVirtualMachine for domain admin root ... === TestName: test_03_reset_keypair_root_admin | Status : SUCCESS === ok Test Reset SSH keys for VM already having SSH key ... === TestName: test_01_reset_ssh_keys | Status : SUCCESS === ok Reset SSH keys for VM created from password enabled template and ... === TestName: test_02_reset_ssh_key_password_enabled_template | Status : SUCCESS === ok Reset SSH key for VM having no SSH key ... === TestName: test_03_reset_ssh_with_no_key | Status : SUCCESS === ok Reset SSH keys for VM created from password enabled template and ... === TestName: test_04_reset_key_passwd_enabled_no_key | Status : SUCCESS === ok Reset SSH keys for VM already having SSH key when VM is in running ... === TestName: test_05_reset_key_in_running_state | Status : SUCCESS === ok Reset SSH keys for VM created from password enabled template and ... === TestName: test_06_reset_key_passwd_enabled_vm_running | Status : SUCCESS === ok Verify API resetSSHKeyForVirtualMachine with incorrect parameters ... === TestName: test_07_reset_keypair_invalid_params | Status : SUCCESS === ok -- Ran 10 tests in 3443.114s OK Thanks, Gaurav Aradhye
Re: Review Request 28939: CLOUDSTACK:8018: Fix test_redundant_router.test_redundantVR_internals - The SSH to router was being done from wrong host
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28939/#review64721 --- Ship it! bbebac733969ffa0125befdba28c49b48c44ee50 4.5 - SrikanteswaraRao Talluri On Dec. 11, 2014, 11:45 a.m., Gaurav Aradhye wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28939/ --- (Updated Dec. 11, 2014, 11:45 a.m.) Review request for cloudstack and SrikanteswaraRao Talluri. Bugs: CLOUDSTACK-8018 https://issues.apache.org/jira/browse/CLOUDSTACK-8018 Repository: cloudstack-git Description --- The host used for SSHing to router was wrong one. Corrected the code. Diffs - test/integration/component/maint/test_redundant_router.py 099ae2c Diff: https://reviews.apache.org/r/28939/diff/ Testing --- Yes. Log: Test redundant router internals ... === TestName: test_redundantVR_internals | Status : SUCCESS === ok -- Ran 1 test in 206.192s OK Thanks, Gaurav Aradhye