[GitHub] cloudstack pull request: CLOUDSTACK-8562: Dynamic Role-Based API C...

[borisroman]

Github user borisroman commented on the pull request:

https://github.com/apache/cloudstack/pull/1489#issuecomment-216487485
  
@swill I think you mentioned the wrong Boris :)



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Restore iptables at once using iptables-r...

[borisroman]

Github user borisroman closed the pull request at:

https://github.com/apache/cloudstack/pull/1400


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Restore iptables at once using iptables-r...

[borisroman]

GitHub user borisroman opened a pull request:

https://github.com/apache/cloudstack/pull/1400

Restore iptables at once using iptables-restore instead of calling iptables 
numerous times



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/borisroman/cloudstack iptables-fix

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/1400.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1400


commit 9145301b261bb66c13823302e313f5baeedb9cac
Author: Boris Schrijver <bschrij...@schubergphilis.com>
Date:   2016-02-01T14:57:26Z

Add iptables copnversion script.

Source: 
https://raw.githubusercontent.com/sl0/conv/master/iptables_converter.py

commit 21a2f3ea01f176825a2ae47ba05ffb1f2e840a9b
Author: Boris Schrijver <bschrij...@schubergphilis.com>
Date:   2016-02-01T14:58:27Z

Restore iptables at once using iptables-restore instead of calling iptables 
numerous times

commit febb3ea9e723de97a4cd6c023a1b9d4b4e2b06c1
Author: Boris Schrijver <bschrij...@schubergphilis.com>
Date:   2016-02-03T14:30:19Z

Remove duplicate spaces, and thus duplicate rules.

commit 0f63846629d9d8b71210724773f38fa2cbd3d2dd
Author: Boris Schrijver <bschrij...@schubergphilis.com>
Date:   2016-02-03T15:15:28Z

Wait for dnsmasq to finish restart




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Restore iptables at once using iptables-r...

[borisroman]

Github user borisroman commented on the pull request:

https://github.com/apache/cloudstack/pull/1391#issuecomment-179292599
  
New PR with additional fixes.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Restore iptables at once using iptables-r...

[borisroman]

Github user borisroman closed the pull request at:

https://github.com/apache/cloudstack/pull/1391


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Restore iptables at once using iptables-r...

[borisroman]

Github user borisroman closed the pull request at:

https://github.com/apache/cloudstack/pull/1389


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Restore iptables at once using iptables-r...

[borisroman]

Github user borisroman commented on the pull request:

https://github.com/apache/cloudstack/pull/1389#issuecomment-178503500
  
@DaanHoogland Two errors, one in S2S and one in prv gw. Will reopen in a few


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Restore iptables at once using iptables-r...

[borisroman]

GitHub user borisroman opened a pull request:

https://github.com/apache/cloudstack/pull/1391

Restore iptables at once using iptables-restore instead of calling iptables 
numerous times



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/borisroman/cloudstack iptables-fix

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/1391.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1391


commit 9145301b261bb66c13823302e313f5baeedb9cac
Author: Boris Schrijver <bschrij...@schubergphilis.com>
Date:   2016-02-01T14:57:26Z

Add iptables copnversion script.

Source: 
https://raw.githubusercontent.com/sl0/conv/master/iptables_converter.py

commit 21a2f3ea01f176825a2ae47ba05ffb1f2e840a9b
Author: Boris Schrijver <bschrij...@schubergphilis.com>
Date:   2016-02-01T14:58:27Z

Restore iptables at once using iptables-restore instead of calling iptables 
numerous times




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Display hostname the VPC router runs on

[borisroman]

Github user borisroman commented on the pull request:

https://github.com/apache/cloudstack/pull/1384#issuecomment-178064538
  
LGTM :+1: Based on screenshots and code-review

Already running in PROD at SBP.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9266: Make deleting static rou...

[borisroman]

Github user borisroman commented on the pull request:

https://github.com/apache/cloudstack/pull/1386#issuecomment-178064345
  
LGTM :+1: 

Already running in PROD at SBP. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9264: Make /32 static routes f...

[borisroman]

Github user borisroman commented on the pull request:

https://github.com/apache/cloudstack/pull/1383#issuecomment-178064659
  
LGTM :+1: Based on codereview

Already running in PROD at SBP.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Restore iptables at once using iptables-r...

[borisroman]

Github user borisroman commented on the pull request:

https://github.com/apache/cloudstack/pull/1389#issuecomment-178000474
  
Integration test results:

```
Test router internal advanced zone ... === TestName: 
test_02_router_internal_adv | Status : SUCCESS ===
ok
Test restart network ... === TestName: test_03_restart_network_cleanup | 
Status : SUCCESS ===
ok
Test router basic setup ... === TestName: test_05_router_basic | Status : 
SUCCESS ===
ok
Test router advanced setup ... === TestName: test_06_router_advanced | 
Status : SUCCESS ===
ok
Test stop router ... === TestName: test_07_stop_router | Status : SUCCESS 
===
ok
Test start router ... === TestName: test_08_start_router | Status : SUCCESS 
===
ok
Test reboot router ... === TestName: test_09_reboot_router | Status : 
SUCCESS ===
ok
Test reset virtual machine on reboot ... === TestName: 
test_01_reset_vm_on_reboot | Status : SUCCESS ===
ok
Test advanced zone virtual router ... === TestName: 
test_advZoneVirtualRouter | Status : SUCCESS ===
ok
Test Deploy Virtual Machine ... === TestName: test_deploy_vm | Status : 
SUCCESS ===
ok
Test Multiple Deploy Virtual Machine ... === TestName: 
test_deploy_vm_multiple | Status : SUCCESS ===
ok
Test Stop Virtual Machine ... === TestName: test_01_stop_vm | Status : 
SUCCESS ===
ok
Test Start Virtual Machine ... === TestName: test_02_start_vm | Status : 
SUCCESS ===
ok
Test Reboot Virtual Machine ... === TestName: test_03_reboot_vm | Status : 
SUCCESS ===
ok
Test destroy Virtual Machine ... === TestName: test_06_destroy_vm | Status 
: SUCCESS ===
ok
Test recover Virtual Machine ... === TestName: test_07_restore_vm | Status 
: SUCCESS ===
ok
Test migrate VM ... === TestName: test_08_migrate_vm | Status : SUCCESS ===
ok
Test destroy(expunge) Virtual Machine ... === TestName: test_09_expunge_vm 
| Status : SUCCESS ===
ok
Test to create service offering ... === TestName: 
test_01_create_service_offering | Status : SUCCESS ===
ok
Test to update existing service offering ... === TestName: 
test_02_edit_service_offering | Status : SUCCESS ===
ok
Test to delete service offering ... === TestName: 
test_03_delete_service_offering | Status : SUCCESS ===
ok
Test for delete account ... === TestName: test_delete_account | Status : 
SUCCESS ===
ok
Test for Associate/Disassociate public IP address for admin account ... === 
TestName: test_public_ip_admin_account | Status : SUCCESS ===
ok
Test for Associate/Disassociate public IP address for user account ... === 
TestName: test_public_ip_user_account | Status : SUCCESS ===
ok
Test for release public IP address ... === TestName: test_releaseIP | 
Status : SUCCESS ===
ok
Test create VPC offering ... === TestName: test_01_create_vpc_offering | 
Status : SUCCESS ===
ok
Test VPC offering without load balancing service ... === TestName: 
test_03_vpc_off_without_lb | Status : SUCCESS ===
ok
Test VPC offering without static NAT service ... === TestName: 
test_04_vpc_off_without_static_nat | Status : SUCCESS ===
ok
Test VPC offering without port forwarding service ... === TestName: 
test_05_vpc_off_without_pf | Status : SUCCESS ===
ok
Test VPC offering with invalid services ... === TestName: 
test_06_vpc_off_invalid_services | Status : SUCCESS ===
ok
Test update VPC offering ... === TestName: test_07_update_vpc_off | Status 
: SUCCESS ===
ok
Test list VPC offering ... === TestName: test_08_list_vpc_off | Status : 
SUCCESS ===
ok
test_09_create_redundant_vpc_offering 
(integration.component.test_vpc_offerings.TestVPCOffering) ... === TestName: 
test_09_create_redundant_vpc_offering | Status : SUCCESS ===
ok
Test start/stop of router after addition of one guest network ... === 
TestName: test_01_start_stop_router_after_addition_of_one_guest_network | 
Status : SUCCESS ===
ok
Test reboot of router after addition of one guest network ... === TestName: 
test_02_reboot_router_after_addition_of_one_guest_network | Status : SUCCESS ===
ok
Test to change service offering of router after addition of one guest 
network ... === TestName: 
test_04_chg_srv_off_router_after_addition_of_one_guest_network | Status : 
SUCCESS ===
ok
Test destroy of router after addition of one guest network ... === 
TestName: test_05_destroy_router_after_addition_of_one_guest_network | Status : 
SUCCESS ===
ok
Test to stop and start router after creation of VPC ... === TestName: 
test_01_stop_start_router_after_creating_vpc | Status : SUCCESS ===
ok
Test to reboot the router after creating a VPC ... === TestName: 
test_02_reboot_router_after_creating_vpc | Status : SUCCESS ===
ok
Tests to change service offering of the Router after ... === TestName: 
test_04_change_service_offerring_vpc

[GitHub] cloudstack pull request: Restore iptables at once using iptables-r...

[borisroman]

GitHub user borisroman opened a pull request:

https://github.com/apache/cloudstack/pull/1389

Restore iptables at once using iptables-restore instead of calling ip 
tables numerous times



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/borisroman/cloudstack 
vr-iptables-save-rebased-wip

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/1389.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1389


commit 5ea9d7e2c57dc319be7b2bc0eba0d91319a6b858
Author: Boris Schrijver <bschrij...@schubergphilis.com>
Date:   2016-01-19T10:57:05Z

Restore iptables at once using iptables-restore instead of calling iptables 
numerous times




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9256 add unique key for static...

[borisroman]

Github user borisroman commented on the pull request:

https://github.com/apache/cloudstack/pull/1364#issuecomment-174861340
  
LGTM :+1: 

Already running in production at SBP!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9245 - Cannot delete non-attac...

[borisroman]

Github user borisroman commented on the pull request:

https://github.com/apache/cloudstack/pull/1358#issuecomment-174492298
  
LGTM :+1: 

Based on integration tests and code-review.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9254: Make longer names displa...

[borisroman]

Github user borisroman commented on the pull request:

https://github.com/apache/cloudstack/pull/1362#issuecomment-174225635
  
Finally! :-)

LGTM :+1:  Based on code-review and screenshots!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: More VR performance!

[borisroman]

Github user borisroman commented on the pull request:

https://github.com/apache/cloudstack/pull/1356#issuecomment-173872641
  
@DaanHoogland It improves performance due to fact firewall rules are only 
created (in memory) once we expect a change. If for example a dhcp lease needs 
to be added, no firewall rules will be build or changed.

At first these were always executed:
```
-# Always run both CsAcl().process() methods
 -# They fill the base rules in config.fw[] 
 -acls = CsAcl('networkacl', config)
 -acls.process()
 -  
 -acls = CsAcl('firewallrules', config) 
 -acls.process()
 -  
 -fwd = CsForwardingRules("forwardingrules", config)
 -fwd.process() 
 -  
 -vpns = CsSite2SiteVpn("site2sitevpn", config) 
 -vpns.process()
 -  
 -rvpn = CsRemoteAccessVpn("remoteaccessvpn", config)   
 -rvpn.process()
 -  
 -lb = CsLoadBalancer("loadbalancer", config)   
 -lb.process()
```

Now they are only executed if we expect change to the firewall rules.

Less execution == more performance!

Hope that clears up! :-)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: More VR performance!

[borisroman]

GitHub user borisroman opened a pull request:

https://github.com/apache/cloudstack/pull/1356

More VR performance!



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/borisroman/cloudstack 4.7-vr-performance-wip

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/1356.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1356


commit 3eceb60f5ca8b86b3308243ae2905bbfbd54bc39
Author: Boris Schrijver <bschrij...@schubergphilis.com>
Date:   2016-01-20T12:34:09Z

More VR performance!




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9229: Autoscale policy creatio...

[borisroman]

Github user borisroman commented on the pull request:

https://github.com/apache/cloudstack/pull/1334#issuecomment-173364778
  
LGTM :+1: 

Based on code review and screenshot from remi


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9142 Migrate VM changes xmlDes...

[borisroman]

Github user borisroman commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1348#discussion_r50335474
  
--- Diff: 
plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/wrapper/LibvirtMigrateCommandWrapper.java
 ---
@@ -190,4 +196,28 @@ Use VIR_DOMAIN_XML_SECURE (value = 1) prior to v1.0.0.
 
 return new MigrateAnswer(command, result == null, result, null);
 }
-}
\ No newline at end of file
+
+/**
+ * This function assumes an qemu machine desription containing a 
single graphics element like
+ * 
+ *   
+ * 
+ * @param xmlDesc the qemu xml description
+ * @param source the ip address to migrate from
--- End diff --

not used?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9142 Migrate VM changes xmlDes...

[borisroman]

Github user borisroman commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1348#discussion_r50325672
  
--- Diff: 
plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/wrapper/LibvirtMigrateCommandWrapper.java
 ---
@@ -48,6 +49,9 @@
 @ResourceWrapper(handles =  MigrateCommand.class)
 public final class LibvirtMigrateCommandWrapper extends 
CommandWrapper<MigrateCommand, Answer, LibvirtComputingResource> {
 
+private static final String CONTENTS_WILDCARD = ".*";
+private static final String GRAPHICS_ELEM_END = "/graphics>";
--- End diff --

This doesn't look correct... ?

"<" missing?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9142 Migrate VM changes xmlDes...

[borisroman]

Github user borisroman commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1348#discussion_r50325617
  
--- Diff: 
plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/wrapper/LibvirtMigrateCommandWrapper.java
 ---
@@ -1,4 +1,5 @@
 //
+
--- End diff --

Why?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Enhance VR performance

[borisroman]

Github user borisroman commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1346#discussion_r50241366
  
--- Diff: systemvm/patches/debian/config/opt/cloud/bin/configure.py ---
@@ -901,79 +901,123 @@ def processStaticNatRule(self, rule):
 
 
 def main(argv):
+# The file we are currently processing, if it is "cmd_line.json" 
everything will be processed.
+process_file = argv[1]
+
+# process_file can be None, if so assume cmd_line.json
+if process_file is None:
+process_file = "cmd_line.json"
+
+# Track if changes need to be committed to NetFilter
+iptables_change = False
+
+# The "GLOBAL" Configuration object
 config = CsConfig()
+
 logging.basicConfig(filename=config.get_logger(),
 level=config.get_level(),
 format=config.get_format())
+
+# Load stored ip adresses from disk to CsConfig()
 config.set_address()
 
 logging.debug("Configuring ip addresses")
-# IP configuration
 config.address().compare()
 config.address().process()
 
-logging.debug("Configuring vmpassword")
-password = CsPassword("vmpassword", config)
-password.process()
+if process_file == "cmd_line.json" or process_file == 
"guest_network.json":
--- End diff --

Done!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: [FUTURE]CLOUDSTACK-8872: Replaced all occ...

[borisroman]

Github user borisroman commented on the pull request:

https://github.com/apache/cloudstack/pull/832#issuecomment-173184982
  
Most of them have already been resolved.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: [FUTURE]CLOUDSTACK-8872: Replaced all occ...

[borisroman]

Github user borisroman closed the pull request at:

https://github.com/apache/cloudstack/pull/832


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: [FUTURE]CLOUDSTACK-8907: POD Gateway opti...

[borisroman]

Github user borisroman closed the pull request at:

https://github.com/apache/cloudstack/pull/886


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: [FUTURE]CLOUDSTACK-8907: POD Gateway opti...

[borisroman]

Github user borisroman commented on the pull request:

https://github.com/apache/cloudstack/pull/886#issuecomment-173185222
  
When the network stack get's refactored this won't be necessary anymore.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8308: Adding automation testca...

[borisroman]

Github user borisroman commented on the pull request:

https://github.com/apache/cloudstack/pull/720#issuecomment-173186487
  
Been open for 3 months, closing.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8308: Adding automation testca...

[borisroman]

Github user borisroman closed the pull request at:

https://github.com/apache/cloudstack/pull/720


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9160: Remove unused folder(s)/...

[borisroman]

Github user borisroman closed the pull request at:

https://github.com/apache/cloudstack/pull/1238


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9237: Create LB Healthcheck is...

[borisroman]

Github user borisroman commented on the pull request:

https://github.com/apache/cloudstack/pull/1340#issuecomment-173184740
  
LGTM :+1: 

Reviewed code, and according to the screenshots it works.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9147: In hypervisor-plugin-kvm...

[borisroman]

Github user borisroman closed the pull request at:

https://github.com/apache/cloudstack/pull/1225


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9146: Refactor Hypervisor KVM ...

[borisroman]

Github user borisroman commented on the pull request:

https://github.com/apache/cloudstack/pull/1224#issuecomment-173185348
  
Conflicts, won't resolve them.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9146: Refactor Hypervisor KVM ...

[borisroman]

Github user borisroman closed the pull request at:

https://github.com/apache/cloudstack/pull/1224


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9147: In hypervisor-plugin-kvm...

[borisroman]

Github user borisroman commented on the pull request:

https://github.com/apache/cloudstack/pull/1225#issuecomment-173185402
  
Conflicts, won't resolve them.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Remove unused folder(s)/file(s); HypervDu...

[borisroman]

Github user borisroman commented on the pull request:

https://github.com/apache/cloudstack/pull/1237#issuecomment-173185763
  
No reviews, so closing.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Remove unused folder(s)/file(s); HypervDu...

[borisroman]

Github user borisroman closed the pull request at:

https://github.com/apache/cloudstack/pull/1237


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9158: Removed SLF4J, it's abun...

[borisroman]

Github user borisroman commented on the pull request:

https://github.com/apache/cloudstack/pull/1236#issuecomment-173185634
  
Closing because of preference to logback.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9158: Removed SLF4J, it's abun...

[borisroman]

Github user borisroman closed the pull request at:

https://github.com/apache/cloudstack/pull/1236


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9152: Remove unused folder(s)/...

[borisroman]

Github user borisroman commented on the pull request:

https://github.com/apache/cloudstack/pull/1232#issuecomment-173186549
  
Closing!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9152: Remove unused folder(s)/...

[borisroman]

Github user borisroman closed the pull request at:

https://github.com/apache/cloudstack/pull/1232


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9160: Remove unused folder(s)/...

[borisroman]

Github user borisroman commented on the pull request:

https://github.com/apache/cloudstack/pull/1238#issuecomment-173186580
  
Closing!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Enhance VR performance

[borisroman]

GitHub user borisroman opened a pull request:

https://github.com/apache/cloudstack/pull/1346

Enhance VR performance

Will post integration test results soon!

Ping @wilderrodrigues @remibergsma 



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/borisroman/cloudstack 4.7-vr-performance

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/1346.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1346


commit bd96a8e79f9aae3267c8870a34f8460147bcda92
Author: Boris Schrijver <bschrij...@schubergphilis.com>
Date:   2016-01-16T18:47:02Z

Enhance VR performance by selectively executing tasks instead of 
brute-forcing




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Implement a NSX API request execution cou...

[borisroman]

Github user borisroman commented on the pull request:

https://github.com/apache/cloudstack/pull/1294#issuecomment-172505055
  
LGTM :+1:

Did code review and ran the PR in beta


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Add Health Check Command to NSX plugin

[borisroman]

Github user borisroman commented on the pull request:

https://github.com/apache/cloudstack/pull/1293#issuecomment-172248684
  
LGTM :+1: 

Been running in beta for a couple of weeks now, no problems!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9222 Prevent cloud.log.1 filli...

[borisroman]

Github user borisroman commented on the pull request:

https://github.com/apache/cloudstack/pull/1329#issuecomment-172247093
  
LGTM :+1: 

delaycompress isn't usefull. The VR has limited space, so delaying the 
compression of the logfiles won't help!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9216: Fix DHCP lease removal l...

[borisroman]

Github user borisroman closed the pull request at:

https://github.com/apache/cloudstack/pull/1318


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9238: Increase URL fields to 2...

[borisroman]

Github user borisroman commented on the pull request:

https://github.com/apache/cloudstack/pull/1341#issuecomment-171681534
  
@wido @kevindierkx Why not use TEXT? Then we'll never have to worry again 
:-)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9220 Sort list of domains on D...

[borisroman]

Github user borisroman commented on the pull request:

https://github.com/apache/cloudstack/pull/1327#issuecomment-170505131
  
It's sorted! LGTM

![screen shot 2016-01-11 at 11 45 
06](https://cloud.githubusercontent.com/assets/5996146/12231567/d518d86e-b858-11e5-979e-fbdb3035a3f6.png)



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: NicProfileHelperImpl NullpointerException...

[borisroman]

GitHub user borisroman opened a pull request:

https://github.com/apache/cloudstack/pull/1328

NicProfileHelperImpl NullpointerException when ipVO is null

When a VPC has a private gateway, and one would like to restart the VPC 
with **cleanup** it would fail.

This PR adds a NullPointer check and verifies it with an integration test.

```
test_01_vpc_privategw_acl 
(integration.smoke.test_privategw_acl.TestPrivateGwACL) ... === TestName: 
test_01_vpc_privategw_acl | Status : SUCCESS ===
ok
test_02_vpc_privategw_static_routes 
(integration.smoke.test_privategw_acl.TestPrivateGwACL) ... === TestName: 
test_02_vpc_privategw_static_routes | Status : SUCCESS ===
ok
test_03_vpc_privategw_restart_vpc_cleanup 
(integration.smoke.test_privategw_acl.TestPrivateGwACL) ... === TestName: 
test_03_vpc_privategw_restart_vpc_cleanup | Status : SUCCESS ===
ok
test_04_rvpc_privategw_static_routes 
(integration.smoke.test_privategw_acl.TestPrivateGwACL) ... === TestName: 
test_04_rvpc_privategw_static_routes | Status : SUCCESS ===
ok

--
Ran 4 tests in 2945.055s

OK
```



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/borisroman/cloudstack 
nullpointer_nicprofilehelperimpl

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/1328.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1328


commit 78fbaf7d4da995c0cdb0ae84606e66f72c6cf289
Author: Boris Schrijver <bschrij...@schubergphilis.com>
Date:   2016-01-11T08:57:35Z

Nullpointer Exception in NicProfileHelperImpl

commit de11b7307c2058959918ebc0eb22a55705d177b9
Author: Boris Schrijver <bschrij...@schubergphilis.com>
Date:   2016-01-11T13:34:08Z

Add integration test for restartVPC with cleanup, and Private Gateway 
enabled.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Fix mariadb related listCapacity bug (CLO...

[borisroman]

Github user borisroman commented on the pull request:

https://github.com/apache/cloudstack/pull/1314#issuecomment-170050753
  
All integration tests look fine!

```
Check the password file in the Router VM ... === TestName: 
test_isolate_network_password_server | Status : SUCCESS ===
ok
Create a redundant VPC with two networks with two VMs in each network ... 
=== TestName: test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL | Status : 
SUCCESS ===
ok
Create a redundant VPC with two networks with two VMs in each network and 
check default routes ... === TestName: test_02_redundant_VPC_default_routes | 
Status : SUCCESS ===
ok
Create a redundant VPC with two networks with two VMs in each network ... 
=== TestName: 
test_03_create_redundant_VPC_1tier_2VMs_2IPs_2PF_ACL_reboot_routers | Status : 
SUCCESS ===
ok
Test iptables default INPUT/FORWARD policy on RouterVM ... === TestName: 
test_02_routervm_iptables_policies | Status : SUCCESS ===
ok
Test iptables default INPUT/FORWARD policies on VPC router ... === 
TestName: test_01_single_VPC_iptables_policies | Status : SUCCESS ===
ok
Test redundant router internals ... === TestName: 
test_01_isolate_network_FW_PF_default_routes_egress_true | Status : SUCCESS ===
ok
Test redundant router internals ... === TestName: 
test_02_isolate_network_FW_PF_default_routes_egress_false | Status : SUCCESS ===
ok
Test redundant router internals ... === TestName: 
test_01_RVR_Network_FW_PF_SSH_default_routes_egress_true | Status : SUCCESS ===
ok
Test redundant router internals ... === TestName: 
test_02_RVR_Network_FW_PF_SSH_default_routes_egress_false | Status : SUCCESS ===
ok
Test redundant router internals ... === TestName: 
test_03_RVR_Network_check_router_state | Status : SUCCESS ===
ok
Create a VPC with two networks with one VM in each network and test nics 
after destroy ... === TestName: test_01_VPC_nics_after_destroy | Status : 
SUCCESS ===
ok
Create a VPC with two networks with one VM in each network and test default 
routes ... === TestName: test_02_VPC_default_routes | Status : SUCCESS ===
ok
Check that the /etc/dhcphosts.txt doesn't contain duplicate IPs ... === 
TestName: test_router_dhcphosts | Status : SUCCESS ===
ok
Test to create Load balancing rule with source NAT ... === TestName: 
test_01_create_lb_rule_src_nat | Status : SUCCESS ===
ok
Test to create Load balancing rule with non source NAT ... === TestName: 
test_02_create_lb_rule_non_nat | Status : SUCCESS ===
ok
Test for assign & removing load balancing rule ... === TestName: 
test_assign_and_removal_lb | Status : SUCCESS ===
ok
Test create, assign, remove of an Internal LB with roundrobin http traffic 
to 3 vm's in a Single VPC ... === TestName: 
test_01_internallb_roundrobin_1VPC_3VM_HTTP_port80 | Status : SUCCESS ===
ok
Test create, assign, remove of an Internal LB with roundrobin http traffic 
to 3 vm's in a Redundant VPC ... === TestName: 
test_02_internallb_roundrobin_1RVPC_3VM_HTTP_port80 | Status : SUCCESS ===
ok
Test to verify access to loadbalancer haproxy admin stats page ... === 
TestName: test_03_vpc_internallb_haproxy_stats_on_all_interfaces | Status : 
SUCCESS ===
ok
Test to verify access to loadbalancer haproxy admin stats page ... === 
TestName: test_04_rvpc_internallb_haproxy_stats_on_all_interfaces | Status : 
SUCCESS ===
ok
Test SSVM Internals ... === TestName: test_03_ssvm_internals | Status : 
SUCCESS ===
ok
Test CPVM Internals ... === TestName: test_04_cpvm_internals | Status : 
SUCCESS ===
ok
Test stop SSVM ... === TestName: test_05_stop_ssvm | Status : SUCCESS ===
ok
Test stop CPVM ... === TestName: test_06_stop_cpvm | Status : SUCCESS ===
ok
Test reboot SSVM ... === TestName: test_07_reboot_ssvm | Status : SUCCESS 
===
ok
Test reboot CPVM ... === TestName: test_08_reboot_cpvm | Status : SUCCESS 
===
ok
Test destroy SSVM ... === TestName: test_09_destroy_ssvm | Status : SUCCESS 
===
ok
Test destroy CPVM ... === TestName: test_10_destroy_cpvm | Status : SUCCESS 
===
ok
Test Remote Access VPN in VPC ... === TestName: test_vpc_remote_access_vpn 
| Status : SUCCESS ===
ok
Test VPN in VPC ... === TestName: test_vpc_site2site_vpn | Status : SUCCESS 
===
ok
test_01_vpc_privategw_acl 
(integration.smoke.test_privategw_acl.TestPrivateGwACL) ... === TestName: 
test_01_vpc_privategw_acl | Status : SUCCESS ===
ok
test_02_vpc_privategw_static_routes 
(integration.smoke.test_privategw_acl.TestPrivateGwACL) ... === TestName: 
test_02_vpc_privategw_static_routes | Status : SUCCESS ===
ok
test_03_rvpc_privategw_static_routes 
(integration.smoke.test_privategw_acl.TestPrivateGwACL) ... === TestName: 
test_03_rvpc_privategw_static_routes | Status : SUCCESS ===
ok
Test for port forwarding on source

[GitHub] cloudstack pull request: CLOUDSTACK-9216: Fix DHCP lease removal l...

[borisroman]

GitHub user borisroman opened a pull request:

https://github.com/apache/cloudstack/pull/1318

CLOUDSTACK-9216: Fix DHCP lease removal logic on VR

It now releases all DHCP leases when requested.

Will post Integration test results once finished.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/borisroman/cloudstack CLOUDSTACK-9216

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/1318.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1318


commit f46640b22f5a72770389b89864492cb374ccb1de
Author: Boris Schrijver <bschrij...@schubergphilis.com>
Date:   2016-01-07T18:38:18Z

Fix DHCP lease removal logic on VR




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Fix mariadb related listCapacity bug (CLO...

[borisroman]

Github user borisroman commented on the pull request:

https://github.com/apache/cloudstack/pull/1314#issuecomment-169486361
  
@lttmtins I've ran the code! When I deployed a management server and open 
the UI it throws an error!

Will investigate tomorrow!

https://cloud.githubusercontent.com/assets/5996146/12157061/48131416-b4cf-11e5-9519-e9bd51224216.png;>



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: trailing commas in javascripts removed

[borisroman]

Github user borisroman commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1288#discussion_r48466763
  
--- Diff: ui/plugins/plugins.js ---
@@ -16,7 +16,7 @@
 // under the License.
 (function($, cloudStack) {
   cloudStack.plugins = [
-'quota',
-//'testPlugin'
+//'testPlugin',
--- End diff --

Why not remove it? It's already commented out...


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Map LDAP group to Cloudstack account

[borisroman]

Github user borisroman commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1285#discussion_r48488856
  
--- Diff: 
plugins/user-authenticators/ldap/src/org/apache/cloudstack/ldap/LdapAuthenticator.java
 ---
@@ -111,19 +114,27 @@ public LdapAuthenticator(final LdapManager 
ldapManager, final UserAccountDao use
 return new Pair<Boolean, ActionOnFailedAuthentication>(result, 
action);
 }
 
-private void enableUserInCloudStack(UserAccount user) {
-if(user != null && 
(user.getState().equalsIgnoreCase(Account.State.disabled.toString( {
+private void enableUserInCloudStack(final UserAccount user) {
+if (user != null && 
user.getState().equalsIgnoreCase(Account.State.disabled.toString())) {
 _accountManager.enableUser(user.getId());
 }
 }
 
-private void createCloudStackUserAccount(LdapUser user, long domainId, 
short accountType) {
-String username = user.getUsername();
-_accountManager.createUserAccount(username, "", 
user.getFirstname(), user.getLastname(), user.getEmail(), null, username, 
accountType, domainId, username, null,
-  UUID.randomUUID().toString(), 
UUID.randomUUID().toString(), User.Source.LDAP);
+private void createCloudStackUserAccount(final LdapUser user, final 
long domainId, final short accountType) {
+final String username = user.getUsername();
+final Account account = 
_accountManager.getActiveAccountByName(ldapGroupName, domainId);
+if (account == null) {
+s_logger.info("Account (" + ldapGroupName + ") for LDAP group 
does not exist. Creating account and user (" + username + ").");
+_accountManager.createUserAccount(username, "", 
user.getFirstname(), user.getLastname(), user.getEmail(), null, ldapGroupName, 
accountType, domainId,
+username, null, UUID.randomUUID().toString(), 
UUID.randomUUID().toString(), User.Source.LDAP);
+} else {
+s_logger.debug("Account (" + ldapGroupName + ") for LDAP group 
already exists not exist. Creating user (" + username + ").");
--- End diff --

@miguelaferreira The following seems a bit strange "for LDAP group already 
exists not exist"... Maybe something like this; "for LDAP group already exists, 
but the user doesn't exist"


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Map LDAP group to Cloudstack account

[borisroman]

Github user borisroman commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1285#discussion_r48498393
  
--- Diff: 
plugins/user-authenticators/ldap/src/org/apache/cloudstack/ldap/LdapAuthenticator.java
 ---
@@ -111,19 +114,27 @@ public LdapAuthenticator(final LdapManager 
ldapManager, final UserAccountDao use
 return new Pair<Boolean, ActionOnFailedAuthentication>(result, 
action);
 }
 
-private void enableUserInCloudStack(UserAccount user) {
-if(user != null && 
(user.getState().equalsIgnoreCase(Account.State.disabled.toString( {
+private void enableUserInCloudStack(final UserAccount user) {
+if (user != null && 
user.getState().equalsIgnoreCase(Account.State.disabled.toString())) {
 _accountManager.enableUser(user.getId());
 }
 }
 
-private void createCloudStackUserAccount(LdapUser user, long domainId, 
short accountType) {
-String username = user.getUsername();
-_accountManager.createUserAccount(username, "", 
user.getFirstname(), user.getLastname(), user.getEmail(), null, username, 
accountType, domainId, username, null,
-  UUID.randomUUID().toString(), 
UUID.randomUUID().toString(), User.Source.LDAP);
+private void createCloudStackUserAccount(final LdapUser user, final 
long domainId, final short accountType) {
+final String username = user.getUsername();
+final Account account = 
_accountManager.getActiveAccountByName(ldapGroupName, domainId);
+if (account == null) {
+s_logger.info("Account (" + ldapGroupName + ") for LDAP group 
does not exist. Creating account and user (" + username + ").");
+_accountManager.createUserAccount(username, "", 
user.getFirstname(), user.getLastname(), user.getEmail(), null, ldapGroupName, 
accountType, domainId,
+username, null, UUID.randomUUID().toString(), 
UUID.randomUUID().toString(), User.Source.LDAP);
+} else {
+s_logger.debug("Account (" + ldapGroupName + ") for LDAP group 
already exists not exist. Creating user (" + username + ").");
--- End diff --

NP


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Set version 4.7.1-SNAPSHOT in 4.7 branch

[borisroman]

Github user borisroman commented on the pull request:

https://github.com/apache/cloudstack/pull/1267#issuecomment-166411739
  
LGTM :+1: 

```
[INFO] 

[INFO] BUILD SUCCESS
[INFO] 

[INFO] Total time: 5:27.676s (Wall Clock)
[INFO] Finished at: Mon Dec 21 21:37:53 CET 2015
[INFO] Final Memory: 98M/808M
[INFO] 

```
```
INFO  [c.c.u.DatabaseUpgradeChecker] (main:null) (logid:) DB version = 
4.7.0 Code Version = 4.7.1-SNAPSHOT
INFO  [c.c.u.DatabaseUpgradeChecker] (main:null) (logid:) Database upgrade 
must be performed from 4.7.0 to 4.7.1-SNAPSHOT
INFO  [c.c.u.DatabaseUpgradeChecker] (main:null) (logid:) Cleaning upgrades 
because all management server are now at the same version
INFO  [c.c.u.DatabaseUpgradeChecker] (main:null) (logid:) Cleanup upgrade 
Upgrade470to471 to upgrade from 4.7.0-4.7.1 to 4.7.1
INFO  [o.a.c.s.l.CloudStackExtendedLifeCycle] (main:null) (logid:) 
Configuring CloudStack Components
```



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Show actual diff in commits after merge w...

[borisroman]

Github user borisroman commented on the pull request:

https://github.com/apache/cloudstack/pull/1227#issuecomment-164146356
  
Nice! LGTM :+1:


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: L10N update before 4.7.0 RC1

[borisroman]

Github user borisroman commented on the pull request:

https://github.com/apache/cloudstack/pull/1217#issuecomment-164177113
  
@milamberspace @remibergsma @DaanHoogland LGTM :+1:

Only did code review.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9151 - As a Developer I want t...

[borisroman]

Github user borisroman commented on the pull request:

https://github.com/apache/cloudstack/pull/1231#issuecomment-164200657
  
LGTM :+1: 

**Environment**
 - 2 KVM host on CentOS 7.1
 - 1 Management Server on CentOS 7.1
 - Agent + Common RPMs built from source

**Integration test suite 1**
```
nosetests --with-marvin --marvin-config=${marvinCfg} -s -a 
tags=advanced,required_hardware=true \
component/test_password_server.py \
smoke/test_vpc_redundant.py \
smoke/test_routers_iptables_default_policy.py \
smoke/test_routers_network_ops.py \
smoke/test_vpc_router_nics.py \
smoke/test_router_dhcphosts.py \
smoke/test_loadbalance.py \
smoke/test_internal_lb.py \
smoke/test_ssvm.py \
smoke/test_vpc_vpn.py \
smoke/test_privategw_acl.py \
smoke/test_network.py
```

**Result test suite 1**
```
Check the password file in the Router VM ... === TestName: 
test_isolate_network_password_server | Status : SUCCESS ===
ok
Create a redundant VPC with two networks with two VMs in each network ... 
=== TestName: test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL | Status : 
SUCCESS ===
ok
Create a redundant VPC with two networks with two VMs in each network and 
check default routes ... === TestName: test_02_redundant_VPC_default_routes | 
Status : SUCCESS ===
ok
Create a redundant VPC with two networks with two VMs in each network ... 
=== TestName: 
test_03_create_redundant_VPC_1tier_2VMs_2IPs_2PF_ACL_reboot_routers | Status : 
SUCCESS ===
ok
Test iptables default INPUT/FORWARD policy on RouterVM ... === TestName: 
test_02_routervm_iptables_policies | Status : SUCCESS ===
ok
Test iptables default INPUT/FORWARD policies on VPC router ... === 
TestName: test_01_single_VPC_iptables_policies | Status : SUCCESS ===
ok
Test redundant router internals ... === TestName: 
test_01_isolate_network_FW_PF_default_routes_egress_true | Status : SUCCESS ===
ok
Test redundant router internals ... === TestName: 
test_02_isolate_network_FW_PF_default_routes_egress_false | Status : SUCCESS ===
ok
Test redundant router internals ... === TestName: 
test_01_RVR_Network_FW_PF_SSH_default_routes_egress_true | Status : SUCCESS ===
ok
Test redundant router internals ... === TestName: 
test_02_RVR_Network_FW_PF_SSH_default_routes_egress_false | Status : SUCCESS ===
ok
Test redundant router internals ... === TestName: 
test_03_RVR_Network_check_router_state | Status : SUCCESS ===
ok
Create a VPC with two networks with one VM in each network and test nics 
after destroy ... === TestName: test_01_VPC_nics_after_destroy | Status : 
SUCCESS ===
ok
Create a VPC with two networks with one VM in each network and test default 
routes ... === TestName: test_02_VPC_default_routes | Status : SUCCESS ===
ok
Check that the /etc/dhcphosts.txt doesn't contain duplicate IPs ... === 
TestName: test_router_dhcphosts | Status : SUCCESS ===
ok
Test to create Load balancing rule with source NAT ... === TestName: 
test_01_create_lb_rule_src_nat | Status : SUCCESS ===
ok
Test to create Load balancing rule with non source NAT ... === TestName: 
test_02_create_lb_rule_non_nat | Status : SUCCESS ===
ok
Test for assign & removing load balancing rule ... === TestName: 
test_assign_and_removal_lb | Status : SUCCESS ===
ok
Test to verify access to loadbalancer haproxy admin stats page ... === 
TestName: test02_internallb_haproxy_stats_on_all_interfaces | Status : SUCCESS 
===
ok
Test create, assign, remove of an Internal LB with roundrobin http traffic 
to 3 vm's ... === TestName: test_01_internallb_roundrobin_1VPC_3VM_HTTP_port80 
| Status : SUCCESS ===
ok
Test SSVM Internals ... === TestName: test_03_ssvm_internals | Status : 
SUCCESS ===
ok
Test CPVM Internals ... === TestName: test_04_cpvm_internals | Status : 
SUCCESS ===
ok
Test stop SSVM ... === TestName: test_05_stop_ssvm | Status : SUCCESS ===
ok
Test stop CPVM ... === TestName: test_06_stop_cpvm | Status : SUCCESS ===
ok
Test reboot SSVM ... === TestName: test_07_reboot_ssvm | Status : SUCCESS 
===
ok
Test reboot CPVM ... === TestName: test_08_reboot_cpvm | Status : SUCCESS 
===
ok
Test destroy SSVM ... === TestName: test_09_destroy_ssvm | Status : SUCCESS 
===
ok
Test destroy CPVM ... === TestName: test_10_destroy_cpvm | Status : SUCCESS 
===
ok
Test Remote Access VPN in VPC ... === TestName: test_vpc_remote_access_vpn 
| Status : SUCCESS ===
ok
Test VPN in VPC ... === TestName: test_vpc_site2site_vpn | Status : SUCCESS 
===
ok
test_01_vpc_privategw_acl 
(integration.smoke.test_privategw_acl.TestPrivateGwACL) ... === TestName: 
test_01_vpc_privategw_acl | Status : SUCCESS ===
ok
test_02_vpc_privategw_static_ro

[GitHub] cloudstack pull request: CLOUDSTACK-4374 - As a Developer I want t...

[borisroman]

Github user borisroman commented on the pull request:

https://github.com/apache/cloudstack/pull/1222#issuecomment-164065917
  
LGTM :+1: 

Ran tests on Ubuntu 14.04

```Create a redundant VPC with two networks with two VMs in each network 
... === TestName: test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL | 
Status : SUCCESS ===
ok
Create a redundant VPC with two networks with two VMs in each network and 
check default routes ... === TestName: test_02_redundant_VPC_default_routes | 
Status : SUCCESS ===
ok
Create a redundant VPC with two networks with two VMs in each network ... 
=== TestName: 
test_03_create_redundant_VPC_1tier_2VMs_2IPs_2PF_ACL_reboot_routers | Status : 
SUCCESS ===
ok
Test iptables default INPUT/FORWARD policy on RouterVM ... === TestName: 
test_02_routervm_iptables_policies | Status : SUCCESS ===
ok
Test iptables default INPUT/FORWARD policies on VPC router ... === 
TestName: test_01_single_VPC_iptables_policies | Status : SUCCESS ===
ok
Test redundant router internals ... === TestName: 
test_01_isolate_network_FW_PF_default_routes_egress_true | Status : SUCCESS ===
ok
Test redundant router internals ... === TestName: 
test_02_isolate_network_FW_PF_default_routes_egress_false | Status : SUCCESS ===
ok
Test redundant router internals ... === TestName: 
test_01_RVR_Network_FW_PF_SSH_default_routes_egress_true | Status : SUCCESS ===
ok
Test redundant router internals ... === TestName: 
test_02_RVR_Network_FW_PF_SSH_default_routes_egress_false | Status : SUCCESS ===
ok
Test redundant router internals ... === TestName: 
test_03_RVR_Network_check_router_state | Status : SUCCESS ===
ok
Create a VPC with two networks with one VM in each network and test nics 
after destroy ... === TestName: test_01_VPC_nics_after_destroy | Status : 
SUCCESS ===
ok
Create a VPC with two networks with one VM in each network and test default 
routes ... === TestName: test_02_VPC_default_routes | Status : SUCCESS ===
ok
Check the password file in the Router VM ... === TestName: 
test_isolate_network_password_server | Status : SUCCESS ===
ok
Check that the /etc/dhcphosts.txt doesn't contain duplicate IPs ... === 
TestName: test_router_dhcphosts | Status : SUCCESS ===
ok
Test to create Load balancing rule with source NAT ... === TestName: 
test_01_create_lb_rule_src_nat | Status : SUCCESS ===
ok
Test to create Load balancing rule with non source NAT ... === TestName: 
test_02_create_lb_rule_non_nat | Status : SUCCESS ===
ok
Test for assign & removing load balancing rule ... === TestName: 
test_assign_and_removal_lb | Status : SUCCESS ===
ok
Test to verify access to loadbalancer haproxy admin stats page ... === 
TestName: test02_internallb_haproxy_stats_on_all_interfaces | Status : SUCCESS 
===
ok
Test create, assign, remove of an Internal LB with roundrobin http traffic 
to 3 vm's ... === TestName: test_01_internallb_roundrobin_1VPC_3VM_HTTP_port80 
| Status : SUCCESS ===
ok
Test SSVM Internals ... === TestName: test_03_ssvm_internals | Status : 
SUCCESS ===
ok
Test CPVM Internals ... === TestName: test_04_cpvm_internals | Status : 
SUCCESS ===
ok
Test stop SSVM ... === TestName: test_05_stop_ssvm | Status : SUCCESS ===
ok
Test stop CPVM ... === TestName: test_06_stop_cpvm | Status : SUCCESS ===
ok
Test reboot SSVM ... === TestName: test_07_reboot_ssvm | Status : SUCCESS 
===
ok
Test reboot CPVM ... === TestName: test_08_reboot_cpvm | Status : SUCCESS 
===
ok
Test destroy SSVM ... === TestName: test_09_destroy_ssvm | Status : SUCCESS 
===
ok
Test destroy CPVM ... === TestName: test_10_destroy_cpvm | Status : SUCCESS 
===
ok
Test Remote Access VPN in VPC ... === TestName: test_vpc_remote_access_vpn 
| Status : SUCCESS ===
ok
Test VPN in VPC ... === TestName: test_vpc_site2site_vpn | Status : SUCCESS 
===
ok
Test for port forwarding on source NAT ... === TestName: 
test_01_port_fwd_on_src_nat | Status : SUCCESS ===
ok
Test for port forwarding on non source NAT ... === TestName: 
test_02_port_fwd_on_non_src_nat | Status : SUCCESS ===
ok
Test for reboot router ... === TestName: test_reboot_router | Status : 
SUCCESS ===
ok
Test for Router rules for network rules on acquired public IP ... === 
TestName: test_network_rules_acquired_public_ip_1_static_nat_rule | Status : 
SUCCESS ===
ok
Test for Router rules for network rules on acquired public IP ... === 
TestName: test_network_rules_acquired_public_ip_2_nat_rule | Status : SUCCESS 
===
ok
Test for Router rules for network rules on acquired public IP ... === 
TestName: test_network_rules_acquired_public_ip_3_Load_Balancer_Rule | Status : 
SUCCESS ===
ok

--
Ran 35 tests in 18635.

[GitHub] cloudstack pull request: CLOUDSTACK-9146: Refactor Hypervisor KVM ...

[borisroman]

GitHub user borisroman opened a pull request:

https://github.com/apache/cloudstack/pull/1224

CLOUDSTACK-9146: Refactor Hypervisor KVM into default Maven directory 
structure.

Ping @wilderrodrigues @wido @remibergsma @miguelaferreira 

Refactored the `Apache CloudStack Plugin - Hypervisor KVM` to the default 
Maven directory structure. Integration tests running now.

```
[INFO] 

[INFO] Reactor Summary:
[INFO] 
[INFO] Apache CloudStack Developer Tools - Checkstyle Configuration  
SUCCESS [1.130s]
[INFO] Apache CloudStack . SUCCESS [0.952s]
[INFO] Apache CloudStack Maven Conventions Parent  SUCCESS [0.493s]
[INFO] Apache CloudStack Framework - Managed Context . SUCCESS [2.206s]
[INFO] Apache CloudStack Utils ... SUCCESS [14.631s]
[INFO] Apache CloudStack Framework ... SUCCESS [0.041s]
[INFO] Apache CloudStack Framework - Event Notification .. SUCCESS [5.132s]
[INFO] Apache CloudStack Framework - Configuration ... SUCCESS [2.746s]
[INFO] Apache CloudStack API . SUCCESS [9.245s]
[INFO] Apache CloudStack Framework - REST  SUCCESS [1.808s]
[INFO] Apache CloudStack Framework - IPC . SUCCESS [2.284s]
[INFO] Apache CloudStack Cloud Engine  SUCCESS [0.021s]
[INFO] Apache CloudStack Cloud Engine API  SUCCESS [2.289s]
[INFO] Apache CloudStack Framework - Security  SUCCESS [1.057s]
[INFO] Apache CloudStack Core  SUCCESS [12.221s]
[INFO] Apache CloudStack Agents .. SUCCESS [3.892s]
[INFO] Apache CloudStack Framework - Clustering .. SUCCESS [3.063s]
[INFO] Apache CloudStack Framework - Event Notification .. SUCCESS [1.159s]
[INFO] Apache CloudStack Cloud Engine Schema Component ... SUCCESS [12.131s]
[INFO] Apache CloudStack Framework - Jobs  SUCCESS [3.483s]
[INFO] Apache CloudStack Cloud Engine Internal Components API  SUCCESS 
[2.743s]
[INFO] Apache CloudStack Server .. SUCCESS [43.936s]
[INFO] Apache CloudStack Framework - Quota ... SUCCESS [3.422s]
[INFO] Apache CloudStack Usage Server  SUCCESS [4.145s]
[INFO] Apache CloudStack Cloud Engine Orchestration Component  SUCCESS 
[4.695s]
[INFO] Apache CloudStack Cloud Services .. SUCCESS [0.048s]
[INFO] Apache CloudStack Secondary Storage ... SUCCESS [0.248s]
[INFO] Apache CloudStack Secondary Storage Service ... SUCCESS [2.592s]
[INFO] Apache CloudStack Engine Storage Component  SUCCESS [3.076s]
[INFO] Apache CloudStack Engine Storage Volume Component . SUCCESS [2.100s]
[INFO] Apache CloudStack Engine Storage Image Component .. SUCCESS [1.396s]
[INFO] Apache CloudStack Engine Storage Data Motion Component  SUCCESS 
[1.213s]
[INFO] Apache CloudStack Engine Storage Cache Component .. SUCCESS [1.349s]
[INFO] Apache CloudStack Engine Storage Snapshot Component  SUCCESS [4.430s]
[INFO] Apache CloudStack Cloud Engine API  SUCCESS [1.112s]
[INFO] Apache CloudStack Cloud Engine Service  SUCCESS [5.387s]
[INFO] Apache CloudStack Plugin POM .. SUCCESS [0.468s]
[INFO] Apache CloudStack Plugin - API Rate Limit . SUCCESS [7.466s]
[INFO] Apache CloudStack Plugin - Storage Volume default provider  SUCCESS 
[3.317s]
[INFO] Apache CloudStack Plugin - Storage Volume SolidFire Provider  
SUCCESS [4.679s]
[INFO] Apache CloudStack Plugin - API SolidFire .. SUCCESS [1.659s]
[INFO] Apache CloudStack Plugin - API Discovery .. SUCCESS [2.690s]
[INFO] Apache CloudStack Plugin - ACL Static Role Based .. SUCCESS [0.940s]
[INFO] Apache CloudStack Plugin - Host Anti-Affinity Processor  SUCCESS 
[1.077s]
[INFO] Apache CloudStack Plugin - Explicit Dedication Processor  SUCCESS 
[1.164s]
[INFO] Apache CloudStack Plugin - User Concentrated Pod Deployment Planner  
SUCCESS [0.863s]
[INFO] Apache CloudStack Plugin - User Dispersing Deployment Planner  
SUCCESS [0.983s]
[INFO] Apache CloudStack Plugin - Implicit Dedication Planner  SUCCESS 
[3.363s]
[INFO] Apache CloudStack Plugin - Skip Heurestics Planner  SUCCESS [1.032s]
[INFO] Apache CloudStack Plugin - Host Allocator Random .. SUCCESS [1.045s]
[INFO] Apache CloudStack Plugin - Dedicated Resources  SUCCESS [3.140s]
[INFO] Apache CloudStack Plugin - Hypervisor OracleVM  SUCCESS [1.455s]
[INFO] Apache CloudStack Plugin - Open vSwitch ... SUCCESS [1.977s]
[INFO] Apache CloudStack Plugin - Hypervisor XenServer ... SUCCESS [19.840s]
[INFO] Apache CloudStack Plugin - Hypervisor

[GitHub] cloudstack pull request: CLOUDSTACK-9123 - As a Developer I want t...

[borisroman]

Github user borisroman commented on the pull request:

https://github.com/apache/cloudstack/pull/1204#issuecomment-163536301
  
@wilderrodrigues @remibergsma I could only verify for KVM. 

Ran tests on Ubuntu 14.04 management/hypervisor.

```
Test to verify access to loadbalancer haproxy admin stats page ... === 
TestName: test02_internallb_haproxy_stats_on_all_interfaces | Status : SUCCESS 
===
ok
Test create, assign, remove of an Internal LB with roundrobin http traffic 
to 3 vm's ... === TestName: test_01_internallb_roundrobin_1VPC_3VM_HTTP_port80 
| Status : SUCCESS ===
ok

--
Ran 2 tests in 2532.875s
```

LGTM :+1: 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: ui/quota: Make the quota UI plugin icon g...

[borisroman]

Github user borisroman commented on the pull request:

https://github.com/apache/cloudstack/pull/1208#issuecomment-163568069
  
@wilderrodrigues @remibergsma @DaanHoogland LGTM :+1: 

Better styling this way.

No unit or integration tests run. Though in this case I don't think it's 
necessary.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9120 - As a Developer I want t...

[borisroman]

Github user borisroman commented on the pull request:

https://github.com/apache/cloudstack/pull/1195#issuecomment-163229139
  
@wilderrodrigues @remibergsma LGTM :+1: 

```Create a redundant VPC with two networks with two VMs in each network 
... === TestName: test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL | 
Status : SUCCESS ===
ok
Create a redundant VPC with two networks with two VMs in each network and 
check default routes ... === TestName: test_02_redundant_VPC_default_routes | 
Status : SUCCESS ===
ok
Create a redundant VPC with two networks with two VMs in each network ... 
=== TestName: 
test_03_create_redundant_VPC_1tier_2VMs_2IPs_2PF_ACL_reboot_routers | Status : 
SUCCESS ===
ok
Create a VPC with two networks with one VM in each network and test nics 
after destroy ... === TestName: test_01_VPC_nics_after_destroy | Status : 
SUCCESS ===
ok
Create a VPC with two networks with one VM in each network and test default 
routes ... === TestName: test_02_VPC_default_routes | Status : SUCCESS ===
ok
Test redundant router internals ... === TestName: 
test_01_isolate_network_FW_PF_default_routes_egress_true | Status : SUCCESS ===
ok
Test redundant router internals ... === TestName: 
test_02_isolate_network_FW_PF_default_routes_egress_false | Status : SUCCESS ===
ok
Test redundant router internals ... === TestName: 
test_01_RVR_Network_FW_PF_SSH_default_routes_egress_true | Status : SUCCESS ===
ok
Test redundant router internals ... === TestName: 
test_02_RVR_Network_FW_PF_SSH_default_routes_egress_false | Status : SUCCESS ===
ok
Test redundant router internals ... === TestName: 
test_03_RVR_Network_check_router_state | Status : SUCCESS ===
ok
Test iptables default INPUT/FORWARD policy on RouterVM ... === TestName: 
test_02_routervm_iptables_policies | Status : SUCCESS ===
ok
Test iptables default INPUT/FORWARD policies on VPC router ... === 
TestName: test_01_single_VPC_iptables_policies | Status : SUCCESS ===
ok
Check that the /etc/dhcphosts.txt doesn't contain duplicate IPs ... === 
TestName: test_router_dhcphosts | Status : SUCCESS ===
ok

--
Ran 13 tests in 11590.324s
```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9118 - As a Developer I want t...

[borisroman]

Github user borisroman commented on the pull request:

https://github.com/apache/cloudstack/pull/1189#issuecomment-162941648
  
Hi @wilderrodrigues,

I tested it just now! Looking good! Ran against Ubuntu 14.04 KVM 
management/hypervisor.

```
Test redundant router internals ... === TestName: 
test_01_isolate_network_FW_PF_default_routes_egress_true | Status : SUCCESS ===
ok
Test redundant router internals ... === TestName: 
test_02_isolate_network_FW_PF_default_routes_egress_false | Status : SUCCESS ===
ok
Test redundant router internals ... === TestName: 
test_01_RVR_Network_FW_PF_SSH_default_routes_egress_true | Status : SUCCESS ===
ok
Test redundant router internals ... === TestName: 
test_02_RVR_Network_FW_PF_SSH_default_routes_egress_false | Status : SUCCESS ===
ok
Test redundant router internals ... === TestName: 
test_03_RVR_Network_check_router_state | Status : SUCCESS ===
ok

--
Ran 5 tests in 2569.926s
```

LGTM :+1: 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack-docs-rn pull request: fix pre 4.5 upgrade instruction

[borisroman]

Github user borisroman commented on a diff in the pull request:

https://github.com/apache/cloudstack-docs-rn/pull/26#discussion_r45843949
  
--- Diff: source/global.rst ---
@@ -28,7 +28,7 @@
 .. |sysvm64-url-ovm|replace:: 
http://cloudstack.apt-get.eu/systemvm/4.6/systemvm64template-4.6.0-ovm.raw.bz2
 
 .. Version specific: 4.3 systemvm template URL
--- End diff --

Should this also be 4.5?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Debian/Ubuntu packaging issues

[borisroman]

Github user borisroman commented on the pull request:

https://github.com/apache/cloudstack/pull/1105#issuecomment-158918940
  
Hi @bhaisaab, what do you mean with "fix the scripts in src paths" ? Regards


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Removed the PlannerBase class because it ...

[borisroman]

Github user borisroman commented on the pull request:

https://github.com/apache/cloudstack/pull/1108#issuecomment-158981153
  
I agree with @DaanHoogland, less is more! Thanks for your contribution. 
I'll run integration tests on it to show nothing breaks.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Debian/Ubuntu packaging issues

[borisroman]

Github user borisroman commented on the pull request:

https://github.com/apache/cloudstack/pull/1105#issuecomment-158980731
  
@bhaisaab Ah, i've already looked them up, and in fact, in the git repo, 
they have the +x flag. So during the install, they have that flagged stripped...


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Debian/Ubuntu packaging issues

[borisroman]

GitHub user borisroman opened a pull request:

https://github.com/apache/cloudstack/pull/1105

Debian/Ubuntu packaging issues

See individual issues.

Before:
```
root@acs46:~# ls -la /var/lib/cloudstack
total 16
drwxr-xr-x  4 root root  4096 Nov 23 00:20 .
drwxr-xr-x 46 root root  4096 Nov 23 00:21 ..
drwxrwx---  2 root cloud 4096 Nov 17 01:15 management
drwxr-xr-x  2 root root  4096 Nov 17 01:15 mnt
```
```
root@acs46:~# ls -la 
/usr/share/cloudstack-management/webapps/client/WEB-INF/classes/scripts/storage/secondary/
total 152
drwxr-xr-x 2 root root  4096 Nov 23 00:20 .
drwxr-xr-x 4 root root  4096 Nov 23 00:20 ..
-rw-r--r-- 1 root root 10092 Nov 17 01:15 cloud-install-sys-tmplt
-rw-r--r-- 1 root root 10591 Nov 17 01:15 cloud-install-sys-tmplt.py
-rw-r--r-- 1 root root 11254 Nov 23 00:20 cloud-install-sys-tmplt.pyc
-rw-r--r-- 1 root root  2362 Nov 17 01:15 
create_privatetemplate_from_snapshot_xen.sh
-rw-r--r-- 1 root root  5446 Nov 17 01:15 createtmplt.sh
-rw-r--r-- 1 root root  5388 Nov 17 01:15 createvolume.sh
-rw-r--r-- 1 root root  2532 Nov 17 01:15 installIso.sh
-rw-r--r-- 1 root root  1622 Nov 17 01:15 listvmtmplt.sh
-rw-r--r-- 1 root root  1621 Nov 17 01:15 listvolume.sh
-rw-r--r-- 1 root root 75712 Nov 17 01:15 swift
```

After:
```
root@acs46:~# ls -la /var/lib/cloudstack
total 16
drwxr-xr-x  4 cloud cloud 4096 Nov 23 00:51 .
drwxr-xr-x 46 root  root  4096 Nov 23 00:53 ..
drwxrwx---  2 cloud cloud 4096 Nov 23 00:33 management
drwxr-xr-x  2 cloud cloud 4096 Nov 23 00:33 mnt
```
```
root@acs46:~# ls -la 
/usr/share/cloudstack-management/webapps/client/WEB-INF/classes/scripts/storage/secondary/
total 152
drwxr-xr-x 2 root root  4096 Nov 23 00:53 .
drwxr-xr-x 4 root root  4096 Nov 23 00:53 ..
-rwxr-xr-x 1 root root 10092 Nov 23 00:33 cloud-install-sys-tmplt
-rwxr-xr-x 1 root root 10591 Nov 23 00:33 cloud-install-sys-tmplt.py
-rwxr-xr-x 1 root root 11254 Nov 23 00:53 cloud-install-sys-tmplt.pyc
-rwxr-xr-x 1 root root  2362 Nov 23 00:33 
create_privatetemplate_from_snapshot_xen.sh
-rwxr-xr-x 1 root root  5446 Nov 23 00:33 createtmplt.sh
-rwxr-xr-x 1 root root  5388 Nov 23 00:33 createvolume.sh
-rwxr-xr-x 1 root root  2532 Nov 23 00:33 installIso.sh
-rwxr-xr-x 1 root root  1622 Nov 23 00:33 listvmtmplt.sh
-rwxr-xr-x 1 root root  1621 Nov 23 00:33 listvolume.sh
-rwxr-xr-x 1 root root 75712 Nov 23 00:33 swift
```

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/borisroman/cloudstack packagingIssues

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/1105.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1105


commit 1e73f667c93fe7bc7a765f205e1eb62fb778f99c
Author: Boris Schrijver <bo...@pcextreme.nl>
Date:   2015-11-22T23:05:53Z

CLOUDSTACK-9076: Changed ownership of directory /var/lib/cloudstack to 
cloud.

commit e2fc270480916901b2bfd4f4bab376a6008f9f57
Author: Boris Schrijver <bo...@pcextreme.nl>
Date:   2015-11-22T23:07:29Z

CLOUDSTACK-9078: Gave scripts executable permissions.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9076: Changed ownership of dir...

[borisroman]

Github user borisroman closed the pull request at:

https://github.com/apache/cloudstack/pull/1095


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9062: Improve S3 implementatio...

[borisroman]

Github user borisroman commented on the pull request:

https://github.com/apache/cloudstack/pull/1083#issuecomment-158344376
  
@remibergsma Of course I tested manually! Nice Jenkins Job btw ;)

I see three LGTM's, two of which are based on code review, one on running 
integration tests (which showed nothing broke). I tested the changes in a 
physical setup, with S3 storage facilities. It does the same as before, so the 
refactor went well.

Do we merge, or wait for someone else to test? @wido @remibergsma 
@wilderrodrigues 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9067 - As I developer I want t...

[borisroman]

Github user borisroman commented on the pull request:

https://github.com/apache/cloudstack/pull/1084#issuecomment-158017282
  
@wilderrodrigues LGTM :+1: 

Always in support of removing old/dead code! :)

Testing:

CentOS 7.1 Setup Managment/Hypervisor

```
nosetests --with-marvin 
--marvin-config=/data/shared/marvin/mct-zone1-kvm1-ISOLATED.cfg -s -a 
tags=advanced,required_hardware=true component/test_vpc_redundant.py 
component/test_routers_iptables_default_policy.py 
component/test_routers_network_ops.py component/test_vpc_router_nics.py 
component/test_password_server.py component/test_router_dhcphosts.py 
smoke/test_loadbalance.py smoke/test_internal_lb.py smoke/test_ssvm.py 
smoke/test_vpc_vpn.py smoke/test_network.py
```
```
Create a redundant VPC with two networks with two VMs in each network ... 
=== TestName: test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL | Status : 
SUCCESS ===
ok
Create a redundant VPC with two networks with two VMs in each network and 
check default routes ... === TestName: test_02_redundant_VPC_default_routes | 
Status : SUCCESS ===
ok
Test iptables default INPUT/FORWARD policy on RouterVM ... === TestName: 
test_02_routervm_iptables_policies | Status : SUCCESS ===
ok
Test iptables default INPUT/FORWARD policies on VPC router ... === 
TestName: test_01_single_VPC_iptables_policies | Status : SUCCESS ===
ok
Test redundant router internals ... === TestName: 
test_01_isolate_network_FW_PF_default_routes_egress_true | Status : SUCCESS ===
ok
Test redundant router internals ... === TestName: 
test_02_isolate_network_FW_PF_default_routes_egress_false | Status : SUCCESS ===
ok
Test redundant router internals ... === TestName: 
test_01_RVR_Network_FW_PF_SSH_default_routes_egress_true | Status : SUCCESS ===
ok
Test redundant router internals ... === TestName: 
test_02_RVR_Network_FW_PF_SSH_default_routes_egress_false | Status : SUCCESS ===
ok
Create a VPC with two networks with one VM in each network and test nics 
after destroy ... === TestName: test_01_VPC_nics_after_destroy | Status : 
SUCCESS ===
ok
Create a VPC with two networks with one VM in each network and test default 
routes ... === TestName: test_02_VPC_default_routes | Status : SUCCESS ===
ok
Check the password file in the Router VM ... === TestName: 
test_isolate_network_password_server | Status : SUCCESS ===
ok
Check that the /etc/dhcphosts.txt doesn't contain duplicate IPs ... === 
TestName: test_router_dhcphosts | Status : SUCCESS ===
ok
Test to create Load balancing rule with source NAT ... === TestName: 
test_01_create_lb_rule_src_nat | Status : SUCCESS ===
ok
Test to create Load balancing rule with non source NAT ... === TestName: 
test_02_create_lb_rule_non_nat | Status : SUCCESS ===
ok
Test for assign & removing load balancing rule ... === TestName: 
test_assign_and_removal_lb | Status : SUCCESS ===
ok
Test to verify access to loadbalancer haproxy admin stats page ... === 
TestName: test02_internallb_haproxy_stats_on_all_interfaces | Status : SUCCESS 
===
ok
Test create, assign, remove of an Internal LB with roundrobin http traffic 
to 3 vm's ... === TestName: test_01_internallb_roundrobin_1VPC_3VM_HTTP_port80 
| Status : SUCCESS ===
ok
Test SSVM Internals ... === TestName: test_03_ssvm_internals | Status : 
SUCCESS ===
ok
Test CPVM Internals ... === TestName: test_04_cpvm_internals | Status : 
SUCCESS ===
ok
Test stop SSVM ... === TestName: test_05_stop_ssvm | Status : SUCCESS ===
ok
Test stop CPVM ... === TestName: test_06_stop_cpvm | Status : SUCCESS ===
ok
Test reboot SSVM ... === TestName: test_07_reboot_ssvm | Status : SUCCESS 
===
ok
Test reboot CPVM ... === TestName: test_08_reboot_cpvm | Status : SUCCESS 
===
ok
Test destroy SSVM ... === TestName: test_09_destroy_ssvm | Status : SUCCESS 
===
ok
Test destroy CPVM ... === TestName: test_10_destroy_cpvm | Status : SUCCESS 
===
ok
Test Remote Access VPN in VPC ... === TestName: test_vpc_remote_access_vpn 
| Status : SUCCESS ===
ok
Test VPN in VPC ... === TestName: test_vpc_site2site_vpn | Status : SUCCESS 
===
ok
Test for port forwarding on source NAT ... === TestName: 
test_01_port_fwd_on_src_nat | Status : SUCCESS ===
ok
Test for port forwarding on non source NAT ... === TestName: 
test_02_port_fwd_on_non_src_nat | Status : SUCCESS ===
ok
Test for reboot router ... === TestName: test_reboot_router | Status : 
SUCCESS ===
ok
Test for Router rules for network rules on acquired public IP ... === 
TestName: test_network_rules_acquired_public_ip_1_static_nat_rule | Status : 
SUCCESS ===
ok
Test for Router rules for network rules on acquired public IP ... === 
TestName: test_network_rules_acquired_public_ip_2_nat_rule | Status : SUCCESS 
===
  

[GitHub] cloudstack pull request: CLOUDSTACK-9067 - As I developer I want t...

[borisroman]

Github user borisroman commented on the pull request:

https://github.com/apache/cloudstack/pull/1084#issuecomment-158020779
  
@jayapalu That's we're git's versioning system comes into play. We want to 
keep the current working directory as clean as possible. Meaning, without 
unused/dead code. If you want to compare how it was, use the history that git 
provides.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Metrics views for CloudStack UI

[borisroman]

Github user borisroman commented on the pull request:

https://github.com/apache/cloudstack/pull/1038#issuecomment-158021643
  
@remibergsma Agree.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9076: Changed ownership of dir...

[borisroman]

GitHub user borisroman opened a pull request:

https://github.com/apache/cloudstack/pull/1095

CLOUDSTACK-9076: Changed ownership of directory /var/lib/cloudstack to 
cloud.

Now the management server can create directories inside this folder.

It's a packaging issue. Testing can be manually done by verifying the owner 
of the /var/lib/cloudstack directory.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/borisroman/cloudstack 4.6

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/1095.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1095


commit f2a3f47db029ca2ee8414829cb685df154efe0bd
Author: Boris Schrijver <bo...@pcextreme.nl>
Date:   2015-11-19T19:18:49Z

CLOUDSTACK-9076: Changed ownership of directory /var/lib/cloudstack to 
cloud.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: [4.6.1] CLOUDSTACK-9015 - Redundant VPC V...

[borisroman]

Github user borisroman commented on the pull request:

https://github.com/apache/cloudstack/pull/1070#issuecomment-158036108
  
@miguelaferreira @remibergsma @wilderrodrigues  LGTM :+1: 

```
nosetests --with-marvin 
--marvin-config=/data/shared/marvin/mct-zone1-kvm1-ISOLATED.cfg -s -a 
tags=advanced,required_hardware=true component/test_vpc_redundant.py
```
```
Create a redundant VPC with two networks with two VMs in each network ... 
=== TestName: test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL | Status : 
SUCCESS ===
ok
Create a redundant VPC with two networks with two VMs in each network and 
check default routes ... === TestName: test_02_redundant_VPC_default_routes | 
Status : SUCCESS ===
ok
Create a redundant VPC with two networks with two VMs in each network ... 
=== TestName: 
test_03_create_redundant_VPC_1tier_2VMs_2IPs_2PF_ACL_reboot_routers | Status : 
SUCCESS ===
ok

--
Ran 3 tests in 3522.654s

OK
```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9062: Improve S3 implementatio...

[borisroman]

Github user borisroman commented on the pull request:

https://github.com/apache/cloudstack/pull/1083#issuecomment-158062783
  
@wilderrodrigues Fixed your comments, refactoring is for the next round ;)



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9062: Improve S3 implementatio...

[borisroman]

Github user borisroman commented on the pull request:

https://github.com/apache/cloudstack/pull/1083#issuecomment-157697285
  
@DaanHoogland You're right. Forgot to remove it in my last iteration. 
Thanks!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9062: Improve S3 implementatio...

[borisroman]

Github user borisroman commented on the pull request:

https://github.com/apache/cloudstack/pull/1083#issuecomment-157551229
  
Ping @wido @remibergsma @wilderrodrigues @karuturi


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9062: Improve S3 implementatio...

[borisroman]

GitHub user borisroman opened a pull request:

https://github.com/apache/cloudstack/pull/1083

CLOUDSTACK-9062: Improve S3 implementation.

The S3 implementation is far from finished, this commit focuses on the 
bases.

 - Upgrade AWS SDK to latest version.
 - Rewrite S3 Template downloader.
 - Rewrite S3Utils utility class.
 - Improve addImageStoreS3 API command.
 - Split various classes for convenience.
 - Various minor improvements and code optimizations.

A side effect of the new AWS SDK is that it, by default, uses the V4 
signature. Therefore I added an option to specify the Signer, so it stays 
compatible with previous versions.

Please review thoroughly, both code inspection and (automated) integration 
tests. Currently no integration tests are available specifically for S3. 
Therefore the implementation is needed to be tested manually, for now...

What I tested:
 - Greenfield install -> will download latest systemvm template 
automatically to S3.
 - Upload a template/iso
 - Download a template/iso
- Restart of management server -> list available templates -> doesn't 
download them again if available.



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/borisroman/cloudstack CLOUDSTACK-9062

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/1083.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1083


commit 8ca0d0730a5739a209dbf7f138ed5e5c482783d8
Author: Boris Schrijver <bo...@pcextreme.nl>
Date:   2015-11-13T01:19:24Z

CLOUDSTACK-9062: Improve S3 implementation.

The S3 implementation is far from finished, this commit focusses on the 
bases.

 - Upgrade AWS SDK to latest version.
 - Rewrite S3 Template downloader.
 - Rewrite S3Utils utility class.
 - Improve addImageStoreS3 API command.
 - Split various classes for convenience.
 - Various minor improvements and code optimalisations.

A side effect of the new AWS SDK is that it, by default, uses the V4 
signature. Therefore I added an option to specify the Signer, so it stays 
compatible with previous versions.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9050 Virtual router should onl...

[borisroman]

Github user borisroman commented on the pull request:

https://github.com/apache/cloudstack/pull/1063#issuecomment-156414832
  
@DaanHoogland That's already being done by @wilderrodrigues. Therefore this 
one is obsolete.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9050 Virtual router should onl...

[borisroman]

Github user borisroman commented on the pull request:

https://github.com/apache/cloudstack/pull/1063#issuecomment-156384240
  
@dsclose Thanks for your PR, it shows support! As the script is not in use 
anymore, would you close the PR?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: update for comment in cancelMaintin on st...

[borisroman]

Github user borisroman commented on the pull request:

https://github.com/apache/cloudstack/pull/1065#issuecomment-156394882
  
LGTM :+1: 

Improving comments, always :+1: 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: [4.6.1] CLOUDSTACK-9015 - Redundant VPC V...

[borisroman]

Github user borisroman commented on the pull request:

https://github.com/apache/cloudstack/pull/1064#issuecomment-156253559
  
@wilderrodrigues Thanks for fixing! Will run tomorrow or this weekend.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9039: Fix paths for logging Ub...

[borisroman]

Github user borisroman commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1039#discussion_r44275233
  
--- Diff: python/lib/cloudutils/serviceConfigServer.py ---
@@ -107,7 +107,7 @@ def checkHostName():
 bash("chown cloud.cloud /var/run/cloudstack-management.pid")
 #distro like sl 6.1 needs this folder, or tomcat6 failed to start
--- End diff --

@remibergsma Could you point me to a couple lines of code where 
/var/log/cloudstack-management/ is used in  current master?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9039: Fix paths for logging Ub...

[borisroman]

Github user borisroman commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1039#discussion_r44275343
  
--- Diff: python/lib/cloudutils/serviceConfigServer.py ---
@@ -107,7 +107,7 @@ def checkHostName():
 bash("chown cloud.cloud /var/run/cloudstack-management.pid")
 #distro like sl 6.1 needs this folder, or tomcat6 failed to start
--- End diff --

@remibergsma Grepping yields:

```
grep "/var/log/cloudstack-management/" . -r
./python/lib/cloudutils/serviceConfigServer.py:bash("mkdir 
/var/log/cloudstack-management/")
```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9038 - Infrastructure tab is s...

[borisroman]

Github user borisroman commented on the pull request:

https://github.com/apache/cloudstack/pull/1036#issuecomment-155071567
  
LGTM, deployed on Ubuntu 14.04 with Tomcat6. Working fine! :+1: 

![screenshot from 2015-11-09 15 07 
28](https://cloud.githubusercontent.com/assets/5996146/11035571/9d357dee-86f3-11e5-89b0-73f9ca3d28b5.png)



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Fix some small UI bugs

[borisroman]

Github user borisroman commented on the pull request:

https://github.com/apache/cloudstack/pull/1034#issuecomment-155153401
  
@wilderrodrigues did you remove the .gz files?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9046 - Fix upgrade path from 4...

[borisroman]

Github user borisroman commented on the pull request:

https://github.com/apache/cloudstack/pull/1050#issuecomment-155116207
  
LGTM :+1: 

Deployed 4.5.2 from DEB packages on Ubuntu 14.04. Deployed a zone, deployed 
the systemvm's and spawned a uservm.

Upgraded to 4.6 with packages build from this branch. Upgrade went ok! :+1: 

```
INFO  [c.c.u.DatabaseUpgradeChecker] (main:null) DB version = 4.5.2 Code 
Version = 4.6.0
INFO  [c.c.u.DatabaseUpgradeChecker] (main:null) Database upgrade must be 
performed from 4.5.2 to 4.6.0
INFO  [c.c.u.DatabaseUpgradeChecker] (main:null) Cleaning upgrades because 
all management server are now at the same version
INFO  [c.c.u.DatabaseUpgradeChecker] (main:null) Cleanup upgrade 
Upgrade452to460 to upgrade from 4.5.2-4.6.0 to 4.6.0
INFO  [o.a.c.s.l.CloudStackExtendedLifeCycle] (main:null) Configuring 
CloudStack Components
INFO  [o.a.c.s.l.CloudStackExtendedLifeCycle] (main:null) Done Configuring 
CloudStack Components
```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9044: Add RBD Primary Storage ...

[borisroman]

Github user borisroman commented on the pull request:

https://github.com/apache/cloudstack/pull/1046#issuecomment-155218538
  
I added a RBD pool using the ZoneWizard:

![screenshot from 2015-11-09 23 24 
29](https://cloud.githubusercontent.com/assets/5996146/11048603/337ee0e8-8739-11e5-8691-6000691b7e50.png)
![screenshot from 2015-11-09 23 24 
45](https://cloud.githubusercontent.com/assets/5996146/11048604/337f569a-8739-11e5-9a3a-f3ac4e1fe60c.png)
![screenshot from 2015-11-09 23 24 
55](https://cloud.githubusercontent.com/assets/5996146/11048602/337e0362-8739-11e5-9688-824a50ff7d78.png)



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Fix some small UI bugs

[borisroman]

Github user borisroman commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1034#discussion_r44254960
  
--- Diff: ui/scripts/vpc.js ---
@@ -1507,7 +1507,9 @@
 },
 complete: function(args) {
 if (args.password != null) {
-alert('Password of the VM is ' + 
args.password);
+cloudStack.dialog.notice({
+message: 'Password of the VM is ' 
+ args.password
--- End diff --

This I like very much! :)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9044: Add RBD Primary Storage ...

[borisroman]

Github user borisroman commented on the pull request:

https://github.com/apache/cloudstack/pull/1046#issuecomment-154862003
  
@DaanHoogland I share the same opinion. I would actually like to see the UI 
be a separate project. But in my opinion that supersedes this PR.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9043 Remove \n (new line) in G...

[borisroman]

Github user borisroman commented on the pull request:

https://github.com/apache/cloudstack/pull/1043#issuecomment-154878848
  
Changed LGTM. No integration tests ran though.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9044: Add RBD Primary Storage ...

[borisroman]

GitHub user borisroman opened a pull request:

https://github.com/apache/cloudstack/pull/1046

CLOUDSTACK-9044: Add RBD Primary Storage to the Zone Wizard.

Added to option to use RBD as primary storage in the Zone Wizard.

Pure UI change.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/borisroman/cloudstack CLOUDSTACK-9044

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/1046.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1046


commit c4f64dce2127c8cef4e28aec5017c5f654c9e584
Author: Boris Schrijver <bo...@pcextreme.nl>
Date:   2015-11-08T17:22:39Z

CLOUDSTACK-9044: Add RBD Primary Storage to the Zone Wizard.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9039: Fix paths for logging Ub...

[borisroman]

Github user borisroman commented on the pull request:

https://github.com/apache/cloudstack/pull/1039#issuecomment-154343137
  
@ustcweizhou This is only for the management server! The usage server will 
create it's own paths when installed. @milamberspace I'll push that change, 
thanks!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9039: Fix paths for logging Ub...

[borisroman]

Github user borisroman commented on the pull request:

https://github.com/apache/cloudstack/pull/1039#issuecomment-154409103
  
@remibergsma @ustcweizhou As @wido pointed out, they are already created 
through the packager.

https://github.com/apache/cloudstack/blob/master/debian/rules#L61

https://github.com/apache/cloudstack/blob/master/debian/cloudstack-management.install#L43


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9039: Fix paths for logging Ub...

[borisroman]

Github user borisroman commented on the pull request:

https://github.com/apache/cloudstack/pull/1039#issuecomment-154411673
  
@wido @ustcweizhou Could you review again please?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9040: Use Tomcat6 for Debian p...

[borisroman]

GitHub user borisroman opened a pull request:

https://github.com/apache/cloudstack/pull/1040

CLOUDSTACK-9040: Use Tomcat6 for Debian packages.

Use Tomcat6 for Debian packages.

How to test:
Package debian packages and install them. Will depend specifically on 
tomcat6 for now.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/borisroman/cloudstack CLOUDSTACK-9040

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/1040.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1040


commit e5040b5cbdb64dcd6199b86dbfb1696c06829281
Author: Boris Schrijver <bo...@pcextreme.nl>
Date:   2015-11-05T19:16:11Z

CLOUDSTACK-9040: Use Tomcat6 for Debian packages.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---