[GitHub] cloudstack issue #874: CLOUDSTACK-8897: baremetal:addHost:make host tag info...
Github user kishankavala commented on the issue: https://github.com/apache/cloudstack/pull/874 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1917: CLOUDSTACK-9756: Configure to ignore the ipassoc fai...
Github user kishankavala commented on the issue: https://github.com/apache/cloudstack/pull/1917 Code LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request #1996: CLOUDSTACK-9099: SecretKey is returned from t...
Github user kishankavala commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1996#discussion_r109835294 --- Diff: server/src/com/cloud/user/AccountManager.java --- @@ -198,4 +200,11 @@ void buildACLViewSearchCriteria(SearchCriteria s public static final String MESSAGE_ADD_ACCOUNT_EVENT = "Message.AddAccount.Event"; public static final String MESSAGE_REMOVE_ACCOUNT_EVENT = "Message.RemoveAccount.Event"; +public static final ConfigKey UseSecretKeyInResponse = new ConfigKey( +"Advanced", +Boolean.class, +"use.secret.key.in.response", +"true", --- End diff -- As per discussion in PR # 1152, default value should be false. Any failing tests due to this change have to be fixed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request #2023: BUG-ID: CLOUDSTACK-9808 Added system Vm upgra...
GitHub user kishankavala opened a pull request: https://github.com/apache/cloudstack/pull/2023 BUG-ID: CLOUDSTACK-9808 Added system Vm upgrade path for LXC and OVM `mysql> select id,unique_name,name,type,url,updated,created from vm_template where type='SYSTEM'; ++-+---++---+-+-+ | id | unique_name | name | type | url | updated | created | ++-+---++---+-+-+ | 1 | routing-1 | SystemVM Template (XenServer) | SYSTEM | https://download.cloudstack.org/systemvm/4.10/systemvm64template-master-4.10.0-xen.vhd.bz2 | NULL| 2017-03-30 15:53:00 | | 3 | routing-3 | SystemVM Template (KVM) | SYSTEM | https://download.cloudstack.org/systemvm/4.10/systemvm64template-master-4.10.0-kvm.qcow2.bz2 | NULL| 2017-03-30 15:53:00 | | 8 | routing-8 | SystemVM Template (vSphere) | SYSTEM | https://download.cloudstack.org/systemvm/4.10/systemvm64template-master-4.10.0-vmware.ova | NULL| 2017-03-30 15:53:00 | | 9 | routing-9 | SystemVM Template (HyperV)| SYSTEM | https://download.cloudstack.org/systemvm/4.10/systemvm64template-master-4.10.0-hyperv.vhd.zip | NULL| 2017-03-30 15:53:00 | | 10 | routing-10 | SystemVM Template (LXC) | SYSTEM | https://download.cloudstack.org/systemvm/4.10/systemvm64template-master-4.10.0-kvm.qcow2.bz2 | NULL| 2017-03-30 15:54:13 | | 12 | routing-12 | SystemVM Template (Ovm3) | SYSTEM | https://download.cloudstack.org/systemvm/4.10/systemvm64template-master-4.10.0-ovm.raw.bz2 | NULL| 2017-03-30 15:55:58 | ++-+---++---+-+-+ 6 rows in set (0.00 sec) ` You can merge this pull request into a Git repository by running: $ git pull https://github.com/Accelerite/cloudstack CLOUDSTACK-9808 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cloudstack/pull/2023.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2023 commit 4795cba0ec86c2e4ffd2da959414deeb15a2c532 Author: Kishan Kavala <kis...@apache.org> Date: 2017-03-30T11:45:46Z BUG-ID: CLOUDSTACK-9808 Added system Vm upgrade path for LXC and OVM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1993: CLOUDSTACK-8931: Fail to deploy VM instance when use...
Github user kishankavala commented on the issue: https://github.com/apache/cloudstack/pull/1993 Changes LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1982: CLOUDSTACK-9807/CLOUDSTACK-9808 - Added upgrade chan...
Github user kishankavala commented on the issue: https://github.com/apache/cloudstack/pull/1982 @karuturi updated template URLs and md5sum --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request #1982: CLOUDSTACK-9807/CLOUDSTACK-9808 - Added upgra...
GitHub user kishankavala opened a pull request: https://github.com/apache/cloudstack/pull/1982 CLOUDSTACK-9807/CLOUDSTACK-9808 - Added upgrade changes for 4.10 system vm template Removed systemvm template upgrade code in 4.6 upgrade. Added 4.10 system vm template upgrade changes with new urls and md5sum Manual testing results: Updated min req version: mysql> select name, value from configuration where name = 'minreq.sysvmtemplate.version'; +--+--+ | name | value| +--+--+ | minreq.sysvmtemplate.version | 4.10.0.0 | +--+--+ 1 row in set (0.00 sec) Update template for KVM: mysql> select * from vm_template where name = 'systemvm-kvm-4.10'\G *** 1. row *** id: 201 unique_name: 201-2-badc363a-507d-3802-942f-205d35c3b575 name: systemvm-kvm-4.10 uuid: 3526258d-d9a4-4c3d-8f15-3137eb5d7ab8 public: 0 featured: 0 type: SYSTEM hvm: 1 bits: 64 url: http://packages.shapeblue.com/systemvmtemplate/4.10/systemvm64template-4.10-kvm.qcow2.bz2 format: QCOW2 created: 2017-03-02 11:35:06 removed: NULL account_id: 2 checksum: NULL display_text: systemvm-kvm-4.10 enable_password: 0 enable_sshkey: 0 guest_os_id: 184 bootable: 1 prepopulate: 0 cross_zones: 1 extractable: 0 hypervisor_type: KVM source_template_id: NULL template_tag: NULL sort_key: 0 size: 5242880 state: Active update_count: 0 updated: NULL dynamically_scalable: 0 1 row in set (0.00 sec) You can merge this pull request into a Git repository by running: $ git pull https://github.com/Accelerite/cloudstack CLOUDSTACK-9807 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cloudstack/pull/1982.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1982 commit d772d93cd354c69e1dbd31d5a79523bf2369463a Author: Kishan Kavala <kishan.kav...@persistent.co.in> Date: 2017-03-02T10:27:11Z systemvm template update commit 3867599006b468dbf5b8153399544fcc74ff92f2 Author: Kishan Kavala <kis...@apache.org> Date: 2017-03-02T10:50:28Z Bug-ID: CLOUDSTACK-9807: Removed systemvm template upgrade code in 4.6 upgrade. Added 4.10 system vm template upgrade changes with new urls and md5sum --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #859: Bug-ID: CLOUDSTACK-8882: calculate network offering u...
Github user kishankavala commented on the issue: https://github.com/apache/cloudstack/pull/859 @DaanHoogland cloudmonger failures are not related to this PR. Changes in this PR are related to usage server only. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request #1866: Advanced isolated network egress destination ...
Github user kishankavala commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1866#discussion_r103861501
--- Diff: engine/schema/src/com/cloud/upgrade/dao/Upgrade4920to41000.java
---
@@ -53,6 +55,7 @@ public boolean supportsRollingUpgrade() {
@Override
public void performDataMigration(Connection conn) {
+updateSourceCidrs(conn);
--- End diff --
Please add comment on why source cidr is updated
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request #1866: Advanced isolated network egress destination ...
Github user kishankavala commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1866#discussion_r103861408
--- Diff:
tools/appliance/definitions/systemvmtemplate/install_systemvm_packages.sh ---
@@ -67,6 +67,8 @@ function install_packages() {
xenstore-utils libxenstore3.0 \
conntrackd ipvsadm libnetfilter-conntrack3 libnl-3-200
libnl-genl-3-200 \
ipcalc \
+ipset \
+openjdk-7-jre-headless \
--- End diff --
Only ipset is required here
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1886: CLOUDSTACK-9728: Fixed traffic sentinel HTTP 414 err...
Github user kishankavala commented on the issue: https://github.com/apache/cloudstack/pull/1886 Tested manually. Did not see any issues with long list of IPs. LGTM. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1883: CLOUDSTACK-9723: Enable unique mac address across th...
Github user kishankavala commented on the issue: https://github.com/apache/cloudstack/pull/1883 Code LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1824: CLOUDSTACK-9657: Fixed security group ipset issues w...
Github user kishankavala commented on the issue: https://github.com/apache/cloudstack/pull/1824 Code LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request #1824: CLOUDSTACK-9657: Fixed security group ipset i...
Github user kishankavala commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1824#discussion_r101981147
--- Diff: scripts/vm/hypervisor/xenserver/vmops ---
@@ -232,28 +233,50 @@ def deleteFile(session, args):
return txt
+#using all the iptables chain names length to 24 because cleanup_rules
groups the vm chain excluding -def,-eg
+#to avoid multiple iptables chains for single vm there using length 24
def chain_name(vm_name):
if vm_name.startswith('i-') or vm_name.startswith('r-'):
if vm_name.endswith('untagged'):
return '-'.join(vm_name.split('-')[:-1])
if len(vm_name) > 28:
-vm_name = vm_name[0:27]
+vm_name = vm_name[0:24]
return vm_name
def chain_name_def(vm_name):
+#iptables chain length max is 29 chars
+if len(vm_name) > 28:
--- End diff --
Check should be > 25, "-def" is suffixed
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #843: Security group ingress/egress issues with xenserver 6...
Github user kishankavala commented on the issue: https://github.com/apache/cloudstack/pull/843 Code LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request #1964: Bug-Id: CLOUDSTACK-9800 Enabled netscaler inl...
GitHub user kishankavala opened a pull request: https://github.com/apache/cloudstack/pull/1964 Bug-Id: CLOUDSTACK-9800 Enabled netscaler inline mode. Added corresponding changes in UI NetScaler can work in inline mode also along with other Firewall devices. Enabled netscaler inline mode capability You can merge this pull request into a Git repository by running: $ git pull https://github.com/kishankavala/cloudstack CLOUDSTACK-9800 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cloudstack/pull/1964.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1964 commit a0f990a2f270e8af92ed03a624a84e14da0ba4c0 Author: Kishan Kavala <kis...@apache.org> Date: 2017-02-23T09:53:56Z Bug-Id: CLOUDSTACK-9800 Enabled netscaler inline mode. Added corrsponding changes in UI --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1922: CLOUDSTACK-9757: Fixed issue in traffic from additio...
Github user kishankavala commented on the issue: https://github.com/apache/cloudstack/pull/1922 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1873: CLOUDSTACK-9709: Updated the vm ip fetch task to use...
Github user kishankavala commented on the issue: https://github.com/apache/cloudstack/pull/1873 Code looks good. LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1379: CLOUDSTACK-8324: config drive data set/get scripts f...
Github user kishankavala commented on the issue: https://github.com/apache/cloudstack/pull/1379 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #847: Bug-ID: CLOUDSTACK-8880: calculate free memory on hos...
Github user kishankavala commented on the issue: https://github.com/apache/cloudstack/pull/847 @rhtyd Done --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #847: Bug-ID: CLOUDSTACK-8880: calculate free memory on hos...
Github user kishankavala commented on the issue: https://github.com/apache/cloudstack/pull/847 @borisroman moved free memory calculation to separate method @rhtyd rebased fix with latest master --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #859: Bug-ID: CLOUDSTACK-8882: calculate network offering u...
Github user kishankavala commented on the issue: https://github.com/apache/cloudstack/pull/859 @DaanHoogland , Test creates two UsageNetworkOfferings, both with same network offering but different nicIds. Test case is verified by checking that 2 usage records are created instead of one. Without this fix only 1 usage record is created. @rhtyd rebased against latest master --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1939: CLOUDSTACK-8886: Limitations is listUsageRecords out...
Github user kishankavala commented on the issue: https://github.com/apache/cloudstack/pull/1939 LGTM API response: admin 8c91c04e-f282-11e6-8a09-d4ae52cb9a54 8c91ab6a-f282-11e6-8a09-d4ae52cb9a54 ROOT a6401f5b-b090-4a64-9d73-c04369d15ca8 VM-5e458101-b6a7-477e-9086-ee659ce0a700 running time (ServiceOffering: 1) (Template: 111) 0.12778 Hrs 1 0.12778 5e458101-b6a7-477e-9086-ee659ce0a700 VM-5e458101-b6a7-477e-9086-ee659ce0a700 2b10fa98-c167-444f-b9c0-752611a9f267 02567d08-f283-11e6-8a09-d4ae52cb9a54 5e458101-b6a7-477e-9086-ee659ce0a700 Simulator 2017-02-14'T'07:07:15+00:00 2017-02-14'T'07:15:00+00:00 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1581: CLOUDSTACK-9404 Fixed ordering of network ACL rules ...
Github user kishankavala commented on the issue: https://github.com/apache/cloudstack/pull/1581 @pdube Current fix is good enough. I'm only concerned about more such issues in VR. can you please create a tracking bug for VR fix and make a note that this is a regression? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1581: CLOUDSTACK-9404 Fixed ordering of network ACL rules ...
Github user kishankavala commented on the issue: https://github.com/apache/cloudstack/pull/1581 @leprechau ACL rule ordering was introduced in 2013 in ACS 4.2. Since 4.2 release, the order was never changed. Older commit your are referring to, was during development phase of 4.2. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1581: CLOUDSTACK-9404 Fixed ordering of network ACL rules ...
Github user kishankavala commented on the issue: https://github.com/apache/cloudstack/pull/1581 @swill This is a regression caused by VR refactor. There could be more such issues. I would prefer a fix in the VR script. Current fix is more like reversing the order twice to make it correct. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1581: CLOUDSTACK-9404 Fixed ordering of network ACL rules ...
Github user kishankavala commented on the issue: https://github.com/apache/cloudstack/pull/1581 @pdube though the fix looks good, the root of the issue is different. Earlier when bash scripts were used to configure rules on VR, iptable rules for ACLs were inserted (-I option). This changed to add (-A option) after VR refactor, resulting in rules being applied in the reverse order. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: Bug-ID: CLOUDSTACK-8870: Skip external de...
Github user kishankavala commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/846#discussion_r64195431
--- Diff: engine/schema/src/com/cloud/host/dao/HostDaoImpl.java ---
@@ -1087,4 +1087,11 @@ public HostVO findByPublicIp(String publicIp) {
sc.addAnd("dataCenterId", SearchCriteria.Op.EQ, zoneId);
return customSearch(sc, null);
}
+
+@Override
+public List listByType(Host.Type type) {
+SearchCriteria sc = TypeSearch.create();
+sc.setParameters("type", type);
+return listBy(sc);
--- End diff --
@rhtyd
listBy(sc) in GenericDao base returns an empty ArrayList if there is no
matching data.
listByType doesn't return null
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Bug-ID: CLOUDSTACK-8870: Skip external de...
Github user kishankavala commented on the pull request: https://github.com/apache/cloudstack/pull/846#issuecomment-220935383 @swill rebased with latest master @GabrielBrascher fixed the typo --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-9261: Query to traffic sentine...
Github user kishankavala commented on the pull request: https://github.com/apache/cloudstack/pull/1418#issuecomment-212842771 @kansal LGTM. See if you can add an integration test. Actual response from traffic sentinel resource in the logs will also help. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-8958: release dedicated ip ran...
Github user kishankavala commented on the pull request: https://github.com/apache/cloudstack/pull/1357#issuecomment-200185858 @DaanHoogland Failed tests are the ones which we should be looking at. integration.smoke.test_privategw_acl.TestPrivateGwACL is the only failed test in this case. Manual run of this particular test will help in assessing the quality of this PR. @bvbharatk please correct me, if my understanding is not correct. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-8800 : Improved the listVirtua...
Github user kishankavala commented on the pull request: https://github.com/apache/cloudstack/pull/780#issuecomment-199222784 @swill @remibergsma @DaanHoogland PR was open since Sep 2015. Review from @swill came after the PR was merged on Mar 17 2016. By then, there were code reviews and tests done with 3 LGTMs. I merged the PR as per the current process. Unfortunately all reviewers missed the issued mentioned by @swill Thanks to @rafaelweingartner https://github.com/apache/cloudstack/pull/1444 addresses the runtime exception issues. Unless there are issues with PR 1444, I do not see a need to revert this merge. Can we all please review PR 1444 and close this issue? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-9305: Cloudstack Usage Breaks ...
Github user kishankavala commented on the pull request: https://github.com/apache/cloudstack/pull/1433#issuecomment-197768091 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-8800 : Improved the listVirtua...
Github user kishankavala commented on the pull request:
https://github.com/apache/cloudstack/pull/780#issuecomment-197262533
Tested Manually. memorykbs, memoryintfreekbs,memorytargetkbs are listed
correctly.
LGTM.
`1a574e9d1-8057-4195-a8b3-2117e9059652VM-a574e9d1-8057-4195-a8b3-2117e9059652VM-a574e9d1-8057-4195-a8b3-2117e9059652adminee621684-952a-11e5-abd2-d4ae52cb9a54adminee5bfd6f-952a-11e5-abd2-d4ae52cb9a54ROOT2015-11-27T23:30:46+0530Runningfalseb5503a30-f55b-4889-94c2-32a73c6b4166KK57382ec5-87e1-4c0b-9df1-02b2cba04971Rack3Pod1Host44ee3b1574-952a-11e5-abd2-d4ae52cb9a54CentOS
5.6(64-bit) no GUI (XenServer)CentOS
5.6(64-bit) no GUI
(XenServer)false1d88488d-6651-4a63-b865-a3a5f4115dd6custom45121280.04%000111310721513107200ee4c163d-952a-11e5-abd2-d4ae52cb9a540ROOT66347c35-f51f-4527-bb59-50a976d90927d97370e1-7fb3-44be-8af5-9515c1d624a2n1255.255.255.010.1.1.110.1.1.14vlan://514vlan://514GuestIsolatedtr
ue02:00:66:75:00:01XenServeri-2-3-VM{hypervisortoolsversion=xenserver56}truetrue142`
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-8800 : Improved the listVirtua...
Github user kishankavala commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/780#discussion_r56311601
--- Diff:
plugins/hypervisors/xenserver/src/com/cloud/hypervisor/xenserver/resource/CitrixResourceBase.java
---
@@ -3332,7 +3332,14 @@ public PowerState getVmState(final Connection conn,
final String vmName) {
vmStatsAnswer.setDiskReadKBs(vmStatsAnswer.getDiskReadKBs() +
getDataAverage(dataNode, col, numRows) / 1000);
} else if (param.matches("vbd_.*_write")) {
vmStatsAnswer.setDiskWriteKBs(vmStatsAnswer.getDiskWriteKBs() +
getDataAverage(dataNode, col, numRows) / 1000);
+} else if (param.contains("memory_internal_free")) {
+
vmStatsAnswer.setIntFreeMemoryKBs(vmStatsAnswer.getIntFreeMemoryKBs() +
getDataAverage(dataNode, col, numRows) / 1000);
--- End diff --
Bytes to KB conversion should use 1024 instead of 1000
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-9252: Support configurable NFS...
Github user kishankavala commented on the pull request: https://github.com/apache/cloudstack/pull/1361#issuecomment-185176731 @nvazquez Can you please repond to my earlier question also. >> How is the nfs.version set in image_store_details table? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-9252: Support configurable NFS...
Github user kishankavala commented on the pull request: https://github.com/apache/cloudstack/pull/1361#issuecomment-181771585 One more query: How is the nfs.version set in image_store_details table? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-9252: Support configurable NFS...
Github user kishankavala commented on the pull request: https://github.com/apache/cloudstack/pull/1361#issuecomment-181715514 @nvazquez Apologies for reviewing it late. 1. Since version is fetched from image_store_details, can we send a map with all details for the image_store instead of just the version. This will make the approach more generic. In case more info is required for other vendors in future, too many changes can be avoided 2. Nfsversion param and corresponding getter/setter methods can be moved to a base class (something like BaseImageStoreCommand) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: Bug-ID: CLOUDSTACK-8654: Added guest_os m...
GitHub user kishankavala opened a pull request: https://github.com/apache/cloudstack/pull/1244 Bug-ID: CLOUDSTACK-8654: Added guest_os mappings for CoreOS Tested CoreOS Vm deploy in Xenserver, KVM and VMware hypervisors Tested upgrade with new guest OS mappings You can merge this pull request into a Git repository by running: $ git pull https://github.com/kishankavala/cloudstack CLOUDSTACK-8654 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cloudstack/pull/1244.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1244 commit 44ae6f4106e693a15e3fc0e39c8da783fa39efe0 Author: Kishan Kavala <kis...@apache.org> Date: 2015-12-15T10:12:13Z Bug-ID: CLOUDSTACK-8654: Added guest_os mappings for CoreOS --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-8605: KVM: Config Drive and ge...
Github user kishankavala closed the pull request at: https://github.com/apache/cloudstack/pull/577 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: [4.7] CLOUDSTACK-9129: list vpc routers b...
Github user kishankavala commented on the pull request: https://github.com/apache/cloudstack/pull/1197#issuecomment-163538722 You are right @ustcweizhou . My branch was not up to date. Applied the patch on latest master. - Able to see vpcname and vpcid in listRouters response - Keyword search with vpc name also worked. LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: [4.7] CLOUDSTACK-9129: list vpc routers b...
Github user kishankavala commented on the pull request: https://github.com/apache/cloudstack/pull/1197#issuecomment-163492909 @ustcweizhou Changes look good to me. But I could not actually test them, patch doesn't apply on latest master --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: Add all tests in /test/integration/smoke ...
Github user kishankavala commented on the pull request: https://github.com/apache/cloudstack/pull/920#issuecomment-147947974 @sanjeevneelarapu 1. We should look at ways to improve the simulator to run faster. 2. We have PRs open for more than a day in most cases. I would rather wait for 6hrs than to have code which might break some functionality. When we get CI based on real hardware in future, it'll take even more time. At that point we can look at running it once a day on latest master instead of per PR. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: Usage event fixes for deleted accounts
Github user kishankavala commented on the pull request: https://github.com/apache/cloudstack/pull/924#issuecomment-147945829 @remibergsma We not have any tests that will check for correct events on account delete. @nnesic Would you be able to add one? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: Add all tests in /test/integration/smoke ...
Github user kishankavala commented on the pull request: https://github.com/apache/cloudstack/pull/920#issuecomment-147944007 @runseb @pvr9711 @sanjeevneelarapu Can we include all regression simulator tests also? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: Bug-ID: CLOUDSTACK-8882: calculate networ...
GitHub user kishankavala opened a pull request: https://github.com/apache/cloudstack/pull/859 Bug-ID: CLOUDSTACK-8882: calculate network offering usage per nic instead of per network offering Issues occurs when: A Vm is created with mutiple nics: If 2 networks use same network offering, network offering usage will be 48hrs (assuming 24hrs aggregation) Usage should be reported per Nic instead of network offering Added test case to verify You can merge this pull request into a Git repository by running: $ git pull https://github.com/kishankavala/cloudstack CLOUDSTACK-8882 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cloudstack/pull/859.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #859 commit 488c593496788573d20d8c332eaac73c7b9d7640 Author: Kishan Kavala <kis...@apache.org> Date: 2015-09-21T06:53:44Z Bug-ID: CLOUDSTACK-8882: calculate network offering usage per nic instead of per network offering --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-8843: Fixed issue in default i...
Github user kishankavala commented on the pull request: https://github.com/apache/cloudstack/pull/842#issuecomment-142185868 LGTM integration.smoke.test_vm_life_cycle test case validates ssh access to Vm as part of test_10_attachAndDetach_iso test Would be better test_deploy_vm test in test_vm_life_cycle also validates that Vm is accessible via SSH. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: Bug-ID: CLOUDSTACK-8870: Skip external de...
GitHub user kishankavala opened a pull request: https://github.com/apache/cloudstack/pull/846 Bug-ID: CLOUDSTACK-8870: Skip external device usage collection if no external devices exist external network device usage monitor thread that runs every 5mins by default (based on global config external.network.stats.interval) and runs coalesce query to acquire a lock. When there are no external devices exist, there is no need to run usage collection. Added test case to verify that usage collection task is not run when there are no External LB or External FW You can merge this pull request into a Git repository by running: $ git pull https://github.com/kishankavala/cloudstack CLOUDSTACK-8870 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cloudstack/pull/846.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #846 commit a77dc78bfead71d0c9b5afa5813575ac67880f11 Author: Kishan Kavala <kis...@apache.org> Date: 2015-09-16T15:15:06Z Bug-ID: CLOUDSTACK-8870: Skip external device usage collection if no external devices exist. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: Bug-ID: CLOUDSTACK-8880: calculate free m...
GitHub user kishankavala opened a pull request: https://github.com/apache/cloudstack/pull/847 Bug-ID: CLOUDSTACK-8880: calculate free memory on host before deploying Vm. free memory = total memory - (all vm memory) With memory over-provisioning set to 1, when mgmt server starts VMs in parallel on one host, then the memory allocated on that kvm can be larger than the actual physcial memory of the kvm host. Fixed by checking free memory on host before starting Vm. Added test case to check memory usage on Host. Verified Vm deploy on Host with enough capacity and also without capacity You can merge this pull request into a Git repository by running: $ git pull https://github.com/kishankavala/cloudstack CLOUDSTACK-8880 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cloudstack/pull/847.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #847 commit e2a879f040e894c32defd3fb9bb3b127fd96702d Author: Kishan Kavala <kis...@apache.org> Date: 2015-09-18T05:40:52Z Bug-ID: CLOUDSTACK-8880: calculate free memory on host before deploying Vm. free memory = total memory - (all vm memory) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-8799 fixed the defalut routes
Github user kishankavala commented on the pull request:
https://github.com/apache/cloudstack/pull/784#issuecomment-139513737
After applying patch, was able to create VPC successfully.
LGTM.
Sub-process optimization is good to have. This PR will unblock the VPC
creation.
2015-09-11 15:59:15,169 DEBUG [c.c.a.t.Request]
(AgentManager-Handler-8:null) Seq 297-1810728525179650071: Processing: { Ans:
, MgmtId: 233845178473044, via: 297, Ver: v1, Flags: 110,
[{"com.cloud.agent.api.StartAnswer":{"vm":{"id":34,"name":"r-34-VM","type":"DomainRouter","cpus":1,"minSpeed":500,"maxSpeed":500,"minRam":268435456,"maxRam":268435456,"arch":"x86_64","os":"Debian
GNU/Linux 5.0 (64-bit)","platformEmulator":"Debian GNU/Linux 5","bootArgs":"
vpccidr=10.5.1.0/24 domain=cs2cloud.internal dns1=4.2.2.2 template=domP
name=r-34-VM eth0ip=169.254.1.43 eth0mask=255.255.0.0 type=vpcrouter
disable_rp_filter=true
baremetalnotificationsecuritykey=s67s-w0ooifUaTiCWhF24OUfj8JSRhTKTs6N-2rlWY2tkkPo-F0nZOv1lKTIyXXs0ir4vv0hatiUHFaddZxiDw
baremetalnotificationapikey=c9SUcsu8zctnSQmy43yhQB0HJM2HTDsRjEXd85s9IJOobOBRLaGZBa22vDH4IozJpIW8PHXVAFWu_W9qtdvYIA
host=10.147.28.47
port=8080","enableHA":true,"limitCpuUse":false,"enableDynamicallyScaleVm":false,"vncPassword":"UOXbgiNACZU3NN8Rv6uvNg",
"vncAddr":"10.147.28.43","params":{},"uuid":"4da3b373-17bc-4b4a-8b34-f32459faf341","disks":[{"data":{"org.apache.cloudstack.storage.to.VolumeObjectTO":{"uuid":"5e291e11-8043-4b67-9b41-aa55e71e8236","volumeType":"ROOT","dataStore":{"org.apache.cloudstack.storage.to.PrimaryDataStoreTO":{"uuid":"954526cd-d0f1-4a9e-b80a-902baad3faa2","id":3,"poolType":"Filesystem","host":"10.147.28.43","path":"/var/lib/libvirt/images","port":0,"url":"Filesystem://10.147.28.43/var/lib/libvirt/images/?ROLE=Primary=954526cd-d0f1-4a9e-b80a-902baad3faa2"}},"name":"ROOT-34","size":3145728000,"path":"5e291e11-8043-4b67-9b41-aa55e71e8236","volumeId":34,"vmName":"r-34-VM","accountId":2,"format":"QCOW2","provisioningType":"THIN","id":34,"deviceId":0,"hypervisorType":"KVM"}},"diskSeq":0,"path":"5e291e11-8043-4b67-9b41-aa55e71e8236","type":"ROOT","_details":{"managed":"false","storagePort":"0","storageHost":"10.147.28.43","volumeSize":"3145728000"}}],"nics":[{"deviceId":0,"networkRateMbps":-1,"defaultNic"
:false,"pxeDisable":true,"nicUuid":"588f728c-9de8-4b04-8fd4-7b03226c9ef2","uuid":"4c825977-669f-4777-9a44-a312952321c8","ip":"169.254.1.43","netmask":"255.255.0.0","gateway":"169.254.0.1","mac":"0e:00:a9:fe:01:2b","broadcastType":"LinkLocal","type":"Control","isSecurityGroupEnabled":false}]},"result":true,"wait":0}},{"com.cloud.agent.api.check.CheckSshAnswer":{"result":true,"wait":0}},{"com.cloud.agent.api.GetDomRVersionAnswer":{"templateVersion":"Cloudstack
Release 4.6.0 Sun Jul 26 22:08:05 UTC
2015","scriptsVersion":"d6222468f4f35d173be74954631b18d2\n","result":true,"details":"Cloudstack
Release 4.6.0 Sun Jul 26 22:08:05 UTC
2015\n","wait":0}},{"com.cloud.agent.api.PlugNicAnswer":{"result":true,"details":"success","wait":0}},{"com.cloud.agent.api.routing.GroupAnswer":{"results":["null
- success: null","null - success: [INFO] update_config.py :: Processing
incoming file => ip_associations.json\n[INFO] Processing JSON file
ip_associations.json\n"],"r
esult":true,"wait":0}},{"com.cloud.agent.api.Answer":{"result":true,"details":"Nothing
to
do","wait":0}},{"com.cloud.agent.api.NetworkUsageAnswer":{"routerName":"r-34-VM","bytesSent":0,"bytesReceived":0,"result":true,"wait":0}}]
}
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-8443: Support CentOS 7 as KVM ...
Github user kishankavala commented on the pull request: https://github.com/apache/cloudstack/pull/731#issuecomment-134636230 @remibergsma changes looks fine. I would like to test it and get back to you, hopefully by tomorrow. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-8733: Host stuck in rebalancin...
Github user kishankavala commented on the pull request: https://github.com/apache/cloudstack/pull/698#issuecomment-133283527 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-8605: KVM: Config Drive and ge...
Github user kishankavala commented on the pull request: https://github.com/apache/cloudstack/pull/577#issuecomment-132073238 @remibergsma I've update the PR. There is still one issue open regarding the usage of /tmp --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-8727: API call listVirtualMach...
Github user kishankavala commented on the pull request: https://github.com/apache/cloudstack/pull/685#issuecomment-130282420 @kansal Can you add a similar check for duplicates keys in the createSSHKeyPair API validation? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-8638: install update_host_pass...
Github user kishankavala commented on the pull request: https://github.com/apache/cloudstack/pull/663#issuecomment-128666248 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-8696: Create Region fails with...
Github user kishankavala commented on the pull request: https://github.com/apache/cloudstack/pull/657#issuecomment-128306138 LGTM if 4.5.2 is released before 4.6.0 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-8696: Create Region fails with...
Github user kishankavala commented on the pull request: https://github.com/apache/cloudstack/pull/657#issuecomment-128227678 @remibergsma Agreed. In this case fix will go into 4.5.2 and 4.6 Updated fixVersion accordingly --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-8696: Create Region fails with...
Github user kishankavala commented on the pull request: https://github.com/apache/cloudstack/pull/657#issuecomment-127560212 @karuturi This issue exists in releases 4.5.0 Shouldn't this be fixed in 4.5.0, 4.5.1 and merged forward as per the new release process? Or is the new process for releases 4.6+ only? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-8677: Call-home functionality ...
Github user kishankavala commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/625#discussion_r35948897 --- Diff: setup/db/db/schema-452to460.sql --- @@ -398,3 +398,5 @@ CREATE TABLE `cloud`.`external_bigswitch_bcf_devices` ( CONSTRAINT `fk_external_bigswitch_bcf_devices__host_id` FOREIGN KEY (`host_id`) REFERENCES `host`(`id`) ON DELETE CASCADE, CONSTRAINT `fk_external_bigswitch_bcf_devices__physical_network_id` FOREIGN KEY (`physical_network_id`) REFERENCES `physical_network`(`id`) ON DELETE CASCADE ) ENGINE=InnoDB DEFAULT CHARSET=utf8; + +INSERT IGNORE INTO `cloud`.`configuration` VALUES (Advanced, 'DEFAULT', 'management-server', usage.report.interval, 7, Interval (days) between sending anonymous Usage Reports back to the CloudStack project, , NULL, NULL, 0); --- End diff -- @wido @DaanHoogland is correct. DB query to insert new config items is not required now. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-8687: Prepare template only on...
Github user kishankavala commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/635#discussion_r35862098 --- Diff: api/src/org/apache/cloudstack/api/command/admin/template/PrepareTemplateCmd.java --- @@ -60,6 +61,15 @@ description = template ID of the template to be prepared in primary storage(s).) private Long templateId; +@ACL(accessType = AccessType.OperateEntry) +@Parameter(name = ApiConstants.STORAGE_ID, +type = CommandType.UUID, +entityType = StoragePoolResponse.class, +required = false, +description = storage pool ID of the primary storage pool to which the template should be prepared. If it is not provided the template + + is prepared on all the available primary storage pools.) +private Long storageId; --- End diff -- @devdeep LGTM if storageId is consistent across APIs --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: Update NiciraNvpGuestNetworkGuru.java
Github user kishankavala commented on the pull request: https://github.com/apache/cloudstack/pull/636#issuecomment-126288404 @sspans Since Test case is updated to cover VXLAN also, LGTM. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-8687: Prepare template only on...
Github user kishankavala commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/635#discussion_r35849002 --- Diff: api/src/org/apache/cloudstack/api/command/admin/template/PrepareTemplateCmd.java --- @@ -60,6 +61,15 @@ description = template ID of the template to be prepared in primary storage(s).) private Long templateId; +@ACL(accessType = AccessType.OperateEntry) +@Parameter(name = ApiConstants.STORAGE_ID, +type = CommandType.UUID, +entityType = StoragePoolResponse.class, +required = false, +description = storage pool ID of the primary storage pool to which the template should be prepared. If it is not provided the template + + is prepared on all the available primary storage pools.) +private Long storageId; --- End diff -- better to use poolId ou storagePoolId instead of storageId to be consistent --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: Cloudstack 8656 adding messages to empty ...
Github user kishankavala commented on the pull request: https://github.com/apache/cloudstack/pull/637#issuecomment-126205414 @DaanHoogland Agreed that setting appropriate log level is out of the scope for this PR. But we should file a jira ticket to track and address it before next release. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-8668: VR type in shared networ...
Github user kishankavala commented on the pull request: https://github.com/apache/cloudstack/pull/627#issuecomment-125890106 @wilderrodrigues iptables issue is not specific to dhcpsrvr (shared VR). On isolated VR also default policy is ACCEPT ``` root@r-23-VM:~# iptables -L -nv Chain INPUT (policy ACCEPT 9620 packets, 1598K bytes) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-8683: process cmd_line.json fo...
GitHub user kishankavala opened a pull request: https://github.com/apache/cloudstack/pull/634 CLOUDSTACK-8683: process cmd_line.json for shared network VR in cloud-early-config - SSH access on link_local_ip is blocked for shared VR - MS is unable to program rules on VR. Vm deployment also fails as the DHCP entries cannot be added. - Fixed by processing cmd_line.json in cloud-early-config similar to isolated VR Test: - Deploy Vm successful - Can access VR from host via ssh on link_local_ip on port 3922 You can merge this pull request into a Git repository by running: $ git pull https://github.com/kishankavala/cloudstack CLOUDSTACK-8683 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cloudstack/pull/634.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #634 commit 14218a6726403262dcf8a712229377977513dcfb Author: Kishan Kavala kis...@apache.org Date: 2015-07-29T08:43:01Z CLOUDSTACK-8683: process cmd_line.json for shared network VR in cloud-early-config --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-8668: VR type in shared networ...
Github user kishankavala commented on the pull request: https://github.com/apache/cloudstack/pull/627#issuecomment-125882216 Sure @wilderrodrigues I'll create a PR. But iptables rules are more open now (default ACCEPT). root@r-30-VM:~# iptables -L INPUT -nv Chain INPUT (policy ACCEPT 104 packets, 14936 bytes) It doesn't match content in /etc/iptables/rules.v4 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-8668: VR type in shared networ...
Github user kishankavala commented on the pull request:
https://github.com/apache/cloudstack/pull/627#issuecomment-125864299
@wilderrodrigues
Below changes fixed the issue but not sure if it breaks anything else:
kk-cloudstack git diff
diff --git a/systemvm/patches/debian/config/etc/init.d/cloud-early-config
b/systemvm/patches/debian/config/etc/init.d/cloud-early-config
index 711d575..934ba9c 100755
--- a/systemvm/patches/debian/config/etc/init.d/cloud-early-config
+++ b/systemvm/patches/debian/config/etc/init.d/cloud-early-config
@@ -1339,6 +1339,10 @@ start() {
dhcpsrvr)
[ $NAME == ] NAME=dhcpsrvr
setup_dhcpsrvr
+ if [ -x /opt/cloud/bin/update_config.py ]
+ then
+/opt/cloud/bin/update_config.py cmd_line.json
+ fi
;;
secstorage)
[ $NAME == ] NAME=secstorage
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-8668: VR type in shared networ...
Github user kishankavala commented on the pull request: https://github.com/apache/cloudstack/pull/627#issuecomment-125915281 Thanks @wilderrodrigues I merged https://github.com/apache/cloudstack/pull/634/ I'll created separate ticket to track default policy ACCEPT issue. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-8668: VR type in shared networ...
Github user kishankavala commented on the pull request: https://github.com/apache/cloudstack/pull/627#issuecomment-126186427 Hi @wilderrodrigues, @sanjeevneelarapu filed ticket for default policy ACCEPT issue. https://issues.apache.org/jira/browse/CLOUDSTACK-8688 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-8668: VR type in shared networ...
GitHub user kishankavala opened a pull request: https://github.com/apache/cloudstack/pull/627 CLOUDSTACK-8668: VR type in shared network is dhcpsrvr. Ips are being removed due to this issue - VR IP config is loaded from /var/cache/cloud/cmdline - For shared network VR type is dhcpserver in /var/cache/cloud/cmdline - after VR refactor, merge.py is considering VR types router and vpcrouter only - Fixed by adding dhcpserver VR type Testing: - VR successfully started on shared network. All IPs are configured properly. You can merge this pull request into a Git repository by running: $ git pull https://github.com/kishankavala/cloudstack CLOUDSTACK-8668 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cloudstack/pull/627.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #627 commit 50a6fa02dabd7df7a78a0541df6e575129e14265 Author: Kishan Kavala kis...@apache.org Date: 2015-07-28T09:45:41Z VR type in shared network is dhcpsrvr. Ips are being removed due to this issue --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-8668: VR type in shared networ...
Github user kishankavala commented on the pull request: https://github.com/apache/cloudstack/pull/627#issuecomment-125580306 Yes @wilderrodrigues VR started successfully . But port 3922 is not open. Once I add iptables rule to allow 3922, MS is able to program rules. I'm looking at CLOUDSTACK-8683, but might take a while for me to find the root cause. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-8668: VR type in shared networ...
Github user kishankavala commented on the pull request: https://github.com/apache/cloudstack/pull/627#issuecomment-125571871 Thanks @wilderrodrigues for merging. Ran into another blocker after VR came up: https://issues.apache.org/jira/browse/CLOUDSTACK-8683 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-8668: VR type in shared networ...
Github user kishankavala commented on the pull request: https://github.com/apache/cloudstack/pull/627#issuecomment-125846995 Hi @wilderrodrigues Please look into CLOUDSTACK-8683 when possible --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: Dereference NULL return value
Github user kishankavala commented on the pull request: https://github.com/apache/cloudstack/pull/618#issuecomment-125136388 LGTM. @bhaisaab can you also take a look at the changes? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: fixed finbugs issue due to PR #609
Github user kishankavala commented on the pull request: https://github.com/apache/cloudstack/pull/622#issuecomment-124481535 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-8666: Put host in Alert state ...
Github user kishankavala commented on the pull request: https://github.com/apache/cloudstack/pull/621#issuecomment-124323020 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: Fixed Coverity issue Dereference null re...
Github user kishankavala commented on the pull request: https://github.com/apache/cloudstack/pull/620#issuecomment-124323473 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: Dereference NULL return value
Github user kishankavala commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/618#discussion_r35290636
--- Diff:
plugins/user-authenticators/saml2/src/org/apache/cloudstack/saml/SAML2AuthManagerImpl.java
---
@@ -368,8 +368,14 @@ private boolean setup() {
_idpMetaDataProvider = new HTTPMetadataProvider(_timer,
client, idpMetaDataUrl);
} else {
File metadataFile =
PropertiesUtil.findConfigFile(idpMetaDataUrl);
-s_logger.debug(Provided Metadata is not a URL, trying to
read metadata file from local path: + metadataFile.getAbsolutePath());
-_idpMetaDataProvider = new
FilesystemMetadataProvider(_timer, metadataFile);
+if (metadataFile == null) {
+s_logger.error(Metadata file returned null);
--- End diff --
Can you please update the error message: Provided Metadata is not a URL,
Unable to locate metadata file from local path
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-8634: Made changes to test_sec...
Github user kishankavala commented on the pull request: https://github.com/apache/cloudstack/pull/586#issuecomment-123971770 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-8649: Fixed unnecessary double...
Github user kishankavala commented on the pull request: https://github.com/apache/cloudstack/pull/615#issuecomment-123699898 @DaanHoogland double URL decoding was added during registerSSHKeyPair refactor. commit 968e71ad0e49088b5f2f022df29aec02b10a5ede Can you please check if this fix breaks any of that refactoring? LGTM otherwise. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-8655: [Browser Based Upload Vo...
Github user kishankavala commented on the pull request: https://github.com/apache/cloudstack/pull/611#issuecomment-123703777 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-8580: user can view, expunge a...
Github user kishankavala commented on the pull request: https://github.com/apache/cloudstack/pull/593#issuecomment-122189103 LGTM. Yes some tests would be good to validate expunge/recover behavior when the config is set to true/false for an account --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-8605: KVM: Config Drive and ge...
Github user kishankavala commented on the pull request: https://github.com/apache/cloudstack/pull/577#issuecomment-122219752 @wido @bhaisaab Made the suggested changes --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-8605: KVM: Config Drive and ge...
GitHub user kishankavala opened a pull request: https://github.com/apache/cloudstack/pull/577 CLOUDSTACK-8605: KVM: Config Drive and getVmIp support - CLOUDSTACK-8324 added support for External DHCP/DNS support along with ConfigDrive for XenServer - FS link: https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=53740797 - This PR adds KVM support for config drive and getVmIpAddress assigned by external DHCP - genisoimage package dependency is added for creating config drive ISO - libguestfs is used to get IPAddress from guest VM. Linux: From dhcp leases file. Windows: From registry You can merge this pull request into a Git repository by running: $ git pull https://github.com/kishankavala/cloudstack master Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cloudstack/pull/577.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #577 commit faab39fdd52026ba7c03f8143331d1004338f5ff Author: Kishan Kavala kishan.kav...@citrix.com Date: 2015-06-26T09:48:01Z kvm config drive commit 220e714b5194a33471fc5728c1a6dc69ca0c98e9 Author: Kishan Kavala kis...@apache.org Date: 2015-07-01T12:40:02Z Unit test for GetVmIpAddressCommand commit b2e8bfdff5cc8013a9d50132a941f7849a2949b2 Author: Kishan Kavala kis...@apache.org Date: 2015-07-01T14:51:01Z Test IP not in CIDR commit 3fc60e31d9bcf68a4901dbc059e02c2868943035 Author: Kishan Kavala kis...@apache.org Date: 2015-07-10T08:24:30Z Merge remote-tracking branch 'upstream/master' Conflicts: plugins/hypervisors/kvm/test/com/cloud/hypervisor/kvm/resource/LibvirtComputingResourceTest.java commit e1d1974a06b334bc1be603823f5f44b51bdb3ab2 Author: Kishan Kavala kis...@apache.org Date: 2015-07-10T08:26:26Z Merge remote-tracking branch 'upstream/master' Conflicts: plugins/hypervisors/kvm/test/com/cloud/hypervisor/kvm/resource/LibvirtComputingResourceTest.java commit a3fe3ae233a23f8ac7dcc7485adac9089a7810a8 Author: Kishan Kavala kis...@apache.org Date: 2015-07-10T08:58:52Z Fix Libvirt getVmIP unit test --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: Improved message for peeples to actually ...
Github user kishankavala commented on the pull request: https://github.com/apache/cloudstack/pull/576#issuecomment-120400649 Can we rephrase it as Expected 1 VDI template but found... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-8623: CPVM fails to start afte...
Github user kishankavala commented on the pull request: https://github.com/apache/cloudstack/pull/571#issuecomment-120222980 LGTM. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: dhcp/dns offload feature config dirve cha...
Github user kishankavala commented on the pull request: https://github.com/apache/cloudstack/pull/568#issuecomment-119917422 Looks good to me. Commented on older PR earlier. PR https://github.com/apache/cloudstack/pull/552 can be removed --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: Config drive changes for vm migration
Github user kishankavala commented on the pull request: https://github.com/apache/cloudstack/pull/552#issuecomment-119812602 Looks good to me. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: BUG-ID:CLOUDSTACK-7472: kvmclock fix for ...
GitHub user kishankavala opened a pull request: https://github.com/apache/cloudstack/pull/557 BUG-ID:CLOUDSTACK-7472: kvmclock fix for LXC is not required after fixing CLOUDSTACK-8177 kvmclock fix for LXC is not required after fixing CLOUDSTACK-8177 You can merge this pull request into a Git repository by running: $ git pull https://github.com/kishankavala/cloudstack CLOUDSTACK-7472 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cloudstack/pull/557.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #557 commit 34e4e9a79cb90dd56bc89f59fcbd0ec0dee82287 Author: Kishan Kavala kis...@apache.org Date: 2015-07-02T11:22:46Z BUG-ID:CLOUDSTACK-7472: kvmclock fix for LXC is not required after fixing CLOUDSTACK-8177 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-5409: Include projectid during...
GitHub user kishankavala opened a pull request: https://github.com/apache/cloudstack/pull/374 CLOUDSTACK-5409: Include projectid during ACL check while listing S2S Vpn gateways ACL check is failing when listing S2S vpn gateway withn a project. Added missing projectId in ACL check to fix the issue You can merge this pull request into a Git repository by running: $ git pull https://github.com/kishankavala/cloudstack master Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cloudstack/pull/374.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #374 commit 4b73a898c8785eb6c67559bc068667d004cef149 Author: Kishan Kavala kis...@apache.org Date: 2015-06-09T10:33:15Z CLOUDSTACK-5409: Include projectid during ACL check while listing S2S Vpn gateways --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: Refactor/libvirt resource
Github user kishankavala commented on the pull request: https://github.com/apache/cloudstack/pull/233#issuecomment-101918061 @wilderrodrigues Sorry, I could not test the PR earlier. I see the following issues while trying to bring up my KVM setup: 1. LibvirtUtilitiesHelper NPE. This could be due to spring configuration. LibvirtUtilitiesHelper ws not injected. 2015-05-14 00:00:05,362 DEBUG [kvm.resource.LibvirtComputingResource] (agentRequest-Handler-2:null) Execption while executing command com.cloud.agent.api.StartCommand java.lang.NullPointerException at com.cloud.hypervisor.kvm.resource.wrapper.LibvirtStartCommandWrapper.execute(LibvirtStartCommandWrapper.java:72) at com.cloud.hypervisor.kvm.resource.wrapper.LibvirtStartCommandWrapper.execute(LibvirtStartCommandWrapper.java:45) at com.cloud.hypervisor.kvm.resource.wrapper.LibvirtRequestWrapper.execute(LibvirtRequestWrapper.java:182) at com.cloud.hypervisor.kvm.resource.LibvirtComputingResource.executeRequest(LibvirtComputingResource.java:1251) at com.cloud.agent.Agent.processRequest(Agent.java:503) at com.cloud.agent.Agent$AgentRequestHandler.doTask(Agent.java:808) at com.cloud.utils.nio.Task.run(Task.java:84) at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145) at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615) at java.lang.Thread.run(Thread.java:744) 2. executeRequest in LibvirtComputingResource is not logging any exception. It return Unsupported command answer. This makes it difficult to debug exceptions thrown during command execution, --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: Refactor/libvirt resource
Github user kishankavala commented on the pull request: https://github.com/apache/cloudstack/pull/233#issuecomment-101917044 --- Test set: com.cloud.hypervisor.kvm.resource.LibvirtComputingResourceTest --- Tests run: 143, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 1.744 sec FAILURE! - in com.cloud.hypervisor.kvm.resource.LibvirtComputingResourceTest testGetHostStatsCommand(com.cloud.hypervisor.kvm.resource.LibvirtComputingResourceTest) Time elapsed: 0.185 sec ERROR! java.lang.Exception: Unexpected exception, expectedjava.lang.NumberFormatException but wasjava.lang.NullPointerException at com.cloud.hypervisor.kvm.resource.wrapper.LibvirtGetHostStatsCommandWrapper.execute(LibvirtGetHostStatsCommandWrapper.java:77) at com.cloud.hypervisor.kvm.resource.wrapper.LibvirtGetHostStatsCommandWrapper.execute(LibvirtGetHostStatsCommandWrapper.java:34) at com.cloud.hypervisor.kvm.resource.wrapper.LibvirtRequestWrapper.execute(LibvirtRequestWrapper.java:182) at com.cloud.hypervisor.kvm.resource.LibvirtComputingResourceTest.testGetHostStatsCommand(LibvirtComputingResourceTest.java:930) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: GetUsageRecordsCmd - NewInputFormat for S...
Github user kishankavala commented on the pull request: https://github.com/apache/cloudstack/pull/185#issuecomment-95800447 @svscorp Commit looks good to me. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-8335: use libvirt from central...
Github user kishankavala commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/163#discussion_r28395781
--- Diff: plugins/hypervisors/kvm/pom.xml ---
@@ -45,7 +38,7 @@
version${project.version}/version
/dependency
dependency
- groupIdorg.libvirt/groupId
+ groupIdcom.github.K0zka/groupId
--- End diff --
@K0zka Can we use something like org.apache.cloudstack.libvirt instead ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
