[GitHub] cloudstack issue #1929: CLOUDSTACK-9770: fix missing ip routes in VR

[murali-reddy]

Github user murali-reddy commented on the issue:

https://github.com/apache/cloudstack/pull/1929
  
LGTM. thanks @ustcweizhou 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: [PROPOSAL] add native container orchestration service

[Murali Reddy]

Thanks for the feedback. There have been some concerns here with this proposal. 
I think we had sufficient valid arguments why we need this functionality in 
CloudStack. While this proposal is to use k8s as container orchestrator design 
should be able to adopt other container orchestrator.


Unless anybody has any specific technical points on this, I'd like to go on 
with its implementation and open up a PR.


Kishan, when do you think you can share further details (northbound API 
semantics etc) on the work you are doing? I am planning to get this feature the 
for 4.11. 



On 31/01/17, 5:54 PM, "Will Stevens" <williamstev...@gmail.com> wrote:

>I think that is covered in this proposal. There is nothing k8s specific in
>this integration (from what I understand), all the k8s details are passed
>in via the cloud-init configuration after the cluster has been provisioned.
>
>On Jan 31, 2017 3:06 AM, "Lianghwa Jou" <lianghwa@accelerite.com> wrote:
>
>
>There are many container orchestrators. Those container orchestrators are
>happy to run on any VMs or bare metal machines. K8s is just one of them and
>there will be more in the future. It may not be a good idea to make
>CloudStack to be k8s aware. IMO, the relationship between k8s and
>cloudstack should be similar to application and os. It probably not a good
>idea to make your OS to be aware of any specific applications so IMHO I
>don’t think k8s should be native to CloudStack. It makes more sense to
>provide some generic services that many applications can take advantages
>of. Some generic resource grouping service makes sense so a group of VMs,
>baremetal machines or network can be treated as a single entity. Some life
>cycle management will be necessary for these entities too. We can deploy
>k8s, swarm, dcos or even non-container specific services on top of
>CloudStack. The k8s is changing fast. One single tenant installation may
>need more than one VM group and may actually requires more (k8s
>federation). It will be a struggle to be in sync if we try to bring k8s
>specific knowledge into cloudstack.
>
>Regards,
>
>
>--
>Lianghwa Jou
>VP Engineering, Accelerite
>email: lianghwa@accelerite.com
>
>
>
>
>
>On 1/29/17, 11:54 PM, "Murali Reddy" <murali.re...@shapeblue.com> wrote:
>
>
>I agree with some good views Will has shared and I also agree to the
>concerns raised by Wido and Eric. IMO we need balance of staying
>relevant/add new features vs stability of CloudStack and take corrective
>action if needed. We have two good examples for both. When SDN was hot
>technology CloudStack ended up with bunch of SDN controller integrations.
>Few years later, now CloudStack is carrying baggage with no maintainers for
>those plugins, with probably not many of CloudStack users needing overlays.
>On the other hand, other than attempt to liaison with ETSI for NFV no
>effort was done. OpenStack has become de-facto for NFV. Now for OpenStack,
>arguably NFV has become larger use case than cloud it self. I concur with
>Will’s point that with minimal viable solution that does not change the
>core of CloudStack, and can keep CloudStack relevant is worth to be taken
>in.
>
>Will,
>
>To your question of how different is from ShapeBlue’s container
>service, its design, implementation and API semantics etc remain same.
>ShapeBlue’s container service was true drop in plug-in to CloudStack, with
>this proposal I am trying to re-work to make it a core CloudStack pluggable
>service which is part of CloudStack.
>
>Key concepts that this proposal is trying to add
>
>- add notion of ‘container cluster’ as a first class entity in
>CloudStack. Which is bacially collection of other CloudStack resources
>(like VM’s, networks, public ip, network rules etc)
>- life cycle operation to manage ‘container cluster’ like create,
>delete, start, stop, scale-up, scale-down, heal etc
>- orchestrate container orchestrator control plane on top of
>provisioned resources
>
>At-least for k8s (which is what this proposal is targeting),
>integration with k8s is bare minimum. There are cloud-config scripts that
>automatically setup k8s cluster master and node VM’s. All CloudStack is
>doing in passing the cloud-config to the core OS VM’s as user data.
>
>Regards
>Murali Reddy
>
>
>
>
>
>
>
>On 29/01/17, 8:54 AM, "Will Stevens" <williamstev...@gmail.com on
>behalf of wstev...@cloudops.com> wrote:
>
>>I agree that we need to be careful what we take on and own inside
>>CloudStack.  I feel like some of the plugins or integrations which we
>have
>>been "maintaining" may serve us bette

Re: [PROPOSAL] add native container orchestration service

[Murali Reddy]

I agree with some good views Will has shared and I also agree to the concerns 
raised by Wido and Eric. IMO we need balance of staying relevant/add new 
features vs stability of CloudStack and take corrective action if needed. We 
have two good examples for both. When SDN was hot technology CloudStack ended 
up with bunch of SDN controller integrations. Few years later, now CloudStack 
is carrying baggage with no maintainers for those plugins, with probably not 
many of CloudStack users needing overlays. On the other hand, other than 
attempt to liaison with ETSI for NFV no effort was done. OpenStack has become 
de-facto for NFV. Now for OpenStack, arguably NFV has become larger use case 
than cloud it self. I concur with Will’s point that with minimal viable 
solution that does not change the core of CloudStack, and can keep CloudStack 
relevant is worth to be taken in. 

Will,

To your question of how different is from ShapeBlue’s container service, its 
design, implementation and API semantics etc remain same. ShapeBlue’s container 
service was true drop in plug-in to CloudStack, with this proposal I am trying 
to re-work to make it a core CloudStack pluggable service which is part of 
CloudStack. 

Key concepts that this proposal is trying to add

- add notion of ‘container cluster’ as a first class entity in CloudStack. 
Which is bacially collection of other CloudStack resources (like VM’s, 
networks, public ip, network rules etc)
- life cycle operation to manage ‘container cluster’ like create, delete, 
start, stop, scale-up, scale-down, heal etc
- orchestrate container orchestrator control plane on top of provisioned 
resources

At-least for k8s (which is what this proposal is targeting), integration with 
k8s is bare minimum. There are cloud-config scripts that automatically setup 
k8s cluster master and node VM’s. All CloudStack is doing in passing the 
cloud-config to the core OS VM’s as user data.

Regards
Murali Reddy







On 29/01/17, 8:54 AM, "Will Stevens" <williamstev...@gmail.com on behalf of 
wstev...@cloudops.com> wrote:

>I agree that we need to be careful what we take on and own inside
>CloudStack.  I feel like some of the plugins or integrations which we have
>been "maintaining" may serve us better to abandon, but I feel like that is
>a whole discussion on its own.
>
>In this case, I feel like there is a minimum viable solution which puts
>CloudStack in a pretty good place to enable container orchestration.  For
>example, one of the biggest challenges with K8S is the fact that it is
>single tenant.  CloudStack has good multi tenancy support and has the
>ability to orchestrate the underlying infra quite well.  We will have to be
>very careful not to try to own too deep into the K8S world though, in my
>opinion.  We only want to be responsible for providing the infra (and a way
>to bootstrap K8S ideally) and be able to scale the infra, everything else
>should be owned by the K8S on top.  That is the way I see it anyway, but
>please add your input.
>
>I think it is a liability to try to go too deep, for the same reasons Wido
>and Erik have mentioned.  But I also think we need to take it seriously
>because that train is moving and this may be a good opportunity to stay
>relevant in a rapidly changing market.
>
>*Will STEVENS*
>Lead Developer
>
><https://goo.gl/NYZ8KK>
>
>On Sat, Jan 28, 2017 at 1:13 PM, Wido den Hollander <w...@widodh.nl> wrote:
>
>>
>> > Op 27 januari 2017 om 16:08 schreef Will Stevens <wstev...@cloudops.com
>> >:
>> >
>> >
>> > Hey Murali,
>> > How different is this proposal than what ShapeBlue already built.  It
>> looks
>> > pretty consistent with the functionality that you guys open sourced in
>> > Seville.
>> >
>> > I have not yet used this functionality, but I have reports that it works
>> > quite well.
>> >
>> > I believe the premise here is to only orchestrate the VM layer and
>> > basically expose a "group" of running VMs to the user.  The user is
>> > responsible for configuring K8S or whatever other container orchestrator
>> on
>> > top.  I saw mention of the "cloud-config" scripts in the FS, how are
>> those
>> > exposed to the cluster?  Maybe the FS can expand on that a bit?
>> >
>> > I believe the core feature that is being requested to be added is the
>> > ability to create a group of VMs which will be kept active as a group if
>> at
>> > all possible.  ACS would be responsible for making sure that the number
>> of
>> > VMs specified for the group are in running state and it would spin up new
>> > VMs as needed in order to satisfy the group settings. 

Re: [PROPOSAL] add native container orchestration service

[Murali Reddy]

Wido,

This proposal is not suggesting CloudStack do the job of container 
orchestration like you mentioned we have number of purpose built options for 
that. 



As described in the FS, running containers on VM’s provisioned by IAAS is 
popular deployment model. If user wants to do same on CloudStack, user can 
provision VM’s and use ansible/terraform to deploy container orchestrator 
control plane and cluster nodes. What this proposal is suggesting to add higher 
abstraction that can automate this and additional operations to act on a 
cluster of VM’s as a cohesive unit. Proposed container service can have plugin 
for swarm, marathon, nomad, etc to automate setting up container orchestrator 
control place. For this proposal CloudStack container service will integrate 
with Kubernetes to start with.

As analogy, any body can deploy container orchestrator on the AWS provisioned 
VM, but there is value why AWS provides native functionality with AWS ECS. Same 
goes with google's GKE.


On 27/01/17, 3:20 PM, "Wido den Hollander" <w...@widodh.nl> wrote:

>
>> Op 27 januari 2017 om 7:20 schreef Murali Reddy <muralimmre...@gmail.com>:
>> 
>> 
>> All,
>> 
>> I would like propose native functionality into CloudStack to provide a 
>> container service through which users out-of-the box can use to launch 
>> container based application. Idea is to support ability to orchestrate the 
>> resources and automate aspects of setting up container orchestrator through 
>> CloudStack. Public IAAS service providers AWS with its ECS [1] and google 
>> with GKE [2] already provides ability container applications.  Competitive 
>> cloud orchestration platforms already have native support for container 
>> service. Users of CloudStack both as public cloud providers and users with 
>> private clouds will benefit with such functionality.
>> 
>
>Sorry, how much I appreciate the effort and work you already invested in this 
>I'm against this.
>
>There are many, many tools which can run inside KVM/Xen/VMWare and do the 
>container orchestration much, much better then I think CloudStack will ever do.
>
>We tried with LXC, but that failed.
>
>For example:
>- Kubernetes
>- Nomad
>- Docker Swarm
>- Apache Mesos
>- CoreOS in the basics
>
>Just a small number of tools which run Containers just fine while being INSIDE 
>a VM.
>
>We still have a long road to go in perfectioning the existing HVs inside 
>CloudStack. I wouldn't want to put resources on testing such a feature which 
>in my opinion does not benefit the project.
>
>CloudStack should imho be mean and lean'. Be damn good and simple in what it 
>does: Running VMs and their network(s).
>
>Wido
>
>> While container orchestrator of user choice can be provisioned on top of 
>> CloudStack (with out CloudStack being involved) with tools like 
>> TerraForm[3], Ansible[4] etc, advantage of having native orchestration is 
>> giving user a nice cohesive integration. This proposal would like add a 
>> notion of first class CloudStack entity called container cluster which can 
>> be used to provision resources, scale up, scale down, start and stop the 
>> cluster of VM’s on which containerised applications can be run. For actual 
>> container orchestration we will still need container orchestrator like 
>> docker swarm, marathon, kubernetes, but CloudStack container service can 
>> automate setting up of control place automatically.
>> 
>> Please see the detailed FS [5], and jira ticket [6]. 
>> 
>> [1]http://docs.aws.amazon.com/AmazonECS/latest/developerguide/Welcome.html
>> [2]https://cloud.google.com/container-engine/
>> [3] https://github.com/skippbox/ansible-cloudstack
>> [4]https://github.com/chiradeep/terraform-cloudstack-examples/tree/master/kubernetes-coreos-isolated-nw
>> [5] 
>> https://cwiki.apache.org/confluence/display/CLOUDSTACK/CloudStack+container+service+functional+specification+and+design+document
>> [6]https://issues.apache.org/jira/browse/CLOUDSTACK-9760
>> 
>>

murali.re...@shapeblue.com 
www.shapeblue.com
53 Chandos Place, Covent Garden, London  WC2N 4HSUK
@shapeblue
  
 

[PROPOSAL] add native container orchestration service

[Murali Reddy]

All,

I would like propose native functionality into CloudStack to provide a 
container service through which users out-of-the box can use to launch 
container based application. Idea is to support ability to orchestrate the 
resources and automate aspects of setting up container orchestrator through 
CloudStack. Public IAAS service providers AWS with its ECS [1] and google with 
GKE [2] already provides ability container applications.  Competitive cloud 
orchestration platforms already have native support for container service. 
Users of CloudStack both as public cloud providers and users with private 
clouds will benefit with such functionality.

While container orchestrator of user choice can be provisioned on top of 
CloudStack (with out CloudStack being involved) with tools like TerraForm[3], 
Ansible[4] etc, advantage of having native orchestration is giving user a nice 
cohesive integration. This proposal would like add a notion of first class 
CloudStack entity called container cluster which can be used to provision 
resources, scale up, scale down, start and stop the cluster of VM’s on which 
containerised applications can be run. For actual container orchestration we 
will still need container orchestrator like docker swarm, marathon, kubernetes, 
but CloudStack container service can automate setting up of control place 
automatically.

Please see the detailed FS [5], and jira ticket [6]. 

[1]http://docs.aws.amazon.com/AmazonECS/latest/developerguide/Welcome.html
[2]https://cloud.google.com/container-engine/
[3] https://github.com/skippbox/ansible-cloudstack
[4]https://github.com/chiradeep/terraform-cloudstack-examples/tree/master/kubernetes-coreos-isolated-nw
[5] 
https://cwiki.apache.org/confluence/display/CLOUDSTACK/CloudStack+container+service+functional+specification+and+design+document
[6]https://issues.apache.org/jira/browse/CLOUDSTACK-9760

[GitHub] cloudstack issue #1856: CLOUDSTACK-9569: propagate global configuration rout...

[murali-reddy]

Github user murali-reddy commented on the issue:

https://github.com/apache/cloudstack/pull/1856
  
@ustcweizhou this will be useful for 4.9 as well, would you mind rebasing 
the patch to 4.9?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request #1856: CLOUDSTACK-9569: propagate global configurati...

[murali-reddy]

Github user murali-reddy commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1856#discussion_r93599467
  
--- Diff: 
core/src/com/cloud/agent/resource/virtualnetwork/VirtualRoutingResource.java ---
@@ -259,8 +260,18 @@ private Answer execute(GetDomRVersionCmd cmd) {
 return new GetDomRVersionAnswer(cmd, result.getDetails(), 
lines[0], lines[1]);
 }
 
+public boolean configureHostParams(final Map<String, String> params) {
+if (_params.get("router.aggregation.command.each.timeout") == 
null) {
--- End diff --

Why do we need this check?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1804: CLOUDSTACK-9639: Unable to create shared network wit...

[murali-reddy]

Github user murali-reddy commented on the issue:

https://github.com/apache/cloudstack/pull/1804
  
LGTM.

a small side note. User can create a guest VM with nic's in two networks 
with same CIDR but different VLAN isolations and mess-up routing.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1837: [4.9] Smoketest Health

[murali-reddy]

Github user murali-reddy commented on the issue:

https://github.com/apache/cloudstack/pull/1837
  
 @blueorangutan test centos7 xenserver-65sp1


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1837: [4.9] Smoketest Health

[murali-reddy]

Github user murali-reddy commented on the issue:

https://github.com/apache/cloudstack/pull/1837
  
@blueorangutan test centos7 vmware-55u3


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1519: Cloudstack 9339: Virtual Routers do not handle Multi...

[murali-reddy]

Github user murali-reddy commented on the issue:

https://github.com/apache/cloudstack/pull/1519
  
@dsclose #1659 is merged, so you can close this PR if you wish. Though 
issue related to redundant VR fixed by commit d582358, bf285e1  in this PR are 
not addressed by #1659, and still a open issue.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1828: CLOUDSTACK-9676 Start instance fails after reverting...

[murali-reddy]

Github user murali-reddy commented on the issue:

https://github.com/apache/cloudstack/pull/1828
  
@blueorangutan test centos7 vmware-55u3


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1828: CLOUDSTACK-9676 Start instance fails after reverting...

[murali-reddy]

Github user murali-reddy commented on the issue:

https://github.com/apache/cloudstack/pull/1828
  
@blueorangutan package


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: [VOTE] Apache Cloudstack 4.9.1.0 (RC1)

[Murali Reddy]

+1

Based on smoke test results [1] and below tests run manually on VMware 
deployment

  - VM life cycle operations
  - network life cycle operations
  - verified source NAT, static NAT, PF, LB, VPC internal LB, network ACL, 
firewall
  - upgrade from 4.9 and 4.5.2


IMO issue raised by Milamber should be fixed on 4.10. If the functionality does 
not exist in 4.9, then no need to have schema change in 4.8 to 4.9 upgrade path.

Redundant VPC VR functionality appears to be broken from last few releases. In 
my testing noticed both the VR getting stuck in backup or in unknown state. RVR 
test failed consistently in smoke tests [1]. We should at least release note 
them as known issues. I will check existing bugs and open new one if necessary.

[1] https://github.com/apache/cloudstack/pull/1753




On 14/12/16, 12:32 AM, "Milamber"  wrote:

>
>Hello,
>
>I'm not sure, but perhaps we have an 'indirect' blocker for 4.9.1.0 RC1.
>
>Currently the upgrade from 4.9.1.0 RC1 to 4.10.0.0 SNAPSHOT don't works 
>because the schema-481to490.sql in the 4.9.1.0 / 4.9 doesn't contains 
>the commit of CLOUDSTACK-9438 (2e77496601ab5420723ce8b955b3960faaba7d5c).
>(this commit is currently in master)
>
>When you try to make the upgrade you have this error: "Unknown column 
>'image_store_details.display' in 'field list'"
>see:  https://issues.apache.org/jira/browse/CLOUDSTACK-9671
>
>Currently there have 2 diff between the schema-481to490.sql in 4.9.1.0 
>RC1 (and 4.9 branch) and master branch.
>
>What is your opinion: blocker or not?
>
>Just copy the 2 sql request inside the schema-4910to41000.sql file (but 
>the commit 2e77496601ab5420723ce8b955b3960faaba7d5c contains other 
>modified files)?
>
>Milamber
>
>
>
>$ diff ./setup/db/db/schema-481to490.sql /tmp/MASTER-schema-481to490.sql
>547a548,552
> >
> > ALTER TABLE `cloud`.`image_store_details` CHANGE COLUMN `value` 
>`value` VARCHAR(255) NULL DEFAULT NULL COMMENT 'value of the detail', 
>ADD COLUMN `display` tinyint(1) NOT
> > NULL DEFAULT '1' COMMENT 'True if the detail can be displayed to the 
>end user' AFTER `value`;
> >
> > ALTER TABLE `snapshots` ADD COLUMN `location_type` VARCHAR(32) 
>COMMENT 'Location of snapshot (ex. Primary)';
>
>
>
>
>
>On 12/12/2016 21:36, Milamber wrote:
>> Hello,
>>
>> My vote +1 (binding)
>>
>> Tests are passed on a virtual topology of servers  (CS over CS) 
>> (1mgr+2nodes+1nfs) :
>>
>> 1/ Fresh install of 4.9.1.0 RC1 (adv net) on Ubuntu 14.04.5 + KVM + 
>> NFS : OK
>> Some standard tests with success (create vm, migration, HA, create 
>> networks, create user, create ssh key, destroy vm, register template, 
>> create snapshot, restore snapshot, create template, ip association, ip 
>> release, static nat, firewall rule)
>> Some tests with cloudstack ansible module with success too (create 
>> network, register templates, create vm, ip, firewall rule)
>>
>> 2/ Test upgrade from 4.8.1 to 4.9.1.0 RC1 : OK
>>
>> 3/ Test upgrade from 4.8.2 RC1 to 4.9.1.0 RC1 : don't works (expected)
>>
>> 4/ Tests of all localization Web UI for 4.9.1.0 RC1:
>> Localization works well except Spanish (not a blocker to release): the 
>> Web UI display partially the localization strings due of one bad 
>> carriage return in the label 
>> message.installWizard.copy.whatIsCloudStack string (from Transifex). 
>> This is the same issue that the 4.8.2 RC1.
>>
>>
>> Perhaps add in the Release notes this Spanish l10n issue.
>>
>> Thanks to the RM.
>>
>> Milamber
>>
>>
>>
>> On 10/12/2016 03:11, Rohit Yadav wrote:
>>> Hi All,
>>>
>>> I've created a 4.9.1.0 release, with the following artifacts up for a 
>>> vote:
>>>
>>> Git Branch and Commit SH:
>>> https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;a=shortlog;h=refs/heads/4.9.1.0-RC20161210T0838
>>>  
>>>
>>> Commit: af2679959b634d095b93b8265c6da294d360065d
>>>
>>> List of changes:
>>> https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;a=blob_plain;f=CHANGES;hb=4.9.1.0-RC20161210T0838
>>>  
>>>
>>>
>>> Source release (checksums and signatures are available at the same
>>> location):
>>> https://dist.apache.org/repos/dist/dev/cloudstack/4.9.1.0/
>>>
>>> PGP release keys (signed using 0EE3D884):
>>> https://dist.apache.org/repos/dist/release/cloudstack/KEYS
>>>
>>> Vote will be open for 120 hours, considering the process started 
>>> during the
>>> weekends, and will end on 14 Dec 2016 end of the day.
>>>
>>> For sanity in tallying the vote, can PMC members please be sure to 
>>> indicate
>>> "(binding)" with their vote?
>>>
>>> [ ] +1  approve
>>> [ ] +0  no opinion
>>> [ ] -1  disapprove (and reason why)
>>>
>>> Regards.
>>>
>>
>>
>

[GitHub] cloudstack issue #1783: CLOUDSTACK-9615: Fixd applying ingress rules without...

[murali-reddy]

Github user murali-reddy commented on the issue:

https://github.com/apache/cloudstack/pull/1783
  
LGTM.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1823: CLOUDSTACK-9594: Fix regression in test_templates

[murali-reddy]

Github user murali-reddy commented on the issue:

https://github.com/apache/cloudstack/pull/1823
  
LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request #1821: CLOUDSTACK-9659: mismatch in traffic type in ...

[murali-reddy]

GitHub user murali-reddy opened a pull request:

https://github.com/apache/cloudstack/pull/1821

CLOUDSTACK-9659: mismatch in traffic type in ip_associations.json and 
ips.json

As part of the bug 'CLOUDSTACK-9339 Virtual Routers don't handle Multiple 
Public Interfaces correctly'
issue of mismatch of traffic type represented by 'nw_type' in config sent 
by management server in
ip_associations.json and how it is persisted in the ips.json data bag are 
differnet,
is addressed, however missed the change in final merge.
this bug is to add the functionality in cs_ip.py, to lower the traffic type 
sent by management server before persisting in the ips.json databag

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/murali-reddy/cloudstack 
traffic_type_in_lower_case

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/1821.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1821


commit 8b4c36ef501a96742c52b4d532cc3adda25aa71b
Author: Murali Reddy <muralimmre...@gmail.com>
Date:   2016-12-08T08:49:01Z

CLOUDSTACK-9659: mismatch in traffic type in ip_associations.json and 
ips.json

As part of the bug 'CLOUDSTACK-9339 Virtual Routers don't handle Multiple 
Public Interfaces correctly'
issue of mismatch of traffic type represented by 'nw_type' in config sent 
by management server in
ip_associations.json and how it is persisted in the ips.json data bag are 
differnet,
is addressed, however missed the change in final merge.
this bug is to add the functionality in cs_ip.py, to lower the traffic type 
sent by management server before persisting in the ips.json databag




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1579: CLOUDSTACK-9403 : Support for shared networks in Nua...

[murali-reddy]

Github user murali-reddy commented on the issue:

https://github.com/apache/cloudstack/pull/1579
  
code changes LGTM

Travis run has been failing due to test 'test_create_volume_under_domain' 
for all the PR's. Lets wait till we fix the test or disable this component test.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1659: CLOUDSTACK-9339 Virtual Routers don't handle Multipl...

[murali-reddy]

Github user murali-reddy commented on the issue:

https://github.com/apache/cloudstack/pull/1659
  
component test results. If any one wish to run component test 
test_multiple_public_interfaces.py, add a new public ip range in the 
test_daya.py, in the 'publiciprange' dict object.

Test iptable rules in case we have IP associated with a network which is in 
... === TestName: test_iptable_rules | Status : SUCCESS ===
ok
Test for port forwarding on a IP which is in pubic IP range different ... 
=== TestName: test_port_forwarding_on_ip_from_non_src_nat_ip_range | Status : 
SUCCESS ===
ok
Test routing table in case we have IP associated with a network which is in 
... === TestName: test_routing_tables | Status : SUCCESS ===
ok
Test for static nat on a IP which is in pubic IP range different ... === 
TestName: test_static_nat_on_ip_from_non_src_nat_ip_range | Status : SUCCESS ===
ok
Test Create VPC PF rules on acquired public ip when VpcVirtualRouter is 
Running ... === TestName: test_network_services_VPC_CreatePF | Status : SUCCESS 
===
ok
Test Create VPC PF rules on acquired public ip when VpcVirtualRouter is 
Running ... === TestName: test_network_services_VPC_CreatePF | Status : SUCCESS 
===
ok

--
Ran 6 tests in 1539.183s

OK


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1659: CLOUDSTACK-9339 Virtual Routers don't handle Multipl...

[murali-reddy]

Github user murali-reddy commented on the issue:

https://github.com/apache/cloudstack/pull/1659
  
@rhtyd please proceed with merge. I have not added the test 
suite(test_multiple_public_interfaces.py) part of this PR as smoke tests, 
because it takes around an hour for execution so they are best fit for 
component testing. Also tests need routable additional public IP range for the 
test case to succeed.

I will run component test against 1753/1754 and report back results.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1799: CLOUDSTACK-9632: Upgrade bouncy castle to version 1....

[murali-reddy]

Github user murali-reddy commented on the issue:

https://github.com/apache/cloudstack/pull/1799
  
code change LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1659: CLOUDSTACK-9339 Virtual Routers don't handle Multipl...

[murali-reddy]

Github user murali-reddy commented on the issue:

https://github.com/apache/cloudstack/pull/1659
  
Can this merged now? test failures are specific to redundent VR/VPC VR 
which have been failing in 4.8/4.9/master.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1604: improvement: systemvm slow operations

[murali-reddy]

Github user murali-reddy commented on the issue:

https://github.com/apache/cloudstack/pull/1604
  
@romain-dartigues we fixed issue where ips.json has wrong gateway due to 
error in parsing the cmd_line.json. its committed in 4.8 and above [1]. Do you 
still see (or can you please verify)  performance hit due to arpping to wrong 
gateway on 4.8/4.9/master?

[1] 
https://github.com/apache/cloudstack/pull/1692/commits/93ac134f1e5c4c4c22029eca241f75362303837a


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1784: CS-505: Marvin test to check VR internal DNS Service

[murali-reddy]

Github user murali-reddy commented on the issue:

https://github.com/apache/cloudstack/pull/1784
  
@abhinandanprateek Multi-nic will be different scenario, we can skip that 
in this test case.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1802: CLOUDSTACK-9635: fix test_privategw_acl.py

[murali-reddy]

Github user murali-reddy commented on the issue:

https://github.com/apache/cloudstack/pull/1802
  
This is good to be merged now. test_privategw_acl.py is passing mostly. 
there are still intermittent failures (not addressed by this PR) in the 
test_privategw_acl.py like create and delete VPC failing, i will investigate 
separately.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1802: CLOUDSTACK-9635: fix test_privategw_acl.py

[murali-reddy]

Github user murali-reddy commented on the issue:

https://github.com/apache/cloudstack/pull/1802
  
@blueorangutan package


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1802: CLOUDSTACK-9635: fix test_privategw_acl.py

[murali-reddy]

Github user murali-reddy commented on the issue:

https://github.com/apache/cloudstack/pull/1802
  
@jburwell This PR is not rebased to fix from #1801. This PR is confined to 
test_privategw_acl.py, so no scope of any regression out side of it.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1802: CLOUDSTACK-9635: fix test_privategw_acl.py

[murali-reddy]

Github user murali-reddy commented on the issue:

https://github.com/apache/cloudstack/pull/1802
  
@jburwell this PR is ready for merge. PR fixes intermittent failures of 
suite of tests in test_privategw_acl.py.

test_04_rvpc_privategw_static_routesSuccess 553.97  
test_privategw_acl.py
test_03_vpc_privategw_restart_vpc_cleanup   Success 536.06  
test_privategw_acl.py
test_02_vpc_privategw_static_routes Success 402.64  test_privategw_acl.py
test_01_vpc_privategw_acl   Success 100.53


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1802: CLOUDSTACK-9635: fix test_privategw_acl.py

[murali-reddy]

Github user murali-reddy commented on the issue:

https://github.com/apache/cloudstack/pull/1802
  
@blueorangutan test


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1802: CLOUDSTACK-9635: fix test_privategw_acl.py

[murali-reddy]

Github user murali-reddy commented on the issue:

https://github.com/apache/cloudstack/pull/1802
  
@blueorangutan package


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1801: fix marvin test failure test_router_dhcp_opts

[murali-reddy]

Github user murali-reddy commented on the issue:

https://github.com/apache/cloudstack/pull/1801
  
test_router_dhcp_opts is passing, and we have necessary LGTM's. can we 
merge this?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1802: CLOUDSTACK-9635: fix test_privategw_acl.py

[murali-reddy]

Github user murali-reddy commented on the issue:

https://github.com/apache/cloudstack/pull/1802
  
@blueorangutan test centos6 kvm-centos6


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1802: CLOUDSTACK-9635: fix test_privategw_acl.py

[murali-reddy]

Github user murali-reddy commented on the issue:

https://github.com/apache/cloudstack/pull/1802
  
 @blueorangutan test centos7 kvm-centos6


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1802: CLOUDSTACK-9635: fix test_privategw_acl.py

[murali-reddy]

Github user murali-reddy commented on the issue:

https://github.com/apache/cloudstack/pull/1802
  
@blueorangutan package


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request #1802: CLOUDSTACK-9635: fix test_privategw_acl.py

[murali-reddy]

GitHub user murali-reddy opened a pull request:

https://github.com/apache/cloudstack/pull/1802

CLOUDSTACK-9635: fix test_privategw_acl.py

ensure VLAN used for createPrivateGateway is determined after the guest
networks in the VPC is created, so that we skip VLAN allocated for guest
network for the private network of vpc gateway

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/murali-reddy/cloudstack test_privategw_acl

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/1802.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1802


commit 16c86d78471d169ff5135ab54a243f18c403c202
Author: Murali Reddy <muralimmre...@gmail.com>
Date:   2016-11-30T13:06:43Z

CLOUDSTACK-9635: fix test_privategw_acl.py

ensure VLAN used for createPrivateGateway is determined after the guest
networks in the VPC is created, so that we skip VLAN allocated for guest
network for the private network of vpc gateway




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request #1801: fix marvin test failure test_router_dhcp_opts

[murali-reddy]

GitHub user murali-reddy opened a pull request:

https://github.com/apache/cloudstack/pull/1801

fix marvin test failure test_router_dhcp_opts

marvin, VirtualMachine objects are not in any particualr order in the 
array. so
check isdefault attribute to the get non-default nic

earlier test made assumption that nic[0] is default nic, which is not true 
always

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/murali-reddy/cloudstack test_router_dhcp_opts

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/1801.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1801


commit e3912820deeda54942af797dc89bf0dc5e1f53fe
Author: Murali Reddy <muralimmre...@gmail.com>
Date:   2016-11-30T10:49:38Z

fix test failure test_router_dhcp_opts

marvin, VirtualMachine objects are not in any particualr order in the 
array. so
check isdefault attribute the get non-default nic




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1659: CLOUDSTACK-9339 Virtual Routers don't handle Multipl...

[murali-reddy]

Github user murali-reddy commented on the issue:

https://github.com/apache/cloudstack/pull/1659
  
@blueorangutan test


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1659: CLOUDSTACK-9339 Virtual Routers don't handle Multipl...

[murali-reddy]

Github user murali-reddy commented on the issue:

https://github.com/apache/cloudstack/pull/1659
  
@blueorangutan test centos7 kvm-centos7


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1787: fix syntax error introduced in CsDhcp.py

[murali-reddy]

Github user murali-reddy commented on the issue:

https://github.com/apache/cloudstack/pull/1787
  
closing, as its addressed by #1788


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request #1787: fix syntax error introduced in CsDhcp.py

[murali-reddy]

Github user murali-reddy closed the pull request at:

https://github.com/apache/cloudstack/pull/1787


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1787: fix syntax error introduced in CsDhcp.py

[murali-reddy]

Github user murali-reddy commented on the issue:

https://github.com/apache/cloudstack/pull/1787
  
@ blueorangutan package


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request #1787: fix syntax error introduced in CsDhcp.py

[murali-reddy]

GitHub user murali-reddy opened a pull request:

https://github.com/apache/cloudstack/pull/1787

fix syntax error introduced in CsDhcp.py

fix syntax error introduced in CsDhcp.py while forward merging fix for 
CS-9598 on to 4.9, 4.10 due to signature mismatch

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/murali-reddy/cloudstack vr_cs_dhcp_syntax_erro

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/1787.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1787


commit 8d5473d4392c0d22ad456f01482696ec99a16cde
Author: Murali Reddy <muralimmre...@gmail.com>
Date:   2016-11-27T08:22:44Z

fix syntax error introduced in CsDhcp.py while forward merging
fix for CS-9598 on to 4.9, 4.10 due to signature mismatch




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1766: CLOUDSTACK-9598: wrong defaut gateway for the nic in...

[murali-reddy]

Github user murali-reddy commented on the issue:

https://github.com/apache/cloudstack/pull/1766
  
@rhtyd it was packaging issue, in failed run my change was not picked


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1766: CLOUDSTACK-9598: wrong defaut gateway for the nic in...

[murali-reddy]

Github user murali-reddy commented on the issue:

https://github.com/apache/cloudstack/pull/1766
  
@rhtyd @abhinandanprateek @ustcweizhou  can you please review, we have 
clean test pass and new test test_router_dhcp_opts passing too.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1766: CLOUDSTACK-9598: wrong defaut gateway for the nic in...

[murali-reddy]

Github user murali-reddy commented on the issue:

https://github.com/apache/cloudstack/pull/1766
  
@blueorangutan test


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1766: CLOUDSTACK-9598: wrong defaut gateway for the nic in...

[murali-reddy]

Github user murali-reddy commented on the issue:

https://github.com/apache/cloudstack/pull/1766
  
@blueorangutan test


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1766: CLOUDSTACK-9598: wrong defaut gateway for the nic in...

[murali-reddy]

Github user murali-reddy commented on the issue:

https://github.com/apache/cloudstack/pull/1766
  
Added test case TestRouterDHCPOpts, that will test the VR behaviour of not 
sending gateway and DNS server information while server DHCP response on 
non-default network NIC's

@ustcweizhou i have used default_entry as per your comment, as it make more 
sense


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1766: CLOUDSTACK-9598: wrong defaut gateway for the nic in...

[murali-reddy]

Github user murali-reddy commented on the issue:

https://github.com/apache/cloudstack/pull/1766
  
@blueorangutan package


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1766: CLOUDSTACK-9598: wrong defaut gateway for the nic in...

[murali-reddy]

Github user murali-reddy commented on the issue:

https://github.com/apache/cloudstack/pull/1766
  
@blueorangutan test


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1766: CLOUDSTACK-9598: wrong defaut gateway for the nic in...

[murali-reddy]

Github user murali-reddy commented on the issue:

https://github.com/apache/cloudstack/pull/1766
  
@blueorangutan package


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request #1766: CLOUDSTACK-9598: wrong defaut gateway for the...

[murali-reddy]

GitHub user murali-reddy opened a pull request:

https://github.com/apache/cloudstack/pull/1766

 CLOUDSTACK-9598: wrong defaut gateway for the nic in non-default network

 when guest VM has nic's in more than one guest network set the tag for 
each host in /etc/dhcphosts.txt, and use the tag to add exception in 
/etc/dhcpopts.txt to prevent sending default route, dns server in case if the 
nic is in non-default network

this was the behaviour with edithosts.sh prior to 4.6

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/murali-reddy/cloudstack 
vr-default-network-gateway

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/1766.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1766


commit 17be6d806378cbacb21e8256e02e6d92188ed183
Author: Murali Reddy <muralimmre...@gmail.com>
Date:   2016-11-17T18:00:25Z

 CLOUDSTACK-9598: wrong defaut gateway for the nic in non-default network
 when guest VM has nic's in more than one guest network

 set the tag for each host in /etc/dhcphosts.txt, and use the tag to add 
exception
 in /etc/dhcpopts.txt to prevent sending default route, dns server in case 
if
 the nic is in non-default network




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1757: CLOUDSTACK-9583: VR: In CsDhcp.py preseed both hosta...

[murali-reddy]

Github user murali-reddy commented on the issue:

https://github.com/apache/cloudstack/pull/1757
  
@blueorangutan package


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1750: CLOUDSTACK-9583: VR: In CsDhcp.py preseed both hosta...

[murali-reddy]

Github user murali-reddy commented on the issue:

https://github.com/apache/cloudstack/pull/1750
  
opened #1757 targeting 4.8 so closed this PR


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request #1757: CLOUDSTACK-9583: VR: In CsDhcp.py preseed bot...

[murali-reddy]

GitHub user murali-reddy opened a pull request:

https://github.com/apache/cloudstack/pull/1757

CLOUDSTACK-9583: VR: In CsDhcp.py preseed both hostaname and localhost to 
resolve to 127.0.0.1



The VR executes a ip route flush command as part of configurations. This 
command performs a
DNS lookup on the VR hostname. Since the VR does not have a DNS entry, the 
ip command would
wait 5 seconds before timing out and executing the flush operation. This 
fix adds the VR
hostname to /etc/hosts mapped to 127.0.0.1 to answer the DNS lookup – 
reducing the
execution time.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/murali-reddy/cloudstack vr_dhcp_entries

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/1757.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1757


commit 4c4696e5e43a870b7504dfde735bc3afd04a843e
Author: Murali Reddy <muralimmre...@gmail.com>
Date:   2016-11-10T07:55:22Z

CLOUDSTACK-9583: VR: In CsDhcp.py preseed both hostaname and localhost to 
resolve to 127.0.0.1

The VR executes a ip route flush command as part of configurations. This 
command performs a
DNS lookup on the VR hostname. Since the VR does not have a DNS entry, the 
ip command would
wait 5 seconds before timing out and executing the flush operation. This 
fix adds the VR
hostname to /etc/hosts mapped to 127.0.0.1 to answer the DNS lookup – 
reducing the
execution time.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request #1750: CLOUDSTACK-9583: VR: In CsDhcp.py preseed bot...

[murali-reddy]

Github user murali-reddy closed the pull request at:

https://github.com/apache/cloudstack/pull/1750


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1751: systemd: Fix semicolon missing in b75e69

[murali-reddy]

Github user murali-reddy commented on the issue:

https://github.com/apache/cloudstack/pull/1751
  
LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1706: CLOUDSTACK-9500: remove the IP from the databag if i...

[murali-reddy]

Github user murali-reddy commented on the issue:

https://github.com/apache/cloudstack/pull/1706
  
@jburwell #1659 has a fix which complements this patch.Basically when first 
IP is associated with an interface routing table is created and should be 
deleted when last IP associated is removed. #1659 handles that case.

@vilisseranen  could you please see if there is regression. Looks like IP 
may be getting removed from ips.json data bag, but not really getting 
dis-associated from the interface. Failure in below tests indicate so.

test_network_rules_acquired_public_ip_3_Load_Balancer_Rule  Failure 36.36   
test_network.py
test_network_rules_acquired_public_ip_2_nat_ruleFailure 31.31   
test_network.py
est_network_rules_acquired_public_ip_1_static_nat_rule  Failure 93.29   
test_network.py




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1750: CLOUDSTACK-9583: VR: In CsDhcp.py preseed both hosta...

[murali-reddy]

Github user murali-reddy commented on the issue:

https://github.com/apache/cloudstack/pull/1750
  
@blueorangutan test


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1750: CLOUDSTACK-9583: VR: In CsDhcp.py preseed both hosta...

[murali-reddy]

Github user murali-reddy commented on the issue:

https://github.com/apache/cloudstack/pull/1750
  
@blueorangutan test


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1673: CLOUDSTACK-9071: Properly parse stats.output.uri in ...

[murali-reddy]

Github user murali-reddy commented on the issue:

https://github.com/apache/cloudstack/pull/1673
  
@jburwell failures are redundant VPC related being tracked CLOUDSTACK-9541


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1750: CLOUDSTACK-9583: VR: In CsDhcp.py preseed both hosta...

[murali-reddy]

Github user murali-reddy commented on the issue:

https://github.com/apache/cloudstack/pull/1750
  
@blueorangutan package


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request #1750: CLOUDSTACK-9583: VR: In CsDhcp.py preseed bot...

[murali-reddy]

GitHub user murali-reddy opened a pull request:

https://github.com/apache/cloudstack/pull/1750

CLOUDSTACK-9583: VR: In CsDhcp.py preseed both hostaname and localhost to 
resolve to 127.0.0.1


ensuring for both vpc and non vpc vr, both localhost and hostname is 
resolved to 127.0.0.1

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/murali-reddy/cloudstack vr_dhcp_entries

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/1750.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1750


commit 0ac2539dfc50d5502d733aabbaf5fa6148aee4ca
Author: Murali Reddy <muralimmre...@gmail.com>
Date:   2016-11-08T11:20:41Z

CLOUDSTACK-9583: VR: In CsDhcp.py preseed both hostaname and localhost to 
resolve to 127.0.0.1

ensuring for both vpc and non vpc vr, both localhost and hostname is 
resolved to 127.0.0.1




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1713: CLOUDSTACK-9552: Allow egress TCP/53 implicitly in B...

[murali-reddy]

Github user murali-reddy commented on the issue:

https://github.com/apache/cloudstack/pull/1713
  
LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1676: CLOUDSTACK-9502: DS template copies don’t get dele...

[murali-reddy]

Github user murali-reddy commented on the issue:

https://github.com/apache/cloudstack/pull/1676
  
@jburwell VR failures seen are intermittent failures we are seeing w.r.t 
VPC static routes, RVPC VR in other PR's as well. Not related to the patch.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1741: Updated StrongSwan VPN Implementation

[murali-reddy]

Github user murali-reddy commented on the issue:

https://github.com/apache/cloudstack/pull/1741
  
@jburwell No, I have fixed issue with static nat on any public IP 
associated in case of multiple public interfaces.

@swill Is there any possibility of public IP going out of order for non-VPC 
case as well on reboot?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1729: CLOUDSTACK-9564: Fix memory leaks in VmwareContextPo...

[murali-reddy]

Github user murali-reddy commented on the issue:

https://github.com/apache/cloudstack/pull/1729
  
LGTM from code change.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1681: CLOUDSTACK-9491: incorrect parsing of device list to...

[murali-reddy]

Github user murali-reddy commented on the issue:

https://github.com/apache/cloudstack/pull/1681
  
@blueorangutan test centos7 vmware55u3


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1680: CLOUDSTACK-9498: VR CsFile search utility methods fa...

[murali-reddy]

Github user murali-reddy commented on the issue:

https://github.com/apache/cloudstack/pull/1680
  
@blueorangutan test


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1680: CLOUDSTACK-9498: VR CsFile search utility methods fa...

[murali-reddy]

Github user murali-reddy commented on the issue:

https://github.com/apache/cloudstack/pull/1680
  
@blueorangutan test


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1681: CLOUDSTACK-9491: incorrect parsing of device list to...

[murali-reddy]

Github user murali-reddy commented on the issue:

https://github.com/apache/cloudstack/pull/1681
  
@blueorangutan test centos7 vmware55u3


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1681: CLOUDSTACK-9491: incorrect parsing of device list to...

[murali-reddy]

Github user murali-reddy commented on the issue:

https://github.com/apache/cloudstack/pull/1681
  
@blueorangutan package


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1680: CLOUDSTACK-9498: VR CsFile search utility methods fa...

[murali-reddy]

Github user murali-reddy commented on the issue:

https://github.com/apache/cloudstack/pull/1680
  
@blueorangutan package


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1659: CLOUDSTACK-9339 Virtual Routers don't handle Multipl...

[murali-reddy]

Github user murali-reddy commented on the issue:

https://github.com/apache/cloudstack/pull/1659
  
@blueorangutan test


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1659: CLOUDSTACK-9339 Virtual Routers don't handle Multipl...

[murali-reddy]

Github user murali-reddy commented on the issue:

https://github.com/apache/cloudstack/pull/1659
  
@blueorangutan package


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1731: CLOUDSTACK-9565: Fix intermittent failure in test_oo...

[murali-reddy]

Github user murali-reddy commented on the issue:

https://github.com/apache/cloudstack/pull/1731
  
LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request #1724: CLOUDSTACK-9511: fix test_privategw_acl.py to...

[murali-reddy]

GitHub user murali-reddy reopened a pull request:

https://github.com/apache/cloudstack/pull/1724

CLOUDSTACK-9511: fix test_privategw_acl.py to handle multiple physical 
network


fix to ensure only physical network with guest traffic is picked up for
creating a private network for vpc private gateway

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/murali-reddy/cloudstack test_privategw_acl

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/1724.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1724


commit 5728ad03caf0580970f2c8226cae4440e12f4d92
Author: Murali Reddy <muralimmre...@gmail.com>
Date:   2016-10-24T09:45:35Z

CLOUDSTACK-9511: fix test_privategw_acl.py to handle multiple physical 
network

fix to ensure only physical network with guest traffic is picked up for
creating a private network for vpc private gateway




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request #1724: CLOUDSTACK-9511: fix test_privategw_acl.py to...

[murali-reddy]

Github user murali-reddy closed the pull request at:

https://github.com/apache/cloudstack/pull/1724


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1724: CLOUDSTACK-9511: fix test_privategw_acl.py to handle...

[murali-reddy]

Github user murali-reddy commented on the issue:

https://github.com/apache/cloudstack/pull/1724
  
all tests in test_privategw_acl.py passed on KVM & XEN except for 
test_02_vpc_privategw_static_routes test fail in XenServer, which was due to  
private gateway not getting created "createprivategateway failed, due to: 
errorCode: 431, errorText:Network with vlan vlan://842 already exists in zone 
1". A network which may not have cleaned up.

Successfully ran 'test_02_vpc_privategw_static_routes' test manually, there 
no issue with the test.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request #1724: CLOUDSTACK-9511: fix test_privategw_acl.py to...

[murali-reddy]

GitHub user murali-reddy opened a pull request:

https://github.com/apache/cloudstack/pull/1724

CLOUDSTACK-9511: fix test_privategw_acl.py to handle multiple physical 
network


fix to ensure only physical network with guest traffic is picked up for
creating a private network for vpc private gateway

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/murali-reddy/cloudstack test_privategw_acl

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/1724.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1724


commit 5728ad03caf0580970f2c8226cae4440e12f4d92
Author: Murali Reddy <muralimmre...@gmail.com>
Date:   2016-10-24T09:45:35Z

CLOUDSTACK-9511: fix test_privategw_acl.py to handle multiple physical 
network

fix to ensure only physical network with guest traffic is picked up for
creating a private network for vpc private gateway




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1659: CLOUDSTACK-9339 Virtual Routers don't handle Multipl...

[murali-reddy]

Github user murali-reddy commented on the issue:

https://github.com/apache/cloudstack/pull/1659
  
@blueorangutan package


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1692: Fix Smoke Test Failures

[murali-reddy]

Github user murali-reddy commented on the issue:

https://github.com/apache/cloudstack/pull/1692
  
@syed Thanks for testing out. Tests related VPC private gateway, redundant 
VPC are still failing as noted [1]. I am working on fix. We want to proceed 
with this PR with those failing tests are known issues. If the rest of the 
tests are passing can we have LGTM?


[1]http://markmail.org/message/n2p2jziywo7kjzx7#query:+page:1+mid:rvv4kqkim2nme35h+state:results


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1695: CLOUDSTACK-9511: fix test_privategw_acl.py to handle...

[murali-reddy]

Github user murali-reddy commented on the issue:

https://github.com/apache/cloudstack/pull/1695
  
I am closing this pull request, and pushed the changes as part of PR #1692, 
which will cover overall marvin test failures


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request #1695: CLOUDSTACK-9511: fix test_privategw_acl.py to...

[murali-reddy]

Github user murali-reddy closed the pull request at:

https://github.com/apache/cloudstack/pull/1695


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request #1695: CLOUDSTACK-9511: fix test_privategw_acl.py to...

[murali-reddy]

GitHub user murali-reddy opened a pull request:

https://github.com/apache/cloudstack/pull/1695

CLOUDSTACK-9511: fix test_privategw_acl.py to handle multiple physical 
networks


modified script to handle case where there can be multple physical networks
in the zone

changes contained ONLY to the test script test_privategw_acl.py. 

test_01_vpc_privategw_acl (test_privategw_acl.TestPrivateGwACL) ... === 
TestName: test_01_vpc_privategw_acl | Status : SUCCESS ===
ok
test_02_vpc_privategw_static_routes (test_privategw_acl.TestPrivateGwACL) 
... === TestName: test_02_vpc_privategw_static_routes | Status : SUCCESS ===
ok
test_03_vpc_privategw_restart_vpc_cleanup 
(test_privategw_acl.TestPrivateGwACL) ... === TestName: 
test_03_vpc_privategw_restart_vpc_cleanup | Status : SUCCESS ===
ok
test_04_rvpc_privategw_static_routes (test_privategw_acl.TestPrivateGwACL) 
... === TestName: test_04_rvpc_privategw_static_routes | Status : SUCCESS ===
ok

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/murali-reddy/cloudstack marving_pvt_gateway

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/1695.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1695


commit aed518ad7bdc06ae76ca6553cf1148a8f199bb9e
Author: Murali Reddy <muralimmre...@gmail.com>
Date:   2016-09-29T08:05:55Z

CLOUDSTACK-9511: fix test_privategw_acl.py to handle multiple physical 
networks

modified script to handle case where there can be multple physical networks
in the zone




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1681: CLOUDSTACK-9491: incorrect parsing of device list to...

[murali-reddy]

Github user murali-reddy commented on the issue:

https://github.com/apache/cloudstack/pull/1681
  
@blueorangutan test centos7 vmware55u3


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1681: CLOUDSTACK-9491: incorrect parsing of device list to...

[murali-reddy]

Github user murali-reddy commented on the issue:

https://github.com/apache/cloudstack/pull/1681
  
@jburwell function 'findRouterEthDeviceIndex' which is modified, is invoked 
when ever a new tier to VPC is added (virtual NIC is hot-plugged). Many VPC 
tests run againest the VMware environment will cover this scenario.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1680: CLOUDSTACK-9498: VR CsFile search utility methods fa...

[murali-reddy]

Github user murali-reddy commented on the issue:

https://github.com/apache/cloudstack/pull/1680
  
@jburwell changed the existing marvin test to use password as 
"p@a#s=s.w_o-r+d", which will cover the all chars permitted for VPN user 
password


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1681: CLOUDSTACK-9491: incorrect parsing of device list to...

[murali-reddy]

Github user murali-reddy commented on the issue:

https://github.com/apache/cloudstack/pull/1681
  
@sateesh-chodapuneedi  added optimization for now, but its better we 
eliminate the whole logic of finding device index from the VR.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1659: CLOUDSTACK-9339 Virtual Routers don't handle Multipl...

[murali-reddy]

Github user murali-reddy commented on the issue:

https://github.com/apache/cloudstack/pull/1659
  
@ustcweizhou thanks, i have fixed it earlier today and tested, am trying to 
fix other test failures and re-run the CI


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: ACS 4.9 + VMware: Failed to deploy VPC VR due to IPAssoc failure

[Murali Reddy]

findRouterEthDeviceIndex() in VmwareResource returned -1.


Looks like CLOUDSTACK-9491: incorrect parsing of device list to find ethernet 
index of plugged NIC

There is a PR https://github.com/apache/cloudstack/pull/1681



On 26/09/16, 5:13 PM, "Prashanth Manthena" 
 wrote:

>Hi All,
>
>We are hitting an issue where VPC VR is failing to come up due to IpAssoc
>failure in ACS+VMware setup.
>
>We have tried with the following system VM templates:
>
>http://cloudstack.apt-get.eu/systemvm/4.6/systemvm64template-4.6.0-vmware.ova
>
>http://cloudstack.apt-get.eu/templates/4.7/systemvm64template-2016-05-18-4.7.0-vmware.ova
>
>
>Is there a more latest system VM template that fixes this issue ?
>
>
>Here is the error log:
>
>[1:00]
>IpAssocVpcCommand) (logid:f727c105) Prepare Ip Assoc failure on applying
>one ip due to exception:
>com.cloud.exception.InternalErrorException: Failed to find DomR VIF to
>associate/disassociate IP with.
>   at
>com.cloud.hypervisor.vmware.resource.VmwareResource.prepareNetworkElementCommand(VmwareResource.java:917)
>   at
>com.cloud.hypervisor.vmware.resource.VmwareResource.prepareCommand(VmwareResource.java:803)
>   at
>com.cloud.agent.resource.virtualnetwork.VirtualRoutingResource.executeRequest(VirtualRoutingResource.java:97)
>   at
>com.cloud.hypervisor.vmware.resource.VmwareResource.executeRequest(VmwareResource.java:387)
>   at
>com.cloud.agent.manager.DirectAgentAttache$Task.runInContext(DirectAgentAttache.java:315)
>   at
>org.apache.cloudstack.managed.context.ManagedContextRunnable$1.run(ManagedContextRunnable.java:49)
>   at
>org.apache.cloudstack.managed.context.impl.DefaultManagedContext$1.call(DefaultManagedContext.java:56)
>   at
>org.apache.cloudstack.managed.context.impl.DefaultManagedContext.callWithContext(DefaultManagedContext.java:103)
>   at
>org.apache.cloudstack.managed.context.impl.DefaultManagedContext.runWithContext(DefaultManagedContext.java:53)
>   at
>org.apache.cloudstack.managed.context.ManagedContextRunnable.run(ManagedContextRunnable.java:46)
>   at
>java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:471)
>   at java.util.concurrent.FutureTask.run(FutureTask.java:262)
>   at
>java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.access$201(ScheduledThreadPoolExecutor.java:178)
>   at
>java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:292)
>   at
>java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145)
>   at
>java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615)
>   at java.lang.Thread.run(Thread.java:745)
>2016-09-26 02:30:22,053 ERROR [c.c.a.r.v.VirtualRoutingResource]
>(DirectAgent-80:ctx-d0fb047f 10.31.56.182, job-65/job-66, cmd:
>IpAssocVpcCommand) (logid:f727c105) Failed to prepare VR command due to
>com.cloud.exception.InternalErrorException: Failed to find DomR VIF to
>associate/disassociate IP with.
>
>With regards,
>Prashanth

[GitHub] cloudstack issue #1659: CLOUDSTACK-9339 Virtual Routers don't handle Multipl...

[murali-reddy]

Github user murali-reddy commented on the issue:

https://github.com/apache/cloudstack/pull/1659
  
@jburwell i am investigating them. Just so you know, blueorangutan is 
running full smoke test suite. Similar failures are seen in other PR as well. 
So some of the tests may have been failing for some time and need to be fixed.

From the above list of failures test_router_dhcphosts are due to test 
errors that is being addressed by https://github.com/apache/cloudstack/pull/1683

I have addressed below two test failures. support for internal LB was not 
added in the logic creating ips.json databag, I made a fix for that as well.

test_02_internallb_roundrobin_1RVPC_3VM_HTTP_port80
test_01_internallb_roundrobin_1VPC_3VM_HTTP_port80

rest of the failures i am investigating if they are regressions, and test 
failures.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1683: fix ping tests to properly recognise successful ping...

[murali-reddy]

Github user murali-reddy commented on the issue:

https://github.com/apache/cloudstack/pull/1683
  
Just ran in to this issue. Fix LGTM.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1680: CLOUDSTACK-9498: VR CsFile search utility methods fa...

[murali-reddy]

Github user murali-reddy commented on the issue:

https://github.com/apache/cloudstack/pull/1680
  
@cloudmonger error seems to be due to 'physicalnetwork 200 has allocated 
vnets in the range 731-732' This is same error seen in test run. After test run 
in done, please see if there is network that was not cleaned and reason for 
that.

This patch is contained to VPN user add/delete functionality, unrelated to 
the error.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1674: CLOUDSTACK-9460: For long running transactions, if t...

[murali-reddy]

Github user murali-reddy commented on the issue:

https://github.com/apache/cloudstack/pull/1674
  
LGTM from the code change.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1681: CLOUDSTACK-9491: incorrect parsing of device list to...

[murali-reddy]

Github user murali-reddy commented on the issue:

https://github.com/apache/cloudstack/pull/1681
  
@serg38 Though same code path, i ran into different issue. When i was 
adding new tier to VPC, eth3 was plugged into VR from vCenter. As commented in 
the function there is delay for ethernet device to appear in the guest instance.

I could see code loops through eth0, eth1, eth2 only, because it read the 
'/proc/sys/net/ipv4/conf' too early.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: [DISCUSS] Replacing the VR

[Murali Reddy]

Matthew,

Please see 
https://cwiki.apache.org/confluence/display/CLOUDSTACK/Extending+CloudStack+Networking

Thanks,
Murali





On 22/09/16, 11:23 PM, "Matthew Smart" <msm...@smartsoftwareinc.com> wrote:

>Hey Murali,
>
>I have been reading through the API and other documentation to try to 
>get a basic understanding of the network service offering abstraction 
>methodology in CS. I have not dove into the code yet but before I did I 
>thought I would try a different approach.
>
>Imagine I were to come to this list and say that I have a network 
>offering that I sell and that I wanted to write whatever I needed to in 
>order to integrate it as an offering in CloudStack. Is there some 
>specific documentation and guidelines you would direct me to read in 
>order to gather the knowledge necessary to create a cloudstack 
>compatible interface for my product?
>
>I don't know the history but I see several products that have navigated 
>this process (Nuage, Nicira, ...etc) and am wondering how a new provider 
>would work with you guys to navigate that process. If this is too vague, 
>we can pretend my new offering is a hardware firewall device.
>
>My goal here is to gain an understanding of how CS interacts with third 
>party offerings underneath the hood. I have some thoughts (I think 
>inline with Will Steven's brain dump and diagram) but want to make sure 
>I am not suffering some misapprehensions about the architecture and, 
>short of tracing code, was not successful at finding the information I 
>needed to satisfy myself that I know how it is designed.
>
>Thanks,
>
>Matthew Smart
>President
>Smart Software Solutions Inc.
>108 S Pierre St.
>Pierre, SD 57501
>
>Phone: (605) 280-0383
>Skype: msmart13
>Email: msm...@smartsoftwareinc.com
>
>On 09/20/2016 04:54 AM, Murali Reddy wrote:
>> Configuration management of network appliances particularly for Cloud and 
>> NFV scenarios is still evolving area. Programmability is the not the 
>> strength for even the most popular network operating systems like IOS, JunoS 
>> etc. So its not surprising why CloudStack integrates in a archaic way with 
>> stock linux for the VR.
>>
>> VR was never integral/hardcoded option in CloudStack. Its always been a 
>> plugin. CloudStack network orchestration is well abstracted and designed 
>> with vision to compose a network with different set of providers for 
>> different services. Yes that vision is not fully realised yet, and we don’t 
>> have true service function chains. That would be different discussion topic.
>>
>> I tend to agree with Simon, as alternate/interim option we can take hard 
>> look whats causing the problems with current VR integration. Personally, I 
>> think it would be easier we take a cue from configuration managers and 
>> network configuration solutions out there (for e.g promise theory based 
>> Cisco ACI) move to more declarative model of expressing desired state of 
>> network configuration. Infact current VR from 4.6, actually holds the 
>> desired state per service basis, seems to be in that direction.
>>
>> It does make sense to evaluate new appliances which can provide rich 
>> semantics (like programmable API, declarative configuration, versioning, 
>> commit/rollback etc), but will need significant engineering effort and time 
>> to stabilise. We may make same mistakes with integration of other appliance 
>> as well, if we fully don’t understand the nature of the current problems 
>> with CloudStack core and service provider interaction and current VR 
>> integration.
>>
>>
>> On 16/09/16, 11:59 PM, "Simon Weller" <swel...@ena.com> wrote:
>>
>>> I think our other option is to take a real look at what it would take to 
>>> fix the VR. In my opinion, a lot of the problems are related to the 
>>> monolithic python code base and the fact nothing is actually separated.
>>>
>>> Secondly, the python scripts (and bash scripts) don't use any established 
>>> libraries to complete tasks and instead shell out and run commands that are 
>>> both hard to track and hard to parse on return.
>>>
>>>
>>> If we daemonized this, used a real api for Agent to VR communication, used 
>>> common already existing libraries for the system service and network 
>>> interactions and spent a bit of time separating out code into distinct 
>>> modules, everything would behave a lot better.
>>>
>>>
>>> The pain and suffering is due to years and years of patches and constant 
>>> shelling out to complete tasks in my opinion. If we spend time to re

[GitHub] cloudstack issue #1659: CLOUDSTACK-9339 Virtual Routers don't handle Multipl...

[murali-reddy]

Github user murali-reddy commented on the issue:

https://github.com/apache/cloudstack/pull/1659
  
@blueorangutan test


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1659: CLOUDSTACK-9339 Virtual Routers don't handle Multipl...

[murali-reddy]

Github user murali-reddy commented on the issue:

https://github.com/apache/cloudstack/pull/1659
  
@blueorangutan package


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1666: CLOUDSTACK-9480, CLOUDSTACK-9495 fix egress rule inc...

[murali-reddy]

Github user murali-reddy commented on the issue:

https://github.com/apache/cloudstack/pull/1666
  
@cloudmonger thanks

test_extendPhysicalNetworkVlan failed due to 'physicalnetwork 200 has 
allocated vnets in the range 734-735'. Possibly due to stale network that was 
not cleaned by one of the tests.

Ran test manually, it passed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request #1681: CLOUDSTACK-9491: incorrect parsing of device ...

[murali-reddy]

GitHub user murali-reddy opened a pull request:

https://github.com/apache/cloudstack/pull/1681

CLOUDSTACK-9491: incorrect parsing of device list to find ethernet index of 
plugged NIC


In VmwareResource, findRouterEthDeviceIndex() method find ethernet 
interface index given
the mac address. This method is used, once a nic is plugged to determine 
ethernet interface.
"/proc/sys/net/ipv4/conf" from the VR and looped through the devices to 
find the right
ethernet interface. Howver current logic read it once, and loops through 
the device list.
Its observerd device may not show up '/proc/sys/net/ipv4/conf' immediatly 
once NIC is plugged
in the VM from vCenter.

Fix ensured, while waiting for 15 sec in the loop, read the latest content 
from /proc/sys/net/ipv4/conf
, so that right device list is processed.

Manual tested VPC scenarios of adding new tiers which uses 
findRouterEthDeviceIndex, to find the guest/public network ethernet index.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/murali-reddy/cloudstack 
router_eth_device_index

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/1681.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1681


commit be7ade3153d3b29c18d904d5327c1af139e1c037
Author: Murali Reddy <muralimmre...@gmail.com>
Date:   2016-09-21T06:08:47Z

CLOUDSTACK-9491: incorrect parsing of device list to find ethener index of 
plugged nic

In VmwareResource, findRouterEthDeviceIndex() method find ethernet 
interface index given
the mac address. This method is used, once a nic is plugged to determine 
ethernet interface.
"/proc/sys/net/ipv4/conf" from the VR and looped through the devices to 
find the right
ethernet interface. Howver current logic read it once, and loops through 
the device list.
Its observerd device may not show up '/proc/sys/net/ipv4/conf' immediatly 
once NIC is plugged
in the VM from vCenter.

Fix ensured, while waiting for 15 sec in the loop, read the latest content 
from /proc/sys/net/ipv4/conf
, so that right device list is processed.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---