[GitHub] cloudstack issue #914: BUG-ID CLOUDSTACK-8939 VM Snapshot size with memory i...
Github user niteshsarda commented on the issue: https://github.com/apache/cloudstack/pull/914 I have tested this and **LGTM** for test. Following are the test results : **Before applying fix :** [root@xenserver-jay ~]# xe vbd-list vm-name-label=i-2-120-VM empty=false params=vdi-uuid vdi-uuid ( RO): 674c2c07-954e-4fa0-943a-979a71748727 [root@xenserver-jay ~]# xe vdi-list params=physical-utilisation,sm-config,is-a-snapshot uuid=674c2c07-954e-4fa0-943a-979a71748727 is-a-snapshot ( RO) : false physical-utilisation ( RO): 81256448 sm-config (MRO): host_OpaqueRef:a3c1c534-b5e3-6cb5-10af-b56dead63fc0: RW; vhd-parent: 1aac168d-22d2-4796-8669-48a3f4361dfc [root@xenserver-jay ~]# xe vdi-list params=physical-utilisation,sm-config,is-a-snapshot uuid=1aac168d-22d2-4796-8669-48a3f4361dfc is-a-snapshot ( RO) : false physical-utilisation ( RO): 233251328 sm-config (MRO): vhd-blocks: eJxjYEAB7AykARFGPc1cN4UVJGqDAUYG5tZJF0ymbpi4bYUCAxPJ+nn2sDQLMGwTYzzI0OvAQob1AgIBip6BrAIrG0jWDAEAQmQNjA==; vhd-parent: 55943089-24fa-4fbe-a44e-e57fe9a080ed [root@xenserver-jay ~]# xe vdi-list name-label=Suspend\ image params=all uuid ( RO): 105fbe1d-973b-4d8d-82e7-96246669a769 name-label ( RW): Suspend image name-description ( RW): Suspend image is-a-snapshot ( RO): true snapshot-of ( RO): snapshots ( RO): snapshot-time ( RO): 20170401T07:49:50Z allowed-operations (SRO): forget; generate_config; update; resize; destroy; clone; copy; snapshot current-operations (SRO): sr-uuid ( RO): 99b84794-d0d6-46c6-fa42-07af5b423b8c sr-name-label ( RO): d2fecabd-61cf-3458-a120-ea01a4f91c29 vbd-uuids (SRO): crashdump-uuids (SRO): virtual-size ( RO): 782237696 physical-utilisation ( RO): 6144 location ( RO): 105fbe1d-973b-4d8d-82e7-96246669a769 type ( RO): Suspend sharable ( RO): false read-only ( RO): false storage-lock ( RO): false managed ( RO): true parent ( RO): missing ( RO): false other-config (MRW): content_id: 842a46b4-bffd-70fb-b00a-47c39de8959b xenstore-data (MRO): sm-config (MRO): vhd-parent: 638118a6-5f85-4c35-9aa8-d19793a144a8 on-boot ( RW): persist allow-caching ( RW): false metadata-latest ( RO): false metadata-of-pool ( RO): tags (SRW): [root@xenserver-jay ~]# xe vdi-list uuid=638118a6-5f85-4c35-9aa8-d19793a144a8 params=all uuid ( RO): 638118a6-5f85-4c35-9aa8-d19793a144a8 name-label ( RW): base copy name-description ( RW): is-a-snapshot ( RO): false snapshot-of ( RO): snapshots ( RO): snapshot-time ( RO): 19700101T00:00:00Z allowed-operations (SRO): forget; generate_config; update; resize; destroy; clone; copy; snapshot current-operations (SRO): sr-uuid ( RO): 99b84794-d0d6-46c6-fa42-07af5b423b8c sr-name-label ( RO): d2fecabd-61cf-3458-a120-ea01a4f91c29 vbd-uuids (SRO): crashdump-uuids (SRO): virtual-size ( RO): 782237696 physical-utilisation ( RO): 548430336 location ( RO): 638118a6-5f85-4c35-9aa8-d19793a144a8 type ( RO): User sharable ( RO): false read-only ( RO): true storage-lock ( RO): false managed ( RO): false parent ( RO): missing ( RO): false other-config (MRW): xenstore-data (MRO): sm-config (MRO): vhd-blocks: eJz7/x8/+MGAAgD69CDZ on-boot ( RW): persist allow-caching ( RW): false metadata-latest ( RO): false metadata-of-pool ( RO): tags (SRW): mysql> select * from cloud.usage_event where resource_name like "i-2-120-VM%" \G *** 1. row *** id: 84 type: VMSNAPSHOT.CREATE account_id: 2 created: 2017-04-01 07:50:42 zone_id: 2 resource_id: 120 resource_name: i-2-120-VM_VS_20170401074841 offering_id: NULL template_id: 120 size: 233272320
[GitHub] cloudstack issue #1810: CLOUDSTACK-9647: NIC adapter type becomes e1000 , ev...
Github user niteshsarda commented on the issue: https://github.com/apache/cloudstack/pull/1810 I have tested this and **LGTM** for test. Following are the results : **Before applying fix :** /vmfs/volumes/5d7b9eae-08336124/r-99-VM # grep virtualDev r-97-VM.vmx pciBridge4.virtualDev = "pcieRootPort" pciBridge5.virtualDev = "pcieRootPort" pciBridge6.virtualDev = "pcieRootPort" pciBridge7.virtualDev = "pcieRootPort" scsi0.virtualDev = "lsilogic" ethernet0.virtualDev = "vmxnet3" ethernet1.virtualDev = "e1000" ethernet2.virtualDev = "e1000" **After applying fix :** /vmfs/volumes/5d7b9eae-08336124/r-99-VM # grep virtualDev r-99-VM.vmx pciBridge4.virtualDev = "pcieRootPort" pciBridge5.virtualDev = "pcieRootPort" pciBridge6.virtualDev = "pcieRootPort" pciBridge7.virtualDev = "pcieRootPort" scsi0.virtualDev = "lsilogic" ethernet0.virtualDev = "vmxnet3" ethernet1.virtualDev = "vmxnet3" ethernet2.virtualDev = "vmxnet3" --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #905: BUG-ID: CLOUDSTACK-8922: Unable to delete IP tag
Github user niteshsarda commented on the issue: https://github.com/apache/cloudstack/pull/905 I have tested this and **LGTM** for test. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1850: CLOUDSTACK-9694: Unable to limit the Public IPs in V...
Github user niteshsarda commented on the issue: https://github.com/apache/cloudstack/pull/1850 I have tested this and LGTM for test. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1725: CLOUDSTACK-9559 Why allow deleting zone without dele...
Github user niteshsarda commented on the issue: https://github.com/apache/cloudstack/pull/1725 I have tested this and **LGTM** for test --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1726: CLOUDSTACK-9560 Root volume of deleted VM left unrem...
Github user niteshsarda commented on the issue: https://github.com/apache/cloudstack/pull/1726 I have tested this and **LGTM** for test --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1987: CLOUDSTACK-9814 : Unable to edit a Sub domain, which...
Github user niteshsarda commented on the issue: https://github.com/apache/cloudstack/pull/1987 This is Ready to Merge --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1978: CLOUDSTACK-9779 : Releasing secondary guest IP fails...
Github user niteshsarda commented on the issue: https://github.com/apache/cloudstack/pull/1978 This is Ready to Merge --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1987: CLOUDSTACK-9814 : Unable to edit a Sub domain, which...
Github user niteshsarda commented on the issue: https://github.com/apache/cloudstack/pull/1987 @rafaelweingartner : As per your suggestion, I have changed the search query and also removed the unused method updateDomain from managementserviceimpl class. Please check. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request #1987: CLOUDSTACK-9814 : Unable to edit a Sub domain...
Github user niteshsarda commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1987#discussion_r104283067
--- Diff: server/src/org/apache/cloudstack/region/RegionManagerImpl.java ---
@@ -229,7 +232,7 @@ public boolean deleteUser(DeleteUserCmd cmd) {
*/
@Override
public Domain updateDomain(UpdateDomainCmd cmd) {
-return _domainMgr.updateDomain(cmd);
+return _managementService.updateDomain(cmd);
--- End diff --
@yvsubhash : As per your suggestion, I have changed the search query and
also removed the unused method updateDomain from managementserviceimpl class.
Please check.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request #1987: CLOUDSTACK-9814 : Unable to edit a Sub domain...
GitHub user niteshsarda opened a pull request: https://github.com/apache/cloudstack/pull/1987 CLOUDSTACK-9814 : Unable to edit a Sub domain, which has the same name in different domains ISSUE Unable to edit a Sub domain, which has the same name in different domains. TROUBLESHOOTING == 1. Created two sub-domains with same name. Under two different domains. ROOT Domain 1 : Sample AA01 BB01 Domain 2 : Test AA01 2. Try to edit resource - Click on edit - edit any parameter. EXPECTED BEHAVIOR == It should allow to edit the required parameter and update the value. ACTUAL BEHAVIOR == It throws an error "Failed to update specified domain id with name 'AA01' since it already exists in system. You can merge this pull request into a Git repository by running: $ git pull https://github.com/Accelerite/cloudstack SubDomainIssue Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cloudstack/pull/1987.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1987 commit 2d29b4fc48081efe683457c7f4597c643f3fa480 Author: Nitesh Sarda <nitesh_sa...@accelerite.com> Date: 2017-03-03T11:24:48Z CLOUDSTACK-9814 : Unable to edit a Sub domain, which has the same name in different domains --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request #1986: CLOUDSTACK-9814 : Unable to edit a Sub domain...
Github user niteshsarda closed the pull request at: https://github.com/apache/cloudstack/pull/1986 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request #1986: CLOUDSTACK-9814 : Unable to edit a Sub domain...
GitHub user niteshsarda opened a pull request: https://github.com/apache/cloudstack/pull/1986 CLOUDSTACK-9814 : Unable to edit a Sub domain, which has the same name in different domains ISSUE Unable to edit a Sub domain, which has the same name in different domains. TROUBLESHOOTING == 1. Created two sub-domains with same name. Under two different domains. ROOT Domain 1 : India@b582a4cb-031e-49e7-afcf-4281fbf231b4 AA01 BB01 Domain 2 : Test AA01 2. Try to edit resource - Click on edit - edit any parameter. EXPECTED BEHAVIOR == It should allow to edit the required parameter and update the value. ACTUAL BEHAVIOR == It throws an error "Failed to update specified domain id with name 'AA01' since it already exists in system. You can merge this pull request into a Git repository by running: $ git pull https://github.com/Accelerite/cloudstack CS-50514 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cloudstack/pull/1986.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1986 commit 2f75b51f42c9400a7be172e405a4ff13bf4c2722 Author: Nitesh Sarda <nitesh_sa...@accelerite.com> Date: 2017-02-27T17:54:20Z CLOUDSTACK-9779 : Releasing secondary guest IP fails with error VM nic Ip x.x.x.x is mapped to load balancing rule commit ff97817b907c25aff8ccf9bfd36a1d12966b6d9e Author: Nitesh Sarda <nitesh_sa...@accelerite.com> Date: 2017-03-03T10:47:58Z CLOUDSTACK-9814 : Unable to edit a Sub domain, which has the same name in different domains --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1978: CLOUDSTACK-9779 : Releasing secondary guest IP fails...
Github user niteshsarda commented on the issue: https://github.com/apache/cloudstack/pull/1978 @borisstoyanov : The test cases which are failing are not related to my code changes. Can you please verify ? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request #1978: CLOUDSTACK-9779 : Releasing secondary guest I...
Github user niteshsarda commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1978#discussion_r103415320 --- Diff: server/test/resources/createNetworkOffering.xml --- @@ -34,22 +34,23 @@ - - - - - - - - - + + + + + + + + + - - - - + + + + + --- End diff -- This is the only line, I have added in this file. Other changes were not visible in the patch which was created before committing the changes in local. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1972: CLOUDSTACK-9779 : Releasing secondary guest IP fails...
Github user niteshsarda commented on the issue: https://github.com/apache/cloudstack/pull/1972 @SudharmaJain Can you please check new PR for this issue. Also, I have implemented the changes which you have suggested. PR link : #1978 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1972: CLOUDSTACK-9779 : Releasing secondary guest IP fails...
Github user niteshsarda commented on the issue: https://github.com/apache/cloudstack/pull/1972 @ustcweizhou : Can you please check new PR for this issue and provide LGTM on that PR. PR link : https://github.com/apache/cloudstack/pull/1978 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request #1978: CLOUDSTACK-9779 : Releasing secondary guest I...
GitHub user niteshsarda opened a pull request: https://github.com/apache/cloudstack/pull/1978 CLOUDSTACK-9779 : Releasing secondary guest IP fails with error VM nic Ip x.x.x.x is mapped to load balancing rule ISSUE Releasing secondary guest IP fails with error VM nic Ip x.x.x.x is mapped to load balancing rule REPRO STEPS Create two isolated guest networks with same CIDR Deploy VMs on both networks Acquire secondary IP on NICs of both VMs and make sure they have the same value, user can input the IP address. Configure Loadbalancing rule on one of the secondary IP address and try releasing the other secondary IP address. The operation would fail EXPECTED BEHAVIOR Secondary IP address should be released if there are no LB rules associated with it. ACTUAL BEHAVIOR Not releasing secondary IP address even if there are no LB rules associated with it. You can merge this pull request into a Git repository by running: $ git pull https://github.com/Accelerite/cloudstack ReleaseNicSecondaryIP Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cloudstack/pull/1978.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1978 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request #1972: CLOUDSTACK-9779 : Releasing secondary guest I...
Github user niteshsarda commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1972#discussion_r103190716 --- Diff: engine/schema/src/com/cloud/network/dao/LoadBalancerDao.java --- @@ -29,4 +30,6 @@ List listInTransitionStateByNetworkIdAndScheme(long networkId, Scheme scheme); +boolean isLoadBalancerRulesMappedToVmGuestIp(long instanceId, String instanceIp, long networkId, FirewallRule.Purpose purpose); --- End diff -- @SudharmaJain : As per suggestion, removed Purpose parameter from method signature and added directly in the SearchBuilder. Please check. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request #1972: CLOUDSTACK-9779 : Releasing secondary guest I...
Github user niteshsarda commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1972#discussion_r103138362
--- Diff: engine/schema/src/com/cloud/network/dao/LoadBalancerDaoImpl.java
---
@@ -75,4 +84,40 @@ protected LoadBalancerDaoImpl() {
return listBy(sc);
}
+@Override
+public boolean isLoadBalancerRulesMappedToVmGuestIp(long instanceId,
String instanceIp, long networkId, FirewallRule.Purpose purpose)
+{
+SearchBuilder lbVmMapSearch =
_loadBalancerVMMapDao.createSearchBuilder();
+lbVmMapSearch.and("instanceIp",
lbVmMapSearch.entity().getInstanceIp(),SearchCriteria.Op.EQ);
+lbVmMapSearch.and("instanceId",
lbVmMapSearch.entity().getInstanceId(), SearchCriteria.Op.EQ);
+
+SearchBuilder firewallRuleIdSearch =
_firewallRulesDao.createSearchBuilder();
--- End diff --
@ustcweizhou : As per suggestion, I have made changes. Please check.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1937: CLOUDSTACK-9779 : Releasing secondary guest IP fails...
Github user niteshsarda commented on the issue: https://github.com/apache/cloudstack/pull/1937 @ustcweizhou : I have created a new PR for this issue https://github.com/apache/cloudstack/pull/1972 . Please check. Also, I have incorporated all the comments which you have provided in this PR in the new PR. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request #1972: CLOUDSTACK-9779 : Releasing secondary guest I...
GitHub user niteshsarda opened a pull request: https://github.com/apache/cloudstack/pull/1972 CLOUDSTACK-9779 : Releasing secondary guest IP fails with error VM nic Ip x.x.x.x is mapped to load balancing rule ISSUE Releasing secondary guest IP fails with error VM nic Ip x.x.x.x is mapped to load balancing rule REPRO STEPS Create two isolated guest networks with same CIDR Deploy VMs on both networks Acquire secondary IP on NICs of both VMs and make sure they have the same value, user can input the IP address. Configure Loadbalancing rule on one of the secondary IP address and try releasing the other secondary IP address. The operation would fail EXPECTED BEHAVIOR Secondary IP address should be released if there are no LB rules associated with it. ACTUAL BEHAVIOR Not releasing secondary IP address even if there are no LB rules associated with it. You can merge this pull request into a Git repository by running: $ git pull https://github.com/Accelerite/cloudstack ReleaseSecondaryIP Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cloudstack/pull/1972.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1972 commit 2362335662085a5f23570fb7bdc90a8409add38c Author: Nitesh Sarda <nitesh_sa...@accelerite.com> Date: 2017-02-24T13:40:29Z CLOUDSTACK-9779 : Releasing secondary guest IP fails with error VM nic Ip x.x.x.x is mapped to load balancing rule --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request #1937: CLOUDSTACK-9779 : Releasing secondary guest I...
Github user niteshsarda closed the pull request at: https://github.com/apache/cloudstack/pull/1937 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request #1937: CLOUDSTACK-9779 : Releasing secondary guest I...
Github user niteshsarda commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1937#discussion_r101966427
--- Diff: server/src/com/cloud/network/NetworkServiceImpl.java ---
@@ -852,7 +852,8 @@ public boolean releaseSecondaryIpFromNic(long
ipAddressId) {
throw new InvalidParameterValueException("Can' remove the
ip " + secondaryIp + "is associate with static NAT rule public IP address id "
+ publicIpVO.getId());
}
-if (_lbService.isLbRuleMappedToVmGuestIp(secondaryIp)) {
+List lbRuleIdList =
_firewallDao.listIdByNetworkAndPurposeAndNotRevoked(network.getId(),
Purpose.LoadBalancing);
--- End diff --
@ustcweizhou : As per your comment, do you expect Null and Empty check for
list variable "lbRuleIdList " to be moved in LoadBalancerVMMapDao.java class ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request #1937: CLOUDSTACK-9779 : Releasing secondary guest I...
Github user niteshsarda commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1937#discussion_r101502146
--- Diff: server/src/com/cloud/network/NetworkServiceImpl.java ---
@@ -852,7 +852,8 @@ public boolean releaseSecondaryIpFromNic(long
ipAddressId) {
throw new InvalidParameterValueException("Can' remove the
ip " + secondaryIp + "is associate with static NAT rule public IP address id "
+ publicIpVO.getId());
--- End diff --
Will take this up in separate ticket.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1942: CLOUDSTACK-9784 : GPU detail not displayed in GPU ta...
Github user niteshsarda commented on the issue: https://github.com/apache/cloudstack/pull/1942 @SudharmaJain : As per suggestion, I have added a screenshot of the UI before and after adding fix in description comment. Please check --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1909: CLOUDSTACK-9740 : Search for secondary IP of NIC tha...
Github user niteshsarda commented on the issue: https://github.com/apache/cloudstack/pull/1909   --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request #1942: CLOUDSTACK-9784 : GPU detail not displayed in...
GitHub user niteshsarda opened a pull request: https://github.com/apache/cloudstack/pull/1942 CLOUDSTACK-9784 : GPU detail not displayed in GPU tab of management server UI. ISSUE == When GPU tab of the host is selected on the management server UI, no GPU detail is displayed. RESOLUTION == There is a javascript file namely "system.js" in which while fetching the GPU details, sort functionality in dataprovider is returning value as undefined and hence it throwing an exception. So handled the output as undefined gracefully to avoid exception. You can merge this pull request into a Git repository by running: $ git pull https://github.com/Accelerite/cloudstack CS-50422 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cloudstack/pull/1942.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1942 commit 36abc63b91cce72d1bee96eea630252c348f2450 Author: Nitesh Sarda <nitesh_sa...@accelerite.com> Date: 2017-02-14T15:59:21Z CLOUDSTACK-9784 : GPU detail not displayed in GPU tab of management server UI. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request #1937: CLOUDSTACK-9779 : Releasing secondary guest I...
GitHub user niteshsarda opened a pull request: https://github.com/apache/cloudstack/pull/1937 CLOUDSTACK-9779 : Releasing secondary guest IP fails with error VM nic Ip x.x.x.x is mapped to load balancing rule ISSUE = Releasing secondary guest IP fails with error VM nic Ip x.x.x.x is mapped to load balancing rule REPRO STEPS == 1. Create two isolated guest networks with same CIDR 2. Deploy VMs on both networks 3. Acquire secondary IP on NICs of both VMs and make sure they have the same value, user can input the IP address. 4. Configure Loadbalancing rule on one of the secondary IP address and try releasing the other secondary IP address. 5. The operation would fail EXPECTED BEHAVIOR == Secondary IP address should be released if there are no LB rules associated with it. ACTUAL BEHAVIOR == Releasing secondary IP address even if there are no LB rules associated with it. You can merge this pull request into a Git repository by running: $ git pull https://github.com/Accelerite/cloudstack CS-50136 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cloudstack/pull/1937.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1937 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request #1924: CLOUDSTACK-9766 : Executing deleteSnapshot ap...
GitHub user niteshsarda opened a pull request: https://github.com/apache/cloudstack/pull/1924 CLOUDSTACK-9766 : Executing deleteSnapshot api with already deleted s⦠If we try to delete the snapshot which is already deleted, then no proper error appears in the log and it just try to delete the snapshot which is already deleted. Steps to reproduce : --- 1-create a snapshot 2-delete the snapshot 3-try to delete snapshot which is deleted in step 2 Expected Result - Result should show proper error message. Request for deleting already deleted snapshot should not be placed. You can merge this pull request into a Git repository by running: $ git pull https://github.com/niteshsarda/cloudstack CS-50213 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cloudstack/pull/1924.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1924 commit f8ad3e8115f50f5de8511a80937a40723bbe4971 Author: Nitesh Sarda <nitesh_sa...@accelerite.com> Date: 2017-02-01T06:29:45Z CLOUDSTACK-9766 : Executing deleteSnapshot api with already deleted snapshot does not throw any exception or failure message --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request #1909: CLOUDSTACK-9740 : Search for secondary IP of ...
GitHub user niteshsarda opened a pull request: https://github.com/apache/cloudstack/pull/1909 CLOUDSTACK-9740 : Search for secondary IP of NIC that is attached to ⦠Search for secondary IP of NIC that is attached to an instance is not working. If instance has more than one secondary IP assigned and administrator attempts to search that list, all IPs are displayed instead of being filtered by the search string. in web UI: CCP dashboard -> Instances -> -> NICs -> âView Secondary IPsâ -> Search for a IP, but the search returns all the IPs in the list You can merge this pull request into a Git repository by running: $ git pull https://github.com/niteshsarda/cloudstack CS-9740 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cloudstack/pull/1909.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1909 commit 4b335fec047350d65031ef636d4c9b70b3a7ba98 Author: Nitesh Sarda <nitesh_sa...@accelerite.com> Date: 2017-01-17T11:05:54Z CLOUDSTACK-9740 : Search for secondary IP of NIC that is attached to an instance is not working --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
