[GitHub] cloudstack pull request #1813: CLOUDSTACK-9604: Root disk resize support for...
Github user pdube commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1813#discussion_r98259395
--- Diff:
plugins/hypervisors/xenserver/src/com/cloud/hypervisor/xenserver/resource/wrapper/xenbase/CitrixResizeVolumeCommandWrapper.java
---
@@ -48,6 +48,11 @@ public Answer execute(final ResizeVolumeCommand command,
final CitrixResourceBas
long newSize = command.getNewSize();
try {
+
+if(command.getCurrentSize() <= newSize) {
+s_logger.info("No need to resize volume: " + volId +",
current size " + command.getCurrentSize() + " is same as new size " + newSize);
+return new ResizeVolumeAnswer(command, true, "success",
newSize);
+}
--- End diff --
So you can't increase the size of a volume? This seems flawed
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request #1813: CLOUDSTACK-9604: Root disk resize support for...
Github user pdube commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1813#discussion_r98259959
--- Diff: server/src/com/cloud/vm/UserVmManagerImpl.java ---
@@ -3520,27 +3520,17 @@ public UserVmVO doInTransaction(TransactionStatus
status) throws InsufficientCap
}
rootDiskSize =
Long.parseLong(customParameters.get("rootdisksize"));
-// only KVM supports rootdisksize override
-if (hypervisorType != HypervisorType.KVM) {
--- End diff --
Why was XS blocked before?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request #1813: CLOUDSTACK-9604: Root disk resize support for...
Github user pdube commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1813#discussion_r98259432
--- Diff:
plugins/hypervisors/xenserver/test/com/cloud/hypervisor/xenserver/resource/wrapper/xenbase/CitrixRequestWrapperTest.java
---
@@ -436,7 +436,7 @@ public void testResizeVolumeCommand() {
final Answer answer = wrapper.execute(resizeCommand,
citrixResourceBase);
verify(citrixResourceBase, times(1)).getConnection();
-assertFalse(answer.getResult());
+//assertFalse(answer.getResult());
--- End diff --
Why comment this out?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1829: CLOUDSTACK-9363: Fix HVM VM restart bug in XenServer
Github user pdube commented on the issue: https://github.com/apache/cloudstack/pull/1829 @rhtyd @koushik-das definitely a blocker IMHO. Being unable to start/reboot a VM that has 3 volumes is unacceptable in a public cloud scenario --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1830: CLOUDSTACK-9677: Adding storage policy support for s...
Github user pdube commented on the issue: https://github.com/apache/cloudstack/pull/1830 Oops, closed by accident --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request #1830: CLOUDSTACK-9677: Adding storage policy suppor...
Github user pdube closed the pull request at: https://github.com/apache/cloudstack/pull/1830 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request #1830: CLOUDSTACK-9677: Adding storage policy suppor...
GitHub user pdube reopened a pull request: https://github.com/apache/cloudstack/pull/1830 CLOUDSTACK-9677: Adding storage policy support for swift as secondary⦠⦠storage Added support to use storage policies with swift You can merge this pull request into a Git repository by running: $ git pull https://github.com/pdube/cloudstack swift-storagepolicies Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cloudstack/pull/1830.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1830 commit b157381b9933e17bd2f0583ecf519c58faeffcb7 Author: Patrick Dube <pd...@cloudops.com> Date: 2016-12-14T18:57:20Z CLOUDSTACK-9677: Adding storage policy support for swift as secondary storage --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1830: CLOUDSTACK-9677: Adding storage policy support for s...
Github user pdube commented on the issue: https://github.com/apache/cloudstack/pull/1830 @syed Think you could take a look? Thanks --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1858: README: Happy Christmas, happy holidays!
Github user pdube commented on the issue: https://github.com/apache/cloudstack/pull/1858 Happy holidays! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request #1830: CLOUDSTACK-9677: Adding storage policy suppor...
GitHub user pdube opened a pull request: https://github.com/apache/cloudstack/pull/1830 CLOUDSTACK-9677: Adding storage policy support for swift as secondary⦠⦠storage Added support to use storage policies with swift You can merge this pull request into a Git repository by running: $ git pull https://github.com/pdube/cloudstack swift-storagepolicies Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cloudstack/pull/1830.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1830 commit b157381b9933e17bd2f0583ecf519c58faeffcb7 Author: Patrick Dube <pd...@cloudops.com> Date: 2016-12-14T18:57:20Z CLOUDSTACK-9677: Adding storage policy support for swift as secondary storage --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1820: CLOUDSTACK-9656 Preventing autoboxing NPE in Usage b...
Github user pdube commented on the issue: https://github.com/apache/cloudstack/pull/1820 @rhtyd Thanks for the speedy responses --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1820: CLOUDSTACK-9656 Preventing autoboxing NPE in Usage b...
Github user pdube commented on the issue: https://github.com/apache/cloudstack/pull/1820 @rhtyd Changed the PR to be against 4.9 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request #1820: CLOUDSTACK-9656 Preventing autoboxing NPE in ...
GitHub user pdube reopened a pull request: https://github.com/apache/cloudstack/pull/1820 CLOUDSTACK-9656 Preventing autoboxing NPE in Usage by setting a default role when not found https://issues.apache.org/jira/browse/CLOUDSTACK-9656 This is a workaround to avoid NPE when using the usage server with Projects To reproduce bug: Create project Add account to project Create VM within that project Run the usage server Same steps to test resolution You can merge this pull request into a Git repository by running: $ git pull https://github.com/pdube/cloudstack CLOUDSTACK-9656-usage-exception Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cloudstack/pull/1820.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1820 commit b7ac7fd2a3eddbe66c36a83b80ae6be303c01bc4 Author: Patrick Dube <pd...@cloudops.com> Date: 2016-12-07T19:39:28Z Preventing autoboxing NPE by setting a default role when not found --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request #1820: CLOUDSTACK-9656 Preventing autoboxing NPE in ...
Github user pdube closed the pull request at: https://github.com/apache/cloudstack/pull/1820 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1820: CLOUDSTACK-9656 Preventing autoboxing NPE in Usage b...
Github user pdube commented on the issue: https://github.com/apache/cloudstack/pull/1820 Ok will do, thanks --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request #1820: CLOUDSTACK-9656 Preventing autoboxing NPE in ...
GitHub user pdube opened a pull request: https://github.com/apache/cloudstack/pull/1820 CLOUDSTACK-9656 Preventing autoboxing NPE in Usage by setting a default role when not found https://issues.apache.org/jira/browse/CLOUDSTACK-9656 This is a workaround to avoid NPE when using the usage server with Projects To reproduce bug: Create project Add account to project Create VM within that project Run the usage server Same steps to test resolution You can merge this pull request into a Git repository by running: $ git pull https://github.com/pdube/cloudstack CLOUDSTACK-9656-usage-exception Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cloudstack/pull/1820.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1820 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request #1616: Added missing rules on router config, fixed o...
GitHub user pdube opened a pull request: https://github.com/apache/cloudstack/pull/1616 Added missing rules on router config, fixed ordering of multiple rule⦠â¦s, removed duplicate rules, added fix for network stats, added a check for b64 decoding (to pad incorrect b64). Also added a catch exception to be logged on the configure main. https://issues.apache.org/jira/browse/CLOUDSTACK-9430 https://issues.apache.org/jira/browse/CLOUDSTACK-9431 https://issues.apache.org/jira/browse/CLOUDSTACK-9435 https://issues.apache.org/jira/browse/CLOUDSTACK-9440 You can merge this pull request into a Git repository by running: $ git pull https://github.com/pdube/cloudstack 4.9-vr-iptables-fixes Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cloudstack/pull/1616.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1616 commit 9ab676206a5bfe94aad8d03345c8804d520b0488 Author: Patrick Dube <pd...@cloudops.com> Date: 2016-07-22T19:32:20Z Added missing rules on router config, fixed ordering of multiple rules, removed duplicate rules, added fix for network stats, added a check for b64 decoding (to pad incorrect b64). Also added a catch exception to be logged on the configure main. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1611: marvin: deploy clusters in separate threads
Github user pdube commented on the issue: https://github.com/apache/cloudstack/pull/1611 Nice. LGTM, code reviewed --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request #1611: marvin: deploy clusters in separate threads
Github user pdube commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1611#discussion_r71037734 --- Diff: tools/marvin/marvin/deployDataCenter.py --- @@ -224,6 +225,16 @@ def createClusters(self, clusters, zoneId, podId, vmwareDc=None): podId, clusterId) +for cluster in clusters: +threads = [] +for cluster in clusters: --- End diff -- Line 228 can be removed --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1609: [CLOUDSTACK-9430] Added fix for adding/editing Netwo...
Github user pdube commented on the issue: https://github.com/apache/cloudstack/pull/1609 Excellent. @leprechau were you able to test the fix? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request #1609: [CLOUDSTACK-9430] Added fix for adding/editin...
GitHub user pdube reopened a pull request: https://github.com/apache/cloudstack/pull/1609 [CLOUDSTACK-9430] Added fix for adding/editing Network ACL rule ordering BUG: https://issues.apache.org/jira/browse/CLOUDSTACK-9430 The issue occurred because all of the ACL rules get inserted before the old ones. Then, the cleanup deletes the duplicate rows, and leaves any new rule in front of the old ones. Here is an example with a simplified iptables view for ACL Ex: adding a rule 4 before add: 1,2,3 during add: 1',2',3',4',1,2,3 after add: 4',1,2,3 After fix: before add: 1,2,3 during add: 1,2,3,1',2',3',4' after add: 1',2',3',4' You can merge this pull request into a Git repository by running: $ git pull https://github.com/pdube/cloudstack network-acl-add-order Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cloudstack/pull/1609.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1609 commit 6dd6ef0c9a30f128657de22fa8b6ea8ab5daa133 Author: Patrick Dube <pd...@cloudops.com> Date: 2016-07-11T19:12:41Z Added fix for adding/editing Network ACL rule ordering --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request #1609: [CLOUDSTACK-9430] Added fix for adding/editin...
Github user pdube closed the pull request at: https://github.com/apache/cloudstack/pull/1609 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1609: [CLOUDSTACK-9430] Added fix for adding/editing Netwo...
Github user pdube commented on the issue: https://github.com/apache/cloudstack/pull/1609 The issue was with the teardown of a snapshots test --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request #1609: [CLOUDSTACK-9430] Added fix for adding/editin...
GitHub user pdube reopened a pull request: https://github.com/apache/cloudstack/pull/1609 [CLOUDSTACK-9430] Added fix for adding/editing Network ACL rule ordering BUG: https://issues.apache.org/jira/browse/CLOUDSTACK-9430 The issue occurred because all of the ACL rules get inserted before the old ones. Then, the cleanup deletes the duplicate rows, and leaves any new rule in front of the old ones. Here is an example with a simplified iptables view for ACL Ex: adding a rule 4 before add: 1,2,3 during add: 1',2',3',4',1,2,3 after add: 4',1,2,3 After fix: before add: 1,2,3 during add: 1,2,3,1',2',3',4' after add: 1',2',3',4' You can merge this pull request into a Git repository by running: $ git pull https://github.com/pdube/cloudstack network-acl-add-order Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cloudstack/pull/1609.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1609 commit 6dd6ef0c9a30f128657de22fa8b6ea8ab5daa133 Author: Patrick Dube <pd...@cloudops.com> Date: 2016-07-11T19:12:41Z Added fix for adding/editing Network ACL rule ordering --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request #1609: [CLOUDSTACK-9430] Added fix for adding/editin...
Github user pdube closed the pull request at: https://github.com/apache/cloudstack/pull/1609 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request #1609: [CLOUDSTACK-9430] Added fix for adding/editin...
GitHub user pdube opened a pull request: https://github.com/apache/cloudstack/pull/1609 [CLOUDSTACK-9430] Added fix for adding/editing Network ACL rule ordering BUG: https://issues.apache.org/jira/browse/CLOUDSTACK-9430 The issue occurred because all of the ACL rules get inserted before the old ones. Then, the cleanup deletes the duplicate rows, and leaves any new rule in front of the old ones. Here is an example with a simplified iptables view for ACL Ex: adding a rule 4 before add: 1,2,3 during add: 1',2',3',4',1,2,3 after add: 4',1,2,3 After fix: before add: 1,2,3 during add: 1,2,3,1',2',3',4' after add: 1',2',3',4' You can merge this pull request into a Git repository by running: $ git pull https://github.com/pdube/cloudstack network-acl-add-order Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cloudstack/pull/1609.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1609 commit 6dd6ef0c9a30f128657de22fa8b6ea8ab5daa133 Author: Patrick Dube <pd...@cloudops.com> Date: 2016-07-11T19:12:41Z Added fix for adding/editing Network ACL rule ordering --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1581: CLOUDSTACK-9404 Fixed ordering of network ACL rules ...
Github user pdube commented on the issue: https://github.com/apache/cloudstack/pull/1581 @kishankavala I think that the ultimate fix will be in the VR. However, the inversion of the list is fixed with this patch, and does not require a VR update. This is a good enough fix for now, as the ordering inversion is a critical security bug, since the rule numbers you are giving are not being applied as expected. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request #1581: CLOUDSTACK-9404 Fixed ordering of network ACL...
Github user pdube closed the pull request at: https://github.com/apache/cloudstack/pull/1581 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request #1581: CLOUDSTACK-9404 Fixed ordering of network ACL...
GitHub user pdube reopened a pull request: https://github.com/apache/cloudstack/pull/1581 CLOUDSTACK-9404 Fixed ordering of network ACL rules being sent to the VR. The comparator was inverted. Issue: https://issues.apache.org/jira/browse/CLOUDSTACK-9404 In this example, I created rules with the port numbers the same as the rule numbers. Chain ACL_INBOUND_eth2 (1 references) target prot opt source destination ACCEPT all -- anywhere 225.0.0.50 ACCEPT all -- anywhere vrrp.mcast.net DROP tcp -- anywhere anywhere tcp dpt:netstat DROP tcp -- anywhere anywhere tcp dpt:10 DROP tcp -- anywhere anywhere tcp dpt:5 DROP tcp -- anywhere anywhere tcp dpt:3 DROP tcp -- anywhere anywhere tcp dpt:2 DROP all -- anywhere anywhere We can see above that the rules are inverted. After the fix: Chain ACL_INBOUND_eth2 (1 references) target prot opt source destination ACCEPT all -- anywhere 225.0.0.50 ACCEPT all -- anywhere vrrp.mcast.net DROP tcp -- anywhere anywhere tcp dpt:2 DROP tcp -- anywhere anywhere tcp dpt:3 DROP tcp -- anywhere anywhere tcp dpt:5 DROP tcp -- anywhere anywhere tcp dpt:10 DROP tcp -- anywhere anywhere tcp dpt:netstat DROP all -- anywhere anywhere You can merge this pull request into a Git repository by running: $ git pull https://github.com/pdube/cloudstack network-acl-rules-order Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cloudstack/pull/1581.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1581 commit caf4a48075e0f59b5d101efdd3ac6b1bee8f4f39 Author: Patrick Dube <pd...@cloudops.com> Date: 2016-06-02T17:15:38Z Fixed ordering of network ACL rules being sent to the VR. The comparator was inverted commit 4c97a3981dc0d543e02f62f2bb4fc2eb805545c6 Author: Patrick Dube <pd...@cloudops.com> Date: 2016-06-02T17:44:39Z Added unit test to verify ordering commit 9cdd23fdc77e643d886c3af8cb0a60f9c4ddf84f Author: Patrick Dube <pd...@cloudops.com> Date: 2016-06-03T12:48:47Z Added ASF license to unit test file --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request #1581: CLOUDSTACK-9404 Fixed ordering of network ACL...
GitHub user pdube reopened a pull request: https://github.com/apache/cloudstack/pull/1581 CLOUDSTACK-9404 Fixed ordering of network ACL rules being sent to the VR. The comparator was inverted. Issue: https://issues.apache.org/jira/browse/CLOUDSTACK-9404 In this example, I created rules with the port numbers the same as the rule numbers. Chain ACL_INBOUND_eth2 (1 references) target prot opt source destination ACCEPT all -- anywhere 225.0.0.50 ACCEPT all -- anywhere vrrp.mcast.net DROP tcp -- anywhere anywhere tcp dpt:netstat DROP tcp -- anywhere anywhere tcp dpt:10 DROP tcp -- anywhere anywhere tcp dpt:5 DROP tcp -- anywhere anywhere tcp dpt:3 DROP tcp -- anywhere anywhere tcp dpt:2 DROP all -- anywhere anywhere We can see above that the rules are inverted. After the fix: Chain ACL_INBOUND_eth2 (1 references) target prot opt source destination ACCEPT all -- anywhere 225.0.0.50 ACCEPT all -- anywhere vrrp.mcast.net DROP tcp -- anywhere anywhere tcp dpt:2 DROP tcp -- anywhere anywhere tcp dpt:3 DROP tcp -- anywhere anywhere tcp dpt:5 DROP tcp -- anywhere anywhere tcp dpt:10 DROP tcp -- anywhere anywhere tcp dpt:netstat DROP all -- anywhere anywhere You can merge this pull request into a Git repository by running: $ git pull https://github.com/pdube/cloudstack network-acl-rules-order Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cloudstack/pull/1581.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1581 commit caf4a48075e0f59b5d101efdd3ac6b1bee8f4f39 Author: Patrick Dube <pd...@cloudops.com> Date: 2016-06-02T17:15:38Z Fixed ordering of network ACL rules being sent to the VR. The comparator was inverted commit 4c97a3981dc0d543e02f62f2bb4fc2eb805545c6 Author: Patrick Dube <pd...@cloudops.com> Date: 2016-06-02T17:44:39Z Added unit test to verify ordering commit 9cdd23fdc77e643d886c3af8cb0a60f9c4ddf84f Author: Patrick Dube <pd...@cloudops.com> Date: 2016-06-03T12:48:47Z Added ASF license to unit test file --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request #1581: CLOUDSTACK-9404 Fixed ordering of network ACL...
Github user pdube closed the pull request at: https://github.com/apache/cloudstack/pull/1581 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1581: CLOUDSTACK-9404 Fixed ordering of network ACL rules ...
Github user pdube commented on the issue: https://github.com/apache/cloudstack/pull/1581 Thanks @dmabry --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request #1581: CLOUDSTACK-9404 Fixed ordering of network ACL...
Github user pdube closed the pull request at: https://github.com/apache/cloudstack/pull/1581 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request #1581: CLOUDSTACK-9404 Fixed ordering of network ACL...
GitHub user pdube reopened a pull request: https://github.com/apache/cloudstack/pull/1581 CLOUDSTACK-9404 Fixed ordering of network ACL rules being sent to the VR. The comparator was inverted. Issue: https://issues.apache.org/jira/browse/CLOUDSTACK-9404 In this example, I created rules with the port numbers the same as the rule numbers. Chain ACL_INBOUND_eth2 (1 references) target prot opt source destination ACCEPT all -- anywhere 225.0.0.50 ACCEPT all -- anywhere vrrp.mcast.net DROP tcp -- anywhere anywhere tcp dpt:netstat DROP tcp -- anywhere anywhere tcp dpt:10 DROP tcp -- anywhere anywhere tcp dpt:5 DROP tcp -- anywhere anywhere tcp dpt:3 DROP tcp -- anywhere anywhere tcp dpt:2 DROP all -- anywhere anywhere We can see above that the rules are inverted. After the fix: Chain ACL_INBOUND_eth2 (1 references) target prot opt source destination ACCEPT all -- anywhere 225.0.0.50 ACCEPT all -- anywhere vrrp.mcast.net DROP tcp -- anywhere anywhere tcp dpt:2 DROP tcp -- anywhere anywhere tcp dpt:3 DROP tcp -- anywhere anywhere tcp dpt:5 DROP tcp -- anywhere anywhere tcp dpt:10 DROP tcp -- anywhere anywhere tcp dpt:netstat DROP all -- anywhere anywhere You can merge this pull request into a Git repository by running: $ git pull https://github.com/pdube/cloudstack network-acl-rules-order Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cloudstack/pull/1581.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1581 commit caf4a48075e0f59b5d101efdd3ac6b1bee8f4f39 Author: Patrick Dube <pd...@cloudops.com> Date: 2016-06-02T17:15:38Z Fixed ordering of network ACL rules being sent to the VR. The comparator was inverted commit 4c97a3981dc0d543e02f62f2bb4fc2eb805545c6 Author: Patrick Dube <pd...@cloudops.com> Date: 2016-06-02T17:44:39Z Added unit test to verify ordering commit 9cdd23fdc77e643d886c3af8cb0a60f9c4ddf84f Author: Patrick Dube <pd...@cloudops.com> Date: 2016-06-03T12:48:47Z Added ASF license to unit test file --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request #1581: CLOUDSTACK-9404 Fixed ordering of network ACL...
GitHub user pdube reopened a pull request: https://github.com/apache/cloudstack/pull/1581 CLOUDSTACK-9404 Fixed ordering of network ACL rules being sent to the VR. The comparator was inverted. Issue: https://issues.apache.org/jira/browse/CLOUDSTACK-9404 In this example, I created rules with the port numbers the same as the rule numbers. Chain ACL_INBOUND_eth2 (1 references) target prot opt source destination ACCEPT all -- anywhere 225.0.0.50 ACCEPT all -- anywhere vrrp.mcast.net DROP tcp -- anywhere anywhere tcp dpt:netstat DROP tcp -- anywhere anywhere tcp dpt:10 DROP tcp -- anywhere anywhere tcp dpt:5 DROP tcp -- anywhere anywhere tcp dpt:3 DROP tcp -- anywhere anywhere tcp dpt:2 DROP all -- anywhere anywhere We can see above that the rules are inverted. After the fix: Chain ACL_INBOUND_eth2 (1 references) target prot opt source destination ACCEPT all -- anywhere 225.0.0.50 ACCEPT all -- anywhere vrrp.mcast.net DROP tcp -- anywhere anywhere tcp dpt:2 DROP tcp -- anywhere anywhere tcp dpt:3 DROP tcp -- anywhere anywhere tcp dpt:5 DROP tcp -- anywhere anywhere tcp dpt:10 DROP tcp -- anywhere anywhere tcp dpt:netstat DROP all -- anywhere anywhere You can merge this pull request into a Git repository by running: $ git pull https://github.com/pdube/cloudstack network-acl-rules-order Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cloudstack/pull/1581.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1581 commit caf4a48075e0f59b5d101efdd3ac6b1bee8f4f39 Author: Patrick Dube <pd...@cloudops.com> Date: 2016-06-02T17:15:38Z Fixed ordering of network ACL rules being sent to the VR. The comparator was inverted commit 4c97a3981dc0d543e02f62f2bb4fc2eb805545c6 Author: Patrick Dube <pd...@cloudops.com> Date: 2016-06-02T17:44:39Z Added unit test to verify ordering commit 9cdd23fdc77e643d886c3af8cb0a60f9c4ddf84f Author: Patrick Dube <pd...@cloudops.com> Date: 2016-06-03T12:48:47Z Added ASF license to unit test file --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request #1581: CLOUDSTACK-9404 Fixed ordering of network ACL...
Github user pdube closed the pull request at: https://github.com/apache/cloudstack/pull/1581 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1581: CLOUDSTACK-9404 Fixed ordering of network ACL rules ...
Github user pdube commented on the issue: https://github.com/apache/cloudstack/pull/1581 The Travis build has timed out 3 times now. Is there any known issue with Travis right now @swill ? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1581: CLOUDSTACK-9404 Fixed ordering of network ACL rules ...
Github user pdube commented on the issue: https://github.com/apache/cloudstack/pull/1581 @remibergsma Yes, the rules should appear in the right order now. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request #1581: CLOUDSTACK-9404 Fixed ordering of network ACL...
GitHub user pdube reopened a pull request: https://github.com/apache/cloudstack/pull/1581 CLOUDSTACK-9404 Fixed ordering of network ACL rules being sent to the VR. The comparator was inverted. Issue: https://issues.apache.org/jira/browse/CLOUDSTACK-9404 In this example, I created rules with the port numbers the same as the rule numbers. Chain ACL_INBOUND_eth2 (1 references) target prot opt source destination ACCEPT all -- anywhere 225.0.0.50 ACCEPT all -- anywhere vrrp.mcast.net DROP tcp -- anywhere anywhere tcp dpt:netstat DROP tcp -- anywhere anywhere tcp dpt:10 DROP tcp -- anywhere anywhere tcp dpt:5 DROP tcp -- anywhere anywhere tcp dpt:3 DROP tcp -- anywhere anywhere tcp dpt:2 DROP all -- anywhere anywhere We can see above that the rules are inverted. After the fix: Chain ACL_INBOUND_eth2 (1 references) target prot opt source destination ACCEPT all -- anywhere 225.0.0.50 ACCEPT all -- anywhere vrrp.mcast.net DROP tcp -- anywhere anywhere tcp dpt:2 DROP tcp -- anywhere anywhere tcp dpt:3 DROP tcp -- anywhere anywhere tcp dpt:5 DROP tcp -- anywhere anywhere tcp dpt:10 DROP tcp -- anywhere anywhere tcp dpt:netstat DROP all -- anywhere anywhere You can merge this pull request into a Git repository by running: $ git pull https://github.com/pdube/cloudstack network-acl-rules-order Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cloudstack/pull/1581.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1581 commit caf4a48075e0f59b5d101efdd3ac6b1bee8f4f39 Author: Patrick Dube <pd...@cloudops.com> Date: 2016-06-02T17:15:38Z Fixed ordering of network ACL rules being sent to the VR. The comparator was inverted commit 4c97a3981dc0d543e02f62f2bb4fc2eb805545c6 Author: Patrick Dube <pd...@cloudops.com> Date: 2016-06-02T17:44:39Z Added unit test to verify ordering commit 9cdd23fdc77e643d886c3af8cb0a60f9c4ddf84f Author: Patrick Dube <pd...@cloudops.com> Date: 2016-06-03T12:48:47Z Added ASF license to unit test file --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request #1581: CLOUDSTACK-9404 Fixed ordering of network ACL...
Github user pdube closed the pull request at: https://github.com/apache/cloudstack/pull/1581 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1581: CLOUDSTACK-9404 Fixed ordering of network ACL rules ...
Github user pdube commented on the issue: https://github.com/apache/cloudstack/pull/1581 @pdube Travis timed out, you may want to try the Travis Lottery again ;-) Is this ready for testing? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request #1581: CLOUDSTACK-9404 Fixed ordering of network ACL...
Github user pdube closed the pull request at: https://github.com/apache/cloudstack/pull/1581 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request #1581: CLOUDSTACK-9404 Fixed ordering of network ACL...
GitHub user pdube reopened a pull request: https://github.com/apache/cloudstack/pull/1581 CLOUDSTACK-9404 Fixed ordering of network ACL rules being sent to the VR. The comparator was inverted. Issue: https://issues.apache.org/jira/browse/CLOUDSTACK-9404 In this example, I created rules with the port numbers the same as the rule numbers. Chain ACL_INBOUND_eth2 (1 references) target prot opt source destination ACCEPT all -- anywhere 225.0.0.50 ACCEPT all -- anywhere vrrp.mcast.net DROP tcp -- anywhere anywhere tcp dpt:netstat DROP tcp -- anywhere anywhere tcp dpt:10 DROP tcp -- anywhere anywhere tcp dpt:5 DROP tcp -- anywhere anywhere tcp dpt:3 DROP tcp -- anywhere anywhere tcp dpt:2 DROP all -- anywhere anywhere We can see above that the rules are inverted. After the fix: Chain ACL_INBOUND_eth2 (1 references) target prot opt source destination ACCEPT all -- anywhere 225.0.0.50 ACCEPT all -- anywhere vrrp.mcast.net DROP tcp -- anywhere anywhere tcp dpt:2 DROP tcp -- anywhere anywhere tcp dpt:3 DROP tcp -- anywhere anywhere tcp dpt:5 DROP tcp -- anywhere anywhere tcp dpt:10 DROP tcp -- anywhere anywhere tcp dpt:netstat DROP all -- anywhere anywhere You can merge this pull request into a Git repository by running: $ git pull https://github.com/pdube/cloudstack network-acl-rules-order Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cloudstack/pull/1581.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1581 commit caf4a48075e0f59b5d101efdd3ac6b1bee8f4f39 Author: Patrick Dube <pd...@cloudops.com> Date: 2016-06-02T17:15:38Z Fixed ordering of network ACL rules being sent to the VR. The comparator was inverted commit 4c97a3981dc0d543e02f62f2bb4fc2eb805545c6 Author: Patrick Dube <pd...@cloudops.com> Date: 2016-06-02T17:44:39Z Added unit test to verify ordering commit 9cdd23fdc77e643d886c3af8cb0a60f9c4ddf84f Author: Patrick Dube <pd...@cloudops.com> Date: 2016-06-03T12:48:47Z Added ASF license to unit test file --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request #1581: CLOUDSTACK-9404 Fixed ordering of network ACL...
Github user pdube commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1581#discussion_r65701961 --- Diff: core/test/com/cloud/agent/api/routing/SetNetworkACLCommandTest.java --- @@ -0,0 +1,34 @@ +package com.cloud.agent.api.routing; --- End diff -- Thanks, updated it --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request #1581: CLOUDSTACK-9404 Fixed ordering of network ACL...
GitHub user pdube opened a pull request: https://github.com/apache/cloudstack/pull/1581 CLOUDSTACK-9404 Fixed ordering of network ACL rules being sent to the VR. The comparator was inverted. Issue: https://issues.apache.org/jira/browse/CLOUDSTACK-9404 In this example, I created rules with the port numbers the same as the rule numbers. Chain ACL_INBOUND_eth2 (1 references) target prot opt source destination ACCEPT all -- anywhere 225.0.0.50 ACCEPT all -- anywhere vrrp.mcast.net DROP tcp -- anywhere anywhere tcp dpt:netstat DROP tcp -- anywhere anywhere tcp dpt:10 DROP tcp -- anywhere anywhere tcp dpt:5 DROP tcp -- anywhere anywhere tcp dpt:3 DROP tcp -- anywhere anywhere tcp dpt:2 DROP all -- anywhere anywhere We can see above that the rules are inverted. After the fix: Chain ACL_INBOUND_eth2 (1 references) target prot opt source destination ACCEPT all -- anywhere 225.0.0.50 ACCEPT all -- anywhere vrrp.mcast.net DROP tcp -- anywhere anywhere tcp dpt:2 DROP tcp -- anywhere anywhere tcp dpt:3 DROP tcp -- anywhere anywhere tcp dpt:5 DROP tcp -- anywhere anywhere tcp dpt:10 DROP tcp -- anywhere anywhere tcp dpt:netstat DROP all -- anywhere anywhere You can merge this pull request into a Git repository by running: $ git pull https://github.com/pdube/cloudstack network-acl-rules-order Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cloudstack/pull/1581.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1581 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: When no zone name is available display a ...
Github user pdube commented on the pull request: https://github.com/apache/cloudstack/pull/1477#issuecomment-213822378 LGTM. Do you think we should translate this? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: Fix deleting template from UI
Github user pdube commented on the pull request: https://github.com/apache/cloudstack/pull/1476#issuecomment-213116347 Hey @remibergsma just noticed that you had a PR open for this. I fixed it as well with #1505 so we might be able to close this one --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-9172 Added cross zones check t...
Github user pdube commented on the pull request: https://github.com/apache/cloudstack/pull/1505#issuecomment-212950771 Screen shot from [before](https://issues.apache.org/jira/secure/attachment/1250/Screen%20Shot%202015-12-15%20at%2015.32.12.png) the fix After: https://cloud.githubusercontent.com/assets/2355044/14712966/4edb4210-07ad-11e6-98ec-a25aa2afddbe.png;> https://cloud.githubusercontent.com/assets/2355044/14712964/4ed4d75e-07ad-11e6-8a2f-0697d5d872bc.png;> https://cloud.githubusercontent.com/assets/2355044/14712965/4ed5c8d0-07ad-11e6-87bb-11d98cbbca98.png;> --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-9172 Added cross zones check t...
Github user pdube closed the pull request at: https://github.com/apache/cloudstack/pull/1504 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-9172 Added cross zones check t...
Github user pdube commented on the pull request: https://github.com/apache/cloudstack/pull/1504#issuecomment-212587181 Pushing towards 4.7 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-9172 Added cross zones check t...
GitHub user pdube opened a pull request: https://github.com/apache/cloudstack/pull/1505 CLOUDSTACK-9172 Added cross zones check to delete template and iso Added a check to ignore the zoneid, in the delete template UI, if the template is cross zones. reference : CLOUDSTACK-9172 You can merge this pull request into a Git repository by running: $ git pull https://github.com/pdube/cloudstack CLOUDSTACK-9172-delete-cross-zones-template Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cloudstack/pull/1505.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1505 commit cfd2ce71edbab431412f48b14011c8a137df1d22 Author: Patrick Dube <pd...@cloudops.com> Date: 2016-04-20T20:16:32Z CLOUDSTACK-9172 Added cross zones check to delete template and iso --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-9172 Added cross zones check t...
GitHub user pdube opened a pull request: https://github.com/apache/cloudstack/pull/1504 CLOUDSTACK-9172 Added cross zones check to delete template and iso Added a check to ignore the zoneid, in the delete template UI, if the template is cross zones. reference : CLOUDSTACK-9172 You can merge this pull request into a Git repository by running: $ git pull https://github.com/pdube/cloudstack CLOUDSTACK-9172-delete-cross-zones-template Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cloudstack/pull/1504.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1504 commit cfd2ce71edbab431412f48b14011c8a137df1d22 Author: Patrick Dube <pd...@cloudops.com> Date: 2016-04-20T20:16:32Z CLOUDSTACK-9172 Added cross zones check to delete template and iso --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-8562: Dynamic Role-Based API C...
Github user pdube commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1489#discussion_r59812425
--- Diff: api/src/org/apache/cloudstack/acl/RoleType.java ---
@@ -16,18 +16,90 @@
// under the License.
package org.apache.cloudstack.acl;
+import com.cloud.user.Account;
+import com.google.common.base.Enums;
+import com.google.common.base.Strings;
+
// Enum for default roles in CloudStack
public enum RoleType {
-Admin(1), ResourceAdmin(2), DomainAdmin(4), User(8), Unknown(0);
+Admin(1L, Account.ACCOUNT_TYPE_ADMIN, 1),
+ResourceAdmin(2L, Account.ACCOUNT_TYPE_RESOURCE_DOMAIN_ADMIN, 2),
+DomainAdmin(3L, Account.ACCOUNT_TYPE_DOMAIN_ADMIN, 4),
+User(4L, Account.ACCOUNT_TYPE_NORMAL, 8),
+Unknown(-1L, (short) -1, 0);
+private long id;
+private short accountType;
private int mask;
-private RoleType(int mask) {
+RoleType(final long id, final short accountType, final int mask) {
+this.id = id;
+this.accountType = accountType;
this.mask = mask;
}
-public int getValue() {
+public long getId() {
+return id;
+}
+
+public short getAccountType() {
+return accountType;
+}
+
+public int getMask() {
return mask;
}
-}
+public static RoleType fromString(final String name) {
+if (!Strings.isNullOrEmpty(name)
+&& Enums.getIfPresent(RoleType.class, name).isPresent()) {
+return RoleType.valueOf(name);
+}
+return null;
+}
+
+public static RoleType fromMask(int mask) {
+for (RoleType roleType : RoleType.values()) {
+if (roleType.getMask() == mask) {
+return roleType;
+}
+}
+return Unknown;
+}
+
+public static RoleType getByAccountType(final short accountType) {
+RoleType roleType = RoleType.Unknown;
+switch (accountType) {
+case Account.ACCOUNT_TYPE_ADMIN:
+roleType = RoleType.Admin;
+break;
+case Account.ACCOUNT_TYPE_DOMAIN_ADMIN:
+roleType = RoleType.DomainAdmin;
+break;
+case Account.ACCOUNT_TYPE_RESOURCE_DOMAIN_ADMIN:
+roleType = RoleType.ResourceAdmin;
--- End diff --
Thanks. I had seen it in the code and looked for more information about it,
but didn't find anything conclusive
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-8562: Dynamic Role-Based API C...
Github user pdube commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1489#discussion_r59777518
--- Diff: api/src/org/apache/cloudstack/acl/RoleType.java ---
@@ -16,18 +16,90 @@
// under the License.
package org.apache.cloudstack.acl;
+import com.cloud.user.Account;
+import com.google.common.base.Enums;
+import com.google.common.base.Strings;
+
// Enum for default roles in CloudStack
public enum RoleType {
-Admin(1), ResourceAdmin(2), DomainAdmin(4), User(8), Unknown(0);
+Admin(1L, Account.ACCOUNT_TYPE_ADMIN, 1),
+ResourceAdmin(2L, Account.ACCOUNT_TYPE_RESOURCE_DOMAIN_ADMIN, 2),
+DomainAdmin(3L, Account.ACCOUNT_TYPE_DOMAIN_ADMIN, 4),
+User(4L, Account.ACCOUNT_TYPE_NORMAL, 8),
+Unknown(-1L, (short) -1, 0);
+private long id;
+private short accountType;
private int mask;
-private RoleType(int mask) {
+RoleType(final long id, final short accountType, final int mask) {
+this.id = id;
+this.accountType = accountType;
this.mask = mask;
}
-public int getValue() {
+public long getId() {
+return id;
+}
+
+public short getAccountType() {
+return accountType;
+}
+
+public int getMask() {
return mask;
}
-}
+public static RoleType fromString(final String name) {
+if (!Strings.isNullOrEmpty(name)
+&& Enums.getIfPresent(RoleType.class, name).isPresent()) {
+return RoleType.valueOf(name);
+}
+return null;
+}
+
+public static RoleType fromMask(int mask) {
+for (RoleType roleType : RoleType.values()) {
+if (roleType.getMask() == mask) {
+return roleType;
+}
+}
+return Unknown;
+}
+
+public static RoleType getByAccountType(final short accountType) {
+RoleType roleType = RoleType.Unknown;
+switch (accountType) {
+case Account.ACCOUNT_TYPE_ADMIN:
+roleType = RoleType.Admin;
+break;
+case Account.ACCOUNT_TYPE_DOMAIN_ADMIN:
+roleType = RoleType.DomainAdmin;
+break;
+case Account.ACCOUNT_TYPE_RESOURCE_DOMAIN_ADMIN:
+roleType = RoleType.ResourceAdmin;
--- End diff --
I meant the ResourceAdmin specifically. What is this role? Is there any
documentation on it?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-8562: Dynamic Role-Based API C...
Github user pdube commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1489#discussion_r59730927
--- Diff: api/src/org/apache/cloudstack/acl/RoleService.java ---
@@ -0,0 +1,43 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+package org.apache.cloudstack.acl;
+
+import org.apache.cloudstack.framework.config.ConfigKey;
+
+import java.util.List;
+
+public interface RoleService {
+
+ConfigKey EnableDynamicApiChecker = new ConfigKey<>("Hidden",
Boolean.class, "dynamic.apichecker.enabled", "false",
+"If set to true, this enables the dynamic role-based api
access checker and disables the default static role-based api access checker.",
+true);
+
+boolean isEnabled();
+Role findRole(final Long id);
+Role createRole(final String name, final RoleType roleType, final
String description);
+boolean updateRole(final Role role, final String name, final RoleType
roleType, final String description);
+boolean deleteRole(final Role role);
+
+RolePermission findRolePermission(final Long id);
+RolePermission createRolePermission(final Role role, final Rule rule,
final RolePermission.Permission permission, final String description);
+boolean updateRolePermission(final RolePermission rolePermission,
final Rule rule, final RolePermission.Permission permission, final String
description);
+boolean deleteRolePermission(final RolePermission rolePermission);
+
+List findAllRolesBy(final Long id, final String name, final
RoleType roleType);
--- End diff --
I would have to agree with @DaanHoogland. Splitting into separate methods
would be clearer and probably simplify the business logic per method as well
(so it would be simpler to unit test).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-8562: Dynamic Role-Based API C...
Github user pdube commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1489#discussion_r59730334
--- Diff: api/src/org/apache/cloudstack/acl/RoleType.java ---
@@ -16,18 +16,90 @@
// under the License.
package org.apache.cloudstack.acl;
+import com.cloud.user.Account;
+import com.google.common.base.Enums;
+import com.google.common.base.Strings;
+
// Enum for default roles in CloudStack
public enum RoleType {
-Admin(1), ResourceAdmin(2), DomainAdmin(4), User(8), Unknown(0);
+Admin(1L, Account.ACCOUNT_TYPE_ADMIN, 1),
+ResourceAdmin(2L, Account.ACCOUNT_TYPE_RESOURCE_DOMAIN_ADMIN, 2),
+DomainAdmin(3L, Account.ACCOUNT_TYPE_DOMAIN_ADMIN, 4),
+User(4L, Account.ACCOUNT_TYPE_NORMAL, 8),
+Unknown(-1L, (short) -1, 0);
+private long id;
+private short accountType;
private int mask;
-private RoleType(int mask) {
+RoleType(final long id, final short accountType, final int mask) {
+this.id = id;
+this.accountType = accountType;
this.mask = mask;
}
-public int getValue() {
+public long getId() {
+return id;
+}
+
+public short getAccountType() {
+return accountType;
+}
+
+public int getMask() {
return mask;
}
-}
+public static RoleType fromString(final String name) {
+if (!Strings.isNullOrEmpty(name)
+&& Enums.getIfPresent(RoleType.class, name).isPresent()) {
+return RoleType.valueOf(name);
+}
+return null;
+}
+
+public static RoleType fromMask(int mask) {
+for (RoleType roleType : RoleType.values()) {
+if (roleType.getMask() == mask) {
+return roleType;
+}
+}
+return Unknown;
+}
+
+public static RoleType getByAccountType(final short accountType) {
+RoleType roleType = RoleType.Unknown;
+switch (accountType) {
+case Account.ACCOUNT_TYPE_ADMIN:
+roleType = RoleType.Admin;
+break;
+case Account.ACCOUNT_TYPE_DOMAIN_ADMIN:
+roleType = RoleType.DomainAdmin;
+break;
+case Account.ACCOUNT_TYPE_RESOURCE_DOMAIN_ADMIN:
+roleType = RoleType.ResourceAdmin;
+break;
+case Account.ACCOUNT_TYPE_NORMAL:
+roleType = RoleType.User;
+break;
+}
+return roleType;
+}
+
+public static Long getRoleByAccountType(final Long roleId, final Short
accountType) {
--- End diff --
Why are you passing in a roleId, if you are getting a role id by account
type?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-8562: Dynamic Role-Based API C...
Github user pdube commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1489#discussion_r59730081
--- Diff: api/src/org/apache/cloudstack/acl/RoleType.java ---
@@ -16,18 +16,90 @@
// under the License.
package org.apache.cloudstack.acl;
+import com.cloud.user.Account;
+import com.google.common.base.Enums;
+import com.google.common.base.Strings;
+
// Enum for default roles in CloudStack
public enum RoleType {
-Admin(1), ResourceAdmin(2), DomainAdmin(4), User(8), Unknown(0);
+Admin(1L, Account.ACCOUNT_TYPE_ADMIN, 1),
+ResourceAdmin(2L, Account.ACCOUNT_TYPE_RESOURCE_DOMAIN_ADMIN, 2),
+DomainAdmin(3L, Account.ACCOUNT_TYPE_DOMAIN_ADMIN, 4),
+User(4L, Account.ACCOUNT_TYPE_NORMAL, 8),
+Unknown(-1L, (short) -1, 0);
+private long id;
+private short accountType;
private int mask;
-private RoleType(int mask) {
+RoleType(final long id, final short accountType, final int mask) {
+this.id = id;
+this.accountType = accountType;
this.mask = mask;
}
-public int getValue() {
+public long getId() {
+return id;
+}
+
+public short getAccountType() {
+return accountType;
+}
+
+public int getMask() {
return mask;
}
-}
+public static RoleType fromString(final String name) {
+if (!Strings.isNullOrEmpty(name)
+&& Enums.getIfPresent(RoleType.class, name).isPresent()) {
+return RoleType.valueOf(name);
+}
+return null;
+}
+
+public static RoleType fromMask(int mask) {
+for (RoleType roleType : RoleType.values()) {
+if (roleType.getMask() == mask) {
+return roleType;
+}
+}
+return Unknown;
+}
+
+public static RoleType getByAccountType(final short accountType) {
+RoleType roleType = RoleType.Unknown;
+switch (accountType) {
+case Account.ACCOUNT_TYPE_ADMIN:
+roleType = RoleType.Admin;
+break;
+case Account.ACCOUNT_TYPE_DOMAIN_ADMIN:
+roleType = RoleType.DomainAdmin;
+break;
+case Account.ACCOUNT_TYPE_RESOURCE_DOMAIN_ADMIN:
+roleType = RoleType.ResourceAdmin;
--- End diff --
What is this role type? Is there any documentation on it?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Fixes regarding VOLUME_DELETE events resu...
Github user pdube commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1491#discussion_r59644462
--- Diff: server/src/com/cloud/user/AccountManagerImpl.java ---
@@ -761,6 +774,17 @@ protected boolean cleanupAccount(AccountVO account,
long callerUserId, Account c
s_logger.error("Unable to expunge vm: " + vm.getId());
accountCleanupNeeded = true;
}
+else if
(!vm.getState().equals(VirtualMachine.State.Destroyed)) {
--- End diff --
Also, do you know if the expunge thread propagates the usage event
correctly?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Fixes regarding VOLUME_DELETE events resu...
Github user pdube commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1491#discussion_r59644306
--- Diff: server/src/com/cloud/user/AccountManagerImpl.java ---
@@ -761,6 +774,17 @@ protected boolean cleanupAccount(AccountVO account,
long callerUserId, Account c
s_logger.error("Unable to expunge vm: " + vm.getId());
accountCleanupNeeded = true;
}
+else if
(!vm.getState().equals(VirtualMachine.State.Destroyed)) {
--- End diff --
In what case would the vm's state be destroyed, when the vm was expunged
above?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Fixed Profiler's unit tests bugs.
Github user pdube commented on the pull request: https://github.com/apache/cloudstack/pull/1445#issuecomment-209026629 Just trying to help get things merged :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: Fixed Profiler's unit tests bugs.
Github user pdube commented on the pull request: https://github.com/apache/cloudstack/pull/1445#issuecomment-209023846 @rafaelweingartner @swill The only thing changed was the unit tests, which I ran. And the only code change he did was to remove useless variables. @swill also gave his LGTM higher --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: Fixed Profiler's unit tests bugs.
Github user pdube commented on the pull request: https://github.com/apache/cloudstack/pull/1445#issuecomment-209017286 @swill this looks ready, no? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: Cloudstack-9285 exception log addition
Github user pdube commented on the pull request: https://github.com/apache/cloudstack/pull/1479#issuecomment-207537198 Simply added a log warning. Built it LGTM [INFO] [INFO] Reactor Summary: [INFO] [INFO] Apache CloudStack Developer Tools - Checkstyle Configuration SUCCESS [ 2.360 s] [INFO] Apache CloudStack . SUCCESS [ 3.182 s] [INFO] Apache CloudStack Maven Conventions Parent SUCCESS [ 2.313 s] [INFO] Apache CloudStack Framework - Managed Context . SUCCESS [ 7.212 s] [INFO] Apache CloudStack Utils ... SUCCESS [ 30.024 s] [INFO] Apache CloudStack Framework ... SUCCESS [ 0.086 s] [INFO] Apache CloudStack Framework - Event Notification .. SUCCESS [ 13.763 s] [INFO] Apache CloudStack Framework - Configuration ... SUCCESS [ 6.532 s] [INFO] Apache CloudStack API . SUCCESS [ 29.538 s] [INFO] Apache CloudStack Framework - REST SUCCESS [ 3.283 s] [INFO] Apache CloudStack Framework - IPC . SUCCESS [ 6.880 s] [INFO] Apache CloudStack Cloud Engine SUCCESS [ 0.065 s] [INFO] Apache CloudStack Cloud Engine API SUCCESS [ 7.692 s] [INFO] Apache CloudStack Framework - Security SUCCESS [ 3.352 s] [INFO] Apache CloudStack Core SUCCESS [ 52.743 s] [INFO] Apache CloudStack Agents .. SUCCESS [ 12.096 s] [INFO] Apache CloudStack Framework - Clustering .. SUCCESS [ 6.700 s] [INFO] Apache CloudStack Framework - Event Notification .. SUCCESS [ 1.773 s] [INFO] Apache CloudStack Cloud Engine Schema Component ... SUCCESS [ 17.664 s] [INFO] Apache CloudStack Framework - Jobs SUCCESS [ 6.236 s] [INFO] Apache CloudStack Cloud Engine Internal Components API SUCCESS [ 3.874 s] [INFO] Apache CloudStack Server .. SUCCESS [ 56.665 s] [INFO] Apache CloudStack Framework - Quota ... SUCCESS [ 7.043 s] [INFO] Apache CloudStack Usage Server SUCCESS [ 7.046 s] [INFO] Apache CloudStack Cloud Engine Orchestration Component SUCCESS [ 16.652 s] [INFO] Apache CloudStack Cloud Services .. SUCCESS [ 0.048 s] [INFO] Apache CloudStack Secondary Storage ... SUCCESS [ 0.459 s] [INFO] Apache CloudStack Secondary Storage Service ... SUCCESS [ 7.624 s] [INFO] Apache CloudStack Engine Storage Component SUCCESS [ 12.711 s] [INFO] Apache CloudStack Engine Storage Volume Component . SUCCESS [ 6.630 s] [INFO] Apache CloudStack Engine Storage Image Component .. SUCCESS [ 3.930 s] [INFO] Apache CloudStack Engine Storage Data Motion Component SUCCESS [ 3.298 s] [INFO] Apache CloudStack Engine Storage Cache Component .. SUCCESS [ 3.176 s] [INFO] Apache CloudStack Engine Storage Snapshot Component SUCCESS [ 10.710 s] [INFO] Apache CloudStack Cloud Engine API SUCCESS [ 1.993 s] [INFO] Apache CloudStack Cloud Engine Service SUCCESS [ 6.200 s] [INFO] Apache CloudStack Plugin POM .. SUCCESS [ 0.389 s] [INFO] Apache CloudStack Plugin - API Rate Limit . SUCCESS [ 7.510 s] [INFO] Apache CloudStack Plugin - Storage Volume default provider SUCCESS [ 2.485 s] [INFO] Apache CloudStack Plugin - Storage Volume SolidFire Provider SUCCESS [ 5.964 s] [INFO] Apache CloudStack Plugin - API SolidFire .. SUCCESS [ 3.038 s] [INFO] Apache CloudStack Plugin - API Discovery .. SUCCESS [ 4.980 s] [INFO] Apache CloudStack Plugin - ACL Static Role Based .. SUCCESS [ 1.830 s] [INFO] Apache CloudStack Plugin - Host Anti-Affinity Processor SUCCESS [ 2.796 s] [INFO] Apache CloudStack Plugin - Explicit Dedication Processor SUCCESS [ 2.379 s] [INFO] Apache CloudStack Plugin - User Concentrated Pod Deployment Planner SUCCESS [ 2.108 s] [INFO] Apache CloudStack Plugin - User Dispersing Deployment Planner SUCCESS [ 2.554 s] [INFO] Apache CloudStack Plugin - Implicit Dedication Planner SUCCESS [ 7.570 s] [INFO] Apache CloudStack Plugin - Skip Heurestics Planner SUCCESS [ 1.979 s] [INFO] Apache CloudStack Plugin - Host Allocator Random .. SUCCESS [ 2.152 s] [INFO] Apache CloudStack Plugin - Dedicated Resources SUCCESS [ 7.137 s] [INFO] Apache CloudStack Plugin - Hypervisor OracleVM SUCCESS [ 2.642 s] [INFO] Apache CloudStack Plugin - Open vSwitch ... SUCCESS [ 3.167 s] [INFO] Apache CloudStack Plugin - Hypervisor XenServer ... SUCCESS [ 23.396 s] [INFO] Apache CloudStack Plugin - Hypervisor KVM . SUCCESS [ 12.189
[GitHub] cloudstack pull request: Removed unused code from com.cloud.api.Ap...
Github user pdube commented on the pull request: https://github.com/apache/cloudstack/pull/1263#issuecomment-207490720 Built the package LGTM after review [INFO] [INFO] Reactor Summary: [INFO] [INFO] Apache CloudStack Developer Tools - Checkstyle Configuration SUCCESS [ 1.746 s] [INFO] Apache CloudStack . SUCCESS [ 2.011 s] [INFO] Apache CloudStack Maven Conventions Parent SUCCESS [ 0.843 s] [INFO] Apache CloudStack Framework - Managed Context . SUCCESS [ 3.186 s] [INFO] Apache CloudStack Utils ... SUCCESS [ 20.485 s] [INFO] Apache CloudStack Framework ... SUCCESS [ 0.045 s] [INFO] Apache CloudStack Framework - Event Notification .. SUCCESS [ 7.133 s] [INFO] Apache CloudStack Framework - Configuration ... SUCCESS [ 3.534 s] [INFO] Apache CloudStack API . SUCCESS [ 14.776 s] [INFO] Apache CloudStack Framework - REST SUCCESS [ 2.349 s] [INFO] Apache CloudStack Framework - IPC . SUCCESS [ 4.402 s] [INFO] Apache CloudStack Cloud Engine SUCCESS [ 0.041 s] [INFO] Apache CloudStack Cloud Engine API SUCCESS [ 5.061 s] [INFO] Apache CloudStack Framework - Security SUCCESS [ 1.998 s] [INFO] Apache CloudStack Core SUCCESS [ 25.450 s] [INFO] Apache CloudStack Agents .. SUCCESS [ 7.287 s] [INFO] Apache CloudStack Framework - Clustering .. SUCCESS [ 3.947 s] [INFO] Apache CloudStack Framework - Event Notification .. SUCCESS [ 1.373 s] [INFO] Apache CloudStack Cloud Engine Schema Component ... SUCCESS [ 13.294 s] [INFO] Apache CloudStack Framework - Jobs SUCCESS [ 4.572 s] [INFO] Apache CloudStack Cloud Engine Internal Components API SUCCESS [ 2.407 s] [INFO] Apache CloudStack Server .. SUCCESS [ 47.212 s] [INFO] Apache CloudStack Framework - Quota ... SUCCESS [ 5.660 s] [INFO] Apache CloudStack Usage Server SUCCESS [ 6.111 s] [INFO] Apache CloudStack Cloud Engine Orchestration Component SUCCESS [ 7.877 s] [INFO] Apache CloudStack Cloud Services .. SUCCESS [ 0.034 s] [INFO] Apache CloudStack Secondary Storage ... SUCCESS [ 0.255 s] [INFO] Apache CloudStack Secondary Storage Service ... SUCCESS [ 7.772 s] [INFO] Apache CloudStack Engine Storage Component SUCCESS [ 10.002 s] [INFO] Apache CloudStack Engine Storage Volume Component . SUCCESS [ 10.349 s] [INFO] Apache CloudStack Engine Storage Image Component .. SUCCESS [ 5.808 s] [INFO] Apache CloudStack Engine Storage Data Motion Component SUCCESS [ 6.406 s] [INFO] Apache CloudStack Engine Storage Cache Component .. SUCCESS [ 5.709 s] [INFO] Apache CloudStack Engine Storage Snapshot Component SUCCESS [ 21.328 s] [INFO] Apache CloudStack Cloud Engine API SUCCESS [ 5.636 s] [INFO] Apache CloudStack Cloud Engine Service SUCCESS [ 23.990 s] [INFO] Apache CloudStack Plugin POM .. SUCCESS [ 1.642 s] [INFO] Apache CloudStack Plugin - API Rate Limit . SUCCESS [ 19.023 s] [INFO] Apache CloudStack Plugin - Storage Volume default provider SUCCESS [ 6.608 s] [INFO] Apache CloudStack Plugin - Storage Volume SolidFire Provider SUCCESS [ 10.002 s] [INFO] Apache CloudStack Plugin - API SolidFire .. SUCCESS [ 5.005 s] [INFO] Apache CloudStack Plugin - API Discovery .. SUCCESS [ 11.298 s] [INFO] Apache CloudStack Plugin - ACL Static Role Based .. SUCCESS [ 3.553 s] [INFO] Apache CloudStack Plugin - Host Anti-Affinity Processor SUCCESS [ 3.810 s] [INFO] Apache CloudStack Plugin - Explicit Dedication Processor SUCCESS [ 4.761 s] [INFO] Apache CloudStack Plugin - User Concentrated Pod Deployment Planner SUCCESS [29:59 min] [INFO] Apache CloudStack Plugin - User Dispersing Deployment Planner SUCCESS [ 2.585 s] [INFO] Apache CloudStack Plugin - Implicit Dedication Planner SUCCESS [ 8.700 s] [INFO] Apache CloudStack Plugin - Skip Heurestics Planner SUCCESS [ 3.693 s] [INFO] Apache CloudStack Plugin - Host Allocator Random .. SUCCESS [ 4.290 s] [INFO] Apache CloudStack Plugin - Dedicated Resources SUCCESS [ 11.395 s] [INFO] Apache CloudStack Plugin - Hypervisor OracleVM SUCCESS [ 5.675 s] [INFO] Apache CloudStack Plugin - Open vSwitch ... SUCCESS [ 7.772 s] [INFO] Apache CloudStack Plugin - Hypervisor XenServer ... SUCCESS [ 59.741 s] [INFO] Apache CloudStack Plugin - Hypervisor KVM . SUCCESS [ 18.321
[GitHub] cloudstack pull request: Removed unused code from com.cloud.api.Ap...
Github user pdube commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1263#discussion_r59026874
--- Diff: server/src/com/cloud/api/ApiServlet.java ---
@@ -156,7 +158,7 @@ void processRequestInContext(final HttpServletRequest
req, final HttpServletResp
try {
if
(HttpUtils.RESPONSE_TYPE_JSON.equalsIgnoreCase(responseType)) {
-resp.setContentType(ApiServer.getJSONContentType());
+resp.setContentType(_apiServer.getJSONContentType());
--- End diff --
Why leave the underscore here?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Removed unused code from com.cloud.api.Ap...
Github user pdube commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1263#discussion_r59026830
--- Diff: server/src/com/cloud/api/ApiServer.java ---
@@ -1340,37 +1340,31 @@ public String getSerializedApiError(final
ServerApiException ex, final Map getPluggableServices() {
-return _pluggableServices;
-}
-
@Inject
public void setPluggableServices(final List
pluggableServices) {
-_pluggableServices = pluggableServices;
-}
-
-public List getApiAccessCheckers() {
-return _apiAccessCheckers;
+this.pluggableServices = pluggableServices;
}
@Inject
public void setApiAccessCheckers(final List
apiAccessCheckers) {
-_apiAccessCheckers = apiAccessCheckers;
+this.apiAccessCheckers = apiAccessCheckers;
}
public static boolean isEncodeApiResponse() {
-return encodeApiResponse;
+return ApiServer.encodeApiResponse;
}
-private static void setEncodeApiResponse(final boolean
encodeApiResponse) {
+private void setEncodeApiResponse(final boolean encodeApiResponse) {
ApiServer.encodeApiResponse = encodeApiResponse;
--- End diff --
What is this for? It seems like a strange thing to do
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Removed unused code from com.cloud.api.Ap...
Github user pdube commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1263#discussion_r59026583
--- Diff: server/src/com/cloud/api/ApiServer.java ---
@@ -223,10 +226,7 @@
private static ExecutorService s_executor = new ThreadPoolExecutor(10,
150, 60, TimeUnit.SECONDS, new LinkedBlockingQueue(), new
NamedThreadFactory(
"ApiServer"));
@Inject
-MessageBus _messageBus;
-
-public ApiServer() {
-}
+private MessageBus _messageBus;
--- End diff --
Why leave the underscore here?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Remove classes with no references
Github user pdube commented on the pull request: https://github.com/apache/cloudstack/pull/1453#issuecomment-203469470 I built, ran the unit tests and ran the server with the simulator. Thanks for cleaning up! LGTM [INFO] [INFO] Reactor Summary: [INFO] [INFO] Apache CloudStack Developer Tools - Checkstyle Configuration SUCCESS [ 1.481 s] [INFO] Apache CloudStack . SUCCESS [ 2.319 s] [INFO] Apache CloudStack Maven Conventions Parent SUCCESS [ 1.075 s] [INFO] Apache CloudStack Framework - Managed Context . SUCCESS [ 5.519 s] [INFO] Apache CloudStack Utils ... SUCCESS [ 20.629 s] [INFO] Apache CloudStack Framework ... SUCCESS [ 0.035 s] [INFO] Apache CloudStack Framework - Event Notification .. SUCCESS [ 6.274 s] [INFO] Apache CloudStack Framework - Configuration ... SUCCESS [ 3.581 s] [INFO] Apache CloudStack API . SUCCESS [ 17.061 s] [INFO] Apache CloudStack Framework - REST SUCCESS [ 2.250 s] [INFO] Apache CloudStack Framework - IPC . SUCCESS [ 5.209 s] [INFO] Apache CloudStack Cloud Engine SUCCESS [ 0.043 s] [INFO] Apache CloudStack Cloud Engine API SUCCESS [ 4.154 s] [INFO] Apache CloudStack Framework - Security SUCCESS [ 1.968 s] [INFO] Apache CloudStack Core SUCCESS [ 24.328 s] [INFO] Apache CloudStack Agents .. SUCCESS [ 7.392 s] [INFO] Apache CloudStack Framework - Clustering .. SUCCESS [ 4.394 s] [INFO] Apache CloudStack Framework - Event Notification .. SUCCESS [ 1.455 s] [INFO] Apache CloudStack Cloud Engine Schema Component ... SUCCESS [ 14.251 s] [INFO] Apache CloudStack Framework - Jobs SUCCESS [ 4.137 s] [INFO] Apache CloudStack Cloud Engine Internal Components API SUCCESS [ 2.500 s] [INFO] Apache CloudStack Server .. SUCCESS [ 44.828 s] [INFO] Apache CloudStack Framework - Quota ... SUCCESS [ 5.957 s] [INFO] Apache CloudStack Usage Server SUCCESS [ 5.625 s] [INFO] Apache CloudStack Cloud Engine Orchestration Component SUCCESS [ 8.316 s] [INFO] Apache CloudStack Cloud Services .. SUCCESS [ 0.029 s] [INFO] Apache CloudStack Secondary Storage ... SUCCESS [ 0.230 s] [INFO] Apache CloudStack Secondary Storage Service ... SUCCESS [ 4.525 s] [INFO] Apache CloudStack Engine Storage Component SUCCESS [ 5.890 s] [INFO] Apache CloudStack Engine Storage Volume Component . SUCCESS [ 4.042 s] [INFO] Apache CloudStack Engine Storage Image Component .. SUCCESS [ 2.578 s] [INFO] Apache CloudStack Engine Storage Data Motion Component SUCCESS [ 2.076 s] [INFO] Apache CloudStack Engine Storage Cache Component .. SUCCESS [ 1.821 s] [INFO] Apache CloudStack Engine Storage Snapshot Component SUCCESS [ 7.113 s] [INFO] Apache CloudStack Cloud Engine API SUCCESS [ 1.391 s] [INFO] Apache CloudStack Cloud Engine Service SUCCESS [ 4.426 s] [INFO] Apache CloudStack Plugin POM .. SUCCESS [ 0.300 s] [INFO] Apache CloudStack Plugin - API Rate Limit . SUCCESS [ 5.367 s] [INFO] Apache CloudStack Plugin - Storage Volume default provider SUCCESS [ 2.396 s] [INFO] Apache CloudStack Plugin - Storage Volume SolidFire Provider SUCCESS [ 4.066 s] [INFO] Apache CloudStack Plugin - API SolidFire .. SUCCESS [ 1.818 s] [INFO] Apache CloudStack Plugin - API Discovery .. SUCCESS [ 3.680 s] [INFO] Apache CloudStack Plugin - ACL Static Role Based .. SUCCESS [ 1.571 s] [INFO] Apache CloudStack Plugin - Host Anti-Affinity Processor SUCCESS [ 1.612 s] [INFO] Apache CloudStack Plugin - Explicit Dedication Processor SUCCESS [ 1.848 s] [INFO] Apache CloudStack Plugin - User Concentrated Pod Deployment Planner SUCCESS [ 1.717 s] [INFO] Apache CloudStack Plugin - User Dispersing Deployment Planner SUCCESS [ 1.660 s] [INFO] Apache CloudStack Plugin - Implicit Dedication Planner SUCCESS [ 5.252 s] [INFO] Apache CloudStack Plugin - Skip Heurestics Planner SUCCESS [ 1.438 s] [INFO] Apache CloudStack Plugin - Host Allocator Random .. SUCCESS [ 1.754 s] [INFO] Apache CloudStack Plugin - Dedicated Resources SUCCESS [ 4.998 s] [INFO] Apache CloudStack Plugin - Hypervisor OracleVM SUCCESS [ 2.442 s] [INFO] Apache CloudStack Plugin - Open vSwitch ... SUCCESS [ 2.689 s] [INFO] Apache CloudStack Plugin - Hypervisor XenServer ... SUCCESS [ 22.957 s] [INFO] Apache
[GitHub] cloudstack pull request: writeIfNotHere requires an array of strin...
Github user pdube commented on the pull request: https://github.com/apache/cloudstack/pull/1456#issuecomment-203437320 Hi @hogniRunar, The code change LGTM. I verified for references to the function, but did not test it. Could you create a JIRA ticket for it please? Could you also add some information as to how do you reproduce the error, and how to test the fix? Thanks --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: Removed unused code from com.cloud.api.Ap...
Github user pdube commented on the pull request: https://github.com/apache/cloudstack/pull/1263#issuecomment-203434250 Hi @GabrielBrascher Travis noted: Failed during checkstyle execution: There are 1 checkstyle errors. Have you run *mvn validate* on your code? Thanks, --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: Fixed Profiler's unit tests bugs.
Github user pdube commented on the pull request: https://github.com/apache/cloudstack/pull/1445#issuecomment-199858341 Built and ran the unit tests. LGTM [INFO] Apache CloudStack Developer Tools - Checkstyle Configuration SUCCESS [ 1.106 s] [INFO] Apache CloudStack . SUCCESS [ 0.975 s] [INFO] Apache CloudStack Maven Conventions Parent SUCCESS [ 1.918 s] [INFO] Apache CloudStack Framework - Managed Context . SUCCESS [ 1.485 s] [INFO] Apache CloudStack Utils ... SUCCESS [ 11.555 s] [INFO] Apache CloudStack Framework ... SUCCESS [ 0.047 s] [INFO] Apache CloudStack Framework - Event Notification .. SUCCESS [ 1.561 s] [INFO] Apache CloudStack Framework - Configuration ... SUCCESS [ 1.210 s] [INFO] Apache CloudStack API . SUCCESS [ 12.870 s] [INFO] Apache CloudStack Framework - REST SUCCESS [ 0.644 s] [INFO] Apache CloudStack Framework - IPC . SUCCESS [ 0.640 s] [INFO] Apache CloudStack Cloud Engine SUCCESS [ 0.030 s] [INFO] Apache CloudStack Cloud Engine API SUCCESS [ 3.529 s] [INFO] Apache CloudStack Framework - Security SUCCESS [ 0.499 s] [INFO] Apache CloudStack Core SUCCESS [ 4.886 s] [INFO] Apache CloudStack Agents .. SUCCESS [ 1.546 s] [INFO] Apache CloudStack Framework - Clustering .. SUCCESS [ 1.026 s] [INFO] Apache CloudStack Framework - Event Notification .. SUCCESS [ 0.332 s] [INFO] Apache CloudStack Cloud Engine Schema Component ... SUCCESS [ 10.903 s] [INFO] Apache CloudStack Framework - Jobs SUCCESS [ 2.049 s] [INFO] Apache CloudStack Cloud Engine Internal Components API SUCCESS [ 0.551 s] [INFO] Apache CloudStack Server .. SUCCESS [ 25.862 s] [INFO] Apache CloudStack Framework - Quota ... SUCCESS [ 1.987 s] [INFO] Apache CloudStack Usage Server SUCCESS [ 1.694 s] [INFO] Apache CloudStack Cloud Engine Orchestration Component SUCCESS [ 0.648 s] [INFO] Apache CloudStack Cloud Services .. SUCCESS [ 0.016 s] [INFO] Apache CloudStack Secondary Storage ... SUCCESS [ 0.125 s] [INFO] Apache CloudStack Secondary Storage Service ... SUCCESS [ 0.678 s] [INFO] Apache CloudStack Engine Storage Component SUCCESS [ 5.129 s] [INFO] Apache CloudStack Engine Storage Volume Component . SUCCESS [ 0.588 s] [INFO] Apache CloudStack Engine Storage Image Component .. SUCCESS [ 0.472 s] [INFO] Apache CloudStack Engine Storage Data Motion Component SUCCESS [ 0.592 s] [INFO] Apache CloudStack Engine Storage Cache Component .. SUCCESS [ 0.545 s] [INFO] Apache CloudStack Engine Storage Snapshot Component SUCCESS [ 3.074 s] [INFO] Apache CloudStack Cloud Engine API SUCCESS [ 0.567 s] [INFO] Apache CloudStack Cloud Engine Service SUCCESS [ 0.596 s] [INFO] Apache CloudStack Plugin POM .. SUCCESS [ 0.266 s] [INFO] Apache CloudStack Plugin - API Rate Limit . SUCCESS [ 3.276 s] [INFO] Apache CloudStack Plugin - Storage Volume default provider SUCCESS [ 0.485 s] [INFO] Apache CloudStack Plugin - Storage Volume SolidFire Provider SUCCESS [ 0.574 s] [INFO] Apache CloudStack Plugin - API SolidFire .. SUCCESS [ 0.483 s] [INFO] Apache CloudStack Plugin - API Discovery .. SUCCESS [ 1.377 s] [INFO] Apache CloudStack Plugin - ACL Static Role Based .. SUCCESS [ 0.497 s] [INFO] Apache CloudStack Plugin - Host Anti-Affinity Processor SUCCESS [ 0.428 s] [INFO] Apache CloudStack Plugin - Explicit Dedication Processor SUCCESS [ 0.404 s] [INFO] Apache CloudStack Plugin - User Concentrated Pod Deployment Planner SUCCESS [ 0.429 s] [INFO] Apache CloudStack Plugin - User Dispersing Deployment Planner SUCCESS [ 0.424 s] [INFO] Apache CloudStack Plugin - Implicit Dedication Planner SUCCESS [ 2.820 s] [INFO] Apache CloudStack Plugin - Skip Heurestics Planner SUCCESS [ 0.635 s] [INFO] Apache CloudStack Plugin - Host Allocator Random .. SUCCESS [ 0.483 s] [INFO] Apache CloudStack Plugin - Dedicated Resources SUCCESS [ 2.748 s] [INFO] Apache CloudStack Plugin - Hypervisor OracleVM SUCCESS [ 0.560 s] [INFO] Apache CloudStack Plugin - Open vSwitch ... SUCCESS [ 0.566 s] [INFO] Apache CloudStack Plugin - Hypervisor XenServer ... SUCCESS [ 21.803 s] [INFO] Apache CloudStack Plugin - Hypervisor KVM . SUCCESS [ 3.487 s] [INFO] Apache CloudStack Plugin - RabbitMQ Event Bus . SUCCESS [ 0.526 s] [INFO] Apache CloudStack Plugin
[GitHub] cloudstack pull request: Fix Sync of template.properties in Swift
Github user pdube commented on the pull request: https://github.com/apache/cloudstack/pull/1331#issuecomment-179502626 Tested on local setup, the template.properties is now uploaded correctly LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: Add ability to download templates in Swif...
Github user pdube commented on the pull request: https://github.com/apache/cloudstack/pull/1332#issuecomment-176825081 LGTM Tested with a XenServer host and Swift as secondary storage. Got the link and downloaded the template https://cloud.githubusercontent.com/assets/2355044/12679915/ea6b1a40-c674-11e5-9a95-617ece9e1c33.png;> --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: Set version to 4.9.0-SNAPSHOT in master b...
Github user pdube commented on the pull request: https://github.com/apache/cloudstack/pull/1369#issuecomment-175058378 Versions LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-9251: Fix issue in scale VM to...
Github user pdube commented on the pull request: https://github.com/apache/cloudstack/pull/1363#issuecomment-175089677 Code LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: Enhance VR performance
Github user pdube commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1346#discussion_r50259649
--- Diff: systemvm/patches/debian/config/opt/cloud/bin/cs/CsDhcp.py ---
@@ -96,29 +96,8 @@ def configure_server(self):
self.conf.search(sline, line)
def delete_leases(self):
-changed = []
-leases = []
try:
-for line in open(LEASES):
-bits = line.strip().split(' ')
-to = {"device": bits[0],
- "mac": bits[1],
- "ip": bits[2],
- "host": bits[3:],
- "del": False
- }
-changed.append(to)
-
-for v in changed:
-if v['mac'] == to['mac'] or v['ip'] == to['ip'] or
v['host'] == to['host']:
-to['del'] = True
-leases.append(to)
-
-for o in leases:
-if o['del']:
-cmd = "dhcp_release eth%s %s %s" % (o['device'],
o['ip'], o['mac'])
-logging.info(cmd)
-CsHelper.execute(cmd)
+open(LEASES, 'w').close()
--- End diff --
That clears that up then!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Enhance VR performance
Github user pdube commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1346#discussion_r50259430
--- Diff: systemvm/patches/debian/config/opt/cloud/bin/configure.py ---
@@ -901,79 +901,123 @@ def processStaticNatRule(self, rule):
def main(argv):
+# The file we are currently processing, if it is "cmd_line.json"
everything will be processed.
+process_file = argv[1]
+
+# process_file can be None, if so assume cmd_line.json
+if process_file is None:
+process_file = "cmd_line.json"
+
+# Track if changes need to be committed to NetFilter
+iptables_change = False
+
+# The "GLOBAL" Configuration object
config = CsConfig()
+
logging.basicConfig(filename=config.get_logger(),
level=config.get_level(),
format=config.get_format())
+
+# Load stored ip adresses from disk to CsConfig()
config.set_address()
logging.debug("Configuring ip addresses")
-# IP configuration
config.address().compare()
config.address().process()
-logging.debug("Configuring vmpassword")
-password = CsPassword("vmpassword", config)
-password.process()
+if process_file in ["cmd_line.json", "guest_network.json"]:
+logging.debug("Configuring Guest Network")
+iptables_change = True
+
+if process_file in ["cmd_line.json", "vm_password.json"]:
+logging.debug("Configuring vmpassword")
+password = CsPassword("vmpassword", config)
+password.process()
-logging.debug("Configuring vmdata")
-metadata = CsVmMetadata('vmdata', config)
-metadata.process()
+if process_file in ["cmd_line.json", "vm_metadata.json"]:
+logging.debug("Configuring vmdata")
+metadata = CsVmMetadata('vmdata', config)
+metadata.process()
-logging.debug("Configuring networkacl")
+# Always run both CsAcl().process() methods
+# They fill the base rules in config.fw[]
acls = CsAcl('networkacl', config)
acls.process()
-logging.debug("Configuring firewall rules")
acls = CsAcl('firewallrules', config)
acls.process()
-logging.debug("Configuring PF rules")
fwd = CsForwardingRules("forwardingrules", config)
fwd.process()
-logging.debug("Configuring s2s vpn")
vpns = CsSite2SiteVpn("site2sitevpn", config)
vpns.process()
-logging.debug("Configuring remote access vpn")
-#remote access vpn
rvpn = CsRemoteAccessVpn("remoteaccessvpn", config)
rvpn.process()
-logging.debug("Configuring vpn users list")
-#remote access vpn users
-vpnuser = CsVpnUser("vpnuserlist", config)
-vpnuser.process()
-
-logging.debug("Configuring dhcp entry")
-dhcp = CsDhcp("dhcpentry", config)
-dhcp.process()
-
-logging.debug("Configuring load balancer")
lb = CsLoadBalancer("loadbalancer", config)
lb.process()
-logging.debug("Configuring monitor service")
-mon = CsMonitor("monitorservice", config)
-mon.process()
+if process_file in ["cmd_line.json", "network_acl.json"]:
+logging.debug("Configuring networkacl")
+iptables_change = True
+
+if process_file in ["cmd_line.json", "firewall_rules.json"]:
+logging.debug("Configuring firewall rules")
+iptables_change = True
+
+if process_file in ["cmd_line.json", "forwarding_rules.json",
"staticnat_rules.json"]:
+logging.debug("Configuring PF rules")
+iptables_change = True
+
+if process_file in ["cmd_line.json", "site_2_site_vpn.json"]:
+logging.debug("Configuring s2s vpn")
+iptables_change = True
--- End diff --
Here, it is misleading. The vpns.process has already been executed, then a
log appears (configur*ing*)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Enhance VR performance
Github user pdube commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1346#discussion_r50259089
--- Diff: systemvm/patches/debian/config/opt/cloud/bin/configure.py ---
@@ -901,79 +901,123 @@ def processStaticNatRule(self, rule):
def main(argv):
+# The file we are currently processing, if it is "cmd_line.json"
everything will be processed.
+process_file = argv[1]
+
+# process_file can be None, if so assume cmd_line.json
+if process_file is None:
+process_file = "cmd_line.json"
+
+# Track if changes need to be committed to NetFilter
+iptables_change = False
+
+# The "GLOBAL" Configuration object
config = CsConfig()
+
logging.basicConfig(filename=config.get_logger(),
level=config.get_level(),
format=config.get_format())
+
+# Load stored ip adresses from disk to CsConfig()
config.set_address()
logging.debug("Configuring ip addresses")
-# IP configuration
config.address().compare()
config.address().process()
-logging.debug("Configuring vmpassword")
-password = CsPassword("vmpassword", config)
-password.process()
+if process_file in ["cmd_line.json", "guest_network.json"]:
+logging.debug("Configuring Guest Network")
+iptables_change = True
+
+if process_file in ["cmd_line.json", "vm_password.json"]:
+logging.debug("Configuring vmpassword")
+password = CsPassword("vmpassword", config)
+password.process()
-logging.debug("Configuring vmdata")
-metadata = CsVmMetadata('vmdata', config)
-metadata.process()
+if process_file in ["cmd_line.json", "vm_metadata.json"]:
+logging.debug("Configuring vmdata")
+metadata = CsVmMetadata('vmdata', config)
+metadata.process()
-logging.debug("Configuring networkacl")
+# Always run both CsAcl().process() methods
+# They fill the base rules in config.fw[]
acls = CsAcl('networkacl', config)
acls.process()
-logging.debug("Configuring firewall rules")
acls = CsAcl('firewallrules', config)
acls.process()
-logging.debug("Configuring PF rules")
fwd = CsForwardingRules("forwardingrules", config)
fwd.process()
-logging.debug("Configuring s2s vpn")
vpns = CsSite2SiteVpn("site2sitevpn", config)
vpns.process()
-logging.debug("Configuring remote access vpn")
-#remote access vpn
rvpn = CsRemoteAccessVpn("remoteaccessvpn", config)
rvpn.process()
-logging.debug("Configuring vpn users list")
-#remote access vpn users
-vpnuser = CsVpnUser("vpnuserlist", config)
-vpnuser.process()
-
-logging.debug("Configuring dhcp entry")
-dhcp = CsDhcp("dhcpentry", config)
-dhcp.process()
-
-logging.debug("Configuring load balancer")
lb = CsLoadBalancer("loadbalancer", config)
lb.process()
-logging.debug("Configuring monitor service")
-mon = CsMonitor("monitorservice", config)
-mon.process()
+if process_file in ["cmd_line.json", "network_acl.json"]:
+logging.debug("Configuring networkacl")
+iptables_change = True
+
+if process_file in ["cmd_line.json", "firewall_rules.json"]:
+logging.debug("Configuring firewall rules")
+iptables_change = True
+
+if process_file in ["cmd_line.json", "forwarding_rules.json",
"staticnat_rules.json"]:
+logging.debug("Configuring PF rules")
--- End diff --
Hey @wilderrodrigues,
I understand the checks that are being made. However, I do not think it is
appropriate to log that you are configuring PFR, after they have already been
processed and configured. I think it can be misleading while
debugging/searching logs.
There are certain code paths that are executed regardless of the config
file and they are only logged after the fact -> acls, fwd, vpns, rvpn, lb. So,
if an error occurs in any of the functions, there are no logs to see what was
being executed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Enhance VR performance
Github user pdube commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1346#discussion_r50259249
--- Diff: systemvm/patches/debian/config/opt/cloud/bin/configure.py ---
@@ -901,79 +901,123 @@ def processStaticNatRule(self, rule):
def main(argv):
+# The file we are currently processing, if it is "cmd_line.json"
everything will be processed.
+process_file = argv[1]
+
+# process_file can be None, if so assume cmd_line.json
+if process_file is None:
+process_file = "cmd_line.json"
+
+# Track if changes need to be committed to NetFilter
+iptables_change = False
+
+# The "GLOBAL" Configuration object
config = CsConfig()
+
logging.basicConfig(filename=config.get_logger(),
level=config.get_level(),
format=config.get_format())
+
+# Load stored ip adresses from disk to CsConfig()
config.set_address()
logging.debug("Configuring ip addresses")
-# IP configuration
config.address().compare()
config.address().process()
-logging.debug("Configuring vmpassword")
-password = CsPassword("vmpassword", config)
-password.process()
+if process_file in ["cmd_line.json", "guest_network.json"]:
+logging.debug("Configuring Guest Network")
+iptables_change = True
+
+if process_file in ["cmd_line.json", "vm_password.json"]:
+logging.debug("Configuring vmpassword")
+password = CsPassword("vmpassword", config)
+password.process()
-logging.debug("Configuring vmdata")
-metadata = CsVmMetadata('vmdata', config)
-metadata.process()
+if process_file in ["cmd_line.json", "vm_metadata.json"]:
+logging.debug("Configuring vmdata")
+metadata = CsVmMetadata('vmdata', config)
+metadata.process()
-logging.debug("Configuring networkacl")
+# Always run both CsAcl().process() methods
+# They fill the base rules in config.fw[]
acls = CsAcl('networkacl', config)
acls.process()
-logging.debug("Configuring firewall rules")
acls = CsAcl('firewallrules', config)
acls.process()
-logging.debug("Configuring PF rules")
fwd = CsForwardingRules("forwardingrules", config)
fwd.process()
-logging.debug("Configuring s2s vpn")
vpns = CsSite2SiteVpn("site2sitevpn", config)
vpns.process()
-logging.debug("Configuring remote access vpn")
-#remote access vpn
rvpn = CsRemoteAccessVpn("remoteaccessvpn", config)
rvpn.process()
-logging.debug("Configuring vpn users list")
-#remote access vpn users
-vpnuser = CsVpnUser("vpnuserlist", config)
-vpnuser.process()
-
-logging.debug("Configuring dhcp entry")
-dhcp = CsDhcp("dhcpentry", config)
-dhcp.process()
-
-logging.debug("Configuring load balancer")
lb = CsLoadBalancer("loadbalancer", config)
lb.process()
-logging.debug("Configuring monitor service")
-mon = CsMonitor("monitorservice", config)
-mon.process()
+if process_file in ["cmd_line.json", "network_acl.json"]:
+logging.debug("Configuring networkacl")
+iptables_change = True
+
+if process_file in ["cmd_line.json", "firewall_rules.json"]:
+logging.debug("Configuring firewall rules")
+iptables_change = True
+
+if process_file in ["cmd_line.json", "forwarding_rules.json",
"staticnat_rules.json"]:
+logging.debug("Configuring PF rules")
+iptables_change = True
+
+if process_file in ["cmd_line.json", "site_2_site_vpn.json"]:
+logging.debug("Configuring s2s vpn")
+iptables_change = True
+
+if process_file in ["cmd_line.json", "remote_access_vpn.json"]:
+logging.debug("Configuring remote access vpn")
+iptables_change = True
+
+if process_file in ["cmd_line.json", "vpn_user_list.json"]:
+logging.debug("Configuring vpn users list")
+vpnuser = CsVpnUser("vpnuserlist", config)
+vpnuser.process()
--- End diff --
Here, it is done as expected. The config file is checked, then it is
logged, then the vpnuser.process gets executed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-9235: Autoscale button is miss...
Github user pdube commented on the pull request: https://github.com/apache/cloudstack/pull/1337#issuecomment-172691481 Code LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: Fix Sync of template.properties in Swift
Github user pdube commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1331#discussion_r50066929
--- Diff:
services/secondary-storage/server/src/org/apache/cloudstack/storage/resource/NfsSecondaryStorageResource.java
---
@@ -942,6 +931,83 @@ protected Answer copyFromNfsToS3(CopyCommand cmd) {
}
}
+protected boolean swiftUploadMetadataFile(SwiftTO swift, File srcFile,
String containerName) throws IOException {
+
+
+//create a template.properties for Swift with its correct unique
name
+File uniqDir = _storage.createUniqDir();
+String metaFileName = uniqDir.getAbsolutePath() + File.separator +
"template.properties";
+_storage.create(uniqDir.getAbsolutePath(), "template.properties");
+
+String uniqueName = FilenameUtils.getBaseName(srcFile.getName());
+File metaFile = new File(metaFileName);
+FileWriter writer = new FileWriter(metaFile);
+BufferedWriter bufferWriter = new BufferedWriter(writer);
+bufferWriter.write("uniquename=" + uniqueName);
+bufferWriter.write("\n");
+bufferWriter.write("filename=" + srcFile.getName());
+bufferWriter.write("\n");
+bufferWriter.write("size=" + srcFile.length());
+bufferWriter.write("\n");
+bufferWriter.write("virtualsize=" + getVirtualSize(srcFile,
getTemplateFormat(srcFile.getName(;
+bufferWriter.close();
+writer.close();
+
+SwiftUtil.putObject(swift, metaFile, containerName, _tmpltpp);
+metaFile.delete();
+uniqDir.delete();
+
+return true;
+}
+
+
+protected Answer copyFromNfsToSwift(CopyCommand cmd) {
+
+final DataTO srcData = cmd.getSrcTO();
+final DataTO destData = cmd.getDestTO();
+
+DataStoreTO srcDataStore = srcData.getDataStore();
+NfsTO srcStore = (NfsTO)srcDataStore;
+DataStoreTO destDataStore = destData.getDataStore();
+File srcFile = getFile(srcData.getPath(), srcStore.getUrl());
+
+SwiftTO swift = (SwiftTO)destDataStore;
+
+try {
+
+String containerName =
SwiftUtil.getContainerName(destData.getObjectType().toString(),
destData.getId());
+String swiftPath = SwiftUtil.putObject(swift, srcFile,
containerName, srcFile.getName());
+
+
+DataTO retObj = null;
+if (destData.getObjectType() == DataObjectType.TEMPLATE) {
+swiftUploadMetadataFile(swift, srcFile, containerName);
+TemplateObjectTO newTemplate = new TemplateObjectTO();
+newTemplate.setPath(swiftPath);
+newTemplate.setSize(getVirtualSize(srcFile,
getTemplateFormat(srcFile.getName(;
+newTemplate.setPhysicalSize(srcFile.length());
+
newTemplate.setFormat(getTemplateFormat(srcFile.getName()));
+retObj = newTemplate;
+} else if (destData.getObjectType() == DataObjectType.VOLUME) {
+VolumeObjectTO newVol = new VolumeObjectTO();
+newVol.setPath(containerName);
+newVol.setSize(srcFile.length());
--- End diff --
Not 100% related to this PR, but are the sizes on volumes and snapshots
correct?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Enhance VR performance
Github user pdube commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1346#discussion_r50057840
--- Diff: systemvm/patches/debian/config/opt/cloud/bin/configure.py ---
@@ -901,79 +901,123 @@ def processStaticNatRule(self, rule):
def main(argv):
+# The file we are currently processing, if it is "cmd_line.json"
everything will be processed.
+process_file = argv[1]
+
+# process_file can be None, if so assume cmd_line.json
+if process_file is None:
+process_file = "cmd_line.json"
+
+# Track if changes need to be committed to NetFilter
+iptables_change = False
+
+# The "GLOBAL" Configuration object
config = CsConfig()
+
logging.basicConfig(filename=config.get_logger(),
level=config.get_level(),
format=config.get_format())
+
+# Load stored ip adresses from disk to CsConfig()
config.set_address()
logging.debug("Configuring ip addresses")
-# IP configuration
config.address().compare()
config.address().process()
-logging.debug("Configuring vmpassword")
-password = CsPassword("vmpassword", config)
-password.process()
+if process_file in ["cmd_line.json", "guest_network.json"]:
+logging.debug("Configuring Guest Network")
+iptables_change = True
+
+if process_file in ["cmd_line.json", "vm_password.json"]:
+logging.debug("Configuring vmpassword")
+password = CsPassword("vmpassword", config)
+password.process()
-logging.debug("Configuring vmdata")
-metadata = CsVmMetadata('vmdata', config)
-metadata.process()
+if process_file in ["cmd_line.json", "vm_metadata.json"]:
+logging.debug("Configuring vmdata")
+metadata = CsVmMetadata('vmdata', config)
+metadata.process()
-logging.debug("Configuring networkacl")
+# Always run both CsAcl().process() methods
+# They fill the base rules in config.fw[]
acls = CsAcl('networkacl', config)
acls.process()
-logging.debug("Configuring firewall rules")
acls = CsAcl('firewallrules', config)
acls.process()
-logging.debug("Configuring PF rules")
fwd = CsForwardingRules("forwardingrules", config)
fwd.process()
-logging.debug("Configuring s2s vpn")
vpns = CsSite2SiteVpn("site2sitevpn", config)
vpns.process()
-logging.debug("Configuring remote access vpn")
-#remote access vpn
rvpn = CsRemoteAccessVpn("remoteaccessvpn", config)
rvpn.process()
-logging.debug("Configuring vpn users list")
-#remote access vpn users
-vpnuser = CsVpnUser("vpnuserlist", config)
-vpnuser.process()
-
-logging.debug("Configuring dhcp entry")
-dhcp = CsDhcp("dhcpentry", config)
-dhcp.process()
-
-logging.debug("Configuring load balancer")
lb = CsLoadBalancer("loadbalancer", config)
lb.process()
-logging.debug("Configuring monitor service")
-mon = CsMonitor("monitorservice", config)
-mon.process()
+if process_file in ["cmd_line.json", "network_acl.json"]:
+logging.debug("Configuring networkacl")
+iptables_change = True
+
+if process_file in ["cmd_line.json", "firewall_rules.json"]:
+logging.debug("Configuring firewall rules")
+iptables_change = True
+
+if process_file in ["cmd_line.json", "forwarding_rules.json",
"staticnat_rules.json"]:
+logging.debug("Configuring PF rules")
--- End diff --
These were configured above right?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Enhance VR performance
Github user pdube commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1346#discussion_r50058474
--- Diff: systemvm/patches/debian/config/opt/cloud/bin/cs/CsDhcp.py ---
@@ -96,29 +96,8 @@ def configure_server(self):
self.conf.search(sline, line)
def delete_leases(self):
-changed = []
-leases = []
try:
-for line in open(LEASES):
-bits = line.strip().split(' ')
-to = {"device": bits[0],
- "mac": bits[1],
- "ip": bits[2],
- "host": bits[3:],
- "del": False
- }
-changed.append(to)
-
-for v in changed:
-if v['mac'] == to['mac'] or v['ip'] == to['ip'] or
v['host'] == to['host']:
-to['del'] = True
-leases.append(to)
-
-for o in leases:
-if o['del']:
-cmd = "dhcp_release eth%s %s %s" % (o['device'],
o['ip'], o['mac'])
-logging.info(cmd)
-CsHelper.execute(cmd)
+open(LEASES, 'w').close()
--- End diff --
This truncates the file, but what about the cmd that was executed before?
Is that handled elsewhere?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-6181: Add 'root disk size' fie...
Github user pdube commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1342#discussion_r50058625
--- Diff: ui/scripts/ui-custom/instanceWizard.js ---
@@ -429,12 +427,52 @@
$step.find('.custom-size-label').remove();
if (!custom) {
--- End diff --
Should become if(custom){//logic} to avoid empty condition
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-9235: Autoscale button is miss...
Github user pdube commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1337#discussion_r50060205
--- Diff: ui/scripts/network.js ---
@@ -3667,8 +3652,16 @@
return 2;
//hide Autoscale button (both header and form)
}
} else { //from VPC
section
-//VPC doesn't
support autoscale
-return 2;
+var
lbProviderIsNetscaler;
+var services =
args.context.vpc[0].service;
+
+
lbProviderIsNetscaler = checkIfNetScalerProviderIsEnabled(services);
+
+if
(lbProviderIsNetscaler == true) { //AutoScale is only supported on Netscaler
(but not on any other provider like VirtualRouter)
--- End diff --
You could remove the condition here, it is unnecessary
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Enhance VR performance
Github user pdube commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1346#discussion_r50057844
--- Diff: systemvm/patches/debian/config/opt/cloud/bin/configure.py ---
@@ -901,79 +901,123 @@ def processStaticNatRule(self, rule):
def main(argv):
+# The file we are currently processing, if it is "cmd_line.json"
everything will be processed.
+process_file = argv[1]
+
+# process_file can be None, if so assume cmd_line.json
+if process_file is None:
+process_file = "cmd_line.json"
+
+# Track if changes need to be committed to NetFilter
+iptables_change = False
+
+# The "GLOBAL" Configuration object
config = CsConfig()
+
logging.basicConfig(filename=config.get_logger(),
level=config.get_level(),
format=config.get_format())
+
+# Load stored ip adresses from disk to CsConfig()
config.set_address()
logging.debug("Configuring ip addresses")
-# IP configuration
config.address().compare()
config.address().process()
-logging.debug("Configuring vmpassword")
-password = CsPassword("vmpassword", config)
-password.process()
+if process_file in ["cmd_line.json", "guest_network.json"]:
+logging.debug("Configuring Guest Network")
+iptables_change = True
+
+if process_file in ["cmd_line.json", "vm_password.json"]:
+logging.debug("Configuring vmpassword")
+password = CsPassword("vmpassword", config)
+password.process()
-logging.debug("Configuring vmdata")
-metadata = CsVmMetadata('vmdata', config)
-metadata.process()
+if process_file in ["cmd_line.json", "vm_metadata.json"]:
+logging.debug("Configuring vmdata")
+metadata = CsVmMetadata('vmdata', config)
+metadata.process()
-logging.debug("Configuring networkacl")
+# Always run both CsAcl().process() methods
+# They fill the base rules in config.fw[]
acls = CsAcl('networkacl', config)
acls.process()
-logging.debug("Configuring firewall rules")
acls = CsAcl('firewallrules', config)
acls.process()
-logging.debug("Configuring PF rules")
--- End diff --
Why remove the logging here? Or, why not bring the lower code block here to
condtionally process the fwd rules?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Reducing expunge delay and interval on de...
Github user pdube closed the pull request at: https://github.com/apache/cloudstack/pull/1135 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: Reducing expunge delay and interval on de...
Github user pdube commented on the pull request: https://github.com/apache/cloudstack/pull/1135#issuecomment-172710149 @DaanHoogland np, I will close the PR --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: Fix Sync of template.properties in Swift
Github user pdube commented on the pull request: https://github.com/apache/cloudstack/pull/1331#issuecomment-172715155 Code LGTM, as a general comment though, I think it is cleaner to be as precise as possible with exception handling. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-9192: UpdateVpnCustomerGateway...
Github user pdube commented on the pull request: https://github.com/apache/cloudstack/pull/1300#issuecomment-171666469 Code changes LGTM, looked in the UpdateVpnGatewayCmd and checked the response name (it is 'updatevpngatewayresponse'). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: Add ability to download templates in Swif...
Github user pdube commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1332#discussion_r49606475
--- Diff:
plugins/storage/image/swift/src/org/apache/cloudstack/storage/datastore/driver/SwiftImageStoreDriverImpl.java
---
@@ -67,7 +73,28 @@ public DataStoreTO getStoreTO(DataStore store) {
@Override
public String createEntityExtractUrl(DataStore store, String
installPath, ImageFormat format, DataObject dataObject) {
-throw new UnsupportedServiceException("Extract entity url is not
yet supported for Swift image store provider");
+
+SwiftTO swiftTO = (SwiftTO)store.getTO();
+String tempKey = UUID.randomUUID().toString();
+boolean result = SwiftUtil.setTempKey(swiftTO, tempKey);
+
+if (!result) {
+s_logger.error("Unable to set Temp-Key: " + tempKey);
+return "";
+}
+
+String containerName =
SwiftUtil.getContainerName(dataObject.getType().toString(), dataObject.getId());
+String objectName = installPath.split("\\/")[1];
+// Get extract url expiration interval set in global configuration
(in seconds)
+int urlExpirationInterval =
Integer.parseInt(_configDao.getValue(Config.ExtractURLExpirationInterval.toString()));
+
+URL swiftUrl = SwiftUtil.generateTempUrl(swiftTO, containerName,
objectName, tempKey, urlExpirationInterval);
+if (swiftUrl != null) {
+s_logger.info("Swift temp-url: " + swiftUrl.toString());
--- End diff --
Should probably be DEBUG instead of INFO, or remove this the log statement
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Add ability to download templates in Swif...
Github user pdube commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1332#discussion_r49606982
--- Diff: utils/src/main/java/com/cloud/utils/SwiftUtil.java ---
@@ -236,4 +247,60 @@ public static boolean deleteObject(SwiftClientCfg cfg,
String path) {
command.execute(parser);
return true;
}
+
+public static boolean setTempKey(SwiftClientCfg cfg, String tempKey){
+
+Map<String, String> tempKeyMap = new HashMap<>();
+tempKeyMap.put("Temp-URL-Key", tempKey);
+return postMeta(cfg, "", "", tempKeyMap);
+
+}
+
+public static URL generateTempUrl(SwiftClientCfg cfg, String
container, String object, String tempKey, int urlExpirationInterval) {
+
+int currentTime = (int) (System.currentTimeMillis() / 1000L);
+int expirationSeconds = currentTime + urlExpirationInterval;
+
+try {
+
+URL endpoint = new URL(cfg.getEndPoint());
+String method = "GET";
+String path = String.format("/v1/AUTH_%s/%s/%s",
cfg.getAccount(), container, object);
+
+//sign the request
+String hmacBody = String.format("%s\n%d\n%s", method,
expirationSeconds, path);
+String signature = calculateRFC2104HMAC(hmacBody, tempKey);
+path += String.format("?temp_url_sig=%s_url_expires=%d",
signature, expirationSeconds);
+
+//generate the temp url
+URL tempUrl = new URL(endpoint.getProtocol(),
endpoint.getHost(), endpoint.getPort(), path);
+
+return tempUrl;
+
+} catch (Exception e) {
+logger.error("Unable to generate temperoary URL " +
e.getMessage());
--- End diff --
Should log the exception, not just the message. And why catch all
exceptions? What exceptions are you expecting?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Add ability to download templates in Swif...
Github user pdube commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1332#discussion_r49606572
--- Diff:
plugins/storage/image/swift/src/org/apache/cloudstack/storage/datastore/driver/SwiftImageStoreDriverImpl.java
---
@@ -67,7 +73,28 @@ public DataStoreTO getStoreTO(DataStore store) {
@Override
public String createEntityExtractUrl(DataStore store, String
installPath, ImageFormat format, DataObject dataObject) {
-throw new UnsupportedServiceException("Extract entity url is not
yet supported for Swift image store provider");
+
+SwiftTO swiftTO = (SwiftTO)store.getTO();
+String tempKey = UUID.randomUUID().toString();
+boolean result = SwiftUtil.setTempKey(swiftTO, tempKey);
+
+if (!result) {
+s_logger.error("Unable to set Temp-Key: " + tempKey);
+return "";
+}
+
+String containerName =
SwiftUtil.getContainerName(dataObject.getType().toString(), dataObject.getId());
+String objectName = installPath.split("\\/")[1];
+// Get extract url expiration interval set in global configuration
(in seconds)
+int urlExpirationInterval =
Integer.parseInt(_configDao.getValue(Config.ExtractURLExpirationInterval.toString()));
+
+URL swiftUrl = SwiftUtil.generateTempUrl(swiftTO, containerName,
objectName, tempKey, urlExpirationInterval);
+if (swiftUrl != null) {
+s_logger.info("Swift temp-url: " + swiftUrl.toString());
+return swiftUrl.toString();
+}
+
--- End diff --
Could instead add a log statement here that indicates that the extraction
url could not be created for the container and object
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Add ability to download templates in Swif...
Github user pdube commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1332#discussion_r49605888
--- Diff:
plugins/storage/image/swift/src/org/apache/cloudstack/storage/datastore/driver/SwiftImageStoreDriverImpl.java
---
@@ -67,7 +73,28 @@ public DataStoreTO getStoreTO(DataStore store) {
@Override
public String createEntityExtractUrl(DataStore store, String
installPath, ImageFormat format, DataObject dataObject) {
-throw new UnsupportedServiceException("Extract entity url is not
yet supported for Swift image store provider");
+
+SwiftTO swiftTO = (SwiftTO)store.getTO();
+String tempKey = UUID.randomUUID().toString();
+boolean result = SwiftUtil.setTempKey(swiftTO, tempKey);
+
+if (!result) {
+s_logger.error("Unable to set Temp-Key: " + tempKey);
+return "";
--- End diff --
Why return empty here, and null later?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-9196: Fixing null pointer exce...
Github user pdube commented on the pull request: https://github.com/apache/cloudstack/pull/1274#issuecomment-167135604 Null check LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: README: happy holidays!
Github user pdube commented on the pull request: https://github.com/apache/cloudstack/pull/1281#issuecomment-166911537 lol @DaanHoogland . +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-9196: Fixing null pointer exce...
Github user pdube commented on the pull request: https://github.com/apache/cloudstack/pull/1274#issuecomment-166910961 Shouldn't we log this information? Doesn't this mean that some resources could be freed up on the hypervisor? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-9200: Fixed failed to delete s...
Github user pdube commented on the pull request: https://github.com/apache/cloudstack/pull/1282#issuecomment-166910265 How do you know if there are no jobs associated with it? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: Removed unused methods from EventBus inte...
Github user pdube commented on the pull request: https://github.com/apache/cloudstack/pull/1260#issuecomment-166691207 Did you try rebuilding CS with each type of event queue? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: [4.7] FIX Site2SiteVPN on redundant VPC
Github user pdube commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1276#discussion_r48278591
--- Diff:
server/src/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.java ---
@@ -916,6 +916,9 @@ protected void updateSite2SiteVpnConnectionState(final
List rout
}
continue;
}
+if (router.getIsRedundantRouter() &&
router.getRedundantState() != RedundantState.MASTER){
--- End diff --
Should this check be done before the previous 'if'?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
