[GitHub] cloudstack issue #1875: CLOUDSTACK-8608: [VMware] System VMs failed to start...
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1875 LGTM. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1837: [4.9] Smoketest Health
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1837 @blueorangutan test matrix --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1836: [4.10/master] Smoketest Health
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1836 @blueorangutan test matrix --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #2033: [master/4.10+] CLOUDSTACK-9462: Support for Ubuntu 1...
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/2033 @blueorangutan test ubuntu kvm-ubuntu --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1836: [4.10/master] Smoketest Health
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1836 @blueorangutan package --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1837: [4.9] Smoketest Health
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1837 @blueorangutan package --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #2037: CLOUDSTACK-9871: Set SQL Mode in SQL Session for MyS...
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/2037 @pdion891 I'll run regression tests @blueorangutan test --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #2037: CLOUDSTACK-9871: Set SQL Mode in SQL Session for MyS...
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/2037 Lgtm @blueorangutan package --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #2037: CLOUDSTACK-9871: Set SQL Mode in SQL Session for MyS...
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/2037 LGTM @wido can you change the base branch to 4.9, to get this in 4.9 branch as well? Thanks. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1879: CLOUDSTACK-9719: [VMware] VR loses DHCP settings and...
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1879 @karuturi thanks I'll see how I can help. This PR though looks like a bug to me, though not a blocker. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1980: CLOUDSTACK-9805: Display VR list in network details
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1980 @karuturi this is a simple UI change with screenshots attached, and has enough LGTM. Please merge this. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #2034: [4.9+][network blocker] CLOUDSTACK-9838: Allow ingre...
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/2034 Verified the mangle table firewall rules are now ACCEPT instead of RETURN. Pinging for review -- @wido @jayapalu @karuturi @abhinandanprateek @DaanHoogland /cc @PaulAngus --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #2033: [master/4.10+] CLOUDSTACK-9462: Support for Ubuntu 1...
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/2033 @ustcweizhou thanks, yes there is a minor difference around the init-helper version that's all @karuturi jenkins/travis re-kicked. @blueorangutan package --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request #2033: [master/4.10+] CLOUDSTACK-9462: Support for U...
Github user rhtyd closed the pull request at: https://github.com/apache/cloudstack/pull/2033 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request #2033: [master/4.10+] CLOUDSTACK-9462: Support for U...
GitHub user rhtyd reopened a pull request: https://github.com/apache/cloudstack/pull/2033 [master/4.10+] CLOUDSTACK-9462: Support for Ubuntu 14.04/16.04 with tomcat6/tomcat7 This extends work from @ustcweizhou from https://github.com/apache/cloudstack/pull/1950 by fixing some build issues to make this work with Ubuntu 14.04 and 16.04. This closes #1950 You can merge this pull request into a Git repository by running: $ git pull https://github.com/shapeblue/cloudstack ubuntu1604-fixsystemd-weiz Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cloudstack/pull/2033.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2033 commit 4a77a799490a0cd655b1a53377c4db1bb51ddc7c Author: Wei Zhou <w.z...@tech.leaseweb.com> Date: 2017-02-17T08:59:52Z CLOUDSTACK-9462: Build packages on Ubuntu 14.04/16.04 and support tomcat6/tomcat7 Changes (1) add systemd support in debian/control and debian/rules for 16.04 (2) add python-setuptools in Build-Depends in debian/control (3) seperate cloudstack-management.service and cloudstack-management.default for CentOS7 and Ubuntu 16.04 (4) add server7-ssl.xml and server7-nonssl.xml in management installation (5) link /usr/share/cloudstack-management/lib and /usr/share/cloudstack-management/bin to correct path (tomcat6 or tomcat7) (6) link /etc/cloudstack/management/server.xml to correct file path (server-nonssl.xml or server7-nonssl.xml) (7) remove *.zip from .gitignore to avoid build error caused by missing /vhds/test.vhd.zip Instruction (1) build packages on Ubuntu 16.04: dpkg-buildpackage -uc -us Output on Ubuntu 16.04: -rw-r--r-- 1 root root 4090 Feb 17 10:12 cloudstack_4.10.0.0-SNAPSHOT_amd64.changes -rw-r--r-- 1 root root 1235 Feb 17 09:53 cloudstack_4.10.0.0-SNAPSHOT.dsc -rw-r--r-- 1 root root 8018248 Feb 17 09:53 cloudstack_4.10.0.0-SNAPSHOT.tar.xz -rw-r--r-- 1 root root 91868746 Feb 17 10:11 cloudstack-agent_4.10.0.0-SNAPSHOT_all.deb -rw-r--r-- 1 root root 52882 Feb 17 10:12 cloudstack-cli_4.10.0.0-SNAPSHOT_all.deb -rw-r--r-- 1 root root 98556216 Feb 17 10:08 cloudstack-common_4.10.0.0-SNAPSHOT_all.deb -rw-r--r-- 1 root root 52864 Feb 17 10:12 cloudstack-docs_4.10.0.0-SNAPSHOT_all.deb -rw-r--r-- 1 root root585434 Feb 17 10:12 cloudstack-integration-tests_4.10.0.0-SNAPSHOT_all.deb -rw-r--r-- 1 root root 323459934 Feb 17 10:10 cloudstack-management_4.10.0.0-SNAPSHOT_all.deb -rw-r--r-- 1 root root442656 Feb 17 10:12 cloudstack-marvin_4.10.0.0-SNAPSHOT_all.deb -rw-r--r-- 1 root root 87037576 Feb 17 10:12 cloudstack-usage_4.10.0.0-SNAPSHOT_all.deb (2) setup tomcat6/tomcat7 on management server: tomcat6: cloudstack-setup-management --tomcat6 tomcat7: cloudstack-setup-management --tomcat7 Signed-off-by: Rohit Yadav <rohit.ya...@shapeblue.com> --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #2033: [master/4.10+] CLOUDSTACK-9462: Support for Ubuntu 1...
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/2033 @karuturi done, thanks. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1879: CLOUDSTACK-9719: [VMware] VR loses DHCP settings and...
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1879 Thanks @sureshanaparti, since @karuturi is the RM I've avoided merging any PRs. @karuturi if you're busy and need a co-pilot I can help review and merge some outstanding PRs that have enough LGTMs and regression test results. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1960: [4.11/Future] CLOUDSTACK-9782: Host HA and KVM HA pr...
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1960 @koushik-das sorry could not get back to you earlier as I was busy with other work. I've replied on the ML thread to address several queries [1] that lists the advantages of this host-ha framework over existing building blocks and I've explained why we needed to implement it. Please have at the reply, if you still have any reservations let us know on the ML thread, we'll get back to you. [1] http://markmail.org/message/k7oaqyv5mzmlvzhx Note: As stated earlier in the ML thread as well -- *this is not a new VM HA framework*, the framework implementation is agnostic of the host-specific HA-provider to allow any custom host-ha plugin to be developed that is specific to a hypervisor as each hypervisor may have their own specific tools/infra/algorithms to check resource (disk/vm etc) activities, including scope for future extentions for other HA-able resources. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #2026: CLOUDSTACK-9861: Expire VM snapshots after configure...
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/2026 Lgtm --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #2022: [dvswitch blocker] CLOUDSTACK-9591: Fix systemvmtemp...
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/2022 @blueorangutan test --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #2022: [dvswitch blocker] CLOUDSTACK-9591: Fix systemvmtemp...
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/2022 @karuturi the failures around vpc are known to be intermittent for vmware env, the failures are not related to the changes. The environments where you dont see more than three failures are usually KVM based. I can kick the tests once again. @blueorangutan package --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #2033: [master/4.10+] CLOUDSTACK-9462: Support for Ubuntu 1...
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/2033 @karuturi this is ready for merge Pinging for review - @wido @ @ustcweizhou --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #2033: [master/4.10+] CLOUDSTACK-9462: Support for Ubuntu 1...
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/2033 @blueorangutan package --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #2034: [4.9+][network blocker] CLOUDSTACK-9838: Allow ingre...
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/2034 @blueorangutan test centos7 vmware-55u3 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request #2034: [4.9+][network blocker] CLOUDSTACK-9838: Allo...
Github user rhtyd closed the pull request at: https://github.com/apache/cloudstack/pull/2034 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request #2034: [4.9+][network blocker] CLOUDSTACK-9838: Allo...
GitHub user rhtyd reopened a pull request: https://github.com/apache/cloudstack/pull/2034 [4.9+][network blocker] CLOUDSTACK-9838: Allow ingress traffic between guest VMs via snat IPs This enables the firewall/mangle tables rules to ACCEPT instead of RETURN, which is the same behaviour as observed in ACS 4.5. By accepting the traffic, guest VMs will be able to communicate tcp traffic between each other over snat public IPs. This is a regression from ACS 4.5, observed in ACS 4.9.2.0. Pinging for review - @PaulAngus @borisstoyanov @DagSonsteboSB @abhinandanprateek @DaanHoogland and others @blueorangutan package You can merge this pull request into a Git repository by running: $ git pull https://github.com/shapeblue/cloudstack CLOUDSTACK-9838 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cloudstack/pull/2034.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2034 commit f4835294869f01def94618f2c206160ccb3b719f Author: Rohit Yadav <rohit.ya...@shapeblue.com> Date: 2017-04-07T11:44:18Z CLOUDSTACK-9838: Allow ingress traffic between guest VMs via snat IPs This enables the firewall/mangle tables rules to ACCEPT instead of RETURN, which is the same behaviour as observed in ACS 4.5. By accepting the traffic, guest VMs will be able to communicate tcp traffic between each other over snat public IPs. Signed-off-by: Rohit Yadav <rohit.ya...@shapeblue.com> --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #2035: CLOUDSTACK-9867:VM snapshot on primary storage usage...
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/2035 @abhinandanprateek can you check/fix the build failures? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #2033: [4.9+] CLOUDSTACK-9462: Support for Ubuntu 14.04/16....
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/2033 @blueorangutan package --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #2034: [4.9+][network blocker] CLOUDSTACK-9838: Allow ingre...
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/2034 @borisstoyanov working now, I've rekicked packaging. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #2022: [dvswitch blocker] CLOUDSTACK-9591: Fix systemvmtemp...
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/2022 Thanks @borisstoyanov @karuturi this is ready for merge now, thanks --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request #2034: [4.9+][network blocker] CLOUDSTACK-9838: Allo...
GitHub user rhtyd opened a pull request: https://github.com/apache/cloudstack/pull/2034 [4.9+][network blocker] CLOUDSTACK-9838: Allow ingress traffic between guest VMs via snat IPs This enables the firewall/mangle tables rules to ACCEPT instead of RETURN, which is the same behaviour as observed in ACS 4.5. By accepting the traffic, guest VMs will be able to communicate tcp traffic between each other over snat public IPs. This is a regression from ACS 4.5, observed in ACS 4.9.2.0. Pinging for review - @PaulAngus @borisstoyanov @DagSonsteboSB @abhinandanprateek @DaanHoogland and others @blueorangutan package You can merge this pull request into a Git repository by running: $ git pull https://github.com/shapeblue/cloudstack CLOUDSTACK-9838 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cloudstack/pull/2034.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2034 commit f4835294869f01def94618f2c206160ccb3b719f Author: Rohit Yadav <rohit.ya...@shapeblue.com> Date: 2017-04-07T11:44:18Z CLOUDSTACK-9838: Allow ingress traffic between guest VMs via snat IPs This enables the firewall/mangle tables rules to ACCEPT instead of RETURN, which is the same behaviour as observed in ACS 4.5. By accepting the traffic, guest VMs will be able to communicate tcp traffic between each other over snat public IPs. Signed-off-by: Rohit Yadav <rohit.ya...@shapeblue.com> --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #2033: [4.9+] CLOUDSTACK-9462: Support for Ubuntu 14.04/16....
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/2033 @blueorangutan test ubuntu kvm-ubuntu --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1950: [4.10] CLOUDSTACK-9462: Build packages on Ubuntu 14....
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1950 @ustcweizhou I've fixed and ported the patch for 4.9 here: https://github.com/apache/cloudstack/pull/2033 Let's work on that PR? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #2033: [4.9+] CLOUDSTACK-9462: Support for Ubuntu 14.04/16....
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/2033 @blueorangutan package --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #2033: [4.9+] CLOUDSTACK-9462: Support for Ubuntu 14.04/16....
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/2033 I've checked this on Trillian, LGTM. While I've ports this PR, the work is by @ustcweizhou Pinging for review -- @wido @ustcweizhou @abhinandanprateek @DaanHoogland @karuturi --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #2033: [Ignore] Test PR
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/2033 @blueorangutan test ubuntu kvm-ubuntu --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1996: CLOUDSTACK-9099: SecretKey is returned from the APIs
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1996 @jayapalu can you push -f to kick Travis? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1950: [4.10] CLOUDSTACK-9462: Build packages on Ubuntu 14....
Github user rhtyd commented on the issue:
https://github.com/apache/cloudstack/pull/1950
@ustcweizhou can you apply this change:
diff --git a/debian/control b/debian/control
index a019043..460ce7a 100644
--- a/debian/control
+++ b/debian/control
@@ -15,7 +15,7 @@ Description: A common package which contains files which
are shared by several C
Package: cloudstack-management
Architecture: all
-Depends: ${misc:Depends}, ${python:Depends}, openjdk-8-jre-headless |
java8-runtime-headless | java8-runtime, cloudstack-common (=
${source:Version}), tomcat6 | tomcat7, sudo, jsvc, python-mysql.connector,
libmysql-java, augeas-tools, mysql-client, adduser, bzip2, ipmitool,
lsb-release, init-system-helpers (>= 1.14~)
+Depends: ${python:Depends}, openjdk-8-jre-headless |
java8-runtime-headless | java8-runtime, cloudstack-common (=
${source:Version}), tomcat6 | tomcat7, sudo, jsvc, python-mysql.connector,
libmysql-java, augeas-tools, mysql-client, adduser, bzip2, ipmitool,
lsb-release, init-system-helpers (>= 1.14~)
Conflicts: cloud-server, cloud-client, cloud-client-ui
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #2022: [dvswitch blocker] CLOUDSTACK-9591: Fix systemvmtemp...
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/2022 @sateesh-chodapuneedi see the JIRA ticket https://issues.apache.org/jira/browse/CLOUDSTACK-9591 The exceptions are seen in SSVM logs --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request #2033: [Ignore] Test PR
GitHub user rhtyd opened a pull request: https://github.com/apache/cloudstack/pull/2033 [Ignore] Test PR See https://github.com/apache/cloudstack/pull/1950 You can merge this pull request into a Git repository by running: $ git pull https://github.com/shapeblue/cloudstack ubuntu1604-fixsystemd-weiz Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cloudstack/pull/2033.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2033 commit d87fc8a69d0f4cc1147aef03adf5594f3a5fc6cb Author: Wei Zhou <w.z...@tech.leaseweb.com> Date: 2017-02-17T08:59:52Z CLOUDSTACK-9462: Build packages on Ubuntu 14.04/16.04 and support tomcat6/tomcat7 Changes (1) add systemd support in debian/control and debian/rules for 16.04 (2) add python-setuptools in Build-Depends in debian/control (3) seperate cloudstack-management.service and cloudstack-management.default for CentOS7 and Ubuntu 16.04 (4) add server7-ssl.xml and server7-nonssl.xml in management installation (5) link /usr/share/cloudstack-management/lib and /usr/share/cloudstack-management/bin to correct path (tomcat6 or tomcat7) (6) link /etc/cloudstack/management/server.xml to correct file path (server-nonssl.xml or server7-nonssl.xml) (7) remove *.zip from .gitignore to avoid build error caused by missing /vhds/test.vhd.zip Instruction (1) build packages on Ubuntu 16.04: dpkg-buildpackage -uc -us Output on Ubuntu 16.04: -rw-r--r-- 1 root root 4090 Feb 17 10:12 cloudstack_4.10.0.0-SNAPSHOT_amd64.changes -rw-r--r-- 1 root root 1235 Feb 17 09:53 cloudstack_4.10.0.0-SNAPSHOT.dsc -rw-r--r-- 1 root root 8018248 Feb 17 09:53 cloudstack_4.10.0.0-SNAPSHOT.tar.xz -rw-r--r-- 1 root root 91868746 Feb 17 10:11 cloudstack-agent_4.10.0.0-SNAPSHOT_all.deb -rw-r--r-- 1 root root 52882 Feb 17 10:12 cloudstack-cli_4.10.0.0-SNAPSHOT_all.deb -rw-r--r-- 1 root root 98556216 Feb 17 10:08 cloudstack-common_4.10.0.0-SNAPSHOT_all.deb -rw-r--r-- 1 root root 52864 Feb 17 10:12 cloudstack-docs_4.10.0.0-SNAPSHOT_all.deb -rw-r--r-- 1 root root585434 Feb 17 10:12 cloudstack-integration-tests_4.10.0.0-SNAPSHOT_all.deb -rw-r--r-- 1 root root 323459934 Feb 17 10:10 cloudstack-management_4.10.0.0-SNAPSHOT_all.deb -rw-r--r-- 1 root root442656 Feb 17 10:12 cloudstack-marvin_4.10.0.0-SNAPSHOT_all.deb -rw-r--r-- 1 root root 87037576 Feb 17 10:12 cloudstack-usage_4.10.0.0-SNAPSHOT_all.deb (2) setup tomcat6/tomcat7 on management server: tomcat6: cloudstack-setup-management --tomcat6 tomcat7: cloudstack-setup-management --tomcat7 Already tested on Ubuntu 16.04, upgraded from 4.7.1 to 4.10.0-SNAPSHOT commit 038bed94fcebd6404393a087dd6f2d5ebbf7a410 Author: Rohit Yadav <rohit.ya...@shapeblue.com> Date: 2017-04-07T06:50:54Z CLOUDSTACK-9462: Fix init-system-helpers version in debian control Signed-off-by: Rohit Yadav <rohit.ya...@shapeblue.com> --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #2033: [Ignore] Test PR
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/2033 @blueorangutan package --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1950: [4.10] CLOUDSTACK-9462: Build packages on Ubuntu 14....
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1950 Failed due to `cloudstack-management : Depends: init-system-helpers (>= 1.18~) but 1.14 is to be installed`. @ustcweizhou can you explicitly set the dependency init-system-helpers (>= 1.14~) for the packages? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #2022: [dvswitch blocker] CLOUDSTACK-9591: Fix systemvmtemp...
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/2022 @karuturi this is ready for merge --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #2025: [4.10-blocker] Fix error in restart network in 4.10....
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/2025 @karuturi this is ready for merge --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #2032: CLOUDSTACK-9783: corrected the version number in met...
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/2032 Thanks @karuturi I usually rebuild CloudStack when forward merging PRs to ensure they don't break the forward-branches --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1944: CLOUDSTACK-9783: Improve metrics view performance
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1944 @karuturi thanks for fixing it --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #2027: Activate NioTest following changes in CLOUDSTACK-934...
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/2027 Thanks @marcaurele that's a good catch! Can you push -f and see why Travis failed, if your fix works let's reenable this test! Also, can you edit the PR and send it for 4.9? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1879: CLOUDSTACK-9719: [VMware] VR loses DHCP settings and...
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1879 @blueorangutan test centos7 vmware-55u3 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #2026: CLOUDSTACK-9861: Expire VM snapshots after configure...
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/2026 LGTM (did not test it). @blueorangutan test centos7 vmware-55u3 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request #2026: CLOUDSTACK-9861: Expire VM snapshots after co...
Github user rhtyd commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/2026#discussion_r110098624
--- Diff: setup/db/db/schema-4920to41000.sql ---
@@ -232,3 +232,5 @@ WHERE (o.cpu is null AND o.speed IS NULL AND o.ram_size
IS NULL) AND
-- CLOUDSTACK-9827: Storage tags stored in multiple places
DROP VIEW IF EXISTS `cloud`.`storage_tag_view`;
+
+INSERT IGNORE INTO `cloud`.`configuration` VALUES ('Advanced', 'DEFAULT',
'VMSanpshotManager', 'vmsnapshot.expire.interval', '-1', 'VM Snapshot expire
interval in hours','-1', NULL, 'Account', 0);
--- End diff --
@abhinandanprateek Since you've used Configkey, no need to use this INSERT
query. Also typo in the 'VMSanpshotManager'.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1879: CLOUDSTACK-9719: [VMware] VR loses DHCP settings and...
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1879 @sureshanaparti sure @blueorangutan package --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #2027: Activate NioTest following changes in CLOUDSTACK-934...
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/2027 @marcaurele the test makes use of threads to run various clients and server instances and is known to consume ports for the same, for these reasons it might fail in some test/build environments. If you look at the git history on this test file and on the pom.xml, you'll find that this test had been disabled in the past (before PR 1493) due to these issues. The test is known to fail intermittently in CI environments such as Jenkins and Travis, which is why I added to the ignored list of test with one of the PRs. On my workstation, I've been consistently able to run and pass it, it is likely an environment issue in your laptop if this is failing inconsistently. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #2024: CLOUDSTACK-9857: With this change if agent dies the ...
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/2024 LGTM, @karuturi this is ready for merging. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1864: [Defunct][Experimental]Switch to using JDK 1.8 and S...
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1864 @wido no, I'm not working on this presently. Though, I've kept it open as a reminder that we need to indeed work on updating the ssvm code to Debian8. Part of the issue is between Debian7 and Debian8, systemd's introducing causes issues with expecting our VR/ssvm codebase to work out of the box, cloud-early-config does not work as it's a init-d script. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1282: CLOUDSTACK-9200: Fixed failed to delete snapshot if ...
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1282 @anshul1886 I've left a comment, the code to check and remove snapshot on allocated state is already in that method? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request #1282: CLOUDSTACK-9200: Fixed failed to delete snaps...
Github user rhtyd commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1282#discussion_r110092518
--- Diff:
engine/storage/snapshot/src/org/apache/cloudstack/storage/snapshot/XenserverSnapshotStrategy.java
---
@@ -245,6 +245,12 @@ public boolean deleteSnapshot(Long snapshotId) {
return true;
}
+if(snapshotVO.getState() == Snapshot.State.Allocated) {
--- End diff --
See
https://github.com/apache/cloudstack/pull/1282/files#diff-2b08c10a0eea4bef15bece6ff38ed1f9R223
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request #1282: CLOUDSTACK-9200: Fixed failed to delete snaps...
Github user rhtyd commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1282#discussion_r110092478
--- Diff:
engine/storage/snapshot/src/org/apache/cloudstack/storage/snapshot/XenserverSnapshotStrategy.java
---
@@ -245,6 +245,12 @@ public boolean deleteSnapshot(Long snapshotId) {
return true;
}
+if(snapshotVO.getState() == Snapshot.State.Allocated) {
--- End diff --
@anshul1886 the code to check and remove snapshot when they are stuck in
Allocated state is already in line 223 above, in the same method. Why this
redundancy, is this a synchronization issue?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1951: CLOUDSTACK-9792: Add upgrade path for 4.9.3.0
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1951 Ping @karuturi --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1980: CLOUDSTACK-9805: Display VR list in network details
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1980 @karuturi this is ready for merge, has the screenshots and lgtms --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1944: CLOUDSTACK-9783: Improve metrics view performance
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1944 Thanks @nvazquez @karuturi --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #2022: CLOUDSTACK-9591: Fix systemvmtemplate to not include...
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/2022 Thanks @karuturi the failures are not related to the PR. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #2025: [4.10-blocker] Fix error in restart network in 4.10....
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/2025 @blueorangutan test --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1950: [4.10] CLOUDSTACK-9462: Build packages on Ubuntu 14....
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1950 @blueorangutan test ubuntu kvm-ubuntu --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #2025: [4.10-blocker] Fix error in restart network in 4.10....
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/2025 I think the issue caused it due to an additional `.0`, LGTM. This should work. @karuturi let's review and merge this blocker, thanks. @blueorangutan package --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1950: [4.10] CLOUDSTACK-9462: Build packages on Ubuntu 14....
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1950 Thanks @ustcweizhou @blueorangutan package --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #2024: CLOUDSTACK-9857: With this change if agent dies the ...
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/2024 LGTM. @abhinandanprateek should we retarget this PR to 4.9? Thanks. @karuturi let's merge this before next 4.10 RC --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #2023: BUG-ID: CLOUDSTACK-9808 Added system Vm upgrade path...
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/2023 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1960: [4.11/Future] CLOUDSTACK-9782: Host HA and KVM HA pr...
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1960 Travis failed due to failure in the test ``test_ha_multiple_mgmt_server_owner...`, I'll have a look shortly --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request #1810: CLOUDSTACK-9647: NIC adapter type becomes e10...
Github user rhtyd commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1810#discussion_r109176624
--- Diff:
server/src/com/cloud/network/router/VpcVirtualNetworkApplianceManagerImpl.java
---
@@ -280,6 +286,16 @@ public boolean finalizeVirtualMachineProfile(final
VirtualMachineProfile profile
public boolean finalizeCommandsOnStart(final Commands cmds, final
VirtualMachineProfile profile) {
final DomainRouterVO domainRouterVO =
_routerDao.findById(profile.getId());
+Map<String, String> details = new HashMap<String, String>();
+
+if(profile.getHypervisorType() ==
Hypervisor.HypervisorType.VMware){
+HypervisorGuru hvGuru =
_hvGuruMgr.getGuru(profile.getHypervisorType());
+VirtualMachineTO vmTO = hvGuru.implement(profile);
+if(vmTO.getDetails() != null){
+details = vmTO.getDetails();
--- End diff --
Should we pass the details irrespective of the hypervisor type?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #2022: CLOUDSTACK-9591: Fix systemvmtemplate to not include...
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/2022 @blueorangutan test centos7 vmware-55u3 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #2022: CLOUDSTACK-9591: Fix systemvmtemplate to not include...
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/2022 This may be seen as a blocker for vmware dv-switch based environments where at the moment we cannot use the systemvmtemplates. Pinging for review - @DaanHoogland @abhinandanprateek @borisstoyanov @PaulAngus @karuturi @koushik-das and others --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #2022: CLOUDSTACK-9591: Fix systemvmtemplate to not include...
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/2022 @blueorangutan package --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #2022: CLOUDSTACK-9591: Fix systemvmtemplate to not include...
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/2022 @blueorangutan test centos7 vmware-55u3 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #2022: CLOUDSTACK-9591: Fix systemvmtemplate to not include...
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/2022 @NuxRo hi Lucian, I tested your Macchinina template as well: http://dl.openvm.eu/cloudstack/macchinina/x86_64/macchinina-vmware.ova It too has network/nics defined so it fails to deploy on dvswitch-based vmware environments (with no vswitches). Can you please regenerate the ova without the defined nics/networks? @blueorangutan package --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request #2022: CLOUDSTACK-9591: Fix systemvmtemplate to not ...
GitHub user rhtyd opened a pull request: https://github.com/apache/cloudstack/pull/2022 CLOUDSTACK-9591: Fix systemvmtemplate to not include network details This removes nic/network specific details while exporting the systemvmtemplate for vmware (ova file). Having this causes the ssvms to not deploy in dvswitch-based vmware environments that have no vswitch portgroups (dummy etc). Tested this on a local Trillian env. You can merge this pull request into a Git repository by running: $ git pull https://github.com/shapeblue/cloudstack 4.9-systemvm-fix-vmware-portgroups Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cloudstack/pull/2022.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2022 commit 49a132fdf9a8e97922a4f2e6435c8fb07fea6076 Author: Rohit Yadav <rohit.ya...@shapeblue.com> Date: 2017-03-30T06:09:43Z appliance: remove nic related rules while exporting ssvm ova Signed-off-by: Rohit Yadav <rohit.ya...@shapeblue.com> --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #2001: CLOUDSTACK-9830 Fix DST bug in QuotaAlertManagerTest
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/2001 @nathanejohnson can we continue to use jodatime but you can fix your issue? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #2001: CLOUDSTACK-9830 Fix DST bug in QuotaAlertManagerTest
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/2001 LGTM. @abhinandanprateek ? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1996: CLOUDSTACK-9099: SecretKey is returned from the APIs
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1996 @jayapalu this is a useful security fix for 4.9 as well, can you please rebase against the 4.9 branch and edit the base branch of the PR to 4.9? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #2019: CLOUDSTACK-9851 travis CI build failure after merge ...
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/2019 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1980: CLOUDSTACK-9805: Display VR list in network details
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1980 @DaanHoogland @abhinandanprateek @borisstoyanov @koushik-das @remibergsma @karuturi let's lgtm and merge this? thanks. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1944: CLOUDSTACK-9783: Improve metrics view performance
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1944 @karuturi this is merge-able and much needed enhancement to improve UI performance for large environments --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1951: CLOUDSTACK-9792: Add upgrade path for 4.9.3.0
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1951 ping @karuturi let's merge this? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1960: [4.11/Future] CLOUDSTACK-9782: Host HA and KVM HA pr...
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1960 @borisstoyanov copy that, done --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #2003: CLOUDSTACK-9811: fixed an issue if the dev is not in...
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/2003 LGTM, does this affect 4.9 as well @swill ? /cc @borisstoyanov --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #2011: CLOUDSTACK-9811: fix duplicated nics on VR caused by...
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/2011 LGTM. Can we check travis failures? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1859: CLOUDSTACK-8672 : NCC Integration with CloudStack
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1859 At least since August 2015, we've been following the guideline [1][2] for 2LGTMs and to squash changes when they are accepted. AFAIK RMs for 4.6+ have been asking PR authors to squash their changes before merging the PR once their PR is accepted, the consensus has been followed and enforced. I've only requested the PR authors to follow what has been followed in the community/PRs for a very long time, however I encourage any disagreements to be debated on dev ML than be discussed and burried in a pull request as this affects everyone. /cc @karuturi As an individual contributor, I prefer squashing changes for a single feature/FR into one or fewer commits. Sometimes, it may make sense to squash changes to more than one commit though 90 seems like an outrageous number. If multiple authors have worked on the PR, authors can consider squashing changes to lowest possible grouped/squashed changes. Lastly, we've also seen several feature PRs with several kloc+ changes that were accepted as a single squashed commit that may be searched through Github PR search page. [1] http://markmail.org/thread/4cvxhm67ef356ppu [2] https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=61311655 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #2009: CLOUDSTACK-9369 Fixed Ldap regression
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/2009 @karuturi done, can you check Travis failure; push -f or close/reopen the PR to kick it again? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request #2009: CLOUDSTACK-9369 Fixed Ldap regression
Github user rhtyd commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/2009#discussion_r106849093
--- Diff:
server/src/com/cloud/api/auth/DefaultLoginAPIAuthenticatorCmd.java ---
@@ -166,7 +166,7 @@ public String authenticate(String command, Map<String,
Object[]> params, HttpSes
throw new CloudAuthenticationException("Unable to find
the domain from the path " + domain);
}
final UserAccount userAccount =
_accountService.getActiveUserAccount(username[0], domainId);
-if (userAccount == null ||
!(User.Source.UNKNOWN.equals(userAccount.getSource()) ||
User.Source.LDAP.equals(userAccount.getSource( {
+if (userAccount != null && User.Source.SAML2 ==
userAccount.getSource()) {
--- End diff --
Why do we need to remove the check `userAccount == null`? Comparision
against Source.SAML2 is fine as long as there are no other user sources other
than LDAP, SAML2 and UNKNOWN. (UNKNOWN should be NATIVE though)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1859: CLOUDSTACK-8672 : NCC Integration with CloudStack
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1859 @rajesh-battala I won't accept this PR, sorry to share this but the number of commits are simply outrageous. From my experience RM-ing for 4.3, 4.5, 4.9 -- the git history is pretty messed-up and it becomes far too difficult to track changes, backport/up-port commits/fixes/feature. There have been big PR/features that have been accepted and merged with very few overall squashed commits. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1859: CLOUDSTACK-8672 : NCC Integration with CloudStack
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1859 @nitin-maharana it becomes easier to triage changes when changes are confined to a limited number of commits (ideally one per PR), please squash the commits based on the author (if not to a single commit) if you don't agree. Ideally, you can also group/squash commits based on the component/framework/architecture. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1879: CLOUDSTACK-9719: [VMware] VR loses DHCP settings and...
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1879 @blueorangutan package --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1944: CLOUDSTACK-9783: Improve metrics view performance
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1944 @karuturi ping? can this be merged as well, this greatly improves the UI performance for the existing metrics view feature as well as improves the load time of the infrastructure tab @abhinandanprateek @DaanHoogland - would you like to review this as well, thanks. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1889: CLOUDSTACK-9718: Revamp the dropdown showing lists o...
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1889 Looks good (did not test it) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1983: [4.10/blocker] Upgrade4920to41000: Migrate systemvmt...
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1983 Closing since another similar PR has been merged now. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #793: CLOUDSTACK-8827: Move the VM snapshots stuck in trans...
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/793 @blueorangutan package --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1879: CLOUDSTACK-9719: [VMware] VR loses DHCP settings and...
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1879 @blueorangutan test centos7 vmware-60u2 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1879: CLOUDSTACK-9719: [VMware] VR loses DHCP settings and...
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1879 I can fire something on vmware6.0 @sureshanaparti can you retarget this PR to 4.9 if this is a useful bugfix as 4.9 also support vmware 6. @blueorangutan package --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1922: CLOUDSTACK-9757: Fixed issue in traffic from additio...
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1922 @jayapalu can you fix the bug on 4.9 as well, send a PR? thanks. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1908: CLOUDSTACK-9317: Fixed disable static nat on leaving...
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1908 @jayapalu can you change the PR base branch to 4.9? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1995: CLOUDSTACK-9828: GetDomRVersionCommand fails to get ...
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1995 @ustcweizhou the issue we found is due to delay in buffered stdout, where sometimes the getdomr answer may not have the 'hash' after the delimiter '&'. This is a very specific case which normally could not be reproduced. We saw this issue in a production environment and Abhi recently found the issue in a Trillian environment. @blueorangutan test centos7 vmware-55u3 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
