Re: new committer: Boris Stoyanov (AKA Bobby)

2018-12-13 Thread Sateesh Chodapuneedi
Hearty Congratulations, Bobby!
Well deserved.
Bobby has been actively helping with validation of MRs under review. Also 
helping users in users list.

Regards,
Sateesh
 

-Original Message-
From: Paul Angus 
Reply-To: "dev@cloudstack.apache.org" 
Date: Thursday, 13 December 2018 at 14:59
To: "us...@cloudstack.apache.org" , 
"dev@cloudstack.apache.org" 
Cc: Boris Stoyanov 
Subject: new committer: Boris Stoyanov (AKA Bobby)

Hi Everyone,

The Project Management Committee (PMC) for Apache CloudStack
has invited Boris Stoyanov to become a committer and we are pleased
to announce that he has accepted.

Please join me in congratulating Bobby!


Being a committer enables easier contribution to the
project since there is no need to go via the patch
submission process. This should enable better productivity.
Being a PMC member enables assistance with the management
and to guide the direction of the project.



paul.an...@shapeblue.com 
www.shapeblue.com
Amadeus House, Floral Street, London  WC2E 9DPUK
@shapeblue
  
 





Re: [ANNOUNCE] New committer: Andrija Panić

2018-11-18 Thread Sateesh Chodapuneedi
Hearty Congrats, Andrija!
Very well deserved.

Regards,
Sateesh

-Original Message-
From: "Tutkowski, Mike" 
Reply-To: "dev@cloudstack.apache.org" 
Date: Monday, 19 November 2018 at 09:57
To: "dev@cloudstack.apache.org" 
Subject: [ANNOUNCE] New committer: Andrija Panić

Hi everyone,

The Project Management Committee (PMC) for Apache CloudStack
has invited Andrija Panić to become a committer and I am pleased
to announce that he has accepted.

Please join me in congratulating Andrija on this accomplishment.

Thanks!
Mike




RE Update default template from CentOS 5.5 to CentOS 7

2018-07-11 Thread Sateesh Chodapuneedi
While it's good idea to bump up the current default VM template "CentOS 
5.5(64-bit) no GUI (KVM)" to a newer version. I doubt the candidate would be 
CentOS 7. Reason being the supportability of the hypervisor. The candidate 
should be supported across all the versions of hypervisors that next version of 
CloudStack would support. To support CentOS 7 we might have to drop support for 
few of the versions listed below.

From 4.11 documentation the minimum versions supported are,
XenServer versions 6.1, 6.2 SP1, 6.5, 7.0, 7.1, 7.2 with latest hotfixes
VMware versions 5.0 Update 3, 5.1 Update 3, 5.5 Update 3b, 6.0 Update 2, and 
6.5 GA

Regards,
Sateesh
 
-Original Message-
From: Gabriel Beims Bräscher 
Reply-To: "dev@cloudstack.apache.org" 
Date: Wednesday, 11 July 2018 at 00:52
To: dev 
Subject: Update default template from CentOS 5.5 to CentOS 7

Hello,

I would like to propose updating our current default VM template "CentOS
5.5(64-bit) no GUI (KVM)" to a newer version (e.g. CentOS 7). I also think
that we could benefit from a wider set of templates offering also Debian,
Ubuntu, and Fedora.

Cheers,
Gabriel.


DISCLAIMER
==
This e-mail may contain privileged and confidential information which is the 
property of Accelerite, a Persistent Systems business. It is intended only for 
the use of the individual or entity to which it is addressed. If you are not 
the intended recipient, you are not authorized to read, retain, copy, print, 
distribute or use this message. If you have received this communication in 
error, please notify the sender and delete all copies of this message. 
Accelerite, a Persistent Systems business does not accept any liability for 
virus infected mails.


Re: John Kinsella and Wido den Hollander now ASF members

2018-05-08 Thread Sateesh Chodapuneedi
Congratulations, guys :-)

Regards,
Sateesh
 
-Original Message-
From: David Nalley 
Reply-To: "dev@cloudstack.apache.org" 
Date: Wednesday, 2 May 2018 at 9:28 PM
To: "dev@cloudstack.apache.org" , 
"priv...@cloudstack.apache.org" 
Subject: John Kinsella and Wido den Hollander now ASF members

Hi folks,

As noted in the press release[1] John Kinsella and Wido den Hollander
have been elected to the ASF's membership.

Members are the 'shareholders' of the foundation, elect the board of
directors, and help guide the future of the ASF.

Congrats to both of you, very well deserved.

--David

[1] https://s.apache.org/ysxx


DISCLAIMER
==
This e-mail may contain privileged and confidential information which is the 
property of Accelerite, a Persistent Systems business. It is intended only for 
the use of the individual or entity to which it is addressed. If you are not 
the intended recipient, you are not authorized to read, retain, copy, print, 
distribute or use this message. If you have received this communication in 
error, please notify the sender and delete all copies of this message. 
Accelerite, a Persistent Systems business does not accept any liability for 
virus infected mails.


Re: Attached volume is not visible within the vm

2018-04-06 Thread Sateesh Chodapuneedi
What hypervisor the windows vm is deployed on?

Regards,
Sateesh
 
-Original Message-
From: soundar rajan 
Reply-To: "us...@cloudstack.apache.org" 
Date: Friday, 6 April 2018 at 12:59 PM
To: "dev@cloudstack.apache.org" , 
"us...@cloudstack.apache.org" 
Subject: Re: Attached volume is not visible within the vm

I am able to view the disk in linux vm centos. The same not working in
windows. Do i need to install any additional package in windows server?

I tried rebooting the windows vm didnt work.

Please help!!

On Fri, Apr 6, 2018 at 11:56 AM, soundar rajan 
wrote:

> Hi,
>
> I have created a 5 GB volume in the storage and attached the volume to a
> vm status shows ready and success
>
> when i login to the vm and access the disk management i dont see that disk
> inside the windows server.
>
> Tried rescan disk option no luck any idea?
>
> OS: Windows Server 2012 R2
>
> cloudstack : 4.11
>
>
> Regards
> Shyam
>


DISCLAIMER
==
This e-mail may contain privileged and confidential information which is the 
property of Accelerite, a Persistent Systems business. It is intended only for 
the use of the individual or entity to which it is addressed. If you are not 
the intended recipient, you are not authorized to read, retain, copy, print, 
distribute or use this message. If you have received this communication in 
error, please notify the sender and delete all copies of this message. 
Accelerite, a Persistent Systems business does not accept any liability for 
virus infected mails.


Re: Welcoming Mike as the new Apache CloudStack VP

2018-03-27 Thread Sateesh Chodapuneedi
Hi Mike,
Hearty congratulations for the new role.

Thank you, Wido, for the good work in last 1 year.

Regards,
Sateesh
 
-Original Message-
From: Wido den Hollander 
Reply-To: "dev@cloudstack.apache.org" 
Date: Monday, 26 March 2018 at 9:11 PM
To: "dev@cloudstack.apache.org" , 
"us...@cloudstack.apache.org" 
Subject: Welcoming Mike as the new Apache CloudStack VP

Hi all,

It's been a great pleasure working with the CloudStack project as the
ACS VP over the past year.

A big thank you from my side for everybody involved with the project in
the last year.

Hereby I would like to announce that Mike Tutkowski has been elected to
replace me as the Apache Cloudstack VP in our annual VP rotation.

Mike has a long history with the project and I am are happy welcome him
as the new VP for CloudStack.

Welcome Mike!

Thanks,

Wido


DISCLAIMER
==
This e-mail may contain privileged and confidential information which is the 
property of Accelerite, a Persistent Systems business. It is intended only for 
the use of the individual or entity to which it is addressed. If you are not 
the intended recipient, you are not authorized to read, retain, copy, print, 
distribute or use this message. If you have received this communication in 
error, please notify the sender and delete all copies of this message. 
Accelerite, a Persistent Systems business does not accept any liability for 
virus infected mails.


Re: Notice that Gabriel Bräscher now works at PCextreme

2018-03-20 Thread Sateesh Chodapuneedi
Congrats Gabriel.

Regards,
Sateesh
 
-Original Message-
From: Wido den Hollander 
Reply-To: "dev@cloudstack.apache.org" 
Date: Tuesday, 20 March 2018 at 7:21 PM
To: "dev@cloudstack.apache.org" 
Cc: "gabrasc...@gmail.com" 
Subject: Notice that Gabriel Bräscher now works at PCextreme

Hi,

Just wanted to let you know that Gabriel Bräscher started working at
PCextreme this week.

He'll be committing and developing on CloudStack for PCextreme and the
community.

Just so everybody knows that we are colleagues now.

Let's make CloudStack even better!

Wido


DISCLAIMER
==
This e-mail may contain privileged and confidential information which is the 
property of Accelerite, a Persistent Systems business. It is intended only for 
the use of the individual or entity to which it is addressed. If you are not 
the intended recipient, you are not authorized to read, retain, copy, print, 
distribute or use this message. If you have received this communication in 
error, please notify the sender and delete all copies of this message. 
Accelerite, a Persistent Systems business does not accept any liability for 
virus infected mails.


Re: [ANNOUNCE] Syed Mushtaq Ahmed has joined the PMC

2017-10-09 Thread Sateesh Chodapuneedi
Hearty Congrats, Syed!
Well deserved!

Regards,
Sateesh,
CloudStack Development,
Accelerite, 
Laurelwood Rd, 
Santa Clara-95054
@accelerite

-Original Message-
From: Paul Angus 
Reply-To: "us...@cloudstack.apache.org" 
Date: Monday, 9 October 2017 at 4:57 PM
To: "dev@cloudstack.apache.org" , 
"us...@cloudstack.apache.org" 
Subject: [ANNOUNCE] Syed Mushtaq Ahmed has joined the PMC

Fellow CloudStackers,

It gives me great pleasure to say that Syed has be invited to join the PMC 
and has gracefully accepted.
Please joining me in congratulating Syed!


Kind regards,

Paul Angus


paul.an...@shapeblue.com 
www.shapeblue.com
53 Chandos Place, Covent Garden, London  WC2N 4HSUK
@shapeblue
  
 



DISCLAIMER
==
This e-mail may contain privileged and confidential information which is the 
property of Accelerite, a Persistent Systems business. It is intended only for 
the use of the individual or entity to which it is addressed. If you are not 
the intended recipient, you are not authorized to read, retain, copy, print, 
distribute or use this message. If you have received this communication in 
error, please notify the sender and delete all copies of this message. 
Accelerite, a Persistent Systems business does not accept any liability for 
virus infected mails.


Re: Advice on converting zone-wide to cluster-wide storage

2017-09-30 Thread Sateesh Chodapuneedi
Hi Andrija,
I’ve converted cluster-wide NFS based storage pools to zone-wide in the past.

Basically there are 2 steps for NFS and Ceph,
1. DB update
2. If there are more than 1 cluster in that zone, then do un-manage & manage 
all the clusters except the original cluster

In addition to Mike’s suggestion, you need to do following,
• Set ‘scope’ of the storage pool to ‘ZONE’ in `cloud`.`storage_pool` table

Example SQL looks like below, given that the hypervisor in my setup is VMware.
mysql> update storage_pool set scope='ZONE', cluster_id=NULL, pod_id=NULL, 
hypervisor='VMware' where id=;

With DB update, the changes would be reflected in UI as well.

Post the DB update, it is important to un-manage, followed by manage clusters 
(except the original cluster to which this storage pool belongs to) so that all 
hosts in other clusters also to connect to this storage pool, making this pool 
as a full-fledged zone wide storage pool.

Hope this helps you!

Regards,
Sateesh Ch,
CloudStack Development, Accelerite,
www.accelerite.com
@accelerite


-Original Message-
From: "Tutkowski, Mike" 
Reply-To: "dev@cloudstack.apache.org" 
Date: Friday, 29 September 2017 at 6:57 PM
To: "dev@cloudstack.apache.org" , 
"us...@cloudstack.apache.org" 
Subject: Re: Advice on converting zone-wide to cluster-wide storage

Hi Andrija,

I just took a look at the SolidFire logic around adding primary storage at 
the zone level versus the cluster scope.

I recommend you try this in development prior to production, but it looks 
like you can make the following changes for SolidFire:

• In cloud.storage_pool, enter the applicable value for pod_id (this should 
be null when being used as zone-wide storage and an integer when being used as 
cluster-scoped storage).
• In cloud.storage_pool, enter the applicable value for cluster_id (this 
should be null when being used as zone-wide storage and an integer when being 
used as cluster-scoped storage).
• In cloud.storage_pool, change the hypervisor_type from Any to (in your 
case) KVM.

Talk to you later!
Mike

On 9/29/17, 5:18 AM, "Andrija Panic"  wrote:

Hi all,

I was wondering if anyone have experience hacking DB and converting
zone-wide primary storage to cluster-wide.

We have:
1 x NFS primary storage, zone-wide
1 x CEPH primary storage, zone-wide
1 x SOLIDFIRE orimary storage, zone-wide
1 zone, 1 pod, 1 cluster., Advanced zone, and 1 NFS regular secondary
storage (SS not relevant here).

I'm assuming few DB changes would do it  - storage_pool table / scope,
cluster_id, pod_id fileds), but have not yet had time to play with it
really.

Any advice if this is OK to be done in production environment, would be
very much appreciated.

We plan to expand to many more racks, so we might move from
single-everything (pod/cluster) to multiple PODs/clusters etc, and thus
design Primary Storage accordingly.

Thanks !

-- 

Andrija Panić




DISCLAIMER
==
This e-mail may contain privileged and confidential information which is the 
property of Accelerite, a Persistent Systems business. It is intended only for 
the use of the individual or entity to which it is addressed. If you are not 
the intended recipient, you are not authorized to read, retain, copy, print, 
distribute or use this message. If you have received this communication in 
error, please notify the sender and delete all copies of this message. 
Accelerite, a Persistent Systems business does not accept any liability for 
virus infected mails.


Re: New committers: Nathan Johnson and Marc-Aurèle Brothier

2017-09-24 Thread Sateesh Chodapuneedi
Congratulations Nathan, and Marc-Aurèle! 
Well deserved!

Regards,
Sateesh
CloudStack Development,
Accelerite.

-Original Message-
From: Rafael Weingärtner 
Reply-To: "dev@cloudstack.apache.org" 
Date: Friday, 22 September 2017 at 10:01 PM
To: "dev@cloudstack.apache.org" 
Subject: New committers: Nathan Johnson and Marc-Aurèle Brothier

The Project Management Committee (PMC) for Apache CloudStack has invited
Nathan Johnson and Marc-Aurèle Brothier to become committers and we are
pleased to announce that they have accepted.

They have shown commitment to Apache CloudStack community, contributing
with PRs in a constant fashion. Moreover, they have proved great abilities
to interact with the community quite often in our mailing lists and Slack
channel trying to help people.

Let´s congratulate and welcome Apache CloudStack’s two newest committers.

--
Rafael Weingärtner


DISCLAIMER
==
This e-mail may contain privileged and confidential information which is the 
property of Accelerite, a Persistent Systems business. It is intended only for 
the use of the individual or entity to which it is addressed. If you are not 
the intended recipient, you are not authorized to read, retain, copy, print, 
distribute or use this message. If you have received this communication in 
error, please notify the sender and delete all copies of this message. 
Accelerite, a Persistent Systems business does not accept any liability for 
virus infected mails.


Re: DISCUSS : Vmware to Cloudstack migration support

2017-07-04 Thread Sateesh Chodapuneedi

From: Shreya Nair 
Reply-To: "us...@cloudstack.apache.org" 
Date: Tuesday, 4 July 2017 at 4:52 PM
To: "us...@cloudstack.apache.org" , 
"dev@cloudstack.apache.org" , 
"iss...@cloudstack.apache.org" 
Cc: Vinay Patil , Siddheshwar More 

Subject: DISCUSS : Vmware to Cloudstack migration support

Hello,

My team is working on a Vmware to Cloudstack migration task. The CloudStack
environment is set up on the Xenserver hypervisor.

We are able to export a VM on vsphere to OVF template which also provides
the OVF, VMDK disk image(s) and MF file for the particular VM.
In order to create a CloudStack Template from these files, it can be done
by 2 methods, namely, template creation from VHD(as the underlying
hypervisor is XenServer) or template creation from ISO.

VHD Template creation:
- The VMDK file (Obtained after export OVF operation of the VM) is
converted to VHD format with VBoxManage.exe tool that is available with
VirtualBox.
-  The VHD file can be used to create a CloudStack template and
instantiate a VM.


ISO Template creation:
- The OVF file (Obtained after export OVF operation of the VM) is imported
to Citrix XenCenter.
- XenCenter runs Operating system Fixup on the imported OVF file and
creates a modified ISO file.
- The modified ISO file can be used for creating a template and
instantiate a VM

However, the newly created VM has booting issues as it requires "You might
have to change the root from /dev/hd[a-d] to /dev/xvd[a-d]"
Is there an alternate way or support to migrate a vSphere VM to CloudStack?
Or a method to change the partitioning on the hard disk from sd[a-d]  to
xvd[a-d]

Hi Shreya,
Did you remove VMware tools from the VM before exporting?
Try installing xentools inside the guest, that should automatically name the 
disks to xvd*

Regards,
Sateesh



Thanks & Regards,

Shreya

DISCLAIMER
==
This e-mail may contain privileged and confidential information which is the 
property of Accelerite, a Persistent Systems business. It is intended only for 
the use of the individual or entity to which it is addressed. If you are not 
the intended recipient, you are not authorized to read, retain, copy, print, 
distribute or use this message. If you have received this communication in 
error, please notify the sender and delete all copies of this message. 
Accelerite, a Persistent Systems business does not accept any liability for 
virus infected mails.


Re: [Github/Gitbox] Setting up your committer account

2017-04-22 Thread Sateesh Chodapuneedi
Hi @Wido
Tried subscribing to commits mailing list, but got reply that I am already a 
subscriber.

Here is the reply received
Hi! This is the ezmlm program. I'm managing the
comm...@cloudstack.apache.org mailing list.

Acknowledgment: The address

   sateesh.chodapune...@accelerite.com

was already on the commits mailing list when I received
your request, and remains a subscriber.

Regards,
Sateesh

On 22/04/17, 4:53 AM, "Wido den Hollander"  wrote:

I can't tell where this comes from.

I suggest subscribing to comm...@cloudstack.apache.org to get the updates.

Wido

> Op 19 april 2017 om 15:46 schreef Boris Stoyanov 
:
> 
> 
> Yup, same here, no GitHub mails recently.. 
> 
> 
> boris.stoya...@shapeblue.com 
> www.shapeblue.com
> 53 Chandos Place, Covent Garden, London  WC2N 4HSUK
> @shapeblue
>   
>  
> 
> > On Apr 19, 2017, at 4:16 AM, Nicolas Vazquez  
wrote:
> > 
> > I noticed the same
> > 
> > 2017-04-18 12:15 GMT-03:00 Syed Ahmed :
> > 
> >> Same thing with me. I don't see any github activity on the ML since 
Friday.
> >> 
> >> On Tue, Apr 18, 2017 at 5:00 AM, Wido den Hollander 
> >> wrote:
> >> 
> >>> 
>  Op 17 april 2017 om 19:58 schreef Sergey Levitskiy <
> >>> sergey.levits...@autodesk.com>:
>  
>  
>  I used to receive emails from @dev on every change in git. The last
> >>> email came on Friday. Is it expected?
> >>> 
> >>> I think so? I don't know how that worked previously. There is a
> >>> com...@cloudstack.apache.org list though, you mind want to subscribe
> >>> there.
> >>> 
> >>> Wido
> >>> 
>  Example header:
>  
>  From: serg38 
>  To: 
>  References: 
>  In-Reply-To: 
>  Subject: [GitHub] cloudstack issue #2044: CLOUDSTACK-9877 Cleanup
> >>> unlinked templates
>  
>  Content-type: text/plain;
>   charset="UTF-8"
>  Content-transfer-encoding: 7bit
>  
>  Github user serg38 commented on the issue:
>  
> https://github.com/apache/cloudstack/pull/2044
>  
>  
>  
>  On 4/16/17, 10:02 PM, "Rohit Yadav"  
wrote:
>  
> Thanks Wido!
>  
> 
> From: Wido den Hollander 
> Sent: 15 April 2017 15:59:33
> To: dev@cloudstack.apache.org
> Subject: [Github/Gitbox] Setting up your committer account
>  
> Hi,
>  
> Since yesterday we are using the Gitbox [0] services from ASF to
> >>> have Github our 'primary' source of code.
>  
> This means that we can now label PRs, merge them, close them, all
> >> on
> >>> Github.
>  
> If you are a committer you have to be added to the 'cloudstack
> >>> committers' team on Github and this is done automatically [1] once 
every
> >> X
> >>> hours.
>  
> You however need to make sure that your Apache Profile/ID [2] has
> >>> the right information and that you have 2FA [3] enabled on your Github
> >>> account.
>  
> The steps you need to take:
>  
> - Make sure you are a CloudStack committer
> - Make sure you have a Github account
> - Enable 2FA [3] on your Github account
> - Update your Apache profile [2] and add your Github username
>  
> Now, after a few hours the sync between ASF and Github should be
> >>> completed and you are added to the right team on Github.
>  
> If that doesn't work you might need to visit the Gitbox setup page
> >>> [4] to link your Apache account to Github.
>  
> Since we moved to Gitbox the URL of our Git repositories also
> >>> changed, for example:
>  
> - https://gitbox.apache.org/repos/asf/cloudstack.git
>  
> If you want RO you can also sync from Github:
>  
> - https://github.com/apache/cloudstack.git
>  
>  
> Once you are in the right group on Github you should be able to
> >>> label PRs, close them, merge them and move.
>  
> I have already created [5] a bunch of labels. If we all try to
> >> label
> >>> the PRs it will be much easier for people to filter PRs and review 
them.
>  
> Questions? Ask!
>  
> Wido
>  
> [0]: 

Re: PRs ready for merging into 4.10

2017-04-09 Thread Sateesh Chodapuneedi
Hi Rajani,
I will pickup CLOUDSTACK-9849.

Regards,
Sateesh
 

On 10/04/17, 11:21 AM, "Rajani Karuturi"  wrote:

@Nicolas and @Haijiao

Noted the PRs. I will see what all can be merged and do the
needful.

@All

Any takers for the VMware blocker (CLOUDSTACK-9849)?

Thanks,

~ Rajani

http://cloudplatform.accelerite.com/

On April 10, 2017 at 1:43 AM, Nicolas Vazquez
(nicovazque...@gmail.com) wrote:

Hi,

I would like to include PR 1935: CLOUDSTACK-9764: Delete domain
failure due
to Account Cleanup task, it has 2 LGTM.

Thanks

2017-04-08 1:32 GMT-03:00 Haijiao <18602198...@163.com>:

Update the PR list ready for merging.

--
#1886, CLOUDSTACK-9728: Fixed traffic sentinel HTTP 414 error
response
#1901, CLOUDSTACK-9405: add details parameter in listDomains API
to reduce
the execution time
#1903, CLOUDSTACK-9356: FIX Cannot add users in VPC VPN
#1955, CLOUDSTACK-8239 Add VirtIO SCSI support for KVM hosts
#1956, CLOUDSTACK-9796 - Fix NPE in
VirtualMachineManagerImpl.java
#1957, CLOUDSTACK-9748:VPN Users search functionality broken
#1980, CLOUDSTACK-9805: Display VR list in network details
#1993, CLOUDSTACK-8931: Fail to deploy VM instance when
use.system.public.ips�lse
#1970, CLOUDSTACK-9725 Failed to update VPC Network during N/w
offering
Upgrade which doesnt have ACL service Enabled.
#1978, CLOUDSTACK-9779 : Releasing secondary guest IP fails with
error VM
nic Ip x.x.x.x is mapped to load balancing rule
#2018, CLOUDSTACK-9848: Added exit status checking for the
iptables
commands
#2022, CLOUDSTACK-9591: Fix systemvmtemplate to not include
network details
#2024, CLOUDSTACK-9857: With this change if agent dies the
systemd will
catch it properly and show process as exited
#2025, Fix error in restart network in 4.10.0.0

Regards,

在2017年04月06 13时23分, "Rajani Karuturi"写道:

A quick update on RC2:

These are the current list of blockers.
https://github.com/apache/cloudstack/pull/2022
https://github.com/apache/cloudstack/pull/2025
https://issues.apache.org/jira/browse/CLOUDSTACK-9849
https://github.com/apache/cloudstack/pull/1582

I am planning to close all the PRs by weekend. The blockers
which Mike
reported is still open and needs a fix.
If everything is resolved, we can plan for RC2 on Monday.

~Rajani
http://cloudplatform.accelerite.com/

On Thu, Apr 6, 2017 at 10:50 AM, Rajani Karuturi

wrote:

Thanks for updating RN. Release notes is something which we
haven't

looked

at till now.
Any update on the xen 7.1 PR?

~Rajani
http://cloudplatform.accelerite.com/

On Mon, Apr 3, 2017 at 6:41 PM, Pierre-Luc Dion

wrote:

Look like we need a new systemvm named "systemvm-xenserver-4.10".
t also
seams that older VR ex: 4.7.x are still usable if the
globalsetting
"minreq.sysvmtemplate.version" is changed after the first boot
of
cloudstack-management that upgraded the database. I'll update
the

release

note acordingly...

So this 4.10 is looking promising! :-)

On Apr 1, 2017 16:02, "Pierre-Luc Dion" 
wrote:

I'm testing upgrade to 4.10 from latest master. I have the
following

error

when upgrading from 4.7.2 in management-server.log:

2017-04-01 15:58:12,558 DEBUG [c.c.u.d.Upgrade4920to41000]
(localhost-startStop-1:null) (logid:) Updating System Vm
template IDs
2017-04-01 15:58:12,561 DEBUG [c.c.u.d.Upgrade4920to41000]
(localhost-startStop-1:null) (logid:) Updating KVM System Vms
2017-04-01 15:58:12,561 WARN [c.c.u.d.Upgrade4920to41000]
(localhost-startStop-1:null) (logid:) 4.10.0.0KVM SystemVm
template not
found. KVM hypervisor is not used, so not failing upgrade
2017-04-01 15:58:12,562 DEBUG [c.c.u.d.Upgrade4920to41000]
(localhost-startStop-1:null) (logid:) Updating VMware System Vms
2017-04-01 15:58:12,563 WARN [c.c.u.d.Upgrade4920to41000]
(localhost-startStop-1:null) (logid:) 4.10.0.0VMware SystemVm
template

not

found. VMware hypervisor is not used, so not failing upgrade
2017-04-01 15:58:12,563 DEBUG [c.c.u.d.Upgrade4920to41000]
(localhost-startStop-1:null) (logid:) Updating XenServer System
Vms
2017-04-01 15:58:12,565 ERROR [c.c.u.DatabaseUpgradeChecker]
(localhost-startStop-1:null) (logid:) Unable to upgrade the
database
com.cloud.utils.exception.CloudRuntimeException:
4.10.0.0XenServer

[GitHub] cloudstack issue #1879: CLOUDSTACK-9719: [VMware] VR loses DHCP settings and...

2017-04-09 Thread sateesh-chodapuneedi
Github user sateesh-chodapuneedi commented on the issue:

https://github.com/apache/cloudstack/pull/1879
  
tag:mergeready


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #2022: [dvswitch blocker] CLOUDSTACK-9591: Fix systemvmtemp...

2017-04-07 Thread sateesh-chodapuneedi
Github user sateesh-chodapuneedi commented on the issue:

https://github.com/apache/cloudstack/pull/2022
  
>>Having this causes the ssvms to not deploy in dvswitch-based vmware 
environments that have no vswitch portgroups (dummy etc). 
@rhtyd can you please share the error/log messages for the deployment 
failures?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


Re: [VOTE] Retirement of midonet plugin

2017-03-29 Thread Sateesh Chodapuneedi
+1

Regards,
Sateesh 

From: Rafael Weingärtner 
Sent: 29 March 2017 02:16:09
To: dev@cloudstack.apache.org; us...@cloudstack.apache.org
Subject: [VOTE] Retirement of midonet plugin

Dear ACS fellows,
We have discussed the retirement of Midonet plugin [*]. After quite some
talk, we converged in a retirement process and it seems that we all agree
that the Midonet plugin should be retired. So, to formalize things, we
should vote Midonet retirement.

All users and devs are welcome to vote here:
[+1] I *do want to retire *the Midonet plugin
[0] Whatever happens I am happy
[-1] I *do not want to retire* the Midonet plugin


[*] http://markmail.org/message/x6p3gnvqbbxcj6gs

--
Rafael Weingärtner

rohit.ya...@shapeblue.com 
www.shapeblue.com
53 Chandos Place, Covent Garden, London  WC2N 4HSUK
@shapeblue
  
 






DISCLAIMER
==
This e-mail may contain privileged and confidential information which is the 
property of Accelerite, a Persistent Systems business. It is intended only for 
the use of the individual or entity to which it is addressed. If you are not 
the intended recipient, you are not authorized to read, retain, copy, print, 
distribute or use this message. If you have received this communication in 
error, please notify the sender and delete all copies of this message. 
Accelerite, a Persistent Systems business does not accept any liability for 
virus infected mails.


Re: Cannot migrate VMware VM with root disk to host in different cluster (CloudStack 4.10)

2017-03-23 Thread Sateesh Chodapuneedi
>>On 24/03/17, 1:51 AM, "Tutkowski, Mike" <mike.tutkow...@netapp.com> wrote:

>>Thanks, Simon
>>I wonder if we support that in CloudStack.

IIRC, CloudStack supports this. I am testing this out in my 4.10 environment, 
will update shortly.

Regards,
Sateesh

On 3/23/17, 2:18 PM, "Simon Weller" <swel...@ena.com> wrote:

Mike,


It is possible to do this on vcenter, but it requires a special license 
I believe.


Here's the info on it :


https://pubs.vmware.com/vsphere-51/index.jsp#com.vmware.vsphere.vcenterhost.doc/GUID-A16BA123-403C-4D13-A581-DC4062E11165.html


https://pubs.vmware.com/vsphere-51/index.jsp#com.vmware.vsphere.vcenterhost.doc/GUID-561681D9-6511-44DF-B169-F20E6CA94944.html


- Si

From: Tutkowski, Mike <mike.tutkow...@netapp.com>
Sent: Thursday, March 23, 2017 3:09 PM
To: dev@cloudstack.apache.org
Subject: Re: Cannot migrate VMware VM with root disk to host in 
different cluster (CloudStack 4.10)

This is interesting:

If I shut the VM down and then migrate its root disk to storage in the 
other cluster, then start up the VM, the VM gets started up correctly (running 
on the new host using the other datastore).

Perhaps you simply cannot live migrate a VM and its storage from one 
cluster to another with VMware? This works for XenServer and I probably just 
assumed it would work in VMware, but maybe it doesn’t?

The reason I’m asking now is because I’m investigating the support of 
cross-cluster migration of a VM that uses managed storage. This works for 
XenServer as of 4.9 and I was looking to implement similar functionality for 
VMware.

On 3/23/17, 2:01 PM, "Tutkowski, Mike" <mike.tutkow...@netapp.com> 
wrote:

Another piece of info:

I tried this same VM + storage migration using NFS for both 
datastores instead of iSCSI for both datastores and it failed with the same 
error message:

Required property datastore is missing from data object of type 
VirtualMachineRelocateSpecDiskLocator

while parsing serialized DataObject of type 
vim.vm.RelocateSpec.DiskLocator
at line 1, column 326

while parsing property "disk" of static type 
ArrayOfVirtualMachineRelocateSpecDiskLocator

while parsing serialized DataObject of type vim.vm.RelocateSpec
at line 1, column 187

while parsing call information for method RelocateVM_Task
at line 1, column 110

while parsing SOAP body
at line 1, column 102

while parsing SOAP envelope
at line 1, column 38

while parsing HTTP request for method relocate
on object of type vim.VirtualMachine
at line 1, column 0

On 3/23/17, 12:33 PM, "Tutkowski, Mike" <mike.tutkow...@netapp.com> 
wrote:

Slight typo:

Both ESXi hosts are version 5.5 and both clusters are within 
the same VMware datastore.

Should be (datastore changed to datacenter):

Both ESXi hosts are version 5.5 and both clusters are within 
the same VMware datacenter.

On 3/23/17, 12:31 PM, "Tutkowski, Mike" 
<mike.tutkow...@netapp.com> wrote:

A little update here:

In the debugger, I made sure we asked for the correct 
source datastore (I edited the UUID we were using for the source datastore).

When VirtualMachineMO.changeDatastore is later invoked 
having the proper source and target datastores, I now see this error message:

Virtual disk 'Hard disk 1' is not accessible on the host: 
Unable to access file [SIOC-1]

Both ESXi hosts are version 5.5 and both clusters are 
within the same VMware datastore.

The source datastore and the target datastore are both 
using iSCSI.

On 3/23/17, 11:53 AM, "Tutkowski, Mike" 
<mike.tutkow...@netapp.com> wrote:

Also, in case it matters, both datastores are iSCSI 
based.

> On Mar 23, 2017, at 11:52 AM, Tutkowski, Mike 
<mike.tutkow...@netapp.com> wrote:
>
        > My version is 5.5 in both clusters.
>
>> On Mar 23, 2017, at 9:48 AM, Sateesh Chodapuneedi 
<sateesh.chodapune...@ac

Re: Cannot migrate VMware VM with root disk to host in different cluster (CloudStack 4.10)

2017-03-23 Thread Sateesh Chodapuneedi
ect of type 
vim.vm.RelocateSpec
>at line 1, column 187
> 
>while parsing call information for method 
RelocateVM_Task
>at line 1, column 110
> 
>while parsing SOAP body
>at line 1, column 102
> 
>while parsing SOAP envelope
>at line 1, column 38
> 
>while parsing HTTP request for method relocate
>on object of type vim.VirtualMachine
>at line 1, column 0
> 
>On 3/23/17, 12:33 PM, "Tutkowski, Mike" 
<mike.tutkow...@netapp.com> wrote:
> 
>Slight typo:
> 
>Both ESXi hosts are version 5.5 and both clusters 
are within the same VMware datastore.
> 
>Should be (datastore changed to datacenter):
> 
>Both ESXi hosts are version 5.5 and both clusters 
are within the same VMware datacenter.
> 
>On 3/23/17, 12:31 PM, "Tutkowski, Mike" 
<mike.tutkow...@netapp.com> wrote:
> 
>A little update here:
> 
>In the debugger, I made sure we asked for the 
correct source datastore (I edited the UUID we were using for the source 
datastore).
> 
>When VirtualMachineMO.changeDatastore is later 
invoked having the proper source and target datastores, I now see this error 
message:
> 
>Virtual disk 'Hard disk 1' is not accessible 
on the host: Unable to access file [SIOC-1]
> 
>Both ESXi hosts are version 5.5 and both 
clusters are within the same VMware datastore.
> 
>        The source datastore and the target datastore 
are both using iSCSI.
> 
>On 3/23/17, 11:53 AM, "Tutkowski, Mike" 
<mike.tutkow...@netapp.com> wrote:
> 
>Also, in case it matters, both datastores 
are iSCSI based.
> 
>> On Mar 23, 2017, at 11:52 AM, Tutkowski, Mike 
<mike.tutkow...@netapp.com> wrote:
>> 
>> My version is 5.5 in both clusters.
>> 
>>> On Mar 23, 2017, at 9:48 AM, Sateesh Chodapuneedi 
<sateesh.chodapune...@accelerite.com> wrote:
>>> 
>>> 
>>>>> On 23/03/17, 7:21 PM, "Tutkowski, Mike" <mike.tutkow...@netapp.com> 
wrote:
>>> 
>>>>> However, perhaps someone can clear this up for me:
>>>>> With XenServer, we are able to migrate a VM and its volumes from a 
host using a shared SR in one cluster to a host using a shared SR in another 
cluster even though the source host can’t see the target SR.
>>>>> Is the same thing possible with VMware or does the source host have 
to be able to see the target datastore? If so, does that mean the target 
datastore has to be zone-wide primary storage when using VMware to make this 
work?
>>> Yes, Mike. But that’s the case with versions less than 5.1 only. In 
vSphere 5.1 and later, vMotion does not require environments with shared 
storage. This is useful for performing cross-cluster migrations, when the 
target cluster machines might not have access to the source cluster's storage.
>>> BTW, what is the version of ESXi hosts in this setup?
>>> 
>>> Regards,
>>> Sateesh,
>>> CloudStack development,
>>> Accelerite, CA-95054
>>> 
>>>  On 3/23/17, 7:47 AM, "Tutkowski, Mike" <mike.tutkow...@netapp.com> 
wrote:
>>> 
>>>  This looks a little suspicious to me (in VmwareResource before we 
call VirtualMachineMO.changeDatastore):
>>> 
>>>  morDsAtTarget = 
HypervisorHostHelper.findDatastoreWithBackwardsCompatibility(tgtHyperHost, 
filerTo.getUuid());
>>>  morDsAtSource = 
HypervisorHostHelper.findDatastoreWithBackwardsCompatibility(srcHyperHost, 
filerTo.getUuid());
>>>  if (morDsAtTarget == null) {
>>>  String msg = "Unable to find the target 
datastore: " + filerTo.getUuid() + " on target host: " + 
tgtHyperHost.getHyperHostName() + " to execute MigrateWithStorageCommand";
>>>  s_logger.error(msg);
>>>  throw new 

Re: Cannot migrate VMware VM with root disk to host in different cluster (CloudStack 4.10)

2017-03-23 Thread Sateesh Chodapuneedi

>> On 23/03/17, 7:21 PM, "Tutkowski, Mike"  wrote:

>>However, perhaps someone can clear this up for me:   
>>With XenServer, we are able to migrate a VM and its volumes from a host using 
>>a shared SR in one cluster to a host using a shared SR in another cluster 
>>even though the source host can’t see the target SR.
>>Is the same thing possible with VMware or does the source host have to be 
>>able to see the target datastore? If so, does that mean the target datastore 
>>has to be zone-wide primary storage when using VMware to make this work?
Yes, Mike. But that’s the case with versions less than 5.1 only. In vSphere 5.1 
and later, vMotion does not require environments with shared storage. This is 
useful for performing cross-cluster migrations, when the target cluster 
machines might not have access to the source cluster's storage.
BTW, what is the version of ESXi hosts in this setup? 

Regards,
Sateesh,
CloudStack development,
Accelerite, CA-95054

On 3/23/17, 7:47 AM, "Tutkowski, Mike"  wrote:

This looks a little suspicious to me (in VmwareResource before we call 
VirtualMachineMO.changeDatastore):

morDsAtTarget = 
HypervisorHostHelper.findDatastoreWithBackwardsCompatibility(tgtHyperHost, 
filerTo.getUuid());
morDsAtSource = 
HypervisorHostHelper.findDatastoreWithBackwardsCompatibility(srcHyperHost, 
filerTo.getUuid());
if (morDsAtTarget == null) {
String msg = "Unable to find the target datastore: 
" + filerTo.getUuid() + " on target host: " + tgtHyperHost.getHyperHostName() + 
" to execute MigrateWithStorageCommand";
s_logger.error(msg);
throw new Exception(msg);
}

We use filerTo.getUuid() when trying to get a pointer to both the 
target and source datastores. Since filerTo.getUuid() has the UUID for the 
target datastore, that works for morDsAtTarget, but morDsAtSource ends up being 
null.

For some reason, we only check if morDsAtTarget is null (I’m not sure 
why we don’t check if morDsAtSource is null, too).

On 3/23/17, 7:31 AM, "Tutkowski, Mike"  
wrote:

Hi,

The CloudStack API that the GUI is invoking is 
migrateVirtualMachineWithVolume (which is expected since I’m asking to migrate 
a VM from a host in one cluster to a host in another cluster).

A MigrateWithStorageCommand is sent to VmwareResource, which 
eventually calls VirtualMachineMO.changeDatastore.

public boolean changeDatastore(VirtualMachineRelocateSpec 
relocateSpec) throws Exception {
ManagedObjectReference morTask = 
_context.getVimClient().getService().relocateVMTask(_mor, relocateSpec, 
VirtualMachineMovePriority.DEFAULT_PRIORITY);
boolean result = 
_context.getVimClient().waitForTask(morTask);
if (result) {
_context.waitForTaskProgressDone(morTask);
return true;
} else {
s_logger.error("VMware RelocateVM_Task to change 
datastore failed due to " + TaskMO.getTaskFailureInfo(_context, morTask));
}
return false;
}

The parameter, VirtualMachineRelocateSpec, looks like this:

http://imgur.com/a/vtKcq (datastore-66 is the target datastore)

The following error message is returned:

Required property datastore is missing from data object of type 
VirtualMachineRelocateSpecDiskLocator

while parsing serialized DataObject of type 
vim.vm.RelocateSpec.DiskLocator
at line 1, column 327

while parsing property "disk" of static type 
ArrayOfVirtualMachineRelocateSpecDiskLocator

while parsing serialized DataObject of type vim.vm.RelocateSpec
at line 1, column 187

while parsing call information for method RelocateVM_Task
at line 1, column 110

while parsing SOAP body
at line 1, column 102

while parsing SOAP envelope
at line 1, column 38

while parsing HTTP request for method relocate
on object of type vim.VirtualMachine
at line 1, column 0

Thoughts?

Thanks!
Mike

On 3/22/17, 11:50 PM, "Sergey Levitskiy" 
 wrote:


Can you trace which API call being used and what parameters 
were specified? 

[GitHub] cloudstack issue #1868: CLOUDSTACK-9707: While using hostid parameter, vm ge...

2017-03-09 Thread sateesh-chodapuneedi
Github user sateesh-chodapuneedi commented on the issue:

https://github.com/apache/cloudstack/pull/1868
  
The point of specifying a host is in deploy request itself means 
inclination towards using that host for instance. Hence I think default value 
should be false. 
While global setting makes sense, rather than a global setting, it would be 
better to add optional parameter in API itself which indicates whether deploy 
should strictly try deployment on specific host, if any, or look for other 
hosts as well. That way more granular control in case by case perspective.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


Re: :[VOTE] Apache Cloudstack 4.10.0.0

2017-03-07 Thread Sateesh Chodapuneedi
Hi Mike,
Is there any volume snapshot operation in progress for that ROOT volume, when 
resize is attempted?

Regards,
Sateesh
 

On 07/03/17, 8:40 PM, "Tutkowski, Mike"  wrote:

No VM snapshot.

I tried while the VM was in the Running state and then I also tried in the 
Stopped state. Same results.

> On Mar 7, 2017, at 7:54 AM, Sergey Levitskiy 
 wrote:
> 
> Is VM has an VMsnaphsot? Is VM in Stopped state?
> 
> On 3/6/17, 10:32 PM, "Tutkowski, Mike"  wrote:
> 
>I seem to have found another blocker:
> 
>https://issues.apache.org/jira/browse/CLOUDSTACK-9822
> 
>On 3/6/17, 9:51 PM, "Rajani Karuturi"  wrote:
> 
>PRs are ready for the blockers. Waiting for reviews and test
>results. Once they are ready, I will merge them(and a few more
>bug fixes) and create RC2 (probably tomorrow, Wednesday)
> 
>Thanks,
> 
>~ Rajani
> 
>http://cloudplatform.accelerite.com/
> 
>On March 3, 2017 at 4:30 PM, Rajani Karuturi (raj...@apache.org)
>wrote:
> 
>I will create RC2 on Monday with the fixes mentioned in my
>previous mail.
> 
>~ Rajani
> 
>http://cloudplatform.accelerite.com/
> 
>On March 3, 2017 at 2:36 PM, Rohit Yadav
>(rohit.ya...@shapeblue.com) wrote:
> 
>Thanks Koushik, I did not realize Kishan had sent this already.
>Let's get either of the PRs merged and kick a RC2.
> 
>Regards.
> 
>
>From: Koushik Das 
>Sent: 03 March 2017 14:14:56
>To: dev@cloudstack.apache.org
>Subject: Re: :[VOTE] Apache Cloudstack 4.10.0.0
> 
>Looks like there is already a PR for the same issue
>https://github.com/apache/cloudstack/pull/1982 from Kishan.
> 
>-Koushik
> 
>On 03/03/17, 1:58 PM, "Rohit Yadav" 
>wrote:
> 
>-1 (binding)
> 
>All, I've found an upgrade blocker. Pre 4.6 users are required
>to seed 4.6 systemvmtemplate to proceed with the upgrade
>otherwise upgrade fails, and from 4.9 upgrade to 4.10 does no
>check/enforcement that 4.10 based systemvmtemplate has been
>seeded/registered, nor the minimum required systemvmtemplate
>version is changed from 4.6.0 to 4.10.0.
> 
>After we have merged the strongswan/java8 PR, I had updated the
>upgrade docs on how to upgrade the systemvmtemplate here:
> 
>
http://docs.cloudstack.apache.org/projects/cloudstack-release-notes/en/4.10/upgrade/upgrade-4.9.html
> 
>Using the above, I've tried to fix these issues here, please
>review and merge for RC2:
> 
>https://github.com/apache/cloudstack/pull/1983
> 
>With above fix,
>the aim is that users only seed the 4.10 systemvmtemplate before
>upgrade and post-upgrade the upgrade paths fix the entries,
>global setting etc.
> 
>Regards.
> 
>
>From: Tutkowski, Mike 
>Sent: 02 March 2017 22:39:08
>To: dev@cloudstack.apache.org
>Subject: Re: :[VOTE] Apache Cloudstack 4.10.0.0
> 
>I rolled back to my master branch at
>da66b06e7d562393da2e4b52206943f8bad49d10 and it works.
> 
>It appears something that went into after that commit has broken
>this. It looks like this SHA is about two weeks old and that 43
>commits have gone into master since it.
> 
>On 3/2/17, 7:06 AM, "Tutkowski, Mike"
> wrote:
> 
>According to where the code fails, though, it appears to be a
>networking problem. If I set a breakpoint before the failure and
>change a variable to say that security groups are not being used,
>then the VM starts.
> 
>I think this is a recently introduced problem because I have
>another branch based off of a slightly older version of master
>and it works fine here.
> 
>> On Mar 2, 2017, at 6:51 AM, Pierre-Luc Dion
> wrote:
>> 
>> Hi Mike,
>> Try vm with at least 512MB for memory.
>> 
>>> On Mar 1, 2017 15:01, "Tutkowski, Mike"
> wrote:
>>> 
>>> I see the following exception when trying to deploy a user 

[GitHub] cloudstack issue #1776: CLOUDSTACK-9603: 'concurrent.snapshots.threshold.per...

2017-03-05 Thread sateesh-chodapuneedi
Github user sateesh-chodapuneedi commented on the issue:

https://github.com/apache/cloudstack/pull/1776
  
tag:mergeready


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1862: CLOUDSTACK-9704 Remove dependency on VmwareContext o...

2017-03-04 Thread sateesh-chodapuneedi
Github user sateesh-chodapuneedi commented on the issue:

https://github.com/apache/cloudstack/pull/1862
  
tag:mergeready


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1776: CLOUDSTACK-9603: 'concurrent.snapshots.threshold.per...

2017-03-03 Thread sateesh-chodapuneedi
Github user sateesh-chodapuneedi commented on the issue:

https://github.com/apache/cloudstack/pull/1776
  
@borisstoyanov Can you please trigger tests for this PR? Tests could be 
over any hypervisor/simulator as the fix is pretty generic.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1862: CLOUDSTACK-9704 Remove dependency on VmwareContext o...

2017-03-03 Thread sateesh-chodapuneedi
Github user sateesh-chodapuneedi commented on the issue:

https://github.com/apache/cloudstack/pull/1862
  
Thanks @borisstoyanov 

The 3 test failures listed in results doesn't seem related to the code 
changes in PR. 

```
2017-03-02 17:45:11,699 - CRITICAL - EXCEPTION: 
test_02_list_snapshots_with_removed_data_store: ['Traceback (most recent call 
last):\n', '  File "/usr/lib64/python2.7/unittest/case.py", line 369, in run\n  
  testMethod()\n', '  File 
"/usr/lib/python2.7/site-packages/marvin/lib/decoratorGenerators.py", line 30, 
in test_wrapper\nreturn test(self, *args, **kwargs)\n', '  File 
"/marvin/tests/smoke/test_snapshots.py", line 363, in 
test_02_list_snapshots_with_removed_data_store\nid=snapshot.id\n', '  File 
"/usr/lib/python2.7/site-packages/marvin/lib/base.py", line 1125, in list\n
return(apiclient.listSnapshots(cmd))\n', '  File 
"/usr/lib/python2.7/site-packages/marvin/cloudstackAPI/cloudstackAPIClient.py", 
line 1161, in listSnapshots\nresponse = 
self.connection.marvinRequest(command, response_type=response, 
method=method)\n', '  File 
"/usr/lib/python2.7/site-packages/marvin/cloudstackConnection.py", line 379, in 
marvinRequest\nraise e\n', 'CloudstackAPIException: Exe
 cute cmd: listsnapshots failed, due to: errorCode: 530, errorText:Unable to 
locate datastore with id 5\n']

2017-03-02 17:45:16,772 - CRITICAL - EXCEPTION: 
test_02_list_snapshots_with_removed_data_store: ['Traceback (most recent call 
last):\n', '  File "/usr/lib64/python2.7/unittest/case.py", line 398, in run\n  
  self.tearDown()\n', '  File "/marvin/tests/smoke/test_snapshots.py", line 
174, in tearDown\nraise Exception("Warning: Exception during cleanup : %s" 
% e)\n', "Exception: Warning: Exception during cleanup : Job failed: 
{jobprocstatus : 0, created : u'2017-03-02T17:45:13+', jobresult : 
{errorcode : 431, errortext : u'Unable to find a virtual machine with specified 
vmId'}, cmd : 
u'org.apache.cloudstack.api.command.admin.vm.DestroyVMCmdByAdmin', userid : 
u'87233b2e-ff35-11e6-be08-06674c01070f', jobstatus : 2, jobid : 
u'43f0ee45-e763-45bc-b777-795c7eaeb26a', jobresultcode : 530, jobinstanceid : 
u'3be27ffe-1884-493b-9566-e616cf2d85d0', jobresulttype : u'object', 
jobinstancetype : u'VirtualMachine', accountid : 
u'872334ae-ff35-11e6-be08-06674c01070f'}\n"]

2017-03-02 17:45:41,985 - CRITICAL - EXCEPTION: 
test_02_list_snapshots_with_removed_data_store: ['Traceback (most recent call 
last):\n', '  File "/usr/lib/python2.7/site-packages/nose/suite.py", line 228, 
in run\nself.tearDown()\n', '  File 
"/usr/lib/python2.7/site-packages/nose/suite.py", line 351, in tearDown\n
self.teardownContext(ancestor)\n', '  File 
"/usr/lib/python2.7/site-packages/nose/suite.py", line 367, in 
teardownContext\ntry_run(context, names)\n', '  File 
"/usr/lib/python2.7/site-packages/nose/util.py", line 471, in try_run\n
return func()\n', '  File "/marvin/tests/smoke/test_snapshots.py", line 160, in 
tearDownClass\nraise Exception("Warning: Exception during cleanup : %s" % 
e)\n', "Exception: Warning: Exception during cleanup : Job failed: 
{jobprocstatus : 0, created : u'2017-03-02T17:45:39+', jobresult : 
{errorcode : 530, errortext : u'Failed to delete template'}, cmd : 
u'org.apache.cloudstack.api.command.user.template.DeleteTemplateCmd', u
 serid : u'87233b2e-ff35-11e6-be08-06674c01070f', jobstatus : 2, jobid : 
u'df91fb7f-b9fd-4b9f-8d07-654821c42d69', jobresultcode : 530, jobinstanceid : 
u'5fc32822-46b8-43e9-ac33-8ad5bb00e775', jobresulttype : u'object', 
jobinstancetype : u'Template', accountid : 
u'872334ae-ff35-11e6-be08-06674c01070f'}\n"]

```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1861: CLOUDSTACK-9698 [VMware] Make hardcorded wait timeou...

2017-03-02 Thread sateesh-chodapuneedi
Github user sateesh-chodapuneedi commented on the issue:

https://github.com/apache/cloudstack/pull/1861
  
Hi @karuturi This has test results as well as 2 LGTMs. I think this can be 
merged.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1861: CLOUDSTACK-9698 [VMware] Make hardcorded wait timeou...

2017-03-02 Thread sateesh-chodapuneedi
Github user sateesh-chodapuneedi commented on the issue:

https://github.com/apache/cloudstack/pull/1861
  
@harikrishna-patnala Thanks. Did not make the parameter as dynamic, to 
avoid unexpected timeout errors upon timeout changes, for those VPC tier 
configurations in progress.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1861: CLOUDSTACK-9698 [VMware] Make hardcorded wait timeou...

2017-03-02 Thread sateesh-chodapuneedi
Github user sateesh-chodapuneedi commented on the issue:

https://github.com/apache/cloudstack/pull/1861
  
Yes, @karuturi rebased with latest master. And changed base branch of this 
PR to master. Please review.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1862: CLOUDSTACK-9704 Remove dependency on VmwareContext o...

2017-03-02 Thread sateesh-chodapuneedi
Github user sateesh-chodapuneedi commented on the issue:

https://github.com/apache/cloudstack/pull/1862
  
@borisstoyanov @borisroman Can you please run trillian tests for this PR?
This already has enough code LGTMs, and needs tests for merge.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1872: CLOUDSTACK-3223 Exception observed while creating CP...

2017-03-02 Thread sateesh-chodapuneedi
Github user sateesh-chodapuneedi commented on the issue:

https://github.com/apache/cloudstack/pull/1872
  
@ping sureshanaparti @anshul1886


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1841: CLOUDSTACK-9684 Invalid zone id error while listing ...

2017-03-02 Thread sateesh-chodapuneedi
Github user sateesh-chodapuneedi commented on the issue:

https://github.com/apache/cloudstack/pull/1841
  
@karuturi Checked the tests errors, they seem to be unrelated to this PR 
code fix.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request #1841: CLOUDSTACK-9684 Invalid zone id error while l...

2017-03-02 Thread sateesh-chodapuneedi
Github user sateesh-chodapuneedi commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1841#discussion_r103883712
  
--- Diff: 
plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/manager/VmwareManagerImpl.java
 ---
@@ -1180,10 +1180,7 @@ public void 
doInTransactionWithoutResult(TransactionStatus status) {
 
 private void validateZone(Long zoneId) throws 
InvalidParameterValueException {
--- End diff --

No, this method is being used in other part of code. This method does more 
than zone existence check.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #815: CLOUDSTACK-8841: Storage XenMotion from XS 6.2 to XS ...

2017-02-27 Thread sateesh-chodapuneedi
Github user sateesh-chodapuneedi commented on the issue:

https://github.com/apache/cloudstack/pull/815
  
@karuturi This seems to be ready for merge.
It has 2 LGTMs and tests passed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1253: CLOUDSTACK-9184: [VMware] vmware.ports.per.dvportgro...

2017-02-26 Thread sateesh-chodapuneedi
Github user sateesh-chodapuneedi commented on the issue:

https://github.com/apache/cloudstack/pull/1253
  
@sureshanaparti Can you please investigate the two failures listed in 
results from @cloudmonger?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1257: CLOUDSTACK-9175: [VMware DRS] Adding new host to DRS...

2017-02-26 Thread sateesh-chodapuneedi
Github user sateesh-chodapuneedi commented on the issue:

https://github.com/apache/cloudstack/pull/1257
  
@karuturi @koushik This has 1 LGTM and test results without any failures.
Can you please review this?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1900: CLOUDSTACK-8862: Introduced new state attaching for ...

2017-02-25 Thread sateesh-chodapuneedi
Github user sateesh-chodapuneedi commented on the issue:

https://github.com/apache/cloudstack/pull/1900
  
LGTM for code changes.
Thanks @anshul1886 for the path.

@karuturi Seems this PR is ready for merge, as it has 2 LGTMs and latest 
test results from @cloudmonger has 0 failures.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1880: CLOUDSTACK-9720: [VMware] template_spool_ref table i...

2017-02-24 Thread sateesh-chodapuneedi
Github user sateesh-chodapuneedi commented on the issue:

https://github.com/apache/cloudstack/pull/1880
  
LGTM for code changes.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1861: CLOUDSTACK-9698 [VMware] Make hardcorded wait timeou...

2017-02-21 Thread sateesh-chodapuneedi
Github user sateesh-chodapuneedi commented on the issue:

https://github.com/apache/cloudstack/pull/1861
  
ping @karuturi @koushik-das 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1861: CLOUDSTACK-9698 [VMware] Make hardcorded wait timeou...

2017-02-21 Thread sateesh-chodapuneedi
Github user sateesh-chodapuneedi commented on the issue:

https://github.com/apache/cloudstack/pull/1861
  
@borisstoyanov, thanks for running tets.

I see 1 test error in the above results, this test has been failing in many 
other PRs as well, and doesn't seem related to changes here?

`2017-02-21 00:56:54,625 - CRITICAL - FAILED: 
test_04_rvpc_privategw_static_routes: ['Traceback (most recent call last):\n', 
'  File "/usr/lib64/python2.7/unittest/case.py", line 369, in run\n
testMethod()\n', '  File "/marvin/tests/smoke/test_privategw_acl.py", line 295, 
in test_04_rvpc_privategw_static_routes\nself.performVPCTests(vpc_off)\n', 
'  File "/marvin/tests/smoke/test_privategw_acl.py", line 362, in 
performVPCTests\nself.check_pvt_gw_connectivity(vm1, public_ip_1, 
[vm2.nic[0].ipaddress, vm1.nic[0].ipaddress])\n', '  File 
"/marvin/tests/smoke/test_privategw_acl.py", line 724, in 
check_pvt_gw_connectivity\n"Ping to VM on Network Tier N from VM in Network 
Tier A should be successful at least for 2 out of 3 VMs"\n', '  File 
"/usr/lib64/python2.7/unittest/case.py", line 462, in assertTrue\nraise 
self.failureException(msg)\n', 'AssertionError: Ping to VM on Network Tier N 
from VM in Network Tier A should be successful at least for 2 out of 3 VMs\n']
`


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1872: CLOUDSTACK-3223 Exception observed while creating CP...

2017-02-20 Thread sateesh-chodapuneedi
Github user sateesh-chodapuneedi commented on the issue:

https://github.com/apache/cloudstack/pull/1872
  
@borisstoyanov Can you please run trillian tests for this PR?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1861: CLOUDSTACK-9698 [VMware] Make hardcorded wait timeou...

2017-02-20 Thread sateesh-chodapuneedi
Github user sateesh-chodapuneedi commented on the issue:

https://github.com/apache/cloudstack/pull/1861
  
@borisstoyanov Can you please run trillian tests for this PR?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1841: CLOUDSTACK-9684 Invalid zone id error while listing ...

2017-02-20 Thread sateesh-chodapuneedi
Github user sateesh-chodapuneedi commented on the issue:

https://github.com/apache/cloudstack/pull/1841
  
@borisstoyanov Can you please run trillian tests for this PR?
This already has enough code LGTMs, and needs tests for merge.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1862: CLOUDSTACK-9704 Remove dependency on VmwareContext o...

2017-02-20 Thread sateesh-chodapuneedi
Github user sateesh-chodapuneedi commented on the issue:

https://github.com/apache/cloudstack/pull/1862
  
@borisstoyanov Can you please run trillian tests for this PR?
This already has enough code LGTMs, and needs tests for merge.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1847: CLOUDSTACK-9691: Fixed unhandeled excetion in list s...

2017-01-05 Thread sateesh-chodapuneedi
Github user sateesh-chodapuneedi commented on the issue:

https://github.com/apache/cloudstack/pull/1847
  
@karuturi Seems this is ready for merge, with code LGTMs and based on test 
results published by @cloudmonger ?
The 4 test failures seems not relevant to this patch  with code changes in 
API layer.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1862: CLOUDSTACK-9704 Remove dependency on VmwareContext o...

2017-01-04 Thread sateesh-chodapuneedi
Github user sateesh-chodapuneedi commented on the issue:

https://github.com/apache/cloudstack/pull/1862
  
ping @anshulgangwar @karuturi 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request #1861: CLOUDSTACK-9698 Make hardcorded wait timeout ...

2016-12-30 Thread sateesh-chodapuneedi
Github user sateesh-chodapuneedi commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1861#discussion_r94216180
  
--- Diff: 
plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java
 ---
@@ -230,6 +230,7 @@
 import com.cloud.hypervisor.guru.VMwareGuru;
 import com.cloud.hypervisor.vmware.manager.VmwareHostService;
 import com.cloud.hypervisor.vmware.manager.VmwareManager;
+import com.cloud.hypervisor.vmware.manager.VmwareManagerImpl;
--- End diff --

Yes, moved the parameter to VmwareManager itself.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request #1861: CLOUDSTACK-9698 Make hardcorded wait timeout ...

2016-12-30 Thread sateesh-chodapuneedi
Github user sateesh-chodapuneedi commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1861#discussion_r94216151
  
--- Diff: 
plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/manager/VmwareManagerImpl.java
 ---
@@ -123,12 +125,14 @@
 import com.cloud.utils.ssh.SshHelper;
 import com.cloud.vm.DomainRouterVO;
 
-public class VmwareManagerImpl extends ManagerBase implements 
VmwareManager, VmwareStorageMount, Listener, VmwareDatacenterService {
+public class VmwareManagerImpl extends ManagerBase implements 
VmwareManager, VmwareStorageMount, Listener, VmwareDatacenterService, 
Configurable {
 private static final Logger s_logger = 
Logger.getLogger(VmwareManagerImpl.class);
 
 private static final int STARTUP_DELAY = 6; // 60 
seconds
 private static final long DEFAULT_HOST_SCAN_INTERVAL = 60; // 
every 10 minutes
 
+public static final ConfigKey s_vmwareNicHotplugWaitTimeout = 
new ConfigKey("Advanced", Long.class, "vmware.nic.hotplug.wait.timeout", 
"2",
--- End diff --

Yes, preivously it was intended, as this is just timeout value in cases 
that need more time for hotplug device detection and doesn't introduce delay in 
regular scenarios.

But left it as 15000, just keep the default behavior intact. If require 
admin may modify the configuration parameter per their environment's 
requirements. Pushed the updated code change.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1841: CLOUDSTACK-9684 Invalid zone id error while listing ...

2016-12-30 Thread sateesh-chodapuneedi
Github user sateesh-chodapuneedi commented on the issue:

https://github.com/apache/cloudstack/pull/1841
  
Thanks @sureshanaparti 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request #1862: CLOUDSTACK-9704 Remove dependency on VmwareCo...

2016-12-30 Thread sateesh-chodapuneedi
Github user sateesh-chodapuneedi commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1862#discussion_r94214404
  
--- Diff: 
plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java
 ---
@@ -5620,4 +5623,39 @@ private String getAbsoluteVmdkFile(VirtualDisk disk) 
{
 }
 return vmdkAbsFile;
 }
+
+protected File getSystemVmKeyFile() {
+if (s_systemVmKeyFile == null) {
+syncFetchSystemVmKeyFile();
+}
+return s_systemVmKeyFile;
+}
+
+private static void syncFetchSystemVmKeyFile() {
+synchronized (s_syncLockObjectFetchKeyFile) {
+if (s_systemVmKeyFile == null) {
+s_systemVmKeyFile = fetchSystemVmKeyFile();
+}
+}
+}
+
+private static File fetchSystemVmKeyFile() {
+String filePath = s_relativePathSystemVmKeyFileInstallDir;
+s_logger.debug("Looking for file [" + filePath + "] in the 
classpath.");
+URL url = Script.class.getClassLoader().getResource(filePath);
+File keyFile = null;
+if (url != null) {
+keyFile = new File(url.getPath());
+}
+if (keyFile == null || !keyFile.exists()) {
+filePath = s_defaultPathSystemVmKeyFile;
+keyFile = new File(filePath);
+s_logger.debug("Looking for file [" + filePath + "] in the 
classpath.");
+}
+assert (keyFile != null);
--- End diff --

Thanks @sureshanaparti for review.
I have addressed that now. Pushed the code changes, please check.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1862: CLOUDSTACK-9704 Remove dependency on VmwareContext o...

2016-12-30 Thread sateesh-chodapuneedi
Github user sateesh-chodapuneedi commented on the issue:

https://github.com/apache/cloudstack/pull/1862
  
Thanks @sureshanaparti for review.
I have addressed that now. Pushed the code changes, please check.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #775: CLOUDSTACK-8805: Domains become inactive automaticall...

2016-12-30 Thread sateesh-chodapuneedi
Github user sateesh-chodapuneedi commented on the issue:

https://github.com/apache/cloudstack/pull/775
  
LGTM for code. Looks like tests are successful too based on results 
published by @bvbharatk 
@karuturi Should we consider this for merge OR re-run tests again as the 
previous tests were some time back in june, 2016?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1758: CLOUDSTACK-9588: Add Load Balancer functionality in ...

2016-12-30 Thread sateesh-chodapuneedi
Github user sateesh-chodapuneedi commented on the issue:

https://github.com/apache/cloudstack/pull/1758
  
@nitin-maharana LGTM for code.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1881: CLOUDSTACK-9721: Remove deprecated/unused global con...

2016-12-30 Thread sateesh-chodapuneedi
Github user sateesh-chodapuneedi commented on the issue:

https://github.com/apache/cloudstack/pull/1881
  
@karuturi As this PR is about removal of a deprecated configuration setting 
which is no more referenced any where in the repo, can we merge this without 
functional tests?
Or we could make this PR part of a place holder PR so that we can trigger 
trillian tests more multiple PRs at once?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1880: CLOUDSTACK-9720: [VMware] template_spool_ref table i...

2016-12-30 Thread sateesh-chodapuneedi
Github user sateesh-chodapuneedi commented on the issue:

https://github.com/apache/cloudstack/pull/1880
  
@sureshanaparti Travis tests ended with timeout. Can you please try force 
push?
```The job exceeded the maximum time limit for jobs, and has been 
terminated.```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1794: added more guest os

2016-12-27 Thread sateesh-chodapuneedi
Github user sateesh-chodapuneedi commented on the issue:

https://github.com/apache/cloudstack/pull/1794
  
@sureshanaparti Seems build timed out. Can you please try force push?
```
[INFO] --- findbugs-maven-plugin:3.0.3:findbugs (findbugs) @ 
cloud-plugin-user-authenticator-md5 ---
[INFO] Fork Value is true
Build timed out (after 77 minutes). Marking the build as aborted.
Build was aborted
```

```
[INFO] Apache CloudStack Plugin - Power Management Driver ipmitool SUCCESS 
[ 34.609 s]
[INFO] Apache CloudStack Plugin - Storage Allocator Random  SUCCESS [ 
26.572 s]
[INFO] Apache CloudStack Plugin - User Authenticator LDAP . SUCCESS [ 
48.989 s]
[INFO] Apache CloudStack Plugin - User Authenticator MD5 .. FAILURE [ 
10.151 s]
[INFO] Apache CloudStack Plugin - User Authenticator PBKDF2-SHA-256 SKIPPED
```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request #1872: CLOUDSTACK-3223 Exception observed while crea...

2016-12-27 Thread sateesh-chodapuneedi
GitHub user sateesh-chodapuneedi opened a pull request:

https://github.com/apache/cloudstack/pull/1872

CLOUDSTACK-3223 Exception observed while creating CPVM in VMware Setup with 
DVS

Jira
===
CLOUDSTACK-3223 Exception observed while creating CPVM in VMware Setup with 
DVS

Issue
=
Exception observed while creating CPVM in VMware Setup with DVS.
Observed error "StartCommand failed due to Exception: 
com.vmware.vim25.AlreadyExists."
This is due to concurrent attempts to create same dv portgroup on same 
dvSwitch by
manager threads of CPVM and SSVM when both are started at same time.

Fix
===
Synchronize api calls to create/update dvportgroup.
Also maintaing local cache to avoid multiple fetch api calls to vCenter
when multiple threads try to create same object.

Signed-off-by: Sateesh Chodapuneedi <sateesh.chodapune...@accelerite.com>

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/sateesh-chodapuneedi/cloudstack 
pr-cloudstack-3223

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/1872.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1872


commit a3d9cfa05616f2fb3362a313d74079a317a78d11
Author: Sateesh Chodapuneedi <sateesh.chodapune...@accelerite.com>
Date:   2016-12-27T04:33:27Z

CLOUDSTACK-3223 Exception observed while creating CPVM in VMware Setup with 
DVS

Issue
=
Exception observed while creating CPVM in VMware Setup with DVS.
Observed error "StartCommand failed due to Exception: 
com.vmware.vim25.AlreadyExists."
This is due to concurrent attempts to create same dv portgroup on same 
dvSwitch by
manager threads of CPVM and SSVM when both are started at same time.

Fix
===
Synchronize api calls to create/update dvportgroup.
Also maintaing local cache to avoid multiple fetch api calls to vCenter
when multiple threads try to create same object.

Signed-off-by: Sateesh Chodapuneedi <sateesh.chodapune...@accelerite.com>




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request #1862: CLOUDSTACK-9704 Remove dependency on VmwareCo...

2016-12-23 Thread sateesh-chodapuneedi
GitHub user sateesh-chodapuneedi opened a pull request:

https://github.com/apache/cloudstack/pull/1862

CLOUDSTACK-9704 Remove dependency on VmwareContext object to fetch systemVM 
keyfile

Jira
===
CLOUDSTACK-9704 Remove dependency on VmwareContext object to fetch system 
VM key file

Description

While remote executing commands/scripts through SSH in VR, ACS uses system 
vm keyfile.
ACS is fetching this key file using VMwareContext object which encapsulates 
vCenter connection handle.
This is inefficient because of dependency on getServiceContext() which 
means a vCenter connection
handle which is not required just to fetch a file in name space in 
management server.

Fix
===
Implement a method to fetch system vm key file by using Script class 
instead of VmwareManagerImpl. Ensure this implementation is not present in 
VmwareManagerImpl itself because fetching the manager object from VmwareContext 
object unnecessarily adds dependency on session object just to search for 
keyfile in class path.

Signed-off-by: Sateesh Chodapuneedi <sateesh.chodapune...@accelerite.com>

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/sateesh-chodapuneedi/cloudstack 
pr-cloudstack-9704

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/1862.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1862


commit 02bd90c424966c81c57bed9b8fc9f530e0b97b7d
Author: Sateesh Chodapuneedi <sateesh.chodapune...@accelerite.com>
Date:   2016-12-23T02:17:43Z

CLOUDSTACK-9704 Remove dependency on VmwareContext object to fetch system 
VM key file

While remote executing commands/scripts through SSH in VR, ACS uses system 
vm keyfile.
ACS is fetching this key file using VMwareContext object which encapsulates 
vCenter connection handle.
This is inefficient because of dependency on getServiceContext() which 
means a vCenter connection
handle which is not required just to fetch a file in name space in 
management server.

Signed-off-by: Sateesh Chodapuneedi <sateesh.chodapune...@accelerite.com>




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request #1861: CLOUDSTACK-9698 Make hardcorded wait timeout ...

2016-12-23 Thread sateesh-chodapuneedi
GitHub user sateesh-chodapuneedi opened a pull request:

https://github.com/apache/cloudstack/pull/1861

CLOUDSTACK-9698 Make hardcorded wait timeout for NIC adapter hotplug as 
configurable

Jira
===
CLOUDSTACK-9698 Make hardcoded wait timeout for NIC adapter hotplug as 
configurable

Description
=
Currently ACS waits for 15 seconds (hard coded) for hot-plugged NIC in VR 
to get detected by guest OS.
The time taken to detect hot plugged NIC in guest OS depends on type of NIC 
adapter like (E1000, VMXNET3, E1000e etc.)
and guest OS itself. In uncommon scenarios the NIC detection may take 
longer time than 15 seconds,
in such cases NIC hotplug would be treated as failure which results in VPC 
tier configuration failure.
Alternatively making the wait timeout for NIC adapter hotplug as 
configurable will be helpful for admins in such scenarios.

Also in future if VMware introduces new NIC adapter types which may take 
time to get detected by guest OS, it is good to have flexibility of
configuring the wait timeout as fallback mechanism in such scenarios.

Fix
===
Introduce new configuration parameter (via ConfigKey) 
"vmware.nic.hotplug.wait.timeout" which is "Wait timeout (milli seconds) for 
hot plugged NIC of VM to be detected by guest OS." as fallback instead of hard 
coded timeout, to ensure flexibility for admins given the listed scenarios 
above.

Signed-off-by: Sateesh Chodapuneedi <sateesh.chodapune...@accelerite.com>

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/sateesh-chodapuneedi/cloudstack 
pr-cloudstack-9698

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/1861.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1861


commit 2ea7aadbac386f4d3a0e0062e1042e4266c24e91
Author: Sateesh Chodapuneedi <sateesh.chodapune...@accelerite.com>
Date:   2016-12-23T00:51:04Z

CLOUDSTACK-9698 Make the wait timeout for NIC adapter hotplug as 
configurable

Currently ACS waits for 15 seconds (hard coded) for hot-plugged NIC in VR 
to get detected by guest OS.
The time taken to detect hot plugged NIC in guest OS depends on type of NIC 
adapter like (E1000, VMXNET3, E1000e etc.)
and guest OS itself. In uncommon scenarios the NIC detection may take 
longer time than 15 seconds,
in such cases NIC hotplug would be treated as failure which results in VPC 
tier configuration failure.
Alternatively making the wait timeout for NIC adapter hotplug as 
configurable will be helpful for admins in such scenarios.

Also in future if VMware introduces new NIC adapter types which may take 
time to get detected by guest OS, it is good to have flexibility of
configuring the wait timeout as fallback mechanism in such scenarios.

Signed-off-by: Sateesh Chodapuneedi <sateesh.chodapune...@accelerite.com>




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1794: added more guest os

2016-12-23 Thread sateesh-chodapuneedi
Github user sateesh-chodapuneedi commented on the issue:

https://github.com/apache/cloudstack/pull/1794
  
@karuturi Can you please resolve the conflicts and rebase this branch?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1828: CLOUDSTACK-9676 Start instance fails after reverting...

2016-12-23 Thread sateesh-chodapuneedi
Github user sateesh-chodapuneedi commented on the issue:

https://github.com/apache/cloudstack/pull/1828
  
@rhtyd Travis is green for this PR. 
Can this be merged based on LGTMs and integration test results?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1828: CLOUDSTACK-9676 Start instance fails after reverting...

2016-12-22 Thread sateesh-chodapuneedi
Github user sateesh-chodapuneedi commented on the issue:

https://github.com/apache/cloudstack/pull/1828
  
@rhtyd Thanks. Done with rebase against `4.9` branch, also changed the PR's 
base branch to `4.9`.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1827: CLOUDSTACK-9673 : Exception occured while creating t...

2016-12-22 Thread sateesh-chodapuneedi
Github user sateesh-chodapuneedi commented on the issue:

https://github.com/apache/cloudstack/pull/1827
  
@rhtyd Thanks. Re-based against 4.9 branch, and changed base branch to 4.9


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request #1841: CLOUDSTACK-9684 Invalid zone id error while l...

2016-12-20 Thread sateesh-chodapuneedi
GitHub user sateesh-chodapuneedi opened a pull request:

https://github.com/apache/cloudstack/pull/1841

CLOUDSTACK-9684 Invalid zone id error while listing vmware zone

Issue
=
While listing datacenters associated with a zone, only zone Id validation 
is required.
There is no need to have additional checks like zone is a legacy zone or 
not.

Fix
===
Removed unnecessary checks over zone ID and just checking if zone with 
specified ID exists or not.

Signed-off-by: Sateesh Chodapuneedi <sateesh.chodapune...@accelerite.com>

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/sateesh-chodapuneedi/cloudstack 
pr-cloudstack-9684

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/1841.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1841


commit 870c2f59b476276475d2c8c711f2aa116ab70a45
Author: Sateesh Chodapuneedi <sateesh.chodapune...@accelerite.com>
Date:   2016-12-20T02:15:26Z

CLOUDSTACK-9684 Invalid zone id error while listing vmware zone
Issue
=
While listing datacenters associated with a zone, only zone Id validation 
is required.
There is no need to have additional checks like zone is a legacy zone or 
not.

Fix
===
Removed unnecessary checks over zone ID and just checking if zone with 
specified ID exists or not.

Signed-off-by: Sateesh Chodapuneedi <sateesh.chodapune...@accelerite.com>




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1828: CLOUDSTACK-9676 Start instance fails after reverting...

2016-12-14 Thread sateesh-chodapuneedi
Github user sateesh-chodapuneedi commented on the issue:

https://github.com/apache/cloudstack/pull/1828
  
Thanks, @serg38, @borisstoyanov for reviews.
@karuturi @rhtyd Can you pleas trigger trillian tests for validation?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request #1828: CLOUDSTACK-9676 Start instance fails after re...

2016-12-14 Thread sateesh-chodapuneedi
GitHub user sateesh-chodapuneedi opened a pull request:

https://github.com/apache/cloudstack/pull/1828

CLOUDSTACK-9676 Start instance fails after reverting to a VM snapshot when 
there are child VM snapshots

Jira
===
CLOUDSTACK-9676 Start instance fails after reverting to a VM snapshot when 
there are child VM snapshots

Issue

Start instance fails after reverting to a VM snapshot, when there is 1 or 
more child VM snapshots in the snapshot tree of the VM.
Per the code that detects the presence of a snapshot, we are checking for 
only current snapshot instead of checking presence of any snapshot in the 
snapshot tree.
The failure to detect all snapshots means ACP reconfigures the VM in wrong 
way assuming there are no snapshots for the VM.
This results in start failure.

Fix
===
Ensure correct detection of VM snapshots in the VM snapshot tree



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/sateesh-chodapuneedi/cloudstack 
pr-cloudstack-9676

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/1828.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1828


commit 34c85f5847dd4d3e55700e324bf695c60b8a4ca6
Author: Sateesh Chodapuneedi <sateesh.chodapune...@accelerite.com>
Date:   2016-12-13T20:22:15Z

CLOUDSTACK-9676 Start instance fails after reverting to a VM snapshot, when 
there are child VM snapshots

Issue

Start instance fails after reverting to a VM snapshot, when there is 1 or 
more child VM snapshots in the snapshot tree of the VM.
Per the code that detects the presence of a snapshot, we are checking for 
only current snapshot instead of checking presence of any snapshot in the 
snapshot tree.
The failure to detect all snapshots means ACP reconfigures the VM in wrong 
way assuming there are no snapshots for the VM.
This results in start failure.

Fix
===
Ensure correct detection of VM snapshots in the VM snapshot tree

Signed-off-by: Sateesh Chodapuneedi <sateesh.chodapune...@accelerite.com>




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request #1827: CLOUDSTACK-9673 : Exception occured while cre...

2016-12-13 Thread sateesh-chodapuneedi
GitHub user sateesh-chodapuneedi opened a pull request:

https://github.com/apache/cloudstack/pull/1827

CLOUDSTACK-9673 : Exception occured while creating the CPVM in VMware setup 
over standard vSwitches

Jira
===
CLOUDSTACK-9673 : Exception occured while creating the CPVM in VMware setup 
over standard vSwitches

Issue

Exception occured while creating the CPVM in the VmWare Setup using 
standard vswitches.
```
StartCommand failed due to Exception: com.vmware.vim25.AlreadyExists
message: [] com.vmware.vim25.AlreadyExistsFaultMsg: The specified key, 
name, or identifier already exists
```

Fix
===
Ensure synchronization while attempting to create port group such that 
simultaneous attempts are not made with same port group name on same ESXi host.

Testing
==
Successfully ran manual tests (deploy user instance) on top of latest 
master commit `17653a86fad67447a4f13e455e336694ad5c1735`.This code change is 
involved in virtual network creation over VMware standard vSwitches. Existing 
functional tests covers this functionality.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/sateesh-chodapuneedi/cloudstack 
pr-cloudstack-9673

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/1827.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1827


commit 69370e1cd9068fb37a46f15066efaa63cea81741
Author: Sateesh Chodapuneedi <sateesh.chodapune...@accelerite.com>
Date:   2016-12-13T18:40:42Z

CLOUDSTACK-9673 Exception occured while creating the CPVM in the VmWare 
Setup over standard vSwitches

Issue

Exception occured while creating the CPVM in the VmWare Setup using 
standard vswitches.
StartCommand failed due to Exception: com.vmware.vim25.AlreadyExists
message: [] com.vmware.vim25.AlreadyExistsFaultMsg: The specified key, 
name, or identifier already exists

Fix
===
Ensure synchronization while attempting to create port group such that 
simultaneous attempts are not made with same port group name on same ESXi host.

Signed-off-by: Sateesh Chodapuneedi <sateesh.chodapune...@accelerite.com>




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1244: Bug-ID: CLOUDSTACK-8654: Added guest_os mappings for...

2016-12-08 Thread sateesh-chodapuneedi
Github user sateesh-chodapuneedi commented on the issue:

https://github.com/apache/cloudstack/pull/1244
  
@rhtyd I think this would be useful for 4.9. 
@kishankavala Can you please rebase this fix?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1817: CLOUDSTACK-9654 Missing hypervisor mapping of variou...

2016-12-08 Thread sateesh-chodapuneedi
Github user sateesh-chodapuneedi commented on the issue:

https://github.com/apache/cloudstack/pull/1817
  
Thanks @rhtyd for merging this.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1396: CLOUDSTACK-9269: Missing field for Switch type for M...

2016-12-08 Thread sateesh-chodapuneedi
Github user sateesh-chodapuneedi commented on the issue:

https://github.com/apache/cloudstack/pull/1396
  
Code LGTM 👍 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request #1794: added more guest os

2016-12-07 Thread sateesh-chodapuneedi
Github user sateesh-chodapuneedi commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1794#discussion_r91453705
  
--- Diff: setup/db/db/schema-4910to41000.sql ---
@@ -45,4 +45,48 @@ CREATE TABLE `cloud`.`vlan_details` (
   `display` tinyint(1) NOT NULL DEFAULT 1 COMMENT 'Should detail be 
displayed to the end user',
   PRIMARY KEY (`id`),
   CONSTRAINT `fk_vlan_details__vlan_id` FOREIGN KEY 
`fk_vlan_details__vlan_id`(`vlan_id`) REFERENCES `vlan`(`id`) ON DELETE CASCADE
-) ENGINE=InnoDB DEFAULT CHARSET=utf8;
\ No newline at end of file
+) ENGINE=InnoDB DEFAULT CHARSET=utf8;
+
+INSERT IGNORE INTO `cloud`.`guest_os` (id, uuid, category_id, 
display_name, created) VALUES (261, UUID(), 1, 'CentOS 6.6 (32-bit)', now());
+INSERT IGNORE INTO `cloud`.`guest_os` (id, uuid, category_id, 
display_name, created) VALUES (262, UUID(), 1, 'CentOS 6.6 (64-bit)', now());
+INSERT IGNORE INTO `cloud`.`guest_os` (id, uuid, category_id, 
display_name, created) VALUES (263, UUID(), 1, 'CentOS 6.7 (32-bit)', now());
+INSERT IGNORE INTO `cloud`.`guest_os` (id, uuid, category_id, 
display_name, created) VALUES (264, UUID(), 1, 'CentOS 6.7 (64-bit)', now());
+INSERT IGNORE INTO `cloud`.`guest_os_hypervisor` (uuid,hypervisor_type, 
hypervisor_version, guest_os_name, guest_os_id, created, is_user_defined) 
VALUES (UUID(),'Xenserver', '6.5.0', 'CentOS 6 (32-bit)', 261, now(), 0);
+INSERT IGNORE INTO `cloud`.`guest_os_hypervisor` (uuid,hypervisor_type, 
hypervisor_version, guest_os_name, guest_os_id, created, is_user_defined) 
VALUES (UUID(),'Xenserver', '6.5.0', 'CentOS 6 (32-bit)', 263, now(), 0);
+INSERT IGNORE INTO `cloud`.`guest_os_hypervisor` (uuid,hypervisor_type, 
hypervisor_version, guest_os_name, guest_os_id, created, is_user_defined) 
VALUES (UUID(),'VMware', '6.0', 'centosGuest', 261, now(), 0);
+INSERT IGNORE INTO `cloud`.`guest_os_hypervisor` (uuid,hypervisor_type, 
hypervisor_version, guest_os_name, guest_os_id, created, is_user_defined) 
VALUES (UUID(),'VMware', '6.0', 'centosGuest', 263, now(), 0);
+INSERT IGNORE INTO `cloud`.`guest_os_hypervisor` (uuid,hypervisor_type, 
hypervisor_version, guest_os_name, guest_os_id, created, is_user_defined) 
VALUES (UUID(),'Xenserver', '6.5.0', 'CentOS 6 (64-bit)', 264, now(), 0);
+INSERT IGNORE INTO `cloud`.`guest_os_hypervisor` (uuid,hypervisor_type, 
hypervisor_version, guest_os_name, guest_os_id, created, is_user_defined) 
VALUES (UUID(),'Xenserver', '6.5.0', 'CentOS 6 (64-bit)', 262, now(), 0);
+INSERT IGNORE INTO `cloud`.`guest_os_hypervisor` (uuid,hypervisor_type, 
hypervisor_version, guest_os_name, guest_os_id, created, is_user_defined) 
VALUES (UUID(),'VMware', '6.0', 'centos64Guest', 264, now(), 0);
+INSERT IGNORE INTO `cloud`.`guest_os_hypervisor` (uuid,hypervisor_type, 
hypervisor_version, guest_os_name, guest_os_id, created, is_user_defined) 
VALUES (UUID(),'VMware', '6.0', 'centos64Guest', 262, now(), 0);
+
+INSERT IGNORE INTO `cloud`.`guest_os` (id, uuid, category_id, 
display_name, created) VALUES (265, UUID(), 4, 'Red Hat Enterprise Linux 6.6 
(32-bit)', now());
+INSERT IGNORE INTO `cloud`.`guest_os` (id, uuid, category_id, 
display_name, created) VALUES (266, UUID(), 4, 'Red Hat Enterprise Linux 6.6 
(64-bit)', now());
+INSERT IGNORE INTO `cloud`.`guest_os` (id, uuid, category_id, 
display_name, created) VALUES (267, UUID(), 4, 'Red Hat Enterprise Linux 6.7 
(32-bit)', now());
+INSERT IGNORE INTO `cloud`.`guest_os` (id, uuid, category_id, 
display_name, created) VALUES (268, UUID(), 4, 'Red Hat Enterprise Linux 6.7 
(64-bit)', now());
+INSERT IGNORE INTO `cloud`.`guest_os_hypervisor` (uuid,hypervisor_type, 
hypervisor_version, guest_os_name, guest_os_id, created, is_user_defined) 
VALUES (UUID(),'Xenserver', '6.5.0', 'Red Hat Enterprise Linux 6 (32-bit)', 
265, now(), 0);
+INSERT IGNORE INTO `cloud`.`guest_os_hypervisor` (uuid,hypervisor_type, 
hypervisor_version, guest_os_name, guest_os_id, created, is_user_defined) 
VALUES (UUID(),'Xenserver', '6.5.0', 'Red Hat Enterprise Linux 6 (32-bit)', 
267, now(), 0);
+INSERT IGNORE INTO `cloud`.`guest_os_hypervisor` (uuid,hypervisor_type, 
hypervisor_version, guest_os_name, guest_os_id, created, is_user_defined) 
VALUES (UUID(),'VMware', '6.0', 'rhel6Guest', 265, now(), 0);
+INSERT IGNORE INTO `cloud`.`guest_os_hypervisor` (uuid,hypervisor_type, 
hypervisor_version, guest_os_name, guest_os_id, created, is_user_defined) 
VALUES (UUID(),'VMware', '6.0', 'rhel6Guest', 267, now(), 0);
+INSERT IGNORE INTO `cloud`.`guest_os_hypervisor` (uuid,hypervisor_type, 
hypervisor_version, guest_os_name, guest_os_id, created, is_user_defined) 
VALUES (UUID(),'Xenserver', '6.5.0', 'Red Hat Enterprise Linux 6 (64-bit)', 
266, now(), 0);
+INSERT IGNORE INTO `cloud`.`guest_os_hypervisor` (uuid,hypervisor_type, 
hypervisor_version, guest_os_name, guest_os_id, created

[GitHub] cloudstack pull request #1794: added more guest os

2016-12-07 Thread sateesh-chodapuneedi
Github user sateesh-chodapuneedi commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1794#discussion_r91460891
  
--- Diff: setup/db/db/schema-4910to41000.sql ---
@@ -45,4 +45,48 @@ CREATE TABLE `cloud`.`vlan_details` (
   `display` tinyint(1) NOT NULL DEFAULT 1 COMMENT 'Should detail be 
displayed to the end user',
   PRIMARY KEY (`id`),
   CONSTRAINT `fk_vlan_details__vlan_id` FOREIGN KEY 
`fk_vlan_details__vlan_id`(`vlan_id`) REFERENCES `vlan`(`id`) ON DELETE CASCADE
-) ENGINE=InnoDB DEFAULT CHARSET=utf8;
\ No newline at end of file
+) ENGINE=InnoDB DEFAULT CHARSET=utf8;
+
+INSERT IGNORE INTO `cloud`.`guest_os` (id, uuid, category_id, 
display_name, created) VALUES (261, UUID(), 1, 'CentOS 6.6 (32-bit)', now());
+INSERT IGNORE INTO `cloud`.`guest_os` (id, uuid, category_id, 
display_name, created) VALUES (262, UUID(), 1, 'CentOS 6.6 (64-bit)', now());
+INSERT IGNORE INTO `cloud`.`guest_os` (id, uuid, category_id, 
display_name, created) VALUES (263, UUID(), 1, 'CentOS 6.7 (32-bit)', now());
+INSERT IGNORE INTO `cloud`.`guest_os` (id, uuid, category_id, 
display_name, created) VALUES (264, UUID(), 1, 'CentOS 6.7 (64-bit)', now());
+INSERT IGNORE INTO `cloud`.`guest_os_hypervisor` (uuid,hypervisor_type, 
hypervisor_version, guest_os_name, guest_os_id, created, is_user_defined) 
VALUES (UUID(),'Xenserver', '6.5.0', 'CentOS 6 (32-bit)', 261, now(), 0);
+INSERT IGNORE INTO `cloud`.`guest_os_hypervisor` (uuid,hypervisor_type, 
hypervisor_version, guest_os_name, guest_os_id, created, is_user_defined) 
VALUES (UUID(),'Xenserver', '6.5.0', 'CentOS 6 (32-bit)', 263, now(), 0);
+INSERT IGNORE INTO `cloud`.`guest_os_hypervisor` (uuid,hypervisor_type, 
hypervisor_version, guest_os_name, guest_os_id, created, is_user_defined) 
VALUES (UUID(),'VMware', '6.0', 'centosGuest', 261, now(), 0);
+INSERT IGNORE INTO `cloud`.`guest_os_hypervisor` (uuid,hypervisor_type, 
hypervisor_version, guest_os_name, guest_os_id, created, is_user_defined) 
VALUES (UUID(),'VMware', '6.0', 'centosGuest', 263, now(), 0);
+INSERT IGNORE INTO `cloud`.`guest_os_hypervisor` (uuid,hypervisor_type, 
hypervisor_version, guest_os_name, guest_os_id, created, is_user_defined) 
VALUES (UUID(),'Xenserver', '6.5.0', 'CentOS 6 (64-bit)', 264, now(), 0);
+INSERT IGNORE INTO `cloud`.`guest_os_hypervisor` (uuid,hypervisor_type, 
hypervisor_version, guest_os_name, guest_os_id, created, is_user_defined) 
VALUES (UUID(),'Xenserver', '6.5.0', 'CentOS 6 (64-bit)', 262, now(), 0);
+INSERT IGNORE INTO `cloud`.`guest_os_hypervisor` (uuid,hypervisor_type, 
hypervisor_version, guest_os_name, guest_os_id, created, is_user_defined) 
VALUES (UUID(),'VMware', '6.0', 'centos64Guest', 264, now(), 0);
+INSERT IGNORE INTO `cloud`.`guest_os_hypervisor` (uuid,hypervisor_type, 
hypervisor_version, guest_os_name, guest_os_id, created, is_user_defined) 
VALUES (UUID(),'VMware', '6.0', 'centos64Guest', 262, now(), 0);
+
+INSERT IGNORE INTO `cloud`.`guest_os` (id, uuid, category_id, 
display_name, created) VALUES (265, UUID(), 4, 'Red Hat Enterprise Linux 6.6 
(32-bit)', now());
+INSERT IGNORE INTO `cloud`.`guest_os` (id, uuid, category_id, 
display_name, created) VALUES (266, UUID(), 4, 'Red Hat Enterprise Linux 6.6 
(64-bit)', now());
+INSERT IGNORE INTO `cloud`.`guest_os` (id, uuid, category_id, 
display_name, created) VALUES (267, UUID(), 4, 'Red Hat Enterprise Linux 6.7 
(32-bit)', now());
+INSERT IGNORE INTO `cloud`.`guest_os` (id, uuid, category_id, 
display_name, created) VALUES (268, UUID(), 4, 'Red Hat Enterprise Linux 6.7 
(64-bit)', now());
+INSERT IGNORE INTO `cloud`.`guest_os_hypervisor` (uuid,hypervisor_type, 
hypervisor_version, guest_os_name, guest_os_id, created, is_user_defined) 
VALUES (UUID(),'Xenserver', '6.5.0', 'Red Hat Enterprise Linux 6 (32-bit)', 
265, now(), 0);
+INSERT IGNORE INTO `cloud`.`guest_os_hypervisor` (uuid,hypervisor_type, 
hypervisor_version, guest_os_name, guest_os_id, created, is_user_defined) 
VALUES (UUID(),'Xenserver', '6.5.0', 'Red Hat Enterprise Linux 6 (32-bit)', 
267, now(), 0);
+INSERT IGNORE INTO `cloud`.`guest_os_hypervisor` (uuid,hypervisor_type, 
hypervisor_version, guest_os_name, guest_os_id, created, is_user_defined) 
VALUES (UUID(),'VMware', '6.0', 'rhel6Guest', 265, now(), 0);
+INSERT IGNORE INTO `cloud`.`guest_os_hypervisor` (uuid,hypervisor_type, 
hypervisor_version, guest_os_name, guest_os_id, created, is_user_defined) 
VALUES (UUID(),'VMware', '6.0', 'rhel6Guest', 267, now(), 0);
+INSERT IGNORE INTO `cloud`.`guest_os_hypervisor` (uuid,hypervisor_type, 
hypervisor_version, guest_os_name, guest_os_id, created, is_user_defined) 
VALUES (UUID(),'Xenserver', '6.5.0', 'Red Hat Enterprise Linux 6 (64-bit)', 
266, now(), 0);
+INSERT IGNORE INTO `cloud`.`guest_os_hypervisor` (uuid,hypervisor_type, 
hypervisor_version, guest_os_name, guest_os_id, created

[GitHub] cloudstack issue #1817: CLOUDSTACK-9654 Missing hypervisor mapping of variou...

2016-12-07 Thread sateesh-chodapuneedi
Github user sateesh-chodapuneedi commented on the issue:

https://github.com/apache/cloudstack/pull/1817
  
@rhtyd I see one travis script failed due to timeout. Remaining are all 
successful.
```
/home/travis/build.sh: line 151: 10405 Terminated  
travis_jigger $! $timeout $cmd
The command "travis_wait 40 ./tools/travis/script.sh ${TESTS}" exited with 
1.
```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1794: added more guest os

2016-12-07 Thread sateesh-chodapuneedi
Github user sateesh-chodapuneedi commented on the issue:

https://github.com/apache/cloudstack/pull/1794
  
@karuturi Can you please resolve the conflicts and rebase this branch?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1817: CLOUDSTACK-9654 Missing hypervisor mapping of variou...

2016-12-07 Thread sateesh-chodapuneedi
Github user sateesh-chodapuneedi commented on the issue:

https://github.com/apache/cloudstack/pull/1817
  
@rhtyd Yes, rebased with latest 4.9, and did a force push to kick Travis 
checks.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1817: CLOUDSTACK-9654 Missing hypervisor mapping of variou...

2016-12-05 Thread sateesh-chodapuneedi
Github user sateesh-chodapuneedi commented on the issue:

https://github.com/apache/cloudstack/pull/1817
  
Changed base branch to 4.9 from master.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request #1817: CLOUDSTACK-9654 Missing hypervisor mapping of...

2016-12-05 Thread sateesh-chodapuneedi
GitHub user sateesh-chodapuneedi opened a pull request:

https://github.com/apache/cloudstack/pull/1817

CLOUDSTACK-9654 Missing hypervisor mapping of various SUSE Linux gues…

…t os versions on VMware 6.0

Issue: Currently many versions of SUSE Linux does not have any hypervisor 
mapping entry in guest_os_hypervisor table in cloud database for VMware 6.0. 
Also observed that the guest_os_name field is incorrect for some SUSE Linux 
variants, which results in deployed instance (with SUSE Linux) set to guest OS 
type as "Other (64-bit)" on vCenter, which would not represent the guest OS 
accurately on hypervisor.

Fix: Add the missing hypervisor mappings
Signed-off-by: Sateesh Chodapuneedi <sateesh.chodapune...@accelerite.com>

The current (4.9) list of SUSE Linux guest os in database looks as below,

> mysql> select id,display_name from guest_os where display_name like 
'%suse%';
> +-+--+
> | id  | display_name |
> +-+--+
> |  40 | SUSE Linux Enterprise Server 9 SP4 (32-bit)  |
> |  41 | SUSE Linux Enterprise Server 10 SP1 (32-bit) |
> |  42 | SUSE Linux Enterprise Server 10 SP1 (64-bit) |
> |  43 | SUSE Linux Enterprise Server 10 SP2 (32-bit) |
> |  44 | SUSE Linux Enterprise Server 10 SP2 (64-bit) |
> |  45 | SUSE Linux Enterprise Server 10 SP3 (64-bit) |
> |  46 | SUSE Linux Enterprise Server 11 (32-bit) |
> |  47 | SUSE Linux Enterprise Server 11 (64-bit) |
> |  96 | SUSE Linux Enterprise 8(32-bit)  |
> |  97 | SUSE Linux Enterprise 8(64-bit)  |
> | 107 | SUSE Linux Enterprise 9(32-bit)  |
> | 108 | SUSE Linux Enterprise 9(64-bit)  |
> | 109 | SUSE Linux Enterprise 10(32-bit) |
> | 110 | SUSE Linux Enterprise 10(64-bit) |
> | 151 | SUSE Linux Enterprise Server 10 SP3 (32-bit) |
> | 152 | SUSE Linux Enterprise Server 10 SP4 (64-bit) |
> | 153 | SUSE Linux Enterprise Server 10 SP4 (32-bit) |
> | 154 | SUSE Linux Enterprise Server 11 SP1 (64-bit) |
> | 155 | SUSE Linux Enterprise Server 11 SP1 (32-bit) |
> | 185 | SUSE Linux Enterprise Server 11 SP2 (64-bit) |
> | 186 | SUSE Linux Enterprise Server 11 SP2 (32-bit) |
> | 187 | SUSE Linux Enterprise Server 11 SP3 (64-bit) |
> | 188 | SUSE Linux Enterprise Server 11 SP3 (32-bit) |
> | 202 | Other SUSE Linux(32-bit) |
> | 203 | Other SUSE Linux(64-bit) |
> | 244 | SUSE Linux Enterprise Server 12 (64-bit) |
> +-+--+
> 26 rows in set (0.00 sec)

The current (4.9) hypervisor mappings for SUSE Linux guest os over VMware 
6.0 in database looks as below. We can observe in the below query result, which 
lists all hypervisor mappings for SUSE Linux guest OS over VMware 6.0, many 
guest os listed in above query result are missing their mappings for VMware 
6.0. Hence the need to add the missing hypervisor mappings.

```
mysql> select o.id,o.display_name, h.guest_os_name, h.hypervisor_version 
from guest_os as o, guest_os_hypervisor as h where o.id=h.guest_os_id and 
h.hypervisor_version='6.0' and h.hypervisor_type='vmware' and o.display_name 
like '%SUSE%';

+-+--+---++
| id  | display_name | guest_os_name | 
hypervisor_version |

+-+--+---++
|  96 | SUSE Linux Enterprise 8(32-bit)  | suseGuest | 6.0  
  |
|  97 | SUSE Linux Enterprise 8(64-bit)  | suse64Guest   | 6.0  
  |
| 107 | SUSE Linux Enterprise 9(32-bit)  | suseGuest | 6.0  
  |
| 108 | SUSE Linux Enterprise 9(64-bit)  | suse64Guest   | 6.0  
  |
| 109 | SUSE Linux Enterprise 10(32-bit) | suseGuest | 6.0  
  |
| 110 | SUSE Linux Enterprise 10(64-bit) | suse64Guest   | 6.0  
  |
| 202 | Other SUSE Linux(32-bit) | suseGuest | 6.0  
  |
| 203 | Other SUSE Linux(64-bit) | suse64Guest   | 6.0  
  |

+-+--+---++
8 rows in set (0.00 sec)

    ```


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/sateesh-chodapuneedi/cloudstack 
pr-cloudstack-9654

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/1817.patch

To close this pull request, make a commit to your master/trunk branch
with (at least)

[GitHub] cloudstack issue #828: CLOUDSTACK-8854: Apple Mac OS/X VM get created withou...

2016-11-30 Thread sateesh-chodapuneedi
Github user sateesh-chodapuneedi commented on the issue:

https://github.com/apache/cloudstack/pull/828
  
LGTM. Verified manually in my VMware setup.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1793: CLOUDSTACK-9624 Incorrect hypervisor mapping of gues...

2016-11-29 Thread sateesh-chodapuneedi
Github user sateesh-chodapuneedi commented on the issue:

https://github.com/apache/cloudstack/pull/1793
  
Thanks @rhtyd 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1793: CLOUDSTACK-9624 Incorrect hypervisor mapping of gues...

2016-11-29 Thread sateesh-chodapuneedi
Github user sateesh-chodapuneedi commented on the issue:

https://github.com/apache/cloudstack/pull/1793
  
@rhtyd Yes, that's correct. The guest_os_name `windows7Server64Guest` is 
supported since vSphere 4.0 onwards. 
I've verified this in 5.0 as well as 6.0 setup. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1793: CLOUDSTACK-9624 Incorrect hypervisor mapping of gues...

2016-11-28 Thread sateesh-chodapuneedi
Github user sateesh-chodapuneedi commented on the issue:

https://github.com/apache/cloudstack/pull/1793
  
Thanks @rhtyd 
Rebased the commit over 4.9, and updated base branch to 4.9.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request #1793: CLOUDSTACK-9624 Incorrect hypervisor mapping ...

2016-11-28 Thread sateesh-chodapuneedi
GitHub user sateesh-chodapuneedi opened a pull request:

https://github.com/apache/cloudstack/pull/1793

CLOUDSTACK-9624 Incorrect hypervisor mapping of guest os Windows 2008 
Server R2 (64-bit) for VMware

**JIRA ticket** 
CLOUDSTACK-9624 Incorrect hypervisor mapping of guest os Windows 2008 
Server R2 (64-bit) for VMware

**Issue**
Guest OS Windows Server 2008 R2 (64-bit) is being mapped to incorrect guest 
os at hypervisor, which is winLonghorn64Guest, same as that of Windows Server 
2008 (64-bit).
Due to this the VM's guest os type was set to "Other (64-bit)", which would 
not represent the guest OS accurately on hypervisor.

**Solution**
Fix is to update incorrect guest_os_name field value in DB table 
cloud.guest_os_hypervisor.
Th query is,
UPDATE IGNORE `cloud`.`guest_os_hypervisor` SET guest_os_name = 
'windows7Server64Guest' WHERE guest_os_id IN (SELECT id FROM guest_os WHERE 
display_name LIKE 'windows%2008%r2%64%') AND hypervisor_type = 'VMware' AND 
hypervisor_version != 'default';

After running above query, the 6 updated rows looks like

UPDATE IGNORE `cloud`.`guest_os_hypervisor` SET guest_os_name = 
'windows7Server64Guest' WHERE guest_os_id IN (SELECT id FROM guest_os WHERE 
display_name LIKE 'windows%2008%r2%64%') AND hypervisor_type = 'VMware' AND 
hypervisor_version != 'default';
Query OK, 6 rows affected (0.01 sec)
Rows matched: 6  Changed: 6  Warnings: 0

mysql> select * from guest_os_hypervisor where guest_os_id in (select id 
from guest_os where display_name like 'windows%2008%r2%64%') and 
hypervisor_type = 'VMware' and hypervisor_version != 'default';

+--+-+---+-++--+-+-+-+
| id   | hypervisor_type | guest_os_name | guest_os_id | 
hypervisor_version | uuid | created 
| removed | is_user_defined |

+--+-+---+-++--+-+-+-+
| 1307 | VMware  | windows7Server64Guest |  54 | 4.0
| 98fce372-b271-11e6-b56b-4e61adb7c6b1 | 2016-11-24 23:42:44 | NULL
|   0 |
| 1448 | VMware  | windows7Server64Guest |  54 | 4.1
| 990abdcc-b271-11e6-b56b-4e61adb7c6b1 | 2016-11-24 23:42:45 | NULL
|   0 |
| 1589 | VMware  | windows7Server64Guest |  54 | 5.0
| 99166f75-b271-11e6-b56b-4e61adb7c6b1 | 2016-11-24 23:42:45 | NULL
|   0 |
| 1730 | VMware  | windows7Server64Guest |  54 | 5.1
| 9930ff30-b271-11e6-b56b-4e61adb7c6b1 | 2016-11-24 23:42:45 | NULL
|   0 |
| 1871 | VMware  | windows7Server64Guest |  54 | 5.5
| 993acb18-b271-11e6-b56b-4e61adb7c6b1 | 2016-11-24 23:42:45 | NULL
|   0 |
| 2381 | VMware  | windows7Server64Guest |  54 | 6.0
| 9cb53675-b271-11e6-b56b-4e61adb7c6b1 | 2016-11-24 18:12:51 | NULL
|   0 |

+--+-+---+-++--+-+-+-+
6 rows in set (0.01 sec)

**Tests**
Registered a template with Windows 2008 R2 (64-bit) guest OS and deployed 
an instance from the template. Found that the VM appeared in vCenter with valid 
guest OS type instead of "Other (64-bit)" shown up before the fix.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/sateesh-chodapuneedi/cloudstack pr-cs-9624

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/1793.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1793


commit b025fa34739f7bd2d197adb1f531572ba6d6bb9e
Author: Sateesh Chodapuneedi <sateesh.chodapune...@accelerite.com>
Date:   2016-11-27T21:54:17Z

CLOUDSTACK-9624 Incorrect hypervisor mapping of guest os Windows 2008 
Server R2 (64-bit) for VMware

Issue:Guest OS Windows Server 2008 R2 (64-bit) is being mapped to incorrect 
guest os at hypervisor, which is winLonghorn64Guest, same as that of Windows 
Server 2008 (64-bit).
Due to this the VM's guest os type was set to "Other (64-bit)", which would 
not represent the guest OS accurately on hypervisor.

Solution:Fix is to update incorrect guest_os_name field value in DB table 
cloud.guest_os_hypervisor.




---
If your project is set up for it, you can reply to this ema

[GitHub] cloudstack issue #1664: CLOUDSTACK-8676 Deploy user instance from vm snapsho...

2016-11-24 Thread sateesh-chodapuneedi
Github user sateesh-chodapuneedi commented on the issue:

https://github.com/apache/cloudstack/pull/1664
  
Hi @rhtyd, Working on this PR this week, should be able to update and push 
soon.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1681: CLOUDSTACK-9491: incorrect parsing of device list to...

2016-09-28 Thread sateesh-chodapuneedi
Github user sateesh-chodapuneedi commented on the issue:

https://github.com/apache/cloudstack/pull/1681
  
Code LGTM, 👍 +1


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1681: CLOUDSTACK-9491: incorrect parsing of device list to...

2016-09-23 Thread sateesh-chodapuneedi
Github user sateesh-chodapuneedi commented on the issue:

https://github.com/apache/cloudstack/pull/1681
  
@murali-reddy Makes sense to get fresh listing of virtual NICs in next 
iteration as the first iteration might have missed the hot-plugged virtual NIC 
(for VPC tier being configured). Though one side effect is we will loop through 
all the virtual NICs, except the newly hot-plugged NIC, at least one more time. 
Can you please see if we can avoid repeating the command 'ip address show' 
for the virtual NICs that were already verified to be not matching.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1664: CLOUDSTACK-8676 Deploy user instance from vm snapsho...

2016-09-19 Thread sateesh-chodapuneedi
Github user sateesh-chodapuneedi commented on the issue:

https://github.com/apache/cloudstack/pull/1664
  
@jburwell Yes, currently working on breaking the methods into multiple 
smaller units, and adding unit tests. Along with these adding the marvin tests 
from the other PR so that PR contains functional tests as well.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request #1664: CLOUDSTACK-8676 Deploy user instance from vm ...

2016-09-01 Thread sateesh-chodapuneedi
Github user sateesh-chodapuneedi commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1664#discussion_r77140277
  
--- Diff: 
api/src/org/apache/cloudstack/api/command/admin/template/SeedTemplateFromVmSnapshotCmd.java
 ---
@@ -0,0 +1,145 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+package org.apache.cloudstack.api.command.admin.template;
+
+import org.apache.log4j.Logger;
+
+import org.apache.cloudstack.acl.SecurityChecker.AccessType;
+import org.apache.cloudstack.api.ACL;
+import org.apache.cloudstack.api.APICommand;
+import org.apache.cloudstack.api.ApiCommandJobType;
+import org.apache.cloudstack.api.ApiConstants;
+import org.apache.cloudstack.api.ApiErrorCode;
+import org.apache.cloudstack.api.BaseAsyncCmd;
+import org.apache.cloudstack.api.Parameter;
+import org.apache.cloudstack.api.ServerApiException;
+import org.apache.cloudstack.api.response.StoragePoolResponse;
+import org.apache.cloudstack.api.response.VMSnapshotResponse;
+import org.apache.cloudstack.api.response.VmSnapshotTemplateResponse;
+import org.apache.cloudstack.api.response.ZoneResponse;
+
+import com.cloud.event.EventTypes;
+import com.cloud.user.Account;
+
+@APICommand(name = "seedTemplateFromVmSnapshot", responseObject = 
VmSnapshotTemplateResponse.class, description = "seed template from vm snapshot 
on primary storage",
+requestHasSensitiveInfo = false, responseHasSensitiveInfo = false)
--- End diff --

Sure, will update the fields.
Thanks for review.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request #1664: CLOUDSTACK-8676 Deploy user instance from vm ...

2016-09-01 Thread sateesh-chodapuneedi
Github user sateesh-chodapuneedi commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1664#discussion_r77140308
  
--- Diff: 
api/src/org/apache/cloudstack/api/command/user/volume/CreateVolumeFromVmSnapshotCmd.java
 ---
@@ -0,0 +1,105 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements.  See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership.  The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License.  You may obtain a copy of the License at
+//
+//   http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied.  See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+package org.apache.cloudstack.api.command.user.volume;
+
+import org.apache.log4j.Logger;
+
+import org.apache.cloudstack.api.APICommand;
+import org.apache.cloudstack.api.ApiConstants;
+import org.apache.cloudstack.api.ApiErrorCode;
+import org.apache.cloudstack.api.Parameter;
+import org.apache.cloudstack.api.ResponseObject.ResponseView;
+import org.apache.cloudstack.api.ServerApiException;
+import org.apache.cloudstack.api.response.VMSnapshotResponse;
+import org.apache.cloudstack.api.response.VolumeResponse;
+import org.apache.cloudstack.context.CallContext;
+
+import com.cloud.event.EventTypes;
+import com.cloud.storage.Volume;
+import com.cloud.vm.VirtualMachine;
+import com.cloud.vm.snapshot.VMSnapshot;
+
+@APICommand(name = "createVolumeFromVmSnapshot", responseObject = 
VolumeResponse.class, description = "Creates a disk volume from a disk volume 
in a VM snapshot. This disk volume must still be attached to a virtual machine 
to make use of it.", responseView = ResponseView.Restricted, entityType = {
+Volume.class, VirtualMachine.class},
+requestHasSensitiveInfo = false, responseHasSensitiveInfo = false)
+public class CreateVolumeFromVmSnapshotCmd extends CreateVolumeCmd {
--- End diff --

Sure, will update the fields.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1664: CLOUDSTACK-8676 Deploy user instance from vm snapsho...

2016-08-29 Thread sateesh-chodapuneedi
Github user sateesh-chodapuneedi commented on the issue:

https://github.com/apache/cloudstack/pull/1664
  
@jburwell I will check with @nitt10prashant on this. Will try to add the 
tests in PR #1417 to this PR.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1664: CLOUDSTACK-8676 Deploy user instance from vm snapsho...

2016-08-27 Thread sateesh-chodapuneedi
Github user sateesh-chodapuneedi commented on the issue:

https://github.com/apache/cloudstack/pull/1664
  
Target this PR to ACS master branch.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1417: CLOUDSTACK-9289:Automation for feature deploy vm fro...

2016-08-27 Thread sateesh-chodapuneedi
Github user sateesh-chodapuneedi commented on the issue:

https://github.com/apache/cloudstack/pull/1417
  
Hi @nitt10prashant / @swill 
Raised PR https://github.com/apache/cloudstack/pull/1664 for parent ticket 
CLOUDSTACK-8676


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request #1664: CLOUDSTACK-8676 Deploy user instance from vm ...

2016-08-27 Thread sateesh-chodapuneedi
GitHub user sateesh-chodapuneedi opened a pull request:

https://github.com/apache/cloudstack/pull/1664

CLOUDSTACK-8676 Deploy user instance from vm snapshot for VMware hypervisor



Currently, ACS provides the ability to deploy a VM from a template or ISO. 
However, ACS does not provide the ability to deploy a VM(s) directly from a VM 
snapshot.

VM snapshots are stored in the primary storage and have a hierarchical or 
parent/child relationship. The requirement would be to provide the ability to 
deploy user instances from selected VM snapshots. Additionally, any VM snapshot 
in the hierarchy can be deployed concurrently.

Even though this can be supported and applicable to all hypervisors, to 
start with this feature is supported only for VMware hypervisor.

Also this feature supports creation of volume from VM snapshots. Details of 
new APIs added as part of this feature can be found in feature specification 
document below.

Feature specification is at 
https://cwiki.apache.org/confluence/display/CLOUDSTACK/Deploy+instance+from+VM+snapshot

There is a separate PR raised by @nitt10prashant  that contains marvin 
tests for this feature.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/sateesh-chodapuneedi/cloudstack 
deploy-from-snapshot

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/1664.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1664


commit 9df51faa8a2f0678e7927ac6ef23752b1eae8f71
Author: rahul singal <rahul.sin...@alcatel-lucent.com>
Date:   2016-05-09T11:24:53Z

Marvin script for cloudstack-9365

commit bee2bdc299844e081ef30ccc5de0c2e01b2a0581
Author: Will Stevens <williamstev...@gmail.com>
Date:   2016-05-11T06:03:49Z

Merge pull request #1489 from shapeblue/dynamicroles-master

CLOUDSTACK-8562: Dynamic Role-Based API Checker for CloudStack### 
CLOUDSTACK-8562: DB-Backed Dynamic Role Based API Access Checker

This feature allows root administrators to define new roles and associate 
API
permissions to them.

A limited form of role-based access control for the CloudStack management 
server
API is provided through a properties file, commands.properties, embedded in 
the
WAR distribution. Therefore, customizing API permissions requires unpacking 
the
distribution and modifying this file consistently on all servers. The old 
system
also does not permit the specification of additional roles.

FS:

https://cwiki.apache.org/confluence/display/CLOUDSTACK/Dynamic+Role+Based+API+Access+Checker+for+CloudStack

DB-Backed Dynamic Role Based API Access Checker for CloudStack brings 
following
changes, features and use-cases:
- Moves the API access definitions from commands.properties to the mgmt 
server DB
- Allows defining custom roles (such as a read-only ROOT admin) beyond the
  current set of four (4) roles
- All roles will resolve to one of the four known roles types (Admin, 
Resource
  Admin, Domain Admin and User) which maintains this association by 
requiring
  all new defined roles to specify a role type.
- Allows changes to roles and API permissions per role at runtime including 
additions or
  removal of roles and/or modifications of permissions, without the need
  of restarting management server(s)

Upgrade/installation notes:
- The feature will be enabled by default for new installations, existing
  deployments will continue to use the older static role based api access 
checker
  with an option to enable this feature
- During fresh installation or upgrade, the upgrade paths will add four 
default
  roles based on the four default role types
- For ease of migration, at the time of upgrade commands.properties will be 
used
  to add existing set of permissions to the default roles. cloud.account
  will have a new role_id column which will be populated based on default 
roles
  as well

Dynamic-roles migration tool: scripts/util/migrate-dynamicroles.py
- Allows admins to migrate to the dynamic role based checker at a future 
date
- Performs a harder one-way migrate and update
- Migrates rules from existing commands.properties file into db and 
deprecates it
- Enables an internal hidden switch to enable dynamic role based checker 
feature

* pr/1489:
  maven: Fix jstl version usage
  CLOUDSTACK-8562: Deprecate commands.properties
  CLOUDSTACK-8562: DB-Backed Dynamic Role Based API Access Checker
  CLOUDSTACK-9361: Centrally handle API validations

Signed-off-by: Will Stevens <williamstev...@gmail.com>

commit dad9e5d86835ccdaa39a3c62047b7fce3a32de6d
Author: Mike Tutk

[GitHub] cloudstack issue #1605: CLOUDSTACK-9428: Fix for CLOUDSTACK-9211 - Improve p...

2016-08-18 Thread sateesh-chodapuneedi
Github user sateesh-chodapuneedi commented on the issue:

https://github.com/apache/cloudstack/pull/1605
  
LGTM 👍 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1605: CLOUDSTACK-9428: Fix for CLOUDSTACK-9211 - Improve p...

2016-07-11 Thread sateesh-chodapuneedi
Github user sateesh-chodapuneedi commented on the issue:

https://github.com/apache/cloudstack/pull/1605
  
@nvazquez Thanks.
I will try this in my setup and share the results.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


Re: JIRA Permission

2016-07-08 Thread Sateesh Chodapuneedi
Priyank,
What is your user name in ACS jira?

Regards,
Sateesh
 

On 08/07/16, 2:37 PM, "Priyank Parihar"  wrote:

Hi,
I am unable to assign issues (e.g. - CLOUDSTACK-9104) to me. Please give me 
permission.

--
Thanks & Regards
Priyank  Parihar




DISCLAIMER
==
This e-mail may contain privileged and confidential information which is the 
property of Accelerite, a Persistent Systems business. It is intended only for 
the use of the individual or entity to which it is addressed. If you are not 
the intended recipient, you are not authorized to read, retain, copy, print, 
distribute or use this message. If you have received this communication in 
error, please notify the sender and delete all copies of this message. 
Accelerite, a Persistent Systems business does not accept any liability for 
virus infected mails.





DISCLAIMER
==
This e-mail may contain privileged and confidential information which is the 
property of Accelerite, a Persistent Systems business. It is intended only for 
the use of the individual or entity to which it is addressed. If you are not 
the intended recipient, you are not authorized to read, retain, copy, print, 
distribute or use this message. If you have received this communication in 
error, please notify the sender and delete all copies of this message. 
Accelerite, a Persistent Systems business does not accept any liability for 
virus infected mails.


Re: Roadmap on Wiki

2016-07-07 Thread Sateesh Chodapuneedi
For strong swan support, there exists a PR - 
https://github.com/apache/cloudstack/pull/872

Regards,
Sateesh

On 07/07/16, 4:15 PM, "Paul Angus"  wrote:

Awesome.  thanks


Kind regards,

Paul Angus

paul.an...@shapeblue.com 
www.shapeblue.com
53 Chandos Place, Covent Garden, London  WC2N 4HSUK
@shapeblue
  
 


-Original Message-
From: Anshul Gangwar [mailto:anshul.gang...@accelerite.com] 
Sent: 07 July 2016 11:44
To: dev@cloudstack.apache.org
Subject: Re: Roadmap on Wiki

There are 3 active PRs for the items
Snapshot Improvements https://github.com/apache/cloudstack/pull/672
iSCSI and HA support in Hyper-V https://github.com/apache/cloudstack/pull/351
Support for non-US keyboards in Console Proxy 
https://github.com/apache/cloudstack/pull/669

Regards,
Anshul 

On 07/07/16, 3:57 PM, "Paul Angus"  wrote:

Hi All,

We have a number of 'Citrix' items on the roadmap, I'd like to find out if 
they're still in progress at Accelerite - or should we remove them from the 
list...


Snapshot Improvements

CLOUDSTACK-8663


Anshul Gangwar
(Citrix)




Openswan with strongswan




jayapal
(Citrix)













iSCSI and HA support in Hyper-V

CLOUDSTACK-8444


Anshul Gangwar
(Citrix)

4.6.0

Design document is available at iSCSI and HA support in 
Hyper-V





Support for non-US keyboards in Console Proxy

CLOUDSTACK-8665


Anshul Gangwar
(Citrix)

4.6.0









Kind regards,

Paul Angus


paul.an...@shapeblue.com
www.shapeblue.com
53 Chandos Place, Covent Garden, London  WC2N 4HSUK @shapeblue
  
 






DISCLAIMER
==
This e-mail may contain privileged and confidential information which is the 
property of Accelerite, a Persistent Systems business. It is intended only for 
the use of the individual or entity to which it is addressed. If you are not 
the intended recipient, you are not authorized to read, retain, copy, print, 
distribute or use this message. If you have received this communication in 
error, please notify the sender and delete all copies of this message. 
Accelerite, a Persistent Systems business does not accept any liability for 
virus infected mails.





DISCLAIMER
==
This e-mail may contain privileged and confidential information which is the 
property of Accelerite, a Persistent Systems business. It is intended only for 
the use of the individual or entity to which it is addressed. If you are not 
the intended recipient, you are not authorized to read, retain, copy, print, 
distribute or use this message. If you have received this communication in 
error, please notify the sender and delete all copies of this message. 
Accelerite, a Persistent Systems business does not accept any liability for 
virus infected mails.


[GitHub] cloudstack pull request #1605: CLOUDSTACK-9428: Fix for CLOUDSTACK-9211 - Im...

2016-07-05 Thread sateesh-chodapuneedi
Github user sateesh-chodapuneedi commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1605#discussion_r69677623
  
--- Diff: 
plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java
 ---
@@ -2015,19 +2016,20 @@ protected StartAnswer execute(StartCommand cmd) {
 }
 
 /**
- * Sets video card memory to the one provided in detail svga.vramSize 
(if provided).
+ * Sets video card memory to the one provided in detail svga.vramSize 
(if provided) on {@code vmConfigSpec}.
  * 64MB was always set before.
  * Size must be in KB.
  * @param vmMo virtual machine mo
  * @param vmSpec virtual machine specs
+ * @param vmConfigSpec virtual machine config spec
  */
-protected void postVideoCardMemoryConfigBeforeStart(VirtualMachineMO 
vmMo, VirtualMachineTO vmSpec) {
+protected void videoCardMemoryConfig(VirtualMachineMO vmMo, 
VirtualMachineTO vmSpec, VirtualMachineConfigSpec vmConfigSpec) {
--- End diff --

Although the method name is apt for current scenario, i.e. configuring 
video RAM, this method could be used for different kinds of Video card 
configurations. Probably it is better to rename this to videoCardConfig or 
videoCardReconfig or so.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request #1605: CLOUDSTACK-9428: Fix for CLOUDSTACK-9211 - Im...

2016-07-05 Thread sateesh-chodapuneedi
Github user sateesh-chodapuneedi commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1605#discussion_r69677503
  
--- Diff: 
plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java
 ---
@@ -2015,19 +2016,20 @@ protected StartAnswer execute(StartCommand cmd) {
 }
 
 /**
- * Sets video card memory to the one provided in detail svga.vramSize 
(if provided).
+ * Sets video card memory to the one provided in detail svga.vramSize 
(if provided) on {@code vmConfigSpec}.
  * 64MB was always set before.
  * Size must be in KB.
  * @param vmMo virtual machine mo
  * @param vmSpec virtual machine specs
+ * @param vmConfigSpec virtual machine config spec
  */
-protected void postVideoCardMemoryConfigBeforeStart(VirtualMachineMO 
vmMo, VirtualMachineTO vmSpec) {
+protected void videoCardMemoryConfig(VirtualMachineMO vmMo, 
VirtualMachineTO vmSpec, VirtualMachineConfigSpec vmConfigSpec) {
 String paramVRamSize = "svga.vramSize";
--- End diff --

👍 Thanks @nvazquez for this PR. It indeed reduces additional API calls.
I'd suggest few minor changes though.
Please move this string constant "svga.vramSize" to VmDetailConstants which 
is place holder for VM detail constants.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


RE: [ANNOUNCE] Will Stevens as new Apache CloudStack VP

2016-05-19 Thread Sateesh Chodapuneedi
Congrats, Will!
Wish you the best.

Regards,
Sateesh Chodapuneedi
Chief Product Engineer, CloudPlatform Development, Accelerite.
Off: +91 80 6772 1329 | EMail: sateesh.chodapune...@accelerite.com

> -Original Message-
> From: Sebastien Goasguen [mailto:run...@gmail.com]
> Sent: Thursday, May 19, 2016 12:27 PM
> To: dev@cloudstack.apache.org; market...@cloudstack.apache.org;
> us...@cloudstack.apache.org
> Subject: [ANNOUNCE] Will Stevens as new Apache CloudStack VP
>
> Morning Everyone,
>
> Yesterday at the ASF board meeting, the board passed the resolution making
> Will Stevens the new Vice President of the Apache CloudStack project.
>
> Join me in congratulating Will on this appointment, wish him luck and bring 
> your
> unwavering support !
>
> You may have noticed that Will took on RM duties for the new releases going
> forward and has also taken a very active role to finish bringing us to github
> based  workflow and CI. Will has some updates on that front that I am sure you
> will all like.
>
> -Sebastien
> Former VP CloudStack



DISCLAIMER
==
This e-mail may contain privileged and confidential information which is the 
property of Accelerite, a Persistent Systems business. It is intended only for 
the use of the individual or entity to which it is addressed. If you are not 
the intended recipient, you are not authorized to read, retain, copy, print, 
distribute or use this message. If you have received this communication in 
error, please notify the sender and delete all copies of this message. 
Accelerite, a Persistent Systems business does not accept any liability for 
virus infected mails.


[GitHub] cloudstack pull request: DAO: Hit the cache for entity flagged as ...

2016-05-09 Thread sateesh-chodapuneedi
Github user sateesh-chodapuneedi commented on the pull request:

https://github.com/apache/cloudstack/pull/1532#issuecomment-217814911
  
Probably intention is to,
```java
T result = null
if (_cache != null) {
final Element element = _cache.get(id);
if (element != null) {
result = (T)element.getObjectValue();
} else {
result = findById(id, true, null);
}
return result;
```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request: DAO: Hit the cache for entity flagged as ...

2016-05-09 Thread sateesh-chodapuneedi
Github user sateesh-chodapuneedi commented on the pull request:

https://github.com/apache/cloudstack/pull/1532#issuecomment-217814496
  


@DaanHoogland I agree that's the best practice though there is a glitch 
here. Following code returns null if _cache is not null but element is null,
```java
T result = null
if (_cache != null) {
final Element element = _cache.get(id);
if (element != null) {
result = (T)element.getObjectValue();
}
} else {
result =findById(id, true, null);
}
return result;
```



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


  1   2   3   >