[GitHub] cloudstack issue #1762: CLOUDSTACK-9595 Transactions are not getting retried...
Github user yvsubhash commented on the issue: https://github.com/apache/cloudstack/pull/1762 @serg38 Is the refactoring suggested by rafael taken care by @nvazquez, else I would take it up --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #914: BUG-ID CLOUDSTACK-8939 VM Snapshot size with memory i...
Github user yvsubhash commented on the issue: https://github.com/apache/cloudstack/pull/914 tag:mergeready --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1759: CLOUDSTACK-9589 vmName entries from host_details tab...
Github user yvsubhash commented on the issue: https://github.com/apache/cloudstack/pull/1759 tag:mergeready --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #899: BUG-ID:CLOUDSTACK-8921 snapshot_store_ref table shoul...
Github user yvsubhash commented on the issue: https://github.com/apache/cloudstack/pull/899 tag:mergeready --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1756: CLOUDSTACK-9585 UI doesn't give an option to select ...
Github user yvsubhash commented on the issue: https://github.com/apache/cloudstack/pull/1756 tag:mergeready --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1740: CLOUDSTACK-9572 Snapshot on primary storage not clea...
Github user yvsubhash commented on the issue: https://github.com/apache/cloudstack/pull/1740 The following ticket is opened for fixing this issue https://issues.apache.org/jira/browse/CLOUDSTACK-9870 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request #1740: CLOUDSTACK-9572 Snapshot on primary storage n...
Github user yvsubhash closed the pull request at: https://github.com/apache/cloudstack/pull/1740 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1740: CLOUDSTACK-9572 Snapshot on primary storage not clea...
Github user yvsubhash commented on the issue: https://github.com/apache/cloudstack/pull/1740 Closing this PR as it is no longer needed --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1721: CLOUDSTACK-9557 Deploy from VMsnapshot fails with ex...
Github user yvsubhash commented on the issue: https://github.com/apache/cloudstack/pull/1721 Closing this as change would be added to #1664 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request #1721: CLOUDSTACK-9557 Deploy from VMsnapshot fails ...
Github user yvsubhash closed the pull request at: https://github.com/apache/cloudstack/pull/1721 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1664: CLOUDSTACK-8676 Deploy user instance from vm snapsho...
Github user yvsubhash commented on the issue:
https://github.com/apache/cloudstack/pull/1664
@sateesh-chodapuneedi Please take care of the code change in the following
PR as well as i am closing
https://github.com/apache/cloudstack/pull/1721
The change is as follows
server/src/com/cloud/vm/UserVmManagerImpl.java
@@ -3242,8 +3242,9 @@ protected UserVm createVirtualMachine(DataCenter
zone, ServiceOffering serviceOf
throw new InvalidParameterValueException("Installing from ISO
requires an ISO that is bootable: " + template.getId());
}
-// Check templates permissions
-_accountMgr.checkAccess(owner, AccessType.UseEntry, false,
template);
+// Check templates permissions when the create vm is not from
snapshot
+if(vmSnapshot == null)
+_accountMgr.checkAccess(owner, AccessType.UseEntry, false,
template);
// check if the user data is correct
validateUserData(userData, httpmethod);
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #827: BUG-ID: CLOUDSTACK-8849: Usage job should stop usage ...
Github user yvsubhash commented on the issue: https://github.com/apache/cloudstack/pull/827 Closing this PR --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request #827: BUG-ID: CLOUDSTACK-8849: Usage job should stop...
Github user yvsubhash closed the pull request at: https://github.com/apache/cloudstack/pull/827 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #905: BUG-ID: CLOUDSTACK-8922: Unable to delete IP tag
Github user yvsubhash commented on the issue: https://github.com/apache/cloudstack/pull/905 tag:mergeready --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #2012: CLOUDSTACK-9842: Unable to map root volume usage to ...
Github user yvsubhash commented on the issue: https://github.com/apache/cloudstack/pull/2012 Tested this change. LGTM for test --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1726: CLOUDSTACK-9560 Root volume of deleted VM left unrem...
Github user yvsubhash commented on the issue: https://github.com/apache/cloudstack/pull/1726 tag:mergeready --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request #921: CLOUDSTACK-8944 Template download possible fro...
Github user yvsubhash closed the pull request at: https://github.com/apache/cloudstack/pull/921 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #921: CLOUDSTACK-8944 Template download possible from new n...
Github user yvsubhash commented on the issue: https://github.com/apache/cloudstack/pull/921 Closing this PR, as this is no longer needed --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1725: CLOUDSTACK-9559 Why allow deleting zone without dele...
Github user yvsubhash commented on the issue: https://github.com/apache/cloudstack/pull/1725 tag:mergeready --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request #914: BUG-ID CLOUDSTACK-8939 VM Snapshot size with m...
Github user yvsubhash commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/914#discussion_r109123538
--- Diff:
plugins/hypervisors/xenserver/src/com/cloud/hypervisor/xenserver/resource/CitrixResourceBase.java
---
@@ -3206,25 +3206,33 @@ public long getVMSnapshotChainSize(final Connection
conn, final VolumeObjectTO v
}
}
if (volumeTo.getVolumeType() == Volume.Type.ROOT) {
-final Map<VM, VM.Record> allVMs = VM.getAllRecords(conn);
-// add size of memory snapshot vdi
-if (allVMs != null && allVMs.size() > 0) {
-for (final VM vmr : allVMs.keySet()) {
-try {
-final String vName = vmr.getNameLabel(conn);
-if (vName != null && vName.contains(vmName) &&
vmr.getIsASnapshot(conn)) {
-final VDI memoryVDI = vmr.getSuspendVDI(conn);
-if (!isRefNull(memoryVDI)) {
-size = size +
memoryVDI.getPhysicalUtilisation(conn);
-final VDI pMemoryVDI =
memoryVDI.getParent(conn);
-if (!isRefNull(pMemoryVDI)) {
-size = size +
pMemoryVDI.getPhysicalUtilisation(conn);
+VM vm = getVM(conn, vmName);
--- End diff --
@sudhansu7 exception needs to be caught at the callers otherwise it would
end up setting zero size
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #899: BUG-ID:CLOUDSTACK-8921 snapshot_store_ref table shoul...
Github user yvsubhash commented on the issue: https://github.com/apache/cloudstack/pull/899 @SudharmaJain its taken care --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #2019: CLOUDSTACK-9851 travis CI build failure after merge ...
Github user yvsubhash commented on the issue: https://github.com/apache/cloudstack/pull/2019 LGTM for code changes --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1726: CLOUDSTACK-9560 Root volume of deleted VM left unrem...
Github user yvsubhash commented on the issue: https://github.com/apache/cloudstack/pull/1726 @ustcweizhou coding convention issue is taken care --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1740: CLOUDSTACK-9572 Snapshot on primary storage not clea...
Github user yvsubhash commented on the issue: https://github.com/apache/cloudstack/pull/1740 @syed On the xenserver we always keep the latest snapshot in primary as xenserver needs it to create delta snapshots. If the snapshot is not present in xenserver, next snapshot would create full snapshot rather than delta snapshot. Please refer to the bug related to that https://issues.apache.org/jira/browse/CLOUDSTACK-2630 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1726: CLOUDSTACK-9560 Root volume of deleted VM left unrem...
Github user yvsubhash commented on the issue: https://github.com/apache/cloudstack/pull/1726 @ustcweizhou does it look good to you now? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #827: BUG-ID: CLOUDSTACK-8849: Usage job should stop usage ...
Github user yvsubhash commented on the issue: https://github.com/apache/cloudstack/pull/827 @ustcweizhou Do you still have some queries on it? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request #1726: CLOUDSTACK-9560 Root volume of deleted VM lef...
Github user yvsubhash commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1726#discussion_r104374914
--- Diff: server/src/com/cloud/storage/StorageManagerImpl.java ---
@@ -2263,27 +2264,43 @@ public void cleanupDownloadUrls(){
// Cleanup expired volume URLs
List volumesOnImageStoreList =
_volumeStoreDao.listVolumeDownloadUrls();
+HashSet expiredVolumeIds = new HashSet();
+HashSet activeVolumeIds = new HashSet();
for(VolumeDataStoreVO volumeOnImageStore :
volumesOnImageStoreList){
+long volumeId = volumeOnImageStore.getVolumeId();
try {
long downloadUrlCurrentAgeInSecs =
DateUtil.getTimeDifference(DateUtil.now(),
volumeOnImageStore.getExtractUrlCreated());
if(downloadUrlCurrentAgeInSecs <
_downloadUrlExpirationInterval){ // URL hasnt expired yet
+activeVolumeIds.add(volumeId);
continue;
}
-
-s_logger.debug("Removing download url " +
volumeOnImageStore.getExtractUrl() + " for volume id " +
volumeOnImageStore.getVolumeId());
+expiredVolumeIds.add(volumeId);
+s_logger.debug("Removing download url " +
volumeOnImageStore.getExtractUrl() + " for volume id " + volumeId);
// Remove it from image store
ImageStoreEntity secStore = (ImageStoreEntity)
_dataStoreMgr.getDataStore(volumeOnImageStore.getDataStoreId(),
DataStoreRole.Image);
secStore.deleteExtractUrl(volumeOnImageStore.getInstallPath(),
volumeOnImageStore.getExtractUrl(), Upload.Type.VOLUME);
+_snapshotStoreDao.findByVolume(volumeId,
DataStoreRole.Image);
--- End diff --
@ustcweizhou That was not needed. So removed that same
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1726: CLOUDSTACK-9560 Root volume of deleted VM left unrem...
Github user yvsubhash commented on the issue: https://github.com/apache/cloudstack/pull/1726 @ustcweizhou Please review --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request #1987: CLOUDSTACK-9814 : Unable to edit a Sub domain...
Github user yvsubhash commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1987#discussion_r104140435
--- Diff: server/src/org/apache/cloudstack/region/RegionManagerImpl.java ---
@@ -229,7 +232,7 @@ public boolean deleteUser(DeleteUserCmd cmd) {
*/
@Override
public Domain updateDomain(UpdateDomainCmd cmd) {
-return _domainMgr.updateDomain(cmd);
+return _managementService.updateDomain(cmd);
--- End diff --
Instead of changing the method that is getting called, the missing one in
search query can be added here and it seems the updateDomain method in
managementserviceimpl is not in use. It can be removed
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1984: CLOUDSTACK-9812:Update "updatePortForwardingRule" pi...
Github user yvsubhash commented on the issue: https://github.com/apache/cloudstack/pull/1984 @mrunalinikankariya One of the commits is not related to the issue --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1734: CLOUDSTACK-9567 Difference in the api call outputs f...
Github user yvsubhash commented on the issue: https://github.com/apache/cloudstack/pull/1734 LGTM for the code --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1942: CLOUDSTACK-9784 : GPU detail not displayed in GPU ta...
Github user yvsubhash commented on the issue: https://github.com/apache/cloudstack/pull/1942 LGTM for code changes --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request #1908: CLOUDSTACK-9317: Fixed disable static nat on ...
Github user yvsubhash commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1908#discussion_r96598944
--- Diff: server/src/com/cloud/network/router/CommandSetupHelper.java ---
@@ -823,13 +826,39 @@ public int compare(final PublicIpAddress o1, final
PublicIpAddress o2) {
associatedWithNetworkId = ipAddrList.get(0).getNetworkId();
}
+// for network if the ips does not have any rules, then only
last ip
+List userIps =
_ipAddressDao.listByAssociatedNetwork(associatedWithNetworkId, null);
+
+int ipsWithrules = 0;
+int ipsStaticNat = 0;
+for (IPAddressVO ip : userIps) {
+if ( _firewallsDao.countRulesByIpIdAndState(ip.getId(),
FirewallRule.State.Active) > 0 ) {
+ipsWithrules++;
+}
+
+if (ip.isOneToOneNat()) {
+ipsStaticNat++;
+}
+}
+
final IpAssocCommand cmd = new IpAssocCommand(ipsToSend);
cmd.setAccessDetail(NetworkElementCommand.ROUTER_IP,
_routerControlHelper.getRouterControlIp(router.getId()));
cmd.setAccessDetail(NetworkElementCommand.ROUTER_GUEST_IP,
_routerControlHelper.getRouterIpInNetwork(associatedWithNetworkId,
router.getId()));
cmd.setAccessDetail(NetworkElementCommand.ROUTER_NAME,
router.getInstanceName());
final DataCenterVO dcVo =
_dcDao.findById(router.getDataCenterId());
cmd.setAccessDetail(NetworkElementCommand.ZONE_NETWORK_TYPE,
dcVo.getNetworkType().toString());
+boolean remove = false;
+// if there is only one static nat then it will be checked for
remove at the resource
+if (ipsWithrules == 0 && (ipsStaticNat == 0 || ipsStaticNat ==
1)) {
--- End diff --
Can you combine these two if blocks and eliminate remove variable if this
is not getting used at a later place
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1759: CLOUDSTACK-9589 vmName entries from host_details tab...
Github user yvsubhash commented on the issue: https://github.com/apache/cloudstack/pull/1759 @rhtyd can you suggest me the branch for rebasing this commit against? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1726: CLOUDSTACK-9560 Root volume of deleted VM left unrem...
Github user yvsubhash commented on the issue: https://github.com/apache/cloudstack/pull/1726 @ustcweizhou thats good point. It should be removed after all download links expire. I will address this case --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1725: CLOUDSTACK-9559 Why allow deleting zone without dele...
Github user yvsubhash commented on the issue: https://github.com/apache/cloudstack/pull/1725 @rhtyd Can you please merge this --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1726: CLOUDSTACK-9560 Root volume of deleted VM left unrem...
Github user yvsubhash commented on the issue: https://github.com/apache/cloudstack/pull/1726 @ustcweizhou As I understand, Volume goes to Expunged state when it is removed from primary and gets removed when it is removed from secondary storage. line 2211 to 2215 is to handle specific case where volume getting removed from primary But not getting removed from secondary because of the download link. So cleaning up the same after the downlink is expired --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1726: CLOUDSTACK-9560 Root volume of deleted VM left unrem...
Github user yvsubhash commented on the issue: https://github.com/apache/cloudstack/pull/1726 @ustcweizhou In case of volume snapsnots, volume gets set to removed irrespective of the presence of snapshots. I have verified the same just now and I am only removing volume not any of the snapshots --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1726: CLOUDSTACK-9560 Root volume of deleted VM left unrem...
Github user yvsubhash commented on the issue: https://github.com/apache/cloudstack/pull/1726 @rhtyd Can you please merge this --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request #1725: CLOUDSTACK-9559 Why allow deleting zone witho...
GitHub user yvsubhash reopened a pull request: https://github.com/apache/cloudstack/pull/1725 CLOUDSTACK-9559 Why allow deleting zone without deleting the seconda⦠CLOUDSTACK-9559 allow deleting zone without deleting the secondary storage under the zone You can merge this pull request into a Git repository by running: $ git pull https://github.com/yvsubhash/cloudstack CLOUDSTACK-9559 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cloudstack/pull/1725.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1725 commit 1c7722d7cc9c60ff1edcbecb4f8046a6cfb4c9c8 Author: subhash_y <venkata.yedugun...@accelerite.com> Date: 2016-10-04T11:57:43Z CLOUDSTACK-9559 Why allow deleting zone without deleting the secondary storage under the zone --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request #1725: CLOUDSTACK-9559 Why allow deleting zone witho...
Github user yvsubhash closed the pull request at: https://github.com/apache/cloudstack/pull/1725 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1726: CLOUDSTACK-9560 Root volume of deleted VM left unrem...
Github user yvsubhash commented on the issue: https://github.com/apache/cloudstack/pull/1726 @ustcweizhou Volume snapshots would be left over even in case of normal vm destroy and that is expected. They can be used if there is a need to restore the volume at a later point in time. The snapshots are visible under storage->snapshots. So i dont see a need to clean up those snapshots --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #896: CLOUDSTACK-8908 After copying the template charging f...
Github user yvsubhash commented on the issue: https://github.com/apache/cloudstack/pull/896 @rhtyd Can you plz merge this? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #827: BUG-ID: CLOUDSTACK-8849: Usage job should stop usage ...
Github user yvsubhash commented on the issue: https://github.com/apache/cloudstack/pull/827 @ustcweizhou By stopping the usage server, we can fix the records and continue in the next run. If we simply skip we wont come to know abt the records with errors. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request #1722: CLOUDSTACK-9558 Cleanup the snapshots on the ...
Github user yvsubhash commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1722#discussion_r91570095
--- Diff:
engine/storage/snapshot/src/org/apache/cloudstack/storage/snapshot/XenserverSnapshotStrategy.java
---
@@ -260,11 +260,15 @@ public boolean deleteSnapshot(Long snapshotId) {
boolean result = deleteSnapshotChain(snapshotOnImage);
obj.processEvent(Snapshot.Event.OperationSucceeded);
if (result) {
-//snapshot is deleted on backup storage, need to delete it
on primary storage
-SnapshotDataStoreVO snapshotOnPrimary =
snapshotStoreDao.findBySnapshot(snapshotId, DataStoreRole.Primary);
-if (snapshotOnPrimary != null) {
-snapshotOnPrimary.setState(State.Destroyed);
-snapshotStoreDao.update(snapshotOnPrimary.getId(),
snapshotOnPrimary);
+SnapshotInfo snapshotOnPrimary =
snapshotDataFactory.getSnapshot(snapshotId, DataStoreRole.Primary);
+if(snapshotSvr.deleteSnapshot(snapshotOnPrimary)) {
--- End diff --
If the db state is set to 'destroyed', it would no longer visible in the ui
and entry would be left behind in primary. Leaving it as is keeps the option of
manual cleanup
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request #1722: CLOUDSTACK-9558 Cleanup the snapshots on the ...
Github user yvsubhash commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1722#discussion_r91569719
--- Diff:
engine/storage/snapshot/src/org/apache/cloudstack/storage/snapshot/XenserverSnapshotStrategy.java
---
@@ -260,11 +260,15 @@ public boolean deleteSnapshot(Long snapshotId) {
boolean result = deleteSnapshotChain(snapshotOnImage);
obj.processEvent(Snapshot.Event.OperationSucceeded);
if (result) {
-//snapshot is deleted on backup storage, need to delete it
on primary storage
-SnapshotDataStoreVO snapshotOnPrimary =
snapshotStoreDao.findBySnapshot(snapshotId, DataStoreRole.Primary);
-if (snapshotOnPrimary != null) {
-snapshotOnPrimary.setState(State.Destroyed);
-snapshotStoreDao.update(snapshotOnPrimary.getId(),
snapshotOnPrimary);
+SnapshotInfo snapshotOnPrimary =
snapshotDataFactory.getSnapshot(snapshotId, DataStoreRole.Primary);
--- End diff --
Yes it should be updated in this case as well. It is taken care
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1759: CLOUDSTACK-9589 vmName entries from host_details tab...
Github user yvsubhash commented on the issue: https://github.com/apache/cloudstack/pull/1759 @rhtyd rebased to 4.9 branch as suggested --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1725: CLOUDSTACK-9559 Why allow deleting zone without dele...
Github user yvsubhash commented on the issue: https://github.com/apache/cloudstack/pull/1725 @rhtyd To answer your other question, lets say there are templates in the secondary storage, they can not be deleted because the zone is no longer there. As we have checks all other zone level resources, i feel it makes sense to check for secondary storage as well --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1725: CLOUDSTACK-9559 Why allow deleting zone without dele...
Github user yvsubhash commented on the issue: https://github.com/apache/cloudstack/pull/1725 @rhtyd Failures are taken care --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1722: CLOUDSTACK-9558 Cleanup the snapshots on the primary...
Github user yvsubhash commented on the issue: https://github.com/apache/cloudstack/pull/1722 @koushik-das can you please review --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #827: BUG-ID: CLOUDSTACK-8849: Usage job should stop usage ...
Github user yvsubhash commented on the issue: https://github.com/apache/cloudstack/pull/827 @ustcweizhou In case we continue with usage generation, we may miss out some of the records which actually resulted in exception and would in turn lead to wrong usage numbers. stopping after the exception can help in running the usage server once the errors are fixed can result in proper usage generation. May I know the reason for you to think usage generation should not be stopped --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1586: CLOUDSTACK-9410 Data Disk shown as detached in XS
Github user yvsubhash commented on the issue: https://github.com/apache/cloudstack/pull/1586 @syed @koushik-das can one of you please merge this --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1759: CLOUDSTACK-9589 vmName entries from host_details tab...
Github user yvsubhash commented on the issue: https://github.com/apache/cloudstack/pull/1759 @jburwell Change is moved to schema-481to4820.sql and base branch is changed to 4.8 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request #1761: CLOUDSTACK-9592 Empty responses from site to ...
Github user yvsubhash commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1761#discussion_r88432900
--- Diff: core/src/com/cloud/agent/api/CheckS2SVpnConnectionsAnswer.java ---
@@ -76,4 +76,14 @@ public String getDetail(String ip) {
}
return null;
}
+
+public boolean isIPPresent(String ip) {
+if (this.getResult()) {
+Boolean status = ipToConnected.get(ip);
+if (status != null) {
--- End diff --
@jburwell VirtualNetworkApplianceManagerImplTest.java has all tests
commented out. are there any other place having tests covering this?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request #1761: CLOUDSTACK-9592 Empty responses from site to ...
Github user yvsubhash commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1761#discussion_r88431269
--- Diff: core/src/com/cloud/agent/api/CheckS2SVpnConnectionsAnswer.java ---
@@ -76,4 +76,14 @@ public String getDetail(String ip) {
}
return null;
}
+
+public boolean isIPPresent(String ip) {
+if (this.getResult()) {
+Boolean status = ipToConnected.get(ip);
+if (status != null) {
--- End diff --
@jburwell changed the base branch to 4.9
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request #1761: CLOUDSTACK-9592 Empty responses from site to ...
Github user yvsubhash commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1761#discussion_r88429916
--- Diff: core/src/com/cloud/agent/api/CheckS2SVpnConnectionsAnswer.java ---
@@ -76,4 +76,14 @@ public String getDetail(String ip) {
}
return null;
}
+
+public boolean isIPPresent(String ip) {
+if (this.getResult()) {
+Boolean status = ipToConnected.get(ip);
+if (status != null) {
--- End diff --
Yes The check to see whether ip is there in the response. So it should be
true even when status is false
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #827: BUG-ID: CLOUDSTACK-8849: Usage job should stop usage ...
Github user yvsubhash commented on the issue: https://github.com/apache/cloudstack/pull/827 @rodrigo93 Exception in this part of code should stop further usage generation. Catching it here is suppressing the exception. The fix is tested manually by simulating the scenario @rhtyd it is rebased to 4.8 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #896: CLOUDSTACK-8908 After copying the template charging f...
Github user yvsubhash commented on the issue: https://github.com/apache/cloudstack/pull/896 @rhtyd rebase to 4.8 is done --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1721: CLOUDSTACK-9557 Deploy from VMsnapshot fails with ex...
Github user yvsubhash commented on the issue: https://github.com/apache/cloudstack/pull/1721 @rhtyd i will merge this to #1664 once the conflicts are resolved int the other one --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request #1740: CLOUDSTACK-9572 Snapshot on primary storage n...
GitHub user yvsubhash reopened a pull request: https://github.com/apache/cloudstack/pull/1740 CLOUDSTACK-9572 Snapshot on primary storage not cleaned up after Stor⦠Snapshot on primary storage not cleaned up after Storage migration. This happens in the following scenario ## Steps To Reproduce 1. Create an instance on the local storage on any host 2. Create a scheduled snapshot of the volume: 3. Wait until ACS created the snapshot. ACS is creating a snapshot on local storage and is transferring this snapshot to secondary storage. But the latest snapshot on local storage will stay there. This is as expected. 4. Migrate the instance to another XenServer host with ACS UI and Storage Live Migration 5. The Snapshot on the old host on local storage will not be cleaned up and is staying on local storage. So local storage will fill up with unneeded snapshots. You can merge this pull request into a Git repository by running: $ git pull https://github.com/yvsubhash/cloudstack CLOUDSTACK-9572 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cloudstack/pull/1740.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1740 commit 13820fdae5a22573db1c964f02e37d232228b3d8 Author: subhash yedugundla <venkatasubhashnaidu.yedugun...@citrix.com> Date: 2016-09-12T13:29:53Z CLOUDSTACK-9572 Snapshot on primary storage not cleaned up after Storage migration --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request #1740: CLOUDSTACK-9572 Snapshot on primary storage n...
Github user yvsubhash closed the pull request at: https://github.com/apache/cloudstack/pull/1740 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1716: CLOUDSTACK-9555 when a template is deleted and then ...
Github user yvsubhash commented on the issue: https://github.com/apache/cloudstack/pull/1716 @karuturi travis is fine now. two failed tests are not related to this --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request #1762: CLOUDSTACK-9595 Transactions are not getting ...
GitHub user yvsubhash opened a pull request: https://github.com/apache/cloudstack/pull/1762 CLOUDSTACK-9595 Transactions are not getting retried in case of datab⦠CLOUDSTACK-9595 Transactions are not getting retried in case of database deadlock errors Problem Statement -- MySQLTransactionRollbackException is seen frequently in logs Root Cause Attempts to lock rows in the core data access layer of database fails if there is a possibility of deadlock. However Operations are not getting retried in case of deadlock. So introducing retries here Solution --- Operations would be retried after some wait time in case of dead lock exception You can merge this pull request into a Git repository by running: $ git pull https://github.com/yvsubhash/cloudstack CLOUDSTACK-9595 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cloudstack/pull/1762.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1762 commit 600ae7cbee28d43e6007979b87e150abd2a70a7e Author: subhash yedugundla <venkatasubhashnaidu.yedugun...@citrix.com> Date: 2016-06-14T10:16:16Z CLOUDSTACK-9595 Transactions are not getting retried in case of database deadlock errors --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request #1761: CLOUDSTACK-9592 Empty responses from site to ...
GitHub user yvsubhash opened a pull request:
https://github.com/apache/cloudstack/pull/1761
CLOUDSTACK-9592 Empty responses from site to site connection status aâ¦
CLOUDSTACK-9592 Empty responses from site to site connection status are not
handled propertly
vpn connection status gives responses like the below sometimes
Processing: { Ans: , MgmtId: 7203499016310, via: 1(10.147.28.37), Ver: v1,
Flags: 110,
[{"com.cloud.agent.api.CheckS2SVpnConnectionsAnswer":{"ipToConnected":{},"ipToDetail":{},"details":"","result":true,"wait":0}}]
}
2016-09-27 08:52:19,211 DEBUG [c.c.a.t.Request]
(RouterStatusMonitor-1:ctx-c20f391d) (logid:c217239d) Seq
1-2315413158421863581: Received: { Ans: , MgmtId: 7203499016310, via:
1(10.147.28.37), Ver: v1, Flags: 110,
{ CheckS2SVpnConnectionsAnswer }
In the above scenario, the bug in the processing of this response assumes
the connection is disconnected even though it is not disconnected and there
would be two consecutive alerts in logs as well as emails even though there is
not actual disconnection and reconnection
Site-to-site Vpn Connection XYZ-VPN on router r-197-VM(id: 197) just switch
from Disconnected to Connected
Site-to-site Vpn Connection to D1 site to site VPN on router r-372-VM(id:
372) just switch from Connected to Disconnected
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/yvsubhash/cloudstack CLOUDSTACK-9592
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cloudstack/pull/1761.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1761
commit 6c8bab5fe30a1c1adacb9b73afe89c41f00cad17
Author: subhash yedugundla <venkatasubhashnaidu.yedugun...@citrix.com>
Date: 2016-06-24T09:36:48Z
CLOUDSTACK-9592 Empty responses from site to site connection status are not
handled propertly
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request #1759: CLOUDSTACK-9589 vmName entries from host_deta...
GitHub user yvsubhash opened a pull request: https://github.com/apache/cloudstack/pull/1759 CLOUDSTACK-9589 vmName entries from host_details table for the VM's w⦠CLOUDSTACK-9589 vmName entries from host_details table for the VM's whose state is Expunging should be deleted during upgrade from older versions Having vmName entries for VMs in 'expunging' states would cause with deploying VMs with matching host tags fail. So removing them during upgrade You can merge this pull request into a Git repository by running: $ git pull https://github.com/yvsubhash/cloudstack CLOUDSTACK-9589 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cloudstack/pull/1759.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1759 commit 45114ec507692d9ca6cb9b4564db474da5f1b76a Author: subhash_y <venkata.yedugun...@accelerite.com> Date: 2016-11-10T12:23:21Z CLOUDSTACK-9589 vmName entries from host_details table for the VM's whose state is Expunging should be deleted during upgrade from older versions --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1586: CLOUDSTACK-9410 Data Disk shown as detached in XS
Github user yvsubhash commented on the issue: https://github.com/apache/cloudstack/pull/1586 @cloudmonger None of the test failures are related to the code change --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request #1740: CLOUDSTACK-9572 Snapshot on primary storage n...
GitHub user yvsubhash opened a pull request: https://github.com/apache/cloudstack/pull/1740 CLOUDSTACK-9572 Snapshot on primary storage not cleaned up after Stor⦠Snapshot on primary storage not cleaned up after Storage migration. This happens in the following two scenarios Live Migration Case 1. Create an instance on the local storage on any host 2. Create a scheduled snapshot of the volume: 3. Wait until ACS created the snapshot. ACS is creating a snapshot on local storage and is transferring this snapshot to secondary storage. But the latest snapshot on local storage will stay there. This is as expected. 4. Migrate the instance to another XenServer host with ACS UI and Storage Live Migration 5. The Snapshot on the old host on local storage will not be cleaned up and is staying on local storage. So local storage will fill up with unneeded snapshots. You can merge this pull request into a Git repository by running: $ git pull https://github.com/yvsubhash/cloudstack CLOUDSTACK-9572 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cloudstack/pull/1740.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1740 commit 66391617d0fd3f404719c7f675eef5be7ee4ee2f Author: subhash yedugundla <venkatasubhashnaidu.yedugun...@citrix.com> Date: 2016-09-12T13:29:53Z CLOUDSTACK-9572 Snapshot on primary storage not cleaned up after Storage migration --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1726: CLOUDSTACK-9560 Root volume of deleted VM left unrem...
Github user yvsubhash commented on the issue: https://github.com/apache/cloudstack/pull/1726 @koushik-das Added the null check --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request #1726: CLOUDSTACK-9560 Root volume of deleted VM lef...
Github user yvsubhash commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1726#discussion_r84859378
--- Diff: server/src/com/cloud/storage/StorageManagerImpl.java ---
@@ -2199,15 +2199,20 @@ public void cleanupDownloadUrls(){
if(downloadUrlCurrentAgeInSecs <
_downloadUrlExpirationInterval){ // URL hasnt expired yet
continue;
}
-
-s_logger.debug("Removing download url " +
volumeOnImageStore.getExtractUrl() + " for volume id " +
volumeOnImageStore.getVolumeId());
+long volumeId = volumeOnImageStore.getVolumeId();
+s_logger.debug("Removing download url " +
volumeOnImageStore.getExtractUrl() + " for volume id " + volumeId);
// Remove it from image store
ImageStoreEntity secStore = (ImageStoreEntity)
_dataStoreMgr.getDataStore(volumeOnImageStore.getDataStoreId(),
DataStoreRole.Image);
secStore.deleteExtractUrl(volumeOnImageStore.getInstallPath(),
volumeOnImageStore.getExtractUrl(), Upload.Type.VOLUME);
// Now expunge it from DB since this entry was created
only for download purpose
_volumeStoreDao.expunge(volumeOnImageStore.getId());
+Volume volume = _volumeDao.findById(volumeId);
+if (volume.getState() == Volume.State.Expunged)
--- End diff --
@koushik-das Having a null for volume is not a possible scenario as there
is db level relation ship between volume and volume_store_ref and the id is
picked up from volume_store_ref. Would you still recommend having a null check
here?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request #1726: CLOUDSTACK-9560 Root volume of deleted VM lef...
GitHub user yvsubhash opened a pull request: https://github.com/apache/cloudstack/pull/1726 CLOUDSTACK-9560 Root volume of deleted VM left unremoved You can merge this pull request into a Git repository by running: $ git pull https://github.com/yvsubhash/cloudstack CLOUDSTACK-9560 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cloudstack/pull/1726.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1726 commit a4e8cc20db18e04ec8cce4a90676b5ef632debe9 Author: subhash yedugundla <venkatasubhashnaidu.yedugun...@citrix.com> Date: 2016-05-31T11:45:04Z CLOUDSTACK-9560 Root volume of deleted VM left unremoved --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request #1725: CLOUDSTACK-9559 Why allow deleting zone witho...
GitHub user yvsubhash opened a pull request: https://github.com/apache/cloudstack/pull/1725 CLOUDSTACK-9559 Why allow deleting zone without deleting the seconda⦠CLOUDSTACK-9559 allow deleting zone without deleting the secondary storage under the zone You can merge this pull request into a Git repository by running: $ git pull https://github.com/yvsubhash/cloudstack CLOUDSTACK-9559 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cloudstack/pull/1725.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1725 commit ad797c85ea30c9af470f180829469ba714b73ff1 Author: subhash_y <venkata.yedugun...@accelerite.com> Date: 2016-10-04T11:57:43Z CLOUDSTACK-9559 Why allow deleting zone without deleting the secondary storage under the zone --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request #1722: CLOUDSTACK-9558 Cleanup the snapshots on the ...
GitHub user yvsubhash opened a pull request: https://github.com/apache/cloudstack/pull/1722 CLOUDSTACK-9558 Cleanup the snapshots on the primary storage of Xense⦠Cleanup the snapshots on the primary storage of Xenserver after VM/Volume is expunged You can merge this pull request into a Git repository by running: $ git pull https://github.com/yvsubhash/cloudstack CLOUDSTACK-9558 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cloudstack/pull/1722.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1722 commit 0ff5a5329ec047fe4872347a26236da75ce5eef7 Author: subhash_y Date: 2016-08-29T05:15:03Z CLOUDSTACK-9558 Cleanup the snapshots on the primary storage of Xenserver after VM/Volume is expunged --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request #1721: CLOUDSTACK-9557 Deploy from VMsnapshot fails ...
GitHub user yvsubhash opened a pull request: https://github.com/apache/cloudstack/pull/1721 CLOUDSTACK-9557 Deploy from VMsnapshot fails with exception if source⦠Deploy from VMsnapshot fails with exception if source template is removed or made private You can merge this pull request into a Git repository by running: $ git pull https://github.com/yvsubhash/cloudstack CLOUDSTACK-9557 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cloudstack/pull/1721.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1721 commit 02edceb50b8fc1d7c12d02d33bda1fa62e7c14aa Author: subhash yedugundla <venkatasubhashnaidu.yedugun...@citrix.com> Date: 2016-07-14T06:43:10Z CLOUDSTACK-9557 Deploy from VMsnapshot fails with exception if source template is removed or made private --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request #1720: Bug-Id:CS-47456 Deploy from VMsnapshot fails ...
Github user yvsubhash closed the pull request at: https://github.com/apache/cloudstack/pull/1720 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request #1720: Bug-Id:CS-47456 Deploy from VMsnapshot fails ...
GitHub user yvsubhash opened a pull request: https://github.com/apache/cloudstack/pull/1720 Bug-Id:CS-47456 Deploy from VMsnapshot fails with exception if source⦠Deploy from VMsnapshot fails with exception if sourcetemplate is removed or made private Reviewed-By:sudharma You can merge this pull request into a Git repository by running: $ git pull https://github.com/yvsubhash/cloudstack CLOUDSTACK-9557 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cloudstack/pull/1720.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1720 commit d377ebf8a5f59063eb1f4d54e72070328a34 Author: subhash yedugundla <venkatasubhashnaidu.yedugun...@citrix.com> Date: 2016-07-14T06:43:10Z Bug-Id:CS-47456 Deploy from VMsnapshot fails with exception if source template is removed or made private Reviewed-By:sudharma --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1715: CLOUDSTACK-9554 Juniper Contrail plug-in is publishi...
Github user yvsubhash commented on the issue: https://github.com/apache/cloudstack/pull/1715 @rhtyd PR pointed to 4.8 branch --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1715: CLOUDSTACK-9554 Juniper Contrail plug-in is publishi...
Github user yvsubhash commented on the issue: https://github.com/apache/cloudstack/pull/1715 @rhtyd How abt rebasing it against branch 4.8 and edit the PR to base it to the same? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request #1716: CLOUDSTACK-9555 when a template is deleted an...
GitHub user yvsubhash opened a pull request: https://github.com/apache/cloudstack/pull/1716 CLOUDSTACK-9555 when a template is deleted and then copied over again⦠when a template is deleted and then copied over again , it is still marked as Removed in template_zone_ref table You can merge this pull request into a Git repository by running: $ git pull https://github.com/yvsubhash/cloudstack CLOUDSTACK-9555 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cloudstack/pull/1716.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1716 commit 96eacf412cb441ba6cf913b170b46b0fe581c6c9 Author: Bharat Kumar <bharat.ku...@citrix.com> Date: 2014-11-04T08:45:22Z CLOUDSTACK-9555 when a template is deleted and then copied over again , it is still marked as Removed in template_zone_ref table --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request #1715: CLOUDSTACK-9554 Juniper Contrail plug-in is p...
GitHub user yvsubhash opened a pull request: https://github.com/apache/cloudstack/pull/1715 CLOUDSTACK-9554 Juniper Contrail plug-in is publishing events to wron⦠Juniper Contrail plug-in is publishing events to message bus instead of event bus You can merge this pull request into a Git repository by running: $ git pull https://github.com/yvsubhash/cloudstack CLOUDSTACK-9554 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cloudstack/pull/1715.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1715 commit 92cebbef0cee94966f80ac3ba8dd711fb31f Author: subhash yedugundla <venkatasubhashnaidu.yedugun...@citrix.com> Date: 2016-08-17T08:38:53Z CLOUDSTACK-9554 Juniper Contrail plug-in is publishing events to wrong message bus --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request #1714: CLOUDSTACK-9553 Usage event is not getting re...
GitHub user yvsubhash opened a pull request: https://github.com/apache/cloudstack/pull/1714 CLOUDSTACK-9553 Usage event is not getting recorded for snapshots in ⦠â¦a specific scenario You can merge this pull request into a Git repository by running: $ git pull https://github.com/yvsubhash/cloudstack CLOUDSTACK-9553 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cloudstack/pull/1714.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1714 commit 488711ba07afab4918b0a201c35ecff70e9e29e5 Author: subhash_y <venkata.yedugun...@accelerite.com> Date: 2016-09-22T07:29:07Z CLOUDSTACK-9553 Usage event is not getting recorded for snapshots in a specific scenario --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1586: CLOUDSTACK-9410 Data Disk shown as detached in XS
Github user yvsubhash commented on the issue: https://github.com/apache/cloudstack/pull/1586 @wido Replacing the original name with 'detached is not correct as it is confusing. Anyway data disk being detached is captured in the state of the volume --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request #1586: CLOUDSTACK-9410 Data Disk shown as detached i...
GitHub user yvsubhash opened a pull request: https://github.com/apache/cloudstack/pull/1586 CLOUDSTACK-9410 Data Disk shown as detached in XS You can merge this pull request into a Git repository by running: $ git pull https://github.com/yvsubhash/cloudstack CLOUDSTACK-9410 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cloudstack/pull/1586.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1586 commit 4ac8613ea39b96abbab24df7db5de8e1220acd26 Author: subhash yedugundla <venkatasubhashnaidu.yedugun...@citrix.com> Date: 2016-06-08T12:29:45Z CLOUDSTACK-9410 Data Disk shown as detached in XS --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-8944 Template download possibl...
GitHub user yvsubhash opened a pull request: https://github.com/apache/cloudstack/pull/921 CLOUDSTACK-8944 Template download possible from new nfs secondary storage before download is 100 % complete Steps to test This 1. Add a new NFS storage 2. Start dowloading any public template before it is full dowloaded to new nfs storage 3. The link should always be from any of the older storages where it is fully downloaded You can merge this pull request into a Git repository by running: $ git pull https://github.com/yvsubhash/cloudstack CLOUDSTACK-8944 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cloudstack/pull/921.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #921 commit 7055a34db133610f947d57542316505777938691 Author: subhash yedugundla <venkatasubhashnaidu.yedugun...@citrix.com> Date: 2015-10-10T19:14:57Z CLODUSTACK-8944 Template download possible from new nfs secondary storage before download is 100 % complete --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-8908 After copying the templat...
Github user yvsubhash commented on the pull request: https://github.com/apache/cloudstack/pull/896#issuecomment-146090133 License Added --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: BUG-ID CLOUDSTACK-8939
GitHub user yvsubhash opened a pull request: https://github.com/apache/cloudstack/pull/914 BUG-ID CLOUDSTACK-8939 Fixing the error with snapshot size calculation in a vm with memory You can merge this pull request into a Git repository by running: $ git pull https://github.com/yvsubhash/cloudstack CLOUDSTACK-8939 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cloudstack/pull/914.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #914 commit 5fecae08d167727437b82c92e26a550ef29bd0b2 Author: subhash yedugundla <venkatasubhashnaidu.yedugun...@citrix.com> Date: 2015-10-06T13:58:13Z BUG-ID CLOUDSTACK-8939 Fixing the error with snapshot size calculation in a vm with memory --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: BUG-ID: CLOUDSTACK-8922: Unable to delete...
GitHub user yvsubhash opened a pull request: https://github.com/apache/cloudstack/pull/905 BUG-ID: CLOUDSTACK-8922: Unable to delete IP tag Root Cause: Due to wrong search string we are fetching a resource which does not belong to current account and domain. This results in permission exception. Solution: Code changes has been done to fix the incorrect search string. You can merge this pull request into a Git repository by running: $ git pull https://github.com/yvsubhash/cloudstack CLOUDSTACK-8922 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cloudstack/pull/905.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #905 commit c0b98d3578092c71e33e869e57f7ea5d40baee7d Author: Subhash Yedugundla <venkatasubhashnaidu.yedugun...@citrix.com> Date: 2015-06-10T06:15:57Z BUG-ID: CLOUDSTACK-8922: Unable to delete IP tag --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: BUG-ID: CLOUDSTACK-8922: Unable to delete...
Github user yvsubhash commented on the pull request: https://github.com/apache/cloudstack/pull/905#issuecomment-144683196 It is tested manually with the data similar to the one mentioned in the bug --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: BUG-ID:CLOUDSTACK-8921
GitHub user yvsubhash opened a pull request: https://github.com/apache/cloudstack/pull/899 BUG-ID:CLOUDSTACK-8921 Summary: CLOUDSTACK-8921 snapshot_store_ref table should store actual size of back snapshot in secondary storage Calling SR scan to make sure size is updated correctly This scenario is tested with this bug fix. Unit tests are not added as the methods that are fixed are too long to add unit tests and there is no existing unit test to change You can merge this pull request into a Git repository by running: $ git pull https://github.com/yvsubhash/cloudstack CLOUDSTACK-8921 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cloudstack/pull/899.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #899 commit 0ff08be8789bf50628bf7ba1b8b0da1d2f6c6639 Author: subhash yedugundla <venkatasubhashnaidu.yedugun...@citrix.com> Date: 2015-09-22T06:26:40Z BUG-ID:CLOUDSTACK-8921 Summary: CLOUDSTACK-8921 snapshot_store_ref table should store actual size of back snapshot in secondary storage Calling SR scan to make sure size is updated correctly --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-8908 After copying the templat...
GitHub user yvsubhash opened a pull request: https://github.com/apache/cloudstack/pull/896 CLOUDSTACK-8908 After copying the template charging for that template is getting stopped This is happening as the zone id is not part of the query. Zone id is added to the query and unit tests are also added You can merge this pull request into a Git repository by running: $ git pull https://github.com/yvsubhash/cloudstack CLOUDSTACK-8908 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cloudstack/pull/896.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #896 commit 3f99d42de9560005d6a2996f307f5dd7f45b8b4d Author: subhash yedugundla <venkatasubhashnaidu.yedugun...@citrix.com> Date: 2015-09-28T17:35:43Z CLOUDSTACK-8908 After copying the template charging for that template is stopped --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: BUG-ID: CLOUDSTACK-8849: Usage job should...
GitHub user yvsubhash opened a pull request: https://github.com/apache/cloudstack/pull/827 BUG-ID: CLOUDSTACK-8849: Usage job should stop usage generation in ca⦠â¦se of any exception You can merge this pull request into a Git repository by running: $ git pull https://github.com/yvsubhash/cloudstack CLOUDSTACK-8849 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cloudstack/pull/827.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #827 commit 2818bd4f82eb1e9517fa13935cef6159fdd22cf9 Author: Sudhansu <sudhansu.s...@citrix.com> Date: 2015-08-25T11:43:56Z BUG-ID: CLOUDSTACK-8849: Usage job should stop usage generation in case of any exception --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
