[GitHub] DaanHoogland commented on issue #2071: CLOUDSTACK-9815 move CertService to more generic location
DaanHoogland commented on issue #2071: CLOUDSTACK-9815 move CertService to more generic location URL: https://github.com/apache/cloudstack/pull/2071#issuecomment-298314605 @blueorangutan test This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] DaanHoogland commented on issue #2071: CLOUDSTACK-9815 move CertService to more generic location
DaanHoogland commented on issue #2071: CLOUDSTACK-9815 move CertService to more generic location URL: https://github.com/apache/cloudstack/pull/2071#issuecomment-298307735 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] DaanHoogland commented on issue #2071: CLOUDSTACK-9815 move CertService to more generic location
DaanHoogland commented on issue #2071: CLOUDSTACK-9815 move CertService to more generic location URL: https://github.com/apache/cloudstack/pull/2071#issuecomment-298307487 falling for the presure from my respected peer @rafaelweingartner with an a-umlaut; worm: server/src/org/apache/cloudstack/network/ssl/CertServiceImpl.java is in a package calles ssl calling this tls package worm: api/src/org/apache/cloudstack/network/tls/SslCert.java (no further comment worm: api/src/org/apache/cloudstack/api/response/SslCertResponse.java is the response used by the commands in api/src/org/apache/cloudstack/network/tls left as an exercise to the reader: worms to be found when related packages are moved ;) This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] DaanHoogland commented on issue #2071: CLOUDSTACK-9815 move CertService to more generic location
DaanHoogland commented on issue #2071: CLOUDSTACK-9815 move CertService to more generic location URL: https://github.com/apache/cloudstack/pull/2071#issuecomment-298307487 falling for the presure from my respected peer @rafaelweingartner with an a-umlaut; worm: server/src/org/apache/cloudstack/network/ssl/CertServiceImpl.java is in a package called ssl calling this tls package worm: api/src/org/apache/cloudstack/network/tls/SslCert.java (no further comment worm: api/src/org/apache/cloudstack/api/response/SslCertResponse.java is the response used by the commands in api/src/org/apache/cloudstack/network/tls left as an exercise to the reader: worms to be found when related packages are moved ;) This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] DaanHoogland commented on issue #2071: CLOUDSTACK-9815 move CertService to more generic location
DaanHoogland commented on issue #2071: CLOUDSTACK-9815 move CertService to more generic location URL: https://github.com/apache/cloudstack/pull/2071#issuecomment-298307487 falling for the presure from my respected peer @rafaelweingartner with an a-umlaut; worm: server/src/org/apache/cloudstack/network/ssl/CertServiceImpl.java is in a package calles ssl calling this tls package worm: api/src/org/apache/cloudstack/network/tls/SslCert.java (no further comment worm: api/src/org/apache/cloudstack/api/response/SslCertResponse.java is the response used by the commands in api/src/org/apache/cloudstack/network/tls left as an exercise to the reader: worms to be found when related packages are moved ;) This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] DaanHoogland commented on issue #2071: CLOUDSTACK-9815 move CertService to more generic location
DaanHoogland commented on issue #2071: CLOUDSTACK-9815 move CertService to more generic location URL: https://github.com/apache/cloudstack/pull/2071#issuecomment-297930758 the virtio failures are addressed in #2066. still needs a 'this reads like poetry to me" This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] DaanHoogland commented on issue #2071: CLOUDSTACK-9815 move CertService to more generic location
DaanHoogland commented on issue #2071: CLOUDSTACK-9815 move CertService to more generic location URL: https://github.com/apache/cloudstack/pull/2071#issuecomment-297927230 @rafaelweingartner I don't like to. Is this :-1: worth? Can of worms involved. There is a lot more service definitions to take into account when we do that move. We can but it is to much change for the scope of this one and only if we move all will it serve it purpose. Also this as is might be a breaking change so, though I need it I would like to keep it as small as possible. Of course happy to discuss if this is This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] DaanHoogland commented on issue #2071: CLOUDSTACK-9815 move CertService to more generic location
DaanHoogland commented on issue #2071: CLOUDSTACK-9815 move CertService to more generic location URL: https://github.com/apache/cloudstack/pull/2071#issuecomment-297927230 @rafaelweingartner I don't like to. Is this :-1: worth? Can of worms involved. There is a lot more service definitions to take into account when we do that move. We can but it is to much change for the scope of this one and only if we move all will it serve it purpose. Also this as is might be a breaking change so, though I need it I would like to keep it as small as possible. Of course happy to discuss if this is This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] DaanHoogland commented on issue #2071: CLOUDSTACK-9815 move CertService to more generic location
DaanHoogland commented on issue #2071: CLOUDSTACK-9815 move CertService to more generic location URL: https://github.com/apache/cloudstack/pull/2071#issuecomment-297712593 @blueorangutan test This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] DaanHoogland commented on issue #2071: CLOUDSTACK-9815 move CertService to more generic location
DaanHoogland commented on issue #2071: CLOUDSTACK-9815 move CertService to more generic location URL: https://github.com/apache/cloudstack/pull/2071#issuecomment-297700071 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] DaanHoogland commented on issue #2071: CLOUDSTACK-9815 move CertService to more generic location
DaanHoogland commented on issue #2071: CLOUDSTACK-9815 move CertService to more generic location URL: https://github.com/apache/cloudstack/pull/2071#issuecomment-297692174 @blueorangutan test d2m41t you are right @resmo, one change coming up ;) This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] DaanHoogland commented on issue #2071: CLOUDSTACK-9815 move CertService to more generic location
DaanHoogland commented on issue #2071: CLOUDSTACK-9815 move CertService to more generic location URL: https://github.com/apache/cloudstack/pull/2071#issuecomment-297678323 @rhtyd @rafaelweingartner @wido please have a look, I discussed this in several different contexts. I think concentrating this code is going to reduce maintenance effort and I needed it in my applicationCluster port effort but it merits separate review. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] DaanHoogland commented on issue #2071: CLOUDSTACK-9815 move CertService to more generic location
DaanHoogland commented on issue #2071: CLOUDSTACK-9815 move CertService to more generic location URL: https://github.com/apache/cloudstack/pull/2071#issuecomment-297677839 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
