[GitHub] cloudstack issue #1269: CLOUDSTACK-8867: Added retry logic to reconnect to h...
Github user anshul1886 commented on the issue: https://github.com/apache/cloudstack/pull/1269 @GabrielBrascher The other method is there for legacy purposes and is no longer get used in Cloudstack. This was getting used in 2.x versions for UI. Some third party tool might be using it so kept it for that purpose. Mixing things will make it more complicated. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1269: CLOUDSTACK-8867: Added retry logic to reconnect to h...
Github user GabrielBrascher commented on the issue: https://github.com/apache/cloudstack/pull/1269 Thanks for the response @anshul1886. I am sorry, but I disagree with you. I think that it gets more stable and readable with less duplicated code. In my humble opinion, it is easier to document, test, read and debug when we have lots of small methods than few big methods. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1269: CLOUDSTACK-8867: Added retry logic to reconnect to h...
Github user anshul1886 commented on the issue: https://github.com/apache/cloudstack/pull/1269 @GabrielBrascher @alexandrelimassantana I kept it that way for readability as console proxy code is hard to debug. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1269: CLOUDSTACK-8867: Added retry logic to reconnect to h...
Github user blueorangutan commented on the issue: https://github.com/apache/cloudstack/pull/1269 Packaging result: âcentos6 âcentos7 âdebian. JID-547 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1269: CLOUDSTACK-8867: Added retry logic to reconnect to h...
Github user blueorangutan commented on the issue: https://github.com/apache/cloudstack/pull/1269 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1269: CLOUDSTACK-8867: Added retry logic to reconnect to h...
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1269 @blueorangutan package --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1269: CLOUDSTACK-8867: Added retry logic to reconnect to h...
Github user cloudmonger commented on the issue: https://github.com/apache/cloudstack/pull/1269 ### ACS CI BVT Run **Sumarry:** Build Number 406 Hypervisor xenserver NetworkType Advanced Passed=104 Failed=1 Skipped=7 _Link to logs Folder (search by build_no):_ https://www.dropbox.com/sh/yj3wnzbceo9uef2/AAB6u-Iap-xztdm6jHX9SjPja?dl=0 **Failed tests:** * test_non_contigiousvlan.py * test_extendPhysicalNetworkVlan Failing since 2 runs **Skipped tests:** test_01_test_vm_volume_snapshot test_vm_nic_adapter_vmxnet3 test_static_role_account_acls test_11_ss_nfs_version_on_ssvm test_nested_virtualization_vmware test_3d_gpu_support test_deploy_vgpu_enabled_vm **Passed test suits:** test_deploy_vm_with_userdata.py test_affinity_groups_projects.py test_portable_publicip.py test_over_provisioning.py test_global_settings.py test_scale_vm.py test_service_offerings.py test_routers_iptables_default_policy.py test_loadbalance.py test_routers.py test_reset_vm_on_reboot.py test_deploy_vms_with_varied_deploymentplanners.py test_network.py test_router_dns.py test_login.py test_deploy_vm_iso.py test_list_ids_parameter.py test_public_ip_range.py test_multipleips_per_nic.py test_regions.py test_affinity_groups.py test_network_acl.py test_pvlan.py test_volumes.py test_nic.py test_deploy_vm_root_resize.py test_resource_detail.py test_secondary_storage.py test_vm_life_cycle.py test_routers_network_ops.py test_disk_offerings.py --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1269: CLOUDSTACK-8867: Added retry logic to reconnect to h...
Github user anshul1886 commented on the issue: https://github.com/apache/cloudstack/pull/1269 @rhtyd , Rebased against latest master --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
