[GitHub] cloudstack issue #1563: CLOUDSTACK-9389:[automation]updating test_routers_ne...
Github user nitt10prashant commented on the issue: https://github.com/apache/cloudstack/pull/1563 Not needed --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1563: CLOUDSTACK-9389:[automation]updating test_routers_ne...
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1563 @nitt10prashant ping --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1563: CLOUDSTACK-9389:[automation]updating test_routers_ne...
Github user bvbharatk commented on the issue: https://github.com/apache/cloudstack/pull/1563 ### ACS CI BVT Run **Sumarry:** Build Number 184 Hypervisor xenserver NetworkType Advanced Passed=73 Failed=0 Skipped=3 _Link to logs Folder (search by build_no):_ https://www.dropbox.com/sh/yj3wnzbceo9uef2/AAB6u-Iap-xztdm6jHX9SjPja?dl=0 **Failed tests:** **Skipped tests:** test_vm_nic_adapter_vmxnet3 test_static_role_account_acls test_deploy_vgpu_enabled_vm **Passed test suits:** test_deploy_vm_with_userdata.py test_affinity_groups_projects.py test_portable_publicip.py test_vpc_vpn.py test_over_provisioning.py test_global_settings.py test_scale_vm.py test_service_offerings.py test_routers_iptables_default_policy.py test_routers.py test_reset_vm_on_reboot.py test_snapshots.py test_deploy_vms_with_varied_deploymentplanners.py test_login.py test_list_ids_parameter.py test_public_ip_range.py test_multipleips_per_nic.py test_regions.py test_affinity_groups.py test_network_acl.py test_pvlan.py test_volumes.py test_nic.py test_deploy_vm_root_resize.py test_resource_detail.py test_secondary_storage.py test_vm_life_cycle.py test_disk_offerings.py --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1563: CLOUDSTACK-9389:[automation]updating test_routers_ne...
Github user nitt10prashant commented on the issue: https://github.com/apache/cloudstack/pull/1563 @swill just curious to know Which guest OS you are using ? Since Cent OS template is default in ACS i modified test_data for cent OS. Regx should be consider ? ->I Agree with you, will push changes for regx to make sure it work for both ping pattern . What do you think? Sorry, I don't mean to be combative here, but this is a good opertunity for us to review the way we handle OS specific test data. ->Yes this should be discussed thoroughly and should be documented properly --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1563: CLOUDSTACK-9389:[automation]updating test_routers_ne...
Github user swill commented on the issue: https://github.com/apache/cloudstack/pull/1563 This assumes that people know how to work with the test data and that they understand that "this random template needs X format and this other one will need Y format". This is too much to ask without guidance, especially as we try to improve the automatability of the testing. The regex idea is not a perfect solution, but would allow for us to handle more template types with a single entry. Ideally we would be able to specify the expected values for this type of thing in an OS specific way so the tested (and verified) values for each OS can live in the test data. It would probably need a default that is used if the current OS does not have a match. My main problem with this is that it will, by default, break this test for everyone using bubble to automate their testing. Maybe we leave the old default test value in place, and people who are testing with other OSs can now override manually. What do you think? Sorry, I don't mean to be combative here, but this is a good opertunity for us to review the way we handle OS specific test data. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1563: CLOUDSTACK-9389:[automation]updating test_routers_ne...
Github user nitt10prashant commented on the issue: https://github.com/apache/cloudstack/pull/1563 -->I think it is important that the test data does not need to be changed for our automated(ish) CI to show the tests are passing @swill i think test-data meant to be changed depend on your local environment and every one should have local copy of their own test data . --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
