[GitHub] cloudstack issue #1606: Allow CGN (RFC6598) to be used within a VPC
Github user rossor commented on the issue: https://github.com/apache/cloudstack/pull/1606 Is it appropriate to add a comparatively complex integration test to cover a functional predicate whose cognitive load is so small? I will expand the associated unit test to include boundary conditions testing of the CGN address range, and that would seem to me to be sufficient. Please advise. @karuturi --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1606: Allow CGN (RFC6598) to be used within a VPC
Github user leprechau commented on the issue: https://github.com/apache/cloudstack/pull/1606 What's the current status of this PR? Is this acceptable as is? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1606: Allow CGN (RFC6598) to be used within a VPC
Github user blueorangutan commented on the issue: https://github.com/apache/cloudstack/pull/1606 Packaging result: âcentos6 âcentos7 âdebian. JID-378 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1606: Allow CGN (RFC6598) to be used within a VPC
Github user blueorangutan commented on the issue: https://github.com/apache/cloudstack/pull/1606 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1606: Allow CGN (RFC6598) to be used within a VPC
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1606 @blueorangutan package --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1606: Allow CGN (RFC6598) to be used within a VPC
Github user kiwiflyer commented on the issue: https://github.com/apache/cloudstack/pull/1606 I've added issue Jira CLOUDSTACK-9661 to track this. https://issues.apache.org/jira/browse/CLOUDSTACK-9661 @leprechau @rhtyd --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1606: Allow CGN (RFC6598) to be used within a VPC
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1606 Ping @leprechau @kiwiflyer --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1606: Allow CGN (RFC6598) to be used within a VPC
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1606 LGTM on tests and code review. @leprechau @kiwiflyer can we have a JIRA id for this and use that in the commit summary. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1606: Allow CGN (RFC6598) to be used within a VPC
Github user blueorangutan commented on the issue: https://github.com/apache/cloudstack/pull/1606 Packaging result: âcentos6 âcentos7 âdebian. JID-209 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1606: Allow CGN (RFC6598) to be used within a VPC
Github user blueorangutan commented on the issue: https://github.com/apache/cloudstack/pull/1606 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1606: Allow CGN (RFC6598) to be used within a VPC
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1606 @blueorangutan package --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1606: Allow CGN (RFC6598) to be used within a VPC
Github user jburwell commented on the issue: https://github.com/apache/cloudstack/pull/1606 @leprechau I would like to get this fix into 4.8.2.0, 4.9.1.0, and 4.10.0.0. Have you had a chance to add the unit tests requested? Also, is there a JIRA ticket for this bug? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1606: Allow CGN (RFC6598) to be used within a VPC
Github user koushik-das commented on the issue: https://github.com/apache/cloudstack/pull/1606 @leprechau You may add an unit test as well for NetUtils.validateGuestCidr(). Check NetUtilsTest.java, there is already an existing test for 192.168. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1606: Allow CGN (RFC6598) to be used within a VPC
Github user leprechau commented on the issue: https://github.com/apache/cloudstack/pull/1606 @jburwell Is there already an existing test for the previous behavior that could be modified? I haven't had a chance to do much with Marvin other than briefly browse the tests folder. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1606: Allow CGN (RFC6598) to be used within a VPC
Github user jburwell commented on the issue: https://github.com/apache/cloudstack/pull/1606 @leprechau you have expanded the type of networks blocks supported by the system. Therefore, there should be a Marvin test case that attempts to specify a CGN network block for a guest network and verifies that the system behaves as expected. In particular, the test should verify that the API calls are successful, and that the networks are implemented as expected when a CGN network block is specified. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1606: Allow CGN (RFC6598) to be used within a VPC
Github user jburwell commented on the issue: https://github.com/apache/cloudstack/pull/1606 @leprechau following up regarding Marvin tests. Unless they are ready, we are likely going to have to push this PR to 4.9.2.0 since I am trying to get a 4.8.2.0 RC cut ASAP (we are week late already). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1606: Allow CGN (RFC6598) to be used within a VPC
Github user kiwiflyer commented on the issue: https://github.com/apache/cloudstack/pull/1606 John, I'll defer to Aaron on this, as he submitted the PR. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1606: Allow CGN (RFC6598) to be used within a VPC
Github user jburwell commented on the issue: https://github.com/apache/cloudstack/pull/1606 @kiwiflyer are there Marvin tests that verify this behavior? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1606: Allow CGN (RFC6598) to be used within a VPC
Github user blueorangutan commented on the issue: https://github.com/apache/cloudstack/pull/1606 Packaging result: âcentos6 âcentos7 âdebian repo: http://packages.shapeblue.com/cloudstack/pr/1606 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1606: Allow CGN (RFC6598) to be used within a VPC
Github user blueorangutan commented on the issue: https://github.com/apache/cloudstack/pull/1606 @rhtyd a Trillian-Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1606: Allow CGN (RFC6598) to be used within a VPC
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1606 @blueorangutan package --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1606: Allow CGN (RFC6598) to be used within a VPC
Github user blueorangutan commented on the issue: https://github.com/apache/cloudstack/pull/1606 Packaging result: âcentos6 âcentos7 âdebian repo: http://packages.shapeblue.com/cloudstack/pr/1606 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1606: Allow CGN (RFC6598) to be used within a VPC
Github user blueorangutan commented on the issue: https://github.com/apache/cloudstack/pull/1606 Packaging result: âcentos6 âcentos7 âdebian repo: http://packages.shapeblue.com/cloudstack/pr/1606 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1606: Allow CGN (RFC6598) to be used within a VPC
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1606 LGTM (did not test it, kicked a packaging build) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1606: Allow CGN (RFC6598) to be used within a VPC
Github user kiwiflyer commented on the issue: https://github.com/apache/cloudstack/pull/1606 Tested in a 4.8 lab. Verified as per screen shots that all RFC 1918 and RFC 6598 ranges work. Attempting to use a public cidr produces an error as expected. Interface is correctly configured on the VR and the routing table is correct and matches the interface the private gateway was configured on (eth3). LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1606: Allow CGN (RFC6598) to be used within a VPC
Github user kiwiflyer commented on the issue: https://github.com/apache/cloudstack/pull/1606  --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1606: Allow CGN (RFC6598) to be used within a VPC
Github user kiwiflyer commented on the issue: https://github.com/apache/cloudstack/pull/1606  --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1606: Allow CGN (RFC6598) to be used within a VPC
Github user kiwiflyer commented on the issue: https://github.com/apache/cloudstack/pull/1606  --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1606: Allow CGN (RFC6598) to be used within a VPC
Github user kiwiflyer commented on the issue: https://github.com/apache/cloudstack/pull/1606  --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1606: Allow CGN (RFC6598) to be used within a VPC
Github user kiwiflyer commented on the issue: https://github.com/apache/cloudstack/pull/1606  --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1606: Allow CGN (RFC6598) to be used within a VPC
Github user kiwiflyer commented on the issue: https://github.com/apache/cloudstack/pull/1606  --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1606: Allow CGN (RFC6598) to be used within a VPC
Github user kiwiflyer commented on the issue: https://github.com/apache/cloudstack/pull/1606  --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1606: Allow CGN (RFC6598) to be used within a VPC
Github user kiwiflyer commented on the issue: https://github.com/apache/cloudstack/pull/1606  --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
