[GitHub] cloudstack issue #1635: CLOUDSTACK-9451
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1635 Test LGTM, the two failures are intermittent and env related. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1635: CLOUDSTACK-9451
Github user blueorangutan commented on the issue: https://github.com/apache/cloudstack/pull/1635 Trillian test result (tid-427) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 28223 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr1635-t427-kvm-centos7.zip Test completed. 41 look ok, 2 have error(s) Test | Result | Time (s) | Test File --- | --- | --- | --- test_05_rvpc_multi_tiers | `Failure` | 225.67 | test_vpc_redundant.py test_10_attachAndDetach_iso | `Failure` | 684.22 | test_vm_life_cycle.py test_01_vpc_site2site_vpn | Success | 161.39 | test_vpc_vpn.py test_01_vpc_remote_access_vpn | Success | 67.19 | test_vpc_vpn.py test_01_redundant_vpc_site2site_vpn | Success | 264.00 | test_vpc_vpn.py test_02_VPC_default_routes | Success | 271.42 | test_vpc_router_nics.py test_01_VPC_nics_after_destroy | Success | 572.64 | test_vpc_router_nics.py test_04_rvpc_network_garbage_collector_nics | Success | 1344.16 | test_vpc_redundant.py test_03_create_redundant_VPC_1tier_2VMs_2IPs_2PF_ACL_reboot_routers | Success | 576.07 | test_vpc_redundant.py test_02_redundant_VPC_default_routes | Success | 753.98 | test_vpc_redundant.py test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL | Success | 1333.54 | test_vpc_redundant.py test_09_delete_detached_volume | Success | 15.85 | test_volumes.py test_08_resize_volume | Success | 15.67 | test_volumes.py test_07_resize_fail | Success | 20.57 | test_volumes.py test_06_download_detached_volume | Success | 15.49 | test_volumes.py test_05_detach_volume | Success | 100.30 | test_volumes.py test_04_delete_attached_volume | Success | 10.42 | test_volumes.py test_03_download_attached_volume | Success | 15.48 | test_volumes.py test_02_attach_volume | Success | 73.83 | test_volumes.py test_01_create_volume | Success | 734.50 | test_volumes.py test_deploy_vm_multiple | Success | 285.29 | test_vm_life_cycle.py test_deploy_vm | Success | 0.03 | test_vm_life_cycle.py test_advZoneVirtualRouter | Success | 0.04 | test_vm_life_cycle.py test_09_expunge_vm | Success | 125.27 | test_vm_life_cycle.py test_08_migrate_vm | Success | 41.36 | test_vm_life_cycle.py test_07_restore_vm | Success | 0.22 | test_vm_life_cycle.py test_06_destroy_vm | Success | 126.11 | test_vm_life_cycle.py test_03_reboot_vm | Success | 126.36 | test_vm_life_cycle.py test_02_start_vm | Success | 10.25 | test_vm_life_cycle.py test_01_stop_vm | Success | 40.47 | test_vm_life_cycle.py test_CreateTemplateWithDuplicateName | Success | 61.25 | test_templates.py test_08_list_system_templates | Success | 0.04 | test_templates.py test_07_list_public_templates | Success | 0.04 | test_templates.py test_05_template_permissions | Success | 0.08 | test_templates.py test_04_extract_template | Success | 5.25 | test_templates.py test_03_delete_template | Success | 5.10 | test_templates.py test_02_edit_template | Success | 90.20 | test_templates.py test_01_create_template | Success | 40.62 | test_templates.py test_10_destroy_cpvm | Success | 161.95 | test_ssvm.py test_09_destroy_ssvm | Success | 163.64 | test_ssvm.py test_08_reboot_cpvm | Success | 101.75 | test_ssvm.py test_07_reboot_ssvm | Success | 133.77 | test_ssvm.py test_06_stop_cpvm | Success | 132.21 | test_ssvm.py test_05_stop_ssvm | Success | 133.95 | test_ssvm.py test_04_cpvm_internals | Success | 1.27 | test_ssvm.py test_03_ssvm_internals | Success | 3.65 | test_ssvm.py test_02_list_cpvm_vm | Success | 0.20 | test_ssvm.py test_01_list_sec_storage_vm | Success | 0.26 | test_ssvm.py test_01_snapshot_root_disk | Success | 11.40 | test_snapshots.py test_04_change_offering_small | Success | 205.01 | test_service_offerings.py test_03_delete_service_offering | Success | 0.04 | test_service_offerings.py test_02_edit_service_offering | Success | 0.06 | test_service_offerings.py test_01_create_service_offering | Success | 0.18 | test_service_offerings.py test_02_sys_template_ready | Success | 0.13 | test_secondary_storage.py test_01_sys_vm_start | Success | 0.20 | test_secondary_storage.py test_09_reboot_router | Success | 40.52 | test_routers.py test_08_start_router | Success | 35.43 | test_routers.py test_07_stop_router | Success | 10.20 | test_routers.py test_06_router_advanced | Success | 0.07 | test_routers.py test_05_router_basic | Success | 0.05 | test_routers.py test_04_restart_network_wo_cleanup | Success | 5.73 | test_routers.py test_03_restart_network_cleanup | Success | 70.83 | test_routers.py test_02_router_internal_adv | Success | 1.21 | test_routers.py test_01_router_internal_basic | Success | 0.74 | test_routers.py test_router_dhcphosts | Success | 310.98 | test_router_dhcphosts.py
[GitHub] cloudstack issue #1635: CLOUDSTACK-9451
Github user blueorangutan commented on the issue: https://github.com/apache/cloudstack/pull/1635 @rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1635: CLOUDSTACK-9451
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1635 Checked centos6 failed due to an intermittent unit test failure, we can ignore that for now. @blueorangutan test --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1635: CLOUDSTACK-9451
Github user blueorangutan commented on the issue: https://github.com/apache/cloudstack/pull/1635 Packaging result: âcentos6 âcentos7 âdebian. JID-248 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1635: CLOUDSTACK-9451
Github user blueorangutan commented on the issue: https://github.com/apache/cloudstack/pull/1635 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1635: CLOUDSTACK-9451
Github user nathanejohnson commented on the issue: https://github.com/apache/cloudstack/pull/1635 @rhtyd @jburwell I believe the last commit should have addressed his concerns. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1635: CLOUDSTACK-9451
Github user blueorangutan commented on the issue: https://github.com/apache/cloudstack/pull/1635 Packaging result: âcentos6 âcentos7 âdebian. JID-203 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1635: CLOUDSTACK-9451
Github user blueorangutan commented on the issue: https://github.com/apache/cloudstack/pull/1635 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1635: CLOUDSTACK-9451
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1635 @nathanejohnson can you reply to @jburwell 's comments --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1635: CLOUDSTACK-9451
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1635 @blueorangutan package --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1635: CLOUDSTACK-9451
Github user blueorangutan commented on the issue: https://github.com/apache/cloudstack/pull/1635 Packaging result: âcentos6 âcentos7 âdebian. JID-78 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1635: CLOUDSTACK-9451
Github user blueorangutan commented on the issue: https://github.com/apache/cloudstack/pull/1635 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1635: CLOUDSTACK-9451
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1635 @blueorangutan package --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1635: CLOUDSTACK-9451
Github user nathanejohnson commented on the issue: https://github.com/apache/cloudstack/pull/1635 I did find one marvin test that does pass forced flag. Here are the results. https://gist.github.com/nathanejohnson/c4d1ffb8b61b19a8105dcb5326794b15 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1635: CLOUDSTACK-9451
Github user nathanejohnson commented on the issue: https://github.com/apache/cloudstack/pull/1635 @jburwell sorry I've been silent, I've been on vacation for a bit and I will be juggling plans this weekend as well. I plan to update this PR soon, and as far as a Marvin test I am not aware of any current tests that would cover this. I haven't forgotten about this but it might be a few days yet before I can dig in fully. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1635: CLOUDSTACK-9451
Github user jburwell commented on the issue: https://github.com/apache/cloudstack/pull/1635 @nathanejohnson I want to get this bug fix into 4.8.2.0. In order to make it, we need to complete the following: * [] Resolve the question about the name of the method (``stop`` vs ``forcedStop``) * [] Amend the commit message to summarize the change and explain the reason/motivation for it * [] Code review LGTM * [] Test LGTM @rhtyd or I will provide the code review LGTM once we resolve the naming question. Do you have someone who can run the test? Also, is this change something we can check via a Marvin test case? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1635: CLOUDSTACK-9451
Github user kiwiflyer commented on the issue: https://github.com/apache/cloudstack/pull/1635 I'll let him comment on this, but If I recall, it had more to do with implementation of force stopping with KVM rather than the lack of the parameter being passing into the VM Manager. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1635: CLOUDSTACK-9451
Github user ProjectMoon commented on the issue: https://github.com/apache/cloudstack/pull/1635 All hypervisors are affected by this, since the parameter is just not passed into the VM Manager. That means its effects don't work at all anywhere. :) I will try to review it to tomorrow. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1635: CLOUDSTACK-9451
Github user kiwiflyer commented on the issue: https://github.com/apache/cloudstack/pull/1635 @ProjectMoon Jeff, could you help review this, as I believe you were the first to point it out on the list. From talking to Nathan, it sounds like we're not sure KVM is actually affected by this bug. He was in the process of doing some digging. Regardless of that, it probably affects other hypervisors. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1635: CLOUDSTACK-9451
Github user jburwell commented on the issue: https://github.com/apache/cloudstack/pull/1635 @nathanejohnson please amend your commit message to explain the change(s) made and their motivation? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1635: CLOUDSTACK-9451
Github user blueorangutan commented on the issue: https://github.com/apache/cloudstack/pull/1635 Packaging result: âcentos6 âcentos7 âdebian repo: http://packages.shapeblue.com/cloudstack/pr/1635 Job ID-95 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1635: CLOUDSTACK-9451
Github user ustcweizhou commented on the issue: https://github.com/apache/cloudstack/pull/1635 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1635: CLOUDSTACK-9451
Github user kiwiflyer commented on the issue: https://github.com/apache/cloudstack/pull/1635 References: https://github.com/apache/cloudstack/pull/1632 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
