[GitHub] cloudstack issue #1647: [lts] CLOUDSTACK-9462: Systemd support for Ubuntu 16...
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1647 Alright, given the reviews and that all changes have been incorporated with exhaustive testing with Ubuntu and CentOS I'll proceed with merging this without blocking 4.9.1.0 RC much further. Any more improvements and changes should be sent in future PRs for example support for cloudstack-management/systemd on Ubuntu 16.04 is yet to be done. Thanks @vincentbernat and @wido for your review and feedback. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1647: [lts] CLOUDSTACK-9462: Systemd support for Ubuntu 16...
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1647 @wido @vincentbernat and others -- any objections, this is good to merge? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1647: [lts] CLOUDSTACK-9462: Systemd support for Ubuntu 16...
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1647 @vincentbernat @wido thank you for your suggestion and review, I've pushed the final version from my end. Packages works on both CentOS7 and Ubuntu 12.04/14.04/16.04. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1647: [lts] CLOUDSTACK-9462: Systemd support for Ubuntu 16...
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1647 Update: postinstall code has been removed now @wido @vincentbernat --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1647: [lts] CLOUDSTACK-9462: Systemd support for Ubuntu 16...
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1647 Packaging tests confirmed, PR is OK. Debian packages tested on Ubuntu 12.04/14.04/16.04, rpms tests on CentOS 7.2. Both usage, agent came up on installation. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1647: [lts] CLOUDSTACK-9462: Systemd support for Ubuntu 16...
Github user rhtyd commented on the issue:
https://github.com/apache/cloudstack/pull/1647
@wido @vincentbernat I could not get rid of the postinst step as shell is
not executed when I move the code in the EnvironmentFile itself. I've reduced
its impact to only run when the default /etc/default/cloudstack-{usage, agent}
are installed.
Since we're re-using the common systemd files, the JAVA_HOME declared in
the files are set to the default we see on CentOS and only in that case the
postinst step will replace it with the system default. On future upgrades, the
postinst code won't run. Sorry, but this hack was needed.
Please see one last time, if we're in agreement as soon as my packaging
testing succeed I'll merge this. /cc @jburwell @karuturi
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1647: [lts] CLOUDSTACK-9462: Systemd support for Ubuntu 16...
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1647 Thanks @wido I'll see if I can fix the issue without including the changes in postinst files. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1647: [lts] CLOUDSTACK-9462: Systemd support for Ubuntu 16...
Github user wido commented on the issue: https://github.com/apache/cloudstack/pull/1647 LGTM for me right now. One side note, I hate changes being made in postinst files. But I wouldn't know a different route though. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1647: [lts] CLOUDSTACK-9462: Systemd support for Ubuntu 16...
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1647 @wido @vincentbernat I've incorporate all the changes now, including refactoring of systemd file and now we've both centos and ubuntu/debian packaging consuming from the the same service/default systemd files. I tried to see if we can include support for cloudstack-management and systemd but that's challenging and different. Please review and let's merge this. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1647: [lts] CLOUDSTACK-9462: Systemd support for Ubuntu 16...
Github user rhtyd commented on the issue:
https://github.com/apache/cloudstack/pull/1647
Thanks @vincentbernat I'll update the dependencies, and in the
post-installation step we can modify the default JAVA_HOME path of the host in
the default/{cloudstack-usage, cloudstack-agent} files if available.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1647: [lts] CLOUDSTACK-9462: Systemd support for Ubuntu 16...
Github user vincentbernat commented on the issue: https://github.com/apache/cloudstack/pull/1647 Otherwise, I think the change to be compatible with 12.04 is OK (no Upstart script should ever be provided in this case). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1647: [lts] CLOUDSTACK-9462: Systemd support for Ubuntu 16...
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1647 @wido actually on a fresh system it would first attempt to find and install openjdk8, on existing ones if openjdk7 is installed then it won't force openjdk8 by default. Thanks. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1647: [lts] CLOUDSTACK-9462: Systemd support for Ubuntu 16...
Github user wido commented on the issue: https://github.com/apache/cloudstack/pull/1647 @rhtyd Seems good, but it would still not force the install of Java 8 on Ubuntu 16.04 However, I don't think that's a blocker. LGTM for me --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1647: [lts] CLOUDSTACK-9462: Systemd support for Ubuntu 16...
Github user rhtyd commented on the issue:
https://github.com/apache/cloudstack/pull/1647
@vincentbernat I made some changes, built packages and was able to install
and run agent and usage server on both Ubuntu 12.04, 14.04 using the same
packages.
@wido @vincentbernat can you review my change and if it's okay, based on
installation tests we can merge this.
Additional notes: on fresh installation the /etc/default/cloudstack-{agent,
usage} files use JAVA_HOME path for 1.8 jre which does not exist and needed
manually fixing. This was the only thing I had to do and can be documented in
install/upgrade and release notes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1647: [lts] CLOUDSTACK-9462: Systemd support for Ubuntu 16...
Github user vincentbernat commented on the issue: https://github.com/apache/cloudstack/pull/1647 it is not possible to have systemd support and build on 12.04 at the same time. dh-systemd doesn't exist on 12.04 and its actions are quite important. If you remove it and just install the units manually, they won't start on boot or on upgrade. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1647: [lts] CLOUDSTACK-9462: Systemd support for Ubuntu 16...
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1647 Thanks @wido that makes sense. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1647: [lts] CLOUDSTACK-9462: Systemd support for Ubuntu 16...
Github user wido commented on the issue: https://github.com/apache/cloudstack/pull/1647 @rhtyd When this one merges and is merged forward I will send a PR for master to remove 12.04 support. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1647: [lts] CLOUDSTACK-9462: Systemd support for Ubuntu 16...
Github user wido commented on the issue: https://github.com/apache/cloudstack/pull/1647 @rhtyd Why another PR for against master? I thought we were merging forward? This stuff is really starting to confuse me. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1647: [lts] CLOUDSTACK-9462: Systemd support for Ubuntu 16...
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1647 @wido based on the ML discussion, I've removed the specific change that removed 12.04 support. Can you send another PR for master for removing support for 12.04. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1647: [lts] CLOUDSTACK-9462: Systemd support for Ubuntu 16...
Github user jburwell commented on the issue: https://github.com/apache/cloudstack/pull/1647 @wido While I understand that it is quite old and presents maintenance challenges, it remains supported until [April 2017](https://wiki.ubuntu.com/Releases). Therefore, it would be reasonable for users to expect us to continue to support it until EOL. I have opened conversation on dev@ and user@ in an effort to determine the impact (if any) to users post 4.9. In the meantime, would it be possible to split this PR into Ubuntu 16.04 support and removal of Ubuntu 12.04 support? If we decide to remove it, I propose that we introduce it in the 4.10.x release. Not only is 4.9 an LTS branch, it doesn't seem reasonable to drop support for a distribution in a patch release (i.e. 4.9.0.0 supports Ubuntu 12.04 and 4.9.1.0 does not). Conversely, Ubuntu 16.04 support seems like a worthy addition to LTS. Splitting these two issues will provide the flexibility to implement such removal of Ubuntu 12.04 in 4.10.x and the addition of Ubuntu 16.04 in 4.9.x+. Does this approach seem reasonable? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1647: [lts] CLOUDSTACK-9462: Systemd support for Ubuntu 16...
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1647 @wido with this change will we have to host two versions of deb repository -- one built on ubuntu without systemd (such as 14.04) and one built on ubuntu with systemd (16.04+)? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
RE: [GitHub] cloudstack issue #1647: [lts] CLOUDSTACK-9462: Systemd support for Ubuntu 16...
I would love to see this AND XenServer 7 support... I would pay money for the XenServer 7 support. Regards, Marty Godsey -Original Message- From: wido [mailto:g...@git.apache.org] Sent: Saturday, August 20, 2016 1:05 PM To: dev@cloudstack.apache.org Subject: [GitHub] cloudstack issue #1647: [lts] CLOUDSTACK-9462: Systemd support for Ubuntu 16... Github user wido commented on the issue: https://github.com/apache/cloudstack/pull/1647 I did the test myself, but since it's my code I can't LGTM this. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1647: [lts] CLOUDSTACK-9462: Systemd support for Ubuntu 16...
Github user wido commented on the issue: https://github.com/apache/cloudstack/pull/1647 I did the test myself, but since it's my code I can't LGTM this. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1647: [lts] CLOUDSTACK-9462: Systemd support for Ubuntu 16...
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1647 @wido given it's a pure packaging fix, and as per RMs we've enough LGTMs but we lack a test LGTM -- I can help merge this after some tests wrt usage and kvm agent (on ubuntu 16.04) over the weekend or next week. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1647: [lts] CLOUDSTACK-9462: Systemd support for Ubuntu 16...
Github user wido commented on the issue: https://github.com/apache/cloudstack/pull/1647 @rhtyd No, it doesn't do the management server. Let's just merge this PR and make a new one for that. I don't want to delay merging this any longer. Thanks @vincentbernat for the comment, that's something for a next PR. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1647: [lts] CLOUDSTACK-9462: Systemd support for Ubuntu 16...
Github user blueorangutan commented on the issue: https://github.com/apache/cloudstack/pull/1647 Packaging result: âcentos6 âcentos7 âdebian repo: http://packages.shapeblue.com/cloudstack/pr/1647 Job ID-92 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1647: [lts] CLOUDSTACK-9462: Systemd support for Ubuntu 16...
Github user vincentbernat commented on the issue: https://github.com/apache/cloudstack/pull/1647 LGTM for the Ubuntu part. You could share `/etc/sysconfig/*` and `/etc/default/*` files between RHEL/Ubuntu (same files, just installed at different locations). Same for the service files: ``` [service] EnvironmentFile=-/etc/default/cloudstack-agent EnvironmentFile=-/etc/sysconfig/cloudstack-agent ``` --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
