[GitHub] cloudstack issue #1726: CLOUDSTACK-9560 Root volume of deleted VM left unrem...
Github user yvsubhash commented on the issue: https://github.com/apache/cloudstack/pull/1726 tag:mergeready --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1726: CLOUDSTACK-9560 Root volume of deleted VM left unrem...
Github user ustcweizhou commented on the issue: https://github.com/apache/cloudstack/pull/1726 LGTM now --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1726: CLOUDSTACK-9560 Root volume of deleted VM left unrem...
Github user yvsubhash commented on the issue: https://github.com/apache/cloudstack/pull/1726 @ustcweizhou coding convention issue is taken care --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1726: CLOUDSTACK-9560 Root volume of deleted VM left unrem...
Github user ustcweizhou commented on the issue: https://github.com/apache/cloudstack/pull/1726 code LGTM @yvsubhash it would be nice if you can reformat part of the code with java code conventions. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1726: CLOUDSTACK-9560 Root volume of deleted VM left unrem...
Github user yvsubhash commented on the issue: https://github.com/apache/cloudstack/pull/1726 @ustcweizhou does it look good to you now? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1726: CLOUDSTACK-9560 Root volume of deleted VM left unrem...
Github user cloudmonger commented on the issue: https://github.com/apache/cloudstack/pull/1726 ### ACS CI BVT Run **Sumarry:** Build Number 456 Hypervisor xenserver NetworkType Advanced Passed=104 Failed=1 Skipped=7 _Link to logs Folder (search by build_no):_ https://www.dropbox.com/sh/yj3wnzbceo9uef2/AAB6u-Iap-xztdm6jHX9SjPja?dl=0 **Failed tests:** * test_routers_network_ops.py * test_03_RVR_Network_check_router_state Failing since 2 runs **Skipped tests:** test_01_test_vm_volume_snapshot test_vm_nic_adapter_vmxnet3 test_static_role_account_acls test_11_ss_nfs_version_on_ssvm test_nested_virtualization_vmware test_3d_gpu_support test_deploy_vgpu_enabled_vm **Passed test suits:** test_deploy_vm_with_userdata.py test_affinity_groups_projects.py test_portable_publicip.py test_over_provisioning.py test_global_settings.py test_scale_vm.py test_service_offerings.py test_routers_iptables_default_policy.py test_loadbalance.py test_routers.py test_reset_vm_on_reboot.py test_deploy_vms_with_varied_deploymentplanners.py test_network.py test_router_dns.py test_non_contigiousvlan.py test_login.py test_deploy_vm_iso.py test_list_ids_parameter.py test_public_ip_range.py test_multipleips_per_nic.py test_regions.py test_affinity_groups.py test_network_acl.py test_pvlan.py test_volumes.py test_nic.py test_deploy_vm_root_resize.py test_resource_detail.py test_secondary_storage.py test_vm_life_cycle.py test_disk_offerings.py --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1726: CLOUDSTACK-9560 Root volume of deleted VM left unrem...
Github user yvsubhash commented on the issue: https://github.com/apache/cloudstack/pull/1726 @ustcweizhou Please review --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1726: CLOUDSTACK-9560 Root volume of deleted VM left unrem...
Github user niteshsarda commented on the issue: https://github.com/apache/cloudstack/pull/1726 I have tested this and **LGTM** for test --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1726: CLOUDSTACK-9560 Root volume of deleted VM left unrem...
Github user yvsubhash commented on the issue: https://github.com/apache/cloudstack/pull/1726 @ustcweizhou thats good point. It should be removed after all download links expire. I will address this case --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1726: CLOUDSTACK-9560 Root volume of deleted VM left unrem...
Github user ustcweizhou commented on the issue: https://github.com/apache/cloudstack/pull/1726 @yvsubhash yes, you are right, it is 'download links', not 'volume snapshots'. I made changes on this long time ago and almost forgot how it works. so, my question is, should we 'Remove' the volume after a download link is expired, or all download links are expired ? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1726: CLOUDSTACK-9560 Root volume of deleted VM left unrem...
Github user yvsubhash commented on the issue: https://github.com/apache/cloudstack/pull/1726 @ustcweizhou As I understand, Volume goes to Expunged state when it is removed from primary and gets removed when it is removed from secondary storage. line 2211 to 2215 is to handle specific case where volume getting removed from primary But not getting removed from secondary because of the download link. So cleaning up the same after the downlink is expired --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1726: CLOUDSTACK-9560 Root volume of deleted VM left unrem...
Github user ustcweizhou commented on the issue: https://github.com/apache/cloudstack/pull/1726 @yvsubhash so, the question is , in what condition the volume is Expunged but not removed ? if it does not happen, then the change from line 2211 to 2215 is not needed. however, to be honest, I often see a volume is Expunged but not Removed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1726: CLOUDSTACK-9560 Root volume of deleted VM left unrem...
Github user yvsubhash commented on the issue: https://github.com/apache/cloudstack/pull/1726 @ustcweizhou In case of volume snapsnots, volume gets set to removed irrespective of the presence of snapshots. I have verified the same just now and I am only removing volume not any of the snapshots --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1726: CLOUDSTACK-9560 Root volume of deleted VM left unrem...
Github user ustcweizhou commented on the issue: https://github.com/apache/cloudstack/pull/1726 @yvsubhash I did not mean we need clean up the snapshots. in my understanding, if the volume has snapshots left, it is Expunged, but not marked as Removed your change just delete one snapshot and then mark the volume as Removed, however, there might be other snapshots left (in this case, we should not mark the volume as Removed) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1726: CLOUDSTACK-9560 Root volume of deleted VM left unrem...
Github user yvsubhash commented on the issue: https://github.com/apache/cloudstack/pull/1726 @rhtyd Can you please merge this --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1726: CLOUDSTACK-9560 Root volume of deleted VM left unrem...
Github user yvsubhash commented on the issue: https://github.com/apache/cloudstack/pull/1726 @ustcweizhou Volume snapshots would be left over even in case of normal vm destroy and that is expected. They can be used if there is a need to restore the volume at a later point in time. The snapshots are visible under storage->snapshots. So i dont see a need to clean up those snapshots --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1726: CLOUDSTACK-9560 Root volume of deleted VM left unrem...
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1726 @yvsubhash can you reply to raised review comments? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1726: CLOUDSTACK-9560 Root volume of deleted VM left unrem...
Github user blueorangutan commented on the issue: https://github.com/apache/cloudstack/pull/1726 Packaging result: âcentos6 âcentos7 âdebian. JID-190 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1726: CLOUDSTACK-9560 Root volume of deleted VM left unrem...
Github user blueorangutan commented on the issue: https://github.com/apache/cloudstack/pull/1726 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1726: CLOUDSTACK-9560 Root volume of deleted VM left unrem...
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1726 @blueorangutan package --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1726: CLOUDSTACK-9560 Root volume of deleted VM left unrem...
Github user koushik-das commented on the issue: https://github.com/apache/cloudstack/pull/1726 Code LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1726: CLOUDSTACK-9560 Root volume of deleted VM left unrem...
Github user blueorangutan commented on the issue: https://github.com/apache/cloudstack/pull/1726 Trillian test result (tid-179) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 24929 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr1726-t179-kvm-centos7.zip Test completed. 43 look ok, 0 have error(s) Test | Result | Time (s) | Test File --- | --- | --- | --- test_01_vpc_site2site_vpn | Success | 160.69 | test_vpc_vpn.py test_01_vpc_remote_access_vpn | Success | 66.88 | test_vpc_vpn.py test_01_redundant_vpc_site2site_vpn | Success | 251.75 | test_vpc_vpn.py test_02_VPC_default_routes | Success | 284.86 | test_vpc_router_nics.py test_01_VPC_nics_after_destroy | Success | 557.95 | test_vpc_router_nics.py test_05_rvpc_multi_tiers | Success | 515.21 | test_vpc_redundant.py test_04_rvpc_network_garbage_collector_nics | Success | 1310.57 | test_vpc_redundant.py test_03_create_redundant_VPC_1tier_2VMs_2IPs_2PF_ACL_reboot_routers | Success | 556.64 | test_vpc_redundant.py test_02_redundant_VPC_default_routes | Success | 763.30 | test_vpc_redundant.py test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL | Success | 1301.57 | test_vpc_redundant.py test_09_delete_detached_volume | Success | 15.53 | test_volumes.py test_08_resize_volume | Success | 15.48 | test_volumes.py test_07_resize_fail | Success | 20.45 | test_volumes.py test_06_download_detached_volume | Success | 15.55 | test_volumes.py test_05_detach_volume | Success | 100.34 | test_volumes.py test_04_delete_attached_volume | Success | 10.20 | test_volumes.py test_03_download_attached_volume | Success | 15.44 | test_volumes.py test_02_attach_volume | Success | 45.26 | test_volumes.py test_01_create_volume | Success | 714.64 | test_volumes.py test_deploy_vm_multiple | Success | 274.23 | test_vm_life_cycle.py test_deploy_vm | Success | 0.03 | test_vm_life_cycle.py test_advZoneVirtualRouter | Success | 0.02 | test_vm_life_cycle.py test_10_attachAndDetach_iso | Success | 26.97 | test_vm_life_cycle.py test_09_expunge_vm | Success | 125.19 | test_vm_life_cycle.py test_08_migrate_vm | Success | 41.34 | test_vm_life_cycle.py test_07_restore_vm | Success | 0.29 | test_vm_life_cycle.py test_06_destroy_vm | Success | 126.03 | test_vm_life_cycle.py test_03_reboot_vm | Success | 126.33 | test_vm_life_cycle.py test_02_start_vm | Success | 10.21 | test_vm_life_cycle.py test_01_stop_vm | Success | 35.40 | test_vm_life_cycle.py test_CreateTemplateWithDuplicateName | Success | 81.08 | test_templates.py test_08_list_system_templates | Success | 0.05 | test_templates.py test_07_list_public_templates | Success | 0.04 | test_templates.py test_05_template_permissions | Success | 0.06 | test_templates.py test_04_extract_template | Success | 5.16 | test_templates.py test_03_delete_template | Success | 5.21 | test_templates.py test_02_edit_template | Success | 90.27 | test_templates.py test_01_create_template | Success | 40.54 | test_templates.py test_10_destroy_cpvm | Success | 161.68 | test_ssvm.py test_09_destroy_ssvm | Success | 164.54 | test_ssvm.py test_08_reboot_cpvm | Success | 101.60 | test_ssvm.py test_07_reboot_ssvm | Success | 163.81 | test_ssvm.py test_06_stop_cpvm | Success | 132.02 | test_ssvm.py test_05_stop_ssvm | Success | 164.12 | test_ssvm.py test_04_cpvm_internals | Success | 1.32 | test_ssvm.py test_03_ssvm_internals | Success | 3.27 | test_ssvm.py test_02_list_cpvm_vm | Success | 0.12 | test_ssvm.py test_01_list_sec_storage_vm | Success | 0.13 | test_ssvm.py test_01_snapshot_root_disk | Success | 11.99 | test_snapshots.py test_04_change_offering_small | Success | 209.95 | test_service_offerings.py test_03_delete_service_offering | Success | 0.04 | test_service_offerings.py test_02_edit_service_offering | Success | 0.09 | test_service_offerings.py test_01_create_service_offering | Success | 0.10 | test_service_offerings.py test_02_sys_template_ready | Success | 0.12 | test_secondary_storage.py test_01_sys_vm_start | Success | 0.20 | test_secondary_storage.py test_09_reboot_router | Success | 40.45 | test_routers.py test_08_start_router | Success | 30.30 | test_routers.py test_07_stop_router | Success | 10.17 | test_routers.py test_06_router_advanced | Success | 0.05 | test_routers.py test_05_router_basic | Success | 0.04 | test_routers.py test_04_restart_network_wo_cleanup | Success | 5.68 | test_routers.py test_03_restart_network_cleanup | Success | 60.53 | test_routers.py test_02_router_internal_adv | Success | 1.16 | test_routers.py test_01_router_internal_basic | Success | 0.63 | test_routers.py test_router_dhcphosts | Success | 277.91 | test_router_dhcphosts.py
[GitHub] cloudstack issue #1726: CLOUDSTACK-9560 Root volume of deleted VM left unrem...
Github user yvsubhash commented on the issue: https://github.com/apache/cloudstack/pull/1726 @koushik-das Added the null check --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1726: CLOUDSTACK-9560 Root volume of deleted VM left unrem...
Github user blueorangutan commented on the issue: https://github.com/apache/cloudstack/pull/1726 @rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1726: CLOUDSTACK-9560 Root volume of deleted VM left unrem...
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1726 @blueorangutan test --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1726: CLOUDSTACK-9560 Root volume of deleted VM left unrem...
Github user blueorangutan commented on the issue: https://github.com/apache/cloudstack/pull/1726 Packaging result: âcentos6 âcentos7 âdebian. JID-91 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1726: CLOUDSTACK-9560 Root volume of deleted VM left unrem...
Github user blueorangutan commented on the issue: https://github.com/apache/cloudstack/pull/1726 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1726: CLOUDSTACK-9560 Root volume of deleted VM left unrem...
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1726 @blueorangutan package --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1726: CLOUDSTACK-9560 Root volume of deleted VM left unrem...
Github user syed commented on the issue: https://github.com/apache/cloudstack/pull/1726 LGTM :+1: --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
