[GitHub] cloudstack issue #1767: CLOUDSTACK-9457: Allow retrieval and modification of...
Github user nvazquez commented on the issue: https://github.com/apache/cloudstack/pull/1767 @karuturi @rafaelweingartner thanks! I closed Jira ticket 9379 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1767: CLOUDSTACK-9457: Allow retrieval and modification of...
Github user rafaelweingartner commented on the issue: https://github.com/apache/cloudstack/pull/1767 I have just reviewed the PR. There are only small suggestions I made. BTW: from the Jira ticket https://issues.apache.org/jira/browse/CLOUDSTACK-9457, I ended up at https://issues.apache.org/jira/browse/CLOUDSTACK-9379, which is already done. I do not have permission to mark it as done. I believe @nvazquez might have. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1767: CLOUDSTACK-9457: Allow retrieval and modification of...
Github user serg38 commented on the issue: https://github.com/apache/cloudstack/pull/1767 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1767: CLOUDSTACK-9457: Allow retrieval and modification of...
Github user serg38 commented on the issue: https://github.com/apache/cloudstack/pull/1767 @karuturi Can we merge this one ? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1767: CLOUDSTACK-9457: Allow retrieval and modification of...
Github user blueorangutan commented on the issue: https://github.com/apache/cloudstack/pull/1767 Trillian test result (tid-776) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 43663 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr1767-t776-kvm-centos7.zip Intermitten failure detected: /marvin/tests/smoke/test_privategw_acl.py Intermitten failure detected: /marvin/tests/smoke/test_routers_network_ops.py Intermitten failure detected: /marvin/tests/smoke/test_templates.py Intermitten failure detected: /marvin/tests/smoke/test_volumes.py Intermitten failure detected: /marvin/tests/smoke/test_vpc_redundant.py Test completed. 45 look ok, 4 have error(s) Test | Result | Time (s) | Test File --- | --- | --- | --- test_02_redundant_VPC_default_routes | `Failure` | 869.57 | test_vpc_redundant.py test_04_rvpc_privategw_static_routes | `Failure` | 391.44 | test_privategw_acl.py test_01_create_volume | `Error` | 279.98 | test_volumes.py test_03_delete_template | `Error` | 5.18 | test_templates.py test_01_vpc_site2site_vpn | Success | 195.95 | test_vpc_vpn.py test_01_vpc_remote_access_vpn | Success | 66.47 | test_vpc_vpn.py test_01_redundant_vpc_site2site_vpn | Success | 352.03 | test_vpc_vpn.py test_02_VPC_default_routes | Success | 453.60 | test_vpc_router_nics.py test_01_VPC_nics_after_destroy | Success | 827.87 | test_vpc_router_nics.py test_05_rvpc_multi_tiers | Success | 537.38 | test_vpc_redundant.py test_04_rvpc_network_garbage_collector_nics | Success | 1336.10 | test_vpc_redundant.py test_03_create_redundant_VPC_1tier_2VMs_2IPs_2PF_ACL_reboot_routers | Success | 580.77 | test_vpc_redundant.py test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL | Success | 1292.65 | test_vpc_redundant.py test_09_delete_detached_volume | Success | 156.61 | test_volumes.py test_08_resize_volume | Success | 156.44 | test_volumes.py test_07_resize_fail | Success | 161.53 | test_volumes.py test_06_download_detached_volume | Success | 156.58 | test_volumes.py test_05_detach_volume | Success | 241.36 | test_volumes.py test_04_delete_attached_volume | Success | 151.27 | test_volumes.py test_03_download_attached_volume | Success | 156.33 | test_volumes.py test_02_attach_volume | Success | 185.35 | test_volumes.py test_deploy_vm_multiple | Success | 338.47 | test_vm_life_cycle.py test_deploy_vm | Success | 0.04 | test_vm_life_cycle.py test_advZoneVirtualRouter | Success | 0.03 | test_vm_life_cycle.py test_10_attachAndDetach_iso | Success | 26.72 | test_vm_life_cycle.py test_09_expunge_vm | Success | 125.22 | test_vm_life_cycle.py test_08_migrate_vm | Success | 40.98 | test_vm_life_cycle.py test_07_restore_vm | Success | 0.14 | test_vm_life_cycle.py test_06_destroy_vm | Success | 125.93 | test_vm_life_cycle.py test_03_reboot_vm | Success | 126.01 | test_vm_life_cycle.py test_02_start_vm | Success | 10.20 | test_vm_life_cycle.py test_01_stop_vm | Success | 125.91 | test_vm_life_cycle.py test_CreateTemplateWithDuplicateName | Success | 70.76 | test_templates.py test_08_list_system_templates | Success | 0.03 | test_templates.py test_07_list_public_templates | Success | 0.04 | test_templates.py test_05_template_permissions | Success | 0.06 | test_templates.py test_04_extract_template | Success | 5.18 | test_templates.py test_02_edit_template | Success | 90.16 | test_templates.py test_01_create_template | Success | 50.54 | test_templates.py test_10_destroy_cpvm | Success | 161.84 | test_ssvm.py test_09_destroy_ssvm | Success | 163.62 | test_ssvm.py test_08_reboot_cpvm | Success | 131.73 | test_ssvm.py test_07_reboot_ssvm | Success | 133.64 | test_ssvm.py test_06_stop_cpvm | Success | 131.94 | test_ssvm.py test_05_stop_ssvm | Success | 133.80 | test_ssvm.py test_04_cpvm_internals | Success | 1.21 | test_ssvm.py test_03_ssvm_internals | Success | 3.48 | test_ssvm.py test_02_list_cpvm_vm | Success | 0.14 | test_ssvm.py test_01_list_sec_storage_vm | Success | 0.15 | test_ssvm.py test_01_snapshot_root_disk | Success | 11.32 | test_snapshots.py test_04_change_offering_small | Success | 242.88 | test_service_offerings.py test_03_delete_service_offering | Success | 0.04 | test_service_offerings.py test_02_edit_service_offering | Success | 0.06 | test_service_offerings.py test_01_create_service_offering | Success | 0.12 | test_service_offerings.py test_02_sys_template_ready | Success | 0.14 | test_secondary_storage.py test_01_sys_vm_start | Success | 0.20 | test_secondary_storage.py test_09_reboot_router | Success | 45.40 | test_routers.py test_08_start_router | Success | 30.31 | test_routers.py test_07_stop_router | Success | 10.19 | test_routers.py test_06_rou
[GitHub] cloudstack issue #1767: CLOUDSTACK-9457: Allow retrieval and modification of...
Github user blueorangutan commented on the issue: https://github.com/apache/cloudstack/pull/1767 @rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1767: CLOUDSTACK-9457: Allow retrieval and modification of...
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1767 @blueorangutan test --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1767: CLOUDSTACK-9457: Allow retrieval and modification of...
Github user blueorangutan commented on the issue: https://github.com/apache/cloudstack/pull/1767 Packaging result: âcentos6 âcentos7 âdebian. JID-451 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1767: CLOUDSTACK-9457: Allow retrieval and modification of...
Github user blueorangutan commented on the issue: https://github.com/apache/cloudstack/pull/1767 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1767: CLOUDSTACK-9457: Allow retrieval and modification of...
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1767 @serg38 sure @blueorangutan package --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1767: CLOUDSTACK-9457: Allow retrieval and modification of...
Github user serg38 commented on the issue: https://github.com/apache/cloudstack/pull/1767 @rhtyd Can you kick off tests for this PR? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1767: CLOUDSTACK-9457: Allow retrieval and modification of...
Github user nvazquez commented on the issue: https://github.com/apache/cloudstack/pull/1767 Hi @rhtyd @koushik-das @ustcweizhou, I refactored this PR removing previously created API commands, only adding an optional parameter (`cleanupdetails`) on `updateVirtualMachine` and `updateTemplate` commands to allow cleaning up details. Besides that change, add/edit/remove are now performed by `updateVirtualMachine` or `updateTemplate` as you suggested. I'll post screenshots on Description to show changes on the UI. Happy new year! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1767: CLOUDSTACK-9457: Allow retrieval and modification of...
Github user serg38 commented on the issue: https://github.com/apache/cloudstack/pull/1767 @nvazquez @koushik-das If we go this route we might want to change update API to behave consistently. It would make sense to allow overriding any details. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1767: CLOUDSTACK-9457: Allow retrieval and modification of...
Github user nvazquez commented on the issue: https://github.com/apache/cloudstack/pull/1767 @serg38 @koushik-das sure, I can work on it, the actual way is passing details as key value pairs on the update methods but I think it would require to define a way to delete details (for example the actual behaviour of `updateTemplates` overrides any existing detail for the ones provided under `details` field while on `updateVirtualMachines` they are added to the existing ones, not allowing to delete any detail) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1767: CLOUDSTACK-9457: Allow retrieval and modification of...
Github user serg38 commented on the issue: https://github.com/apache/cloudstack/pull/1767 @koushik-das No I don't. I tend to agree with you but obviously the implementation will be messier since configs are random. @nvazquez Do you think it can be changes so that modification is done via detail tag of updateVirtuaMachine and updateTemplate APIs. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1767: CLOUDSTACK-9457: Allow retrieval and modification of...
Github user koushik-das commented on the issue: https://github.com/apache/cloudstack/pull/1767 @serg38 @nvazquez Thanks for the update. As I understand form some of the detail parameter examples, these are tied to the lifecycle of the entity (create/destroy or start/stop of the VM). If thats the case then it make sense to pass on these details along with the corresponding lifecycle APIs rather than creating new APIs. Do you see any use case where the details are not tied to entity lifecycle? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1767: CLOUDSTACK-9457: Allow retrieval and modification of...
Github user serg38 commented on the issue: https://github.com/apache/cloudstack/pull/1767 @koushik-das @ustcweizhou Just want to add on the use case. There is growing need to change template/VM details for after the deployment e.g. to switch root disk controller or change ratio of cores/socket with cpuid.coresPerSocket or with adding vGPU startup parameters or switch boot firmware from bios to efi as required by some OS. Currently users are unable to easily do it with API and/or UI. As implemented now, all settings with display=1 in user_vm_details and vm_template_details will be returned by API and allowed to changed. If desired we can open another PR to switch details created by other API in automatic fashion to have display=0 so they will not show up in the response of these APIs and users wont be able to edit/delete them. We thought this to be out of scope for now. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1767: CLOUDSTACK-9457: Allow retrieval and modification of...
Github user nvazquez commented on the issue: https://github.com/apache/cloudstack/pull/1767 Hi @koushik-das @ustcweizhou, For this new methods as they require the entity id (VM or template) I added a basic validation to check if the entity is found on DB, but I realize that I should also validate that entity is not destroyed. This data is to be stored in *details tables. About existing API methods, I have checked `updateTemplate` and `updateVirtualMachines` methods before adding this new methods, and they provide a way to add/update details (although updateTemplate overrides existing details). Also, details can be listed on `listTemplates` and `listVirtualMachines` but thought the best approach was introducing this new methods to reduce overhead and treat entity details separately instead of updating/listing the entity every time. What do you think of this approach? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1767: CLOUDSTACK-9457: Allow retrieval and modification of...
Github user ustcweizhou commented on the issue: https://github.com/apache/cloudstack/pull/1767 I have the same concerns as @koushik-das . --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1767: CLOUDSTACK-9457: Allow retrieval and modification of...
Github user koushik-das commented on the issue: https://github.com/apache/cloudstack/pull/1767 @nvazquez Can you add use case details that will be addressed by these new methods? Also what kind of validation will be performed on the inputs and the state of the entity (VM or template)? Will it be metadata for book keeping only or will impact the entity during runtime? I am assuming that data will be stored in the corresponding *details table in DB. How will these APIs impact already existing data that are created using some other APIs and stored in the details table? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1767: CLOUDSTACK-9457: Allow retrieval and modification of...
Github user blueorangutan commented on the issue: https://github.com/apache/cloudstack/pull/1767 Packaging result: âcentos6 âcentos7 âdebian. JID-166 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1767: CLOUDSTACK-9457: Allow retrieval and modification of...
Github user blueorangutan commented on the issue: https://github.com/apache/cloudstack/pull/1767 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1767: CLOUDSTACK-9457: Allow retrieval and modification of...
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1767 @blueorangutan package --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
