[GitHub] cloudstack issue #1771: CLOUDSTACK-9611: Dedicating a Guest VLAN range to Pr...
Github user cloudmonger commented on the issue: https://github.com/apache/cloudstack/pull/1771 ### ACS CI BVT Run **Sumarry:** Build Number 468 Hypervisor xenserver NetworkType Advanced Passed=105 Failed=0 Skipped=7 _Link to logs Folder (search by build_no):_ https://www.dropbox.com/sh/yj3wnzbceo9uef2/AAB6u-Iap-xztdm6jHX9SjPja?dl=0 **Failed tests:** **Skipped tests:** test_01_test_vm_volume_snapshot test_vm_nic_adapter_vmxnet3 test_static_role_account_acls test_11_ss_nfs_version_on_ssvm test_nested_virtualization_vmware test_3d_gpu_support test_deploy_vgpu_enabled_vm **Passed test suits:** test_deploy_vm_with_userdata.py test_affinity_groups_projects.py test_portable_publicip.py test_over_provisioning.py test_global_settings.py test_scale_vm.py test_service_offerings.py test_routers_iptables_default_policy.py test_loadbalance.py test_routers.py test_reset_vm_on_reboot.py test_deploy_vms_with_varied_deploymentplanners.py test_network.py test_router_dns.py test_non_contigiousvlan.py test_login.py test_deploy_vm_iso.py test_list_ids_parameter.py test_public_ip_range.py test_multipleips_per_nic.py test_regions.py test_affinity_groups.py test_network_acl.py test_pvlan.py test_volumes.py test_nic.py test_deploy_vm_root_resize.py test_resource_detail.py test_secondary_storage.py test_vm_life_cycle.py test_routers_network_ops.py test_disk_offerings.py --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1771: CLOUDSTACK-9611: Dedicating a Guest VLAN range to Pr...
Github user nitin-maharana commented on the issue: https://github.com/apache/cloudstack/pull/1771 tag:mergeready --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1771: CLOUDSTACK-9611: Dedicating a Guest VLAN range to Pr...
Github user ustcweizhou commented on the issue: https://github.com/apache/cloudstack/pull/1771 @nitin-maharana yes, you are right. I forgot it. LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1771: CLOUDSTACK-9611: Dedicating a Guest VLAN range to Pr...
Github user nitin-maharana commented on the issue: https://github.com/apache/cloudstack/pull/1771 @ustcweizhou : In case of project view, the projectId is always passed. Also we consider it as project scope but we won't have any option to choose projects from a list because we are already under a project. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1771: CLOUDSTACK-9611: Dedicating a Guest VLAN range to Pr...
Github user ustcweizhou commented on the issue: https://github.com/apache/cloudstack/pull/1771 @nitin-maharana if this is performed in project view, should projectid be passed ? projectId: args.context.projects[0].id --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1771: CLOUDSTACK-9611: Dedicating a Guest VLAN range to Pr...
Github user nitin-maharana commented on the issue: https://github.com/apache/cloudstack/pull/1771 ping @rhtyd @karuturi --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1771: CLOUDSTACK-9611: Dedicating a Guest VLAN range to Pr...
Github user nitin-maharana commented on the issue: https://github.com/apache/cloudstack/pull/1771 @ustcweizhou : Please verify, I have changed according to your suggestion. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1771: CLOUDSTACK-9611: Dedicating a Guest VLAN range to Pr...
Github user nitin-maharana commented on the issue: https://github.com/apache/cloudstack/pull/1771 @ustcweizhou : The createProject API allows to created a project under a domain but no idea if there is any support from UI. Whenever I create a project, it always goes to ROOT domain. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1771: CLOUDSTACK-9611: Dedicating a Guest VLAN range to Pr...
Github user ustcweizhou commented on the issue: https://github.com/apache/cloudstack/pull/1771 @nitin-maharana cannot we dedicate guest vlan range to projects in other domains ? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1771: CLOUDSTACK-9611: Dedicating a Guest VLAN range to Pr...
Github user ustcweizhou commented on the issue: https://github.com/apache/cloudstack/pull/1771 @nitin-maharana I think it is better to list projects by domain. Just an example, if there are 3 projects with same name created in 3 domains, it will be difficult to choose. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1771: CLOUDSTACK-9611: Dedicating a Guest VLAN range to Pr...
Github user nitin-maharana commented on the issue: https://github.com/apache/cloudstack/pull/1771 @ustcweizhou : Yes, if domain changes, the project list should change. As per my understanding, a project is similar to an account. When we create a project, by default it is always created in ROOT domain. But an account can be created in a specific domain. I am still not clear what is the need of project. As all the projects are under ROOT domain, if we select any domain other than ROOT, the project list would be empty. So I think we needn't use the domain list in project scope and instead we should list all projects. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1771: CLOUDSTACK-9611: Dedicating a Guest VLAN range to Pr...
Github user ustcweizhou commented on the issue: https://github.com/apache/cloudstack/pull/1771 @nitin-maharana should projectId dependsOn domainId ? If the domain changes, the project list should change according to the new domainid. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1771: CLOUDSTACK-9611: Dedicating a Guest VLAN range to Pr...
Github user nitin-maharana commented on the issue: https://github.com/apache/cloudstack/pull/1771 @ustcweizhou : I have modified the code, can you review it one more time. Please see the below snapshot. https://cloud.githubusercontent.com/assets/12583725/23455743/b4d7be00-fe96-11e6-8a41-398c41f6d019.png;> --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1771: CLOUDSTACK-9611: Dedicating a Guest VLAN range to Pr...
Github user nitin-maharana commented on the issue: https://github.com/apache/cloudstack/pull/1771 @ustcweizhou : You are correct. We have to remove the domain scope. If we support the domain scope, we need more changes on the logic. In that case we can create a new ticket for that. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1771: CLOUDSTACK-9611: Dedicating a Guest VLAN range to Pr...
Github user ustcweizhou commented on the issue: https://github.com/apache/cloudstack/pull/1771 @nitin-maharana I thought dedicating guest vlan range is already implemented in CLOUDSTACK-8958. Actually they are two stories. In this case, we have to remove the Domain scope from UI as it is not supported, unless you make more changes to support it (similar to 37301ed4540450c29be4f975d58b38dbeec6c296 for CLOUDSTACK-8958). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1771: CLOUDSTACK-9611: Dedicating a Guest VLAN range to Pr...
Github user nitin-maharana commented on the issue: https://github.com/apache/cloudstack/pull/1771 @ustcweizhou : Passing project with domain won't create any issue but not passing any account details when we call the API from default view creates an issue. Because the internal logic expects account owner of VLAN when dedicated from the default view. In the case of project view, it gets the account detail from selected project. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1771: CLOUDSTACK-9611: Dedicating a Guest VLAN range to Pr...
Github user ustcweizhou commented on the issue:
https://github.com/apache/cloudstack/pull/1771
@nitin-maharana you may add "ignoreProject: true" in
createURL('dedicateGuestVlanRange') if scope is set to Domain
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1771: CLOUDSTACK-9611: Dedicating a Guest VLAN range to Pr...
Github user nitin-maharana commented on the issue: https://github.com/apache/cloudstack/pull/1771 @ustcweizhou @koushik-das : I implemented the way @ustcweizhou's suggested. It was purely an UI change. But I found an issue while testing. On API side, the entire logic uses VLAN owner account details, they find it from the account given by the user. So, they made account field as mandatory. But that contradicts when it is accessed from a project view(This issue). The current logic works in a default view because we don't add projectid details while accessing the API. But when it is accessed from a particular project view, by default the projectid parameter is added with the API call, So this issue arises. Now, if we go with the change suggested by @ustcweizhou, once we select the scope as domain, we don't pass any account details, so the logic can't able to find the owner hence gives an error. According to my suggestion, On API side, we should make the account field as optional and on UI front, we should make it mandatory and the account field will appear only in case of default view, which will fix the issue. Please give your input on this. Accordingly, I will proceed. Please see the current change(I pushed it here) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1771: CLOUDSTACK-9611: Dedicating a Guest VLAN range to Pr...
Github user nitin-maharana commented on the issue: https://github.com/apache/cloudstack/pull/1771 ping @karuturi @sateesh-chodapuneedi --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1771: CLOUDSTACK-9611: Dedicating a Guest VLAN range to Pr...
Github user blueorangutan commented on the issue: https://github.com/apache/cloudstack/pull/1771 Packaging result: âcentos6 âcentos7 âdebian. JID-375 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1771: CLOUDSTACK-9611: Dedicating a Guest VLAN range to Pr...
Github user blueorangutan commented on the issue: https://github.com/apache/cloudstack/pull/1771 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1771: CLOUDSTACK-9611: Dedicating a Guest VLAN range to Pr...
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1771 @blueorangutan package --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1771: CLOUDSTACK-9611: Dedicating a Guest VLAN range to Pr...
Github user nitin-maharana commented on the issue: https://github.com/apache/cloudstack/pull/1771 @rhtyd : Changed PR's base branch to 4.9 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1771: CLOUDSTACK-9611: Dedicating a Guest VLAN range to Pr...
Github user rajesh-battala commented on the issue: https://github.com/apache/cloudstack/pull/1771 Gone through the patch. LGTM. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
