[GitHub] cloudstack issue #1881: CLOUDSTACK-9721: Remove deprecated/unused global con...
Github user cloudmonger commented on the issue: https://github.com/apache/cloudstack/pull/1881 ### ACS CI BVT Run **Sumarry:** Build Number 365 Hypervisor xenserver NetworkType Advanced Passed=105 Failed=0 Skipped=7 _Link to logs Folder (search by build_no):_ https://www.dropbox.com/sh/yj3wnzbceo9uef2/AAB6u-Iap-xztdm6jHX9SjPja?dl=0 **Failed tests:** **Skipped tests:** test_01_test_vm_volume_snapshot test_vm_nic_adapter_vmxnet3 test_static_role_account_acls test_11_ss_nfs_version_on_ssvm test_nested_virtualization_vmware test_3d_gpu_support test_deploy_vgpu_enabled_vm **Passed test suits:** test_deploy_vm_with_userdata.py test_affinity_groups_projects.py test_portable_publicip.py test_over_provisioning.py test_global_settings.py test_scale_vm.py test_service_offerings.py test_routers_iptables_default_policy.py test_loadbalance.py test_routers.py test_reset_vm_on_reboot.py test_deploy_vms_with_varied_deploymentplanners.py test_network.py test_router_dns.py test_non_contigiousvlan.py test_login.py test_deploy_vm_iso.py test_list_ids_parameter.py test_public_ip_range.py test_multipleips_per_nic.py test_regions.py test_affinity_groups.py test_network_acl.py test_pvlan.py test_volumes.py test_nic.py test_deploy_vm_root_resize.py test_resource_detail.py test_secondary_storage.py test_vm_life_cycle.py test_routers_network_ops.py test_disk_offerings.py --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1881: CLOUDSTACK-9721: Remove deprecated/unused global con...
Github user karuturi commented on the issue: https://github.com/apache/cloudstack/pull/1881 configuration cleanup. needs BVT --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1881: CLOUDSTACK-9721: Remove deprecated/unused global con...
Github user rafaelweingartner commented on the issue: https://github.com/apache/cloudstack/pull/1881 @sureshanaparti Thanks for the cleanup. LGTM @sateesh-chodapuneedi this is a good question. The changes here remove an attribute of an Enum that is not referenced anywhere. In my opinion, we should not need to run function tests. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1881: CLOUDSTACK-9721: Remove deprecated/unused global con...
Github user sateesh-chodapuneedi commented on the issue: https://github.com/apache/cloudstack/pull/1881 @karuturi As this PR is about removal of a deprecated configuration setting which is no more referenced any where in the repo, can we merge this without functional tests? Or we could make this PR part of a place holder PR so that we can trigger trillian tests more multiple PRs at once? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1881: CLOUDSTACK-9721: Remove deprecated/unused global con...
Github user koushik-das commented on the issue: https://github.com/apache/cloudstack/pull/1881 Code changes LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
