[GitHub] cloudstack issue #1905: CLOUDSTACK-9738: [Vmware] Optimize vm expunge proces...
Github user nvazquez commented on the issue: https://github.com/apache/cloudstack/pull/1905 @karuturi thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1905: CLOUDSTACK-9738: [Vmware] Optimize vm expunge proces...
Github user karuturi commented on the issue: https://github.com/apache/cloudstack/pull/1905 Thanks for the clarification. Its a nice enhancement. LGTM for the changes. Marvin tests are always welcome :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1905: CLOUDSTACK-9738: [Vmware] Optimize vm expunge proces...
Github user nvazquez commented on the issue: https://github.com/apache/cloudstack/pull/1905 @karuturi regarding tests done, we've compared the number of delete tasks sent to Vmware hypervisor on expunging a vm with `N` vm snapshots before and after this optimization, reducing from `N+1` tasks to only `1`. Is a marvin test required for this case? Thanks --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1905: CLOUDSTACK-9738: [Vmware] Optimize vm expunge proces...
Github user nvazquez commented on the issue: https://github.com/apache/cloudstack/pull/1905 Hi @karuturi, On Vmware, step 2 reduces tasks sent to hypervisor by sending only one task which actually deletes vm snapshots and the vm itself instead of sending one for each vm snapshot plus the one for the vm. For other hypervisors, it would work the same. I refactored this PR adding tag [Vmware] on title too. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
