[GitHub] cloudstack issue #1935: CLOUDSTACK-9764: Delete domain failure due to Accoun...
Github user rafaelweingartner commented on the issue: https://github.com/apache/cloudstack/pull/1935 @nvazquez now everything seems to be ok LGTM. Great job! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1935: CLOUDSTACK-9764: Delete domain failure due to Accoun...
Github user nvazquez commented on the issue: https://github.com/apache/cloudstack/pull/1935 @rafaelweingartner thanks for reviewing again! Minor refactor pushed --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1935: CLOUDSTACK-9764: Delete domain failure due to Accoun...
Github user blueorangutan commented on the issue: https://github.com/apache/cloudstack/pull/1935 Trillian test result (tid-973) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 29259 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr1935-t973-kvm-centos7.zip Intermitten failure detected: /marvin/tests/smoke/test_privategw_acl.py Test completed. 48 look ok, 1 have error(s) Test | Result | Time (s) | Test File --- | --- | --- | --- test_04_rvpc_privategw_static_routes | `Failure` | 335.65 | test_privategw_acl.py test_01_vpc_site2site_vpn | Success | 150.05 | test_vpc_vpn.py test_01_vpc_remote_access_vpn | Success | 61.16 | test_vpc_vpn.py test_01_redundant_vpc_site2site_vpn | Success | 245.99 | test_vpc_vpn.py test_02_VPC_default_routes | Success | 264.01 | test_vpc_router_nics.py test_01_VPC_nics_after_destroy | Success | 553.63 | test_vpc_router_nics.py test_05_rvpc_multi_tiers | Success | 512.64 | test_vpc_redundant.py test_04_rvpc_network_garbage_collector_nics | Success | 1410.93 | test_vpc_redundant.py test_03_create_redundant_VPC_1tier_2VMs_2IPs_2PF_ACL_reboot_routers | Success | 548.06 | test_vpc_redundant.py test_02_redundant_VPC_default_routes | Success | 745.11 | test_vpc_redundant.py test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL | Success | 1306.39 | test_vpc_redundant.py test_09_delete_detached_volume | Success | 156.51 | test_volumes.py test_08_resize_volume | Success | 156.45 | test_volumes.py test_07_resize_fail | Success | 161.44 | test_volumes.py test_06_download_detached_volume | Success | 156.43 | test_volumes.py test_05_detach_volume | Success | 150.80 | test_volumes.py test_04_delete_attached_volume | Success | 151.22 | test_volumes.py test_03_download_attached_volume | Success | 156.38 | test_volumes.py test_02_attach_volume | Success | 89.17 | test_volumes.py test_01_create_volume | Success | 622.16 | test_volumes.py test_03_delete_vm_snapshots | Success | 275.25 | test_vm_snapshots.py test_02_revert_vm_snapshots | Success | 100.71 | test_vm_snapshots.py test_01_create_vm_snapshots | Success | 168.82 | test_vm_snapshots.py test_deploy_vm_multiple | Success | 272.66 | test_vm_life_cycle.py test_deploy_vm | Success | 0.03 | test_vm_life_cycle.py test_advZoneVirtualRouter | Success | 0.02 | test_vm_life_cycle.py test_10_attachAndDetach_iso | Success | 26.55 | test_vm_life_cycle.py test_09_expunge_vm | Success | 125.24 | test_vm_life_cycle.py test_08_migrate_vm | Success | 30.88 | test_vm_life_cycle.py test_07_restore_vm | Success | 0.13 | test_vm_life_cycle.py test_06_destroy_vm | Success | 125.81 | test_vm_life_cycle.py test_03_reboot_vm | Success | 125.84 | test_vm_life_cycle.py test_02_start_vm | Success | 10.17 | test_vm_life_cycle.py test_01_stop_vm | Success | 35.29 | test_vm_life_cycle.py test_CreateTemplateWithDuplicateName | Success | 161.14 | test_templates.py test_08_list_system_templates | Success | 0.04 | test_templates.py test_07_list_public_templates | Success | 0.04 | test_templates.py test_05_template_permissions | Success | 0.05 | test_templates.py test_04_extract_template | Success | 5.17 | test_templates.py test_03_delete_template | Success | 5.11 | test_templates.py test_02_edit_template | Success | 90.13 | test_templates.py test_01_create_template | Success | 35.41 | test_templates.py test_10_destroy_cpvm | Success | 161.64 | test_ssvm.py test_09_destroy_ssvm | Success | 133.24 | test_ssvm.py test_08_reboot_cpvm | Success | 131.61 | test_ssvm.py test_07_reboot_ssvm | Success | 133.65 | test_ssvm.py test_06_stop_cpvm | Success | 131.74 | test_ssvm.py test_05_stop_ssvm | Success | 163.77 | test_ssvm.py test_04_cpvm_internals | Success | 1.24 | test_ssvm.py test_03_ssvm_internals | Success | 3.37 | test_ssvm.py test_02_list_cpvm_vm | Success | 0.12 | test_ssvm.py test_01_list_sec_storage_vm | Success | 0.13 | test_ssvm.py test_02_list_snapshots_with_removed_data_store | Success | 86.81 | test_snapshots.py test_01_snapshot_root_disk | Success | 16.33 | test_snapshots.py test_04_change_offering_small | Success | 209.54 | test_service_offerings.py test_03_delete_service_offering | Success | 0.04 | test_service_offerings.py test_02_edit_service_offering | Success | 0.06 | test_service_offerings.py test_01_create_service_offering | Success | 0.11 | test_service_offerings.py test_02_sys_template_ready | Success | 0.14 | test_secondary_storage.py test_01_sys_vm_start | Success | 0.18 | test_secondary_storage.py test_09_reboot_router | Success | 35.35 | test_routers.py test_08_start_router | Success | 30.32 | test_routers.py test_07_stop_router | Success | 10.18 | test_routers.py
[GitHub] cloudstack issue #1935: CLOUDSTACK-9764: Delete domain failure due to Accoun...
Github user borisstoyanov commented on the issue: https://github.com/apache/cloudstack/pull/1935 @blueorangutan test --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1935: CLOUDSTACK-9764: Delete domain failure due to Accoun...
Github user blueorangutan commented on the issue: https://github.com/apache/cloudstack/pull/1935 @borisstoyanov a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1935: CLOUDSTACK-9764: Delete domain failure due to Accoun...
Github user blueorangutan commented on the issue: https://github.com/apache/cloudstack/pull/1935 Packaging result: âcentos6 âcentos7 âdebian. JID-614 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1935: CLOUDSTACK-9764: Delete domain failure due to Accoun...
Github user blueorangutan commented on the issue: https://github.com/apache/cloudstack/pull/1935 @borisstoyanov a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1935: CLOUDSTACK-9764: Delete domain failure due to Accoun...
Github user borisstoyanov commented on the issue: https://github.com/apache/cloudstack/pull/1935 @blueorangutan package --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1935: CLOUDSTACK-9764: Delete domain failure due to Accoun...
Github user nvazquez commented on the issue: https://github.com/apache/cloudstack/pull/1935 @borisstoyanov I've rebased master branch, can we re-run tests on this PR? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1935: CLOUDSTACK-9764: Delete domain failure due to Accoun...
Github user nvazquez commented on the issue: https://github.com/apache/cloudstack/pull/1935 Hi @rafaelweingartner, I've refactored the code instead of using `rollBackState` as static. I think that using static variable could lead to a problem if new methods are invoked from another method different than `deleteDomain` method. Instead of declaring it as static, we reduced the scope again and only set it true when `CloudRuntimeException` is thrown. What do you think about this refactor? I tryied not to introduce major changes in original code --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1935: CLOUDSTACK-9764: Delete domain failure due to Accoun...
Github user serg38 commented on the issue: https://github.com/apache/cloudstack/pull/1935 @rhtyd @karuturi To fix errors in B.O in test_02_list_snapshots_with_removed_data_store we need to merge PR1961 and then adjust test_data on B.O side to have correct mapping for nfs2 label --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1935: CLOUDSTACK-9764: Delete domain failure due to Accoun...
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1935 @nvazquez can you check if the failures in above test results are related to your changes, thanks. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1935: CLOUDSTACK-9764: Delete domain failure due to Accoun...
Github user blueorangutan commented on the issue: https://github.com/apache/cloudstack/pull/1935 Trillian test result (tid-896) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 32396 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr1935-t896-kvm-centos7.zip Intermitten failure detected: /marvin/tests/smoke/test_privategw_acl.py Intermitten failure detected: /marvin/tests/smoke/test_snapshots.py Intermitten failure detected: /marvin/tests/smoke/test_vpc_redundant.py Test completed. 46 look ok, 3 have error(s) Test | Result | Time (s) | Test File --- | --- | --- | --- test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL | `Failure` | 363.77 | test_vpc_redundant.py test_04_rvpc_privategw_static_routes | `Failure` | 345.94 | test_privategw_acl.py test_02_list_snapshots_with_removed_data_store | `Error` | 0.04 | test_snapshots.py test_01_vpc_site2site_vpn | Success | 141.33 | test_vpc_vpn.py test_01_vpc_remote_access_vpn | Success | 56.08 | test_vpc_vpn.py test_01_redundant_vpc_site2site_vpn | Success | 231.05 | test_vpc_vpn.py test_02_VPC_default_routes | Success | 258.91 | test_vpc_router_nics.py test_01_VPC_nics_after_destroy | Success | 531.86 | test_vpc_router_nics.py test_05_rvpc_multi_tiers | Success | 521.44 | test_vpc_redundant.py test_04_rvpc_network_garbage_collector_nics | Success | 1407.93 | test_vpc_redundant.py test_03_create_redundant_VPC_1tier_2VMs_2IPs_2PF_ACL_reboot_routers | Success | 537.92 | test_vpc_redundant.py test_02_redundant_VPC_default_routes | Success | 755.43 | test_vpc_redundant.py test_09_delete_detached_volume | Success | 151.68 | test_volumes.py test_08_resize_volume | Success | 156.42 | test_volumes.py test_07_resize_fail | Success | 161.56 | test_volumes.py test_06_download_detached_volume | Success | 156.35 | test_volumes.py test_05_detach_volume | Success | 145.71 | test_volumes.py test_04_delete_attached_volume | Success | 146.22 | test_volumes.py test_03_download_attached_volume | Success | 156.37 | test_volumes.py test_02_attach_volume | Success | 84.13 | test_volumes.py test_01_create_volume | Success | 621.25 | test_volumes.py test_03_delete_vm_snapshots | Success | 275.20 | test_vm_snapshots.py test_02_revert_vm_snapshots | Success | 95.69 | test_vm_snapshots.py test_01_create_vm_snapshots | Success | 163.72 | test_vm_snapshots.py test_deploy_vm_multiple | Success | 232.62 | test_vm_life_cycle.py test_deploy_vm | Success | 0.04 | test_vm_life_cycle.py test_advZoneVirtualRouter | Success | 0.03 | test_vm_life_cycle.py test_10_attachAndDetach_iso | Success | 26.52 | test_vm_life_cycle.py test_09_expunge_vm | Success | 125.25 | test_vm_life_cycle.py test_08_migrate_vm | Success | 35.90 | test_vm_life_cycle.py test_07_restore_vm | Success | 0.13 | test_vm_life_cycle.py test_06_destroy_vm | Success | 125.94 | test_vm_life_cycle.py test_03_reboot_vm | Success | 125.90 | test_vm_life_cycle.py test_02_start_vm | Success | 10.17 | test_vm_life_cycle.py test_01_stop_vm | Success | 35.30 | test_vm_life_cycle.py test_CreateTemplateWithDuplicateName | Success | 50.55 | test_templates.py test_08_list_system_templates | Success | 0.03 | test_templates.py test_07_list_public_templates | Success | 0.06 | test_templates.py test_05_template_permissions | Success | 0.06 | test_templates.py test_04_extract_template | Success | 5.14 | test_templates.py test_03_delete_template | Success | 5.13 | test_templates.py test_02_edit_template | Success | 90.13 | test_templates.py test_01_create_template | Success | 30.36 | test_templates.py test_10_destroy_cpvm | Success | 161.39 | test_ssvm.py test_09_destroy_ssvm | Success | 138.56 | test_ssvm.py test_08_reboot_cpvm | Success | 101.35 | test_ssvm.py test_07_reboot_ssvm | Success | 133.54 | test_ssvm.py test_06_stop_cpvm | Success | 131.57 | test_ssvm.py test_05_stop_ssvm | Success | 163.76 | test_ssvm.py test_04_cpvm_internals | Success | 0.97 | test_ssvm.py test_03_ssvm_internals | Success | 3.30 | test_ssvm.py test_02_list_cpvm_vm | Success | 0.13 | test_ssvm.py test_01_list_sec_storage_vm | Success | 0.15 | test_ssvm.py test_01_snapshot_root_disk | Success | 11.27 | test_snapshots.py test_04_change_offering_small | Success | 234.58 | test_service_offerings.py test_03_delete_service_offering | Success | 0.04 | test_service_offerings.py test_02_edit_service_offering | Success | 0.06 | test_service_offerings.py test_01_create_service_offering | Success | 0.11 | test_service_offerings.py test_02_sys_template_ready | Success | 0.15 | test_secondary_storage.py test_01_sys_vm_start | Success | 0.18 | test_secondary_storage.py test_09_reboot_router | Success | 35.33
[GitHub] cloudstack issue #1935: CLOUDSTACK-9764: Delete domain failure due to Accoun...
Github user borisstoyanov commented on the issue: https://github.com/apache/cloudstack/pull/1935 @blueorangutan test --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1935: CLOUDSTACK-9764: Delete domain failure due to Accoun...
Github user blueorangutan commented on the issue: https://github.com/apache/cloudstack/pull/1935 @borisstoyanov a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1935: CLOUDSTACK-9764: Delete domain failure due to Accoun...
Github user blueorangutan commented on the issue: https://github.com/apache/cloudstack/pull/1935 Packaging result: âcentos6 âcentos7 âdebian. JID-537 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1935: CLOUDSTACK-9764: Delete domain failure due to Accoun...
Github user borisstoyanov commented on the issue: https://github.com/apache/cloudstack/pull/1935 @blueorangutan package --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1935: CLOUDSTACK-9764: Delete domain failure due to Accoun...
Github user blueorangutan commented on the issue: https://github.com/apache/cloudstack/pull/1935 @borisstoyanov a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1935: CLOUDSTACK-9764: Delete domain failure due to Accoun...
Github user rafaelweingartner commented on the issue: https://github.com/apache/cloudstack/pull/1935 @serg38 I did, the code is great as always. However, I have a concern about that `rollBackState` variable being static there. Because the `DomainManagerImpl ` is a singleton, using that variable may create problems. Instead of using the variable to indicate when the rollback has to be executed, we could do the same using an exception (the exception is already thrown when the variable is set to `true`). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1935: CLOUDSTACK-9764: Delete domain failure due to Accoun...
Github user serg38 commented on the issue: https://github.com/apache/cloudstack/pull/1935 @rafaelweingartner Can you review latest updates from @nvazquez . Since tests are passing this PR will be ready for merging to 4.10 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1935: CLOUDSTACK-9764: Delete domain failure due to Accoun...
Github user nvazquez commented on the issue: https://github.com/apache/cloudstack/pull/1935 @rafaelweingartner no problem, I should have mentioned about changing the variable to static. I'll work on your last comments :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1935: CLOUDSTACK-9764: Delete domain failure due to Accoun...
Github user rafaelweingartner commented on the issue: https://github.com/apache/cloudstack/pull/1935 @nvazquez was the static declaration there before?! I am so sorry I missed it. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1935: CLOUDSTACK-9764: Delete domain failure due to Accoun...
Github user blueorangutan commented on the issue: https://github.com/apache/cloudstack/pull/1935 Trillian test result (tid-876) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 35807 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr1935-t876-kvm-centos7.zip Intermitten failure detected: /marvin/tests/smoke/test_network.py Intermitten failure detected: /marvin/tests/smoke/test_privategw_acl.py Intermitten failure detected: /marvin/tests/smoke/test_snapshots.py Intermitten failure detected: /marvin/tests/smoke/test_vpc_redundant.py Test completed. 46 look ok, 3 have error(s) Test | Result | Time (s) | Test File --- | --- | --- | --- test_02_redundant_VPC_default_routes | `Failure` | 864.13 | test_vpc_redundant.py test_04_rvpc_privategw_static_routes | `Failure` | 320.45 | test_privategw_acl.py test_02_list_snapshots_with_removed_data_store | `Error` | 0.04 | test_snapshots.py test_01_vpc_site2site_vpn | Success | 160.52 | test_vpc_vpn.py test_01_vpc_remote_access_vpn | Success | 61.11 | test_vpc_vpn.py test_01_redundant_vpc_site2site_vpn | Success | 250.72 | test_vpc_vpn.py test_02_VPC_default_routes | Success | 287.25 | test_vpc_router_nics.py test_01_VPC_nics_after_destroy | Success | 545.04 | test_vpc_router_nics.py test_05_rvpc_multi_tiers | Success | 512.25 | test_vpc_redundant.py test_04_rvpc_network_garbage_collector_nics | Success | 1414.74 | test_vpc_redundant.py test_03_create_redundant_VPC_1tier_2VMs_2IPs_2PF_ACL_reboot_routers | Success | 548.99 | test_vpc_redundant.py test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL | Success | 1297.58 | test_vpc_redundant.py test_09_delete_detached_volume | Success | 151.41 | test_volumes.py test_08_resize_volume | Success | 156.44 | test_volumes.py test_07_resize_fail | Success | 156.52 | test_volumes.py test_06_download_detached_volume | Success | 156.34 | test_volumes.py test_05_detach_volume | Success | 155.91 | test_volumes.py test_04_delete_attached_volume | Success | 151.44 | test_volumes.py test_03_download_attached_volume | Success | 151.32 | test_volumes.py test_02_attach_volume | Success | 95.17 | test_volumes.py test_01_create_volume | Success | 711.28 | test_volumes.py test_03_delete_vm_snapshots | Success | 275.17 | test_vm_snapshots.py test_02_revert_vm_snapshots | Success | 95.78 | test_vm_snapshots.py test_01_create_vm_snapshots | Success | 163.76 | test_vm_snapshots.py test_deploy_vm_multiple | Success | 247.75 | test_vm_life_cycle.py test_deploy_vm | Success | 0.04 | test_vm_life_cycle.py test_advZoneVirtualRouter | Success | 0.03 | test_vm_life_cycle.py test_10_attachAndDetach_iso | Success | 26.64 | test_vm_life_cycle.py test_09_expunge_vm | Success | 125.25 | test_vm_life_cycle.py test_08_migrate_vm | Success | 40.94 | test_vm_life_cycle.py test_07_restore_vm | Success | 0.13 | test_vm_life_cycle.py test_06_destroy_vm | Success | 125.84 | test_vm_life_cycle.py test_03_reboot_vm | Success | 125.87 | test_vm_life_cycle.py test_02_start_vm | Success | 10.17 | test_vm_life_cycle.py test_01_stop_vm | Success | 40.33 | test_vm_life_cycle.py test_CreateTemplateWithDuplicateName | Success | 40.46 | test_templates.py test_08_list_system_templates | Success | 0.03 | test_templates.py test_07_list_public_templates | Success | 0.04 | test_templates.py test_05_template_permissions | Success | 0.06 | test_templates.py test_04_extract_template | Success | 5.16 | test_templates.py test_03_delete_template | Success | 5.11 | test_templates.py test_02_edit_template | Success | 90.18 | test_templates.py test_01_create_template | Success | 40.43 | test_templates.py test_10_destroy_cpvm | Success | 166.69 | test_ssvm.py test_09_destroy_ssvm | Success | 163.56 | test_ssvm.py test_08_reboot_cpvm | Success | 101.57 | test_ssvm.py test_07_reboot_ssvm | Success | 163.59 | test_ssvm.py test_06_stop_cpvm | Success | 132.19 | test_ssvm.py test_05_stop_ssvm | Success | 164.02 | test_ssvm.py test_04_cpvm_internals | Success | 1.22 | test_ssvm.py test_03_ssvm_internals | Success | 3.42 | test_ssvm.py test_02_list_cpvm_vm | Success | 0.12 | test_ssvm.py test_01_list_sec_storage_vm | Success | 0.13 | test_ssvm.py test_01_snapshot_root_disk | Success | 11.11 | test_snapshots.py test_04_change_offering_small | Success | 210.27 | test_service_offerings.py test_03_delete_service_offering | Success | 0.04 | test_service_offerings.py test_02_edit_service_offering | Success | 0.05 | test_service_offerings.py test_01_create_service_offering | Success | 0.11 | test_service_offerings.py test_02_sys_template_ready | Success | 0.13 | test_secondary_storage.py test_01_sys_vm_start | Success | 0.18
[GitHub] cloudstack issue #1935: CLOUDSTACK-9764: Delete domain failure due to Accoun...
Github user nvazquez commented on the issue: https://github.com/apache/cloudstack/pull/1935 @rafaelweingartner I think I got your point, I tried to keep code as similar as it was before, by declaring `rollBackState` as static class variable on line 114. This way inner `finally` block would work the same as before when one of new methods set `rollBackState = true.` On outter `finally` block, `rollBackState` is set to false (line 345), this way each time `deleteDomain` is invoked it would start on false (maybe it would be easier to move it at the beggining of `deleteDomain`). Do you agree with this approach? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1935: CLOUDSTACK-9764: Delete domain failure due to Accoun...
Github user rafaelweingartner commented on the issue: https://github.com/apache/cloudstack/pull/1935 @nvazquez great work. However, there is a catch there that I think you might have overlooked. This problem is caused by the method extraction I suggested. If you take a look at the code before the extraction, every time that an exception is thrown, the code was setting the variable `rollBackState = true`. This happens at lines 287, 305, and 313. Now that the code was extracted, setting those variables to `true` does not work anymore, because of the context those variables are declared change. In my opinion, this code was kind of weird before. It was throwing an exception that is caught right away and setting a control variable to be executed on `finally` block. The only reason I see for this is that if other exceptions that are not the ones generated at lines 292, 310, and 325 happen, and we do not want to execute the rollback for them. However, this seems error prone, leading to database inconsistencies. I would change the "rollback" code (lines 342-345) to the catch block. I do not know if I have been clear, we can discuss this further. I may have overlooked some bits of it as well (it is a quite complicated bit of code). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1935: CLOUDSTACK-9764: Delete domain failure due to Accoun...
Github user nvazquez commented on the issue: https://github.com/apache/cloudstack/pull/1935 @rafaelweingartner thanks for reviewing! I extracted code to new methods and also added unit tests for them --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1935: CLOUDSTACK-9764: Delete domain failure due to Accoun...
Github user blueorangutan commented on the issue: https://github.com/apache/cloudstack/pull/1935 @borisstoyanov a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1935: CLOUDSTACK-9764: Delete domain failure due to Accoun...
Github user borisstoyanov commented on the issue: https://github.com/apache/cloudstack/pull/1935 @blueorangutan test --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1935: CLOUDSTACK-9764: Delete domain failure due to Accoun...
Github user blueorangutan commented on the issue: https://github.com/apache/cloudstack/pull/1935 Packaging result: âcentos6 âcentos7 âdebian. JID-520 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1935: CLOUDSTACK-9764: Delete domain failure due to Accoun...
Github user borisstoyanov commented on the issue: https://github.com/apache/cloudstack/pull/1935 @blueorangutan package --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1935: CLOUDSTACK-9764: Delete domain failure due to Accoun...
Github user blueorangutan commented on the issue: https://github.com/apache/cloudstack/pull/1935 @borisstoyanov a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1935: CLOUDSTACK-9764: Delete domain failure due to Accoun...
Github user blueorangutan commented on the issue: https://github.com/apache/cloudstack/pull/1935 Trillian test result (tid-810) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 32603 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr1935-t810-kvm-centos7.zip Intermitten failure detected: /marvin/tests/smoke/test_privategw_acl.py Intermitten failure detected: /marvin/tests/smoke/test_vpc_redundant.py Test completed. 47 look ok, 2 have error(s) Test | Result | Time (s) | Test File --- | --- | --- | --- test_02_redundant_VPC_default_routes | `Failure` | 854.15 | test_vpc_redundant.py test_04_rvpc_privategw_static_routes | `Failure` | 310.34 | test_privategw_acl.py test_01_vpc_site2site_vpn | Success | 159.79 | test_vpc_vpn.py test_01_vpc_remote_access_vpn | Success | 66.17 | test_vpc_vpn.py test_01_redundant_vpc_site2site_vpn | Success | 236.31 | test_vpc_vpn.py test_02_VPC_default_routes | Success | 253.89 | test_vpc_router_nics.py test_01_VPC_nics_after_destroy | Success | 533.13 | test_vpc_router_nics.py test_05_rvpc_multi_tiers | Success | 505.05 | test_vpc_redundant.py test_04_rvpc_network_garbage_collector_nics | Success | 1413.32 | test_vpc_redundant.py test_03_create_redundant_VPC_1tier_2VMs_2IPs_2PF_ACL_reboot_routers | Success | 543.16 | test_vpc_redundant.py test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL | Success | 1269.24 | test_vpc_redundant.py test_09_delete_detached_volume | Success | 156.44 | test_volumes.py test_08_resize_volume | Success | 151.68 | test_volumes.py test_07_resize_fail | Success | 161.54 | test_volumes.py test_06_download_detached_volume | Success | 156.35 | test_volumes.py test_05_detach_volume | Success | 150.77 | test_volumes.py test_04_delete_attached_volume | Success | 151.29 | test_volumes.py test_03_download_attached_volume | Success | 156.30 | test_volumes.py test_02_attach_volume | Success | 84.34 | test_volumes.py test_01_create_volume | Success | 621.02 | test_volumes.py test_03_delete_vm_snapshots | Success | 275.20 | test_vm_snapshots.py test_02_revert_vm_snapshots | Success | 95.77 | test_vm_snapshots.py test_01_create_vm_snapshots | Success | 158.77 | test_vm_snapshots.py test_deploy_vm_multiple | Success | 262.74 | test_vm_life_cycle.py test_deploy_vm | Success | 0.03 | test_vm_life_cycle.py test_advZoneVirtualRouter | Success | 0.02 | test_vm_life_cycle.py test_10_attachAndDetach_iso | Success | 26.62 | test_vm_life_cycle.py test_09_expunge_vm | Success | 125.25 | test_vm_life_cycle.py test_08_migrate_vm | Success | 36.05 | test_vm_life_cycle.py test_07_restore_vm | Success | 0.14 | test_vm_life_cycle.py test_06_destroy_vm | Success | 125.82 | test_vm_life_cycle.py test_03_reboot_vm | Success | 125.86 | test_vm_life_cycle.py test_02_start_vm | Success | 10.18 | test_vm_life_cycle.py test_01_stop_vm | Success | 35.30 | test_vm_life_cycle.py test_CreateTemplateWithDuplicateName | Success | 40.47 | test_templates.py test_08_list_system_templates | Success | 0.03 | test_templates.py test_07_list_public_templates | Success | 0.04 | test_templates.py test_05_template_permissions | Success | 0.06 | test_templates.py test_04_extract_template | Success | 5.13 | test_templates.py test_03_delete_template | Success | 5.10 | test_templates.py test_02_edit_template | Success | 90.13 | test_templates.py test_01_create_template | Success | 40.52 | test_templates.py test_10_destroy_cpvm | Success | 161.42 | test_ssvm.py test_09_destroy_ssvm | Success | 163.61 | test_ssvm.py test_08_reboot_cpvm | Success | 101.56 | test_ssvm.py test_07_reboot_ssvm | Success | 103.46 | test_ssvm.py test_06_stop_cpvm | Success | 101.64 | test_ssvm.py test_05_stop_ssvm | Success | 138.80 | test_ssvm.py test_04_cpvm_internals | Success | 1.18 | test_ssvm.py test_03_ssvm_internals | Success | 3.29 | test_ssvm.py test_02_list_cpvm_vm | Success | 0.13 | test_ssvm.py test_01_list_sec_storage_vm | Success | 0.13 | test_ssvm.py test_01_snapshot_root_disk | Success | 11.27 | test_snapshots.py test_04_change_offering_small | Success | 210.02 | test_service_offerings.py test_03_delete_service_offering | Success | 0.04 | test_service_offerings.py test_02_edit_service_offering | Success | 0.05 | test_service_offerings.py test_01_create_service_offering | Success | 0.10 | test_service_offerings.py test_02_sys_template_ready | Success | 0.12 | test_secondary_storage.py test_01_sys_vm_start | Success | 0.18 | test_secondary_storage.py test_09_reboot_router | Success | 35.30 | test_routers.py test_08_start_router | Success | 25.25 | test_routers.py test_07_stop_router | Success | 10.18 | test_routers.py
[GitHub] cloudstack issue #1935: CLOUDSTACK-9764: Delete domain failure due to Accoun...
Github user blueorangutan commented on the issue: https://github.com/apache/cloudstack/pull/1935 @borisstoyanov a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1935: CLOUDSTACK-9764: Delete domain failure due to Accoun...
Github user borisstoyanov commented on the issue: https://github.com/apache/cloudstack/pull/1935 @blueorangutan test --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1935: CLOUDSTACK-9764: Delete domain failure due to Accoun...
Github user blueorangutan commented on the issue: https://github.com/apache/cloudstack/pull/1935 Packaging result: âcentos6 âcentos7 âdebian. JID-478 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1935: CLOUDSTACK-9764: Delete domain failure due to Accoun...
Github user blueorangutan commented on the issue: https://github.com/apache/cloudstack/pull/1935 @borisstoyanov a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1935: CLOUDSTACK-9764: Delete domain failure due to Accoun...
Github user borisstoyanov commented on the issue: https://github.com/apache/cloudstack/pull/1935 @blueorangutan package --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
