[GitHub] cloudstack issue #1956: CLOUDSTACK-9796 - Fix NPE in VirtualMachineManagerIm...
Github user GabrielBrascher commented on the issue: https://github.com/apache/cloudstack/pull/1956 Got it @borisstoyanov. Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1956: CLOUDSTACK-9796 - Fix NPE in VirtualMachineManagerIm...
Github user borisstoyanov commented on the issue: https://github.com/apache/cloudstack/pull/1956 @GabrielBrascher privategw_acl and vpc_redundant test failures have been a pain for a while, couldn't managed to fix those tests. If someone spend time and fix them would be really good. While the test_snapshot is already fixed, in fact we just merged the fix in Trillian as well and next run would pass. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1956: CLOUDSTACK-9796 - Fix NPE in VirtualMachineManagerIm...
Github user GabrielBrascher commented on the issue: https://github.com/apache/cloudstack/pull/1956 Great, this one looks ready to merge. Just for caution. Are those failures false positives? ``` test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL Failure 368.96 test_vpc_redundant.py test_04_rvpc_privategw_static_routesFailure 315.79 test_privategw_acl.py test_02_list_snapshots_with_removed_data_store Error 0.04 test_snapshots.py ``` --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1956: CLOUDSTACK-9796 - Fix NPE in VirtualMachineManagerIm...
Github user blueorangutan commented on the issue: https://github.com/apache/cloudstack/pull/1956 Trillian test result (tid-936) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 32211 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr1956-t936-kvm-centos7.zip Intermitten failure detected: /marvin/tests/smoke/test_privategw_acl.py Intermitten failure detected: /marvin/tests/smoke/test_snapshots.py Intermitten failure detected: /marvin/tests/smoke/test_vpc_redundant.py Test completed. 45 look ok, 3 have error(s) Test | Result | Time (s) | Test File --- | --- | --- | --- test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL | `Failure` | 368.96 | test_vpc_redundant.py test_04_rvpc_privategw_static_routes | `Failure` | 315.79 | test_privategw_acl.py test_02_list_snapshots_with_removed_data_store | `Error` | 0.04 | test_snapshots.py test_01_vpc_site2site_vpn | Success | 160.02 | test_vpc_vpn.py test_01_vpc_remote_access_vpn | Success | 71.29 | test_vpc_vpn.py test_01_redundant_vpc_site2site_vpn | Success | 245.60 | test_vpc_vpn.py test_02_VPC_default_routes | Success | 270.06 | test_vpc_router_nics.py test_01_VPC_nics_after_destroy | Success | 533.80 | test_vpc_router_nics.py test_05_rvpc_multi_tiers | Success | 513.29 | test_vpc_redundant.py test_04_rvpc_network_garbage_collector_nics | Success | 1400.07 | test_vpc_redundant.py test_03_create_redundant_VPC_1tier_2VMs_2IPs_2PF_ACL_reboot_routers | Success | 548.99 | test_vpc_redundant.py test_02_redundant_VPC_default_routes | Success | 762.46 | test_vpc_redundant.py test_09_delete_detached_volume | Success | 156.53 | test_volumes.py test_08_resize_volume | Success | 156.59 | test_volumes.py test_07_resize_fail | Success | 161.50 | test_volumes.py test_06_download_detached_volume | Success | 156.55 | test_volumes.py test_05_detach_volume | Success | 150.77 | test_volumes.py test_04_delete_attached_volume | Success | 151.25 | test_volumes.py test_03_download_attached_volume | Success | 151.34 | test_volumes.py test_02_attach_volume | Success | 124.22 | test_volumes.py test_01_create_volume | Success | 711.43 | test_volumes.py test_deploy_vm_multiple | Success | 252.67 | test_vm_life_cycle.py test_deploy_vm | Success | 0.03 | test_vm_life_cycle.py test_advZoneVirtualRouter | Success | 0.02 | test_vm_life_cycle.py test_10_attachAndDetach_iso | Success | 26.67 | test_vm_life_cycle.py test_09_expunge_vm | Success | 125.25 | test_vm_life_cycle.py test_08_migrate_vm | Success | 40.97 | test_vm_life_cycle.py test_07_restore_vm | Success | 0.13 | test_vm_life_cycle.py test_06_destroy_vm | Success | 125.94 | test_vm_life_cycle.py test_03_reboot_vm | Success | 125.87 | test_vm_life_cycle.py test_02_start_vm | Success | 10.18 | test_vm_life_cycle.py test_01_stop_vm | Success | 40.34 | test_vm_life_cycle.py test_CreateTemplateWithDuplicateName | Success | 35.45 | test_templates.py test_08_list_system_templates | Success | 0.03 | test_templates.py test_07_list_public_templates | Success | 0.04 | test_templates.py test_05_template_permissions | Success | 0.06 | test_templates.py test_04_extract_template | Success | 5.16 | test_templates.py test_03_delete_template | Success | 5.11 | test_templates.py test_02_edit_template | Success | 90.13 | test_templates.py test_01_create_template | Success | 35.40 | test_templates.py test_10_destroy_cpvm | Success | 161.70 | test_ssvm.py test_09_destroy_ssvm | Success | 163.80 | test_ssvm.py test_08_reboot_cpvm | Success | 101.56 | test_ssvm.py test_07_reboot_ssvm | Success | 103.64 | test_ssvm.py test_06_stop_cpvm | Success | 161.80 | test_ssvm.py test_05_stop_ssvm | Success | 193.85 | test_ssvm.py test_04_cpvm_internals | Success | 1.20 | test_ssvm.py test_03_ssvm_internals | Success | 3.23 | test_ssvm.py test_02_list_cpvm_vm | Success | 0.13 | test_ssvm.py test_01_list_sec_storage_vm | Success | 0.16 | test_ssvm.py test_01_snapshot_root_disk | Success | 11.11 | test_snapshots.py test_04_change_offering_small | Success | 239.64 | test_service_offerings.py test_03_delete_service_offering | Success | 0.04 | test_service_offerings.py test_02_edit_service_offering | Success | 0.06 | test_service_offerings.py test_01_create_service_offering | Success | 0.11 | test_service_offerings.py test_02_sys_template_ready | Success | 0.13 | test_secondary_storage.py test_01_sys_vm_start | Success | 0.20 | test_secondary_storage.py test_09_reboot_router | Success | 35.32 | test_routers.py test_08_start_router | Success | 30.30 | test_routers.py test_07_stop_router | Success | 10.18 | test_routers.py test_06_router_advanced | Success | 0.06 | test_routers.py
[GitHub] cloudstack issue #1956: CLOUDSTACK-9796 - Fix NPE in VirtualMachineManagerIm...
Github user blueorangutan commented on the issue: https://github.com/apache/cloudstack/pull/1956 @borisstoyanov a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1956: CLOUDSTACK-9796 - Fix NPE in VirtualMachineManagerIm...
Github user borisstoyanov commented on the issue: https://github.com/apache/cloudstack/pull/1956 @blueorangutan test --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1956: CLOUDSTACK-9796 - Fix NPE in VirtualMachineManagerIm...
Github user blueorangutan commented on the issue: https://github.com/apache/cloudstack/pull/1956 Packaging result: âcentos6 âcentos7 âdebian. JID-572 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1956: CLOUDSTACK-9796 - Fix NPE in VirtualMachineManagerIm...
Github user blueorangutan commented on the issue: https://github.com/apache/cloudstack/pull/1956 @borisstoyanov a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1956: CLOUDSTACK-9796 - Fix NPE in VirtualMachineManagerIm...
Github user borisstoyanov commented on the issue: https://github.com/apache/cloudstack/pull/1956 @blueorangutan package --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1956: CLOUDSTACK-9796 - Fix NPE in VirtualMachineManagerIm...
Github user blueorangutan commented on the issue: https://github.com/apache/cloudstack/pull/1956 Packaging result: âcentos6 âcentos7 âdebian. JID-571 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1956: CLOUDSTACK-9796 - Fix NPE in VirtualMachineManagerIm...
Github user blueorangutan commented on the issue: https://github.com/apache/cloudstack/pull/1956 @borisstoyanov a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1956: CLOUDSTACK-9796 - Fix NPE in VirtualMachineManagerIm...
Github user borisstoyanov commented on the issue: https://github.com/apache/cloudstack/pull/1956 @nathanejohnson thanks for this bug fix @blueorangutan package --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1956: CLOUDSTACK-9796 - Fix NPE in VirtualMachineManagerIm...
Github user kiwiflyer commented on the issue: https://github.com/apache/cloudstack/pull/1956 LGTM by Rafael in commit review above (for acspr). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1956: CLOUDSTACK-9796 - Fix NPE in VirtualMachineManagerIm...
Github user GabrielBrascher commented on the issue: https://github.com/apache/cloudstack/pull/1956 Thanks for the code that prevents NULL pointer exception. Based on code revirew and that all checks have passed LGTM. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
