[GitHub] cloudstack issue #2023: BUG-ID: CLOUDSTACK-9808 Added system Vm upgrade path...

2017-04-06 Thread wido
Github user wido commented on the issue:

https://github.com/apache/cloudstack/pull/2023
  
LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #2023: BUG-ID: CLOUDSTACK-9808 Added system Vm upgrade path...

2017-04-03 Thread rhtyd
Github user rhtyd commented on the issue:

https://github.com/apache/cloudstack/pull/2023
  
LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #2023: BUG-ID: CLOUDSTACK-9808 Added system Vm upgrade path...

2017-03-30 Thread DaanHoogland
Github user DaanHoogland commented on the issue:

https://github.com/apache/cloudstack/pull/2023
  
@karuturi I think it is easiest to just reapply and not search for the 
cause of an 8 month old PR resulting in conflicts. (if the original code has 
the right URLS in it)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #2023: BUG-ID: CLOUDSTACK-9808 Added system Vm upgrade path...

2017-03-30 Thread karuturi
Github user karuturi commented on the issue:

https://github.com/apache/cloudstack/pull/2023
  
code LGTM. Need to check why xenserver and KVM still have wrong urls on PR 
https://github.com/apache/cloudstack/pull/1582#issuecomment-288310796 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #2023: BUG-ID: CLOUDSTACK-9808 Added system Vm upgrade path...

2017-03-30 Thread DaanHoogland
Github user DaanHoogland commented on the issue:

https://github.com/apache/cloudstack/pull/2023
  
LGTM
@kishankavala did you check what went wrong with the kvm template. 
@karuturi reported that and it was probably some auto-conflict-resolution.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---