[GitHub] cloudstack pull request: Allow custom command role ACL files on cl...
Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/354 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: Allow custom command role ACL files on cl...
Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/354#issuecomment-113102919 @ProjectMoon can you rebase and re-submit the PR, the travis tests seems to be failing. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: Allow custom command role ACL files on cl...
Github user ProjectMoon commented on the pull request: https://github.com/apache/cloudstack/pull/354#issuecomment-113106273 Pull request branch has been updated. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: Allow custom command role ACL files on cl...
Github user ProjectMoon commented on the pull request: https://github.com/apache/cloudstack/pull/354#issuecomment-111475122 This would be a step-by-step way of how I tested the change. We will use mycommands.properties as the example. 1. Add the new properties file name to the list in the Spring XML and then compile CloudStack. 2. Create mycommands.properties.in in client/tomcatconf. Build should move this to WEB-INF/classes after compilation as mycommands.properties. 3. Move some commands from commands.properties.in to mycommands.properties.in 4. Build and run client with Jetty server. 5. Use cloudmonkey sync command to verify it's reading all 479 commands in from both files. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: Allow custom command role ACL files on cl...
Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/354#issuecomment-111468655 @ProjectMoon can you share any test results? Is the spring xml gets into the compiled jar from users' perspective, how may I configure a different properties file, any docs in this regard? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: Allow custom command role ACL files on cl...
Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/354#issuecomment-111481710 @ProjectMoon my concern here is -- you're still making changes in the XML to make it work during build time, is there a way to make it configurable like rabbitmq plugin so one can add the xml at some place in /etc/cloudstack/management to change/add file names in the XML. (pardon my ignorance, I'm not well versed with spring) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: Allow custom command role ACL files on cl...
Github user ProjectMoon commented on the pull request: https://github.com/apache/cloudstack/pull/354#issuecomment-109915316 Is there anything I can do to assist with the testing? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: Allow custom command role ACL files on cl...
Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/354#issuecomment-108627999 LGTM, though we need to test it by producing packages. In theory, the /etc/cloudstack/management should be on classpath so this should work. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: Allow custom command role ACL files on cl...
GitHub user ProjectMoon opened a pull request: https://github.com/apache/cloudstack/pull/354 Allow custom command role ACL files on classpath in Static Role API Checker ## Commit Message This commit has a small refactoring of cloud-plugin-acl-static-role-based to allow it to read files on the classpath that might have a different name than commands.properties. It also allows more than one file to be read from. Rationale: Third-party plugins may want to keep their API command access level configuration separate from the main file so as to reduce configuration maintenance work during packaging and deployments. ## Testing Performed Ran the simulator locally and connected to it with Cloudmonkey. Ran sync and then executed some API commands to verify that they are not blacklisted (i.e. not found because CS could not read the file on the classpath). You can merge this pull request into a Git repository by running: $ git pull https://github.com/greenqloud/cloudstack master-gq Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cloudstack/pull/354.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #354 commit a97bfbbb35772f0f94afb4563a01a6adfc404ac0 Author: jeff j...@greenqloud.com Date: 2015-06-03T17:15:57Z Allow custom command role ACL files on classpath in Static Role API Checker. This commit has a small refactoring of cloud-plugin-acl-static-role-based to allow it to read files on the classpath that might have a different name than commands.properties. It also allows more than one file to be read from. Rationale: Third-party plugins may want to keep their API command access level configuration separate from the main file so as to reduce configuration maintenance work during packaging and deployments. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
