[GitHub] cloudstack pull request: CLOUDSTACK-8577: fixing script testpath_d...
Github user wilderrodrigues commented on the pull request: https://github.com/apache/cloudstack/pull/507#issuecomment-119082107 @DaanHoogland @runseb @bhaisaab @remibergsma Does the LGTM idea also apply to integration tests? Cheers, Wilder --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-8577: fixing script testpath_d...
GitHub user nitt10prashant reopened a pull request: https://github.com/apache/cloudstack/pull/507 CLOUDSTACK-8577: fixing script testpath_disable_enable_zone disable enable cluster ... === TestName: test_01_disable_enable_cluster | Status : SUCCESS === ok disable enable host ... === TestName: test_01_disable_enable_host | Status : SUCCESS === ok disable enable Pod ... === TestName: test_01_disable_enable_pod | Status : SUCCESS === ok disable enable zone ... === TestName: test_01_disable_enable_zone | Status : SUCCESS === ok -- Ran 4 tests in 2818.119s OK You can merge this pull request into a Git repository by running: $ git pull https://github.com/nitt10prashant/cloudstack enable_zone Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cloudstack/pull/507.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #507 commit 4554ae7eb793ad1a519e5b96d938f380218a18fa Author: nitt10prashant nitt10.prash...@gmail.com Date: 2015-06-22T12:55:39Z CLOUDSTACK-8577: fixing script testpath_disable_enable_zone commit 10afc3bba339084d10abafa16ec7dccaacfb81c5 Author: nitt10prashant nitt10.prash...@gmail.com Date: 2015-06-22T13:05:40Z CLOUDSTACK-8577: fixing script testpath_disable_enable_zone --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-8577: fixing script testpath_d...
Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/507#issuecomment-119082514 I have let Gaurav take care of things before because he was the only one actually looking. I don't think we can afford to demand 2 LTGM on integration tests. I would like to. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-8577: fixing script testpath_d...
Github user wilderrodrigues commented on the pull request: https://github.com/apache/cloudstack/pull/507#issuecomment-119082808 Fair enough. I'm just asking because it should be made clear on the list. It's already difficult to get 2 LGTM on the Java stuff, not many people looking into things. There are also a lot of PRs standing due to lack of information from the committer. How should we address that? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-8577: fixing script testpath_d...
Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/507#issuecomment-119083411 first let us not limmit the LTGM to commiters in the case of integration tests. As for information, we will have to ask for it. Finally I want for us to have a mech to refuse/close PRs as community. We can't at the moment. I don't even know who can. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-8577: fixing script testpath_d...
Github user nitt10prashant closed the pull request at: https://github.com/apache/cloudstack/pull/507 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-8577: fixing script testpath_d...
Github user nitt10prashant closed the pull request at: https://github.com/apache/cloudstack/pull/507 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
Re: [GitHub] cloudstack pull request: CLOUDSTACK-8577: fixing script testpath_d...
LGTM. I am taking this patch. On Mon, Jun 22, 2015 at 6:26 PM, nitt10prashant g...@git.apache.org wrote: GitHub user nitt10prashant opened a pull request: https://github.com/apache/cloudstack/pull/507 CLOUDSTACK-8577: fixing script testpath_disable_enable_zone disable enable cluster ... === TestName: test_01_disable_enable_cluster | Status : SUCCESS === ok disable enable host ... === TestName: test_01_disable_enable_host | Status : SUCCESS === ok disable enable Pod ... === TestName: test_01_disable_enable_pod | Status : SUCCESS === ok disable enable zone ... === TestName: test_01_disable_enable_zone | Status : SUCCESS === ok -- Ran 4 tests in 2818.119s OK You can merge this pull request into a Git repository by running: $ git pull https://github.com/nitt10prashant/cloudstack enable_zone Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cloudstack/pull/507.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #507 commit 4554ae7eb793ad1a519e5b96d938f380218a18fa Author: nitt10prashant nitt10.prash...@gmail.com Date: 2015-06-22T12:55:39Z CLOUDSTACK-8577: fixing script testpath_disable_enable_zone --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-8577: fixing script testpath_d...
GitHub user nitt10prashant opened a pull request: https://github.com/apache/cloudstack/pull/507 CLOUDSTACK-8577: fixing script testpath_disable_enable_zone disable enable cluster ... === TestName: test_01_disable_enable_cluster | Status : SUCCESS === ok disable enable host ... === TestName: test_01_disable_enable_host | Status : SUCCESS === ok disable enable Pod ... === TestName: test_01_disable_enable_pod | Status : SUCCESS === ok disable enable zone ... === TestName: test_01_disable_enable_zone | Status : SUCCESS === ok -- Ran 4 tests in 2818.119s OK You can merge this pull request into a Git repository by running: $ git pull https://github.com/nitt10prashant/cloudstack enable_zone Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cloudstack/pull/507.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #507 commit 4554ae7eb793ad1a519e5b96d938f380218a18fa Author: nitt10prashant nitt10.prash...@gmail.com Date: 2015-06-22T12:55:39Z CLOUDSTACK-8577: fixing script testpath_disable_enable_zone --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
