[GitHub] cloudstack pull request: CLOUDSTACK-8620 :skip test cases if rbd s...
Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/570 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-8620 :skip test cases if rbd s...
Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/570#issuecomment-120408068 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-8620 :skip test cases if rbd s...
Github user wilderrodrigues commented on the pull request: https://github.com/apache/cloudstack/pull/570#issuecomment-119920451 LGTM :+1: But, please, next time do it in 2 separate commits: 1 commit with file formatting 1 commit with the actual change It was a bit hard to see your changes in the middle of all formatting. Cheers, Wilder --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-8620 :skip test cases if rbd s...
GitHub user nitt10prashant opened a pull request: https://github.com/apache/cloudstack/pull/570 CLOUDSTACK-8620 :skip test cases if rbd storage is not available in l⦠skipping tests based on storage for lxc hype and fixing pep8 issues test result = Test increasing volume size within the account limit and verify primary storage usage ... SKIP: unsupported storage type Test increasing volume size above the account limit ... SKIP: unsupported storage type Test increasing volume size above the domain limit ... SKIP: unsupported storage type -- Ran 3 tests in 2.236s OK (SKIP=3) You can merge this pull request into a Git repository by running: $ git pull https://github.com/nitt10prashant/cloudstack lxc Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cloudstack/pull/570.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #570 commit 7486f6fcb247a35ab7f139713796dc6647f80c09 Author: nitt10prashant nitt10.prash...@gmail.com Date: 2015-07-09T09:09:51Z CLOUDSTACK-8620 :skip test cases if rbd storage is not available in lxc setup --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-8620 :skip test cases if rbd s...
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/570#discussion_r34249648
--- Diff: test/integration/component/test_ps_resize_volume.py ---
@@ -48,59 +51,69 @@
RESOURCE_SECONDARY_STORAGE,
XEN_SERVER)
+
class TestResizeVolume(cloudstackTestCase):
@classmethod
def setUpClass(cls):
cloudstackTestClient = super(TestResizeVolume,
- cls).getClsTestClient()
+ cls).getClsTestClient()
cls.api_client = cloudstackTestClient.getApiClient()
+cls.hypervisor = cloudstackTestClient.getHypervisorInfo()
# Fill services from the external config file
cls.services = cloudstackTestClient.getParsedTestDataConfig()
# Get Zone, Domain and templates
cls.domain = get_domain(cls.api_client)
-cls.zone = get_zone(cls.api_client,
cloudstackTestClient.getZoneForTests())
+cls.zone = get_zone(
+cls.api_client,
+cloudstackTestClient.getZoneForTests())
cls.services[mode] = cls.zone.networktype
+cls._cleanup = []
+cls.unsupportedStorageType = False
+if cls.hypervisor.lower() == 'lxc':
+if not find_storage_pool_type(cls.api_client,
storagetype='rbd'):
+cls.unsupportedStorageType = True
+return
cls.resourcetypemapping = {RESOURCE_PRIMARY_STORAGE: 10,
RESOURCE_SECONDARY_STORAGE: 11}
-
-
cls.template = get_template(
-cls.api_client,
-cls.zone.id,
-cls.services[ostype]
-)
+cls.api_client,
+cls.zone.id,
+cls.services[ostype]
+)
cls.services[virtual_machine][zoneid] = cls.zone.id
cls.services[virtual_machine][template] = cls.template.id
cls.services[volume][zoneid] = cls.zone.id
-cls._cleanup = []
try:
cls.hypervisor =
str(get_hypervisor_type(cls.api_client)).lower()
# Creating service offering with normal config
cls.service_offering = ServiceOffering.create(cls.api_client,
-
cls.services[service_offering])
+ cls.services[\
--- End diff --
this looks strange. are you sure you want to break the line within a
string-literal?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-8620 :skip test cases if rbd s...
Github user wilderrodrigues commented on the pull request: https://github.com/apache/cloudstack/pull/570#issuecomment-119930090 @DaanHoogland @bhaisaab @karuturi Could you please have a look at this one as well? :) Thanks in advance. Cheers, Wilder --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
