[GitHub] cloudstack pull request: CLOUDSTACK-8716: Verify creation of snaps...

2015-08-26 Thread bhaisaab
Github user bhaisaab commented on the pull request:

https://github.com/apache/cloudstack/pull/665#issuecomment-134920085
  
LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request: CLOUDSTACK-8716: Verify creation of snaps...

2015-08-26 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/cloudstack/pull/665


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request: CLOUDSTACK-8716: Verify creation of snaps...

2015-08-19 Thread nitt10prashant
Github user nitt10prashant commented on the pull request:

https://github.com/apache/cloudstack/pull/665#issuecomment-132583048
  
LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request: CLOUDSTACK-8716: Verify creation of snaps...

2015-08-19 Thread remibergsma
Github user remibergsma commented on the pull request:

https://github.com/apache/cloudstack/pull/665#issuecomment-132573747
  
@nitt10prashant Can you please review this PR again?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request: CLOUDSTACK-8716: Verify creation of snaps...

2015-08-14 Thread remibergsma
Github user remibergsma commented on the pull request:

https://github.com/apache/cloudstack/pull/665#issuecomment-131213094
  
@pritisarap12 Please squash the commits, they have the same titles which is 
confusing. If you need multiple commits, make sure they have a descriptive 
first line. Thanks!



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request: CLOUDSTACK-8716: Verify creation of snaps...

2015-08-11 Thread nitt10prashant
Github user nitt10prashant commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/665#discussion_r36735392
  
--- Diff: test/integration/testpaths/testpath_multiple_snapshot.py ---
@@ -0,0 +1,279 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# License); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#   http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# AS IS BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+ Test case for Multiple Volume Snapshot in ZWPS
+
+from nose.plugins.attrib import attr
+from marvin.cloudstackTestCase import cloudstackTestCase
+from marvin.lib.utils import (cleanup_resources,
+  validateList)
+from marvin.lib.base import (Account,
+ ServiceOffering,
+ DiskOffering,
+ Snapshot,
+ VirtualMachine,
+ StoragePool
+ )
+from marvin.lib.common import (get_domain,
+   get_zone,
+   list_volumes,
+   list_clusters,
+   get_template
+   )
+
+from marvin.codes import PASS, ZONETAG1, ROOT, DATA
+
+
+class TestMultipleVolumeSnapshots(cloudstackTestCase):
+
+@classmethod
+def setUpClass(cls):
+testClient = super(TestMultipleVolumeSnapshots, 
cls).getClsTestClient()
+cls.apiclient = testClient.getApiClient()
+cls.testdata = testClient.getParsedTestDataConfig()
+
+# Get Zone, Domain and templates
+cls.domain = get_domain(cls.apiclient)
+cls.zone = get_zone(cls.apiclient, testClient.getZoneForTests())
+cls.hypervisor = cls.testClient.getHypervisorInfo()
+cls.template = get_template(
+cls.apiclient,
+cls.zone.id,
+cls.testdata[ostype])
+
+cls._cleanup = []
+
+cls.skiptest = False
+
+clus_list = list_clusters(cls.apiclient)
+
+if cls.hypervisor.lower() not in ['vmware'] or len(clus_list)  2:
+cls.skiptest = True
+return
+
+try:
+# Create an account
+cls.account = Account.create(
+cls.apiclient,
+cls.testdata[account],
+domainid=cls.domain.id
+)
+
+# Create user api client of the account
+cls.userapiclient = testClient.getUserApiClient(
+UserName=cls.account.name,
+DomainName=cls.account.domain
+)
+# Create Service offering
+cls.service_offering_zwps = ServiceOffering.create(
+cls.apiclient,
+cls.testdata[service_offering],
+tags=ZONETAG1
+)
+
+cls.disk_offering_zwps = DiskOffering.create(
+cls.apiclient,
+cls.testdata[disk_offering],
+tags=ZONETAG1
+)
+
+cls._cleanup = [
+cls.account,
+cls.service_offering_zwps,
+cls.disk_offering_zwps,
+]
+except Exception as e:
+cls.tearDownClass()
+raise e
+return
+
+@classmethod
+def tearDownClass(cls):
+try:
+cleanup_resources(cls.apiclient, cls._cleanup)
+except Exception as e:
+raise Exception(Warning: Exception during cleanup : %s % e)
+
+def setUp(self):
+
+self.cleanup = []
+if self.skiptest:
+self.skipTest(Skip test as setup is either not VMWare or  \
+having less than 2 clusters %s % self.hypervisor)
+
+self.apiclient = self.testClient.getApiClient()
+self.dbclient = self.testClient.getDbConnection()
+self.pools = []
+
+def 

[GitHub] cloudstack pull request: CLOUDSTACK-8716: Verify creation of snaps...

2015-08-11 Thread nitt10prashant
Github user nitt10prashant commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/665#discussion_r36734361
  
--- Diff: test/integration/testpaths/testpath_multiple_snapshot.py ---
@@ -0,0 +1,279 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# License); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#   http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# AS IS BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+ Test case for Multiple Volume Snapshot in ZWPS
+
+from nose.plugins.attrib import attr
+from marvin.cloudstackTestCase import cloudstackTestCase
+from marvin.lib.utils import (cleanup_resources,
+  validateList)
+from marvin.lib.base import (Account,
+ ServiceOffering,
+ DiskOffering,
+ Snapshot,
+ VirtualMachine,
+ StoragePool
+ )
+from marvin.lib.common import (get_domain,
+   get_zone,
+   list_volumes,
+   list_clusters,
+   get_template
+   )
+
+from marvin.codes import PASS, ZONETAG1, ROOT, DATA
+
+
+class TestMultipleVolumeSnapshots(cloudstackTestCase):
+
+@classmethod
+def setUpClass(cls):
+testClient = super(TestMultipleVolumeSnapshots, 
cls).getClsTestClient()
+cls.apiclient = testClient.getApiClient()
+cls.testdata = testClient.getParsedTestDataConfig()
+
+# Get Zone, Domain and templates
+cls.domain = get_domain(cls.apiclient)
+cls.zone = get_zone(cls.apiclient, testClient.getZoneForTests())
+cls.hypervisor = cls.testClient.getHypervisorInfo()
+cls.template = get_template(
+cls.apiclient,
+cls.zone.id,
+cls.testdata[ostype])
+
+cls._cleanup = []
+
+cls.skiptest = False
+
+clus_list = list_clusters(cls.apiclient)
+
+if cls.hypervisor.lower() not in ['vmware'] or len(clus_list)  2:
+cls.skiptest = True
+return
+
+try:
+# Create an account
+cls.account = Account.create(
+cls.apiclient,
+cls.testdata[account],
+domainid=cls.domain.id
+)
+
+# Create user api client of the account
+cls.userapiclient = testClient.getUserApiClient(
+UserName=cls.account.name,
+DomainName=cls.account.domain
+)
+# Create Service offering
+cls.service_offering_zwps = ServiceOffering.create(
+cls.apiclient,
+cls.testdata[service_offering],
+tags=ZONETAG1
+)
+
+cls.disk_offering_zwps = DiskOffering.create(
+cls.apiclient,
+cls.testdata[disk_offering],
+tags=ZONETAG1
+)
+
+cls._cleanup = [
+cls.account,
+cls.service_offering_zwps,
+cls.disk_offering_zwps,
+]
+except Exception as e:
+cls.tearDownClass()
+raise e
+return
+
+@classmethod
+def tearDownClass(cls):
+try:
+cleanup_resources(cls.apiclient, cls._cleanup)
+except Exception as e:
+raise Exception(Warning: Exception during cleanup : %s % e)
+
+def setUp(self):
+
+self.cleanup = []
+if self.skiptest:
+self.skipTest(Skip test as setup is either not VMWare or  \
+having less than 2 clusters %s % self.hypervisor)
+
+self.apiclient = self.testClient.getApiClient()
+self.dbclient = self.testClient.getDbConnection()
+self.pools = []
+
+def 

[GitHub] cloudstack pull request: CLOUDSTACK-8716: Verify creation of snaps...

2015-08-11 Thread nitt10prashant
Github user nitt10prashant commented on the pull request:

https://github.com/apache/cloudstack/pull/665#issuecomment-129846827
  
can you update test results ?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request: CLOUDSTACK-8716: Verify creation of snaps...

2015-08-11 Thread nitt10prashant
Github user nitt10prashant commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/665#discussion_r36734207
  
--- Diff: test/integration/testpaths/testpath_multiple_snapshot.py ---
@@ -0,0 +1,279 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# License); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#   http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# AS IS BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+ Test case for Multiple Volume Snapshot in ZWPS
+
+from nose.plugins.attrib import attr
+from marvin.cloudstackTestCase import cloudstackTestCase
+from marvin.lib.utils import (cleanup_resources,
+  validateList)
+from marvin.lib.base import (Account,
+ ServiceOffering,
+ DiskOffering,
+ Snapshot,
+ VirtualMachine,
+ StoragePool
+ )
+from marvin.lib.common import (get_domain,
+   get_zone,
+   list_volumes,
+   list_clusters,
+   get_template
+   )
+
+from marvin.codes import PASS, ZONETAG1, ROOT, DATA
+
+
+class TestMultipleVolumeSnapshots(cloudstackTestCase):
+
+@classmethod
+def setUpClass(cls):
+testClient = super(TestMultipleVolumeSnapshots, 
cls).getClsTestClient()
+cls.apiclient = testClient.getApiClient()
+cls.testdata = testClient.getParsedTestDataConfig()
+
+# Get Zone, Domain and templates
+cls.domain = get_domain(cls.apiclient)
+cls.zone = get_zone(cls.apiclient, testClient.getZoneForTests())
+cls.hypervisor = cls.testClient.getHypervisorInfo()
+cls.template = get_template(
+cls.apiclient,
+cls.zone.id,
+cls.testdata[ostype])
+
+cls._cleanup = []
+
+cls.skiptest = False
+
+clus_list = list_clusters(cls.apiclient)
+
+if cls.hypervisor.lower() not in ['vmware'] or len(clus_list)  2:
+cls.skiptest = True
+return
+
+try:
+# Create an account
+cls.account = Account.create(
+cls.apiclient,
+cls.testdata[account],
+domainid=cls.domain.id
+)
+
+# Create user api client of the account
+cls.userapiclient = testClient.getUserApiClient(
+UserName=cls.account.name,
+DomainName=cls.account.domain
+)
+# Create Service offering
+cls.service_offering_zwps = ServiceOffering.create(
+cls.apiclient,
+cls.testdata[service_offering],
+tags=ZONETAG1
+)
+
+cls.disk_offering_zwps = DiskOffering.create(
+cls.apiclient,
+cls.testdata[disk_offering],
+tags=ZONETAG1
+)
+
+cls._cleanup = [
+cls.account,
+cls.service_offering_zwps,
+cls.disk_offering_zwps,
+]
+except Exception as e:
+cls.tearDownClass()
+raise e
+return
+
+@classmethod
+def tearDownClass(cls):
+try:
+cleanup_resources(cls.apiclient, cls._cleanup)
+except Exception as e:
+raise Exception(Warning: Exception during cleanup : %s % e)
+
+def setUp(self):
+
+self.cleanup = []
+if self.skiptest:
+self.skipTest(Skip test as setup is either not VMWare or  \
+having less than 2 clusters %s % self.hypervisor)
+
+self.apiclient = self.testClient.getApiClient()
+self.dbclient = self.testClient.getDbConnection()
+self.pools = []
+
+def 

[GitHub] cloudstack pull request: CLOUDSTACK-8716: Verify creation of snaps...

2015-08-09 Thread sanju1010
Github user sanju1010 commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/665#discussion_r36601402
  
--- Diff: test/integration/testpaths/testpath_multiple_snapshot.py ---
@@ -0,0 +1,255 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# License); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#   http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# AS IS BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+ Test case for Multiple Volume Snapshot in ZWPS
+
+from nose.plugins.attrib import attr
+from marvin.cloudstackTestCase import cloudstackTestCase
+from marvin.lib.utils import (cleanup_resources,
+  validateList)
+from marvin.lib.base import (Account,
+ ServiceOffering,
+ DiskOffering,
+ Snapshot,
+ VirtualMachine,
+ StoragePool
+ )
+from marvin.lib.common import (get_domain,
+   get_zone,
+   list_volumes,
+   list_clusters,
+   get_template
+   )
+
+from marvin.codes import PASS, ZONETAG1, ROOT, DATA
+
+
+class TestMultipleVolumeSnapshots(cloudstackTestCase):
+
+@classmethod
+def setUpClass(cls):
+testClient = super(TestMultipleVolumeSnapshots, 
cls).getClsTestClient()
+cls.apiclient = testClient.getApiClient()
+cls.testdata = testClient.getParsedTestDataConfig()
+
+# Get Zone, Domain and templates
+cls.domain = get_domain(cls.apiclient)
+cls.zone = get_zone(cls.apiclient, testClient.getZoneForTests())
+cls.hypervisor = cls.testClient.getHypervisorInfo()
+cls.template = get_template(
+cls.apiclient,
+cls.zone.id,
+cls.testdata[ostype])
+
+cls._cleanup = []
+
+cls.skiptest = False
+
+clus_list = list_clusters(cls.apiclient)
+
+if cls.hypervisor.lower() not in ['vmware'] or len(clus_list)  2:
+cls.skiptest = True
+return
+
+try:
+# Create an account
+cls.account = Account.create(
+cls.apiclient,
+cls.testdata[account],
+domainid=cls.domain.id
+)
+
+# Create user api client of the account
+cls.userapiclient = testClient.getUserApiClient(
+UserName=cls.account.name,
+DomainName=cls.account.domain
+)
+# Create Service offering
+cls.service_offering_zwps = ServiceOffering.create(
+cls.apiclient,
+cls.testdata[service_offering],
+tags=ZONETAG1
+)
+
+cls.disk_offering_zwps = DiskOffering.create(
+cls.apiclient,
+cls.testdata[disk_offering],
+tags=ZONETAG1
+)
+
+cls._cleanup = [
+cls.account,
+cls.service_offering_zwps,
+cls.disk_offering_zwps,
+]
+except Exception as e:
+cls.tearDownClass()
+raise e
+return
+
+@classmethod
+def tearDownClass(cls):
+try:
+cleanup_resources(cls.apiclient, cls._cleanup)
+except Exception as e:
+raise Exception(Warning: Exception during cleanup : %s % e)
+
+def setUp(self):
+
+self.cleanup = []
+if self.skiptest:
+self.skipTest(Skip test as setup is either not VMWare or  \
+having less than 2 clusters %s % self.hypervisor)
+
+self.apiclient = self.testClient.getApiClient()
+self.dbclient = self.testClient.getDbConnection()
+self.pools = []
+
+def 

[GitHub] cloudstack pull request: CLOUDSTACK-8716: Verify creation of snaps...

2015-08-09 Thread sanju1010
Github user sanju1010 commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/665#discussion_r36601462
  
--- Diff: test/integration/testpaths/testpath_multiple_snapshot.py ---
@@ -0,0 +1,255 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# License); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#   http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# AS IS BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+ Test case for Multiple Volume Snapshot in ZWPS
+
+from nose.plugins.attrib import attr
+from marvin.cloudstackTestCase import cloudstackTestCase
+from marvin.lib.utils import (cleanup_resources,
+  validateList)
+from marvin.lib.base import (Account,
+ ServiceOffering,
+ DiskOffering,
+ Snapshot,
+ VirtualMachine,
+ StoragePool
+ )
+from marvin.lib.common import (get_domain,
+   get_zone,
+   list_volumes,
+   list_clusters,
+   get_template
+   )
+
+from marvin.codes import PASS, ZONETAG1, ROOT, DATA
+
+
+class TestMultipleVolumeSnapshots(cloudstackTestCase):
+
+@classmethod
+def setUpClass(cls):
+testClient = super(TestMultipleVolumeSnapshots, 
cls).getClsTestClient()
+cls.apiclient = testClient.getApiClient()
+cls.testdata = testClient.getParsedTestDataConfig()
+
+# Get Zone, Domain and templates
+cls.domain = get_domain(cls.apiclient)
+cls.zone = get_zone(cls.apiclient, testClient.getZoneForTests())
+cls.hypervisor = cls.testClient.getHypervisorInfo()
+cls.template = get_template(
+cls.apiclient,
+cls.zone.id,
+cls.testdata[ostype])
+
+cls._cleanup = []
+
+cls.skiptest = False
+
+clus_list = list_clusters(cls.apiclient)
+
+if cls.hypervisor.lower() not in ['vmware'] or len(clus_list)  2:
+cls.skiptest = True
+return
+
+try:
+# Create an account
+cls.account = Account.create(
+cls.apiclient,
+cls.testdata[account],
+domainid=cls.domain.id
+)
+
+# Create user api client of the account
+cls.userapiclient = testClient.getUserApiClient(
+UserName=cls.account.name,
+DomainName=cls.account.domain
+)
+# Create Service offering
+cls.service_offering_zwps = ServiceOffering.create(
+cls.apiclient,
+cls.testdata[service_offering],
+tags=ZONETAG1
+)
+
+cls.disk_offering_zwps = DiskOffering.create(
+cls.apiclient,
+cls.testdata[disk_offering],
+tags=ZONETAG1
+)
+
+cls._cleanup = [
+cls.account,
+cls.service_offering_zwps,
+cls.disk_offering_zwps,
+]
+except Exception as e:
+cls.tearDownClass()
+raise e
+return
+
+@classmethod
+def tearDownClass(cls):
+try:
+cleanup_resources(cls.apiclient, cls._cleanup)
+except Exception as e:
+raise Exception(Warning: Exception during cleanup : %s % e)
+
+def setUp(self):
+
+self.cleanup = []
+if self.skiptest:
+self.skipTest(Skip test as setup is either not VMWare or  \
+having less than 2 clusters %s % self.hypervisor)
+
+self.apiclient = self.testClient.getApiClient()
+self.dbclient = self.testClient.getDbConnection()
+self.pools = []
+
+def 

[GitHub] cloudstack pull request: CLOUDSTACK-8716: Verify creation of snaps...

2015-08-09 Thread sanju1010
Github user sanju1010 commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/665#discussion_r36601607
  
--- Diff: test/integration/testpaths/testpath_multiple_snapshot.py ---
@@ -0,0 +1,255 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# License); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#   http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# AS IS BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+ Test case for Multiple Volume Snapshot in ZWPS
+
+from nose.plugins.attrib import attr
+from marvin.cloudstackTestCase import cloudstackTestCase
+from marvin.lib.utils import (cleanup_resources,
+  validateList)
+from marvin.lib.base import (Account,
+ ServiceOffering,
+ DiskOffering,
+ Snapshot,
+ VirtualMachine,
+ StoragePool
+ )
+from marvin.lib.common import (get_domain,
+   get_zone,
+   list_volumes,
+   list_clusters,
+   get_template
+   )
+
+from marvin.codes import PASS, ZONETAG1, ROOT, DATA
+
+
+class TestMultipleVolumeSnapshots(cloudstackTestCase):
+
+@classmethod
+def setUpClass(cls):
+testClient = super(TestMultipleVolumeSnapshots, 
cls).getClsTestClient()
+cls.apiclient = testClient.getApiClient()
+cls.testdata = testClient.getParsedTestDataConfig()
+
+# Get Zone, Domain and templates
+cls.domain = get_domain(cls.apiclient)
+cls.zone = get_zone(cls.apiclient, testClient.getZoneForTests())
+cls.hypervisor = cls.testClient.getHypervisorInfo()
+cls.template = get_template(
+cls.apiclient,
+cls.zone.id,
+cls.testdata[ostype])
+
+cls._cleanup = []
+
+cls.skiptest = False
+
+clus_list = list_clusters(cls.apiclient)
+
+if cls.hypervisor.lower() not in ['vmware'] or len(clus_list)  2:
+cls.skiptest = True
+return
+
+try:
+# Create an account
+cls.account = Account.create(
+cls.apiclient,
+cls.testdata[account],
+domainid=cls.domain.id
+)
+
+# Create user api client of the account
+cls.userapiclient = testClient.getUserApiClient(
+UserName=cls.account.name,
+DomainName=cls.account.domain
+)
+# Create Service offering
+cls.service_offering_zwps = ServiceOffering.create(
+cls.apiclient,
+cls.testdata[service_offering],
+tags=ZONETAG1
+)
+
+cls.disk_offering_zwps = DiskOffering.create(
+cls.apiclient,
+cls.testdata[disk_offering],
+tags=ZONETAG1
+)
+
+cls._cleanup = [
+cls.account,
+cls.service_offering_zwps,
+cls.disk_offering_zwps,
+]
+except Exception as e:
+cls.tearDownClass()
+raise e
+return
+
+@classmethod
+def tearDownClass(cls):
+try:
+cleanup_resources(cls.apiclient, cls._cleanup)
+except Exception as e:
+raise Exception(Warning: Exception during cleanup : %s % e)
+
+def setUp(self):
+
+self.cleanup = []
+if self.skiptest:
+self.skipTest(Skip test as setup is either not VMWare or  \
+having less than 2 clusters %s % self.hypervisor)
+
+self.apiclient = self.testClient.getApiClient()
+self.dbclient = self.testClient.getDbConnection()
+self.pools = []
+
+def 

[GitHub] cloudstack pull request: CLOUDSTACK-8716: Verify creation of snaps...

2015-08-09 Thread pritisarap12
Github user pritisarap12 commented on the pull request:

https://github.com/apache/cloudstack/pull/665#issuecomment-129314182
  
Updated testcase:
-Removed redundant code 
-Added validate_list function for list snapshot operation 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request: CLOUDSTACK-8716: Verify creation of snaps...

2015-08-07 Thread pritisarap12
GitHub user pritisarap12 opened a pull request:

https://github.com/apache/cloudstack/pull/665

CLOUDSTACK-8716: Verify creation of snapshot from volume when the task is 
performed repeatedly in zone wide primary Storage

On VMWare with a Zone wide primary storage and more than two clusters 
verify successful creation of snapshot multiple times.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/pritisarap12/cloudstack 
CLOUDSTACK-8716-Verify-creation-of-snapshot-from-volume-when-the-task-is-performed-repeatedly-in-zone-wide-primary-Storage

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/665.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #665


commit 44ba3a652e3c13c79f65aafd3e68c4b72e1dc134
Author: Priti Sarap priti.sa...@clogeny.com
Date:   2015-08-07T11:48:42Z

CLOUDSTACK-8716: Verify creation of snapshot from volume when the task is 
performed repeatedly in zone wide primary Storage




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---