[GitHub] cloudstack pull request: CLOUDSTACK-8717: Failed to start instance...

[pritisarap12]

Github user pritisarap12 commented on the pull request:

https://github.com/apache/cloudstack/pull/1416#issuecomment-185092942
  
@remibergsma and @runseb  Please give one LGTM to close the PR as it is 
just the change in commit message and PR title .


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8717: Failed to start instance...

[DaanHoogland]

Github user DaanHoogland commented on the pull request:

https://github.com/apache/cloudstack/pull/1416#issuecomment-185092625
  
please ask @remibergsma and @runseb , as they had opinions on it before.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8717: Failed to start instance...

[pritisarap12]

Github user pritisarap12 commented on the pull request:

https://github.com/apache/cloudstack/pull/1416#issuecomment-185092215
  
@DaanHoogland  Please give one LGTM to close the PR as it is just the 
change in commit message and PR title .




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8717: Failed to start instance...

[sanju1010]

Github user sanju1010 commented on the pull request:

https://github.com/apache/cloudstack/pull/1416#issuecomment-185061120
  
LGTM based on PR #667


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8717: Failed to start instance...

[sanju1010]

Github user sanju1010 commented on the pull request:

https://github.com/apache/cloudstack/pull/1411#issuecomment-185057058
  
I have reverted this  merge commit 
commit d159af93b4e6485b30424026e1a84ce85a3c7abf
Author: sanjeev 
Date:   Wed Feb 17 11:53:07 2016 +0530

Revert "Merge pull request #1411 from 
pritisarap12/CLOUDSTACK-8717-Failed-to-start-instance-after-restoring-the-running-instance"

This reverts commit 13f4e5a253c6fac8ff38ffc0a43d237be290d084, reversing
changes made to 7332e88ec935f7bdcec4e0659dfac88d537d898a.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8717: Failed to start instance...

[pritisarap12]

GitHub user pritisarap12 opened a pull request:

https://github.com/apache/cloudstack/pull/1416

CLOUDSTACK-8717: Failed to start instance after restoring the running 
instance 

Changing PR title and commit message 
In continuation with PR #1411  and  #667 

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/pritisarap12/cloudstack 
CLOUDSTACK-8717-Failed-to-start-instance-after-restoring-the-running-instance

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/1416.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1416


commit 06289da022e264c3135413cdb064a414a35e1c8c
Author: Priti Sarap 
Date:   2016-02-17T05:02:01Z

CLOUDSTACK-8717: Failed to start instance after restoring the running 
instance




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8717: Failed to start instance...

[pritisarap12]

Github user pritisarap12 commented on the pull request:

https://github.com/apache/cloudstack/pull/667#issuecomment-182778439
  
Testcase results:

Test Restore VM on VMWare ... === TestName: test_01_recover_VM | Status : 
SUCCESS ===
ok

--
Ran 1 test in 414.293s

OK



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8717: Failed to start instance...

[nitt10prashant]

Github user nitt10prashant commented on the pull request:

https://github.com/apache/cloudstack/pull/667#issuecomment-182784773
  
LGTM ..based on code review and result .


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8717: Failed to start instance...

[remibergsma]

Github user remibergsma commented on the pull request:

https://github.com/apache/cloudstack/pull/667#issuecomment-183022736
  
Don't merge stuff without responding to the comments. Look at your commits, 
two with the same title? How does that help? I asked to squash them on Aug 14 
and now you just merge it... weird. I will revert it.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8717: Failed to start instance...

[sanju1010]

Github user sanju1010 commented on the pull request:

https://github.com/apache/cloudstack/pull/667#issuecomment-182802497
  
LGTM !!

Test Restore VM on VMWare ... === TestName: test_01_recover_VM | Status : 
SUCCESS ===
ok
 
--
Ran 1 test in 435.223s
 
OK



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8717: Failed to start instance...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/cloudstack/pull/667


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8717: Failed to start instance...

[remibergsma]

Github user remibergsma commented on the pull request:

https://github.com/apache/cloudstack/pull/667#issuecomment-131213451
  
@pritisarap12 Same here, please squash the commits as they have the same 
titles.

Also, please @nitt10prashant asks for tests results. Can you please post 
them?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8717: Failed to start instance...

[nitt10prashant]

Github user nitt10prashant commented on the pull request:

https://github.com/apache/cloudstack/pull/667#issuecomment-129836794
  
can we get test result ?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8717: Failed to start instance...

[nitt10prashant]

Github user nitt10prashant commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/667#discussion_r36733719
  
--- Diff: test/integration/testpaths/testpath_restore_vm.py ---
@@ -0,0 +1,201 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# License); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#   http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# AS IS BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+
+Test restore running VM on VMWare with one cluster having 2 Primary Storage
+
+
+
+from nose.plugins.attrib import attr
+from marvin.cloudstackTestCase import cloudstackTestCase
+from marvin.lib.utils import cleanup_resources
+from marvin.lib.base import (Account,
+ ServiceOffering,
+ VirtualMachine,
+ StoragePool
+ )
+from marvin.lib.common import (get_domain,
+   get_zone,
+   get_template,
+   list_volumes,
+   list_virtual_machines
+   )
+
+from marvin.codes import CLUSTERTAG1, ROOT
+import time
+
+
+class TestRestoreVM(cloudstackTestCase):
+
+@classmethod
+def setUpClass(cls):
+testClient = super(TestRestoreVM, cls).getClsTestClient()
+cls.apiclient = testClient.getApiClient()
+cls.testdata = testClient.getParsedTestDataConfig()
+cls.hypervisor = cls.testClient.getHypervisorInfo()
+
+# Get Zone, Domain and templates
+cls.domain = get_domain(cls.apiclient)
+cls.zone = get_zone(cls.apiclient, testClient.getZoneForTests())
+
+cls.template = get_template(
+cls.apiclient,
+cls.zone.id,
+cls.testdata[ostype])
+
+cls._cleanup = []
+
+try:
+cls.skiptest = False
+if cls.hypervisor.lower() not in [vmware]:
+cls.skiptest = True
+return
+
+# Create an account
+cls.account = Account.create(
+cls.apiclient,
+cls.testdata[account],
+domainid=cls.domain.id
+)
+cls._cleanup.append(cls.account)
+# Create user api client of the account
+cls.userapiclient = testClient.getUserApiClient(
+UserName=cls.account.name,
+DomainName=cls.account.domain
+)
+# Create Service offering
+cls.service_offering_cwps = ServiceOffering.create(
+cls.apiclient,
+cls.testdata[service_offering],
+tags=CLUSTERTAG1
+)
+cls._cleanup.append(cls.service_offering_cwps)
+except Exception as e:
+cls.tearDownClass()
+raise e
+return
+
+@classmethod
+def tearDownClass(cls):
+try:
+cleanup_resources(cls.apiclient, cls._cleanup)
+except Exception as e:
+raise Exception(Warning: Exception during cleanup : %s % e)
+
+def setUp(self):
+
+self.cleanup = []
+if self.skiptest:
+self.skipTest(This test is to be checked on VMWare only \
+Hence, skip for %s % self.hypervisor)
+
+self.apiclient = self.testClient.getApiClient()
+self.dbclient = self.testClient.getDbConnection()
+
+def tearDown(self):
+try:
+cleanup_resources(self.apiclient, self.cleanup)
+except Exception as e:
+raise Exception(Warning: Exception during cleanup : %s % e)
+return
+
+@attr(tags=[advanced, basic], required_hardware=true)
+def test_01_recover_VM(self):
+ Test Restore VM on VMWare
+1. Deploy a VM without datadisk
+2. Restore the VM
+3. Verify that VM comes up in 

[GitHub] cloudstack pull request: CLOUDSTACK-8717: Failed to start instance...

[nitt10prashant]

Github user nitt10prashant commented on the pull request:

https://github.com/apache/cloudstack/pull/667#issuecomment-129837984
  
can we get test results ?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8717: Failed to start instance...

[pritisarap12]

Github user pritisarap12 commented on the pull request:

https://github.com/apache/cloudstack/pull/667#issuecomment-129310396
  
Updated testcase with review comments.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8717: Failed to start instance...

[sanju1010]

Github user sanju1010 commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/667#discussion_r36601640
  
--- Diff: test/integration/testpaths/testpath_restore_vm.py ---
@@ -0,0 +1,192 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# License); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#   http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# AS IS BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+
+Test restore running VM on VMWare with one cluster having 2 Primary Storage
+
+
+
+from nose.plugins.attrib import attr
+from marvin.cloudstackTestCase import cloudstackTestCase
+from marvin.lib.utils import cleanup_resources
+from marvin.lib.base import (Account,
+ ServiceOffering,
+ VirtualMachine,
+ StoragePool
+ )
+from marvin.lib.common import (get_domain,
+   get_zone,
+   get_template,
+   list_volumes
+   )
+
+from marvin.codes import CLUSTERTAG1, ROOT
+import time
+
+
+class TestRestoreVM(cloudstackTestCase):
+
+@classmethod
+def setUpClass(cls):
+testClient = super(TestRestoreVM, cls).getClsTestClient()
+cls.apiclient = testClient.getApiClient()
+cls.testdata = testClient.getParsedTestDataConfig()
+cls.hypervisor = cls.testClient.getHypervisorInfo()
+
+# Get Zone, Domain and templates
+cls.domain = get_domain(cls.apiclient)
+cls.zone = get_zone(cls.apiclient, testClient.getZoneForTests())
+
+cls.template = get_template(
+cls.apiclient,
+cls.zone.id,
+cls.testdata[ostype])
+
+cls._cleanup = []
+
+try:
+cls.skiptest = False
+if cls.hypervisor.lower() not in [vmware]:
+cls.skiptest = True
+return
+
+# Create an account
+cls.account = Account.create(
+cls.apiclient,
+cls.testdata[account],
+domainid=cls.domain.id
+)
+cls._cleanup.append(cls.account)
+# Create user api client of the account
+cls.userapiclient = testClient.getUserApiClient(
+UserName=cls.account.name,
+DomainName=cls.account.domain
+)
+# Create Service offering
+cls.service_offering_cwps = ServiceOffering.create(
+cls.apiclient,
+cls.testdata[service_offering],
+tags=CLUSTERTAG1
+)
+cls._cleanup.append(cls.service_offering_cwps)
+except Exception as e:
+cls.tearDownClass()
+raise e
+return
+
+@classmethod
+def tearDownClass(cls):
+try:
+cleanup_resources(cls.apiclient, cls._cleanup)
+except Exception as e:
+raise Exception(Warning: Exception during cleanup : %s % e)
+
+def setUp(self):
+
+self.cleanup = []
+if self.skiptest:
+self.skipTest(This test is to be checked on VMWare only \
+Hence, skip for %s % self.hypervisor)
+
+self.apiclient = self.testClient.getApiClient()
+self.dbclient = self.testClient.getDbConnection()
+
+def tearDown(self):
+try:
+cleanup_resources(self.apiclient, self.cleanup)
+except Exception as e:
+raise Exception(Warning: Exception during cleanup : %s % e)
+return
+
+@attr(tags=[advanced, basic], required_hardware=false)
--- End diff --

Since this test is specific to vmware, this can't be run on a simulator. 
Please set required_hardware=true if this is only for vmware.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as 

[GitHub] cloudstack pull request: CLOUDSTACK-8717: Failed to start instance...

[sanju1010]

Github user sanju1010 commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/667#discussion_r36602070
  
--- Diff: test/integration/testpaths/testpath_restore_vm.py ---
@@ -0,0 +1,192 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# License); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#   http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# AS IS BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+
+Test restore running VM on VMWare with one cluster having 2 Primary Storage
+
+
+
+from nose.plugins.attrib import attr
+from marvin.cloudstackTestCase import cloudstackTestCase
+from marvin.lib.utils import cleanup_resources
+from marvin.lib.base import (Account,
+ ServiceOffering,
+ VirtualMachine,
+ StoragePool
+ )
+from marvin.lib.common import (get_domain,
+   get_zone,
+   get_template,
+   list_volumes
+   )
+
+from marvin.codes import CLUSTERTAG1, ROOT
+import time
+
+
+class TestRestoreVM(cloudstackTestCase):
+
+@classmethod
+def setUpClass(cls):
+testClient = super(TestRestoreVM, cls).getClsTestClient()
+cls.apiclient = testClient.getApiClient()
+cls.testdata = testClient.getParsedTestDataConfig()
+cls.hypervisor = cls.testClient.getHypervisorInfo()
+
+# Get Zone, Domain and templates
+cls.domain = get_domain(cls.apiclient)
+cls.zone = get_zone(cls.apiclient, testClient.getZoneForTests())
+
+cls.template = get_template(
+cls.apiclient,
+cls.zone.id,
+cls.testdata[ostype])
+
+cls._cleanup = []
+
+try:
+cls.skiptest = False
+if cls.hypervisor.lower() not in [vmware]:
+cls.skiptest = True
+return
+
+# Create an account
+cls.account = Account.create(
+cls.apiclient,
+cls.testdata[account],
+domainid=cls.domain.id
+)
+cls._cleanup.append(cls.account)
+# Create user api client of the account
+cls.userapiclient = testClient.getUserApiClient(
+UserName=cls.account.name,
+DomainName=cls.account.domain
+)
+# Create Service offering
+cls.service_offering_cwps = ServiceOffering.create(
+cls.apiclient,
+cls.testdata[service_offering],
+tags=CLUSTERTAG1
+)
+cls._cleanup.append(cls.service_offering_cwps)
+except Exception as e:
+cls.tearDownClass()
+raise e
+return
+
+@classmethod
+def tearDownClass(cls):
+try:
+cleanup_resources(cls.apiclient, cls._cleanup)
+except Exception as e:
+raise Exception(Warning: Exception during cleanup : %s % e)
+
+def setUp(self):
+
+self.cleanup = []
+if self.skiptest:
+self.skipTest(This test is to be checked on VMWare only \
+Hence, skip for %s % self.hypervisor)
+
+self.apiclient = self.testClient.getApiClient()
+self.dbclient = self.testClient.getDbConnection()
+
+def tearDown(self):
+try:
+cleanup_resources(self.apiclient, self.cleanup)
+except Exception as e:
+raise Exception(Warning: Exception during cleanup : %s % e)
+return
+
+@attr(tags=[advanced, basic], required_hardware=false)
+def test_01_recover_VM(self):
+ Test Restore VM on VMWare
+1. Deploy a VM without datadisk
+2. Restore the VM
+3. Verify that VM comes up in Running state
+
+try:
+

[GitHub] cloudstack pull request: CLOUDSTACK-8717: Failed to start instance...

[pritisarap12]

GitHub user pritisarap12 opened a pull request:

https://github.com/apache/cloudstack/pull/667

CLOUDSTACK-8717: Failed to start instance after restoring the running 
instance 

On setup with two cluster wide primary storage verify restoring a running 
instance.(As while restoring instance root disk may get created on another 
primary storage.)


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/pritisarap12/cloudstack 
CLOUDSTACK-8717-Failed-to-start-instance-after-restoring-the-running-instance

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/667.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #667


commit f163cbcb44d1c712deb5722f9623cb4675f01bf9
Author: Priti Sarap priti.sa...@clogeny.com
Date:   2015-08-07T12:27:54Z

CLOUDSTACK-8717: Failed to start instance after restoring the running 
instance




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---