[GitHub] cloudstack pull request: CLOUDSTACK-8720: Handle corner case in re...
Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/671 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-8720: Handle corner case in re...
Github user pavanb018 commented on the pull request: https://github.com/apache/cloudstack/pull/671#issuecomment-129720549 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-8720: Handle corner case in re...
GitHub user sanju1010 opened a pull request: https://github.com/apache/cloudstack/pull/671 CLOUDSTACK-8720: Handle corner case in remove nic from vm Please see the bug for more details You can merge this pull request into a Git repository by running: $ git pull https://github.com/sanju1010/cloudstack CSBug Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cloudstack/pull/671.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #671 commit 41be8f4ef8bc914eb94549003b72387d729a3ef4 Author: sanjeev sanj...@apache.org Date: 2015-08-07T12:39:09Z CLOUDSTACK-8720: Handle corner case in remove nic from vm Please see the bug for more details --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-8720: Handle corner case in re...
Github user sanju1010 commented on the pull request: https://github.com/apache/cloudstack/pull/671#issuecomment-129378007 Test to verify remove nic from vm if the nic ip is same as another vm ip in another network ... === TestName: test_29_remove_nic_CS22503 | Status : SUCCESS === ok -- Ran 1 test in 359.186s OK --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-8720: Handle corner case in re...
Github user nitt10prashant commented on the pull request: https://github.com/apache/cloudstack/pull/671#issuecomment-129401139 Looks Good --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---