[GitHub] cloudstack pull request: CLOUDSTACK-8726 : Automation for Quickly ...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/cloudstack/pull/683


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8726 : Automation for Quickly ...

[pavanb018]

Github user pavanb018 commented on the pull request:

https://github.com/apache/cloudstack/pull/683#issuecomment-142531937
  
The result of operation is captured in the list volume validation following 
the call to query_async_job method. Hence didn't capture the return value of 
call to function as it will be captured in the end validation. Please let me 
know your suggestions.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: [GitHub] cloudstack pull request: CLOUDSTACK-8726 : Automation for Quickly ...

[Sanjeev N]

LGTM!!

On Wed, Sep 23, 2015 at 2:15 PM, pavanb018  wrote:

> Github user pavanb018 commented on the pull request:
>
> https://github.com/apache/cloudstack/pull/683#issuecomment-142531937
>
> The result of operation is captured in the list volume validation
> following the call to query_async_job method. Hence didn't capture the
> return value of call to function as it will be captured in the end
> validation. Please let me know your suggestions.
>
>
> ---
> If your project is set up for it, you can reply to this email and have your
> reply appear on GitHub as well. If your project does not have this feature
> enabled and wishes so, or if the feature is enabled but not working, please
> contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
> with INFRA.
> ---
>

[GitHub] cloudstack pull request: CLOUDSTACK-8726 : Automation for Quickly ...

[sanju1010]

Github user sanju1010 commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/683#discussion_r37160117
  
--- Diff: test/integration/component/test_simultaneous_volume_attach.py ---
@@ -0,0 +1,255 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# License); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#   http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# AS IS BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+#Import Local Modules
+from marvin.cloudstackAPI import *
+from marvin.cloudstackTestCase import cloudstackTestCase, unittest
+from marvin.lib.utils import (cleanup_resources,
+  validateList)
+from marvin.lib.base import (ServiceOffering,
+ VirtualMachine,
+ Account,
+ Volume,
+ DiskOffering,
+ )
+from marvin.lib.common import (get_domain,
+get_zone,
+get_template,
+find_storage_pool_type)
+from marvin.codes import (
+PASS,
+FAILED,
+JOB_FAILED,
+JOB_CANCELLED,
+JOB_SUCCEEDED
+)
+from nose.plugins.attrib import attr
+import time
+
+
+class TestMultipleVolumeAttach(cloudstackTestCase):
+
+@classmethod
+def setUpClass(cls):
+testClient = super(TestMultipleVolumeAttach, 
cls).getClsTestClient()
+cls.apiclient = testClient.getApiClient()
+cls.services = testClient.getParsedTestDataConfig()
+cls._cleanup = []
+# Get Zone, Domain and templates
+cls.domain = get_domain(cls.apiclient)
+cls.zone = get_zone(cls.apiclient, testClient.getZoneForTests())
+cls.services['mode'] = cls.zone.networktype
+cls.hypervisor = testClient.getHypervisorInfo()
+cls.invalidStoragePoolType = False
+#for LXC if the storage pool of type 'rbd' ex: ceph is not 
available, skip the test
+if cls.hypervisor.lower() == 'lxc':
+if not find_storage_pool_type(cls.apiclient, 
storagetype='rbd'):
+# RBD storage type is required for data volumes for LXC
+cls.invalidStoragePoolType = True
+return
+
+cls.disk_offering = DiskOffering.create(
+cls.apiclient,
+cls.services[disk_offering]
+)
+
+template = get_template(
+cls.apiclient,
+cls.zone.id,
+cls.services[ostype]
+)
+if template == FAILED:
+assert False, get_template() failed to return template with 
description %s % cls.services[ostype]
+
+cls.services[domainid] = cls.domain.id
+cls.services[zoneid] = cls.zone.id
+cls.services[template] = template.id
+cls.services[diskofferingid] = cls.disk_offering.id
+
+# Create VMs, VMs etc
+cls.account = Account.create(
+cls.apiclient,
+cls.services[account],
+domainid=cls.domain.id
+)
+cls.service_offering = ServiceOffering.create(
+cls.apiclient,
+
cls.services[service_offering]
+)
+cls.virtual_machine = VirtualMachine.create(
+cls.apiclient,
+cls.services,
+accountid=cls.account.name,
+domainid=cls.account.domainid,
+
serviceofferingid=cls.service_offering.id,
+mode=cls.services[mode]
+)
+
+

[GitHub] cloudstack pull request: CLOUDSTACK-8726 : Automation for Quickly ...

[remibergsma]

Github user remibergsma commented on the pull request:

https://github.com/apache/cloudstack/pull/683#issuecomment-131158312
  
@pavanb018 Can you please squash the commits?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8726 : Automation for Quickly ...

[nitt10prashant]

Github user nitt10prashant commented on the pull request:

https://github.com/apache/cloudstack/pull/683#issuecomment-130587552
  
LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8726 : Automation for Quickly ...

[nitt10prashant]

Github user nitt10prashant commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/683#discussion_r36940905
  
--- Diff: test/integration/component/test_simultaneous_volume_attach.py ---
@@ -0,0 +1,256 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# License); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#   http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# AS IS BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+#Import Local Modules
+from marvin.cloudstackAPI import *
+from marvin.cloudstackTestCase import cloudstackTestCase, unittest
+from marvin.lib.utils import (cleanup_resources,
+  validateList)
+from marvin.lib.base import (ServiceOffering,
+ VirtualMachine,
+ Account,
+ Volume,
+ DiskOffering,
+ )
+from marvin.lib.common import (get_domain,
+get_zone,
+get_template,
+find_storage_pool_type)
+from marvin.codes import (
+PASS,
+FAILED,
+JOB_FAILED,
+JOB_CANCELLED,
+JOB_SUCCEEDED
+)
+from nose.plugins.attrib import attr
+import time
+
+
+class TestMultipleVolumeAttach(cloudstackTestCase):
+
+@classmethod
+def setUpClass(cls):
+testClient = super(TestMultipleVolumeAttach, 
cls).getClsTestClient()
+cls.apiclient = testClient.getApiClient()
+cls.services = testClient.getParsedTestDataConfig()
+cls._cleanup = []
+# Get Zone, Domain and templates
+cls.domain = get_domain(cls.apiclient)
+cls.zone = get_zone(cls.apiclient, testClient.getZoneForTests())
+cls.services['mode'] = cls.zone.networktype
+cls.hypervisor = testClient.getHypervisorInfo()
+cls.invalidStoragePoolType = False
+#for LXC if the storage pool of type 'rbd' ex: ceph is not 
available, skip the test
+if cls.hypervisor.lower() == 'lxc':
+if not find_storage_pool_type(cls.apiclient, 
storagetype='rbd'):
+# RBD storage type is required for data volumes for LXC
+cls.invalidStoragePoolType = True
+return
+cls.disk_offering = DiskOffering.create(
+cls.apiclient,
+cls.services[disk_offering]
+)
+
+template = get_template(
+cls.apiclient,
+cls.zone.id,
+cls.services[ostype]
+)
+if template == FAILED:
+assert False, get_template() failed to return template with 
description %s % cls.services[ostype]
+
+cls.services[domainid] = cls.domain.id
+cls.services[zoneid] = cls.zone.id
+cls.services[template] = template.id
+cls.services[diskofferingid] = cls.disk_offering.id
+
+# Create VMs, VMs etc
+cls.account = Account.create(
+cls.apiclient,
+cls.services[account],
+domainid=cls.domain.id
+)
+cls.service_offering = ServiceOffering.create(
+cls.apiclient,
+
cls.services[service_offering]
+)
+cls.virtual_machine = VirtualMachine.create(
+cls.apiclient,
+cls.services,
+accountid=cls.account.name,
+domainid=cls.account.domainid,
+
serviceofferingid=cls.service_offering.id,
+mode=cls.services[mode]
+)
+
+if 

[GitHub] cloudstack pull request: CLOUDSTACK-8726 : Automation for Quickly ...

[nitt10prashant]

Github user nitt10prashant commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/683#discussion_r36845173
  
--- Diff: test/integration/component/test_simultaneous_volume_attach.py ---
@@ -0,0 +1,264 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# License); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#   http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# AS IS BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+#Import Local Modules
+from marvin.cloudstackAPI import *
+from marvin.cloudstackTestCase import cloudstackTestCase, unittest
+from marvin.lib.utils import (cleanup_resources,
+  validateList)
+from marvin.lib.base import (ServiceOffering,
+ VirtualMachine,
+ Account,
+ Volume,
+ DiskOffering,
+ )
+from marvin.lib.common import (get_domain,
+get_zone,
+get_template,
+find_storage_pool_type)
+from marvin.codes import (
+PASS,
+FAILED,
+JOB_FAILED,
+JOB_CANCELLED,
+JOB_SUCCEEDED
+)
+from nose.plugins.attrib import attr
+import time
+
+
+class TestMultipleVolumeAttach(cloudstackTestCase):
+
+@classmethod
+def setUpClass(cls):
+testClient = super(TestMultipleVolumeAttach, 
cls).getClsTestClient()
+cls.apiclient = testClient.getApiClient()
+cls.services = testClient.getParsedTestDataConfig()
+cls._cleanup = []
+# Get Zone, Domain and templates
+cls.domain = get_domain(cls.apiclient)
+cls.zone = get_zone(cls.apiclient, testClient.getZoneForTests())
+cls.services['mode'] = cls.zone.networktype
+cls.hypervisor = testClient.getHypervisorInfo()
+cls.invalidStoragePoolType = False
+#for LXC if the storage pool of type 'rbd' ex: ceph is not 
available, skip the test
+if cls.hypervisor.lower() == 'lxc':
+if not find_storage_pool_type(cls.apiclient, 
storagetype='rbd'):
+# RBD storage type is required for data volumes for LXC
+cls.invalidStoragePoolType = True
+return
+cls.disk_offering = DiskOffering.create(
+cls.apiclient,
+cls.services[disk_offering]
+)
+
+template = get_template(
+cls.apiclient,
+cls.zone.id,
+cls.services[ostype]
+)
+if template == FAILED:
+assert False, get_template() failed to return template with 
description %s % cls.services[ostype]
+
+cls.services[domainid] = cls.domain.id
+cls.services[zoneid] = cls.zone.id
+cls.services[template] = template.id
+cls.services[diskofferingid] = cls.disk_offering.id
+
+# Create VMs, VMs etc
+cls.account = Account.create(
+cls.apiclient,
+cls.services[account],
+domainid=cls.domain.id
+)
+cls.service_offering = ServiceOffering.create(
+cls.apiclient,
+
cls.services[service_offering]
+)
+cls.virtual_machine = VirtualMachine.create(
+cls.apiclient,
+cls.services,
+accountid=cls.account.name,
+domainid=cls.account.domainid,
+
serviceofferingid=cls.service_offering.id,
+mode=cls.services[mode]
+)
+
+if 

[GitHub] cloudstack pull request: CLOUDSTACK-8726 : Automation for Quickly ...

[pavanb018]

GitHub user pavanb018 opened a pull request:

https://github.com/apache/cloudstack/pull/683

CLOUDSTACK-8726 : Automation for Quickly attaching multiple data disks to a 
new VM

Attach multiple Volumes simultaneously to a Running VM ... === TestName: 
test_attach_multiple_volumes | Status : SUCCESS ===
ok

--
Ran 1 test in 196.931s

OK


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/pavanb018/cloudstack multivol

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/683.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #683


commit 6e96c658a81cf86cbd01ca08368b2a29ffc51000
Author: pavan018 pavanbandarupa...@gmail.com
Date:   2015-08-12T09:52:19Z

Automation for multiple disk attachments to instance




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8726 : Automation for Quickly ...

[nitt10prashant]

Github user nitt10prashant commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/683#discussion_r36845123
  
--- Diff: test/integration/component/test_simultaneous_volume_attach.py ---
@@ -0,0 +1,264 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# License); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#   http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# AS IS BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+#Import Local Modules
+from marvin.cloudstackAPI import *
+from marvin.cloudstackTestCase import cloudstackTestCase, unittest
+from marvin.lib.utils import (cleanup_resources,
+  validateList)
+from marvin.lib.base import (ServiceOffering,
+ VirtualMachine,
+ Account,
+ Volume,
+ DiskOffering,
+ )
+from marvin.lib.common import (get_domain,
+get_zone,
+get_template,
+find_storage_pool_type)
+from marvin.codes import (
+PASS,
+FAILED,
+JOB_FAILED,
+JOB_CANCELLED,
+JOB_SUCCEEDED
+)
+from nose.plugins.attrib import attr
+import time
+
+
+class TestMultipleVolumeAttach(cloudstackTestCase):
+
+@classmethod
+def setUpClass(cls):
+testClient = super(TestMultipleVolumeAttach, 
cls).getClsTestClient()
+cls.apiclient = testClient.getApiClient()
+cls.services = testClient.getParsedTestDataConfig()
+cls._cleanup = []
+# Get Zone, Domain and templates
+cls.domain = get_domain(cls.apiclient)
+cls.zone = get_zone(cls.apiclient, testClient.getZoneForTests())
+cls.services['mode'] = cls.zone.networktype
+cls.hypervisor = testClient.getHypervisorInfo()
+cls.invalidStoragePoolType = False
+#for LXC if the storage pool of type 'rbd' ex: ceph is not 
available, skip the test
+if cls.hypervisor.lower() == 'lxc':
+if not find_storage_pool_type(cls.apiclient, 
storagetype='rbd'):
+# RBD storage type is required for data volumes for LXC
+cls.invalidStoragePoolType = True
+return
+cls.disk_offering = DiskOffering.create(
+cls.apiclient,
+cls.services[disk_offering]
+)
+
+template = get_template(
+cls.apiclient,
+cls.zone.id,
+cls.services[ostype]
+)
+if template == FAILED:
+assert False, get_template() failed to return template with 
description %s % cls.services[ostype]
+
+cls.services[domainid] = cls.domain.id
+cls.services[zoneid] = cls.zone.id
+cls.services[template] = template.id
+cls.services[diskofferingid] = cls.disk_offering.id
+
+# Create VMs, VMs etc
+cls.account = Account.create(
+cls.apiclient,
+cls.services[account],
+domainid=cls.domain.id
+)
+cls.service_offering = ServiceOffering.create(
+cls.apiclient,
+
cls.services[service_offering]
+)
+cls.virtual_machine = VirtualMachine.create(
+cls.apiclient,
+cls.services,
+accountid=cls.account.name,
+domainid=cls.account.domainid,
+
serviceofferingid=cls.service_offering.id,
+mode=cls.services[mode]
+)
+
+if