[GitHub] cloudstack pull request: CLOUDSTACK-8745 : verify usage after root...
Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/713 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-8745 : verify usage after root...
Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/713#issuecomment-213565364 I think this one is ready unless anyone has any final words... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-8745 : verify usage after root...
Github user swill commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/713#discussion_r60792255 --- Diff: test/integration/component/maint/test_ha_pool_maintenance.py --- @@ -0,0 +1,229 @@ +#!/usr/bin/env python +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +from nose.plugins.attrib import attr +from marvin.cloudstackTestCase import cloudstackTestCase +from marvin.cloudstackAPI import (enableStorageMaintenance, + cancelStorageMaintenance + ) +from marvin.lib.utils import (cleanup_resources, + validateList) +from marvin.lib.base import (Account, + VirtualMachine, + ServiceOffering, + Cluster, + StoragePool, + Volume) +from marvin.lib.common import (get_zone, + get_domain, + get_template, + list_hosts + ) +from marvin.codes import PASS + + +def maintenance(self, storageid): +"""enables maintenance mode of a Storage pool""" + +cmd = enableStorageMaintenance.enableStorageMaintenanceCmd() +cmd.id = storageid +return self.api_client.enableStorageMaintenance(cmd) + + +def cancelmaintenance(self, storageid): +"""cancel maintenance mode of a Storage pool""" + +cmd = cancelStorageMaintenance.cancelStorageMaintenanceCmd() +cmd.id = storageid +return self.api_client.cancelStorageMaintenance(cmd) + + +class testHaPoolMaintenance(cloudstackTestCase): + +@classmethod +def setUpClass(cls): +try: +cls._cleanup = [] +cls.testClient = super( +testHaPoolMaintenance, +cls).getClsTestClient() +cls.api_client = cls.testClient.getApiClient() +cls.services = cls.testClient.getParsedTestDataConfig() +# Get Domain, Zone, Template +cls.domain = get_domain(cls.api_client) +cls.zone = get_zone( +cls.api_client, +cls.testClient.getZoneForTests()) +cls.template = get_template( +cls.api_client, +cls.zone.id, +cls.services["ostype"] +) +cls.hypervisor = cls.testClient.getHypervisorInfo() +cls.services['mode'] = cls.zone.networktype +cls.hypervisor = cls.testClient.getHypervisorInfo() +cls.services["virtual_machine"]["zoneid"] = cls.zone.id +cls.services["virtual_machine"]["template"] = cls.template.id +cls.clusterWithSufficientPool = None +clusters = Cluster.list(cls.api_client, zoneid=cls.zone.id) + +if not validateList(clusters)[0]: + +cls.debug( +"check list cluster response for zone id %s" % +cls.zone.id) + +for cluster in clusters: +cls.pool = StoragePool.list(cls.api_client, +clusterid=cluster.id, +keyword="NetworkFilesystem" +) + +if not validateList(cls.pool)[0]: + +cls.debug( +"check list cluster response for zone id %s" % +cls.zone.id) + +if len(cls.pool) >= 2: +cls.clusterWithSufficientPool = cluster +break +if not cls.clusterWithSufficientPool: +return + +cls.services["service_offerings"][ +
[GitHub] cloudstack pull request: CLOUDSTACK-8745 : verify usage after root...
Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/713#issuecomment-213407542 I need one more LGTM code review on this one. I will try to test this in my lab today. Thanks... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-8745 : verify usage after root...
Github user nitt10prashant commented on the pull request: https://github.com/apache/cloudstack/pull/713#issuecomment-213278268 @bhaisaab rebased and merged into single commit ,@swill @koushik-das can you please look into this --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-8745 : verify usage after root...
Github user nitt10prashant commented on the pull request: https://github.com/apache/cloudstack/pull/713#issuecomment-191098254 sure --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-8745 : verify usage after root...
Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/713#issuecomment-175665150 @nitt10prashant please rebase and meld into a single commit --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-8745 : verify usage after root...
Github user pavanb018 commented on the pull request: https://github.com/apache/cloudstack/pull/713#issuecomment-141880475 The test Looks good to me. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-8745 : verify usage after root...
Github user sanju1010 commented on the pull request: https://github.com/apache/cloudstack/pull/713#issuecomment-139975477 LGTM!! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-8745 : verify usage after root...
Github user nitt10prashant commented on the pull request: https://github.com/apache/cloudstack/pull/713#issuecomment-132476722 test result of enough storage is not available to perform test put storage in maintenance mode and start ha vm and check usage ... SKIP: sufficient storage not available in any cluster for zone 90d85d89-01c4-4a91-b76e-eedf947b40f6 -- Ran 1 test in 4.059s OK (SKIP=1) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-8745 : verify usage after root...
GitHub user nitt10prashant opened a pull request: https://github.com/apache/cloudstack/pull/713 CLOUDSTACK-8745 : verify usage after root disk migration put storage in maintenance mode and start ha vm and check usage ... === TestName: test_ha_with_storage_maintenance | Status : SUCCESS === ok -- Ran 1 test in 842.294s OK You can merge this pull request into a Git repository by running: $ git pull https://github.com/nitt10prashant/cloudstack pool_maint Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cloudstack/pull/713.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #713 commit d276a3579f7f055b5431575a5bb498d96dfc9f45 Author: nitt10prashant nitt10.prash...@gmail.com Date: 2015-08-18T11:23:54Z CLOUDSTACK-8745 : verify usage after root disk migration --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-8745 : verify usage after root...
Github user ksowmya commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/713#discussion_r37379405 --- Diff: test/integration/component/maint/test_ha_pool_maintenance.py --- @@ -0,0 +1,229 @@ +#!/usr/bin/env python +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# License); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# AS IS BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +from nose.plugins.attrib import attr +from marvin.cloudstackTestCase import cloudstackTestCase +from marvin.cloudstackAPI import (enableStorageMaintenance, + cancelStorageMaintenance + ) +from marvin.lib.utils import (cleanup_resources, + validateList) +from marvin.lib.base import (Account, + VirtualMachine, + ServiceOffering, + Cluster, + StoragePool, + Volume) +from marvin.lib.common import (get_zone, + get_domain, + get_template, + list_hosts + ) +from marvin.codes import PASS + + +def maintenance(self, storageid): +enables maintenance mode of a Storage pool + +cmd = enableStorageMaintenance.enableStorageMaintenanceCmd() +cmd.id = storageid +return self.api_client.enableStorageMaintenance(cmd) + + +def cancelmaintenance(self, storageid): +cancel maintenance mode of a Storage pool + +cmd = cancelStorageMaintenance.cancelStorageMaintenanceCmd() +cmd.id = storageid +return self.api_client.cancelStorageMaintenance(cmd) + + +class testHaPoolMaintenance(cloudstackTestCase): + +@classmethod +def setUpClass(cls): +try: +cls._cleanup = [] +cls.testClient = super( +testHaPoolMaintenance, +cls).getClsTestClient() +cls.api_client = cls.testClient.getApiClient() +cls.services = cls.testClient.getParsedTestDataConfig() +# Get Domain, Zone, Template +cls.domain = get_domain(cls.api_client) +cls.zone = get_zone( +cls.api_client, +cls.testClient.getZoneForTests()) +cls.template = get_template( +cls.api_client, +cls.zone.id, +cls.services[ostype] +) +cls.hypervisor = cls.testClient.getHypervisorInfo() +cls.services['mode'] = cls.zone.networktype +cls.hypervisor = cls.testClient.getHypervisorInfo() +cls.services[virtual_machine][zoneid] = cls.zone.id +cls.services[virtual_machine][template] = cls.template.id +cls.clusterWithSufficientPool = None +clusters = Cluster.list(cls.api_client, zoneid=cls.zone.id) + +if not validateList(clusters)[0]: + +cls.debug( +check list cluster response for zone id %s % +cls.zone.id) + +for cluster in clusters: +cls.pool = StoragePool.list(cls.api_client, +clusterid=cluster.id, +keyword=NetworkFilesystem +) + +if not validateList(cls.pool)[0]: + +cls.debug( +check list cluster response for zone id %s % +cls.zone.id) + +if len(cls.pool) = 2: +cls.clusterWithSufficientPool = cluster +break +if not cls.clusterWithSufficientPool: +return + +cls.services[service_offerings][ +tiny][offerha] = True + +
[GitHub] cloudstack pull request: CLOUDSTACK-8745 : verify usage after root...
Github user nitt10prashant commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/713#discussion_r37379426 --- Diff: test/integration/component/maint/test_ha_pool_maintenance.py --- @@ -0,0 +1,229 @@ +#!/usr/bin/env python +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# License); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# AS IS BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +from nose.plugins.attrib import attr +from marvin.cloudstackTestCase import cloudstackTestCase +from marvin.cloudstackAPI import (enableStorageMaintenance, + cancelStorageMaintenance + ) +from marvin.lib.utils import (cleanup_resources, + validateList) +from marvin.lib.base import (Account, + VirtualMachine, + ServiceOffering, + Cluster, + StoragePool, + Volume) +from marvin.lib.common import (get_zone, + get_domain, + get_template, + list_hosts + ) +from marvin.codes import PASS + + +def maintenance(self, storageid): +enables maintenance mode of a Storage pool + +cmd = enableStorageMaintenance.enableStorageMaintenanceCmd() +cmd.id = storageid +return self.api_client.enableStorageMaintenance(cmd) + + +def cancelmaintenance(self, storageid): +cancel maintenance mode of a Storage pool + +cmd = cancelStorageMaintenance.cancelStorageMaintenanceCmd() +cmd.id = storageid +return self.api_client.cancelStorageMaintenance(cmd) + + +class testHaPoolMaintenance(cloudstackTestCase): + +@classmethod +def setUpClass(cls): +try: +cls._cleanup = [] +cls.testClient = super( +testHaPoolMaintenance, +cls).getClsTestClient() +cls.api_client = cls.testClient.getApiClient() +cls.services = cls.testClient.getParsedTestDataConfig() +# Get Domain, Zone, Template +cls.domain = get_domain(cls.api_client) +cls.zone = get_zone( +cls.api_client, +cls.testClient.getZoneForTests()) +cls.template = get_template( +cls.api_client, +cls.zone.id, +cls.services[ostype] +) +cls.hypervisor = cls.testClient.getHypervisorInfo() +cls.services['mode'] = cls.zone.networktype +cls.hypervisor = cls.testClient.getHypervisorInfo() +cls.services[virtual_machine][zoneid] = cls.zone.id +cls.services[virtual_machine][template] = cls.template.id +cls.clusterWithSufficientPool = None +clusters = Cluster.list(cls.api_client, zoneid=cls.zone.id) + +if not validateList(clusters)[0]: + +cls.debug( +check list cluster response for zone id %s % +cls.zone.id) + +for cluster in clusters: +cls.pool = StoragePool.list(cls.api_client, +clusterid=cluster.id, +keyword=NetworkFilesystem +) + +if not validateList(cls.pool)[0]: + +cls.debug( +check list cluster response for zone id %s % +cls.zone.id) + +if len(cls.pool) = 2: +cls.clusterWithSufficientPool = cluster +break +if not cls.clusterWithSufficientPool: +return + +cls.services[service_offerings][ +tiny][offerha] = True + +
[GitHub] cloudstack pull request: CLOUDSTACK-8745 : verify usage after root...
Github user ksowmya commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/713#discussion_r37379847 --- Diff: test/integration/component/maint/test_ha_pool_maintenance.py --- @@ -0,0 +1,229 @@ +#!/usr/bin/env python +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# License); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# AS IS BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +from nose.plugins.attrib import attr +from marvin.cloudstackTestCase import cloudstackTestCase +from marvin.cloudstackAPI import (enableStorageMaintenance, + cancelStorageMaintenance + ) +from marvin.lib.utils import (cleanup_resources, + validateList) +from marvin.lib.base import (Account, + VirtualMachine, + ServiceOffering, + Cluster, + StoragePool, + Volume) +from marvin.lib.common import (get_zone, + get_domain, + get_template, + list_hosts + ) +from marvin.codes import PASS + + +def maintenance(self, storageid): +enables maintenance mode of a Storage pool + +cmd = enableStorageMaintenance.enableStorageMaintenanceCmd() +cmd.id = storageid +return self.api_client.enableStorageMaintenance(cmd) + --- End diff -- hmm... I thought something like this should work: StoragePool.enableMaintenance(self.api_client, id=storageself.storageid[0][0]) since it is a classmethod I am just trying to confirm you're using the latest base.py since couple of these enhancements went in recently into base.py... If it still doesn't fit in, it's ok. You can continue the way you've done --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-8745 : verify usage after root...
Github user nitt10prashant commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/713#discussion_r37379373 --- Diff: test/integration/component/maint/test_ha_pool_maintenance.py --- @@ -0,0 +1,229 @@ +#!/usr/bin/env python +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# License); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# AS IS BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +from nose.plugins.attrib import attr +from marvin.cloudstackTestCase import cloudstackTestCase +from marvin.cloudstackAPI import (enableStorageMaintenance, + cancelStorageMaintenance + ) +from marvin.lib.utils import (cleanup_resources, + validateList) +from marvin.lib.base import (Account, + VirtualMachine, + ServiceOffering, + Cluster, + StoragePool, + Volume) +from marvin.lib.common import (get_zone, + get_domain, + get_template, + list_hosts + ) +from marvin.codes import PASS + + +def maintenance(self, storageid): +enables maintenance mode of a Storage pool + +cmd = enableStorageMaintenance.enableStorageMaintenanceCmd() +cmd.id = storageid +return self.api_client.enableStorageMaintenance(cmd) + --- End diff -- those methods can be used only with storage pool class object. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-8745 : verify usage after root...
Github user nitt10prashant commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/713#discussion_r37379748 --- Diff: test/integration/component/maint/test_ha_pool_maintenance.py --- @@ -0,0 +1,229 @@ +#!/usr/bin/env python +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# License); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# AS IS BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +from nose.plugins.attrib import attr +from marvin.cloudstackTestCase import cloudstackTestCase +from marvin.cloudstackAPI import (enableStorageMaintenance, + cancelStorageMaintenance + ) +from marvin.lib.utils import (cleanup_resources, + validateList) +from marvin.lib.base import (Account, + VirtualMachine, + ServiceOffering, + Cluster, + StoragePool, + Volume) +from marvin.lib.common import (get_zone, + get_domain, + get_template, + list_hosts + ) +from marvin.codes import PASS + + +def maintenance(self, storageid): +enables maintenance mode of a Storage pool + +cmd = enableStorageMaintenance.enableStorageMaintenanceCmd() +cmd.id = storageid +return self.api_client.enableStorageMaintenance(cmd) + + +def cancelmaintenance(self, storageid): +cancel maintenance mode of a Storage pool + +cmd = cancelStorageMaintenance.cancelStorageMaintenanceCmd() +cmd.id = storageid +return self.api_client.cancelStorageMaintenance(cmd) + + +class testHaPoolMaintenance(cloudstackTestCase): + +@classmethod +def setUpClass(cls): +try: +cls._cleanup = [] +cls.testClient = super( +testHaPoolMaintenance, +cls).getClsTestClient() +cls.api_client = cls.testClient.getApiClient() +cls.services = cls.testClient.getParsedTestDataConfig() +# Get Domain, Zone, Template +cls.domain = get_domain(cls.api_client) +cls.zone = get_zone( +cls.api_client, +cls.testClient.getZoneForTests()) +cls.template = get_template( +cls.api_client, +cls.zone.id, +cls.services[ostype] +) +cls.hypervisor = cls.testClient.getHypervisorInfo() +cls.services['mode'] = cls.zone.networktype +cls.hypervisor = cls.testClient.getHypervisorInfo() +cls.services[virtual_machine][zoneid] = cls.zone.id +cls.services[virtual_machine][template] = cls.template.id +cls.clusterWithSufficientPool = None +clusters = Cluster.list(cls.api_client, zoneid=cls.zone.id) + +if not validateList(clusters)[0]: + +cls.debug( +check list cluster response for zone id %s % +cls.zone.id) + +for cluster in clusters: +cls.pool = StoragePool.list(cls.api_client, +clusterid=cluster.id, +keyword=NetworkFilesystem +) + +if not validateList(cls.pool)[0]: + +cls.debug( +check list cluster response for zone id %s % +cls.zone.id) + +if len(cls.pool) = 2: +cls.clusterWithSufficientPool = cluster +break +if not cls.clusterWithSufficientPool: +return + +cls.services[service_offerings][ +tiny][offerha] = True + +
[GitHub] cloudstack pull request: CLOUDSTACK-8745 : verify usage after root...
Github user ksowmya commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/713#discussion_r37379183 --- Diff: test/integration/component/maint/test_ha_pool_maintenance.py --- @@ -0,0 +1,229 @@ +#!/usr/bin/env python +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# License); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# AS IS BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +from nose.plugins.attrib import attr +from marvin.cloudstackTestCase import cloudstackTestCase +from marvin.cloudstackAPI import (enableStorageMaintenance, + cancelStorageMaintenance + ) +from marvin.lib.utils import (cleanup_resources, + validateList) +from marvin.lib.base import (Account, + VirtualMachine, + ServiceOffering, + Cluster, + StoragePool, + Volume) +from marvin.lib.common import (get_zone, + get_domain, + get_template, + list_hosts + ) +from marvin.codes import PASS + + +def maintenance(self, storageid): +enables maintenance mode of a Storage pool + +cmd = enableStorageMaintenance.enableStorageMaintenanceCmd() +cmd.id = storageid +return self.api_client.enableStorageMaintenance(cmd) + + +def cancelmaintenance(self, storageid): +cancel maintenance mode of a Storage pool + +cmd = cancelStorageMaintenance.cancelStorageMaintenanceCmd() +cmd.id = storageid +return self.api_client.cancelStorageMaintenance(cmd) + + +class testHaPoolMaintenance(cloudstackTestCase): + +@classmethod +def setUpClass(cls): +try: +cls._cleanup = [] +cls.testClient = super( +testHaPoolMaintenance, +cls).getClsTestClient() +cls.api_client = cls.testClient.getApiClient() +cls.services = cls.testClient.getParsedTestDataConfig() +# Get Domain, Zone, Template +cls.domain = get_domain(cls.api_client) +cls.zone = get_zone( +cls.api_client, +cls.testClient.getZoneForTests()) +cls.template = get_template( +cls.api_client, +cls.zone.id, +cls.services[ostype] +) +cls.hypervisor = cls.testClient.getHypervisorInfo() +cls.services['mode'] = cls.zone.networktype +cls.hypervisor = cls.testClient.getHypervisorInfo() +cls.services[virtual_machine][zoneid] = cls.zone.id +cls.services[virtual_machine][template] = cls.template.id +cls.clusterWithSufficientPool = None +clusters = Cluster.list(cls.api_client, zoneid=cls.zone.id) + +if not validateList(clusters)[0]: + +cls.debug( +check list cluster response for zone id %s % +cls.zone.id) + +for cluster in clusters: +cls.pool = StoragePool.list(cls.api_client, +clusterid=cluster.id, +keyword=NetworkFilesystem +) + +if not validateList(cls.pool)[0]: + +cls.debug( +check list cluster response for zone id %s % +cls.zone.id) + +if len(cls.pool) = 2: +cls.clusterWithSufficientPool = cluster +break +if not cls.clusterWithSufficientPool: +return + +cls.services[service_offerings][ +tiny][offerha] = True + +
[GitHub] cloudstack pull request: CLOUDSTACK-8745 : verify usage after root...
Github user ksowmya commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/713#discussion_r37379122 --- Diff: test/integration/component/maint/test_ha_pool_maintenance.py --- @@ -0,0 +1,229 @@ +#!/usr/bin/env python +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# License); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# AS IS BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +from nose.plugins.attrib import attr +from marvin.cloudstackTestCase import cloudstackTestCase +from marvin.cloudstackAPI import (enableStorageMaintenance, + cancelStorageMaintenance + ) +from marvin.lib.utils import (cleanup_resources, + validateList) +from marvin.lib.base import (Account, + VirtualMachine, + ServiceOffering, + Cluster, + StoragePool, + Volume) +from marvin.lib.common import (get_zone, + get_domain, + get_template, + list_hosts + ) +from marvin.codes import PASS + + +def maintenance(self, storageid): +enables maintenance mode of a Storage pool + +cmd = enableStorageMaintenance.enableStorageMaintenanceCmd() +cmd.id = storageid +return self.api_client.enableStorageMaintenance(cmd) + --- End diff -- There are enableMaintenance and cancelMaintenance methods available now directly from StoragePool in base.py. It's better to use that instead of repeating? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-8745 : verify usage after root...
Github user ksowmya commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/713#discussion_r37379467 --- Diff: test/integration/component/maint/test_ha_pool_maintenance.py --- @@ -0,0 +1,229 @@ +#!/usr/bin/env python +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# License); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# AS IS BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +from nose.plugins.attrib import attr +from marvin.cloudstackTestCase import cloudstackTestCase +from marvin.cloudstackAPI import (enableStorageMaintenance, + cancelStorageMaintenance + ) +from marvin.lib.utils import (cleanup_resources, + validateList) +from marvin.lib.base import (Account, + VirtualMachine, + ServiceOffering, + Cluster, + StoragePool, + Volume) +from marvin.lib.common import (get_zone, + get_domain, + get_template, + list_hosts + ) +from marvin.codes import PASS + + +def maintenance(self, storageid): +enables maintenance mode of a Storage pool + +cmd = enableStorageMaintenance.enableStorageMaintenanceCmd() +cmd.id = storageid +return self.api_client.enableStorageMaintenance(cmd) + + +def cancelmaintenance(self, storageid): +cancel maintenance mode of a Storage pool + +cmd = cancelStorageMaintenance.cancelStorageMaintenanceCmd() +cmd.id = storageid +return self.api_client.cancelStorageMaintenance(cmd) + + +class testHaPoolMaintenance(cloudstackTestCase): + +@classmethod +def setUpClass(cls): +try: +cls._cleanup = [] +cls.testClient = super( +testHaPoolMaintenance, +cls).getClsTestClient() +cls.api_client = cls.testClient.getApiClient() +cls.services = cls.testClient.getParsedTestDataConfig() +# Get Domain, Zone, Template +cls.domain = get_domain(cls.api_client) +cls.zone = get_zone( +cls.api_client, +cls.testClient.getZoneForTests()) +cls.template = get_template( +cls.api_client, +cls.zone.id, +cls.services[ostype] +) +cls.hypervisor = cls.testClient.getHypervisorInfo() +cls.services['mode'] = cls.zone.networktype +cls.hypervisor = cls.testClient.getHypervisorInfo() +cls.services[virtual_machine][zoneid] = cls.zone.id +cls.services[virtual_machine][template] = cls.template.id +cls.clusterWithSufficientPool = None +clusters = Cluster.list(cls.api_client, zoneid=cls.zone.id) + +if not validateList(clusters)[0]: + +cls.debug( +check list cluster response for zone id %s % +cls.zone.id) + +for cluster in clusters: +cls.pool = StoragePool.list(cls.api_client, +clusterid=cluster.id, +keyword=NetworkFilesystem +) + +if not validateList(cls.pool)[0]: + +cls.debug( +check list cluster response for zone id %s % +cls.zone.id) + +if len(cls.pool) = 2: +cls.clusterWithSufficientPool = cluster +break +if not cls.clusterWithSufficientPool: +return + +cls.services[service_offerings][ +tiny][offerha] = True + +
[GitHub] cloudstack pull request: CLOUDSTACK-8745 : verify usage after root...
Github user ksowmya commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/713#discussion_r37379515 --- Diff: test/integration/component/maint/test_ha_pool_maintenance.py --- @@ -0,0 +1,229 @@ +#!/usr/bin/env python +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# License); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# AS IS BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +from nose.plugins.attrib import attr +from marvin.cloudstackTestCase import cloudstackTestCase +from marvin.cloudstackAPI import (enableStorageMaintenance, + cancelStorageMaintenance + ) +from marvin.lib.utils import (cleanup_resources, + validateList) +from marvin.lib.base import (Account, + VirtualMachine, + ServiceOffering, + Cluster, + StoragePool, + Volume) +from marvin.lib.common import (get_zone, + get_domain, + get_template, + list_hosts + ) +from marvin.codes import PASS + + +def maintenance(self, storageid): +enables maintenance mode of a Storage pool + +cmd = enableStorageMaintenance.enableStorageMaintenanceCmd() +cmd.id = storageid +return self.api_client.enableStorageMaintenance(cmd) + + +def cancelmaintenance(self, storageid): +cancel maintenance mode of a Storage pool + +cmd = cancelStorageMaintenance.cancelStorageMaintenanceCmd() +cmd.id = storageid +return self.api_client.cancelStorageMaintenance(cmd) + + +class testHaPoolMaintenance(cloudstackTestCase): + +@classmethod +def setUpClass(cls): +try: +cls._cleanup = [] +cls.testClient = super( +testHaPoolMaintenance, +cls).getClsTestClient() +cls.api_client = cls.testClient.getApiClient() +cls.services = cls.testClient.getParsedTestDataConfig() +# Get Domain, Zone, Template +cls.domain = get_domain(cls.api_client) +cls.zone = get_zone( +cls.api_client, +cls.testClient.getZoneForTests()) +cls.template = get_template( +cls.api_client, +cls.zone.id, +cls.services[ostype] +) +cls.hypervisor = cls.testClient.getHypervisorInfo() +cls.services['mode'] = cls.zone.networktype +cls.hypervisor = cls.testClient.getHypervisorInfo() +cls.services[virtual_machine][zoneid] = cls.zone.id +cls.services[virtual_machine][template] = cls.template.id +cls.clusterWithSufficientPool = None +clusters = Cluster.list(cls.api_client, zoneid=cls.zone.id) + +if not validateList(clusters)[0]: + +cls.debug( +check list cluster response for zone id %s % +cls.zone.id) + +for cluster in clusters: +cls.pool = StoragePool.list(cls.api_client, +clusterid=cluster.id, +keyword=NetworkFilesystem +) + +if not validateList(cls.pool)[0]: + +cls.debug( +check list cluster response for zone id %s % +cls.zone.id) + +if len(cls.pool) = 2: +cls.clusterWithSufficientPool = cluster +break +if not cls.clusterWithSufficientPool: +return + +cls.services[service_offerings][ +tiny][offerha] = True + +
[GitHub] cloudstack pull request: CLOUDSTACK-8745 : verify usage after root...
Github user nitt10prashant commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/713#discussion_r37380762 --- Diff: test/integration/component/maint/test_ha_pool_maintenance.py --- @@ -0,0 +1,229 @@ +#!/usr/bin/env python +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# License); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# AS IS BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +from nose.plugins.attrib import attr +from marvin.cloudstackTestCase import cloudstackTestCase +from marvin.cloudstackAPI import (enableStorageMaintenance, + cancelStorageMaintenance + ) +from marvin.lib.utils import (cleanup_resources, + validateList) +from marvin.lib.base import (Account, + VirtualMachine, + ServiceOffering, + Cluster, + StoragePool, + Volume) +from marvin.lib.common import (get_zone, + get_domain, + get_template, + list_hosts + ) +from marvin.codes import PASS + + +def maintenance(self, storageid): +enables maintenance mode of a Storage pool + +cmd = enableStorageMaintenance.enableStorageMaintenanceCmd() +cmd.id = storageid +return self.api_client.enableStorageMaintenance(cmd) + + +def cancelmaintenance(self, storageid): +cancel maintenance mode of a Storage pool + +cmd = cancelStorageMaintenance.cancelStorageMaintenanceCmd() +cmd.id = storageid +return self.api_client.cancelStorageMaintenance(cmd) + + +class testHaPoolMaintenance(cloudstackTestCase): + +@classmethod +def setUpClass(cls): +try: +cls._cleanup = [] +cls.testClient = super( +testHaPoolMaintenance, +cls).getClsTestClient() +cls.api_client = cls.testClient.getApiClient() +cls.services = cls.testClient.getParsedTestDataConfig() +# Get Domain, Zone, Template +cls.domain = get_domain(cls.api_client) +cls.zone = get_zone( +cls.api_client, +cls.testClient.getZoneForTests()) +cls.template = get_template( +cls.api_client, +cls.zone.id, +cls.services[ostype] +) +cls.hypervisor = cls.testClient.getHypervisorInfo() +cls.services['mode'] = cls.zone.networktype +cls.hypervisor = cls.testClient.getHypervisorInfo() +cls.services[virtual_machine][zoneid] = cls.zone.id +cls.services[virtual_machine][template] = cls.template.id +cls.clusterWithSufficientPool = None +clusters = Cluster.list(cls.api_client, zoneid=cls.zone.id) + +if not validateList(clusters)[0]: + +cls.debug( +check list cluster response for zone id %s % +cls.zone.id) + +for cluster in clusters: +cls.pool = StoragePool.list(cls.api_client, +clusterid=cluster.id, +keyword=NetworkFilesystem +) + +if not validateList(cls.pool)[0]: + +cls.debug( +check list cluster response for zone id %s % +cls.zone.id) + +if len(cls.pool) = 2: +cls.clusterWithSufficientPool = cluster +break +if not cls.clusterWithSufficientPool: +return + +cls.services[service_offerings][ +tiny][offerha] = True + +
[GitHub] cloudstack pull request: CLOUDSTACK-8745 : verify usage after root...
Github user nitt10prashant commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/713#discussion_r37380740 --- Diff: test/integration/component/maint/test_ha_pool_maintenance.py --- @@ -0,0 +1,229 @@ +#!/usr/bin/env python +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# License); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# AS IS BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +from nose.plugins.attrib import attr +from marvin.cloudstackTestCase import cloudstackTestCase +from marvin.cloudstackAPI import (enableStorageMaintenance, + cancelStorageMaintenance + ) +from marvin.lib.utils import (cleanup_resources, + validateList) +from marvin.lib.base import (Account, + VirtualMachine, + ServiceOffering, + Cluster, + StoragePool, + Volume) +from marvin.lib.common import (get_zone, + get_domain, + get_template, + list_hosts + ) +from marvin.codes import PASS + + +def maintenance(self, storageid): +enables maintenance mode of a Storage pool + +cmd = enableStorageMaintenance.enableStorageMaintenanceCmd() +cmd.id = storageid +return self.api_client.enableStorageMaintenance(cmd) + + +def cancelmaintenance(self, storageid): +cancel maintenance mode of a Storage pool + +cmd = cancelStorageMaintenance.cancelStorageMaintenanceCmd() +cmd.id = storageid +return self.api_client.cancelStorageMaintenance(cmd) + + +class testHaPoolMaintenance(cloudstackTestCase): + +@classmethod +def setUpClass(cls): +try: +cls._cleanup = [] +cls.testClient = super( +testHaPoolMaintenance, +cls).getClsTestClient() +cls.api_client = cls.testClient.getApiClient() +cls.services = cls.testClient.getParsedTestDataConfig() +# Get Domain, Zone, Template +cls.domain = get_domain(cls.api_client) +cls.zone = get_zone( +cls.api_client, +cls.testClient.getZoneForTests()) +cls.template = get_template( +cls.api_client, +cls.zone.id, +cls.services[ostype] +) +cls.hypervisor = cls.testClient.getHypervisorInfo() +cls.services['mode'] = cls.zone.networktype +cls.hypervisor = cls.testClient.getHypervisorInfo() +cls.services[virtual_machine][zoneid] = cls.zone.id +cls.services[virtual_machine][template] = cls.template.id +cls.clusterWithSufficientPool = None +clusters = Cluster.list(cls.api_client, zoneid=cls.zone.id) + +if not validateList(clusters)[0]: + +cls.debug( +check list cluster response for zone id %s % +cls.zone.id) + +for cluster in clusters: +cls.pool = StoragePool.list(cls.api_client, +clusterid=cluster.id, +keyword=NetworkFilesystem +) + +if not validateList(cls.pool)[0]: + +cls.debug( +check list cluster response for zone id %s % +cls.zone.id) + +if len(cls.pool) = 2: +cls.clusterWithSufficientPool = cluster +break +if not cls.clusterWithSufficientPool: +return + +cls.services[service_offerings][ +tiny][offerha] = True + +
[GitHub] cloudstack pull request: CLOUDSTACK-8745 : verify usage after root...
Github user ksowmya commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/713#discussion_r37381494 --- Diff: test/integration/component/maint/test_ha_pool_maintenance.py --- @@ -0,0 +1,229 @@ +#!/usr/bin/env python +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# License); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# AS IS BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +from nose.plugins.attrib import attr +from marvin.cloudstackTestCase import cloudstackTestCase +from marvin.cloudstackAPI import (enableStorageMaintenance, + cancelStorageMaintenance + ) +from marvin.lib.utils import (cleanup_resources, + validateList) +from marvin.lib.base import (Account, + VirtualMachine, + ServiceOffering, + Cluster, + StoragePool, + Volume) +from marvin.lib.common import (get_zone, + get_domain, + get_template, + list_hosts + ) +from marvin.codes import PASS + + +def maintenance(self, storageid): +enables maintenance mode of a Storage pool + +cmd = enableStorageMaintenance.enableStorageMaintenanceCmd() +cmd.id = storageid +return self.api_client.enableStorageMaintenance(cmd) + + +def cancelmaintenance(self, storageid): +cancel maintenance mode of a Storage pool + +cmd = cancelStorageMaintenance.cancelStorageMaintenanceCmd() +cmd.id = storageid +return self.api_client.cancelStorageMaintenance(cmd) + + +class testHaPoolMaintenance(cloudstackTestCase): + +@classmethod +def setUpClass(cls): +try: +cls._cleanup = [] +cls.testClient = super( +testHaPoolMaintenance, +cls).getClsTestClient() +cls.api_client = cls.testClient.getApiClient() +cls.services = cls.testClient.getParsedTestDataConfig() +# Get Domain, Zone, Template +cls.domain = get_domain(cls.api_client) +cls.zone = get_zone( +cls.api_client, +cls.testClient.getZoneForTests()) +cls.template = get_template( +cls.api_client, +cls.zone.id, +cls.services[ostype] +) +cls.hypervisor = cls.testClient.getHypervisorInfo() +cls.services['mode'] = cls.zone.networktype +cls.hypervisor = cls.testClient.getHypervisorInfo() +cls.services[virtual_machine][zoneid] = cls.zone.id +cls.services[virtual_machine][template] = cls.template.id +cls.clusterWithSufficientPool = None +clusters = Cluster.list(cls.api_client, zoneid=cls.zone.id) + +if not validateList(clusters)[0]: + +cls.debug( +check list cluster response for zone id %s % +cls.zone.id) + +for cluster in clusters: +cls.pool = StoragePool.list(cls.api_client, +clusterid=cluster.id, +keyword=NetworkFilesystem +) + +if not validateList(cls.pool)[0]: + +cls.debug( +check list cluster response for zone id %s % +cls.zone.id) + +if len(cls.pool) = 2: +cls.clusterWithSufficientPool = cluster +break +if not cls.clusterWithSufficientPool: +return + +cls.services[service_offerings][ +tiny][offerha] = True + +
