[GitHub] cloudstack pull request: CLOUDSTACK-8968: UI icon over VM snapshot...

[rhtyd]

Github user rhtyd commented on the pull request:

https://github.com/apache/cloudstack/pull/1320#issuecomment-216220179
  
@nitin-maharana please rebase and share screenshots of what this fixes

A manual UI testing would be needed


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8968: UI icon over VM snapshot...

[swill]

Github user swill commented on the pull request:

https://github.com/apache/cloudstack/pull/1320#issuecomment-215554347
  
@nitin-maharana please rebase as we currently have merge conflicts.  
Thanks...


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8968: UI icon over VM snapshot...

[rodrigo93]

Github user rodrigo93 commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1320#discussion_r52106924
  
--- Diff: ui/scripts/instanceWizard.js ---
@@ -294,53 +295,67 @@
 
 // Step 3: Service offering
 function(args) {
-selectedTemplateObj = null; //reset
-if (args.currentData["select-template"] == 
"select-template") {
-if (featuredTemplateObjs != null && 
featuredTemplateObjs.length > 0) {
-for (var i = 0; i < featuredTemplateObjs.length; 
i++) {
-if (featuredTemplateObjs[i].id == 
args.currentData.templateid) {
-selectedTemplateObj = 
featuredTemplateObjs[i];
-break;
+snapshotObjs = null;
+selectedSnapshotObj = null;
+
+if (args.moreArgs && args.moreArgs.snapshot)
+{
+zoneObjs = args.moreArgs.zone;
+selectedZoneObj = zoneObjs[0];
+hypervisorObjs = args.moreArgs.hypervisor;
+selectedHypervisor = hypervisorObjs[0].name;
+snapshotObjs = args.moreArgs.snapshot;
+selectedSnapshotObj = snapshotObjs[0];
+}
+else {
+selectedTemplateObj = null; //reset
+if (args.currentData["select-template"] == 
"select-template") {
+if (featuredTemplateObjs != null && 
featuredTemplateObjs.length > 0) {
+for (var i = 0; i < 
featuredTemplateObjs.length; i++) {
+if (featuredTemplateObjs[i].id == 
args.currentData.templateid) {
+selectedTemplateObj = 
featuredTemplateObjs[i];
+break;
+}
 }
 }
-}
-if (selectedTemplateObj == null) {
-if (communityTemplateObjs != null && 
communityTemplateObjs.length > 0) {
-for (var i = 0; i < 
communityTemplateObjs.length; i++) {
-if (communityTemplateObjs[i].id == 
args.currentData.templateid) {
-selectedTemplateObj = 
communityTemplateObjs[i];
-break;
+if (selectedTemplateObj == null) {
--- End diff --

Hi @nitin-maharana 
Couldn't this _if_ and the following _ifs_ be merged into one? 
Like:

> if ( selectedTemplateObj == null && communityTemplateObjs != null && 
communityTemplateObjs.length > 0)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8968: UI icon over VM snapshot...

[nitin-maharana]

Github user nitin-maharana commented on the pull request:

https://github.com/apache/cloudstack/pull/1150#issuecomment-169931078
  
Closing this PR as made a new PR #1320 (Against 4.7 which will be merged in 
master later).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8968: UI icon over VM snapshot...

[nitin-maharana]

Github user nitin-maharana closed the pull request at:

https://github.com/apache/cloudstack/pull/1150


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8968: UI icon over VM snapshot...

[nitin-maharana]

GitHub user nitin-maharana opened a pull request:

https://github.com/apache/cloudstack/pull/1320

CLOUDSTACK-8968: UI icon over VM snapshot to deploy user instance

Added a new Icon in Instance page to launch the VM from the snapshot.

A new icon over VM snapshot object, which upon invoked will open a deploy 
user instance wizard, where there is no choice to choose zone and ISO or 
template to deploy the user instance from.

1) A new icon to indicate deploy user instance from VM snapshot
2) The new icon is placed as an operation over each VM snapshot object.
3) Clicking this icon will show the wizard to deploy user instance, which 
is same as wizard for normal user instance except that zone selection page and 
ISO/template selection page would not be present in this wizard.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/nitin-maharana/CloudStack 
CloudStack-Nitin12_4.7

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/1320.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1320


commit 55183fd81804e41f9fa8e335a3282ef42e536af7
Author: Nitin Kumar Maharana 
Date:   2015-12-07T18:14:37Z

CLOUDSTACK-8968: UI icon over VM snapshot to deploy user instance

Added a new Icon in Instance page to launch the VM from the snapshot.
Only supports in case of VMware.

Conflicts:
client/WEB-INF/classes/resources/messages.properties




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8968: UI icon over VM snapshot...

[nitin-maharana]

Github user nitin-maharana commented on the pull request:

https://github.com/apache/cloudstack/pull/1320#issuecomment-169931271
  
Reference PR #1150 (Against 4.6). This PR (against 4.7) contains the same 
code change with one conflict which I resolved.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8968: UI icon over VM snapshot...

[remibergsma]

Github user remibergsma commented on the pull request:

https://github.com/apache/cloudstack/pull/1150#issuecomment-168136764
  
Sorry I have no vmware setup to test this. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8968: UI icon over VM snapshot...

[nitin-maharana]

Github user nitin-maharana commented on the pull request:

https://github.com/apache/cloudstack/pull/1150#issuecomment-168115562
  
@remibergsma : Any updates on this? Can you please look at the change if 
you have a setup. Thanks.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8968: UI icon over VM snapshot...

[bhaisaab]

Github user bhaisaab commented on the pull request:

https://github.com/apache/cloudstack/pull/1150#issuecomment-168075565
  
@nitin-maharana sorry don't have the infra to setup vmware and test right 
now, so cannot help test it


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8968: UI icon over VM snapshot...

[nitin-maharana]

Github user nitin-maharana commented on the pull request:

https://github.com/apache/cloudstack/pull/1150#issuecomment-167931844
  
cc @bhaisaab 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8968: UI icon over VM snapshot...

[nitin-maharana]

Github user nitin-maharana commented on the pull request:

https://github.com/apache/cloudstack/pull/1150#issuecomment-164514502
  
Step-1:
=

![pr_1150_ss1_nitin](https://cloud.githubusercontent.com/assets/12583725/11789386/1d14793c-a2bc-11e5-9184-f16b84af91f4.png)

Step-2:
=
Skipped 1st and 2nd steps


![pr_1150_ss2_nitin](https://cloud.githubusercontent.com/assets/12583725/11789434/636162f6-a2bc-11e5-8746-5fd2411803df.png)

Step-3:
=
Last step


![pr_1150_ss3_nitin](https://cloud.githubusercontent.com/assets/12583725/11789449/7404f2ee-a2bc-11e5-8bc7-b196a1bae76d.png)





---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8968: UI icon over VM snapshot...

[remibergsma]

Github user remibergsma commented on the pull request:

https://github.com/apache/cloudstack/pull/1150#issuecomment-162485224
  
Hmm.. this isn't supported on KVM, is it? That may be why I can't find it.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8968: UI icon over VM snapshot...

[remibergsma]

Github user remibergsma commented on the pull request:

https://github.com/apache/cloudstack/pull/1150#issuecomment-162484701
  
@nitin-maharana @bhaisaab I looked around but just don't find what's 
changed. Please post screenshots of what is changed or instruct exactly how it 
should work. Thanks!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8968: UI icon over VM snapshot...

[nitin-maharana]

Github user nitin-maharana commented on the pull request:

https://github.com/apache/cloudstack/pull/1150#issuecomment-162612180
  
@bhaisaab @DaanHoogland I updated the change with current 4.6 branch and 
removed the commented codes. @remibergsma This only supports in VMware. Thanks 
:) 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8968: UI icon over VM snapshot...

[DaanHoogland]

Github user DaanHoogland commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1150#discussion_r46775285
  
--- Diff: ui/scripts/instanceWizard.js ---
@@ -731,25 +746,33 @@
 
 //step 1 : select zone
 $.extend(deployVmData, {
-zoneid : args.data.zoneid
+zoneid : selectedZoneObj.id
 });
 
 //step 2: select template
-$.extend(deployVmData, {
-templateid : args.data.templateid
-});
+if (snapshotObjs) {
+$.extend(deployVmData, {
+vmsnapshotid : selectedSnapshotObj.id
+});
+}
+else {
+$.extend(deployVmData, {
+templateid : args.data.templateid
+});
+}
 
 $.extend(deployVmData, {
 hypervisor : selectedHypervisor
 });
 
-if 
(args.$wizard.find('input[name=rootDiskSize]').parent().css('display') != 
'none')  {
-if 
(args.$wizard.find('input[name=rootDiskSize]').val().length > 0) {
-$.extend(deployVmData, {
-rootdisksize : 
args.$wizard.find('input[name=rootDiskSize]').val()
-});
-}
-}
+//Currently it is not supporting in backend
+//if 
(args.$wizard.find('input[name=rootDiskSize]').parent().css('display') != 
'none')  {
--- End diff --

please do not leave code commented in. this block should be deleted.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8968: UI icon over VM snapshot...

[bhaisaab]

Github user bhaisaab commented on the pull request:

https://github.com/apache/cloudstack/pull/1150#issuecomment-162416679
  
@nitin-maharana if you can address what Daan has commented today, along 
with fix tabs with spaces (if any) I can help review this and merge this; 
before 4.7.0/master freeze is announced today.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8968: UI icon over VM snapshot...

[nitin-maharana]

GitHub user nitin-maharana opened a pull request:

https://github.com/apache/cloudstack/pull/1150

CLOUDSTACK-8968: UI icon over VM snapshot to deploy user instance

Added a new Icon in Instance page to launch the VM from the snapshot.

A new icon over VM snapshot object, which upon invoked will open a deploy 
user instance wizard, where there is no choice to choose zone and ISO or 
template to deploy the user instance from.

1) A new icon to indicate deploy user instance from VM snapshot
2) The new icon is placed as an operation over each VM snapshot object.
3) Clicking this icon will show the wizard to deploy user instance, which 
is same as wizard for normal user instance except that zone selection page and 
ISO/template selection page would not be present in this wizard.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/nitin-maharana/CloudStack CloudStack-Nitin12

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/1150.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1150


commit 0fddcc663e201edaff7ed80eb09cf2e1197ae08c
Author: Nitin Kumar Maharana 
Date:   2015-10-19T19:07:56Z

CLOUDSTACK-8968: UI icon over VM snapshot to deploy user instance

Added a new Icon in Instance page to launch the VM from the snapshot.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8968: UI icon over VM snapshot...

[nitin-maharana]

Github user nitin-maharana commented on the pull request:

https://github.com/apache/cloudstack/pull/953#issuecomment-161262674
  
Made a pull request to merge in 4.6. So closing this PR. Thanks.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8968: UI icon over VM snapshot...

[nitin-maharana]

Github user nitin-maharana closed the pull request at:

https://github.com/apache/cloudstack/pull/953


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8968: UI icon over VM snapshot...

[remibergsma]

Github user remibergsma commented on the pull request:

https://github.com/apache/cloudstack/pull/953#issuecomment-150836024
  
Hi @nitin-maharana can you please rebase with current master? I'd like to 
test your patch. Thanks!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8968: UI icon over VM snapshot...

[nitin-maharana]

Github user nitin-maharana commented on the pull request:

https://github.com/apache/cloudstack/pull/953#issuecomment-150837653
  
Sure @remibergsma I will do that. Thank you.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8968: UI icon over VM snapshot...

[nitin-maharana]

GitHub user nitin-maharana opened a pull request:

https://github.com/apache/cloudstack/pull/953

CLOUDSTACK-8968: UI icon over VM snapshot to deploy user instance

Added a new Icon in Instance page to launch the VM from the snapshot.

A new icon over VM snapshot object, which upon invoked will open a deploy 
user instance wizard, where there is no choice to choose zone and ISO or 
template to deploy the user instance from.

1) A new icon to indicate deploy user instance from VM snapshot
2) The new icon is placed as an operation over each VM snapshot object.
3) Clicking this icon will show the wizard to deploy user instance, which 
is same as wizard for normal user instance except that zone selection page and 
ISO/template selection page would not be present in this wizard.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/nitin-maharana/cloudstack CloudStack-Nitin12

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/953.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #953


commit 0411f9dd0c68039dbdfd84c0f75d5ff7e4e1b269
Author: Nitin Kumar Maharana 
Date:   2015-10-19T19:07:56Z

CLOUDSTACK-8968: UI icon over VM snapshot to deploy user instance

Added a new Icon in Instance page to launch the VM from the snapshot.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---