[GitHub] cloudstack pull request: CLOUDSTACK-8970 Centos 6.{1,2,3,4,5} gues...
Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/956 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-8970 Centos 6.{1,2,3,4,5} gues...
Github user pdion891 commented on the pull request: https://github.com/apache/cloudstack/pull/956#issuecomment-219820531 @DaanHoogland to automatically have support for those OSes ? unless we should have a script that auto populate Oses mapping thru the API instead of preinserting data into the database. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-8970 Centos 6.{1,2,3,4,5} gues...
Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/956#issuecomment-219816935 Why would we need this? https://cloudstack.apache.org/api/apidocs-4.8/root_admin/addGuestOsMapping.html Ypu can add an guest os to hypervisormapping on runtime --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-8970 Centos 6.{1,2,3,4,5} gues...
Github user pdion891 commented on the pull request: https://github.com/apache/cloudstack/pull/956#issuecomment-219816849 LGTM, unfortunately there is not way on our side to tests this :-S because it require VMware host. but inserts are similar to previous from previous releases. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-8970 Centos 6.{1,2,3,4,5} gues...
Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/956#issuecomment-219802208 I have no way to test this and no one has verification of this from what I can tell. Otherwise it is ready to go... I may have to make a judgement call on this one for 4.9. Thoughts? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-8970 Centos 6.{1,2,3,4,5} gues...
Github user SudharmaJain commented on the pull request: https://github.com/apache/cloudstack/pull/956#issuecomment-219617936 Rebased and pushed the branch. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-8970 Centos 6.{1,2,3,4,5} gues...
Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/956#issuecomment-219538622 @SudharmaJain can you rebase and push to see if we can get this green for the 4.9 freeze... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-8970 Centos 6.{1,2,3,4,5} gues...
Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/956#issuecomment-219130130 @SudharmaJain can you re-push or close and reopen this PR to kick off Jenkins again? @rhtyd and @nvazquez I know you both use VMware. I don't have a way to validate this PR, so can you give me your opinion on if this should be merged without validation or can either of you validate this PR in your environment and give me a verbal OK? Since I don't have a way to test this, I want some verification from someone who is affected by this PR. Thx... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-8970 Centos 6.{1,2,3,4,5} gues...
Github user abhinandanprateek commented on the pull request: https://github.com/apache/cloudstack/pull/956#issuecomment-218978117 @SudharmaJain it is a unit test failure triggered by an assert. cc @rhtyd It is being generated by ProcessRunner. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-8970 Centos 6.{1,2,3,4,5} gues...
Github user SudharmaJain commented on the pull request: https://github.com/apache/cloudstack/pull/956#issuecomment-218960573 Getting following error with Jenkins Running org.apache.cloudstack.utils.hypervisor.HypervisorUtilsTest Testing don't block on newly created clones - pass Testing block on modified files - pass Testing timeout of blocking on modified files - pass Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 5.272 sec - in org.apache.cloudstack.utils.hypervisor.HypervisorUtilsTest Running org.apache.cloudstack.utils.imagestore.ImageStoreUtilTest Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.057 sec - in org.apache.cloudstack.utils.imagestore.ImageStoreUtilTest Running org.apache.cloudstack.utils.process.ProcessTest Tests run: 4, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 301.061 sec <<< FAILURE! - in org.apache.cloudstack.utils.process.ProcessTest testProcessRunner(org.apache.cloudstack.utils.process.ProcessTest) Time elapsed: 300.038 sec <<< FAILURE! java.lang.AssertionError: expected:<-1> but was:<0> at org.junit.Assert.fail(Assert.java:88) at org.junit.Assert.failNotEquals(Assert.java:834) at org.junit.Assert.assertEquals(Assert.java:645) at org.junit.Assert.assertEquals(Assert.java:631) at org.apache.cloudstack.utils.process.ProcessTest.testProcessRunner(ProcessTest.java:43) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-8970 Centos 6.{1,2,3,4,5} gues...
Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/956#issuecomment-218836777 Thank you @SudharmaJain. Is there anything you can provide to show this works as expected? Screenshots or something? I don't have the ability to CI this, so it would be awesome if we could get some sort of verification that this is working. Are you running this in production somewhere? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-8970 Centos 6.{1,2,3,4,5} gues...
Github user SudharmaJain commented on the pull request: https://github.com/apache/cloudstack/pull/956#issuecomment-218830874 @swill Rebased against master. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-8970 Centos 6.{1,2,3,4,5} gues...
Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/956#issuecomment-218806800 @SudharmaJain please rebase as we now have merge conflicts. Ideally we would have some verification that this works as expected. I don't have the ability to test this. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-8970 Centos 6.{1,2,3,4,5} gues...
Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/956#issuecomment-218362729 Can someone with a VMware environment validate this PR is functional? I don't think running CI is going to give us anything on this one since I only have KVM and this is only a DB change. Thoughts??? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-8970 Centos 6.{1,2,3,4,5} gues...
Github user SudharmaJain commented on the pull request: https://github.com/apache/cloudstack/pull/956#issuecomment-218362347 Rebased and pushed it again. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-8970 Centos 6.{1,2,3,4,5} gues...
Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/956#issuecomment-218057646 Thanks @SudharmaJain. I will get someone to look into this. @DaanHoogland do you or @pdion891 have access to this box to clean up the disk space so it is functional again? I am not sure who had access to these boxes... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-8970 Centos 6.{1,2,3,4,5} gues...
Github user SudharmaJain commented on the pull request: https://github.com/apache/cloudstack/pull/956#issuecomment-218056032 @swill I force pushed again and still it is failing. In logs I see following error. fatal: write error: No space left on device --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-8970 Centos 6.{1,2,3,4,5} gues...
Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/956#issuecomment-217471716 Can you do a force push again. Jenkins has been in this state for 3 days now. Thx... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-8970 Centos 6.{1,2,3,4,5} gues...
Github user rhtyd commented on the pull request: https://github.com/apache/cloudstack/pull/956#issuecomment-216199303 @SudharmaJain please rebase against master and push -f, and update on status of your PR, thanks LGTM tag:easypr --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-8970 Centos 6.{1,2,3,4,5} gues...
Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/956#issuecomment-215451916 Do we have any verification that this does what it is supposed to? It would be good if we could get some form of verification posted that this behaves as expected. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-8970 Centos 6.{1,2,3,4,5} gues...
Github user koushik-das commented on the pull request: https://github.com/apache/cloudstack/pull/956#issuecomment-215364487 Changes LGTM. @swill This can be merged. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-8970 Centos 6.{1,2,3,4,5} gues...
Github user SudharmaJain commented on the pull request: https://github.com/apache/cloudstack/pull/956#issuecomment-212718578 @bhaisaab Thanks for the comment. I have updated with the latest now. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-8970 Centos 6.{1,2,3,4,5} gues...
Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/956#issuecomment-212474106 @SudharmaJain The provided version have already released so these change need to go into 481to490 related sql /cc @swill any vmware/guest-os-mapping guru want to comment on the changes -- @anshulgangwar @devdeep @agneya2001 @koushik-das @sureshanaparti --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-8970 Centos 6.{1,2,3,4,5} gues...
Github user SudharmaJain commented on the pull request: https://github.com/apache/cloudstack/pull/956#issuecomment-212416597 @bhaisaab Rebased against master. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-8970 Centos 6.{1,2,3,4,5} gues...
Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/956#issuecomment-175673522 @SudharmaJain please rebase against latest --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-8970 Centos 6.{1,2,3,4,5} gues...
Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/956#issuecomment-153684702 LGTM, @abhinandanprateek do you have any comments? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-8970 Centos 6.{1,2,3,4,5} gues...
Github user snuf commented on the pull request: https://github.com/apache/cloudstack/pull/956#issuecomment-150176025 Values are inline with the guest_os table and inserts the inserts all work so LGTM! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
