[GitHub] cloudstack pull request: CLOUDSTACK-9001: Modifying snapshot resul...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/cloudstack/pull/994


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9001: Modifying snapshot resul...

[pvr9711]

Github user pvr9711 commented on the pull request:

https://github.com/apache/cloudstack/pull/994#issuecomment-166879847
  
@remibergsma can you please merge this in?  thanks, Raja


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9001: Modifying snapshot resul...

[DaanHoogland]

Github user DaanHoogland commented on the pull request:

https://github.com/apache/cloudstack/pull/994#issuecomment-153301418
  
this has two lgtm but no report of tests executed. As this is only test 
code I'll recreate an environment and give it a spin.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9001: Modifying snapshot resul...

[nitt10prashant]

Github user nitt10prashant commented on the pull request:

https://github.com/apache/cloudstack/pull/994#issuecomment-153285936
  
LGTM based on code review.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9001: Modifying snapshot resul...

[pritisarap12]

Github user pritisarap12 commented on the pull request:

https://github.com/apache/cloudstack/pull/994#issuecomment-153302400
  
Test Result:

Test events table ... === TestName: test_01_verify_events_table | Status : 
SUCCESS ===
ok

--
Ran 1 test in 86.360s

OK



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: [GitHub] cloudstack pull request: CLOUDSTACK-9001: Modifying snapshot resul...

[Sanjeev N]

This is very small change related to list validation and it looks good.

LGTM!!

On Wed, Oct 28, 2015 at 11:28 AM, bhaisaab  wrote:

> Github user bhaisaab commented on the pull request:
>
> https://github.com/apache/cloudstack/pull/994#issuecomment-151733973
>
> Officially we're over 9000 :)
>
>
> ---
> If your project is set up for it, you can reply to this email and have your
> reply appear on GitHub as well. If your project does not have this feature
> enabled and wishes so, or if the feature is enabled but not working, please
> contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
> with INFRA.
> ---
>

[GitHub] cloudstack pull request: CLOUDSTACK-9001: Modifying snapshot resul...

[pritisarap12]

GitHub user pritisarap12 opened a pull request:

https://github.com/apache/cloudstack/pull/994

CLOUDSTACK-9001: Modifying snapshot results validation 

Currently snapshots results validation is based on length of snapshot 
result but if snapshot creation fails then None type object will not have "len" 
attribute hence modifying the validation.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/pritisarap12/cloudstack 
snapshot-has-no-attribute-len

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/994.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #994


commit 0e01c7f357cd6596570fd966e0f2ac65c4bbedb1
Author: Priti Sarap 
Date:   2015-10-28T05:49:36Z

CLOUDSTACK-9001: Modifying snapshot results validation in 
testpath_uuid_event testpath




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9001: Modifying snapshot resul...

[bhaisaab]

Github user bhaisaab commented on the pull request:

https://github.com/apache/cloudstack/pull/994#issuecomment-151733973
  
Officially we're over 9000 :)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---