[GitHub] cloudstack pull request: CLOUDSTACK-9005: Modifying tearDown funct...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/cloudstack/pull/1000


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9005: Modifying tearDown funct...

[pvr9711]

Github user pvr9711 commented on the pull request:

https://github.com/apache/cloudstack/pull/1000#issuecomment-166879646
  
@remibergsma can you please merge this in?  thanks, Raja


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9005: Modifying tearDown funct...

[bhaisaab]

Github user bhaisaab commented on the pull request:

https://github.com/apache/cloudstack/pull/1000#issuecomment-153683247
  
LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9005: Modifying tearDown funct...

[nitt10prashant]

Github user nitt10prashant commented on the pull request:

https://github.com/apache/cloudstack/pull/1000#issuecomment-153287076
  
LGTM  Based on code understanding

One line change  if attribute is there then proceed to cleanup  if 
hasattr(self, "data_volume_created"): 
 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9005: Modifying tearDown funct...

[pritisarap12]

Github user pritisarap12 commented on the pull request:

https://github.com/apache/cloudstack/pull/1000#issuecomment-153302753
  
Test Result:

Storage and Snapshot Limit ...
--
Ran 1 test in 970.317s

OK




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9005: Modifying tearDown funct...

[DaanHoogland]

Github user DaanHoogland commented on the pull request:

https://github.com/apache/cloudstack/pull/1000#issuecomment-153301936
  
2 lgtm but no test report, will execute


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: [GitHub] cloudstack pull request: CLOUDSTACK-9005: Modifying tearDown funct...

[Sanjeev N]

I looked at the changes Priti has done in this PR. It looks good to me.
LGTM!!

On Thu, Oct 29, 2015 at 11:00 AM, pritisarap12  wrote:

> GitHub user pritisarap12 opened a pull request:
>
> https://github.com/apache/cloudstack/pull/1000
>
> CLOUDSTACK-9005: Modifying tearDown function
>
> Modifying tearDown function to check if data volume is in detached
> state before deleting the volume
>
>
> You can merge this pull request into a Git repository by running:
>
> $ git pull https://github.com/pritisarap12/cloudstack
> CLOUDSTACK-9005-Modifying-tearDown-function
>
> Alternatively you can review and apply these changes as the patch at:
>
> https://github.com/apache/cloudstack/pull/1000.patch
>
> To close this pull request, make a commit to your master/trunk branch
> with (at least) the following in the commit message:
>
> This closes #1000
>
> 
> commit d793c7f50ff56a3ecdd6c8862df1ee67ebcc9ac4
> Author: Priti Sarap 
> Date:   2015-10-29T05:28:15Z
>
> CLOUDSTACK-9005: Modifying tearDown function
>
> 
>
>
> ---
> If your project is set up for it, you can reply to this email and have your
> reply appear on GitHub as well. If your project does not have this feature
> enabled and wishes so, or if the feature is enabled but not working, please
> contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
> with INFRA.
> ---
>