[GitHub] cloudstack pull request: CLOUDSTACK-9050 Virtual router should onl...
Github user dsclose closed the pull request at: https://github.com/apache/cloudstack/pull/1063 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-9050 Virtual router should onl...
Github user dsclose commented on the pull request: https://github.com/apache/cloudstack/pull/1063#issuecomment-157678223 CLosing this pull request as the patched script is already deprecated. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-9050 Virtual router should onl...
Github user borisroman commented on the pull request: https://github.com/apache/cloudstack/pull/1063#issuecomment-156414832 @DaanHoogland That's already being done by @wilderrodrigues. Therefore this one is obsolete. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-9050 Virtual router should onl...
Github user wilderrodrigues commented on the pull request: https://github.com/apache/cloudstack/pull/1063#issuecomment-156368254 @ustcweizhou @dsclose Dude, this script is not used anymore! Please test it with maven, or manually, and you will see that it doesn't apply. The only place the file is reference is here ==>  It should have been removed with the Routers Persistent Configuration / Redundant VPCs. I'm glad to help to get the fix in the right place, but please test against 4.6.0/master using a 4.6.0 SystemVM. Cheers, Wilder --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-9050 Virtual router should onl...
Github user wilderrodrigues commented on the pull request: https://github.com/apache/cloudstack/pull/1063#issuecomment-156382390 @dsclose Scripts not in use since 4.6.0: ``` public static final String FIREWALL_EGRESS = "firewall_egress.sh"; public static final String IPASSOC = "ipassoc.sh"; public static final String VMDATA = "vmdata.py"; public static final String VPC_ACL = "vpc_acl.sh"; public static final String VPC_GUEST_NETWORK = "vpc_guestnw.sh"; public static final String VPC_PRIVATEGW_ACL = "vpc_privategw_acl.sh"; public static final String VPC_STATIC_NAT = "vpc_staticnat.sh"; public static final String VPC_STATIC_ROUTE = "vpc_staticroute.sh"; public static final String S2SVPN_IPSEC = "ipsectunnel.sh"; public static final String DHCP = "edithosts.sh"; public static final String DNSMASQ_CONFIG = "dnsmasq.sh"; public static final String FIREWALL_INGRESS = "firewall_ingress.sh"; public static final String FIREWALL_NAT = "firewall_nat.sh"; public static final String IPALIAS_CREATE = "createipAlias.sh"; public static final String IPALIAS_DELETE = "deleteipAlias.sh"; public static final String LB = "loadbalancer.sh"; public static final String MONITOR_SERVICE = "monitor_service.sh"; public static final String PASSWORD = "savepassword.sh"; public static final String VPC_IPASSOC = "vpc_ipassoc.sh"; public static final String VPC_LB = "vpc_loadbalancer.sh"; public static final String VPC_PRIVATEGW = "vpc_privateGateway.sh"; public static final String VPC_PORTFORWARDING = "vpc_portforwarding.sh"; public static final String VPC_SOURCE_NAT = "vpc_snat.sh"; public static final String VPN_L2TP = "vpn_l2tp.sh"; ``` I will remove all of them from the project to avoid misunderstands. Cheers, Wilder --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-9050 Virtual router should onl...
Github user wilderrodrigues commented on the pull request: https://github.com/apache/cloudstack/pull/1063#issuecomment-156379177 @dsclose, please have a look at: ``` ./cloud-systemvm/patches/debian/config/opt/cloud/bin/configure.py ``` Cheers, Wilder --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-9050 Virtual router should onl...
Github user borisroman commented on the pull request: https://github.com/apache/cloudstack/pull/1063#issuecomment-156384240 @dsclose Thanks for your PR, it shows support! As the script is not in use anymore, would you close the PR? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-9050 Virtual router should onl...
Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1063#issuecomment-15648 @borisroman @dsclose how about changing it to a pr that removes the script ;) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-9050 Virtual router should onl...
Github user ustcweizhou commented on the pull request: https://github.com/apache/cloudstack/pull/1063#issuecomment-156118661 LGTM the similar issue happened several times in our scripts. We should use more precise expression when we use sed/grep, etc --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-9050 Virtual router should onl...
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/1063#issuecomment-156119598 @wilderrodrigues Are these scripts still used in master/4.6? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
