[GitHub] cloudstack pull request: CLOUDSTACK-9092: L10n fix in "Add LDAP Ac...

[bhaisaab]

Github user bhaisaab commented on the pull request:

https://github.com/apache/cloudstack/pull/1139#issuecomment-160908402
  
LGTM.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9092: L10n fix in "Add LDAP Ac...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/cloudstack/pull/1139


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9092: L10n fix in "Add LDAP Ac...

[milamberspace]

Github user milamberspace commented on the pull request:

https://github.com/apache/cloudstack/pull/1139#issuecomment-160591699
  
Not tested, but code is good.
LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9092: L10n fix in "Add LDAP Ac...

[harikrishna-patnala]

Github user harikrishna-patnala commented on the pull request:

https://github.com/apache/cloudstack/pull/1139#issuecomment-160531359
  
Looks good to me


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9092: L10n fix in "Add LDAP Ac...

[karuturi]

GitHub user karuturi opened a pull request:

https://github.com/apache/cloudstack/pull/1139

CLOUDSTACK-9092: L10n fix in "Add LDAP Account page"

fixed two strings on the "Add LDAP Account page"

After the change: (with a test string in messages_ja_JP.properties file)
![screen shot 2015-11-30 at 11 07 42 
am](https://cloud.githubusercontent.com/assets/186833/11464468/213f0f4e-9755-11e5-85b3-1cc6a89895c1.png)


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/karuturi/cloudstack CLOUDSTACK-9092

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/1139.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1139


commit d6af6adbad707ab378098decca47d8f5e4012872
Author: Rajani Karuturi 
Date:   2015-11-30T05:51:17Z

CLOUDSTACK-9092: L10n fix in "Add LDAP Account page"

fixed two strings on the "Add LDAP Account page"




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---