[GitHub] cloudstack pull request: Reimplement router.redundant.vrrp.interva...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/cloudstack/pull/1486


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Reimplement router.redundant.vrrp.interva...

[GabrielBrascher]

Github user GabrielBrascher commented on the pull request:

https://github.com/apache/cloudstack/pull/1486#issuecomment-219561259
  
Based on code review and the documentation cited by @remibergsma, the code 
LGTM.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Reimplement router.redundant.vrrp.interva...

[swill]

Github user swill commented on the pull request:

https://github.com/apache/cloudstack/pull/1486#issuecomment-219541268
  
This one is ready to merge.  I would love another code review on this one 
as it is green and the CI is clean...


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Reimplement router.redundant.vrrp.interva...

[swill]

Github user swill commented on the pull request:

https://github.com/apache/cloudstack/pull/1486#issuecomment-219160164
  
Ok, we need one more review on this.

tag:needsreview tag:needreview


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Reimplement router.redundant.vrrp.interva...

[DaanHoogland]

Github user DaanHoogland commented on the pull request:

https://github.com/apache/cloudstack/pull/1486#issuecomment-219157668
  
LGTM, tag:easypr


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Reimplement router.redundant.vrrp.interva...

[swill]

Github user swill commented on the pull request:

https://github.com/apache/cloudstack/pull/1486#issuecomment-219082129
  
This one is looking pretty good.  Can we get some code review on it so we 
can move it forward.  Thanks...


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Reimplement router.redundant.vrrp.interva...

[remibergsma]

Github user remibergsma commented on the pull request:

https://github.com/apache/cloudstack/pull/1486#issuecomment-219031280
  
Resolved conflict


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Reimplement router.redundant.vrrp.interva...

[swill]

Github user swill commented on the pull request:

https://github.com/apache/cloudstack/pull/1486#issuecomment-218811415
  
@remibergsma sorry to do this to you again.  can you force push again.  I 
have pushed fixes to jenkins and travis this morning so hopefully we can get 
this all green.

I need some code review on this one too.  Thx...


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Reimplement router.redundant.vrrp.interva...

[remibergsma]

Github user remibergsma commented on the pull request:

https://github.com/apache/cloudstack/pull/1486#issuecomment-218783498
  
Force pushed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Reimplement router.redundant.vrrp.interva...

[swill]

Github user swill commented on the pull request:

https://github.com/apache/cloudstack/pull/1486#issuecomment-217605326
  


### CI RESULTS

```
Tests Run: 85
  Skipped: 0
   Failed: 0
   Errors: 0
 Duration: 8h 49m 25s
```



**Associated Uploads**

**`/tmp/MarvinLogs/DeployDataCenter__May_06_2016_20_02_11_2X0JYY:`**
* 
[dc_entries.obj](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1486/tmp/MarvinLogs/DeployDataCenter__May_06_2016_20_02_11_2X0JYY/dc_entries.obj)
* 
[failed_plus_exceptions.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1486/tmp/MarvinLogs/DeployDataCenter__May_06_2016_20_02_11_2X0JYY/failed_plus_exceptions.txt)
* 
[runinfo.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1486/tmp/MarvinLogs/DeployDataCenter__May_06_2016_20_02_11_2X0JYY/runinfo.txt)

**`/tmp/MarvinLogs/test_network_W1WTK6:`**
* 
[failed_plus_exceptions.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1486/tmp/MarvinLogs/test_network_W1WTK6/failed_plus_exceptions.txt)
* 
[results.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1486/tmp/MarvinLogs/test_network_W1WTK6/results.txt)
* 
[runinfo.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1486/tmp/MarvinLogs/test_network_W1WTK6/runinfo.txt)

**`/tmp/MarvinLogs/test_vpc_routers_CEKKSO:`**
* 
[failed_plus_exceptions.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1486/tmp/MarvinLogs/test_vpc_routers_CEKKSO/failed_plus_exceptions.txt)
* 
[results.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1486/tmp/MarvinLogs/test_vpc_routers_CEKKSO/results.txt)
* 
[runinfo.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1486/tmp/MarvinLogs/test_vpc_routers_CEKKSO/runinfo.txt)


Uploads will be available until `2016-07-07 02:00:00 +0200 CEST`

*Comment created by [`upr comment`](https://github.com/cloudops/upr).*



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Reimplement router.redundant.vrrp.interva...

[rhtyd]

Github user rhtyd commented on the pull request:

https://github.com/apache/cloudstack/pull/1486#issuecomment-216228086
  
@remibergsma can do a push -f again, Travis failed


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Reimplement router.redundant.vrrp.interva...

[remibergsma]

Github user remibergsma commented on the pull request:

https://github.com/apache/cloudstack/pull/1486#issuecomment-216030568
  
Also force pushed this one again.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Reimplement router.redundant.vrrp.interva...

[remibergsma]

Github user remibergsma commented on the pull request:

https://github.com/apache/cloudstack/pull/1486#issuecomment-215988010
  
@swill force pushed


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Reimplement router.redundant.vrrp.interva...

[swill]

Github user swill commented on the pull request:

https://github.com/apache/cloudstack/pull/1486#issuecomment-208909441
  
I am not sure what is going on with Jenkins and Travis now days, but they 
are being very flaky.  Maybe the added load of people being more active is 
messing with them, but it is annoying.  What should we do about this?  Do I 
just keep asking people to force push until everything clears?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Reimplement router.redundant.vrrp.interva...

[remibergsma]

Github user remibergsma commented on the pull request:

https://github.com/apache/cloudstack/pull/1486#issuecomment-208793335
  
@swill force pushed


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Reimplement router.redundant.vrrp.interva...

[remibergsma]

GitHub user remibergsma opened a pull request:

https://github.com/apache/cloudstack/pull/1486

Reimplement router.redundant.vrrp.interval setting

Global setting `router.redundant.vrrp.interval` is not used any more and it 
is now set to a hardcoded 1. 

This results in a failover from master->backup when the backup doesn't hear 
from the master in ~3.6sec. This is a bit too tight, as we've seen failovers 
during live migrations. We could reproduce it in about half of the cases. 
Setting this to setting to 2 (tested it by hardcoding it in the systemvms) 
gives twice as much time and we didn't see issues any more. Instead of updating 
the hardcoded setting from 1 to 2, I reimplemented the global setting by 
sending it to the router with the cmd_line, as the non-VPC router also does.

Background:
Why is the maximum failover time in the example 3.6 seconds? This comes 
from the advertisement interval and the skew time. The default advertisement 
interval is 1 second (configurable in keepalived.conf). The skew time helps to 
keep everyone from trying to transition at once. It is a number between 0 and 
1, based on the formula (256 - priority) / 256

As defined in the RFC, the backup must receive an advertisement from the 
master every (3 * advert_int) + skew_time seconds. If it doesn't hear anything 
from the master, it takes over. With a backup router priority of 100 (as in the 
example), the failover will happen at most 3.6 seconds after the master goes 
down.

Source: http://www.hollenback.net/KeepalivedForNetworkReliability


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/remibergsma/cloudstack 
reimplement-vrrp-setting-47

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/1486.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1486


commit c33358db848faf8c8891e00e0100a2627b177407
Author: Remi Bergsma 
Date:   2016-03-23T15:33:20Z

Have rVPCs use the router.redundant.vrrp.interval setting

It defaults to 1, which is hardcoded in the template:

./cosmic/cosmic-core/systemvm/patches/debian/config/opt/cloud/templates/keepalived.conf.templ

As non-VPC redundant routers use this setting, I think it makes sense to 
use it for rVPCs as well.

We also need a change to pickup the cmd_line parameter and use it in the 
Python code that configures the router.

commit 408478413ad0469265dfa0ce9101d6337f558ab2
Author: Remi Bergsma 
Date:   2016-03-23T15:56:54Z

Configure rVPC for router.redundant.vrrp.interval advert_int setting




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---