[GitHub] cloudstack pull request: noncritical fixes on packaging script

2014-12-05 Thread bhaisaab
Github user bhaisaab commented on the pull request:

https://github.com/apache/cloudstack/pull/51#issuecomment-65822688
  
+1 LGTM.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request: noncritical fixes on packaging script

2014-12-05 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/cloudstack/pull/51


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request: noncritical fixes on packaging script

2014-12-04 Thread K0zka
GitHub user K0zka opened a pull request:

https://github.com/apache/cloudstack/pull/51

noncritical fixes on packaging script

fixed:
- a syntax issue, which was tolerated by bash
- removed an option from usage text

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/K0zka/cloudstack packaging_1

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/51.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #51


commit 2fc3883ac02ea886c078f4e644eefc9504863fb5
Author: Laszlo Hornyak laszlo.horn...@gmail.com
Date:   2014-12-04T06:46:20Z

syntax fix for packaging OSS

Signed-off-by: Laszlo Hornyak laszlo.horn...@gmail.com

commit 6b058b0203813b395cdb7b1167135472cca72245
Author: Laszlo Hornyak laszlo.horn...@gmail.com
Date:   2014-12-04T06:52:29Z

removed -o|--operating-system from the package.sh help text

it does not handle the arguments, it warns for unknown option when using it

Signed-off-by: Laszlo Hornyak laszlo.horn...@gmail.com




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---