[GitHub] cloudstack pull request #1582: CLOUDSTACK-9408 for the move away from downlo...

[DaanHoogland]

Github user DaanHoogland commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1582#discussion_r106675353
  
--- Diff: 
api/src/org/apache/cloudstack/api/response/AutoScaleVmProfileResponse.java ---
@@ -75,6 +75,7 @@
 @Parameter(name = ApiConstants.CS_URL,
type = CommandType.STRING,
description = "the API URL including port of the CloudStack 
Management Server example: http://server.cloud.com:8080/client/api?;)
+// leaving cloud.com reference above as it serves only as an example
--- End diff --

ok, in that perspect you have a point absolutely. The sentence would need 
to be rephrased, then. It now spells "example: http://...;!
Ive been going through the, code reviewing every occurrence of 
cloud.com, back in june!!! just before leaving the project to do some paid 
work ;) (hope my boss is alright with this remark)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request #1582: CLOUDSTACK-9408 for the move away from downlo...

[rafaelweingartner]

Github user rafaelweingartner commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1582#discussion_r106670299
  
--- Diff: 
api/src/org/apache/cloudstack/api/response/AutoScaleVmProfileResponse.java ---
@@ -75,6 +75,7 @@
 @Parameter(name = ApiConstants.CS_URL,
type = CommandType.STRING,
description = "the API URL including port of the CloudStack 
Management Server example: http://server.cloud.com:8080/client/api?;)
+// leaving cloud.com reference above as it serves only as an example
--- End diff --

I agree that it is out of the scope. I just wanted to ask about the idea of 
starting using notations instead of real URLs as examples.

To tell you the truth I have already seen so many time people not thinking 
while seeing examples like this and using a copy/paste working mode that I try 
to avoid it sometimes, just to force people to change the parameters.

It is nothing that you need to change, I just so it, and I wanted to check 
your opinion ;)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request #1582: CLOUDSTACK-9408 for the move away from downlo...

[DaanHoogland]

Github user DaanHoogland commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1582#discussion_r106667548
  
--- Diff: 
api/src/org/apache/cloudstack/api/response/AutoScaleVmProfileResponse.java ---
@@ -75,6 +75,7 @@
 @Parameter(name = ApiConstants.CS_URL,
type = CommandType.STRING,
description = "the API URL including port of the CloudStack 
Management Server example: http://server.cloud.com:8080/client/api?;)
+// leaving cloud.com reference above as it serves only as an example
--- End diff --

I don't see you point Rafael. it would no longer be an example bu a semi 
formal definition.

Also I think it is out of scope to be frank


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request #1582: CLOUDSTACK-9408 for the move away from downlo...

[rafaelweingartner]

Github user rafaelweingartner commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1582#discussion_r105259838
  
--- Diff: 
api/src/org/apache/cloudstack/api/response/AutoScaleVmProfileResponse.java ---
@@ -75,6 +75,7 @@
 @Parameter(name = ApiConstants.CS_URL,
type = CommandType.STRING,
description = "the API URL including port of the CloudStack 
Management Server example: http://server.cloud.com:8080/client/api?;)
+// leaving cloud.com reference above as it serves only as an example
--- End diff --

This examples with URL, what about using notations like: 
http://:[port]/client/api?

I think administrators/operators are familiar with those notations


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request #1582: CLOUDSTACK-9408 for the move away from downlo...

[DaanHoogland]

Github user DaanHoogland commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1582#discussion_r105162233
  
--- Diff: packaging/centos63/cloud.spec ---
@@ -445,7 +445,7 @@ grep -s -q "db.usage.driver=jdbc:mysql" 
"%{_sysconfdir}/%{name}/management/db.pr
 grep -s -q "db.simulator.driver=jdbc:mysql" 
"%{_sysconfdir}/%{name}/management/db.properties" || sed -i -e 
"\$adb.simulator.driver=jdbc:mysql" 
"%{_sysconfdir}/%{name}/management/db.properties"
 
 if [ ! -f 
%{_datadir}/cloudstack-common/scripts/vm/hypervisor/xenserver/vhd-util ] ; then
-echo Please download vhd-util from 
http://download.cloud.com.s3.amazonaws.com/tools/vhd-util and put it in 
+echo Please download vhd-util from 
http://download.apachecloudstack.net/tools/vhd-util and put it in
--- End diff --

@rhtyd yes, we can. At the time we started with this it wasn't clear yet 
what the url would eventually be.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request #1582: CLOUDSTACK-9408 for the move away from downlo...

[rhtyd]

Github user rhtyd commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1582#discussion_r105120559
  
--- Diff: packaging/centos63/cloud.spec ---
@@ -445,7 +445,7 @@ grep -s -q "db.usage.driver=jdbc:mysql" 
"%{_sysconfdir}/%{name}/management/db.pr
 grep -s -q "db.simulator.driver=jdbc:mysql" 
"%{_sysconfdir}/%{name}/management/db.properties" || sed -i -e 
"\$adb.simulator.driver=jdbc:mysql" 
"%{_sysconfdir}/%{name}/management/db.properties"
 
 if [ ! -f 
%{_datadir}/cloudstack-common/scripts/vm/hypervisor/xenserver/vhd-util ] ; then
-echo Please download vhd-util from 
http://download.cloud.com.s3.amazonaws.com/tools/vhd-util and put it in 
+echo Please download vhd-util from 
http://download.apachecloudstack.net/tools/vhd-util and put it in
--- End diff --

@wido @DaanHoogland can we move the binary and install from the new 
download.cloudstack.org alias? Who owns apachecloudstack.net?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request #1582: CLOUDSTACK-9408 for the move away from downlo...

[DaanHoogland]

GitHub user DaanHoogland reopened a pull request:

https://github.com/apache/cloudstack/pull/1582

CLOUDSTACK-9408 for the move away from download.cloud.com

 - commented some occurences of cloud.com as being harmless
  * examples
  * identifiers (internal)
 - changed the URL for vhd-util download
 - changed comments from 'cloud.com' to 'Apache CloudStack'

What remains now is to find all other downloads that occur from the code 
and reconstruct the tree in a save location (atm at cloudstack.apt-get.eu)

We will also want to use a CNAME for download.cloudstack.org which can for 
now point to cloudstack.apt-get.eu and can later be implemented with a redirect 
mechanism to a mirror list.

this should be save to pull in now but we can add the missing parts in this 
PR as well.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/DaanHoogland/cloudstack CLOUDSTACK-9408

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/1582.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1582


commit c443efd7825038c1b42785e13246bbfadd2f08ab
Author: Daan Hoogland 
Date:   2016-06-07T10:20:36Z

CLOUDSTACK-9408 for the move away from download.cloud.com
 - commented some occurences of cloud.com as being harmless
  * examples
  * identifiers (internal)
 - changed the URL for vhd-util download
 - changed comments from 'cloud.com' to 'Apache CloudStack'

commit c4f13fe286e0b53360d4adf2e7b63cca3b6c9549
Author: Daan Hoogland 
Date:   2016-06-07T10:40:38Z

CLOUDSTACK-9408 remove antiquated devcloud project

  as it contains references to cloud.com and is not current

commit 9b7049d6c116a82287fed7bb9201e0344e70a13f
Author: Daan Hoogland 
Date:   2016-06-07T18:10:25Z

CLOUDSTACK-9408 change URLs in templates.sql




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request #1582: CLOUDSTACK-9408 for the move away from downlo...

[DaanHoogland]

Github user DaanHoogland closed the pull request at:

https://github.com/apache/cloudstack/pull/1582


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request #1582: CLOUDSTACK-9408 for the move away from downlo...

[DaanHoogland]

GitHub user DaanHoogland reopened a pull request:

https://github.com/apache/cloudstack/pull/1582

CLOUDSTACK-9408 for the move away from download.cloud.com

 - commented some occurences of cloud.com as being harmless
  * examples
  * identifiers (internal)
 - changed the URL for vhd-util download
 - changed comments from 'cloud.com' to 'Apache CloudStack'

What remains now is to find all other downloads that occur from the code 
and reconstruct the tree in a save location (atm at cloudstack.apt-get.eu)

We will also want to use a CNAME for download.cloudstack.org which can for 
now point to cloudstack.apt-get.eu and can later be implemented with a redirect 
mechanism to a mirror list.

this should be save to pull in now but we can add the missing parts in this 
PR as well.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/DaanHoogland/cloudstack CLOUDSTACK-9408

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/1582.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1582


commit c443efd7825038c1b42785e13246bbfadd2f08ab
Author: Daan Hoogland 
Date:   2016-06-07T10:20:36Z

CLOUDSTACK-9408 for the move away from download.cloud.com
 - commented some occurences of cloud.com as being harmless
  * examples
  * identifiers (internal)
 - changed the URL for vhd-util download
 - changed comments from 'cloud.com' to 'Apache CloudStack'

commit c4f13fe286e0b53360d4adf2e7b63cca3b6c9549
Author: Daan Hoogland 
Date:   2016-06-07T10:40:38Z

CLOUDSTACK-9408 remove antiquated devcloud project

  as it contains references to cloud.com and is not current

commit 9b7049d6c116a82287fed7bb9201e0344e70a13f
Author: Daan Hoogland 
Date:   2016-06-07T18:10:25Z

CLOUDSTACK-9408 change URLs in templates.sql




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request #1582: CLOUDSTACK-9408 for the move away from downlo...

[DaanHoogland]

Github user DaanHoogland closed the pull request at:

https://github.com/apache/cloudstack/pull/1582


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: [GitHub] cloudstack pull request #1582: CLOUDSTACK-9408 for the move away from downlo...

[Daan Hoogland]

So I gave a first stab at changing the url for downloading (
download.cloud.com). Please empty your guns at this. I didn't follow all of
the discussions around this but deemed it important enough to just start
working on it.

On Tue, Jun 7, 2016 at 12:24 PM, DaanHoogland  wrote:

> GitHub user DaanHoogland opened a pull request:
>
> https://github.com/apache/cloudstack/pull/1582
>
> CLOUDSTACK-9408 for the move away from download.cloud.com
>
>  - commented some occurences of cloud.com as being harmless
>   * examples
>   * identifiers (internal)
>  - changed the URL for vhd-util download
>  - changed comments from 'cloud.com' to 'Apache CloudStack'
>
> What remains now is to find all other downloads that occur from the
> code and reconstruct the tree in a save location (atm at
> cloudstack.apt-get.eu)
>
> We will also want to use a CNAME for download.cloudstack.org which
> can for now point to cloudstack.apt-get.eu and can later be implemented
> with a redirect mechanism to a mirror list.
>
> this should be save to pull in now but we can add the missing parts in
> this PR as well.
>
> You can merge this pull request into a Git repository by running:
>
> $ git pull https://github.com/DaanHoogland/cloudstack CLOUDSTACK-9408
>
> Alternatively you can review and apply these changes as the patch at:
>
> https://github.com/apache/cloudstack/pull/1582.patch
>
> To close this pull request, make a commit to your master/trunk branch
> with (at least) the following in the commit message:
>
> This closes #1582
>
> 
> commit c443efd7825038c1b42785e13246bbfadd2f08ab
> Author: Daan Hoogland 
> Date:   2016-06-07T10:20:36Z
>
> CLOUDSTACK-9408 for the move away from download.cloud.com
>  - commented some occurences of cloud.com as being harmless
>   * examples
>   * identifiers (internal)
>  - changed the URL for vhd-util download
>  - changed comments from 'cloud.com' to 'Apache CloudStack'
>
> 
>
>
> ---
> If your project is set up for it, you can reply to this email and have your
> reply appear on GitHub as well. If your project does not have this feature
> enabled and wishes so, or if the feature is enabled but not working, please
> contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
> with INFRA.
> ---
>



-- 
Daan

[GitHub] cloudstack pull request #1582: CLOUDSTACK-9408 for the move away from downlo...

[DaanHoogland]

GitHub user DaanHoogland opened a pull request:

https://github.com/apache/cloudstack/pull/1582

CLOUDSTACK-9408 for the move away from download.cloud.com

 - commented some occurences of cloud.com as being harmless
  * examples
  * identifiers (internal)
 - changed the URL for vhd-util download
 - changed comments from 'cloud.com' to 'Apache CloudStack'

What remains now is to find all other downloads that occur from the code 
and reconstruct the tree in a save location (atm at cloudstack.apt-get.eu)

We will also want to use a CNAME for download.cloudstack.org which can for 
now point to cloudstack.apt-get.eu and can later be implemented with a redirect 
mechanism to a mirror list.

this should be save to pull in now but we can add the missing parts in this 
PR as well.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/DaanHoogland/cloudstack CLOUDSTACK-9408

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/1582.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1582


commit c443efd7825038c1b42785e13246bbfadd2f08ab
Author: Daan Hoogland 
Date:   2016-06-07T10:20:36Z

CLOUDSTACK-9408 for the move away from download.cloud.com
 - commented some occurences of cloud.com as being harmless
  * examples
  * identifiers (internal)
 - changed the URL for vhd-util download
 - changed comments from 'cloud.com' to 'Apache CloudStack'




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---