[GitHub] cloudstack pull request #1775: CLOUDSTACK-9606: While IP address is released...

[rajesh-battala]

Github user rajesh-battala commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1775#discussion_r90640757
  
--- Diff: server/src/com/cloud/network/IpAddressManagerImpl.java ---
@@ -281,6 +284,8 @@
 VpcDao _vpcDao;
 SearchBuilder AssignIpAddressSearch;
 SearchBuilder AssignIpAddressFromPodVlanSearch;
+@Inject
+ResourceTagDao _resourceTagDao;
--- End diff --

Move 287,288 after 284.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request #1775: CLOUDSTACK-9606: While IP address is released...

[rajesh-battala]

Github user rajesh-battala commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1775#discussion_r90640403
  
--- Diff: server/src/com/cloud/network/IpAddressManagerImpl.java ---
@@ -568,6 +573,11 @@ protected boolean cleanupIpResources(long ipId, long 
userId, Account caller) {
 success = false;
 }
 
+//Remove the tags corresponding to IP.
+if(success) {
+_resourceTagDao.removeByIdAndType(ipId, 
ResourceTag.ResourceObjectType.PublicIpAddress);
+}
+
--- End diff --

This extra line can be removed


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request #1775: CLOUDSTACK-9606: While IP address is released...

[rajesh-battala]

Github user rajesh-battala commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1775#discussion_r90640201
  
--- Diff: server/src/com/cloud/network/IpAddressManagerImpl.java ---
@@ -168,6 +168,9 @@
 import com.cloud.vm.dao.NicSecondaryIpDao;
 import com.cloud.vm.dao.UserVmDao;
 import com.cloud.vm.dao.VMInstanceDao;
+import com.cloud.server.ResourceTag;
+import com.cloud.tags.dao.ResourceTagDao;
+
--- End diff --

Remove this extra line


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request #1775: CLOUDSTACK-9606: While IP address is released...

[priyankparihar]

GitHub user priyankparihar opened a pull request:

https://github.com/apache/cloudstack/pull/1775

CLOUDSTACK-9606: While IP address is released, tag are not deleted.



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/priyankparihar/cloudstack CLOUDSTACK-9606

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/1775.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1775


commit 428f9c6acf8eeddca8fc137e7187bef2d773f7f8
Author: Priyank Parihar 
Date:   2016-11-24T11:40:08Z

CLOUDSTACK-9606: While IP address is released, tag are not deleted.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---