[GitHub] cloudstack pull request #1866: Advanced isolated network egress destination ...

[jayapalu]

Github user jayapalu commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1866#discussion_r103863373
  
--- Diff: engine/schema/src/com/cloud/upgrade/dao/Upgrade4920to41000.java 
---
@@ -53,6 +55,7 @@ public boolean supportsRollingUpgrade() {
 
 @Override
 public void performDataMigration(Connection conn) {
+updateSourceCidrs(conn);
--- End diff --

Updated


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request #1866: Advanced isolated network egress destination ...

[kishankavala]

Github user kishankavala commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1866#discussion_r103861501
  
--- Diff: engine/schema/src/com/cloud/upgrade/dao/Upgrade4920to41000.java 
---
@@ -53,6 +55,7 @@ public boolean supportsRollingUpgrade() {
 
 @Override
 public void performDataMigration(Connection conn) {
+updateSourceCidrs(conn);
--- End diff --

Please add comment on why source cidr is updated


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request #1866: Advanced isolated network egress destination ...

[kishankavala]

Github user kishankavala commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1866#discussion_r103861408
  
--- Diff: 
tools/appliance/definitions/systemvmtemplate/install_systemvm_packages.sh ---
@@ -67,6 +67,8 @@ function install_packages() {
 xenstore-utils libxenstore3.0 \
 conntrackd ipvsadm libnetfilter-conntrack3 libnl-3-200 
libnl-genl-3-200 \
 ipcalc \
+ipset \
+openjdk-7-jre-headless \
--- End diff --

Only ipset is required here


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request #1866: Advanced isolated network egress destination ...

[jayapalu]

GitHub user jayapalu opened a pull request:

https://github.com/apache/cloudstack/pull/1866

Advanced isolated network egress destination cidr support added

Added the destination cidr support for the advanced zone isolated network 
egress rule.
With this now user can control both source and destination ip address of 
the egress firewall rules.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/Accelerite/cloudstack egresdcidr

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/1866.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1866


commit e1351a1b2efd31e2546a203092da6bf458973161
Author: Jayapal 
Date:   2016-12-23T09:59:11Z

CLOUDSTACK-9669:egress destination UI changes

commit 45533d16505339fd580349f1b7556270b7dcfc86
Author: Jayapal 
Date:   2016-12-26T05:52:58Z

CLOUDSTACK-9669:egress destination cidr VR python script changes

commit 56286970e3a6fb3cc618a33aac6dd2c2516a3b49
Author: Jayapal 
Date:   2016-12-26T07:08:53Z

CLOUDSTACK-9669:egress destination API and orchestration changes




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---