[GitHub] cloudstack pull request #1875: CLOUDSTACK-8608: [VMware] System VMs failed t...

[sureshanaparti]

Github user sureshanaparti commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1875#discussion_r105573382
  
--- Diff: 
plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/manager/VmwareManagerImpl.java
 ---
@@ -707,6 +709,23 @@ private String setupMountPoint(String parent) {
 return mountPoint;
 }
 
+@Override
+public synchronized void setSystemVmTmpltPermission(String mountPoint) 
{
+if (!s_isSystemVmTmpltPermissionSet) {
+s_logger.debug("Set permissions for " + mountPoint);
+String result = null;
+final String systemVmTmpltPermissions = "0777";
+Script script = new Script(true, "chmod", _timeout, s_logger);
+script.add("-R", systemVmTmpltPermissions, mountPoint);
--- End diff --

@SudharmaJain Moved to TemplateConstants.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request #1875: CLOUDSTACK-8608: [VMware] System VMs failed t...

[SudharmaJain]

Github user SudharmaJain commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1875#discussion_r104600403
  
--- Diff: 
plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/manager/VmwareManagerImpl.java
 ---
@@ -707,6 +709,23 @@ private String setupMountPoint(String parent) {
 return mountPoint;
 }
 
+@Override
+public synchronized void setSystemVmTmpltPermission(String mountPoint) 
{
+if (!s_isSystemVmTmpltPermissionSet) {
+s_logger.debug("Set permissions for " + mountPoint);
+String result = null;
+final String systemVmTmpltPermissions = "0777";
+Script script = new Script(true, "chmod", _timeout, s_logger);
+script.add("-R", systemVmTmpltPermissions, mountPoint);
--- End diff --

@sureshanaparti It would be better if you  can move it to TemplateConstants.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request #1875: CLOUDSTACK-8608: [VMware] System VMs failed t...

[sureshanaparti]

Github user sureshanaparti commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1875#discussion_r104373535
  
--- Diff: 
plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/manager/VmwareManagerImpl.java
 ---
@@ -707,6 +709,23 @@ private String setupMountPoint(String parent) {
 return mountPoint;
 }
 
+@Override
+public synchronized void setSystemVmTmpltPermission(String mountPoint) 
{
+if (!s_isSystemVmTmpltPermissionSet) {
+s_logger.debug("Set permissions for " + mountPoint);
+String result = null;
+final String systemVmTmpltPermissions = "0777";
+Script script = new Script(true, "chmod", _timeout, s_logger);
+script.add("-R", systemVmTmpltPermissions, mountPoint);
--- End diff --

@SudharmaJain Used the string as suggested instead of hardcoded value for 
permissions.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request #1875: CLOUDSTACK-8608: [VMware] System VMs failed t...

[sureshanaparti]

GitHub user sureshanaparti opened a pull request:

https://github.com/apache/cloudstack/pull/1875

CLOUDSTACK-8608: [VMware] System VMs failed to start due to permissions 
issue. Provide permissions to template folder when mounted on management server.

[VMware] System VMs failed to start due to permissions issue. Provide 
permissions to template folder when mounted on management server.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/Accelerite/cloudstack CLOUDSTACK-8608

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/1875.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1875


commit c1c77a9d7cdc472962050c7eeea0ea51ddc16bda
Author: Suresh Kumar Anaparti 
Date:   2016-12-29T09:10:01Z

CLOUDSTACK-8608: [VMware] System VMs failed to start due to permissions 
issue. Provide permissions to template folder when mounted on management server.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---