[GitHub] cloudstack pull request #1934: [CLOUDSTACK-9772] Template: perform a HEAD re...

[remibergsma]

Github user remibergsma commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1934#discussion_r100702832
  
--- Diff: utils/src/main/java/com/cloud/utils/UriUtils.java ---
@@ -200,37 +198,27 @@ public static String getUpdateUri(String url, boolean 
encrypt) {
 }
 
 // Get the size of a file from URL response header.
-public static Long getRemoteSize(String url) {
-Long remoteSize = (long)0;
+public static long getRemoteSize(String url) {
--- End diff --

@marcaurele I think this needs to be changed back to Long, or else the 
method cannot be found as it is called with type Long.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request #1934: [CLOUDSTACK-9772] Template: perform a HEAD re...

[marcaurele]

GitHub user marcaurele opened a pull request:

https://github.com/apache/cloudstack/pull/1934

[CLOUDSTACK-9772] Template: perform a HEAD request to check file size from 
a URL

Signed-off-by: Marc-Aurèle Brothier 

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/exoscale/cloudstack fix/CLOUDSTACK-9772

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/1934.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1934


commit 46fb454f4deb6c36f52a6e943b1f23c45508ab04
Author: Marc-Aurèle Brothier 
Date:   2017-02-06T12:51:14Z

Template: perform a HEAD request to check file size from a URL

Signed-off-by: Marc-Aurèle Brothier 




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---